ebbf2fbdba3daa1089c03bf44edf723f2a6b045f
[modest] / src / modest-account-mgr.c
1 /* Copyright (c) 2006, Nokia Corporation
2  * All rights reserved.
3  *
4  * Redistribution and use in source and binary forms, with or without
5  * modification, are permitted provided that the following conditions are
6  * met:
7  *
8  * * Redistributions of source code must retain the above copyright
9  *   notice, this list of conditions and the following disclaimer.
10  * * Redistributions in binary form must reproduce the above copyright
11  *   notice, this list of conditions and the following disclaimer in the
12  *   documentation and/or other materials provided with the distribution.
13  * * Neither the name of the Nokia Corporation nor the names of its
14  *   contributors may be used to endorse or promote products derived from
15  *   this software without specific prior written permission.
16  *
17  * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS
18  * IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED
19  * TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A
20  * PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER
21  * OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
22  * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
23  * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
24  * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF
25  * LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
26  * NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
27  * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
28  */
29
30 #include <string.h>
31 #include <modest-marshal.h>
32 #include <modest-account-mgr.h>
33 #include <modest-account-mgr-priv.h>
34 #include <modest-account-mgr-helpers.h>
35
36 /* 'private'/'protected' functions */
37 static void modest_account_mgr_class_init (ModestAccountMgrClass * klass);
38 static void modest_account_mgr_init       (ModestAccountMgr * obj);
39 static void modest_account_mgr_finalize   (GObject * obj);
40
41 /* list my signals */
42 enum {
43         ACCOUNT_CHANGED_SIGNAL,
44         ACCOUNT_REMOVED_SIGNAL,
45         LAST_SIGNAL
46 };
47
48
49 /* globals */
50 static GObjectClass *parent_class = NULL;
51 static guint signals[LAST_SIGNAL] = {0};
52
53 static void
54 on_key_change (ModestConf *conf, const gchar *key, ModestConfEvent event, gpointer user_data)
55 {
56         ModestAccountMgr *self;
57         ModestAccountMgrPrivate *priv;
58
59         gchar *account;
60         gboolean is_account_key, is_server_account;
61         gboolean enabled;
62
63         self = MODEST_ACCOUNT_MGR (user_data);
64         priv = MODEST_ACCOUNT_MGR_GET_PRIVATE (self);
65         
66         account = _modest_account_mgr_account_from_key (key, &is_account_key, &is_server_account);
67
68         /* if this is not an account-related key change, ignore */
69         if (!account)
70                 return;
71
72         /* account was removed -- emit this, even if the account was disabled */
73         if (is_account_key && event == MODEST_CONF_EVENT_KEY_UNSET) {
74                 g_signal_emit (G_OBJECT(self), signals[ACCOUNT_REMOVED_SIGNAL], 0,
75                                account, is_server_account);
76                 g_free (account);
77                 return;
78         }
79
80         /* is this account enabled? */
81         if (is_server_account)
82                 enabled = TRUE;
83         else 
84                 enabled = modest_account_mgr_get_enabled (self, account);
85
86         /* account was changed.
87          * and always notify when enabled/disabled changes
88          */
89         if (enabled || g_str_has_suffix (key, MODEST_ACCOUNT_ENABLED)) 
90                 g_signal_emit (G_OBJECT(self), signals[ACCOUNT_CHANGED_SIGNAL], 0,
91                                account, key, is_server_account);
92
93         g_free (account);
94 }
95
96
97 GType
98 modest_account_mgr_get_type (void)
99 {
100         static GType my_type = 0;
101
102         if (!my_type) {
103                 static const GTypeInfo my_info = {
104                         sizeof (ModestAccountMgrClass),
105                         NULL,   /* base init */
106                         NULL,   /* base finalize */
107                         (GClassInitFunc) modest_account_mgr_class_init,
108                         NULL,   /* class finalize */
109                         NULL,   /* class data */
110                         sizeof (ModestAccountMgr),
111                         1,      /* n_preallocs */
112                         (GInstanceInitFunc) modest_account_mgr_init,
113                         NULL
114                 };
115
116                 my_type = g_type_register_static (G_TYPE_OBJECT,
117                                                   "ModestAccountMgr",
118                                                   &my_info, 0);
119         }
120         return my_type;
121 }
122
123 static void
124 modest_account_mgr_class_init (ModestAccountMgrClass * klass)
125 {
126         GObjectClass *gobject_class;
127         gobject_class = (GObjectClass *) klass;
128
129         parent_class = g_type_class_peek_parent (klass);
130         gobject_class->finalize = modest_account_mgr_finalize;
131
132         g_type_class_add_private (gobject_class,
133                                   sizeof (ModestAccountMgrPrivate));
134
135         /* signal definitions */
136         signals[ACCOUNT_REMOVED_SIGNAL] =
137                 g_signal_new ("account_removed",
138                               G_TYPE_FROM_CLASS (klass),
139                               G_SIGNAL_RUN_FIRST,
140                               G_STRUCT_OFFSET(ModestAccountMgrClass,account_removed),
141                               NULL, NULL,
142                               modest_marshal_VOID__STRING_BOOLEAN,
143                               G_TYPE_NONE, 2, G_TYPE_STRING, G_TYPE_BOOLEAN);
144         signals[ACCOUNT_CHANGED_SIGNAL] =
145                 g_signal_new ("account_changed",
146                                G_TYPE_FROM_CLASS (klass),
147                               G_SIGNAL_RUN_FIRST,
148                               G_STRUCT_OFFSET(ModestAccountMgrClass,account_changed),
149                               NULL, NULL,
150                               modest_marshal_VOID__STRING_STRING_BOOLEAN,
151                               G_TYPE_NONE, 3, G_TYPE_STRING, G_TYPE_STRING, G_TYPE_BOOLEAN);
152 }
153
154
155 static void
156 modest_account_mgr_init (ModestAccountMgr * obj)
157 {
158         ModestAccountMgrPrivate *priv =
159                 MODEST_ACCOUNT_MGR_GET_PRIVATE (obj);
160
161         priv->modest_conf = NULL;
162 }
163
164 static void
165 modest_account_mgr_finalize (GObject * obj)
166 {
167         ModestAccountMgrPrivate *priv =
168                 MODEST_ACCOUNT_MGR_GET_PRIVATE (obj);
169
170         if (priv->modest_conf) {
171                 g_object_unref (G_OBJECT(priv->modest_conf));
172                 priv->modest_conf = NULL;
173         }
174
175         G_OBJECT_CLASS(parent_class)->finalize (obj);
176 }
177
178 ModestAccountMgr *
179 modest_account_mgr_new (ModestConf * conf)
180 {
181         GObject *obj;
182         ModestAccountMgrPrivate *priv;
183
184         g_return_val_if_fail (conf, NULL);
185
186         obj = G_OBJECT (g_object_new (MODEST_TYPE_ACCOUNT_MGR, NULL));
187         priv = MODEST_ACCOUNT_MGR_GET_PRIVATE (obj);
188
189         g_object_ref (G_OBJECT(conf));
190         priv->modest_conf = conf;
191
192         g_signal_connect (G_OBJECT (conf), "key_changed",
193                           G_CALLBACK (on_key_change),
194                           obj);
195         
196         return MODEST_ACCOUNT_MGR (obj);
197 }
198
199
200 static const gchar *
201 null_means_empty (const gchar * str)
202 {
203         return str ? str : "";
204 }
205
206
207 gboolean
208 modest_account_mgr_add_account (ModestAccountMgr *self,
209                                 const gchar *name,
210                                 const gchar *store_account,
211                                 const gchar *transport_account,
212                                 GError **err)
213 {
214         ModestAccountMgrPrivate *priv;
215         gchar *key;
216         gboolean ok;
217
218         g_return_val_if_fail (self, FALSE);
219         g_return_val_if_fail (name, FALSE);
220         g_return_val_if_fail (strchr(name, '/') == NULL, FALSE);
221         
222         priv = MODEST_ACCOUNT_MGR_GET_PRIVATE (self);
223         
224         /*
225          * we create the account by adding an account 'dir', with the name <name>,
226          * and in that the 'display_name' string key
227          */
228         key = _modest_account_mgr_get_account_keyname (name, MODEST_ACCOUNT_DISPLAY_NAME, FALSE);
229         if (modest_account_mgr_account_exists (self, key, FALSE, err)) {
230                 g_printerr ("modest: account already exists\n");
231                 g_free (key);
232                 return FALSE;
233         }
234         
235         ok = modest_conf_set_string (priv->modest_conf, key, name, err);
236         g_free (key);
237         if (!ok) {
238                 g_printerr ("modest: cannot set display name\n");
239                 return FALSE;
240         }
241         
242         if (store_account) {
243                 key = _modest_account_mgr_get_account_keyname (name, MODEST_ACCOUNT_STORE_ACCOUNT, FALSE);
244                 ok = modest_conf_set_string (priv->modest_conf, key, store_account, err);
245                 g_free (key);
246                 if (!ok) {
247                         g_printerr ("modest: failed to set store account '%s'\n",
248                                 store_account);
249                         return FALSE;
250                 }
251         }
252
253         if (transport_account) {
254                 key = _modest_account_mgr_get_account_keyname (name, MODEST_ACCOUNT_TRANSPORT_ACCOUNT, FALSE);
255                 ok = modest_conf_set_string (priv->modest_conf, key, transport_account, err);
256                 g_free (key);
257                 if (!ok) {
258                         g_printerr ("modest: failed to set transport account '%s'\n",
259                                 transport_account);
260                         return FALSE;
261                 }
262         }
263         modest_account_mgr_set_enabled (self, name, TRUE);
264         
265         return TRUE;
266 }
267
268
269
270
271 gboolean
272 modest_account_mgr_add_server_account (ModestAccountMgr * self,
273                                        const gchar * name, const gchar *hostname,
274                                        const gchar * username, const gchar * password,
275                                        ModestProtocol proto)
276 {
277         ModestAccountMgrPrivate *priv;
278         gchar *key;
279         ModestProtocolType proto_type;
280         
281         g_return_val_if_fail (self, FALSE);
282         g_return_val_if_fail (name, FALSE);
283         g_return_val_if_fail (strchr(name, '/') == NULL, FALSE);
284
285         proto_type = modest_protocol_info_get_protocol_type (proto);
286         g_return_val_if_fail (proto_type == MODEST_PROTOCOL_TYPE_TRANSPORT ||
287                               proto_type == MODEST_PROTOCOL_TYPE_STORE, FALSE);
288                               
289         priv = MODEST_ACCOUNT_MGR_GET_PRIVATE (self);
290         
291         /* hostname */
292         key = _modest_account_mgr_get_account_keyname (name, MODEST_ACCOUNT_HOSTNAME, TRUE);
293         if (modest_conf_key_exists (priv->modest_conf, key, NULL)) {
294                 g_printerr ("modest: server account '%s' already exists", name);
295                 g_free (key);
296                 return FALSE;
297         }
298         
299         modest_conf_set_string (priv->modest_conf, key, null_means_empty(hostname), NULL);
300         g_free (key);
301
302         /* username */
303         key = _modest_account_mgr_get_account_keyname (name, MODEST_ACCOUNT_USERNAME, TRUE);
304         modest_conf_set_string (priv->modest_conf, key, null_means_empty (username), NULL);
305         g_free (key);
306
307         /* password */
308         key = _modest_account_mgr_get_account_keyname (name, MODEST_ACCOUNT_PASSWORD, TRUE);
309         modest_conf_set_string (priv->modest_conf, key, null_means_empty (password), NULL);
310         g_free (key);
311
312         /* proto */
313         key = _modest_account_mgr_get_account_keyname (name, MODEST_ACCOUNT_PROTO, TRUE);
314         modest_conf_set_string (priv->modest_conf, key,
315                                 modest_protocol_info_get_protocol_name(proto),
316                                 NULL);
317         g_free (key);
318         
319         return TRUE;
320 }
321
322
323
324 gboolean
325 modest_account_mgr_remove_account (ModestAccountMgr * self,
326                                    const gchar * name,
327                                    gboolean server_account,
328                                    GError ** err)
329 {
330         ModestAccountMgrPrivate *priv;
331         gchar *key;
332         gboolean retval;
333
334         g_return_val_if_fail (self, FALSE);
335         g_return_val_if_fail (name, FALSE);
336
337         if (!modest_account_mgr_account_exists (self, name, server_account, err)) {
338                 g_printerr ("modest: account '%s' does not exist\n", name);
339                 return FALSE;
340         }
341
342         priv = MODEST_ACCOUNT_MGR_GET_PRIVATE (self);
343         key = _modest_account_mgr_get_account_keyname (name, NULL, server_account);
344
345         retval = modest_conf_remove_key (priv->modest_conf, key, NULL);
346
347         g_free (key);
348         return retval;
349 }
350
351
352
353 /* strip the first /n/ character from each element
354  * caller must make sure all elements are strings with
355  * length >= n, and also that data can be freed.
356  * change is in-place
357  */
358 static void
359 strip_prefix_from_elements (GSList * lst, guint n)
360 {
361         while (lst) {
362                 memmove (lst->data, lst->data + n,
363                          strlen(lst->data) - n + 1);
364                 lst = lst->next;
365         }
366 }
367
368
369 GSList*
370 modest_account_mgr_search_server_accounts (ModestAccountMgr * self,
371                                            const gchar * account_name,
372                                            ModestProtocolType type,
373                                            ModestProtocol proto)
374 {
375         GSList *accounts;
376         GSList *cursor;
377         ModestAccountMgrPrivate *priv;
378         gchar *key;
379         GError *err = NULL;
380         
381         g_return_val_if_fail (self, NULL);
382
383         if (proto != MODEST_PROTOCOL_UNKNOWN) {
384                 ModestProtocolType proto_type;
385                 proto_type = modest_protocol_info_get_protocol_type (proto);
386                 g_return_val_if_fail (proto_type == MODEST_PROTOCOL_TYPE_TRANSPORT ||
387                                       proto_type == MODEST_PROTOCOL_TYPE_STORE, NULL);
388         }
389         
390         key      = _modest_account_mgr_get_account_keyname (account_name, NULL, TRUE);
391         priv     = MODEST_ACCOUNT_MGR_GET_PRIVATE (self);
392         
393         /* get the list of all server accounts */
394         accounts = modest_conf_list_subkeys (priv->modest_conf, key, &err);
395         if (err) {
396                 g_error_free (err);
397                 g_printerr ("modest: failed to get subkeys for '%s'\n", key);
398                 return NULL;
399         }
400         
401         /* filter out the ones with the wrong protocol */
402         /* we could optimize for unknown proto / unknown type, but it will only
403          * make the code more complex */
404         cursor = accounts;
405         while (cursor) { 
406                 gchar *account   = _modest_account_mgr_account_from_key ((gchar*)cursor->data, NULL, NULL);
407                 gchar *acc_proto = modest_account_mgr_get_string (self, account, MODEST_ACCOUNT_PROTO,
408                                                                   TRUE, NULL);
409                 ModestProtocol     this_proto = modest_protocol_info_get_protocol (acc_proto);
410                 ModestProtocolType this_type  = modest_protocol_info_get_protocol_type (this_proto);
411
412                 if ((this_type  != MODEST_PROTOCOL_TYPE_UNKNOWN && this_type  != type) ||
413                     (this_proto != MODEST_PROTOCOL_UNKNOWN      && this_proto != proto)) {
414                         GSList *nxt = cursor->next;
415                         accounts = g_slist_delete_link (accounts, cursor);
416                         cursor = nxt;
417                 } else
418                         cursor = cursor->next;
419                 
420                 g_free (account);
421                 g_free (acc_proto);
422         }
423         
424         /* +1 because we must remove the ending '/' as well */
425         strip_prefix_from_elements (accounts, strlen(key)+1);
426         return accounts;        
427 }
428
429
430 GSList*
431 modest_account_mgr_account_names (ModestAccountMgr * self, GError ** err)
432 {
433         GSList *accounts;
434         ModestAccountMgrPrivate *priv;
435         const size_t prefix_len = strlen (MODEST_ACCOUNT_NAMESPACE "/");
436
437         g_return_val_if_fail (self, NULL);
438
439         priv = MODEST_ACCOUNT_MGR_GET_PRIVATE (self);
440
441         accounts = modest_conf_list_subkeys (priv->modest_conf,
442                                              MODEST_ACCOUNT_NAMESPACE, err);
443         
444         strip_prefix_from_elements (accounts, prefix_len);
445         return accounts;
446 }
447
448
449 gchar *
450 modest_account_mgr_get_string (ModestAccountMgr *self, const gchar *name,
451                                const gchar *key, gboolean server_account, GError **err) {
452
453         ModestAccountMgrPrivate *priv;
454
455         gchar *keyname;
456         gchar *retval;
457
458         g_return_val_if_fail (self, NULL);
459         g_return_val_if_fail (name, NULL);
460         g_return_val_if_fail (key, NULL);
461
462         keyname = _modest_account_mgr_get_account_keyname (name, key, server_account);
463         
464         priv = MODEST_ACCOUNT_MGR_GET_PRIVATE (self);
465         retval = modest_conf_get_string (priv->modest_conf, keyname, err);
466         g_free (keyname);
467
468         return retval;
469 }
470
471
472 gint
473 modest_account_mgr_get_int (ModestAccountMgr *self, const gchar *name,
474                             const gchar *key, gboolean server_account, GError **err)
475 {
476         ModestAccountMgrPrivate *priv;
477
478         gchar *keyname;
479         gint retval;
480
481         g_return_val_if_fail (self, -1);
482         g_return_val_if_fail (name, -1);
483         g_return_val_if_fail (key, -1);
484
485         keyname = _modest_account_mgr_get_account_keyname (name, key, server_account);
486
487         priv = MODEST_ACCOUNT_MGR_GET_PRIVATE (self);
488         retval = modest_conf_get_int (priv->modest_conf, keyname, err);
489         g_free (keyname);
490
491         return retval;
492 }
493
494
495
496 gboolean
497 modest_account_mgr_get_bool (ModestAccountMgr * self, const gchar *account,
498                              const gchar * key, gboolean server_account, GError ** err)
499 {
500         ModestAccountMgrPrivate *priv;
501
502         gchar *keyname;
503         gboolean retval;
504
505         g_return_val_if_fail (self, FALSE);
506         g_return_val_if_fail (account, FALSE);
507         g_return_val_if_fail (key, FALSE);
508
509         keyname = _modest_account_mgr_get_account_keyname (account, key, server_account);
510         
511         priv = MODEST_ACCOUNT_MGR_GET_PRIVATE (self);
512         retval = modest_conf_get_bool (priv->modest_conf, keyname, err);
513                 
514         g_free (keyname);
515
516         return retval;
517 }
518
519
520 gboolean
521 modest_account_mgr_set_string (ModestAccountMgr * self, const gchar * name,
522                                const gchar * key, const gchar * val,
523                                gboolean server_account, GError ** err)
524 {
525         ModestAccountMgrPrivate *priv;
526
527         gchar *keyname;
528         gboolean retval;
529
530         g_return_val_if_fail (self, FALSE);
531         g_return_val_if_fail (name, FALSE);
532         g_return_val_if_fail (key, FALSE);
533
534         keyname = _modest_account_mgr_get_account_keyname (name, key, server_account);
535         
536         priv = MODEST_ACCOUNT_MGR_GET_PRIVATE (self);
537
538         retval = modest_conf_set_string (priv->modest_conf, keyname, val,
539                                          err);
540
541         g_free (keyname);
542         return retval;
543 }
544
545
546 gboolean
547 modest_account_mgr_set_int (ModestAccountMgr * self, const gchar * name,
548                             const gchar * key, int val, gboolean server_account,
549                             GError ** err)
550 {
551         ModestAccountMgrPrivate *priv;
552
553         gchar *keyname;
554         gboolean retval;
555
556         g_return_val_if_fail (self, FALSE);
557         g_return_val_if_fail (name, FALSE);
558         g_return_val_if_fail (key, FALSE);
559
560         keyname = _modest_account_mgr_get_account_keyname (name, key, server_account);
561         
562         priv = MODEST_ACCOUNT_MGR_GET_PRIVATE (self);
563
564         retval = modest_conf_set_int (priv->modest_conf, keyname, val, err);
565
566         g_free (keyname);
567         return retval;
568 }
569
570
571
572 gboolean
573 modest_account_mgr_set_bool (ModestAccountMgr * self, const gchar * name,
574                              const gchar * key, gboolean val, gboolean server_account, 
575                              GError ** err)
576 {
577         ModestAccountMgrPrivate *priv;
578
579         gchar *keyname;
580         gboolean retval;
581
582         g_return_val_if_fail (self, FALSE);
583         g_return_val_if_fail (name, FALSE);
584         g_return_val_if_fail (key, FALSE);
585
586         keyname = _modest_account_mgr_get_account_keyname (name, key, server_account);
587
588         priv = MODEST_ACCOUNT_MGR_GET_PRIVATE (self);
589
590         retval = modest_conf_set_bool (priv->modest_conf, keyname, val, err);
591
592         g_free (keyname);
593         return retval;
594 }
595
596 void 
597 modest_account_mgr_set_list (ModestAccountMgr *self,
598                              const gchar *name,
599                              const gchar *key,
600                              GSList *val,
601                              ModestConfValueType list_type,
602                              gboolean server_account,
603                              GError **err)
604 {
605         ModestAccountMgrPrivate *priv;
606         gchar *keyname;
607         
608         g_return_if_fail (self);
609         g_return_if_fail (name);
610         g_return_if_fail (key);
611         g_return_if_fail (val);
612
613         keyname = _modest_account_mgr_get_account_keyname (name, key, server_account);
614         
615         priv = MODEST_ACCOUNT_MGR_GET_PRIVATE (self);
616         modest_conf_set_list (priv->modest_conf, keyname, val, list_type, err);
617         g_free (keyname);
618 }
619
620 gboolean
621 modest_account_mgr_account_exists (ModestAccountMgr * self, const gchar * name,
622                                    gboolean server_account, GError ** err)
623 {
624         ModestAccountMgrPrivate *priv;
625
626         gchar *keyname;
627         gboolean retval;
628
629         g_return_val_if_fail (self, FALSE);
630         g_return_val_if_fail (name, FALSE);
631
632         keyname = _modest_account_mgr_get_account_keyname (name, NULL, server_account);
633
634         priv = MODEST_ACCOUNT_MGR_GET_PRIVATE (self);
635         retval = modest_conf_key_exists (priv->modest_conf, keyname, err);
636
637         g_free (keyname);
638         return retval;
639 }
640
641
642 GSList * 
643 modest_account_mgr_get_list (ModestAccountMgr *self,
644                              const gchar *name,
645                              const gchar *key,
646                              ModestConfValueType list_type,
647                              gboolean server_account,
648                              GError **err)
649 {
650         ModestAccountMgrPrivate *priv;
651
652         gchar *keyname;
653         GSList *retval;
654         
655         g_return_val_if_fail (self, NULL);
656         g_return_val_if_fail (name, NULL);
657         g_return_val_if_fail (key, NULL);
658
659         keyname = _modest_account_mgr_get_account_keyname (name, key, server_account);
660         
661         priv = MODEST_ACCOUNT_MGR_GET_PRIVATE (self);
662         retval = modest_conf_get_list (priv->modest_conf, keyname, list_type, err);
663         g_free (keyname);
664
665         return retval;
666 }
667
668
669 gboolean 
670 modest_account_mgr_unset (ModestAccountMgr *self,
671                           const gchar *name,
672                           const gchar *key,
673                           gboolean server_account,
674                           GError **err)
675 {
676         ModestAccountMgrPrivate *priv;
677
678         gchar *keyname;
679         gboolean retval;
680
681         g_return_val_if_fail (self, FALSE);
682         g_return_val_if_fail (name, FALSE);
683         g_return_val_if_fail (key, FALSE);
684
685         keyname = _modest_account_mgr_get_account_keyname (name, key, server_account);
686
687         priv = MODEST_ACCOUNT_MGR_GET_PRIVATE (self);
688         retval = modest_conf_remove_key (priv->modest_conf, keyname, err);
689
690         g_free (keyname);
691         return retval;
692 }