2007-04-18 Murray Cumming <murrayc@murrayc.com>
[modest] / ChangeLog2
index 1890ab6..0b229bc 100644 (file)
@@ -1,3 +1,133 @@
+2007-04-18  Murray Cumming  <murrayc@murrayc.com>
+
+       * src/widgets/Makefile.am:
+       * src/widgets/modest-limit-retrieve-combo-box.c:
+       * src/widgets/modest-limit-retrieve-combo-box.h:
+       * src/widgets/modest-retrieve-combo-box.c:
+       * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in 
+       the account settings dialog.
+       
+       * src/modest-defs.h:
+       * src/modest-account-mgr-helpers.h:
+       * src/modest-account-mgr-helpers.c:
+       (modest_server_account_get_option_secure_auth),
+       (modest_server_account_set_option_secure_auth):
+       * src/modest-account-mgr.c:
+       (modest_account_mgr_add_server_account):
+       Use the existing AUTH_MECH conf key for the secure-auth setting, 
+       instead of putting it in the list options, because this was actually used already.
+       
+       * src/maemo/modest-account-settings-dialog.c:
+       (create_page_account_details),
+       (modest_account_settings_dialog_set_account_name),
+       (save_configuration):
+       * src/maemo/modest-account-settings-dialog.h:
+       Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
+       Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
+
+2007-04-18  Murray Cumming  <murrayc@murrayc.com>
+
+       * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
+       * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
+       Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
+
+       * src/modest-defs.h:
+       * src/maemo/modest-account-settings-dialog.c:
+       (create_page_incoming), (on_combo_outgoing_security_changed),
+       (on_combo_incoming_security_changed), (create_page_outgoing),
+       (modest_account_settings_dialog_set_account_name),
+       (save_configuration): Load/Save the port number, and change it when the 
+       security combo changes, to suitable defaults.
+
+2007-04-17  Murray Cumming  <murrayc@murrayc.com>
+
+       * src/modest-account-mgr.c:
+       (modest_account_mgr_add_server_account): Set the security and secure-auth 
+       options, and add a comment saying that the other camel-specific options should be 
+       removed in future.
+
+2007-04-17  Murray Cumming  <murrayc@murrayc.com>
+
+       * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something, 
+       found by valgrind.
+       * src/modest-tny-account-store.c: (account_list_free),
+       (on_account_changed): Add a TODO comment about a valgrind error, caused by using 
+       cursor->data after unreffing it. But there is some strange stuff there so it might not be 
+       easy to fix.
+
+2007-04-17  Murray Cumming  <murrayc@murrayc.com>
+
+       * src/modest-protocol-info.c:
+       * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it 
+       is required by our UI spec. Maybe something in our implementation will use this eventually.
+       * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c: 
+       (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value 
+       instead of the previous 0 placeholder.
+       
+       * src/modest-defs.h: Added gconf list pair key names and value strings for the security and 
+       secure-auth settings.
+       * src/modest-account-mgr-helpers.h:
+       * src/modest-account-mgr-helpers.c:
+       (modest_server_account_data_get_option_secure_auth),
+       (modest_server_account_set_option_secure_auth),
+       (modest_server_account_data_get_option_security),
+       (modest_server_account_set_option_security): Added this API for getting and setting the security 
+       and secure-auth settings.
+       
+       * src/maemo/modest-account-settings-dialog.h:
+       * src/maemo/modest-account-settings-dialog.c:
+       (modest_account_settings_dialog_finalize), (check_data),
+       (on_response): Store the original title as well as the name, to avoid unnececessary warnings 
+       about changing titles.
+       (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
+       (save_configuration): Save the security and secure-auth settings.
+
+       * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this 
+       is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
+
+2007-04-17  Murray Cumming  <murrayc@murrayc.com>
+
+       * src/modest-defs.h: 
+       * src/modest-account-mgr.c:
+       (modest_account_mgr_add_server_account):
+       Added and used defines for the options key and value pair strings, 
+       that are used so far, though they do not seem to correspond to anything in our 
+       UI specs or ModestProtocol enum.
+       
+       * src/modest-account-mgr-helpers.h:
+       * src/modest-account-mgr-helpers.c:
+       (compare_option_strings_for_name),
+       (modest_server_account_data_get_option_value),
+       (modest_server_account_data_get_option_bool),
+       (modest_account_mgr_get_server_account_option):
+       Added helper functions for parsing the options GSList.
+
+2007-04-16  Murray Cumming  <murrayc@murrayc.com>
+
+       * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial 
+       display name is based on the supplied account name.
+       * src/modest-account-mgr.c:
+       * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(), 
+       with an inefficient, but good-enough, implementation.
+       
+       * src/maemo/easysetup/modest-easysetup-wizard.c:
+       (create_page_account_details), (on_before_next), (create_account): 
+       Check for existing display names rather than (non-user-visible) account names, and just 
+       create and set a unique account name at the end.
+       
+       * src/maemo/modest-account-settings-dialog.c:
+       (modest_account_settings_dialog_init),
+       (modest_account_settings_dialog_set_account_name),
+       (create_page_incoming): Show the display name, instead of the account name.
+       (on_response): Do some (not all) extra checks, as in the UI spec.
+       (save_configuration): Save the display name if it was changed.
+
+2007-04-16  Murray Cumming  <murrayc@murrayc.com>
+
+       * po/en_GB.po: Added needed logical ID and translation.
+       * src/widgets/modest-account-view.c: (on_account_default_toggled),
+       (init_view): Made the is-default column clicking work.
+
 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 
        * configure.ac: