+2007-06-08 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
+ Improve the error dialog to show Incorrect Account Settings, which seems
+ clearer, and say that the internal error message (to be removed from the
+ dialog later) is often misleading.
+ I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
+
+ * src/modest-tny-account.c:
+ (modest_tny_account_new_from_server_account): Uncomment the printf of the
+ URL because this is so useful for debugging on the device.
+
+ * src/widgets/modest-serversecurity-combo-box.c:
+ (modest_serversecurity_combo_box_fill): Correct a logical ID.
+
+2007-06-08 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-mail-operation.c:
+ (modest_mail_operation_send_new_mail):
+ Added a comment about a nasty but apparently harmless message. Details
+ added to the wiki g_warnings() page.
+
+2007-06-08 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
+ (modest_tny_send_queue_class_init):
+ Do not use the priv struct because it is empty, to avoid g_warnings
+ about a non-existant priv struct.
+
+ * src/modest-tny-account-store.c:
+ (modest_tny_account_store_get_server_account),
+ (modest_tny_account_store_get_transport_account_for_open_connection
+ ): Do not try to get transport server accounts for local folders,
+ because they don't have any. This avoids a g_warning().
+
+ * src/maemo/modest-main-window.c:
+ (modest_main_window_notify_send_receive_initied),
+ (on_configuration_key_changed):
+ * src/maemo/modest-msg-edit-window.c: (on_delete_event):
+ * src/modest-defs.h:
+ * src/modest-mail-operation.c:
+ (modest_mail_operation_update_account):
+ * src/modest-tny-account-store.h:
+ * src/modest-tny-account.c:
+ (modest_tny_account_get_special_folder),
+ (modest_tny_account_new_for_local_folders),
+ (modest_tny_account_new_for_per_account_local_outbox_folder):
+ * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
+ * src/modest-tny-local-folders-account.c:
+ (add_account_folders_to_merged_folder):
+ * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
+ (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
+ (modest_ui_actions_on_send):
+ * src/widgets/modest-folder-view.c: (update_model):
+ Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
+ MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
+ modest_tny_account_store_get_tny_account_by_account() to
+ modest_tny_account_store_get_server_account() to make the code clearer.
+
+2007-06-07 Marcus Bauer <marcusb@openismus.com>
+
+ * src/dbus_api/modest-dbus-api.h:
+ changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
+ * src/maemo/modest-msg-edit-window.c:
+ (modest_msg_edit_window_attach_file_noninteractive):
+ added g_warning in case the file to be attached does not exist
+ * tests/dbus_api/test_compose_mail.c: (main):
+ removed obsolete comment, added generic files as test case
+
+2007-06-07 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account-store.c: (get_server_accounts):
+ Create the local folders account only once, not once for each outbox, and
+ not only when there are some outboxes.
+
+2007-06-07 Murray Cumming <murrayc@murrayc.com>
+
+ * src/widgets/modest-folder-view.c: (update_model): Comment out some
+ code that is causing a crash at startup. Sergio says that he is fixing this.
+
+2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
+
+ * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
+ * src/maemo/modest-account-settings-dialog.c:
+ (create_page_outgoing),
+ (modest_account_settings_dialog_set_account_name),
+ (save_configuration):
+ - Fixed handling of the "Use secure authentication" toggle to comply with
+ the ui specification. See also projects.maemo.org bug NB#58400
+
+ - Restore the Secure connection setting combo correctly when loading
+ the settings dialog
+
+ * src/maemo/modest-maemo-utils.c:
+ (on_camel_account_get_supported_secure_authentication),
+ (modest_maemo_utils_get_supported_secure_authentication_methods):
+ Fixed a crasher if operation is canceled
+
+ * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
+ (modest_protocol_info_auth_is_secure):
+ * src/modest-protocol-info.h:
+
+ Added two new methods to determine if a protocol/auth method is secure/encrypted in
+ the sense of the "Use secure authentication" toggle.
+
+2007-06-07 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account-store.h:
+ * src/modest-tny-account-store.c:
+ Added modest_tny_account_store_get_local_folders_account().
+
+ * src/modest-tny-folder.h:
+ * src/modest-tny-folder.c:
+ (modest_tny_folder_get_account):
+ Added this replacement for tny_folder_get_account() which returns
+ the local-folders account for TnyMergeFolders, to avoid the
+ warning about the unimplemented get_account_func() vfunc().
+
+ (modest_tny_folder_get_rules),
+ * src/modest-ui-actions.c:
+ (modest_ui_actions_on_folder_selection_changed):
+ * src/modest-mail-operation.c:
+ (modest_mail_operation_remove_folder),
+ (modest_mail_operation_xfer_folder),
+ (modest_mail_operation_rename_folder),
+ (modest_mail_operation_get_msg),
+ (modest_mail_operation_get_msgs_full),
+ (modest_mail_operation_remove_msg),
+ (modest_mail_operation_xfer_msgs),
+ (modest_mail_operation_refresh_folder):
+ Use modest_tny_folder_get_account() instead of tny_folder_get_account().
+
+2007-06-07 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
+ (modest_server_account_set_security):
+ * src/modest-defs.h: Add comments explaining that our
+ UI spec means TLS when it says Normal, so these do not look like errors.
+
+ * src/modest-tny-account.c:
+ (modest_tny_account_new_from_server_account): Use the new tinymail
+ 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
+ for TLS. This should fix projects.maemo.org bug NB#58460.
+
+2007-06-06 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/easysetup/modest-easysetup-wizard.c:
+ (create_account): Correct the position of the gconf sanity check warning.
+ (on_button_edit_advanced_settings): Show the dialog immediately, instead
+ of using the g_idle_add() hack, because this does not seem to be necessary
+ on osso 1.1. It might even work on Maemo Bora if the problems were actually
+ caused by something other than maemo's gconf.
+ This fixes projects.maemo.org bug #59022.
+
+2007-06-06 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-account-mgr-helpers.c:
+ (modest_account_mgr_get_default_account): Do not check that the account
+ exists if there is no default account (NULL), to fix a runtime warning.
+
+2007-06-06 Murray Cumming <murrayc@murrayc.com>
+
+ * src/widgets/modest-folder-view.c: (update_model):
+ Do not unref the treemodel before we have finished with it.
+ This prevents a valgrind warning and an occasional crash at startup.
+
+2007-06-06 Marcus Bauer <marcusb@openismus.com>
+
+ * libmodest-dbus-client/libmodest-dbus-client.h:
+ added libmodest_dbus_client_compose_mail()
+ * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
+ (on_compose_mail):
+ added functions needed for SendAsMail() functionality
+ * src/maemo/modest-msg-edit-window.c:
+ (modest_msg_edit_window_attach_file_noninteractive):
+ non interactively attaching files to message edit window
+ * src/widgets/modest-msg-edit-window.h:
+ * tests/dbus_api/Makefile.am:
+ added test_compose_mail.c
+ * tests/dbus_api/test_compose_mail.c: (main):
+
+2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
+
+ * src/modest-account-view.c:
+ Fixed bug projects.maemo.org bug NB#59307
+
+2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
+
+ * src/maemo/easysetup/modest-easysetup-wizard.c:
+ (get_serverport_incoming), (on_before_next), (create_account):
+ * src/maemo/modest-account-settings-dialog.c:
+ (modest_account_settings_dialog_set_account_name):
+ * src/maemo/modest-maemo-utils.c:
+ (on_camel_account_get_supported_secure_authentication_status),
+ (on_camel_account_get_supported_secure_authentication),
+ (on_secure_auth_cancel),
+ (modest_maemo_utils_get_supported_secure_authentication_methods):
+
+ Implemented security authentication for settings and easysetup.
+
+2007-06-05 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-main-window.c: (create_details_widget):
+ Show the total size for memory card accounts too, instead of showing
+ the name again. Fixes bug projects.maemo.org bug NB#59307.
+
+2007-06-05 Murray Cumming <murrayc@murrayc.com>
+
+ * src/Makefile.am:
+ * src/modest-tny-simple-folder-store.c:
+ * src/modest-tny-simple-folder-store.h: Removed.
+
+ * src/modest-tny-local-folders-account.h
+ * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
+ for the local-folders maildir, with an extra TnyMergedFolder containing
+ the folders of the per-account outbox store accounts.
+ * src/modest-tny-account-store.c: (get_server_accounts):
+ Add the outboxes to the special local folders account after creating it.
+
+ * src/modest-tny-account.c:
+ (modest_tny_account_new_for_local_folders): Create the derived
+ account when creating the main local-folders account.
+
+ * src/maemo/modest-main-window.c: (create_details_widget),
+ (modest_main_window_set_contents_style):
+ Adapted to the use of the derived account instead of the folder store.
+
+ * src/modest-ui-actions.c:
+ (modest_ui_actions_on_folder_selection_changed):
+ * src/modest-ui-dimming-rules.c:
+ (modest_ui_dimming_rules_on_new_folder):
+ * src/widgets/modest-folder-view.c: (text_cell_data),
+ (icon_cell_data), (filter_row), (update_model),
+ (get_cmp_rows_type_pos):
+
+
+ * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
+ Do not get the priv struct, because no priv struct has been set,
+ to avoid a runtime warning.
+
+ * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
+ #ifelse with #else, to fix a warning, to fix the build.
+
+
+2007-06-05 Christian Kellner <ckellner@openismus.com>
+
+ * libmodest-dbus-client/libmodest-dbus-client.c:
+ Fix small typo in doc (why do you always see them
+ AFTER committing stuff?)
+
+
+2007-06-05 Christian Kellner <ckellner@openismus.com>
+
+ * libmodest-dbus-client/libmodest-dbus-client.c:
+ (libmodest_dbus_client_search):
+ Initialize hit list with NULL. Also set folder list
+ to "" if NULL was supplied.
+ Add documentation.
+
+2007-06-03 Christian Kellner <ckellner@openismus.com>
+
+ * libmodest-dbus-client/libmodest-dbus-client.c:
+ (modest_search_hit_list_free):
+ Make it save to call it with NULL.
+
+ * src/dbus_api/modest-dbus-callbacks.c:
+ * src/modest-search.c:
+ Return full ModestSearchHits as the search result list not TnyHeader
+ since can't be around withouth the correspoding TnyFolder.
+
+2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
+
+ * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
+ Added currently commented code to check for secure auth
+
+ * src/maemo/modest-account-settings-dialog.c: (on_response),
+ (save_configuration), (show_ok):
+ Fixed projects.maemo.org bugs NB #59248 and #59251
+
+ * src/maemo/modest-maemo-utils.c:
+ (on_camel_account_get_supported_secure_authentication_status),
+ (on_camel_account_get_supported_secure_authentication),
+ (modest_maemo_utils_get_supported_secure_authentication_methods):
+ * src/maemo/modest-maemo-utils.h:
+ Moved get_supported_secure_authentication() method here to be able
+ to use it from easysetup wizard.
+
+ * src/modest-pair.c: (on_pair_compare_as_string):
+ Should compare string with first part of pair and not
+ strcmp pairs which will crash.
+
+ * src/modest-protocol-info.c:
+ (modest_protocol_info_protocol_is_store):
+ * src/modest-protocol-info.h:
+ Added modest_protocol_info_get_auth_protocol_name()
+
+2007-06-03 Armin Burgmeier <armin@openismus.com>
+
+ * src/modest-mail-operation.c:
+ (modest_mail_operation_get_msgs_full): Set priv->account also when
+ only retrieving a single message. This avoids a crash when canceling
+ the operation.
+
+ (modest_mail_operation_notify_end): Do not explicitely remove the
+ operation from the queue but only emit the progress_changed signal.
+ The queue itself listens to that signal to remove the operation when
+ it is finished. This reduces coupling and removes a potential deadlock
+ when modest_mail_operation_notify_end() is called from the queue
+ itself. If that is a problem performance-wise, I would suggest to
+ implement a status-changed signal or something.
+
+ * src/modest-mail-operation-queue.c: Make sure to never call a
+ function from another file while the queue is locked. This (hopefully)
+ fixes another deadlock when exiting the application while retrieving
+ mail.
+
+2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
+
+ * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
+ Fixed build if libogs is not available
+
+2007-06-03 Christian Kellner <ckellner@openismus.com>
+
+ * libmodest-dbus-client/libmodest-dbus-client.h:
+ * libmodest-dbus-client/libmodest-dbus-client.c:
+ (libmodest_dbus_client_delete_message):
+ Implement deletion of messages (Client side).
+
+ (modest_search_hit_free),
+ (modest_search_hit_list_free):
+ Utility functions to free the result hits.
+
+ * src/dbus_api/modest-dbus-api.h:
+ * src/dbus_api/modest-dbus-callbacks.c:
+ (on_delete_message),
+ (modest_dbus_req_handler):
+ Implement deletion of messages (Server side).
+
+ * tests/dbus_api/test_search.c: (main):
+ Free the hits.
+
+ * tests/dbus_api/Makefile.am:
+ * tests/dbus_api/test_delete_message:
+ Add little test for the message deletion logic
+
+2007-06-03 Armin Burgmeier <armin@openismus.com>
+
+ * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
+ when the operation queue was not empty. projects.maemo.org bug
+ NB#58976.
+
+2007-06-03 Armin Burgmeier <armin@openismus.com>
+
+ * src/widgets/modest-account-view.c
+ (on_account_default_toggled): Toggle default account column
+ explicitely instead of waiting for gconf notification (which is
+ currently ignored). This should fix projects.maemo.org bug NB#56910
+ for now. It should probably be removed when gconf notifications are
+ re-enabled.
+
+2007-06-03 Christian Kellner <ckellner@openismus.com>
+
+ * libmodest-dbus-client/libmodest-dbus-client.c:
+ Removed debugging spew.
+
+ * src/dbus_api/modest-dbus-callbacks.c:
+ Added debugging info.
+
+ * src/modest-search.c:
+ (modest_search_all_accounts):
+ Use tny_account_store_get_accounts () on the account store
+ to get all accounts which is the way to get all accounts.
+
+ * tests/dbus_api/test_search.c: (main):
+ Make it possible to supply the search term on the command line.
+
+2007-06-03 Christian Kellner <ckellner@openismus.com>
+
+ * libmodest-dbus-client/libmodest-dbus-client.c:
+ * libmodest-dbus-client/libmodest-dbus-client.h:
+ Implement searching for mesages over raw dbus. (Client side)
+
+ * src/dbus_api/Makefile.am:
+ * src/dbus_api/modest-dbus-api.h:
+ * src/dbus_api/modest-dbus-callbacks.c:
+ * src/dbus_api/modest-dbus-callbacks.h:
+ Search framework (Server side). Also implement on_idle_open_message().
+
+ * src/maemo/modest-platform.c: (modest_platform_init):
+ Prepare for raw dbus/osso rpc interaction.
+
+ * src/modest-search.h:
+ Changed minsize from unspecific guint to guint32.
+
+ * src/modest-search.c:
+ (add_header):
+ Added strange hack which magically made tnymail work.
+
+ (modest_search_folder),
+ (modest_search_account),
+ (modest_search_all_accounts):
+ Implement helper functions to search all accounts, specific account
+ and folder.
+
+ * tests/dbus_api/Makefile.am:
+ * tests/dbus_api/test_open_message.c:
+ Read url to open from commandline.
+
+ * tests/dbus_api/test_search.c:
+ Implement small test for dbus search stuff
+
+2007-06-02 Armin Burgmeier <armin@openismus.com>
+
+ * src/maemo/modest-account-settings-dialog.c: Changed window title to
+ include account type and account title. This fixes projects.maemo.org
+ bug NB#59000.
+
+ * src/maemo/modest-account-view-window.c: Set a title for the window.
+
+2007-06-02 Armin Burgmeier <armin@openismus.com>
+
+ * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
+ incoming and outgoing server name based on email address and server
+ types as long as the names have not been edited manually. This fixes
+ projects.maemo.org bug NB#58671.
+
+2007-06-02 Armin Burgmeier <armin@openismus.com>
+
+ * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
+ server type cannot be changed in future to the incoming details page
+ when creating an account. This fixes projects.maemo.org bug NB#59029.
+
+2007-06-02 Armin Burgmeier <armin@openismus.com>
+
+ * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
+ and assigned max width chars so that they wrap instead of being
+ truncated. Fixes projects.maemo.org bug NB#56126.
+
+2007-06-02 Armin Burgmeier <armin@openismus.com>
+
+ * src/maemo/modest-connection-specific-smtp-window.c: Add an
+ introductory note to the connection specific smtp servers dialog, as
+ section 8.12 of the email UI specification requires. This fixes
+ projects.maemo.org bug NB#59212.
+
+2007-06-01 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
+ Check for running mail operations, and offer to cancel them, as per the UI
+ spec. This fixes projects.maemo.org bug NB#59041 .
+ However, I suspect that tinymail may still use the network connection
+ in ways that we cannot detect or cancel. But it should at least adapt to
+ changes fairly well.
+
+2007-06-01 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account-store.c: (recreate_all_accounts),
+ (get_cached_accounts), (get_server_accounts): Do more sensible
+ ref-counting of the temporarily-cached outbox accounts list. This seems
+ to fix a crash when entering the password when the password was wrong.
+
+2007-06-01 Murray Cumming <murrayc@murrayc.com>
+
+ * src/gnome/modest-main-window.c: (connect_signals):
+ * src/modest-tny-account-store.c: (get_password),
+ (modest_tny_account_store_alert): Added comments and clues and
+ commented-out code about how we currently fail to deal with connection
+ errors and wrong passwords, and how we should.
+
+2007-06-01 Murray Cumming <murrayc@murrayc.com>
+
+ * src/widgets/modest-retrieve-combo-box.c:
+ (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
+ This fixes projects.maemo.org bug NB#58472 .
+
+2007-06-01 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/easysetup/modest-easysetup-wizard.c:
+ (create_page_complete_easysetup):
+ (create_page_complete_custom): Correct the last commit,
+ putting the correct sentences in the correct pages.
+
+2007-06-01 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/easysetup/modest-easysetup-wizard.c:
+ (create_page_complete_custom): Show the second sentence of text
+ (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
+ NB#59023 .
+
+2007-06-01 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-account-mgr.c: (modest_account_mgr_add_account):
+ Set the leave-on-server conf key by default. This fixes
+ projects.maemo.org bug NB#59258 .
+
+2007-06-01 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-account-view-window.c:
+ (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
+ logical ID for the confirmation messages. Fixed projects.maemo.org bug
+ NB#59037 .
+
+2007-06-01 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/easysetup/modest-easysetup-wizard.c:
+ (create_caption_new_with_asterisk):
+ * src/maemo/modest-account-settings-dialog.c:
+ (create_caption_new_with_asterisk):
+ Uncomment the code to add the asterisk, because they are no longer in the
+ translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
+ (update_incoming_server_title): Add an asterisk here too.
+
+2007-06-01 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-maemo-global-settings-dialog.c:
+ (current_connection): Check that we are even connected before trying to
+ get the current connection name, to prevent a warning.
+
+ * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
+ Change the comments because tny_maemo_conic_device_connect() is now meant to
+ block.
+ * src/modest-mail-operation.c:
+ (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
+ make sure we have a connection and fail if we can't connect.
+
+2007-05-31 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-main-window.c:
+ (on_account_store_connecting_finished): Do not try to get the
+ connection ID if we are not really connected. I am surprised that
+ this signal handler is called when we are not connected.
+
+2007-05-31 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-error.h:
+ * src/modest-ui-actions.c:
+ (modest_ui_actions_get_msgs_full_error_handler):
+ Renamed an enum, added comments, added an enum
+ for retrieve-limit errors.
+
+ * src/modest-mail-operation.c: (foreach_add_item),
+ (internal_folder_observer_update), (update_account_thread),
+ (modest_mail_operation_get_msgs_full):
+ (modest_mail_operation_update_account),
+ Added comments about how this works, and some code that should
+ (but does not) check the retrieve-limit. See the TODO comment.
+
+2007-05-31 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-ui-actions.c: (modest_ui_actions_on_help):
+ Initialize help_id to fix the build. Warnings are good.
+
+2007-05-31 Murray Cumming <murrayc@murrayc.com>
+
+ * src/widgets/modest-hbox-cell-renderer.c:
+ (modest_hbox_cell_renderer_append):
+ * src/widgets/modest-vbox-cell-renderer.c:
+ (modest_vbox_cell_renderer_append):
+ Fix the last commit by doing an extra ref.
+
+2007-05-31 Murray Cumming <murrayc@murrayc.com>
+
+ * src/widgets/modest-hbox-cell-renderer.c:
+ (modest_hbox_cell_renderer_append):
+ * src/widgets/modest-vbox-cell-renderer.c:
+ (modest_vbox_cell_renderer_append):
+ For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
+ to fix the build with Maemo Bora.
+ However, there seems to be a remaining crash, probably due to reference
+ counting errors.
+
+2007-05-30 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account.c:
+ (modest_tny_account_new_for_local_folders):
+ Use hildon_file_system_info_async_new() to get a better name for
+ the memory card account, setting it as the account name.
+ The timing seems to work, but this is probably
+ not the best place to do this. See the TODO comment.
+ * src/maemo/modest-main-window.c: (create_details_widget):
+ * src/widgets/modest-folder-view.c: (text_cell_data):
+ Use the tny account name instead of hardcoding a name.
+
+2007-05-30 Christian Kellner <ckellner@openismus.com>
+
+ * src/modest-search.c: (modest_search):
+ Correctly set part_search_func even if we have already parsed
+ the query and thus a valid OgsTextSearcher object.
+
+2007-05-30 Christian Kellner <ckellner@openismus.com>
+
+ * configure.ac:
+ Search and check for libogs.
+
+ * src/Makefile.am:
+ Incooparte the ogs build env.
+
+ * src/modest-mime-part-search-stream.c:
+ * src/modest-mime-part-search-stream.h:
+ Removed since we do the real searching now in modest-search.c.
+
+ * src/modest-search.c:
+ * src/modest-search.h:
+ Implement support for ogs. We use that if available and requested
+ and fall back to modest_text_utils_utf8_strcmp (). The search logic
+ should now handle the corner case when the search term is spread
+ across multiple reads.
+ Also the logic in modest_search () was corrected to search all
+ requested fields until one is found.
+
+2007-05-30 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
+
+ * src/modest-init.h:
+ * src/modest-init.c: Made modest_init_local_folders() take a
+ path and be public so we can iniitialize maildir folders on
+ arbitrary volumes.
+
+ * src/modest-local-folder-info.h:
+ * src/modest-local-folder-info.c:
+ (modest_local_folder_info_get_maildir_path): Add a path parameter.
+
+ * src/modest-tny-account.c:
+ (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
+ still means the standard local-folders path on the local volume.
+
+ * src/modest-tny-account-store.c:
+ (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
+ signal so we can detect mount/unmount of the MMC1 card, and do an update of
+ all accounts when that happens.
+ (get_server_accounts): If the MMC1 card is mounted, create a store account for
+ this too, so it shows up in the treeview.
+
+2007-05-28 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-maemo-global-settings-dialog.c:
+ (current_connection):
+ * src/widgets/modest-global-settings-dialog.c:
+ (current_connection_default):
+ Use the enum values instead of 0, 1 and -1,
+ to make the code clearer.
+
+ * src/modest-account-mgr-helpers.c:
+ (modest_account_mgr_get_connection_specific_smtp): Make this code
+ more robust.
+
+ * src/modest-runtime.h:
+ * src/modest-runtime.c:
+ Added modest_runtime_remove_all_send_queues().
+ * src/maemo/modest-main-window.c:
+ (on_account_store_connecting_finished): Recreate the send queues,
+ using the appropriate transport accounts for this new connection.
+ Some futher adapting might be needed if the old send queues are not
+ automatically stopped at this point.
+
+ * src/modest-tny-account-store.c: (get_server_accounts):
+ Create the connection-specific transport accounts, so that they can
+ be found later by their ID.
+
+ * src/modest-tny-account.h:
+ * src/modest-tny-account.c:
+ Added modest_tny_account_new_from_server_account_name().
+ modest_tny_account_new_from_server_account(): Do not create the
+ send queues here, because they will be
+ recreated anyway when the connection changes for the first time.
+
+2007-05-28 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-local-folder-info.h:
+ * src/modest-local-folder-info.c:
+ (modest_per_account_local_outbox_folder_info_get_maildir_path),
+ (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
+ tbox_folder): Take a modest account name instead of a server TnyAccount,
+ so we can have per-modest-account rather than per-transport-account
+ outboxes.
+ We must make sure that we change or recreate the exisitng send queues
+ when the connection changes for connection-specific transport accounts.
+
+ * src/modest-tny-account-store.c:
+ (create_per_account_local_outbox_folders): Create outboxed per modest
+ account, not per transport account.
+
+ * src/modest-tny-account.h:
+ * src/modest-tny-account.c:
+ (modest_tny_account_get_special_folder): For outboxes, get the
+ parent modest account name. The account is ignored for other folders.
+ (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
+ modest account name rather than a server TnyAccount.
+
+2007-05-25 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account.c:
+ (modest_tny_account_new_from_server_account):
+ Call modest_runtime_get_send_queue() immediately after creating transport
+ accounts, so that they start trying to send email from the outbox as soon
+ as possible at startup. This is probably what we want.
+
+ * src/modest-mail-operation.c: (update_account_thread):
+ * src/modest-runtime.c: (modest_runtime_get_send_queue):
+ * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
+ * src/modest-tny-send-queue.h:
+ * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
+ (modest_ui_actions_on_send):
+ Added comments about how sending works, though it needs some more work.
+
+2007-05-25 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account.c:
+ (modest_tny_account_get_special_folder): Add TODO because this fails when
+ the network is busy.
+ (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
+ * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
+ Do not try to show this window when there is no active account. The UI
+ specs does not tell us what to do in this case.
+
+2007-05-24 Murray Cumming <murrayc@murrayc.com>
+
+ * Makefile.am:
+ * po/POTFILES.in:
+ * src/maemo/Makefile.am:
+ * src/widgets/Makefile.am: Some dist fixes.
+
+2007-05-24 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-connection-specific-smtp-window.c:
+ (on_button_edit): Make the code clearer, to prevent a double free.
+
+2007-05-24 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-account-settings-dialog.c:
+ (modest_account_settings_dialog_set_account_name),
+ Check the connection-specific smtp servers checkbox if there are any.
+
+ * src/maemo/modest-connection-specific-smtp-edit-window.c:
+ (modest_connection_specific_smtp_edit_window_init):
+ Start with a suitable port number.
+
+ * src/modest-account-mgr-helpers.h:
+ * src/modest-account-mgr-helpers.c: Added
+ modest_account_mgr_get_has_connection_specific_smtp().
+
+ (modest_account_mgr_set_connection_specific_smtp),
+ (modest_account_mgr_remove_connection_specific_smtp),
+ (modest_account_mgr_get_has_connection_specific_smtp),
+ (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
+ connection-specific smtp server accounts in the account, rather than
+ the server account conf dir.
+
+ This fixes bug projects.maemo.org bug NB#58263 .
+
+ * src/modest-tny-account-store.c:
+ (create_per_account_local_outbox_folders): Do not call get_server_accounts()
+ if there are no server accounts yet, to prevent an infinite loop when there
+ are no accounts. Document that one must be called before the other.
+
+2007-05-24 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-account-mgr-helpers.c:
+ (modest_account_mgr_get_default_account): Make sure that at least
+ one account is always the default, if there are any enabled accounts.
+ This is just a sanity check that shouldn't be necessary.
+
+ * src/modest-account-mgr-priv.c:
+ (_modest_account_mgr_account_from_key): Unescape the conf key to
+ get the real account name. For instance, this is an issue if a space
+ was in the account name, which can happen because the account name
+ is generated from the display name.
+ (_modest_account_mgr_get_account_keyname): Always escape the
+ account name.
+ * src/modest-account-mgr.c: (modest_account_mgr_account_names):
+ Unescape the conf keys to get the real account names.
+
+ For instance, previously the is-default radio button in the accounts
+ list was not checked for any accounts at first. This fixes that,
+ and might fix several similar bugs.
+
+2007-05-23 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-ui-actions.c: (set_active_account_from_tny_account):
+ Removed some debug printfs.
+
+2007-05-23 Murray Cumming <murrayc@murrayc.com>
+
+ Modest on-disk outbox directories are now here, for instance:
+ $HOME/.modest/outboxes/<account-id-1>/outbox
+ $HOME/.modest/outboxes/<account-id-2>/outbox
+ instead of here:
+ $HOME/.modest/local-folders/outbox
+ so we can have a separate outbox for each account.
+ But they are shown as one outbox in the GtkTreeView, by using a
+ TnyMergeFolder in a ModestTnySimpleFolderStore.
+
+ * src/Makefile.am:
+ * src/modest-tny-simple-folder-store.c:
+ * src/modest-tny-simple-folder-store.h:
+ Added ModestTnySimpleFolderStore, used to contain folders from
+ other folder stores, such as other accounts.
+
+ * src/modest-tny-outbox-account.h:
+ * src/modest-tny-outbox-account.c:
+ Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
+ used for the per-account local outbox folders.
+
+ * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
+ MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
+ only use this (internally) now for the non-outbox local folders.
+
+ * src/modest-init.h:
+ * src/modest-init.c: Added modest_init_one_local_folder(), for
+ setting up the directory structure for each local folder.
+
+ * src/modest-local-folder-info.c:
+ (modest_per_account_local_outbox_folder_info_get_maildir_path),
+ (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
+ tbox_folder):
+ * src/modest-local-folder-info.h:
+ * src/modest-tny-account-store.c: (on_account_removed),
+ (on_account_changed), (create_per_account_local_outbox_folders),
+ (get_server_accounts), (modest_tny_account_store_get_accounts),
+ (modest_tny_account_store_get_tny_account_by_account),
+ (modest_tny_folder_store_is_virtual_local_folders):
+
+ * src/modest-tny-account.h:
+ * src/modest-tny-account.c:
+ Added modest_tny_account_new_for_per_account_local_outbox_folder(),
+ to create an on-disk per-account local outbox folder for each
+ transport account.
+ (create_per_account_local_outbox_folders): Create a local outbox folder
+ for each transport account.
+ (modest_tny_account_new_for_local_folders): Do not create an outbox folder
+ for all local folders.
+
+ Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
+ instead of using g_object_get/set() directly. It is clearer.
+
+ (modest_tny_folder_store_get_message_count),
+ (modest_tny_folder_store_get_local_size
+ (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
+ because we now use these with non-acount folder stores.
+
+ (modest_tny_account_get_special_folder),
+ (modest_tny_account_new_from_server_account),
+ (modest_tny_account_new_from_account):
+ (recurse_folders): Adjust to the new outbox system.
+
+ * src/modest-tny-folder.h:
+ * src/modest-tny-folder.c:
+ (modest_tny_folder_is_local_folder),
+ (modest_tny_folder_get_local_folder_type),
+ (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
+
+ * src/widgets/modest-main-window.h:
+ * src/maemo/modest-main-window.c: (create_details_widget),
+ (modest_main_window_set_contents_style): Show details for any folder store,
+ not just accounts.
+
+ (modest_tny_folder_get_rules):
+ Remove the const. C does not support constness enough for this.
+
+ * src/modest-ui-actions.c:
+ update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
+ make all outboxes appear as one, in the usual local-folders tree node.
+
+ (set_active_account_from_tny_account),
+ (modest_ui_actions_on_folder_selection_changed):
+ * src/widgets/modest-folder-view.c: (text_cell_data),
+ (icon_cell_data), (filter_row),
+ (add_account_folders_to_merged_folder),
+ (add_account_folders_to_simple_folder_store), (),
+ (get_cmp_rows_type_pos), (cmp_rows),
+ (modest_folder_view_set_account_id_of_visible_server_account):
+ Adjust to the new outbox system, using generic folder stores and folders
+ in the GtkTreeModel.
+
+2007-05-23 Christian Kellner <ckellner@openismus.com>
+
+ * src/modest-mail-operation.c:
+ (modest_mail_operation_update_account):
+ Use info->max_size instead of unintialized local var [small
+ build fix]. (Added TODO to review that change since I don't
+ know the code)
+
+2007-05-23 Marcus Bauer <marcusb@openismus.com>
+
+ * libmodest-dbus-client/libmodest-dbus-client.c:
+ (libmodest_dbus_client_compose_mail): function added
+ * src/dbus_api/modest-dbus-api.h:
+ * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
+ (on_compose_mail): Implementation of the SendAsMail functionality
+
+2007-05-22 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-account-mgr.c:
+ (modest_account_mgr_add_server_account): Set the secure-connection
+ conf key for transport accounts as well as store accounts. I don't know
+ why the if was there. For instance, this makes sure that we use SSL
+ for the gmail preset from the easysetup wizard.
+
+2007-05-22 Murray Cumming <murrayc@murrayc.com>
+
+ * src/gnome/modest-main-window.c:
+ (on_account_store_connecting_finished), (connect_signals):
+ * src/maemo/modest-main-window.c:
+ (on_account_store_connecting_finished), (connect_signals),
+ (modest_main_window_new):
+ Handle TnyAccountStore::connecting-finished instead of
+ TnyDevice::connection-changed, because we cannot actually perform
+ operations on accounts until TnyAccountStore has itself responded to
+ the TnyDevice::connection-changed signal. This prevents a GError from
+ tinymail.
+ Do not try to update at startup, because we (at least on scratchbox)
+ already do an update at startup when the device goes online.
+ This prevents a GError from tinymail.
+ * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
+ Added TODO about stopping simultaneous operations.
+
+2007-05-21 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-account-mgr.c: (modest_account_mgr_add_account):
+ * src/modest-mail-operation-queue.c:
+ (modest_mail_operation_queue_remove):
+ * src/modest-tny-account-store.c: When GErrors happen, give more clues
+ about where they happened.
+