+2007-06-12 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
+ NULL, so that the signals get all the keys. This should not actually
+ change any behaviour because we currently update everything when anything
+ changes.
+
+2007-06-12 Murray Cumming <murrayc@murrayc.com>
+
+ * src/widgets/modest-folder-view.c: (text_cell_data),
+ (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
+ (find_inbox_iter): If tinymail tells us that the folder is
+ a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
+ This causes the inbox to be selected at startup, fixing part of
+ projects.maemo.org bug NB#56305.
+
+ * src/modest-ui-dimming-rules.c:
+ (modest_ui_dimming_rules_on_tools_smtp_servers):
+ * src/modest-ui-dimming-rules.h: Added a callback function to dim
+ the SMTP servers menu item.
+ * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
+ that the SMTP Servers menu item is dimmed when there are no accounts,
+ as a future version of the UI spec will require. This fixes
+ projects.maemo.org bug NB#56305.
+
+2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
+
+ * src/maemo/modest-maemo-utils.c:
+ (modest_maemo_utils_get_supported_secure_authentication_methods):
+ Added label to dialog instead of unreadable title
+
+ * src/maemo/modest-main-window.c: (sync_accounts_cb),
+ (modest_main_window_new):
+ Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
+ dead code.
+
+ * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
+ * src/modest-account-mgr.h:
+ Added method to avoid code duplication
+
+ * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
+ (modest_ui_actions_on_send_receive):
+ Use modest_account_mgr_has_accounts
+
+2007-06-11 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/easysetup/modest-presets.c:
+ (modest_presets_get_info_server_security): Do not report secure auth
+ if there is none.
+ * src/modest-protocol-info.c: Use the defines for the gconf key names
+ for secure authentication. This was not working because we were writing
+ Password and reading password, and the check was case sensitive.
+ With this, gmail now works for receiving and sending when created via
+ easysetup.
+
+2007-06-11 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/easysetup/modest-presets.c:
+ (modest_presets_get_info_server_security): Correct the key name for
+ SecureSmtp, because it seems to be case-sensitive.
+ * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
+ Do not try to get the 0th notebook page if there are 0 pages, to
+ avoid a g_warning().
+
+2007-06-11 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
+ Prevent use of the new notification feature for now, because it currently
+ shows one dialog for each new email, which is annoying.
+
+2007-06-11 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
+ (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
+ when no country was selected, so that we show the global ones.
+ * src/maemo/easysetup/modest-presets.c:
+ (modest_presets_get_providers): Return only the global providers, not
+ all providers when mmc=0 was requested.
+
+2007-06-11 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
+ (easysetup_provider_combo_box_fill): Remove debug code that showed the
+ provider ID in the combo.
+
+ * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
+ Do not show the page numbers, because it would be confusing when we add
+ the 2 extra pages for the custom setup, when the user chooses the "Other"
+ provider. This fixes projects.maemo.org bug NB#59028
+
+ * src/modest-init.c: (modest_init_init_core),
+ (modest_init_local_folders):
+ * src/modest-init.h:
+ * src/modest-tny-account.c:
+ (modest_tny_account_new_for_local_folders): Do not create default folders
+ for the memory card. This should fix projects.maemo.org bug NB#59328.
+
+2007-06-11 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-account-mgr.c: (modest_account_mgr_finalize):
+ Free the changed_conf_keys string items. They are already freed in the
+ idle handler if that runs first.
+
+2007-06-11 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-ui-actions.c:
+ (modest_ui_actions_on_password_requested): Check that the server name
+ is not NULL, because I just saw a password dialog with (null) as the
+ server name.
+
+ * src/modest-tny-folder.[h|c]: Added
+ modest_tny_folder_is_memory_card_folder().
+ * src/modest-ui-dimming-rules.c:
+ (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
+ menu item for memory cards, as per the UI spec (section 7.4). This should
+ fix projects.maemo.org bug NB#59297.
+
+2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
+
+ * src/maemo/modest-main-window.c: (sync_accounts_cb):
+ Fixed projects.maemo.org bug NB#58576 (not yet activated as there
+ is another problem with the code, see Murray's comment at line 772)
+
+2007-06-08 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
+ * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
+ (on_model_foreach_release), (easysetup_country_combo_box_finalize),
+ (load_from_file), (easysetup_country_combo_box_init),
+ (easysetup_country_combo_box_get_active_country_ids),
+ (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
+ instead of just one ID, to avoid duplicate country names in the UI.
+
+ * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
+ * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
+ (easysetup_provider_combo_box_fill): Adapt to use a list rather than
+ a single ID, avoiding duplicate providers.
+ * src/maemo/easysetup/modest-easysetup-wizard.c:
+ (on_combo_account_country): Adapt to use a list.
+
+2007-06-08 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
+ keys changed in the last X seconds.
+
+ * src/modest-account-mgr.h:
+ * src/modest-account-mgr.c: (on_timeout_notify_changes),
+ (on_key_change), (modest_account_mgr_class_init),
+ (modest_account_mgr_init), (modest_account_mgr_finalize):
+ As the keys are changed, save them in a GSList* and signal that GSList*
+ further every X seconds, to batch changes, to allow us to do just one
+ update per batch. This should fix bug projects.maemo.org bug NB#56472 and
+ bug NB#56941 and other (UI-blocking) delays when changing account settings.
+
+ * src/modest-tny-account-store.c: (on_account_changed): Adapted to
+ changed signal signature.
+
+ * src/modest-conf.c: (modest_conf_set_list),
+ (modest_conf_on_change): Reenable notification.
+
+ (modest_conf_maemo_fake_on_change): Comment out the hack that
+ notified immediately instead of asynchronously.
+
+ * src/widgets/modest-account-view.h:
+ * src/widgets/modest-account-view.c:
+ (update_account_view): Select the previously-selected account ID,
+ if possible. This fixes projects.maemo.org bug NB#56933.
+
+ (on_account_changed), (on_account_removed),
+ (modest_account_view_select_account):
+
+ Remove the block/unblock functions
+ because they were not useful.
+
+ * src/maemo/modest-account-view-window.c:
+ (on_delete_button_clicked), (on_edit_button_clicked),
+ (on_new_button_clicked): Remove the use of the non-working block/unblock.
+
+2007-06-08 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
+ Improve the error dialog to show Incorrect Account Settings, which seems
+ clearer, and say that the internal error message (to be removed from the
+ dialog later) is often misleading.
+ I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
+
+ * src/modest-tny-account.c:
+ (modest_tny_account_new_from_server_account): Uncomment the printf of the
+ URL because this is so useful for debugging on the device.
+
+ * src/widgets/modest-serversecurity-combo-box.c:
+ (modest_serversecurity_combo_box_fill): Correct a logical ID.
+
+2007-06-08 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-mail-operation.c:
+ (modest_mail_operation_send_new_mail):
+ Added a comment about a nasty but apparently harmless message. Details
+ added to the wiki g_warnings() page.
+
+2007-06-08 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
+ (modest_tny_send_queue_class_init):
+ Do not use the priv struct because it is empty, to avoid g_warnings
+ about a non-existant priv struct.
+
+ * src/modest-tny-account-store.c:
+ (modest_tny_account_store_get_server_account),
+ (modest_tny_account_store_get_transport_account_for_open_connection
+ ): Do not try to get transport server accounts for local folders,
+ because they don't have any. This avoids a g_warning().
+
+ * src/maemo/modest-main-window.c:
+ (modest_main_window_notify_send_receive_initied),
+ (on_configuration_key_changed):
+ * src/maemo/modest-msg-edit-window.c: (on_delete_event):
+ * src/modest-defs.h:
+ * src/modest-mail-operation.c:
+ (modest_mail_operation_update_account):
+ * src/modest-tny-account-store.h:
+ * src/modest-tny-account.c:
+ (modest_tny_account_get_special_folder),
+ (modest_tny_account_new_for_local_folders),
+ (modest_tny_account_new_for_per_account_local_outbox_folder):
+ * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
+ * src/modest-tny-local-folders-account.c:
+ (add_account_folders_to_merged_folder):
+ * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
+ (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
+ (modest_ui_actions_on_send):
+ * src/widgets/modest-folder-view.c: (update_model):
+ Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
+ MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
+ modest_tny_account_store_get_tny_account_by_account() to
+ modest_tny_account_store_get_server_account() to make the code clearer.
+
+2007-06-07 Marcus Bauer <marcusb@openismus.com>
+
+ * src/dbus_api/modest-dbus-api.h:
+ changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
+ * src/maemo/modest-msg-edit-window.c:
+ (modest_msg_edit_window_attach_file_noninteractive):
+ added g_warning in case the file to be attached does not exist
+ * tests/dbus_api/test_compose_mail.c: (main):
+ removed obsolete comment, added generic files as test case
+
2007-06-07 Murray Cumming <murrayc@murrayc.com>
* src/modest-tny-account-store.c: (get_server_accounts):
projects / modest / blobdiff