+ * src/maemo/modest-account-settings-dialog.c:
+ (modest_account_settings_dialog_set_account_name): Set the incoming
+ secure-auth checkbox only when a secure auth method is really specified
+ in gconf. For some reason, it was set also if a secure connection was
+ chosen, but that does not make sense to me, and was not commented.
+ For instance, this stops the user from seeing an error about unsupported
+ secure authentication when editing a gmail account.
+
+2007-09-05 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-maemo-utils.c:
+ (on_camel_account_get_supported_secure_authentication),
+ (modest_maemo_utils_get_supported_secure_authentication_methods):
+ Adapted to the changed tinymail signature of the callback, and
+ printf a warning when there is an exception, as a clue.
+
+2007-09-03 Armin Burgmeier <armin@openismus.com>
+
+ * src/maemo/modest-maemo-utils.c: Don't set the temporary account
+ online that checks for supported authentication methods. This fixes
+ projects.maemo.org bug NB#61369.
+
+2007-09-03 Murray Cumming <murrayc@murrayc.com>
+
+ * src/widgets/modest-folder-view.c: (strings_are_equal),
+ (on_model_foreach_set_name), (on_get_mmc_account_name),
+ (text_cell_data): Restored this code that was removed in
+ svn revision 3165 by jfernandez, because this late name-discovery
+ really is necessary sometimes. This is the correct fix to the endless
+ calling of this function:
+ * src/modest-tny-account.c: (on_modest_file_system_info):
+ Don't call tny_account_set_name() when the name is already correct,
+ to avoid unnecessary (endless) updates to the tree model.
+
+2007-08-31 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-defs.h: Rename MODEST_CONF_CONNECTION_SPECIFIC_SMTP_LIST to
+ MODEST_CONF_CONNECTION_SPECIFIC_SMTP_LIST and make it a global list
+ for use by all accounts that enable the MODEST_ACCOUNT_USE_CONNECTION_SPECIFIC_SMTP
+ boolean, because this is the specified behaviour in the UI spec.
+ * src/modest-account-mgr-helpers.h:
+ * src/modest-account-mgr-helpers.c:
+ (modest_account_mgr_set_connection_specific_smtp),
+ (modest_account_mgr_remove_connection_specific_smtp),
+ (modest_account_mgr_get_connection_specific_smtp): Remove the account_name
+ parameter.
+ * src/maemo/modest-connection-specific-smtp-window.h:
+ * src/maemo/modest-connection-specific-smtp-window.c:
+ (modest_connection_specific_smtp_window_finalize),
+ (modest_connection_specific_smtp_window_fill_with_connections),
+ (modest_connection_specific_smtp_window_save_server_accounts):
+ Remove the account_name parameters and member variable.
+ * src/maemo/easysetup/modest-easysetup-wizard.c:
+ (on_button_outgoing_smtp_servers), (create_account):
+ * src/maemo/modest-account-settings-dialog.c:
+ (on_button_outgoing_smtp_servers), (check_data),
+ (modest_account_settings_dialog_set_account_name),
+ (save_configuration):
+ * src/maemo/modest-maemo-utils.c: (on_account_online),
+ (modest_maemo_utils_get_supported_secure_authentication_methods):
+ * src/modest-tny-account-store.c:
+ (get_smtp_specific_transport_account_for_open_connection),
+ (insert_account), (add_connection_specific_transport_accounts):
+ * src/modest-ui-actions.c: (on_smtp_servers_window_hide),
+ (modest_ui_actions_on_smtp_servers):
+ Adapt to the changed API.
+
+2007-08-29 Armin Burgmeier <armin@openismus.com>
+
+ * src/modest-protocol-info.h:
+ * src/modest-protocol-info.c: Added
+ modest_protocol_info_get_auth_protocol() to translate an
+ authentication protocol name to the corresponding enum value.
+
+ * src/maemo/modest-maemo-utils.c: Fixed supported auth protocol list
+ generation using the newly added function.
+
+ * src/maemo/modest-account-settings-dialog.c: Use the current element
+ when traversing through the list of supported authentication methods,
+ not always the first.
+
+2007-08-29 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/easysetup/modest-easysetup-wizard.c:
+ (check_first_supported_auth_method), (on_before_next),
+ (create_account):
+ * src/maemo/modest-account-settings-dialog.c: (check_data):
+ Some cleanup, to make the code clearer.
+
+2007-08-29 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
+ Use the mail_ni_ssl_certificate_error ("Secure connection failed")
+ logical ID when the secure authentication method is not supported by
+ the server, as requested by Mox on the wiki, though I hate not
+ giving the user the clue.
+
+2007-08-29 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-search.c: (modest_search_all_accounts):
+ * src/modest-platform.h:
+ * src/maemo/modest-platform.c: Moved and renamed
+ check_and_wait_for_account_is_online() to
+ modest_platform_check_and_wait_for_account_is_online() so it
+ can be used in more places.
+
+2007-08-29 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
+ Removed the sleep(1) experiment because it does not seem to help,
+ and I should not have checked the experiment in anyway.
+ The problem is maybe in the TnyAccount connected state - I will
+ investigate that instead.
+
+2007-08-28 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
+ Added a sleep(1) in case it helps with bug #66769.
+
+2007-08-28 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-search.c: (on_timeout_check_account_is_online),
+ (check_and_wait_for_account_is_online):
+ It is OK for local-folder and mmc accounts to be used when they
+ are in the _INIT folder, instead of waiting for them to change
+ (they never do).
+ For POP and IMAP, wait from them to stop being _INIT, rather than
+ waiting from them to be _CONNECTED, because that seems to be
+ the status that causes the problems.
+
+2007-08-28 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-search.c: (check_and_wait_for_account_is_online):
+ Actually pass the account to the timeout callback.
+
+2007-08-28 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-search.c: (on_timeout_check_account_is_online):
+ Added some debug output to help me debug a problem on the N800.
+ (check_and_wait_for_account_is_online): Fail immediately if the
+ device is offline.
+ modest_search_all_accounts(): Try the search even if the account does
+ not seem to be online, because this can work sometimes, and should work
+ with the cache if there is no active libconic connection.
+
+2007-08-27 Armin Burgmeier <armin@openismus.com>
+
+ * src/modest-tny-send-queue.c: Implement TnyFolderObserver and
+ observe outbox for added messages to assign them a status. Previously,
+ this was done in modest_tny_send_queue_add(), but the message id might
+ not yet be known at that point. This reduces warnings when sending
+ mail, though I am not sure how this even worked before.
+
+2007-08-27 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-account-settings-dialog.c:
+ (modest_account_settings_dialog_init):
+ * src/maemo/modest-connection-specific-smtp-edit-window.c:
+ (modest_connection_specific_smtp_edit_window_init):
+ * src/maemo/modest-connection-specific-smtp-window.c:
+ (modest_connection_specific_smtp_window_init):
+ * src/maemo/modest-maemo-utils.c:
+ (modest_maemo_utils_get_supported_secure_authentication_methods):
+ * src/maemo/modest-platform.c:
+ (modest_platform_run_folder_name_dialog):
+ * src/maemo/modest-signature-editor-dialog.c:
+ (modest_signature_editor_dialog_init):
+ * src/modest-ui-actions.c: (modest_ui_actions_on_item_not_found),
+ (modest_ui_actions_on_password_requested), (create_move_to_dialog):
+ * src/widgets/modest-global-settings-dialog.c:
+ (modest_global_settings_dialog_init):
+ Replace all uses of GTK_STOCK_OK (and GTK_BUTTONS_OK) with
+ mcen_bd_dialog_ok,
+ GTK_STOCK_CANCEL with mcen_bd_dialog_cancel,
+ GTK_STOCK_EDIT with mcen_bd_edit, and
+ GTK_STOCK_CLOSE with mcen_bd_close,
+ to fix projects.maemo.org bug NB#64995.
+ I strongly believe that Maemo's GTK+ should have the wanted translations
+ instead of duplicating this in each application and complicating the code.
+
+2007-08-27 Armin Burgmeier <armin@openismus.com>
+
+ * src/maemo/modest-msg-edit-window.c: Fixed a crash due to endless
+ recursion when entering text in the subject field.
+
+2007-08-27 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-search.c: Added check_and_wait_for_account_is_online(),
+ which checks every second, 10 times, to wait until the account is online
+ so that we can use it, if the account is in the process of going online.
+ (modest_search_all_accounts): Use check_and_wait_for_account_is_online()
+ so that searching works even when the application was not yet started before.
+ This fixes projects.maemo.org bug NB#63784, at least in scratchbox.
+
+2007-08-24 Armin Burgmeier <armin@openismus.com>
+
+ * src/modest-widget-memory.c: Always show the default account when the
+ application is started, as stated in the UI spec. This fixes
+ projects.maemo.org bug NB#66630.
+
+2007-08-24 Armin Burgmeier <armin@openismus.com>
+
+ * src/maemo/modest-platform.c:
+ (modest_platform_run_rename_folder_dialog): Use logical IDs instead of
+ english text for strings in the rename folder dialog, fixing
+ projects.maemo.org bug NB#66338.
+
+2007-08-22 Armin Burgmeier <armin@openismus.com>
+
+ * src/widgets/modest-account-view.c: Fix for bora by using
+ MODEST_HAVE_HILDON0_WIDGETS instead of MODEST_HILDON_VERSION_0. The
+ latter seems not be used anymore.
+
+ * src/maemo/easysetup/modest-easysetup-provider-combo-box.c: Some
+ minor optimizations.
+
+ * src/maemo/modest-main-window.c: Update menu items when the default
+ account changes so that the current default account is always bolded.
+ This fixes maemo.projects.org bug NB#66173.
+
+2007-08-17 Murray Cumming <murrayc@murrayc.com>
+
+ * src/dbus_api/modest-dbus-callbacks.c:
+ (on_dbus_method_get_folders): Avoid trying to get the account name
+ when there are no accounts, to avoid critical g_warnings, fixing
+ projects.maemo.org bug NB#65574.
+
+2007-08-17 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg):
+ Use modest_account_mgr_get_signature() instead of accessing gconf
+ directly, to slightly simplify the code.
+ * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
+ Append the signature also when opening via other applications,
+ fixing projects.maemo.org bug NB#65828.
+
+2007-08-17 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_msg_id):
+ Check for NULLs to prevent a crash when opening an email that is
+ an attachment in another email, fixing projects.maemo.org bug
+ NB#66012.
+
+2007-08-17 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-ui-dimming-rules.c:
+ (modest_ui_dimming_rules_on_view_window_move_to):
+ Enable the Move To toolbar button for search results, fixing the
+ last part of projects.maemo.org bug NB#63807.
+
+2007-08-17 Murray Cumming <murrayc@murrayc.com>
+
+ * src/dbus_api/modest-dbus-callbacks.c:
+ (check_and_offer_account_creation): Use gdk_thread_enter/leave(),
+ because this is called from idle handlers, to fix hangs afte the
+ wizard closes.
+ (find_message_by_url): Added a TODO comment about a crash that
+ happens when tinymail was built with DBC checks.
+
+2007-08-16 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-search.c: (modest_search_folder):
+ * src/modest-search.h: Rename ModestSearch::before to start_date
+ and after to end_date, using the same names as the libogs struct
+ fields.
+ * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
+ The start_date and end_date were swapped in the check. This
+ fixes date range searches, fixing projects.maemo.org bug NB#63407.
+
+2007-08-16 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-account-view-window.c:
+ Added (check_for_active_acount).
+ (on_delete_button_clicked), (on_edit_button_clicked):
+ When an account is doing something (such as refreshing),
+ show the same warning for account deletion as for account
+ editing, to fix projects.maemo.org bug NB#64588.
+
+2007-08-16 Murray Cumming <murrayc@murrayc.com>
+
+ * src/widgets/modest-msg-view-window.h:
+ * src/gnome/modest-msg-view-window.c:
+ * src/maemo/modest-msg-view-window.c:
+ Added modest_msg_view_window_construct().
+ (modest_msg_view_window_new_with_header_model),
+ Added modest_msg_view_window_new_for_search_result),
+ Renamed modest_msg_view_window_new() to
+ modest_msg_view_window_new_for_attachment(),
+ and modest_msg_view_window_is_search_result(),
+ so we can explicitly know that the window is for an
+ attachment or a search result or a message from the list.
+
+ (modest_msg_view_window_view_attachment):
+ * src/modest-ui-actions.c: (open_msg_cb): Use the renamed function.
+ * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
+ Use modest_msg_view_window_new_for_search_result().
+
+ * src/modest-ui-dimming-rules.c:
+ (modest_ui_dimming_rules_on_delete_msg): Enable the delete button
+ for search results, fixing projects.maemo.org bug NB#63811.
+
+2007-08-16 Armin Burgmeier <armin@openismus.com>
+
+ * src/modest-ui-actions.c: Show a banner instead of a dialog when
+ renaming a folder fails, to stay consistent with what happens when
+ creating a folder fails.
+
+ * src/maemo/easysetup/modest-easysetup-country-combo-box.c: Optimized
+ slightly country loading from the mmc_mappings file, fixed a memory
+ leak.
+
+2007-08-16 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account-store.c: (volume_path_is_mounted):
+ Check the GnomeVFSVolume activation path instead of the device path,
+ so that the memory card is really really shown in the UI.
+
+2007-08-16 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/easysetup/modest-easysetup-wizard.c:
+ (get_entered_account_title), (on_before_next), (entry_is_empty),
+ (create_account):
+ * src/maemo/modest-account-settings-dialog.c:
+ (get_entered_account_title), (on_button_signature), (check_data),
+ (save_configuration), (entry_is_empty):
+ Strip the account title of whitespace at the start and end before
+ using it or checking it. This means that an all-whitespace title
+ is not allowed, fixing projects.maemo.org bug NB#64977.
+
+2007-08-15 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-ui-actions.h:
+ * src/modest-ui-actions.c: Renamed modest_run_account_setup_wizard()
+ to modest_run_account_setup_wizard() and made it public.
+ * src/dbus_api/modest-dbus-callbacks.c:
+ (check_and_offer_account_creation), (on_idle_mail_to),
+ (on_idle_compose_mail), (on_idle_open_default_inbox):
+ Offer account creation if necessary, fixing projects.maemo.org
+ bug NB#63713.
+
+2007-08-15 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-ui-actions.c: (run_account_setup_wizard):
+ Return a gboolean to indicate success.
+ (modest_ui_actions_on_new_msg), (open_msg_cb), (reply_forward),
+ (modest_ui_actions_on_send): When offering account creation, only
+ give up (return) if account creation failed. Otherwise continue
+ with the original request. This fixed projects.maemo.org bug
+ NB#64317.
+
+2007-08-15 Murray Cumming <murrayc@murrayc.com>
+
+ * src/widgets/modest-recpt-editor.c:
+ (modest_recpt_editor_instance_init): Turn off hildon auto-capitalization,
+ to fix projects.maemo.org bug NB#63789.
+
+2007-08-15 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account-store.c: Added volume_path_is_mounted().
+ (modest_tny_account_store_new): Properly detect the memory card at
+ startup, and add an account for it.
+
+2007-08-14 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account-store.c: (modest_tny_account_store_new):
+ Commented out the MMC code again because it mistakenly detects
+ the card even when it isn't inserted.
+
+2007-08-14 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account-store.c: (modest_tny_account_store_new):
+ Renabled the call to add_mmc_account() because I do not believe
+ it could be the cause of the mentioned hang (in scratchbox, where
+ there is no memory card), and because I have tested that it works
+ on the device.
+
+2007-08-14 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account-store.c: (modest_tny_account_store_new):
+ Comment out part of the last commit because it apparently causes
+ a hang.
+
+2007-08-14 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account-store.c: Added the add_mmc_account()
+ function to save some copy/pasting.
+ (modest_tny_account_store_new): If the memory card is mounted,
+ create an account for it at the start, instead of waiting for the
+ user to unmount it and mount it.
+
+2007-08-13 Murray Cumming <murrayc@murrayc.com>
+
+ * src/widgets/modest-account-view.c: (on_account_changed):
+ Do not try to use the human-readable TnyAccount name instead of the
+ ID of the modest account to get the transport account. And unref
+ the transport account. This prevents a g_warning(), and a possible
+ ref leak.
+
+2007-08-13 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-platform.c:
+ (modest_platform_set_update_interval): Handle the new
+ alarmd error to warn when alarmd is not running, as is the case in
+ scratchbox for me now because
+ "Module /usr/lib/alarmd/libretu.so initialization failed"
+
+2007-08-13 Murray Cumming <murrayc@murrayc.com>
+
+ * src/widgets/modest-header-view-render.c:
+ (_modest_header_view_compact_header_cell_data):
+ NULL some strings after freeing them, trying to deal with
+ the double deletion found in projects.maemo.org bug 64183,
+ probably having no effect.
+
+2007-08-13 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-account-settings-dialog.c:
+ (create_page_incoming), (create_page_outgoing): Use a define
+ for the min and max port numbers.
+
+ (check_hildon_number_editor_and_warn_value_not_in_range),
+ (check_data): Do an extra check for an invalid port number, as needed
+ in projects.maemo.org bug #64275, when the number is cleared, but this
+ does not work due to bugs.maemo.org bug #1806.
+
+2007-08-13 Murray Cumming <murrayc@murrayc.com>
+
+ * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
+ Comment out the debug warning about the unexpected D-Bus methods.
+ They are just annoying now.
+ * src/maemo/modest-platform.c:
+ (modest_platform_set_update_interval): Correct the D-Bus path, instead
+ of using a file path, though it did not seem to break things before.
+ It might be needed now:
+ Use the ALARM_EVENT_ACTIVATION flag so that emails are updated even when
+ modest is not already running. This is the behaviour of the old client, and
+ Mox says it is what we should do for modest.
+ This closes projects.maemo.org bug NB#64327.
+
+2007-08-04 Johannes Schmid <johannes.schmid@openismus.com>
+
+ * src/modest-text-utils.c:
+ Fixed invalid jump due to incorrect string/pointer
+ operation.
+ (See https://projects.maemo.org/trac/email/wiki/ValgrindErrors
+ for details)
+
+2007-08-01 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-account-mgr-helpers.h:
+ * src/modest-account-mgr-helpers.c:
+ Added modest_account_mgr_get_first_account_name(),
+ using code from modest_account_mgr_set_first_account_as_default().
+
+ * src/maemo/modest-main-window.c: Added set_at_least_one_account_visible().
+ (account_number_changed): Call set_at_least_one_account_visible() so that
+ the first account is visible when first added, without the user having to
+ use the View menu.
+ I do wonder how this worked before.
+
+2007-08-01 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account-store.c: (show_password_warning_only),
+ (show_wrong_password), (request_password_and_wait), (get_password),
+ (modest_tny_account_store_alert): Remove the (incomplete anyway)
+ attempts to show UI only in the main context, which used g_idle_add()
+ and mainloops, because tinymail now guarantees that it only calls these
+ callbacks in the mainloop with the gdk lock. This makes everything much
+ simpler.
+
+2007-08-01 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
+ Handle TNY_ACCOUNT_ERROR_TRY_CONNECT_SERVICE_UNAVAILABLE in the same
+ way as TNY_ACCOUNT_ERROR_TRY_CONNECT_HOST_LOOKUP_FAILED, showing an
+ error dialog, instead of ignoring it.
+
+2007-08-01 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-msg-view-window.c:
+ (modest_msg_view_window_get_header),
+ (modest_msg_view_window_last_message_selected):
+ Added comments to explain the use of priv->header_model.
+ * src/modest-ui-dimming-rules.c:
+ (modest_ui_dimming_rules_on_open_msg),
+ (modest_ui_dimming_rules_on_mark_as_read_msg),
+ (modest_ui_dimming_rules_on_mark_as_unread_msg),
+ (modest_ui_dimming_rules_on_remove_attachments),
+ (_invalid_attach_selected), (_selected_msg_marked_as):
+ Renamed _marked_as_deleted() to _selected_message_is_marked_as_deleted(),
+ and changed the parameter to a ModestMainWindow to make it clearer that
+ it never uses any other kind of window.
+ Added _message_is_marked_as_deleted() for examining a ModestMsgViewWindow
+ instead of the selected message.
+ I notice that much of the dimming code and the ModestMsgViewWindow code
+ hard-codes the assumption that the viewed message is always selected in
+ the header view. This does not seem wise or simple.
+
+ (modest_ui_dimming_rules_on_delete_msg): For a ModestMsgViewWindow,
+ examine the actual message instead of whatever might be selected
+ in the header view. This stops the delete toolbar button and menu item
+ from being dimmed when opening a message view the search UI,
+ partially fixing projects.maemo.org bug NB#63811.
+
+ However, when actually deleting, I now get this warning:
+ "tny_header_set_flags: This is a header instance for a new message.
+ Only priority and attachment flags are supported"
+
+2007-07-30 Johannes Schmid <johannes.schmid@openismus.com>
+
+ * src/modest-ui-actions.c: (modest_ui_actions_on_send):
+
+ Show account wizard if no accounts are defined while sending
+ (automatic sending after the account wizard finished does not
+ work because it takes some time until the account manager
+ synchronizes everything. (projects.maemo.org NB#62792)
+
+2007-07-30 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account-store.c: (on_account_removed),
+ (on_account_changed): Emit the ACCOUNT_UPDATE signal so that the
+ account is removed from the View menu. We have TnyAccountStore
+ and ModestTnyAccountStore signals that seem very similar, but this
+ seems to work for now.
+
+ * src/maemo/modest-main-window.c:
+ (on_show_account_action_activated): Prevent dereference
+ of a NULL if the accoutn does not really exist, though that
+ should not happen anymore.
+
+ This fixes projects.maemo.org bug NB#64606.
+
+2007-07-30 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-ui-actions.c: (run_account_setup_wizard),
+ (modest_ui_actions_on_accounts): Revert a change that set these
+ to modal dialogs, freezing the UI when they show secondary dialogs.
+ This fixed projects.maemo.org bug NB#64519.
+
+2007-07-27 Murray Cumming <murrayc@murrayc.com>
+
+ * src/widgets/modest-header-view-render.c:
+ (_modest_header_view_compact_header_cell_data):
+ Some checks and initialization to try to deal with a crash,
+ probably ineffective.
+
+2007-07-27 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-maemo-utils.c:
+ (modest_maemo_utils_get_supported_secure_authentication_methods):
+ Make sure that we have a connection, asking the user for one
+ if necessary.
+ * src/maemo/modest-main-window.c: (modest_main_window_on_show):
+ Check for a connection before showing the wizard, because
+ the wizard needs a connection to check for server capabilities.
+
+2007-07-27 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-account-view-window.c:
+ (on_new_button_clicked): Remember the wizard dialog instance,
+ so we can just present it again if necessary. This prevents
+ multiple windows from appearing if you click again quickly on the
+ New button before the dialog appears, fixing projects.maemo.org
+ bug NB#64169.
+
+2007-07-27 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-main-window.c: (modest_main_window_on_show):
+ Offer a connection dialog if there is no connection when
+ starting modest. This should fix projects.maemo.org bug NB#61134.
+
+2007-07-27 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
+ Reverted my last commit. I was able to fix the build by doing
+ apt-get install wpeditor0 (replacing other wpeditor packages) and
+ an explicit apt-get install wpeditor-dev to upgrade the -dev
+ package.
+
+2007-07-27 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
+ Commented out the use of wp_text_buffer_replace_image()
+ because it does not exist, to break the build. Added a TODO for it.
+
+2007-07-26 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account-store.c: (recreate_all_accounts):
+ Recreate them even if they were NULL before. I guess something
+ else was already creating them before, or this would never
+ have worked.
+ (modest_tny_account_store_get_server_account): Make sure that
+ the tny accounts have been created before trying to find one.
+ This allows libmodest_dbus_client_compose_mail() to work
+ when the UI is not yet visible.
+ This is probably useful in other cases too.
+
+ (get_password): When the password is wrong after it is entered
+ in the protected password dialog, show an info banner (in an
+ idle handler) before showing the protected password dialog
+ again.
+
+2007-07-26 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-ui-actions.h:
+ * src/modest-ui-actions.c: Added
+ modest_do_refresh_current_folder() containing some code from
+ modest_ui_actions_on_send_receive().
+ * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive):
+ Call modest_do_refresh_current_folder() before refreshing the
+ requested account, as in modest_ui_actions_on_send_receive().
+ This is strange, but seems to be necessary to show new mails.
+ Now new emails are finally visible in the UI when downloaded
+ via the automatic update interval, fixing bug NB#57458.
+ This also works because bug NB#57458 has been fixed somehow.
+
+2007-07-26 Murray Cumming <murrayc@murrayc.com>
+
+ * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
+ printf more details when we get unhandled D-Bus methods, because
+ it is interesting.
+
+ * src/modest-mail-operation.c: (update_account_thread):
+ Comment out the tny_camel_pop_store_account_reconnect(), because this
+ is apparently no longer needed, and it did not work before anyway.
+ See the comment in the code.
+
+ * src/modest-search.c: (modest_search_folder): Ignore deleted emails,
+ by checking the header flags. This fixes projects.maemo.org bug
+ NB#64225.
+
+2007-07-25 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-maemo-utils.h:
+ * src/maemo/modest-maemo-utils.c: Added
+ modest_maemo_show_information_note_in_main_context_and_forget().
+ * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
+ Use the new function to show simple error dialogs in the main
+ context, though question dialogs are still in the current context,
+ which is unfortunately usually not the main context. This should
+ fix some hangs.
+
+2007-07-25 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account-store.c: (get_password):
+ Never save the entered username and password in gconf,
+ because the UI spec says we should not. This helps
+ slightly with projects.maemo.org bug NB#63671.
+
+2007-07-25 Murray Cumming <murrayc@murrayc.com>
+
+ * src/widgets/modest-msg-edit-window.h:
+ * src/maemo/modest-msg-edit-window.c: (create_stream_for_uri):
+ Moved some code here to make it simpler.
+ (modest_msg_edit_window_attach_file_one): Renamed from
+ modest_msg_edit_window_attach_file_interactive().
+ (modest_msg_edit_window_offer_attach_file): Renamed from
+ modest_msg_edit_window_attach_file() and used
+ modest_msg_edit_window_attach_file_one() instead of
+ copy/pasting the code. The old code for one was not using
+ GnomeVFS. This allows use of smb:// URLs when using send-as
+ from external applications, fixing bug NB#63741.
+
+ (modest_msg_edit_window_insert_image),
+ (modest_msg_edit_window_add_attachment_clicked):
+ * src/modest-ui-actions.c: (modest_ui_actions_on_attach_file):
+ * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
+ Adapted to the new function names.
+
+2007-07-25 Murray Cumming <murrayc@murrayc.com>
+
+ (modest_platform_set_update_interval): Set the alarm recurrence
+ fields so that auto-update does not just happen the first time.
+ This should have fixed projects.maemo.org bug NB#63938.
+
+ When this happens you can see a printf when the D-Bus method is
+ called:
+ GLIB DEBUG default - debug: modest_dbus_req_handler: method received: SendReceive
+
+ However, I do not actually seem to get new POP messages even when
+ clicking the refresh button manually. A restart gets them.
+ This might be a problem in today's tinymail only.
+
+2007-07-24 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-maemo-global-settings-dialog.c:
+ (current_connection):
+ Avoid a crash (probably only in scratchbox) when strcmp()ing a
+ NULL when closing the dialog.
+
+2007-07-24 Murray Cumming <murrayc@murrayc.com>
+
+ * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
+ Remove the hacky send/receive that didn't work, and instead
+ refilter the treemodel to make the deleted email really vanish from
+ the UI (though the delete-from-menu code does has commented out
+ the code that does that). This fixes projects.maemo.org bug
+ NB#62859.
+
+2007-07-24 Murray Cumming <murrayc@murrayc.com>
+
+ * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
+ Try a couple of tricks to force the treeview to update (
+ poke the folder, and do a send/receive refresh), but the deleted
+ email still appears with a strike-through instead of really being
+ removed.
+
+2007-07-23 Murray Cumming <murrayc@murrayc.com>
+
+ * src/dbus_api/modest-dbus-callbacks.c:
+ (add_single_folder_to_list): Ignore TnyMergeFolder folders,
+ because their ID is not human-readable (see the comment about
+ improvements needed to the osso-email-interface API) and
+ TnyMergeFolder::get_id_func() currently crashes with DBC enabled.
+
+2007-07-23 Murray Cumming <murrayc@murrayc.com>
+
+ * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler),
+ (add_folders_to_list), (on_dbus_method_get_folders),
+ (modest_dbus_req_filter):
+ * src/maemo/modest-maemo-utils.c:
+ (on_camel_account_get_supported_secure_authentication):
+ * src/maemo/modest-main-window.c: (modest_main_window_set_style),
+ (on_header_view_focus_in):
+ * src/modest-email-clipboard.c: (modest_email_clipboard_set_data):
+ * src/modest-formatter.c: (modest_formatter_create_body_part):
+ * src/modest-mail-operation.c: (recurse_folders),
+ (update_account_thread), (get_msgs_full_thread),
+ (modest_mail_operation_get_msgs_full),
+ (modest_mail_operation_xfer_msgs):
+ * src/modest-search.c: (search_mime_part_and_child_parts),
+ (modest_search_account), (modest_search_all_accounts):
+ * src/modest-tny-account.c:
+ (modest_tny_account_get_special_folder), (recurse_folders):
+ * src/modest-tny-local-folders-account.c:
+ (modest_tny_local_folders_account_query_passes):
+ * src/modest-tny-msg.c: (copy_mime_part),
+ (modest_tny_msg_find_body_part_from_mime_part):
+ * src/modest-tny-send-queue.c: (modest_tny_send_queue_cancel),
+ (modest_tny_send_queue_try_to_send):
+ * src/modest-ui-actions.c: (modest_ui_actions_on_delete_message),
+ (_modest_ui_actions_open), (download_uncached_messages),
+ (reply_forward), (modest_ui_actions_on_copy),
+ (modest_ui_actions_on_details), (has_retrieved_msgs),
+ (msgs_move_to_confirmation), (open_msg_for_purge_cb),
+ (do_headers_action):
+ * src/modest-ui-dimming-rules.c: (_already_opened_msg),
+ (_selected_msg_marked_as), (_msg_download_completed),
+ (_selected_msg_sent_in_progress):
+ * src/widgets/modest-attachments-view.c:
+ (modest_attachments_view_set_message):
+ * src/widgets/modest-msg-view.c: (find_cid_image):
+ * tests/check_folder-transfer.c: (find_folders):
+ * tests/check_update-account.c: (func):
+ * tests/dbus_api/test_get_folders.c: (main):
+ Checked all uses of tny_iterator_get_current(), making sure
+ that the object is unreferenced (3 or 4 places did not),
+ and adding checks for NULL.
+
+2007-07-23 Murray Cumming <murrayc@murrayc.com>
+
+ * src/dbus_api/modest-dbus-callbacks.c:
+ (on_idle_open_default_inbox): Make sure that the application UI is
+ visible.
+ * src/maemo/easysetup/modest-easysetup-wizard.c:
+ (on_entry_invalid_character): Show the word whitespace instead
+ of (null) in the banner when whitespace was entered.
+ (show_error): Add a comment that this does not work in
+ Maemo Bora, though we do not know why.
+
+2007-07-23 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account.c:
+ (modest_tny_account_get_special_folder): Use an if instead of
+ an assert for when the parent account name is NULL, because this
+ might be causing a crash in projects.maemo.org bug 63192.
+ * src/modest-mail-operation.c:
+ (modest_mail_operation_send_new_mail_cb),
+ (modest_mail_operation_remove_folder): unref the folder that is
+ returned from modest_tny_account_get_special_folder().
+
+2007-07-23 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-ui-actions.c:
+ (modest_ui_actions_on_password_requested):
+ Show mail_ib_login_cancelled info banner when the user cancels
+ the protected password dialog, to fix projects.maemo.org
+ bug NB#63617.
+
+2007-07-23 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-account-settings-dialog.c:
+ (create_page_outgoing): Put this page in a GtkScrolledWindow,
+ matching the UI mock-up in the UI spec, and allowing access
+ to all widgets even when the on-screen keyboard is active.
+
+2007-07-23 Murray Cumming <murrayc@murrayc.com>
+
+ Reverted this previous commit from Johannes,
+ because the scrollbars are always visible and because
+ I think we only need it on onepage of the account
+ settings, not the account wizard.
+ (I wrote the wrong instructions in the bug.)
+
+ * src/maemo/easysetup/modest-easysetup-wizard.c:
+ Added scrollbars to account wizard dialog.
+ Fixed projects.maemo.org NB #62744
+
+2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
+
+ * src/maemo/easysetup/modest-easysetup-wizard.c:
+ (create_page_user_details):
+ Use auto-cap for name (projects.maemo.org NB#63716)
+ * src/widgets/modest-account-view.c: (on_account_busy_changed):
+
+2007-07-22 Armin Burgmeier <armin@openismus.com>
+
+ * src/maemo/modest-ui-actions.c: Use current account instead of
+ default account for creating viewer windows, so that the viewer
+ window knows to which account the viewed message belongs.
+
+ * src/maemo/modest-msg-view-window.c: Destroy the window when the
+ corresponding account is deleted. This fixes projects.maemo.org bug
+ NB#62936.
+
+2007-07-18 Armin Burgmeier <armin@openismus.com>
+
+ * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
+ the dialog close after entering an invalid port number and clicking
+ OK. This fixes projects.maemo.org bug NB#63602.
+
+2007-07-18 Armin Burgmeier <armin@openismus.com>
+
+ * src/modest-tny-account-store.c:
+ (get_server_accounts): Set parent modest account name for each
+ connection-specific transport account so that special folders of such
+ an account can be looked up. This fixes a crash when changing account
+ settings. This might also be related to projects.maemo.org bug
+ NB#63594.
+
+2007-07-16 Armin Burgmeier <armin@openismus.com>
+
+ * src/modest-ui-actions.c: Added a button to create a folder to the
+ move-to dialog. This fixes projects.maemo.org bug NB#59863.
+
+2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
+
+ * src/maemo/easysetup/modest-easysetup-wizard.c:
+ Added scrollbars to account wizard dialog.
+ Fixed projects.maemo.org NB #62744
+
+2007-07-16 Murray Cumming <murrayc@murrayc.com>
+
+ * src/widgets/modest-msg-view.h:
+ * src/widgets/modest-msg-view.c:
+ Added modest_msg_view_get_message_is_empty() but this needs
+ to be implemented.
+ * src/maemo/modest-msg-edit-window.c: (message_is_empty):
+ Check if there is any text in the message yet.
+ But this needs to be implemented properly.
+ (modest_msg_edit_window_toggle_find_toolbar):
+ * src/maemo/modest-msg-view-window.c:
+ (modest_msg_view_window_toggle_find_toolbar):
+ Show a banner warning if there is no text to search, when
+ trying to start a search. This partially fixes
+ projects.maemo.org bug NB#62350.
+
+2007-07-13 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-mail-operation.c: (update_account_thread):
+ Initialized num_new_headers to fix the build.
+
+2007-07-13 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-account-mgr.c: (modest_account_mgr_account_names):
+ Ignore modest accounts whose server accounts don't exist in gconf.
+ This prevents us trying to create TnyAccount instances for those
+ server accounts when the server account has been removed from gconf,
+ but the parent modest account has not yet been removed from modest.
+ I don't know why this is only noticeable now. It was probably just
+ a harmeless g_warning() anyway.
+
+2007-07-13 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
+ Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
+
+2007-07-12 Armin Burgmeier <armin@openismus.com>
+
+ * src/maemo/modest-main-window.c: Make default account appear bold
+ in view, tools/send & receive and toolbar/send & receive SCM menus.
+ This fixes projects.maemo.org bug NB#59010.
+
+2007-07-12 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
+ Add a short-cut, by checking if the folder store is an account.
+ This ensures that the Sort menu item and toolbar is dimmed for
+ the local-folders account root item, fixing
+ projects.maemo.org bug NB#62545.
+
+2007-07-12 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account-store.c: (get_password):
+ Show the password dialog (via the signal) only in the mainloop, via
+ an idle handler that we wait for. This could theoretically prevent
+ hangs, though I worry that it could introduce some too.
+
+2007-07-12 Murray Cumming <murrayc@murrayc.com>
+
+ * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
+ * src/maemo/modest-platform.c:
+ (modest_platform_connect_and_wait):
+ Take a TnyAccount* parameter and try to set it to online
+ (a TnyCamel-only API), because tinymail sets accounts to offline
+ when the user cancels a password dialog, and doesn't ask again until
+ it has been set to online.
+ However, this is commented out because it causes a hang now.
+
+ (modest_platform_connect_and_wait_if_network_account):
+ * src/modest-mail-operation.c:
+ (modest_mail_operation_update_account):
+ * src/modest-platform.h:
+ * src/modest-ui-actions.c: (_modest_ui_actions_open),
+ (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
+
+2007-07-12 Armin Burgmeier <armin@openismus.com>
+
+ * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
+
+ * src/modest-mail-operation.c:
+ * src/modest-ui-actions.c: Check for already existing folder before
+ querying the server, show error message from camel if the request
+ still fails. This fixes projects.maemo.org bug NB#58701.
+
+2007-07-12 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account-store.h:
+ * src/modest-tny-account-store.c:
+ Added modest_tny_account_store_forget_password_in_memory(),
+ (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
+ when creating a new account, so that new passwords will be used, instead of
+ us thinking that it's a second request as a result of a failed password again.
+
+2007-07-12 Murray Cumming <murrayc@murrayc.com>
+
+ * src/dbus_api/modest-dbus-callbacks.c:
+ (on_idle_open_message): If the message is in drafts then open it
+ in an edit window instead of a view window. This fixes
+ projects.maemo.org bug NB#63005.
+
+2007-07-12 Murray Cumming <murrayc@murrayc.com>
+
+ * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
+ Avoided a harmless g_warning().
+
+2007-07-12 Murray Cumming <murrayc@murrayc.com>
+
+ * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
+ Pass the modest account name, not the TnyAccount display name to
+ modest_msg_view_window_new() so that the reply feature works,
+ fixing projects.maemo.org bug NB#62892.
+
+ * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
+ (modest_msg_view_window_new_with_header_model):
+ * src/maemo/modest-msg-view-window.c:
+ (modest_msg_view_window_new_with_header_model),
+ (modest_msg_view_window_new):
+ * src/modest-ui-actions.c: (reply_forward):
+ * src/widgets/modest-msg-view-window.h:
+ * src/widgets/modest-window.c: (modest_window_set_active_account):
+ Rename an account parameter to modest_account_name to make this clearer.
+
+2007-07-11 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-ui-actions.h:
+ * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
+ modest_do_message_delete().
+ * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
+ Call modest_do_message_delete(), hoping that this would cause messages
+ to be really deleted from search instead of just marked with strike through.
+ Does not seem to help.
+
+2007-07-11 Armin Burgmeier <armin@openismus.com>
+
+ * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
+ priv->reselect to FALSE prior to calling
+ modest_folder_view_select_first_inbox_or_local() to prevent endless
+ recursion and thus a crash on startup.
+
+2007-07-11 Armin Burgmeier <armin@openismus.com>
+
+ * src/maemo/modest-account-settings-dialog.h: Include
+ <gtk/gtknotebook.h> to fix the build (at least for me).
+
+ * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
+ Use "New FolderN" as default suggested name if "New folder" already
+ exists, with N being the first free number, though never exceed "New
+ folder99" in which case we just fall back to "New Folder" even though
+ it already exists. This fixes projects.maemo.org bug NB#58663.
+
+2007-07-11 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
+ Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
+ projects.maemo.org bug NB#62778.
+
+2007-07-11 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
+ Ignore the wrong (for now) secure-smtp setting in the presets -
+ just default to requiring secure authentication for SMTP, because
+ that is most common.
+
+2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
+
+ * src/widgets/modest-folder-view.c: (filter_row)
+ Do not show drafts folder (see UI specs)
+
+2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
+
+ * src/modest-ui-actions.c:
+ Remove call to show_non_move_folders(TRUE) which was moved to a wrong
+ place and also not necessary.
+
+ * src/widgets/modest-folder-view.c: (filter_row)
+ Guess folder type and hide Sent & Outbox if necessary.
+ Fixed project.maemo.org NB#57328
+
+2007-07-11 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-ui-actions.h:
+ * src/modest-ui-actions.c:
+ (modest_ui_actions_on_delete_message):
+ Move some code into a new
+ modest_ui_actions_refresh_message_window_after_delete()
+ function so we can use it from elsewhere.
+
+ * src/dbus_api/modest-dbus-callbacks.c:
+ (on_idle_delete_message), (on_delete_message): Used an idle
+ handler, as we do for the other D-Bus method handlers.
+ Call modest_ui_actions_refresh_message_window_after_delete()
+ if the deleted message was open in a window. This fixed
+ projects.maemo.org bug NB#62862.
+
+2007-07-11 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-main.c: (main): Only show the UI at the start if
+ the showui command line option was given. For instance,
+ run-standalone src/modest showui
+ Otherwise, we wait for the top_application D-Bus method to
+ be sent by hildon-desktop when the application is selected
+ from the menu.
+ This allows us to run without a UI when osso-global-search
+ uses our D-Bus methods.
+
+2007-07-11 Murray Cumming <murrayc@murrayc.com>
+
+ * src/dbus_api/modest-dbus-api.h: Added a define for a
+ top-application D-Bus method.
+ * src/dbus_api/modest-dbus-callbacks.c:
+ (on_top_application),
+ (modest_dbus_req_handler): Handle the top-application D-Bus
+ method, which might be an undocumented D-Bus signal sent by
+ hildon-desktop when it starts the application from the menu.
+ But I am not sure and I need to test it on the device, because
+ my scratchbox does not have the application in the menu now.
+ This method shows the main window, so that it can be invisible
+ when started, for instance, just for email searching from
+ osso-global-search.
+
+ * src/maemo/modest-main-window.c: (restore_settings),
+ (modest_main_window_new): Do not show the window immediately
+ upon creation. We show it later.
+ * src/modest-widget-memory.c: (save_settings_paned):
+ Try (unsuccessfully) to avoid saving the paned position when
+ it is not even visible.
+ (restore_settings_paned): Do not allow a silly paned position.
+ This seems necessary when not showing the window at first.
+
+ * tests/dbus_api/Makefile.am:
+ * tests/dbus_api/test_top_application.c: (main): Test for the
+ new D-Bus method.
+
+2007-07-10 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-ui-dimming-rules.c:
+ (modest_ui_dimming_rules_on_new_msg),
+ (modest_ui_dimming_rules_on_reply_msg),
+ (modest_ui_dimming_rules_on_delete_msg),
+ (modest_ui_dimming_rules_on_details),
+ (modest_ui_dimming_rules_on_view_window_move_to),
+ (modest_ui_dimming_rules_on_view_previous),
+ (modest_ui_dimming_rules_on_view_next),
+ (_invalid_folder_for_purge): Added checks before
+ casting the window. This looks like an actual
+ logic error in _invalid_folder_for_purge(), because it
+ tries to use a ModestMainWindow as a message window.
+
+2007-07-10 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-account-settings-dialog.c:
+ (show_error): Use the same implementation as in
+ modest-easysetup-wizard.c:
+ (on_entry_invalid_character): The logical ID contains a %s.
+ Guessed what it should be.
+ (on_entry_max), (check_data), (on_response): Adapt to
+ changed show_error().
+ (create_page_account_details): Really call
+ modest_validating_entry_set_func() on the correct widgets.
+ * src/maemo/easysetup/modest-easysetup-wizard.c:
+ (on_entry_invalid_character): Fix the logical ID here too.
+ (create_page_account_details),
+ (create_page_user_details):
+ Really call
+ modest_validating_entry_set_func() on the correct widgets.
+
+ * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
+ Do not try to use the account if it is NULL.
+
+2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
+
+ * src/modest-ui-actions.c: (create_move_to_dialog),
+ (modest_ui_actions_on_main_window_move_to),
+ (modest_ui_actions_on_msg_view_window_move_to):
+ * src/widgets/modest-folder-view.c: (modest_folder_view_init),
+ (filter_row), (modest_folder_view_show_non_move_folders):
+ * src/widgets/modest-folder-view.h:
+
+ Hide Sent & Outbox folder in "move to"-dialog. Does not work for
+ the Sent folder yet as it does not report the correct folder type.
+
+2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
+
+ * src/maemo/modest-msg-edit-window.c: (init_window):
+ Fixed bora build
+
+2007-07-10 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
+ Take a parent widget instead of a parent window, and
+ implement this with hildon_banner_show_information() instead.
+ Non-Maemo builds can just ifdef that there.
+ This fixed projects.maemo.org bug NB#62766.
+
+ (on_entry_invalid_character): Use show_error() again instead
+ of using hildon directly, and use the _CS() macro to use the correct
+ translation domain.
+ (create_account), (check_for_supported_auth_methods), (on_entry_max):
+ Pass a widget instead od a window to show_error().
+
+2007-07-10 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
+ Adapt to the changed tinymail API, using the new TnyAccount* parameter.
+ This allows us to show the server name in the error message, fixing
+ projects.maemo.org bug NB#62904.
+ Also, use the appropriate logical ID message for the account protocol.
+
+2007-07-10 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account-store.c: (on_idle_wrong_password):
+ A compilation fix, though the build wasn't broken for me.
+
+2007-07-09 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
+ Do not try to unref a NULL folder store, to avoid a runtime warning.
+ This seems to happen sometimes when changing accounts settings.
+
+2007-07-09 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account-store.c:
+ (modest_tny_account_store_instance_init),
+ (modest_tny_account_store_finalize),
+ (on_account_settings_hide), (on_idle_wrong_password):
+ Use a GHashTable to ensure that we only show one account settings
+ dialog per modest account. This avoids us having a dialog open for
+ both the store and transport accounts, or due to repeated get_password()
+ calls that shouldn't happen anyway.
+
+2007-07-09 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-maemo-utils.c: (on_hide),
+ (modest_maemo_show_dialog_and_forget): Handle the response, because
+ the window is not even hidden by default.
+
+ * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
+ * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
+ Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
+ which seems to prevent some modality problems.
+
+ * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
+ Ignore user cancellation errors.
+
+ * src/modest-account-mgr-helpers.h:
+ * src/modest-account-mgr-helpers.c:
+ Added modest_server_account_get_password() and
+ modest_server_account_get_has_password() to avoid direct use of
+ conf enums.
+
+ * src/maemo/modest-account-settings-dialog.h:
+ * src/maemo/modest-account-settings-dialog.c:
+ (modest_account_settings_dialog_init): Store the notebook so we can
+ use it later.
+ Added modest_account_settings_dialog_switch_to_user_info().
+
+ * src/modest-tny-account-store.c:
+ (get_password): When the password in the account settings is wrong (we think),
+ show the relevant page of the account settings dialog, in the mainloop.
+ However, we currently get many of these at once because cancel does not
+ seem to cancel.
+ (forget_password): Do not forget the password
+ from the account settings, because this causes side-effects when
+ tinymail seems to call it at strange time, maybe because of how we
+ are cancelling get_password().
+ (modest_tny_account_store_alert): Ignore user cancellations.
+
+2007-07-09 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-maemo-utils.h:
+ * src/maemo/modest-maemo-utils.c:
+ Added modest_maemo_show_information_note_and_forget() for use instead of
+ gtk_dialog_run() when the response is not needed, to avoid an extra
+ mainloop which could cause a hang.
+
+ * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
+ Use the logical IDs for the error message, though they are not
+ specific enough. Note that I used modest_maemo_show_information_note_and_forget()
+ because gtk_dialog_run() caused a hang here (the window did not close).
+ This fixes projects.maemo.org bug NB#62646.
+
+2007-07-09 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-account-mgr-helpers.h:
+ * src/modest-account-mgr-helpers.c:
+ Added modest_account_mgr_get_store_protocol().
+
+ * src/maemo/modest-account-view-window.c:
+ (on_delete_button_clicked): Show different warning text depending on
+ the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
+ of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
+ NB#59037.
+
+2007-07-09 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-msg-edit-window.c:
+ (modest_msg_edit_window_attach_file): Set the file chooser dialog title
+ as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
+
+2007-07-07 Armin Burgmeier <armin@openismus.com>
+
+ * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
+ ckdg_ib_maximum_characters_reached from correct package.
+
+ * src/modest-ui-actions.c: Show an error message when a folder could
+ not be created. Tinymail does not give us specific error codes about
+ what has gone wrong, so we assume that a folder with that name
+ already exists, though there might be other reasons.
+
+2007-07-06 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
+ Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
+ give a more exact error message that can be partly translated.
+
+2007-07-05 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-address-book.c:
+ (select_email_addrs_for_contact): Specify a default window size for the
+ select-email-address dialog, so that it is probably big enough for the
+ title. This should fix projects.maemo.org bug NB#62277.
+
+2007-07-05 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/easysetup/modest-easysetup-wizard.c:
+ (create_page_complete_easysetup): Use
+ gtk_widget_set_size() request to ensure that the text wraps
+ even in osso 1.1.
+
+2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
+
+ * src/maemo/easysetup/modest-easysetup-wizard.c:
+ (on_entry_invalid_character), (create_page_account_details),
+ (create_page_user_details):
+ Use new API of ModestValidatingEntry. But for some reason the banner is
+ not shown. I will have to investigate that further.
+
+ * src/widgets/modest-validating-entry.c: (on_insert_text),
+ (modest_validating_entry_set_func):
+ * src/widgets/modest-validating-entry.h:
+ Added a new callback function to be able to react to prevented
+ characters whitespaces to e.g show a banner.
+
+2007-07-05 Armin Burgmeier <armin@openismus.com>
+
+ * src/maemo/modest-account-settings-dialog.c: Use the notify::value
+ notification of HildonNumberEditor instead of remembering the port
+ number. Thanks to Johannes for pointing this out.
+
+2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
+
+ * src/maemo/easysetup/modest-easysetup-wizard.c:
+ Check if there are any user changes before showing a confirmation
+ dialog (projects.maemo.org NB#60946)
+
+2007-07-05 Armin Burgmeier <armin@openismus.com>
+
+ * src/maemo/modest-account-settings-dialog.c: Remember custom port
+ number at the beginning of the dialog and set the modified flag at the
+ end if the port number has changed. This is necessary because
+ HildonNumberEditor does not support notification when the value has
+ changed.
+
+2007-07-05 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-ui-actions.c:
+ (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
+ a connection before asking anything else. Correct the check for the destination
+ folder so that it succeeds when online.
+ This fixed projects.maemo.org bug NB#61645.
+
+2007-07-05 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-ui-actions.c: (modest_ui_actions_on_send):
+ Call modest_platform_connect_and_wait() to ask for a connection if necessary,
+ to fix projects.maemo.org bug NB#62439.
+
+2007-07-05 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account.c: (on_connection_status_changed):
+ Really do not use tny_device_force_offline() here. See the previous comment.
+
+2007-07-04 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account.c: (on_connection_status_changed):
+ Do not use tny_device_force_offline() when tinymail says that something
+ went wrong with the connection. It seems to report this unnecessarily.
+
+2007-07-04 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-connection-specific-smtp-window.c:
+ (modest_connection_specific_smtp_window_init):
+ Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
+ does not seem to have any effect in osso 1.1 (though it works in
+ Maemo Bora). This fixes bug projects.maemo.org NB#59212.
+
+2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
+
+ * src/maemo/modest-connection-specific-smtp-window.c:
+ Fix UI specification problems with projects.meamo.org NB#60479
+
+2007-07-04 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
+ clue when this has failed, because the error dialog is not always shown
+ (at least in earlier version).
+
+ (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
+ GError message, because the generic error dialog is not helpful.
+ I am getting
+ 'This message is not currently available (can't let a new connection go online)'
+ when trying to open an IMAP message.
+
+ (_modest_ui_actions_open): Offer a connection when some messages would
+ have to be downloaded and we are offline.
+
+2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
+
+ * src/widgets/modest-folder-view.c:
+ Don't check for MERGE type anymore as we use the correct type
+ now.
+ NOTE: For the last two changes you need to update your tinymail copy
+ because of API changes!
+
+2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
+
+ * src/modest-tny-local-folders-account.c:
+ Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
+ (see projects.maemo.org NB#61580)
+
+2007-07-04 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account.c: (on_connection_status_changed):
+ Commented out the call to modest_platform_connect_and_wait() because this
+ seems to always hang, and I would like to know if this is the only thing
+ that causes a hang when showing the connection dialog.
+ It is not very useful anyway.
+
+2007-07-04 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-msg-view-window.c:
+ (modest_msg_view_window_select_next_message):
+
+ * src/modest-platform.h:
+ * src/maemo/modest-platform.c:
+ Added modest_platform_connect_and_wait(), which calls
+ tny_maemo_conic_device_connect() always in the main thread, by calling it
+ in an idle handler and waiting for the idle handler to run. It should be
+ in the main thread because it uses GTK+ UI code. It just returns TRUE
+ if the device is already online.
+
+ There is some nasty code to ensure that subsequent calls to
+ modest_platform_connect_and_wait() just wait for the first one to finish,
+ by checking repeatedly in another idle handler. This is necessary,
+ because other threads (or even the main thread, via another idle handler)
+ can call modest_platform_connect_and_wait() while
+ modest_platform_connect_and_wait() is running.
+
+ (modest_platform_connect_and_wait_if_network_account),
+ (modest_platform_connect_and_wait_if_network_folderstore):
+ Convenience functions that calls modest_platform_connect_and_wait() if
+ the account or folder might want network access.
+
+ * src/modest-mail-operation.c:
+ (modest_mail_operation_update_account):
+ * src/modest-ui-actions.c: (download_uncached_messages),
+ (modest_ui_actions_on_rename_folder), (delete_folder),
+ (modest_ui_actions_on_main_window_move_to),
+ (modest_ui_actions_on_msg_view_window_move_to):
+ * src/widgets/modest-folder-view.c:
+ (drag_and_drop_from_folder_view):
+ Offer a connection if we are offline.
+
+ * src/modest-tny-account.c: (on_connection_status_changed):
+ Document this as only handling errors during network operations in progress,
+ and replace the idle code with a simple call to
+ modest_platform_connect_and_wait(), which does this instead.
+
+2007-07-03 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account.c:
+ (modest_tny_account_get_special_folder): (util_on_idle),
+ Handle the GError so we can see when tny_folder_store_get_folders()
+ fails, as it currently does while something else is connecting.
+
+ Added util_run_in_main_thread_and_wait()
projects / modest / blobdiff