+2007-09-11 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-account-settings-dialog.c:
+ (modest_account_settings_dialog_set_account_name): Set the incoming
+ secure-auth checkbox only when a secure auth method is really specified
+ in gconf. For some reason, it was set also if a secure connection was
+ chosen, but that does not make sense to me, and was not commented.
+ For instance, this stops the user from seeing an error about unsupported
+ secure authentication when editing a gmail account.
+
+2007-09-05 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-maemo-utils.c:
+ (on_camel_account_get_supported_secure_authentication),
+ (modest_maemo_utils_get_supported_secure_authentication_methods):
+ Adapted to the changed tinymail signature of the callback, and
+ printf a warning when there is an exception, as a clue.
+
+2007-09-03 Armin Burgmeier <armin@openismus.com>
+
+ * src/maemo/modest-maemo-utils.c: Don't set the temporary account
+ online that checks for supported authentication methods. This fixes
+ projects.maemo.org bug NB#61369.
+
+2007-09-03 Murray Cumming <murrayc@murrayc.com>
+
+ * src/widgets/modest-folder-view.c: (strings_are_equal),
+ (on_model_foreach_set_name), (on_get_mmc_account_name),
+ (text_cell_data): Restored this code that was removed in
+ svn revision 3165 by jfernandez, because this late name-discovery
+ really is necessary sometimes. This is the correct fix to the endless
+ calling of this function:
+ * src/modest-tny-account.c: (on_modest_file_system_info):
+ Don't call tny_account_set_name() when the name is already correct,
+ to avoid unnecessary (endless) updates to the tree model.
+
+2007-08-31 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-defs.h: Rename MODEST_CONF_CONNECTION_SPECIFIC_SMTP_LIST to
+ MODEST_CONF_CONNECTION_SPECIFIC_SMTP_LIST and make it a global list
+ for use by all accounts that enable the MODEST_ACCOUNT_USE_CONNECTION_SPECIFIC_SMTP
+ boolean, because this is the specified behaviour in the UI spec.
+ * src/modest-account-mgr-helpers.h:
+ * src/modest-account-mgr-helpers.c:
+ (modest_account_mgr_set_connection_specific_smtp),
+ (modest_account_mgr_remove_connection_specific_smtp),
+ (modest_account_mgr_get_connection_specific_smtp): Remove the account_name
+ parameter.
+ * src/maemo/modest-connection-specific-smtp-window.h:
+ * src/maemo/modest-connection-specific-smtp-window.c:
+ (modest_connection_specific_smtp_window_finalize),
+ (modest_connection_specific_smtp_window_fill_with_connections),
+ (modest_connection_specific_smtp_window_save_server_accounts):
+ Remove the account_name parameters and member variable.
+ * src/maemo/easysetup/modest-easysetup-wizard.c:
+ (on_button_outgoing_smtp_servers), (create_account):
+ * src/maemo/modest-account-settings-dialog.c:
+ (on_button_outgoing_smtp_servers), (check_data),
+ (modest_account_settings_dialog_set_account_name),
+ (save_configuration):
+ * src/maemo/modest-maemo-utils.c: (on_account_online),
+ (modest_maemo_utils_get_supported_secure_authentication_methods):
+ * src/modest-tny-account-store.c:
+ (get_smtp_specific_transport_account_for_open_connection),
+ (insert_account), (add_connection_specific_transport_accounts):
+ * src/modest-ui-actions.c: (on_smtp_servers_window_hide),
+ (modest_ui_actions_on_smtp_servers):
+ Adapt to the changed API.
+
+2007-08-29 Armin Burgmeier <armin@openismus.com>
+
+ * src/modest-protocol-info.h:
+ * src/modest-protocol-info.c: Added
+ modest_protocol_info_get_auth_protocol() to translate an
+ authentication protocol name to the corresponding enum value.
+
+ * src/maemo/modest-maemo-utils.c: Fixed supported auth protocol list
+ generation using the newly added function.
+
+ * src/maemo/modest-account-settings-dialog.c: Use the current element
+ when traversing through the list of supported authentication methods,
+ not always the first.
+
+2007-08-29 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/easysetup/modest-easysetup-wizard.c:
+ (check_first_supported_auth_method), (on_before_next),
+ (create_account):
+ * src/maemo/modest-account-settings-dialog.c: (check_data):
+ Some cleanup, to make the code clearer.
+
+2007-08-29 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
+ Use the mail_ni_ssl_certificate_error ("Secure connection failed")
+ logical ID when the secure authentication method is not supported by
+ the server, as requested by Mox on the wiki, though I hate not
+ giving the user the clue.
+
+2007-08-29 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-search.c: (modest_search_all_accounts):
+ * src/modest-platform.h:
+ * src/maemo/modest-platform.c: Moved and renamed
+ check_and_wait_for_account_is_online() to
+ modest_platform_check_and_wait_for_account_is_online() so it
+ can be used in more places.
+
+2007-08-29 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
+ Removed the sleep(1) experiment because it does not seem to help,
+ and I should not have checked the experiment in anyway.
+ The problem is maybe in the TnyAccount connected state - I will
+ investigate that instead.
+
+2007-08-28 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
+ Added a sleep(1) in case it helps with bug #66769.
+
+2007-08-28 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-search.c: (on_timeout_check_account_is_online),
+ (check_and_wait_for_account_is_online):
+ It is OK for local-folder and mmc accounts to be used when they
+ are in the _INIT folder, instead of waiting for them to change
+ (they never do).
+ For POP and IMAP, wait from them to stop being _INIT, rather than
+ waiting from them to be _CONNECTED, because that seems to be
+ the status that causes the problems.
+
+2007-08-28 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-search.c: (check_and_wait_for_account_is_online):
+ Actually pass the account to the timeout callback.
+
+2007-08-28 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-search.c: (on_timeout_check_account_is_online):
+ Added some debug output to help me debug a problem on the N800.
+ (check_and_wait_for_account_is_online): Fail immediately if the
+ device is offline.
+ modest_search_all_accounts(): Try the search even if the account does
+ not seem to be online, because this can work sometimes, and should work
+ with the cache if there is no active libconic connection.
+
+2007-08-27 Armin Burgmeier <armin@openismus.com>
+
+ * src/modest-tny-send-queue.c: Implement TnyFolderObserver and
+ observe outbox for added messages to assign them a status. Previously,
+ this was done in modest_tny_send_queue_add(), but the message id might
+ not yet be known at that point. This reduces warnings when sending
+ mail, though I am not sure how this even worked before.
+
+2007-08-27 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-account-settings-dialog.c:
+ (modest_account_settings_dialog_init):
+ * src/maemo/modest-connection-specific-smtp-edit-window.c:
+ (modest_connection_specific_smtp_edit_window_init):
+ * src/maemo/modest-connection-specific-smtp-window.c:
+ (modest_connection_specific_smtp_window_init):
+ * src/maemo/modest-maemo-utils.c:
+ (modest_maemo_utils_get_supported_secure_authentication_methods):
+ * src/maemo/modest-platform.c:
+ (modest_platform_run_folder_name_dialog):
+ * src/maemo/modest-signature-editor-dialog.c:
+ (modest_signature_editor_dialog_init):
+ * src/modest-ui-actions.c: (modest_ui_actions_on_item_not_found),
+ (modest_ui_actions_on_password_requested), (create_move_to_dialog):
+ * src/widgets/modest-global-settings-dialog.c:
+ (modest_global_settings_dialog_init):
+ Replace all uses of GTK_STOCK_OK (and GTK_BUTTONS_OK) with
+ mcen_bd_dialog_ok,
+ GTK_STOCK_CANCEL with mcen_bd_dialog_cancel,
+ GTK_STOCK_EDIT with mcen_bd_edit, and
+ GTK_STOCK_CLOSE with mcen_bd_close,
+ to fix projects.maemo.org bug NB#64995.
+ I strongly believe that Maemo's GTK+ should have the wanted translations
+ instead of duplicating this in each application and complicating the code.
+
+2007-08-27 Armin Burgmeier <armin@openismus.com>
+
+ * src/maemo/modest-msg-edit-window.c: Fixed a crash due to endless
+ recursion when entering text in the subject field.
+
+2007-08-27 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-search.c: Added check_and_wait_for_account_is_online(),
+ which checks every second, 10 times, to wait until the account is online
+ so that we can use it, if the account is in the process of going online.
+ (modest_search_all_accounts): Use check_and_wait_for_account_is_online()
+ so that searching works even when the application was not yet started before.
+ This fixes projects.maemo.org bug NB#63784, at least in scratchbox.
+
+2007-08-24 Armin Burgmeier <armin@openismus.com>
+
+ * src/modest-widget-memory.c: Always show the default account when the
+ application is started, as stated in the UI spec. This fixes
+ projects.maemo.org bug NB#66630.
+
+2007-08-24 Armin Burgmeier <armin@openismus.com>
+
+ * src/maemo/modest-platform.c:
+ (modest_platform_run_rename_folder_dialog): Use logical IDs instead of
+ english text for strings in the rename folder dialog, fixing
+ projects.maemo.org bug NB#66338.
+
+2007-08-22 Armin Burgmeier <armin@openismus.com>
+
+ * src/widgets/modest-account-view.c: Fix for bora by using
+ MODEST_HAVE_HILDON0_WIDGETS instead of MODEST_HILDON_VERSION_0. The
+ latter seems not be used anymore.
+
+ * src/maemo/easysetup/modest-easysetup-provider-combo-box.c: Some
+ minor optimizations.
+
+ * src/maemo/modest-main-window.c: Update menu items when the default
+ account changes so that the current default account is always bolded.
+ This fixes maemo.projects.org bug NB#66173.
+
+2007-08-17 Murray Cumming <murrayc@murrayc.com>
+
+ * src/dbus_api/modest-dbus-callbacks.c:
+ (on_dbus_method_get_folders): Avoid trying to get the account name
+ when there are no accounts, to avoid critical g_warnings, fixing
+ projects.maemo.org bug NB#65574.
+
+2007-08-17 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg):
+ Use modest_account_mgr_get_signature() instead of accessing gconf
+ directly, to slightly simplify the code.
+ * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
+ Append the signature also when opening via other applications,
+ fixing projects.maemo.org bug NB#65828.
+
+2007-08-17 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_msg_id):
+ Check for NULLs to prevent a crash when opening an email that is
+ an attachment in another email, fixing projects.maemo.org bug
+ NB#66012.
+
+2007-08-17 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-ui-dimming-rules.c:
+ (modest_ui_dimming_rules_on_view_window_move_to):
+ Enable the Move To toolbar button for search results, fixing the
+ last part of projects.maemo.org bug NB#63807.
+
+2007-08-17 Murray Cumming <murrayc@murrayc.com>
+
+ * src/dbus_api/modest-dbus-callbacks.c:
+ (check_and_offer_account_creation): Use gdk_thread_enter/leave(),
+ because this is called from idle handlers, to fix hangs afte the
+ wizard closes.
+ (find_message_by_url): Added a TODO comment about a crash that
+ happens when tinymail was built with DBC checks.
+
+2007-08-16 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-search.c: (modest_search_folder):
+ * src/modest-search.h: Rename ModestSearch::before to start_date
+ and after to end_date, using the same names as the libogs struct
+ fields.
+ * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
+ The start_date and end_date were swapped in the check. This
+ fixes date range searches, fixing projects.maemo.org bug NB#63407.
+
+2007-08-16 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-account-view-window.c:
+ Added (check_for_active_acount).
+ (on_delete_button_clicked), (on_edit_button_clicked):
+ When an account is doing something (such as refreshing),
+ show the same warning for account deletion as for account
+ editing, to fix projects.maemo.org bug NB#64588.
+
+2007-08-16 Murray Cumming <murrayc@murrayc.com>
+
+ * src/widgets/modest-msg-view-window.h:
+ * src/gnome/modest-msg-view-window.c:
+ * src/maemo/modest-msg-view-window.c:
+ Added modest_msg_view_window_construct().
+ (modest_msg_view_window_new_with_header_model),
+ Added modest_msg_view_window_new_for_search_result),
+ Renamed modest_msg_view_window_new() to
+ modest_msg_view_window_new_for_attachment(),
+ and modest_msg_view_window_is_search_result(),
+ so we can explicitly know that the window is for an
+ attachment or a search result or a message from the list.
+
+ (modest_msg_view_window_view_attachment):
+ * src/modest-ui-actions.c: (open_msg_cb): Use the renamed function.
+ * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
+ Use modest_msg_view_window_new_for_search_result().
+
+ * src/modest-ui-dimming-rules.c:
+ (modest_ui_dimming_rules_on_delete_msg): Enable the delete button
+ for search results, fixing projects.maemo.org bug NB#63811.
+
+2007-08-16 Armin Burgmeier <armin@openismus.com>
+
+ * src/modest-ui-actions.c: Show a banner instead of a dialog when
+ renaming a folder fails, to stay consistent with what happens when
+ creating a folder fails.
+
+ * src/maemo/easysetup/modest-easysetup-country-combo-box.c: Optimized
+ slightly country loading from the mmc_mappings file, fixed a memory
+ leak.
+
+2007-08-16 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account-store.c: (volume_path_is_mounted):
+ Check the GnomeVFSVolume activation path instead of the device path,
+ so that the memory card is really really shown in the UI.
+
+2007-08-16 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/easysetup/modest-easysetup-wizard.c:
+ (get_entered_account_title), (on_before_next), (entry_is_empty),
+ (create_account):
+ * src/maemo/modest-account-settings-dialog.c:
+ (get_entered_account_title), (on_button_signature), (check_data),
+ (save_configuration), (entry_is_empty):
+ Strip the account title of whitespace at the start and end before
+ using it or checking it. This means that an all-whitespace title
+ is not allowed, fixing projects.maemo.org bug NB#64977.
+
+2007-08-15 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-ui-actions.h:
+ * src/modest-ui-actions.c: Renamed modest_run_account_setup_wizard()
+ to modest_run_account_setup_wizard() and made it public.
+ * src/dbus_api/modest-dbus-callbacks.c:
+ (check_and_offer_account_creation), (on_idle_mail_to),
+ (on_idle_compose_mail), (on_idle_open_default_inbox):
+ Offer account creation if necessary, fixing projects.maemo.org
+ bug NB#63713.
+
+2007-08-15 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-ui-actions.c: (run_account_setup_wizard):
+ Return a gboolean to indicate success.
+ (modest_ui_actions_on_new_msg), (open_msg_cb), (reply_forward),
+ (modest_ui_actions_on_send): When offering account creation, only
+ give up (return) if account creation failed. Otherwise continue
+ with the original request. This fixed projects.maemo.org bug
+ NB#64317.
+
+2007-08-15 Murray Cumming <murrayc@murrayc.com>
+
+ * src/widgets/modest-recpt-editor.c:
+ (modest_recpt_editor_instance_init): Turn off hildon auto-capitalization,
+ to fix projects.maemo.org bug NB#63789.
+
+2007-08-15 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account-store.c: Added volume_path_is_mounted().
+ (modest_tny_account_store_new): Properly detect the memory card at
+ startup, and add an account for it.
+
+2007-08-14 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account-store.c: (modest_tny_account_store_new):
+ Commented out the MMC code again because it mistakenly detects
+ the card even when it isn't inserted.
+
+2007-08-14 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account-store.c: (modest_tny_account_store_new):
+ Renabled the call to add_mmc_account() because I do not believe
+ it could be the cause of the mentioned hang (in scratchbox, where
+ there is no memory card), and because I have tested that it works
+ on the device.
+
+2007-08-14 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account-store.c: (modest_tny_account_store_new):
+ Comment out part of the last commit because it apparently causes
+ a hang.
+
+2007-08-14 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account-store.c: Added the add_mmc_account()
+ function to save some copy/pasting.
+ (modest_tny_account_store_new): If the memory card is mounted,
+ create an account for it at the start, instead of waiting for the
+ user to unmount it and mount it.
+
+2007-08-13 Murray Cumming <murrayc@murrayc.com>
+
+ * src/widgets/modest-account-view.c: (on_account_changed):
+ Do not try to use the human-readable TnyAccount name instead of the
+ ID of the modest account to get the transport account. And unref
+ the transport account. This prevents a g_warning(), and a possible
+ ref leak.
+
+2007-08-13 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-platform.c:
+ (modest_platform_set_update_interval): Handle the new
+ alarmd error to warn when alarmd is not running, as is the case in
+ scratchbox for me now because
+ "Module /usr/lib/alarmd/libretu.so initialization failed"
+
+2007-08-13 Murray Cumming <murrayc@murrayc.com>
+
+ * src/widgets/modest-header-view-render.c:
+ (_modest_header_view_compact_header_cell_data):
+ NULL some strings after freeing them, trying to deal with
+ the double deletion found in projects.maemo.org bug 64183,
+ probably having no effect.
+
+2007-08-13 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-account-settings-dialog.c:
+ (create_page_incoming), (create_page_outgoing): Use a define
+ for the min and max port numbers.
+
+ (check_hildon_number_editor_and_warn_value_not_in_range),
+ (check_data): Do an extra check for an invalid port number, as needed
+ in projects.maemo.org bug #64275, when the number is cleared, but this
+ does not work due to bugs.maemo.org bug #1806.
+
2007-08-13 Murray Cumming <murrayc@murrayc.com>
* src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
2007-07-16 Armin Burgmeier <armin@openismus.com>
* src/modest-ui-actions.c: Added a button to create a folder to the
- move-to dialog. This fixes projects.maemo.org bug NB#.
+ move-to dialog. This fixes projects.maemo.org bug NB#59863.
2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
projects / modest / blobdiff