-2007-06-29 Murray Cumming <murrayc@murrayc.com
+2007-07-09 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-maemo-utils.h:
+ * src/maemo/modest-maemo-utils.c:
+ Added modest_maemo_show_information_note_and_forget() for use instead of
+ gtk_dialog_run() when the response is not needed, to avoid an extra
+ mainloop which could cause a hang.
+
+ * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
+ Use the logical IDs for the error message, though they are not
+ specific enough. Note that I used modest_maemo_show_information_note_and_forget()
+ because gtk_dialog_run() caused a hang here (the window did not close).
+
+2007-07-09 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-account-mgr-helpers.h:
+ * src/modest-account-mgr-helpers.c:
+ Added modest_account_mgr_get_store_protocol().
+
+ * src/maemo/modest-account-view-window.c:
+ (on_delete_button_clicked): Show different warning text depending on
+ the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
+ of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
+ NB#59037.
+
+2007-07-09 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-msg-edit-window.c:
+ (modest_msg_edit_window_attach_file): Set the file chooser dialog title
+ as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
+
+2007-07-07 Armin Burgmeier <armin@openismus.com>
+
+ * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
+ ckdg_ib_maximum_characters_reached from correct package.
+
+ * src/modest-ui-actions.c: Show an error message when a folder could
+ not be created. Tinymail does not give us specific error codes about
+ what has gone wrong, so we assume that a folder with that name
+ already exists, though there might be other reasons.
+
+2007-07-06 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
+ Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
+ give a more exact error message that can be partly translated.
+
+2007-07-05 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-address-book.c:
+ (select_email_addrs_for_contact): Specify a default window size for the
+ select-email-address dialog, so that it is probably big enough for the
+ title. This should fix projects.maemo.org bug NB#62277.
+
+2007-07-05 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/easysetup/modest-easysetup-wizard.c:
+ (create_page_complete_easysetup): Use
+ gtk_widget_set_size() request to ensure that the text wraps
+ even in osso 1.1.
+
+2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
+
+ * src/maemo/easysetup/modest-easysetup-wizard.c:
+ (on_entry_invalid_character), (create_page_account_details),
+ (create_page_user_details):
+ Use new API of ModestValidatingEntry. But for some reason the banner is
+ not shown. I will have to investigate that further.
+
+ * src/widgets/modest-validating-entry.c: (on_insert_text),
+ (modest_validating_entry_set_func):
+ * src/widgets/modest-validating-entry.h:
+ Added a new callback function to be able to react to prevented
+ characters whitespaces to e.g show a banner.
+
+2007-07-05 Armin Burgmeier <armin@openismus.com>
+
+ * src/maemo/modest-account-settings-dialog.c: Use the notify::value
+ notification of HildonNumberEditor instead of remembering the port
+ number. Thanks to Johannes for pointing this out.
+
+2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
+
+ * src/maemo/easysetup/modest-easysetup-wizard.c:
+ Check if there are any user changes before showing a confirmation
+ dialog (projects.maemo.org NB#60946)
+
+2007-07-05 Armin Burgmeier <armin@openismus.com>
+
+ * src/maemo/modest-account-settings-dialog.c: Remember custom port
+ number at the beginning of the dialog and set the modified flag at the
+ end if the port number has changed. This is necessary because
+ HildonNumberEditor does not support notification when the value has
+ changed.
+
+2007-07-05 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-ui-actions.c:
+ (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
+ a connection before asking anything else. Correct the check for the destination
+ folder so that it succeeds when online.
+ This fixed projects.maemo.org bug NB#61645.
+
+2007-07-05 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-ui-actions.c: (modest_ui_actions_on_send):
+ Call modest_platform_connect_and_wait() to ask for a connection if necessary,
+ to fix projects.maemo.org bug NB#62439.
+
+2007-07-05 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account.c: (on_connection_status_changed):
+ Really do not use tny_device_force_offline() here. See the previous comment.
+
+2007-07-04 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account.c: (on_connection_status_changed):
+ Do not use tny_device_force_offline() when tinymail says that something
+ went wrong with the connection. It seems to report this unnecessarily.
+
+2007-07-04 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-connection-specific-smtp-window.c:
+ (modest_connection_specific_smtp_window_init):
+ Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
+ does not seem to have any effect in osso 1.1 (though it works in
+ Maemo Bora). This fixes bug projects.maemo.org NB#59212.
+
+2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
+
+ * src/maemo/modest-connection-specific-smtp-window.c:
+ Fix UI specification problems with projects.meamo.org NB#60479
+
+2007-07-04 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
+ clue when this has failed, because the error dialog is not always shown
+ (at least in earlier version).
+
+ (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
+ GError message, because the generic error dialog is not helpful.
+ I am getting
+ 'This message is not currently available (can't let a new connection go online)'
+ when trying to open an IMAP message.
+
+ (_modest_ui_actions_open): Offer a connection when some messages would
+ have to be downloaded and we are offline.
+
+2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
+
+ * src/widgets/modest-folder-view.c:
+ Don't check for MERGE type anymore as we use the correct type
+ now.
+ NOTE: For the last two changes you need to update your tinymail copy
+ because of API changes!
+
+2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
+
+ * src/modest-tny-local-folders-account.c:
+ Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
+ (see projects.maemo.org NB#61580)
+
+2007-07-04 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account.c: (on_connection_status_changed):
+ Commented out the call to modest_platform_connect_and_wait() because this
+ seems to always hang, and I would like to know if this is the only thing
+ that causes a hang when showing the connection dialog.
+ It is not very useful anyway.
+
+2007-07-04 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-msg-view-window.c:
+ (modest_msg_view_window_select_next_message):
+
+ * src/modest-platform.h:
+ * src/maemo/modest-platform.c:
+ Added modest_platform_connect_and_wait(), which calls
+ tny_maemo_conic_device_connect() always in the main thread, by calling it
+ in an idle handler and waiting for the idle handler to run. It should be
+ in the main thread because it uses GTK+ UI code. It just returns TRUE
+ if the device is already online.
+
+ There is some nasty code to ensure that subsequent calls to
+ modest_platform_connect_and_wait() just wait for the first one to finish,
+ by checking repeatedly in another idle handler. This is necessary,
+ because other threads (or even the main thread, via another idle handler)
+ can call modest_platform_connect_and_wait() while
+ modest_platform_connect_and_wait() is running.
+
+ (modest_platform_connect_and_wait_if_network_account),
+ (modest_platform_connect_and_wait_if_network_folderstore):
+ Convenience functions that calls modest_platform_connect_and_wait() if
+ the account or folder might want network access.
+
+ * src/modest-mail-operation.c:
+ (modest_mail_operation_update_account):
+ * src/modest-ui-actions.c: (download_uncached_messages),
+ (modest_ui_actions_on_rename_folder), (delete_folder),
+ (modest_ui_actions_on_main_window_move_to),
+ (modest_ui_actions_on_msg_view_window_move_to):
+ * src/widgets/modest-folder-view.c:
+ (drag_and_drop_from_folder_view):
+ Offer a connection if we are offline.
+
+ * src/modest-tny-account.c: (on_connection_status_changed):
+ Document this as only handling errors during network operations in progress,
+ and replace the idle code with a simple call to
+ modest_platform_connect_and_wait(), which does this instead.
+
+2007-07-03 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account.c:
+ (modest_tny_account_get_special_folder): (util_on_idle),
+ Handle the GError so we can see when tny_folder_store_get_folders()
+ fails, as it currently does while something else is connecting.
+
+ Added util_run_in_main_thread_and_wait()
+ which uses an idlen handler and mainloop to ensure that the function
+ is called in the main thread.
+ (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
+ to make sure that we call attempt the connection in the mainloop only,
+ which might solve some hangs.
+
+2007-07-03 Murray Cumming <murrayc@murrayc.com>
+
+ (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
+ be found by their display name. This is never useful.
+ * src/modest-tny-account-store.c: (on_account_removed): Find the account
+ by its ID, instead of trying to use its ID as its display name.
+
+ * src/modest-tny-account-store.h:
+ * src/modest-tny-account.c:
+ (modest_tny_account_get_special_folder): Add a g_warning() when
+ tny_folder_store_get_folders() returns an empty list for the maildir.
+
+ * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
+ Add a g_warning() when this returns NULL, because that it not allowed
+ by tinymail.
+
+2007-07-02 Armin Burgmeier <armin@openismus.com>
+
+ * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
+ note when trying to cancel the wizard. This fixes projects.maemo.org
+ bug NB#60946.
+
+2007-07-02 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account.h:
+ * src/modest-tny-account.c:
+ (modest_tny_account_new_from_server_account),
+ (modest_tny_account_new_from_server_account_name),
+ (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
+ because this must now be set before setting the proto. This is usd in
+ modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
+ warning in camel_session_get_service() caused by
+ tny_camel_transport_account_prepare().
+
+ * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
+ session parameter.
+
+2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
+
+ * src/maemo/modest-connection-specific-smtp-edit-window.c:
+ (on_value_changed),
+ (modest_connection_specific_smtp_edit_window_init):
+
+ Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
+ of "changed" for now
+
+2007-06-29 Murray Cumming <murrayc@murrayc.com>
* src/modest-tny-account.c:
(modest_tny_account_new_from_server_account):
projects / modest / blobdiff