+2007-04-24 Murray Cumming <murrayc@murrayc.com>
+
+ * src/dbus_api/modest-dbus-api.h:
+ * src/dbus_api/modest-dbus-callbacks.c:
+ Use an idle callback to execute the modest code in the application's own thread.
+ Remove the helloworld example method.
+ Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
+ parsed, and the open-message method is not implemented because this is not yet implemented in
+ modest itself.
+ * libmodest-dbus-client/libmodest-dbus-client.c:
+ (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
+ (libmodest_dbus_client_open_message):
+ * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
+
+ * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
+ body without crashing.
+
+ * tests/dbus_api/Makefile.am:
+ * tests/dbus_api/test_mail_to.c:
+ * tests/dbus_api/test_open_message.c: New tests for the new methods.
+
+2007-04-24 Murray Cumming <murrayc@murrayc.com>
+
+ * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
+ Added file to fix the build. Sorry.
+
+ * src/dbus_api/Makefile.am:
+ * src/dbus_api/modest-dbus-api.h:
+ * src/dbus_api/modest-dbus-callbacks.h:
+ * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
+ (modest_dbus_req_handler):
+ Put constants in a separate header so it can be reused by the
+ client library, without duplication
+
+ * libmodest-dbus-client/Makefile.am:
+ * libmodest-dbus-client/libmodest-dbus-client.c:
+ (libmodest_dbus_client_call_helloworld),
+ (libmodfest_dbus_client_send_mail),
+ (libmodfest_dbus_client_mailto),
+ (libmodfest_dbus_client_open_message):
+ * libmodest-dbus-client/libmodest-dbus-client.h:
+ (Partly) Implement a send_mail D-Bus method.
+
+ * tests/dbus_api/Makefile.am:
+ * tests/dbus_api/test_send_mail.c: (main): Added a test for
+ the send_email D-Bus method.
+
+2007-04-24 Murray Cumming <murrayc@murrayc.com>
+
+ * Makefile.am:
+ * configure.ac:
+ * libmodest-dbus-client/Makefile.am:
+ * libmodest-dbus-client/libmodest-dbus-client.c:
+ * libmodest-dbus-client/libmodest-dbus-client.h:
+ * tests/dbus_api/Makefile.am:
+ * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
+ for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
+
+2007-04-24 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/easysetup/modest-easysetup-wizard.c:
+ (create_page_account_details):
+ * src/maemo/modest-account-settings-dialog.c:
+ (create_page_account_details): Explicitly set auto-capitalization mode for the title
+ widgets, because this might not be the default in future versions of the Maemo GTK+.
+ However, I can not not get capitalization to work even in a simple test case.
+
+2007-04-24 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/easysetup/modest-easysetup-wizard.c:
+ (create_page_custom_incoming), (create_page_custom_outgoing):
+ * src/maemo/modest-account-settings-dialog.c:
+ (create_page_account_details), (create_page_incoming),
+ (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
+ instead of using gtk_check_button_with_label(), so they are aligned like the other
+ widgets, as per the UI spec.
+
+2007-04-24 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/easysetup/modest-easysetup-wizard.c:
+ * src/maemo/modest-connection-specific-smtp-edit-window.c:
+ * src/widgets/modest-validating-entry.c:
+ * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
+ Modest prefix instead of an EasySetup prefix.
+
+2007-04-23 Murray Cumming <murrayc@murrayc.com>
+
+ * src/widgets/modest-validating-entry.h:
+ * src/widgets/modest-validating-entry.c: (on_insert_text),
+ Added easysetup_validating_entry_set_max_func(), used to set a callback
+ to call when the max number of characters is reached. GtkEntry has a max-length
+ already but is silent about it.
+
+ * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
+ (create_page_account_details), (create_page_user_details),
+ (create_account):
+ * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
+ (create_page_account_details), (create_page_user_details),
+ (create_page_outgoing):
+ * src/modest-ui-actions.c: (modest_ui_actions_on_details):
+ Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
+ the UI spec, when the user tries to enter more than the max number of characters.
+
+2007-04-23 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/easysetup/modest-easysetup-wizard.c:
+ (create_page_user_details), (create_page_custom_incoming),
+ (create_page_custom_outgoing):
+ * src/maemo/modest-account-settings-dialog.c:
+ (create_page_user_details), (create_page_incoming),
+ (create_page_outgoing):
+ * src/maemo/modest-connection-specific-smtp-edit-window.c:
+ (modest_connection_specific_smtp_edit_window_init):
+ Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
+ not appropriate. Bad Maemo-specific defaults!.
+
+2007-04-23 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
+ (on_toggle_button_changed), (modest_signature_editor_dialog_init),
+ (modest_signature_editor_dialog_set_settings):
+ Disable the label and textview when the checkbox is disabled, and use the
+ specified (UI spec) default signature text.
+
+2007-04-23 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-connection-specific-smtp-edit-window.c:
+ (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
+
+ * src/modest-defs.h:
+ * src/modest-account-mgr-helpers.h:
+ * src/modest-account-mgr-helpers.c:
+ Added modest_account_mgr_get/set_signature(), using new gconf keys.
+
+ * src/maemo/Makefile.am:
+ * src/maemo/modest-signature-editor-dialog.c:
+ * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
+ as per the UI spec.
+
+ * src/maemo/modest-account-settings-dialog.h:
+ * src/maemo/modest-account-settings-dialog.c:
+ (modest_account_settings_dialog_finalize), (on_button_signature),
+ (save_configuration): Use the new dialog when the Edit button is pressed, and
+ save the changes if necessary, as per the UI spec.
+
+2007-04-23 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/Makefile.am:
+ * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
+ based on maemo-develoers email from Dirk.
+
+ * src/maemo/easysetup/modest-easysetup-wizard.c:
+ (create_page_welcome), (create_page_account_details),
+ (create_page_user_details), (create_page_complete_easysetup),
+ (create_page_custom_incoming), (create_page_custom_outgoing),
+ (create_page_complete_custom),
+ (modest_easysetup_wizard_dialog_init):
+ * src/maemo/modest-account-settings-dialog.c:
+ (create_page_account_details), (create_page_user_details),
+ (create_page_incoming), (create_page_outgoing),
+ (modest_account_settings_dialog_init):
+ * src/maemo/modest-connection-specific-smtp-window.c:
+ (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
+
+2007-04-23 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/easysetup/modest-easysetup-wizard.c:
+ (create_page_account_details), (create_page_custom_outgoing),
+ (create_page_complete_custom):
+ * src/maemo/modest-account-settings-dialog.c:
+ (create_page_user_details), (create_page_incoming),
+ (create_page_outgoing):
+ * src/maemo/modest-connection-specific-smtp-edit-window.c:
+ (modest_connection_specific_smtp_edit_window_init):
+ Use the correct (UI spec) port min/max, and use horizontal separators,
+ as per the UI spec.
+
+2007-04-23 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/easysetup/modest-easysetup-wizard.c:
+ (set_default_custom_servernames):
+ * src/maemo/modest-account-settings-dialog.c:
+ (create_page_incoming), (on_combo_outgoing_security_changed),
+ (on_combo_incoming_security_changed), (create_page_outgoing),
+ (modest_account_settings_dialog_set_account_name),
+ (save_configuration):
+ * src/maemo/modest-connection-specific-smtp-edit-window.c:
+ (on_combo_security_changed),
+ (modest_connection_specific_smtp_edit_window_init),
+ (modest_connection_specific_smtp_edit_window_set_connection),
+ (modest_connection_specific_smtp_edit_window_get_settings):
+ Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
+ as per the UI spec.
+
+2007-04-20 Murray Cumming <murrayc@murrayc.com>
+
+ * po/en_GB.po:
+ * src/maemo/easysetup/modest-easysetup-wizard.c:
+ (create_page_custom_outgoing), (create_page_complete_custom):
+ * src/maemo/modest-account-settings-dialog.c:
+ (create_page_user_details), (create_page_outgoing):
+ * src/maemo/modest-account-view-window.c: (button_box_new):
+ Use changed logical IDs as per the most recent UI spec:
+ mcen_bd_emailsetup_edit -> mcen_bd_edit
+ mcen_bd_emailsetup_delete -> mcen_bd_delete
+ mcen_bd_emailsetup_close -> mcen_bd_close
+
+2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
+
+ * configure.ac:
+ * src/Makefile.am:
+ * src/dbus_api/Makefile.am:
+ * src/dbus_api/modest-dbus-callbacks.c:
+ * src/dbus_api/modest-dbus-callbacks.h:
+ * src/maemo/modest-platform.c: (modest_platform_init):
+ Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
+ method.
+ * tests/Makefile.am:
+ * tests/dbus_api/Makefile.am:
+ * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
+
+2007-04-20 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-account-settings-dialog.c:
+ * src/maemo/modest-connection-specific-smtp-edit-window.c:
+ Removed unnecessary includes.
+
+2007-04-20 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/easysetup/modest-easysetup-wizard.c:
+ * src/maemo/modest-account-settings-dialog.c:
+ * src/maemo/modest-connection-specific-smtp-edit-window.c:
+ * src/widgets/Makefile.am:
+ * src/widgets/modest-easysetup-secureauth-combo-box.c:
+ * src/widgets/modest-easysetup-secureauth-combo-box.h:
+ * src/widgets/modest-easysetup-serversecurity-combo-box.c:
+ * src/widgets/modest-easysetup-serversecurity-combo-box.h:
+ * src/widgets/modest-secureauth-combo-box.c:
+ * src/widgets/modest-secureauth-combo-box.h:
+ * src/widgets/modest-serversecurity-combo-box.c:
+ * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
+ made the GObject names more consistent with the rest of the Modest code.
+
+2007-04-20 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/easysetup/Makefile.am:
+ * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
+ * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
+ * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
+ * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
+ * src/maemo/easysetup/modest-easysetup-wizard.c:
+ * src/maemo/easysetup/modest-validating-entry.c:
+ * src/maemo/easysetup/modest-validating-entry.h:
+ * src/maemo/modest-account-settings-dialog.c:
+ * src/maemo/modest-connection-specific-smtp-edit-window.c:
+ * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
+ widgets/ because they are used outside of easysetup too. After checking in,
+ svn will allow me to rename them too.
+
+2007-04-20 Murray Cumming <murrayc@murrayc.com>
+
+ * src/gnome/modest-msg-edit-window.c:
+ (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
+ linker error, to fix the build on the GNOME platform.
+ modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
+ modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
+ ifdefed out to avoid a warning.
+
+2007-04-20 Murray Cumming <murrayc@murrayc.com>
+
+ * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
+ use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
+ some alternative for GTK+ 2.6.
+
+2007-04-19 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-address-book.c: Added include to avoid a warning.
+
+ * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
+ specified for EmailAccountsDialog in UI spec.
+
+ * src/maemo/easysetup/modest-easysetup-wizard.c:
+ * src/maemo/easysetup/modest-easysetup-wizard.h:
+ * src/maemo/modest-account-settings-dialog.c:
+ * src/maemo/modest-account-settings-dialog.h:
+ Reuse a member window widget for the connection-specific SMTP server accounts,
+ so we can tell it to create/save the accounts only if we actually save changes.
+
+ * src/maemo/modest-connection-specific-smtp-edit-window.h:
+ * src/maemo/modest-connection-specific-smtp-edit-window.c:
+ (modest_connection_specific_smtp_edit_window_get_settings):
+ Return a struct instance for temporarily remembering the entered data.
+
+ * src/maemo/modest-connection-specific-smtp-window.h:
+ * src/maemo/modest-connection-specific-smtp-window.c:
+ (modest_connection_specific_smtp_window_finalize),
+ (modest_connection_specific_smtp_window_fill_with_connections),
+ (on_button_edit),
+ (modest_connection_specific_smtp_window_save_server_accounts),
+ (update_model_server_names): Do not actually save data until asked,
+ when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
+
+ (on_selection_changed),
+ (modest_connection_specific_smtp_window_init): Disable the edit
+ button when nothing is selected.
+
+ * src/modest-account-mgr-helpers.c:
+ * src/modest-account-mgr-helpers.h:
+ Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
+ elsewhere.
+
+2007-04-19 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-account-mgr-helpers.h:
+ * src/modest-account-mgr-helpers.c:
+ (modest_account_mgr_get_unused_account_name),
+ (modest_account_mgr_get_unused_account_display_name): Added these
+ utility functions, to avoid code duplication.
+
+ * src/maemo/easysetup/modest-easysetup-wizard.c:
+ (create_page_account_details), (create_account):
+ * src/maemo/modest-connection-specific-smtp-edit-window.c:
+ (on_combo_security_changed),
+ (modest_connection_specific_smtp_edit_window_init),
+ (modest_connection_specific_smtp_edit_window_save_settings):
+ * src/maemo/modest-connection-specific-smtp-edit-window.h:
+ * src/maemo/modest-connection-specific-smtp-window.c:
+ (modest_connection_specific_smtp_window_finalize),
+ (modest_connection_specific_smtp_window_fill_with_connections),
+ (on_button_edit), (modest_connection_specific_smtp_window_init):
+ * src/maemo/modest-connection-specific-smtp-window.h:
+ Implementing saving of connection-specific server accounts.
+
+ But I need to refactor this so we can save the data for each
+ possible connection-specific account and only actually create the server accounts
+ when the easysetup finished, or the OK button is pressed on the account settings
+ dialog.
+
+2007-04-18 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-connection-specific-smtp-edit-window.c:
+ (on_combo_security_changed):
+ (modest_connection_specific_smtp_edit_window_init):
+ Auto-fill the port number as in the account settings.
+
+ (modest_connection_specific_smtp_edit_window_set_connection):
+ * src/maemo/modest-connection-specific-smtp-edit-window.h:
+ * src/maemo/modest-connection-specific-smtp-window.c:
+ (fill_with_connections), (on_button_edit),
+ (modest_connection_specific_smtp_window_init):
+ Turn the edit window into a dialog to simplify the code, and
+ set a WM hint as in a GtkDialog, because only a popup can be on top of
+ another window in Maemo, and popups usually have no WM decoration.
+
+ * src/modest-defs.h:
+ * src/modest-account-mgr-helpers.c:
+ (modest_account_mgr_set_connection_specific_smtp),
+ (modest_account_mgr_remove_connection_specific_smtp),
+ (modest_account_mgr_get_connection_specific_smtp):
+ * src/modest-account-mgr-helpers.h: Some functions to write the
+ connection-specific SMTP server information. Not yet used.
+
+
+ * src/widgets/modest-folder-view.c: (text_cell_data):
+ Fix a warning about an uninitialized variable.
+ (on_configuration_key_changed): Put an #ifdef around the use
+ of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
+
+2007-04-18 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-account-settings-dialog.h:
+ * src/maemo/modest-account-settings-dialog.c:
+ Added connect_for_modified() utility function to mark the new modified boolean.
+
+ (create_page_account_details), (create_page_user_details),
+ (create_page_incoming), (create_page_outgoing), (on_response),
+ (modest_account_settings_dialog_init),
+ (modest_account_settings_dialog_set_account_name):
+ Only warn about unsaved changes when there are actually unsaved changes.
+
+ * src/modest-account-mgr-helpers.c:
+ * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
+ into the ModestServerAccountData struct. I do not use it yet, but someone might expect
+ to get the data from there in future.
+
+2007-04-18 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-defs.h:
+
+ * src/modest-account-mgr-helpers.h:
+ * src/modest-account-mgr-helpers.c:
+ Store the security account setting in a single conf key instead of using
+ the options list, so that the list is left for just the to-be-removed camel hack,
+ and because gconf_client_set_list() is failing for some reason.
+
+ * src/modest-account-mgr.c:
+ (modest_account_mgr_add_server_account):
+ * src/maemo/modest-account-settings-dialog.c:
+ (modest_account_settings_dialog_set_account_name),
+ (save_configuration): Use the renamed functions.
+
+
+2007-04-18 Murray Cumming <murrayc@murrayc.com>
+
+ * src/widgets/Makefile.am:
+ * src/widgets/modest-limit-retrieve-combo-box.c:
+ * src/widgets/modest-limit-retrieve-combo-box.h:
+ * src/widgets/modest-retrieve-combo-box.c:
+ * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
+ the account settings dialog.
+
+ * src/modest-defs.h:
+ * src/modest-account-mgr-helpers.h:
+ * src/modest-account-mgr-helpers.c:
+ (modest_server_account_get_option_secure_auth),
+ (modest_server_account_set_option_secure_auth):
+ * src/modest-account-mgr.c:
+ (modest_account_mgr_add_server_account):
+ Use the existing AUTH_MECH conf key for the secure-auth setting,
+ instead of putting it in the list options, because this was actually used already.
+
+ * src/maemo/modest-account-settings-dialog.c:
+ (create_page_account_details),
+ (modest_account_settings_dialog_set_account_name),
+ (save_configuration):
+ * src/maemo/modest-account-settings-dialog.h:
+ Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
+ Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
+
+2007-04-18 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
+ * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
+ Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
+
+ * src/modest-defs.h:
+ * src/maemo/modest-account-settings-dialog.c:
+ (create_page_incoming), (on_combo_outgoing_security_changed),
+ (on_combo_incoming_security_changed), (create_page_outgoing),
+ (modest_account_settings_dialog_set_account_name),
+ (save_configuration): Load/Save the port number, and change it when the
+ security combo changes, to suitable defaults.
+
2007-04-17 Murray Cumming <murrayc@murrayc.com>
* src/modest-account-mgr.c:
projects / modest / blobdiff