2007-08-04 Johannes Schmid <johannes.schmid@openismus.com>
[modest] / ChangeLog2
index 63f70a5..934bd57 100644 (file)
@@ -1,3 +1,96 @@
+2007-08-04  Johannes Schmid <johannes.schmid@openismus.com>
+
+       * src/modest-text-utils.c:
+       Fixed invalid jump due to incorrect string/pointer
+       operation. 
+       (See https://projects.maemo.org/trac/email/wiki/ValgrindErrors
+       for details)
+
+2007-08-01  Murray Cumming  <murrayc@murrayc.com>
+
+       * src/modest-account-mgr-helpers.h:
+       * src/modest-account-mgr-helpers.c:
+       Added modest_account_mgr_get_first_account_name(), 
+       using code from modest_account_mgr_set_first_account_as_default().
+
+       * src/maemo/modest-main-window.c: Added set_at_least_one_account_visible().
+       (account_number_changed): Call set_at_least_one_account_visible() so that 
+       the first account is visible when first added, without the user having to 
+       use the View menu.
+       I do wonder how this worked before.
+
+2007-08-01  Murray Cumming  <murrayc@murrayc.com>
+
+       * src/modest-tny-account-store.c: (show_password_warning_only),
+       (show_wrong_password), (request_password_and_wait), (get_password),
+       (modest_tny_account_store_alert): Remove the (incomplete anyway) 
+       attempts to show UI only in the main context, which used g_idle_add() 
+       and mainloops, because tinymail now guarantees that it only calls these 
+       callbacks in the mainloop with the gdk lock. This makes everything much 
+       simpler.
+
+2007-08-01  Murray Cumming  <murrayc@murrayc.com>
+
+       * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
+       Handle TNY_ACCOUNT_ERROR_TRY_CONNECT_SERVICE_UNAVAILABLE in the same 
+       way as TNY_ACCOUNT_ERROR_TRY_CONNECT_HOST_LOOKUP_FAILED, showing an 
+       error dialog, instead of ignoring it.
+
+2007-08-01  Murray Cumming  <murrayc@murrayc.com>
+
+       * src/maemo/modest-msg-view-window.c:
+       (modest_msg_view_window_get_header),
+       (modest_msg_view_window_last_message_selected):
+       Added comments to explain the use of priv->header_model.
+       * src/modest-ui-dimming-rules.c:
+       (modest_ui_dimming_rules_on_open_msg),
+       (modest_ui_dimming_rules_on_mark_as_read_msg),
+       (modest_ui_dimming_rules_on_mark_as_unread_msg),
+       (modest_ui_dimming_rules_on_remove_attachments),
+       (_invalid_attach_selected), (_selected_msg_marked_as):
+       Renamed _marked_as_deleted() to _selected_message_is_marked_as_deleted(), 
+       and changed the parameter to a ModestMainWindow to make it clearer that 
+       it never uses any other kind of window.
+       Added _message_is_marked_as_deleted() for examining a ModestMsgViewWindow 
+       instead of the selected message.
+       I notice that much of the dimming code and the ModestMsgViewWindow code 
+       hard-codes the assumption that the viewed message is always selected in 
+       the header view. This does not seem wise or simple.
+
+       (modest_ui_dimming_rules_on_delete_msg): For a ModestMsgViewWindow, 
+       examine the actual message instead of whatever might be selected 
+       in the header view. This stops the delete toolbar button and menu item
+       from being dimmed when opening a message view the search UI, 
+       partially fixing projects.maemo.org bug NB#63811.
+
+       However, when actually deleting, I now get this warning:
+       "tny_header_set_flags: This is a header instance for a new message. 
+       Only priority and attachment flags are supported"
+
+2007-07-30  Johannes Schmid <johannes.schmid@openismus.com>
+
+       * src/modest-ui-actions.c: (modest_ui_actions_on_send):
+       
+       Show account wizard if no accounts are defined while sending
+       (automatic sending after the account wizard finished does not
+       work because it takes some time until the account manager
+       synchronizes everything. (projects.maemo.org NB#62792)
+       
+2007-07-30  Murray Cumming  <murrayc@murrayc.com>
+
+       * src/modest-tny-account-store.c: (on_account_removed),
+       (on_account_changed): Emit the ACCOUNT_UPDATE signal so that the 
+       account is removed from the View menu. We have TnyAccountStore 
+       and ModestTnyAccountStore signals that seem very similar, but this 
+       seems to work for now.
+
+       * src/maemo/modest-main-window.c:
+       (on_show_account_action_activated): Prevent dereference 
+       of a NULL if the accoutn does not really exist, though that 
+       should not happen anymore.
+
+       This fixes projects.maemo.org bug NB#64606.
+
 2007-07-30  Murray Cumming  <murrayc@murrayc.com>
 
        * src/modest-ui-actions.c: (run_account_setup_wizard),