2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
[modest] / ChangeLog2
index ea80e71..b5264bd 100644 (file)
@@ -1,3 +1,315 @@
+2007-06-17  Johannes Schmid <johannes.schmid@openismus.com>
+
+       * configure.ac:
+       Fixed build with hildon < 0.99
+       
+       * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
+       Check if the selected account is busy instead of checking all accounts
+       
+       * src/modest-account-mgr-priv.h:
+       * src/modest-account-mgr.c: (modest_account_mgr_class_init),
+       (modest_account_mgr_init), (compare_account_name),
+       (modest_account_mgr_set_account_busy),
+       (modest_account_mgr_account_is_busy):
+       * src/modest-account-mgr.h:
+       Added busy information to the account manager. It possible to
+       set an account to busy or not busy now.
+       
+       * src/modest-mail-operation.c: (modest_mail_operation_finalize),
+       (modest_mail_operation_update_account),
+       (modest_mail_operation_notify_end):
+               Set the account to busy/not busy depending on the operation state.
+
+       * src/widgets/modest-account-view.c:
+       (modest_account_view_finalize), (get_last_updated_string),
+       (update_account_view), (on_account_busy_changed), (init_view):
+       Show string "Refreshing..." if the account is currently busy.
+
+       All this fixes projects.maemo.org bug NB#59711
+
+2007-06-14  Armin Burgmeier  <armin@openismus.com>
+
+       * src/widgets/modest-attachments-view.h:
+       * src/widgets/modest-attachments-view.c: Added
+       modest_attachments_view_has_attachments() and fixed coordinate
+       transformation in get_att_view_at_coords(). This fixes attachment
+       selection.
+
+       * src/widgets/modest-msg-view.c: Make use of
+       modest_attachments_view_has_attachments() to decide whether to show
+       attachments in the header.
+
+2007-06-14  Johannes Schmid <johannes.schmid@openismus.com>
+
+       * src/maemo/modest-connection-specific-smtp-edit-window.c:
+       (on_change), (on_combo_security_changed),
+       (modest_connection_specific_smtp_edit_window_init),
+       (modest_connection_specific_smtp_edit_window_set_connection),
+       (modest_connection_specific_smtp_edit_window_is_dirty):
+       * src/maemo/modest-connection-specific-smtp-edit-window.h:
+       * src/maemo/modest-connection-specific-smtp-window.c:
+       (on_button_edit):
+       
+       Show an comfirmation dialog for the smpt-edit-window if there are
+       unsaved changes and the user hits cancel.
+       (projects.maemo.org bug NB#60479)
+
+2007-06-14  Armin Burgmeier  <armin@openismus.com>
+
+       * src/maemo/easysetup/modest-easysetup-wizard.c:
+       * src/maemo/modest-account-settings-dialog.c: Show "invalid email
+       address" info in banner instead of node, and select all the text as
+       per UI spec. This fixes projects.maemo.org bug NB#60550.
+
+2007-06-14  set REAL_NAME environment variable  <set EMAIL_ADDRESS environment variable>
+
+       reviewed by: <delete if not using a buddy>
+
+       * src/maemo/modest-main-window.c: (_on_msg_count_changed):
+       * src/modest-ui-actions.c: (folder_refreshed_cb):
+
+2007-06-14  Murray Cumming  <murrayc@murrayc.com>
+
+       * src/widgets/modest-folder-view.c: (filter_row):
+       Explictly filter out the per-account outbox accounts. I don't know why 
+       these only sometimes show up, but now they should never show up in the UI.
+       This should fix projects.maemo.org bug NB#60160.
+
+2007-06-14  Murray Cumming  <murrayc@murrayc.com>
+
+       * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
+       when the toolbar does not exist yet.
+       * src/modest-widget-memory.c: (save_settings_header_view):
+       Added g_warnings() to help us to discover when we are trying to set 
+       an empty columns list in gconf.
+
+2007-06-14  Murray Cumming  <murrayc@murrayc.com>
+
+       * src/modest-init.h:
+       * src/modest-init.c: 
+       Added modest_init_get_default_header_view_column_ids().
+
+       * src/modest-widget-memory.c: (restore_settings_header_view):
+       Use the new function to get defaults, if the gconf key is empty, 
+       instead of not creating any columns. This seems to fix the 
+       empty right-hand pane problems.
+       
+       * src/widgets/modest-header-view.h: Improved documentation.
+
+2007-06-13  Murray Cumming  <murrayc@murrayc.com>
+
+       * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
+       Revert the use of the display name as the account name, because this
+       is generally wrong and would break the code that follows.
+
+2007-06-13  Johannes Schmid <johannes.schmid@openismus.com>
+
+       * src/maemo/easysetup/modest-easysetup-wizard.c:
+       (check_for_supported_auth_methods), (on_before_next),
+       (create_account):
+       
+       More correct fix for projects.maemo.org bug NB# 58991
+       Do not longer accept AUTH_PASSWORD as secure method and choose
+       correct method when creating the account.
+
+2007-06-13  Johannes Schmid <johannes.schmid@openismus.com>
+
+       * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
+       Fixed projects.maemo.org bug NB# 58991
+
+2007-06-13  Murray Cumming  <murrayc@murrayc.com>
+
+       * src/modest-init.c: (modest_init_init_core),
+       (modest_init_local_folders): Fixed compilation errors.
+
+2007-06-13  Murray Cumming  <murrayc@murrayc.com>
+
+       * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
+       Remove unnecessary lib/include, though it is good in principle when needed.
+       
+       * src/modest-init.c: (modest_init_one_local_folder),
+       (modest_init_local_folders):
+       * src/modest-init.h: Initialize the .modest library for memory cards, 
+       instead of just doing nothing for them. This should allow us to create 
+       folders there, fixing projects.maemo.org bug NB#59297.
+
+2007-06-13  Murray Cumming  <murrayc@murrayc.com>
+
+       * libmodest-dbus-client/libmodest-dbus-client.c:
+       (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
+       (libmodest_dbus_client_compose_mail),
+       (libmodest_dbus_client_open_message),
+       (libmodest_dbus_client_send_and_receive),
+       (libmodest_dbus_client_open_default_inbox):  Improved debug messages.
+       
+       * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
+       (on_idle_open_message), (modest_dbus_req_handler),
+       (search_result_to_message), (modest_dbus_req_filter):
+       * src/modest-search.c: (add_hit), (modest_search_folder),
+       (modest_search_all_accounts): Improved debug messages.
+       
+       * tests/dbus_api/test_open_message.c: (main): Improved comments.
+       
+       * src/modest-tny-account-store.c:
+       (modest_tny_account_store_get_tny_account_by): Initialize a variable to 
+       fix the build.
+
+2007-06-13  Murray Cumming  <murrayc@murrayc.com>
+
+
+2007-06-12  Murray Cumming  <murrayc@murrayc.com>
+
+       * src/modest-tny-account-store.c: (get_server_accounts):
+       Call modest_tny_local_folders_account_add_merged_outbox_folders() 
+       even when there are no accounts, so that the Outbox folder is always 
+       visible. This fixes projects.maemo.org bug NB#60158.
+
+2007-06-12   Murray Cumming  <murrayc@murrayc.com>
+
+       * src/maemo/modest-main-window.c: (create_details_widget):
+       Use the mcen_va_never logical ID.
+
+2007-06-12  Murray Cumming  <murrayc@murrayc.com>
+
+       * src/dbus_api/modest-dbus-api.h:
+       * src/dbus_api/modest-dbus-callbacks.c:
+       (on_idle_open_default_inbox), (on_open_default_inbox),
+       (modest_dbus_req_handler):
+       Added a new OpenDefaultInbox method.
+       
+       * libmodest-dbus-client/libmodest-dbus-client.h:
+       * libmodest-dbus-client/libmodest-dbus-client.c:
+       Added libmodest_dbus_client_open_default_inbox() to call the new 
+       dbus method. This should be useful to projects.maemo.org bug NB#57214,
+       though it should maybe be used by a new osso-email-interface function.
+       
+       * tests/dbus_api/Makefile.am:
+       * tests/dbus_api/test_open_default_inbox.c: Added a test for the new 
+       function.
+
+2007-06-12  Murray Cumming  <murrayc@murrayc.com>
+
+       * src/modest-account-mgr.c: (on_key_change): Append to the list, not to 
+       NULL, so that the signals get all the keys. This should not actually 
+       change any behaviour because we currently update everything when anything 
+       changes.
+
+2007-06-12  Murray Cumming  <murrayc@murrayc.com>
+
+       * src/widgets/modest-folder-view.c: (text_cell_data),
+       (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
+       (find_inbox_iter): If tinymail tells us that the folder is 
+       a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
+       This causes the inbox to be selected at startup, fixing part of 
+       projects.maemo.org bug NB#56305.
+
+       * src/modest-ui-dimming-rules.c:
+       (modest_ui_dimming_rules_on_tools_smtp_servers):
+       * src/modest-ui-dimming-rules.h: Added a callback function to dim 
+       the SMTP servers menu item.
+       * src/maemo/modest-main-window-ui-dimming.h: Used the function, so 
+       that the SMTP Servers menu item is dimmed when there are no accounts, 
+       as a future version of the UI spec will require. This fixes 
+       projects.maemo.org bug NB#56305.
+
+2007-06-11  Johannes Schmid <johannes.schmid@openismus.com>
+
+       * src/maemo/modest-maemo-utils.c:
+       (modest_maemo_utils_get_supported_secure_authentication_methods):
+       Added label to dialog instead of unreadable title
+       
+       * src/maemo/modest-main-window.c: (sync_accounts_cb),
+       (modest_main_window_new):
+       Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
+       dead code.
+       
+       * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
+       * src/modest-account-mgr.h:
+       Added method to avoid code duplication
+       
+       * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
+       (modest_ui_actions_on_send_receive):
+       Use modest_account_mgr_has_accounts
+
+2007-06-11  Murray Cumming  <murrayc@murrayc.com>
+
+       * src/maemo/easysetup/modest-presets.c:
+       (modest_presets_get_info_server_security): Do not report secure auth 
+       if there is none.
+       * src/modest-protocol-info.c: Use the defines for the gconf key names 
+       for secure authentication. This was not working because we were writing 
+       Password and reading password, and the check was case sensitive.
+       With this, gmail now works for receiving and sending when created via 
+       easysetup.
+
+2007-06-11  Murray Cumming  <murrayc@murrayc.com>
+
+       * src/maemo/easysetup/modest-presets.c:
+       (modest_presets_get_info_server_security): Correct the key name for 
+       SecureSmtp, because it seems to be case-sensitive.
+       * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
+       Do not try to get the 0th notebook page if there are 0 pages, to 
+       avoid a g_warning().
+
+2007-06-11  Murray Cumming  <murrayc@murrayc.com>
+
+       * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
+       Prevent use of the new notification feature for now, because it currently 
+       shows one dialog for each new email, which is annoying.
+
+2007-06-11  Murray Cumming  <murrayc@murrayc.com>
+
+       * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
+       (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0 
+       when no country was selected, so that we show the global ones.
+       * src/maemo/easysetup/modest-presets.c:
+       (modest_presets_get_providers): Return only the global providers, not 
+       all providers when mmc=0 was requested.
+
+2007-06-11  Murray Cumming  <murrayc@murrayc.com>
+
+       * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
+       (easysetup_provider_combo_box_fill): Remove debug code that showed the 
+       provider ID in the combo.
+       
+       * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
+       Do not show the page numbers, because it would be confusing when we add 
+       the 2 extra pages for the custom setup, when the user chooses the "Other"
+       provider. This fixes projects.maemo.org bug NB#59028
+       
+       * src/modest-init.c: (modest_init_init_core),
+       (modest_init_local_folders):
+       * src/modest-init.h:
+       * src/modest-tny-account.c:
+       (modest_tny_account_new_for_local_folders): Do not create default folders 
+       for the memory card. This should fix projects.maemo.org bug NB#59328.
+
+2007-06-11  Murray Cumming  <murrayc@murrayc.com>
+
+       * src/modest-account-mgr.c: (modest_account_mgr_finalize):
+       Free the changed_conf_keys string items. They are already freed in the 
+       idle handler if that runs first.
+
+2007-06-11  Murray Cumming  <murrayc@murrayc.com>
+
+       * src/modest-ui-actions.c:
+       (modest_ui_actions_on_password_requested): Check that the server name 
+       is not NULL, because I just saw a password dialog with (null) as the 
+       server name.
+
+       * src/modest-tny-folder.[h|c]: Added 
+       modest_tny_folder_is_memory_card_folder().
+       * src/modest-ui-dimming-rules.c:
+       (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context 
+       menu item for memory cards, as per the UI spec (section 7.4). This should 
+       fix projects.maemo.org bug NB#59297.
+
+2007-06-10  Johannes Schmid <johannes.schmid@openismus.com>
+
+       * src/maemo/modest-main-window.c: (sync_accounts_cb):
+       Fixed projects.maemo.org bug NB#58576 (not yet activated as there
+       is another problem with the code, see Murray's comment at line 772)
+
 2007-06-08  Murray Cumming  <murrayc@murrayc.com>
 
        * src/maemo/easysetup/modest-easysetup-country-combo-box.h: