2007-06-20 Murray Cumming <murrayc@murrayc-desktop>
[modest] / ChangeLog2
index c31fa8f..bcb7a8f 100644 (file)
@@ -1,3 +1,237 @@
+2007-06-20  Murray Cumming  <murrayc@murrayc-desktop>
+
+       * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
+       (load_from_file): Sort the list. The unsorted list would be more noticeable 
+       in non-English locales.
+       
+       * src/maemo/modest-msg-edit-window.c:
+       (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
+       warning and fix the build.
+       
+       * src/maemo/modest-progress-bar-widget.c:
+       (modest_progress_bar_widget_set_progress): Avoid a division by zero, to 
+       avoid a g_warning, and probably to avoid a crash.
+
+2007-06-20  Murray Cumming  <murrayc@murrayc-desktop>
+
+       * src/modest-search.c: (modest_search_folder): Check for a GError 
+       when calling tny_folder_get_headers(), to show that this is not the cause 
+       of later failure.
+
+2007-06-20  Murray Cumming  <murrayc@murrayc.com>
+
+       * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
+       Actually set the body query instead of the subject query.
+       
+       * src/modest-search.c: (search_mime_part_ogs),
+       (search_mime_part_strcmp): Remove extra space from the text/* regex,
+       which would probably cause it to fail if we got this far.
+               
+       (modest_search_folder): Use simple #ifdefs instead of the function pointer, 
+       to simplify the code.
+       Warn when tny_mime_part_get_parts() returns an empty list, which seems to 
+       be causing search-in-body to fail.
+
+2007-06-20  Murray Cumming  <murrayc@murrayc.com>
+
+       * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder 
+       struct item.
+       * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
+       Better debug message when the folder cannot be found.
+       This should help with fixing projects.maemo.org bug #61287.
+       * src/modest-search.c: (add_hit): Do not leak the furl string.
+
+2007-06-20  Murray Cumming  <murrayc@murrayc.com>
+
+       * src/modest-ui-actions.c:
+       (modest_ui_actions_on_folder_selection_changed): 
+       Do not special-case TNY_MERGE_FOLDER here, because 
+       modest_tny_folder_get_account() already does that. This fixes 
+       projects.maemo.org bug NB#60955 (The smtp connections dialog was not 
+       shown when the Outbox was selected).
+
+2007-06-19  Murray Cumming,,,  <murrayc@murrayc.com>
+
+       * libmodest-dbus-client/libmodest-dbus-client.c:
+       (_dbus_iter_get_string_or_null): Initialize the string variable in 
+       case this helps with Dirk's crash.
+
+2007-06-19  Murray Cumming  <murrayc@murrayc.com>
+
+       * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail, 
+       though it is not implemented yet (this function is maybe not even used),
+       to avoid breaking ABI in future.
+       * libmodest-dbus-client/libmodest-dbus-client.c:
+       (get_attachments_string): Moved some code into this generic function.
+       (libmodest_dbus_client_send_mail): Corrected the documentation. This really 
+       sends email. It is maybe not used.
+       * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
+       (on_send_mail): Use attachments.
+       
+       * src/widgets/modest-msg-edit-window.h: Improve the documentation.
+       * src/maemo/modest-msg-edit-window.c:
+       (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to 
+       a filename before using it, to fix projects.maemo.org bug NB#58233.
+
+2007-06-19  Murray Cumming  <murrayc@murrayc.com>
+
+       * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
+       Initialize the continue_download variable to fix the build, and probably
+       to fix randome behaviour.
+
+2007-06-18  Armin Burgmeier  <armin@openismus.com>
+
+       * src/modest-tny-send-queue.h:
+       * src/modest-tny-send-queue.c: Keep track of the status of messages in
+       the queue so we can later show it in the UI. Replaced
+       modest_tny_send_queue_msg_is_being_sent() by
+       modest_tny_send_queue_get_msg_status().
+
+       * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
+
+       * src/modest-tny-account.c: Changed a cast to gpointer* to one to
+       gpointer. This probably was not harmful, but just to be sure.
+
+2007-06-18  Murray Cumming  <murrayc@murrayc.com>
+
+       * src/maemo/modest-platform.c: (modest_platform_activate_uri):
+       Fix the build, but leave the function broken on Bora, because
+       hildon_uri_action_get_service() does not exist. 
+       osso_uri_action_get_service() does not exist either, it seems.
+
+2007-06-18  Murray Cumming  <murrayc@murrayc.com>
+
+       * src/modest-tny-account.c:
+       (modest_tny_account_new_from_server_account):
+       Uncommented the url debug output again, because it is useful for 
+       debugging, as I said in the comment.
+
+2007-06-18  Murray Cumming  <murrayc@murrayc.com>
+
+       * configure.ac: Do not require hildon-notify for Maemo Bora. It is not 
+       available.
+       * src/modest-init.c: (modest_init_init_ui): Do not call notify_init() 
+       for Mameo Bora, to fix the build.
+       
+2007-06-17  Johannes Schmid <johannes.schmid@openismus.com>
+
+       * configure.ac:
+       Fixed build with hildon < 0.99
+       
+       * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
+       Check if the selected account is busy instead of checking all accounts
+       
+       * src/modest-account-mgr-priv.h:
+       * src/modest-account-mgr.c: (modest_account_mgr_class_init),
+       (modest_account_mgr_init), (compare_account_name),
+       (modest_account_mgr_set_account_busy),
+       (modest_account_mgr_account_is_busy):
+       * src/modest-account-mgr.h:
+       Added busy information to the account manager. It possible to
+       set an account to busy or not busy now.
+       
+       * src/modest-mail-operation.c: (modest_mail_operation_finalize),
+       (modest_mail_operation_update_account),
+       (modest_mail_operation_notify_end):
+               Set the account to busy/not busy depending on the operation state.
+
+       * src/widgets/modest-account-view.c:
+       (modest_account_view_finalize), (get_last_updated_string),
+       (update_account_view), (on_account_busy_changed), (init_view):
+       Show string "Refreshing..." if the account is currently busy.
+
+       All this fixes projects.maemo.org bug NB#59711
+
+2007-06-14  Armin Burgmeier  <armin@openismus.com>
+
+       * src/widgets/modest-attachments-view.h:
+       * src/widgets/modest-attachments-view.c: Added
+       modest_attachments_view_has_attachments() and fixed coordinate
+       transformation in get_att_view_at_coords(). This fixes attachment
+       selection.
+
+       * src/widgets/modest-msg-view.c: Make use of
+       modest_attachments_view_has_attachments() to decide whether to show
+       attachments in the header.
+
+2007-06-14  Johannes Schmid <johannes.schmid@openismus.com>
+
+       * src/maemo/modest-connection-specific-smtp-edit-window.c:
+       (on_change), (on_combo_security_changed),
+       (modest_connection_specific_smtp_edit_window_init),
+       (modest_connection_specific_smtp_edit_window_set_connection),
+       (modest_connection_specific_smtp_edit_window_is_dirty):
+       * src/maemo/modest-connection-specific-smtp-edit-window.h:
+       * src/maemo/modest-connection-specific-smtp-window.c:
+       (on_button_edit):
+       
+       Show an comfirmation dialog for the smpt-edit-window if there are
+       unsaved changes and the user hits cancel.
+       (projects.maemo.org bug NB#60479)
+
+2007-06-14  Armin Burgmeier  <armin@openismus.com>
+
+       * src/maemo/easysetup/modest-easysetup-wizard.c:
+       * src/maemo/modest-account-settings-dialog.c: Show "invalid email
+       address" info in banner instead of node, and select all the text as
+       per UI spec. This fixes projects.maemo.org bug NB#60550.
+
+2007-06-14  set REAL_NAME environment variable  <set EMAIL_ADDRESS environment variable>
+
+       reviewed by: <delete if not using a buddy>
+
+       * src/maemo/modest-main-window.c: (_on_msg_count_changed):
+       * src/modest-ui-actions.c: (folder_refreshed_cb):
+
+2007-06-14  Murray Cumming  <murrayc@murrayc.com>
+
+       * src/widgets/modest-folder-view.c: (filter_row):
+       Explictly filter out the per-account outbox accounts. I don't know why 
+       these only sometimes show up, but now they should never show up in the UI.
+       This should fix projects.maemo.org bug NB#60160.
+
+2007-06-14  Murray Cumming  <murrayc@murrayc.com>
+
+       * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
+       when the toolbar does not exist yet.
+       * src/modest-widget-memory.c: (save_settings_header_view):
+       Added g_warnings() to help us to discover when we are trying to set 
+       an empty columns list in gconf.
+
+2007-06-14  Murray Cumming  <murrayc@murrayc.com>
+
+       * src/modest-init.h:
+       * src/modest-init.c: 
+       Added modest_init_get_default_header_view_column_ids().
+
+       * src/modest-widget-memory.c: (restore_settings_header_view):
+       Use the new function to get defaults, if the gconf key is empty, 
+       instead of not creating any columns. This seems to fix the 
+       empty right-hand pane problems.
+       
+       * src/widgets/modest-header-view.h: Improved documentation.
+
+2007-06-13  Murray Cumming  <murrayc@murrayc.com>
+
+       * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
+       Revert the use of the display name as the account name, because this
+       is generally wrong and would break the code that follows.
+
+2007-06-13  Johannes Schmid <johannes.schmid@openismus.com>
+
+       * src/maemo/easysetup/modest-easysetup-wizard.c:
+       (check_for_supported_auth_methods), (on_before_next),
+       (create_account):
+       
+       More correct fix for projects.maemo.org bug NB# 58991
+       Do not longer accept AUTH_PASSWORD as secure method and choose
+       correct method when creating the account.
+
+2007-06-13  Johannes Schmid <johannes.schmid@openismus.com>
+
+       * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
+       Fixed projects.maemo.org bug NB# 58991
+
 2007-06-13  Murray Cumming  <murrayc@murrayc.com>
 
        * src/modest-init.c: (modest_init_init_core),