* Added global settings dialog specific implementations
[modest] / ChangeLog2
index 24d8ad9..d55c885 100644 (file)
@@ -1,3 +1,111 @@
+2007-05-09  Murray Cumming  <murrayc@murrayc.com>
+
+       * src/modest-tny-account-store.c: (on_account_changed): 
+       Correct the signature of this signal handler.
+
+2007-05-09  Murray Cumming  <murrayc@murrayc.com>
+
+       * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
+       Show a HildonNote instead of a GtkDialog for Maemo.
+
+2007-05-09  Murray Cumming  <murrayc@murrayc.com>
+
+       * src/widgets/modest-account-view.h:
+       * src/widgets/modest-account-view.c: (on_account_changed),
+       (on_account_removed). Added a boolean flag, set/unset by 
+       modest_account_view_block_conf_updates(), 
+       modest_account_view_unblock_conf_updates() to prevent unnecessary 
+       updates, but this is not very useful because the gconf notifications are 
+       so delays (maybe only on Maemo Bora).
+       So auto-updating is turned off, and these functions do an explicit 
+       update when necessary.
+       However, something else is still doing too much work when adding/removing 
+       accounts, probably in another part of the application.
+       
+       * src/maemo/modest-account-view-window.c:
+       (on_delete_button_clicked), (on_edit_button_clicked),
+       (on_new_button_clicked): Use the new functions.
+
+2007-05-09  Murray Cumming  <murrayc@murrayc.com>
+
+       * src/modest-account-mgr-helpers.c:
+       (modest_account_mgr_set_first_account_as_default):
+       Sort the list of names alphabetically-by-title, so we choose the first one 
+       based on that.
+       * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel 
+       alphabetically by the title.
+       
+       This fixes projects.maemo.org bug NB#56418 .
+       
+       * src/modest-account-mgr-priv.c:
+       (_modest_account_mgr_account_from_key):
+       * src/modest-account-mgr.c: (on_key_change): Initialize variables to 
+       avoid a valgrind error, and possible random behaviour.
+
+2007-05-09  Murray Cumming  <murrayc@murrayc.com>
+
+       * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
+       Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the 
+       tinymail documentation to say that this can be expected.
+       Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not 
+       pretty, and should not happen, but I would prefer to know when it does.
+
+2007-05-09  Murray Cumming  <murrayc@murrayc.com>
+
+       * configure.ac: When using the older hildon version, probably on Bora, 
+       require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
+       to fix the build.
+       * src/widgets/modest-attachment-view.c:
+       (modest_attachment_view_set_part_default): Initialize variables, to fix the 
+       build.
+
+2007-05-09  Marcus Bauer  <marcusb@openismus.com>
+
+       * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
+       Implemented the prototype. Can be tested with
+       tests/dbus_api/test_open_message: 
+
+2007-05-08  Murray Cumming  <murrayc@murrayc.com>
+
+       * src/modest-tny-account-store.c:
+       (modest_tny_account_store_instance_init), (get_password):
+       * src/modest-ui-actions.c:
+       (modest_ui_actions_on_password_requested):
+       Do not store the password in gconf, because this function is called 
+       for non-remembered passwords. Actually use the cached (in the hash map) 
+       password instead of releasing it.
+       The password will now not be remembered if it is asked via the protected 
+       password dialog, as per the UI spec.
+
+2007-05-08  Murray Cumming  <murrayc@murrayc.com>
+
+       * src/modest-defs.h:
+       * src/modest-account-mgr-helpers.h:
+       * src/modest-account-mgr-helpers.c:
+       Added modest_server_account_get_username_has_succeeded(),
+       modest_server_account_set_username_has_succeeded().
+       (modest_server_account_set_username),
+       Reset the has-succeeded flag if the username changes.
+       
+       * src/maemo/modest-account-settings-dialog.c: (save_configuration):
+       * src/maemo/modest-connection-specific-smtp-window.c:
+       (modest_connection_specific_smtp_window_save_server_accounts):
+       Use modest_server_account_set_username() instead of using 
+       modest_conf_set_string() directly, so that the has-succeeded flag is always 
+       reset.
+       
+       * src/modest-ui-actions.c:
+       (modest_ui_actions_on_password_requested): Dim the username entry if 
+       the username has ever worked, as per the UI spec.
+
+2007-05-08  Murray Cumming  <murrayc@murrayc.com>
+
+       * src/modest-tny-account-store.c: (get_password):
+       * src/modest-ui-actions.c:
+       (modest_ui_actions_on_password_requested):
+       Allow the username to be changed too, though there is more work to 
+       be done on exactly how this behaves.
+
 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 
        * src/modest-account-mgr-helpers.h: