+2007-05-09 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account-store.c: (on_account_changed):
+ Correct the signature of this signal handler.
+
+2007-05-09 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
+ Show a HildonNote instead of a GtkDialog for Maemo.
+
+2007-05-09 Murray Cumming <murrayc@murrayc.com>
+
+ * src/widgets/modest-account-view.h:
+ * src/widgets/modest-account-view.c: (on_account_changed),
+ (on_account_removed). Added a boolean flag, set/unset by
+ modest_account_view_block_conf_updates(),
+ modest_account_view_unblock_conf_updates() to prevent unnecessary
+ updates, but this is not very useful because the gconf notifications are
+ so delays (maybe only on Maemo Bora).
+ So auto-updating is turned off, and these functions do an explicit
+ update when necessary.
+ However, something else is still doing too much work when adding/removing
+ accounts, probably in another part of the application.
+
+ * src/maemo/modest-account-view-window.c:
+ (on_delete_button_clicked), (on_edit_button_clicked),
+ (on_new_button_clicked): Use the new functions.
+
+2007-05-09 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-account-mgr-helpers.c:
+ (modest_account_mgr_set_first_account_as_default):
+ Sort the list of names alphabetically-by-title, so we choose the first one
+ based on that.
+ * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
+ alphabetically by the title.
+
+ This fixes projects.maemo.org bug NB#56418 .
+
+ * src/modest-account-mgr-priv.c:
+ (_modest_account_mgr_account_from_key):
+ * src/modest-account-mgr.c: (on_key_change): Initialize variables to
+ avoid a valgrind error, and possible random behaviour.
+
+2007-05-09 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
+ Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
+ tinymail documentation to say that this can be expected.
+ Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
+ pretty, and should not happen, but I would prefer to know when it does.
+
+2007-05-09 Murray Cumming <murrayc@murrayc.com>
+
+ * configure.ac: When using the older hildon version, probably on Bora,
+ require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
+ to fix the build.
+ * src/widgets/modest-attachment-view.c:
+ (modest_attachment_view_set_part_default): Initialize variables, to fix the
+ build.
+
+2007-05-09 Marcus Bauer <marcusb@openismus.com>
+
+ * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
+ Implemented the prototype. Can be tested with
+ tests/dbus_api/test_open_message:
+
+2007-05-08 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account-store.c:
+ (modest_tny_account_store_instance_init), (get_password):
+ * src/modest-ui-actions.c:
+ (modest_ui_actions_on_password_requested):
+ Do not store the password in gconf, because this function is called
+ for non-remembered passwords. Actually use the cached (in the hash map)
+ password instead of releasing it.
+ The password will now not be remembered if it is asked via the protected
+ password dialog, as per the UI spec.
+
+2007-05-08 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-defs.h:
+ * src/modest-account-mgr-helpers.h:
+ * src/modest-account-mgr-helpers.c:
+ Added modest_server_account_get_username_has_succeeded(),
+ modest_server_account_set_username_has_succeeded().
+ (modest_server_account_set_username),
+ Reset the has-succeeded flag if the username changes.
+
+ * src/maemo/modest-account-settings-dialog.c: (save_configuration):
+ * src/maemo/modest-connection-specific-smtp-window.c:
+ (modest_connection_specific_smtp_window_save_server_accounts):
+ Use modest_server_account_set_username() instead of using
+ modest_conf_set_string() directly, so that the has-succeeded flag is always
+ reset.
+
+ * src/modest-ui-actions.c:
+ (modest_ui_actions_on_password_requested): Dim the username entry if
+ the username has ever worked, as per the UI spec.
+
+2007-05-08 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account-store.c: (get_password):
+ * src/modest-ui-actions.c:
+ (modest_ui_actions_on_password_requested):
+ Allow the username to be changed too, though there is more work to
+ be done on exactly how this behaves.
+
+2007-05-08 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-account-mgr-helpers.h:
+ * src/modest-account-mgr-helpers.c:
+ Added modest_account_mgr_get_display_name(),
+ modest_server_account_get_username(),
+ modest_server_account_set_username(),
+ modest_server_account_set_password(),
+ modest_server_account_get_hostname() functions so we do not need to
+ use the conf API directly.
+
+ * src/maemo/modest-main-window.c: (connect_signals):
+ Actually connect ot the ModestAccountStore::request-password signal,
+ so that we show the dialog when the password is requested by Tinymail,
+ for isntance if it is empty.
+
+ * src/modest-marshal.list:
+ * src/modest-tny-account-store.c:
+ (modest_tny_account_store_class_init), (get_password),
+ (modest_tny_account_store_alert):
+ * src/modest-tny-account-store.h:
+ * src/modest-ui-actions.h:
+ * src/modest-ui-actions.c:
+ (modest_ui_actions_on_password_requested):
+ Change the signal parameters, so it is obvious that we are providing
+ the non human-readable server name, and receiving both the username
+ and password, though changing of the username is not yet implemented.
+ Change the dialog UI to match the Maemo UI specifications, with #idfefing
+ for the GNOME version.
+
+ This should fix the projects.maemo.org bug NB#56209, though it does not
+ work on Bora, because the gconf_client_get() for the password fails
+ immediately after we save it with gconf_client_set().
+
+2007-05-08 Murray Cumming <murrayc@murrayc.com>
+
+ * configure.ac:
+ * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
+ caused an undefined symbol error:
+ modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
+
+2007-05-08 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account-store.c:
+ (modest_tny_account_store_alert): Adapt to the changed tinymail API,
+ using a GError instead of a string message, so we can translate it in
+ Modest.
+
+2007-05-08 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-address-book.c:
+ (modest_address_book_check_names):
+ * src/maemo/modest-msg-view-window.c:
+ (modest_msg_view_window_clipboard_owner_change):
+ * src/modest-init.c: (modest_init_init_ui):
+ * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
+ (update_folders_cb), (modest_mail_operation_update_account):
+ * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
+ (modest_ui_actions_on_msg_attachment_clicked),
+ (modest_ui_actions_on_msg_recpt_activated):
+ * src/widgets/modest-header-view.c: (drag_data_get_cb):
+ * src/widgets/modest-msg-view.c: (modest_msg_view_search),
+ (modest_msg_view_search_next):
+ * src/widgets/modest-recpt-editor.c:
+ (modest_recpt_editor_on_button_release_event),
+ (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
+ g_message(). At this point we should only be seeing interesting errors on
+ stdout. Debugging messages could be #ifdefed-out if they are still useful.
+
+2007-05-07 Murray Cumming <murrayc@murrayc.com>
+
+ (modest_wizard_dialog_force_title_update):
+ * src/maemo/easysetup/modest-wizard-dialog.h:
+ * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
+ For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
+ can update the title when appropriate. Otherwise the title is wrong if the
+ pages are added after adding the notebook to the dialog.
+ This must be a problem in HildonWizardDialog too.
+ Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
+
+ * src/maemo/easysetup/modest-easysetup-wizard.c:
+ (create_subsequent_customsetup_pages),
+ (create_subsequent_easysetup_pages):
+ Call modest_wizard_dialog_force_title_update() so that the title is
+ correct even with GTK+ < 2.10.
+ This fixes projects.maemo.org bug NB#56145 .
+
+2007-05-07 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-platform.c:
+ (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
+ flag (awful lack of namespacing in this API) to prevent a useless %s dialog
+ from being shown.
+
+2007-05-07 Murray Cumming <murrayc@murrayc.com>
+
+ * src/widgets/modest-window.h:
+ * src/widgets/modest-window.c: Added a save_state_func vfunc,
+ and modest_window_save_state(), which invokes it.
+
+ * src/widgets/modest-window-mgr.h:
+ * src/widgets/modest-window-mgr.c:
+ Added modest_window_mgr_save_state_for_all_windows(), which calls
+ the save_state vfunc on all registered windows, if implemented.
+
+ * src/gnome/modest-msg-edit-window.c:
+ * src/gnome/modest-msg-view-window.c:
+ * src/maemo/modest-msg-edit-window.c:
+ * src/maemo/modest-msg-view-window.c:
+ * src/maemo/modest-main-window.c:
+ Specify the existing save_settings functions as implementations of
+ ModestWindow::save_state_func().
+
+ * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
+ Call modest_window_mgr_save_state_for_all_windows(). This happens before
+ enabling hibernation, for instance.
+
+ We may need to do the same thing for restoring settings.
+
+
+2007-05-07 Murray Cumming <murrayc@murrayc.com>
+
+ * src/widgets/modest-window-mgr.c:
+ * src/widgets/modest-window-mgr.h:
+ Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
+ modest_window_mgr_get_hibernation_is_prevented().
+
+ * src/maemo/modest-main-window.c:
+ (on_hildon_program_is_topmost_notify): Prevent hibernation
+ (possible when the application goes to the background in the WM),
+ if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
+
+ * src/maemo/easysetup/modest-easysetup-wizard.c:
+ (modest_easysetup_wizard_dialog_init):
+ * src/maemo/modest-account-settings-dialog.c:
+ (modest_account_settings_dialog_init):
+ * src/maemo/modest-connection-specific-smtp-edit-window.c:
+ (modest_connection_specific_smtp_edit_window_init):
+ * src/maemo/modest-connection-specific-smtp-window.c:
+ (modest_connection_specific_smtp_window_init):
+ * src/maemo/modest-signature-editor-dialog.c:
+ (modest_signature_editor_dialog_init):
+ Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
+ prevent hibernation while any of these account settings dialogs are open.
+
+2007-05-04 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/Makefile.am:
+ * src/maemo/modest-osso-state-saving.c:
+ * src/maemo/modest-osso-state-saving.h: Added
+ modest_osso_load_state() and modest_osso_save_state() though they do
+ nothing now. They should iterate through all the open windows and load/save
+ their state.
+ * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
+ save state when closing.
+
+ * src/maemo/modest-main-window.c:
+ (on_hildon_program_is_topmost_notify), (modest_main_window_new):
+ Add a notification handler for the HildonProgram::is-topmost property,
+ so we can allow hibernation when the application goes into the background.
+ But we still need to detect when the accounts setup windows are open so
+ we can stop hibernation when they are open.
+ To do this, I also added the main window the HildonProgram. This might have
+ other side-effects/benefits, and should maybe be done for other windows.
+
+ * src/maemo/modest-osso-autosave-callbacks.h:
+ * src/maemo/modest-osso-autosave-callbacks.c:
+ (modest_on_osso_application_autosave): Add a libosso auto-save callback,
+ though it does not do anything yet, and we might never need this to do
+ anything. For instance, we already save drafts.
+
+ * src/maemo/modest-platform.c: (modest_platform_init):
+ Specify the libosso auto-save callback.
+
+2007-05-03 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-platform.c:
+ (modest_platform_set_update_interval):
+ * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
+ aparently stays valid between application instances, so we can use this
+ to remove and reset it later. According to a maemo-developers email from
+ David Weinehall.
+
+2007-05-03 Murray Cumming <murrayc@murrayc.com>
+
+ * configure.ac: Depend on libalarm for Maemo.
+
+ * src/dbus_api/modest-dbus-api.h:
+ * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
+ (on_send_receive), (modest_dbus_req_handler):
+ Handle a SEND_RECEIVE D-Bus method.
+
+ * libmodest-dbus-client/libmodest-dbus-client.c:
+ (libmodest_dbus_client_send_and_receive):
+ * libmodest-dbus-client/libmodest-dbus-client.h:
+ Add C convenience functions for calling the new D-Bus method.
+
+ * src/modest-platform.h:
+ * src/gnome/modest-platform.c:
+ * src/maemo/modest-platform.c:
+ Added modest_platform_set_update_interval(), which uses the
+ alarmd API on Maemo.
+ (modest_platform_init),
+ Call modest_platform_set_update_interval(), using a hard-coded
+ interval for now (until the global settings dialog is implemented),
+ though I am not sure that this makes sense yet.
+
2007-05-02 Murray Cumming <murrayc@murrayc.com>
* src/dbus_api/modest-dbus-callbacks.c:
projects / modest / blobdiff