+2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
+
+ * src/maemo/modest-connection-specific-smtp-edit-window.c:
+ (on_value_changed),
+ (modest_connection_specific_smtp_edit_window_init):
+
+ Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
+ of "changed" for now
+
+2007-06-29 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account.c:
+ (modest_tny_account_new_from_server_account):
+ Handle the TnyAccount::"connection-status-changed" signal, which tinymail
+ now uses to request a connection when it needs one, and which it uses
+ to tell us that something is wrong with the connection, so we can force
+ the accounts offline to prevent further problems.
+
+ * src/modest-defs.h:
+ * src/modest-init.c: (init_default_settings):
+ * src/modest-mail-operation.c:
+ (modest_mail_operation_update_account):
+ * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
+ This should not be necessary anymore. Do not set the conf key that
+ determined this (it was always TRUE and not set anywhere else).
+
+ * src/modest-ui-actions.h: Remove unused and unimplemented
+ modest_ui_actions_on_online_toggle_toggled().
+
+2007-06-29 Murray Cumming <murrayc@murrayc.com
+
+ * src/maemo/modest-main-window.c: (connect_signals):
+ Don't connect to delete_event twice. Maybe this was harmless.
+
+2007-06-29 Murray Cumming <murrayc@murrayc.com
+
+ * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
+ * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
+ Debug output to give some more clue when a folder move is not allowed.
+
+2007-06-28 Murray Cumming <murrayc@murrayc.com
+
+ * src/modest-tny-account.c: (on_modest_file_system_info),
+ (modest_tny_account_get_mmc_account_name):
+ Always call the callback, without checking whether the name has changed.
+ * src/widgets/modest-folder-view.c: (strings_are_equal),
+ (on_model_foreach_set_name), (on_get_mmc_account_name),
+ (text_cell_data): Compare the name here, and use the name from
+ the account rather than from the
+ TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
+ if the name was changed after the account was added to the model.
+ That's a tinymail bug but not one that I want to fix now.
+
+ This finally fixes projects.maemo.org bug NB#59301.
+
+2007-06-27 Armin Burgmeier <armin@openismus.com>
+
+ * src/modest-mail-operation.c: Fixed a crash when canceling a mail
+ receive operation.
+
+2007-06-27 Murray Cumming <murrayc@murrayc.com
+
+ * src/modest-tny-account.h:
+ * src/modest-tny-account.c:
+ Added modest_tny_account_get_mmc_account_name(), to set the memory
+ card name asynchronously for the given account and then notify.
+ (modest_tny_account_new_for_local_folders): Use this new function instead
+ of using hildon_file_system_info_async_new() directly.
+
+ * src/widgets/modest-folder-view.c: (text_cell_data):
+ Use modest_tny_account_get_mmc_account_name() to get the real name, calling
+ gtk_tree_model_row_changed() when it is available.
+
+ This should fix projects.maemo.org bug NB#59301.
+
+2007-06-27 Murray Cumming <murrayc@murrayc.com
+
+ * src/modest-mail-operation.c: (update_account_thread),
+ (get_msgs_full_thread): Fix typo failures in the revert
+ to fix the build.
+
+2007-06-27 Murray Cumming <murrayc@murrayc.com
+
+ * src/maemo/modest-maemo-global-settings-dialog.c:
+ (idle_select_default_focus):
+ * src/modest-mail-operation.c: (idle_notify_progress),
+ (idle_notify_progress_once), (set_last_updated_idle),
+ (update_account_thread), (get_msgs_full_thread):
+ * src/widgets/modest-attachment-view.c: (get_size_idle_func):
+ * src/widgets/modest-header-view.c:
+ (idle_notify_headers_count_changed_destroy),
+ (idle_notify_headers_count_changed):
+ Reverted the additions of gdk_threads_enter/leave(), in case this
+ helps with a startup hang on the device.
+
+2007-06-26 Armin Burgmeier <armin@openismus.com>
+
+ * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
+ for supported secure authentication methods from server by
+ gtk_dialog_run(), saving CPU time and a potential race condition.
+
+2007-06-26 Armin Burgmeier <armin@openismus.com>
+
+ * src/maemo/modest-maemo-utils.h:
+ * src/maemo/modest-maemo-utils.c: Added a
+ ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
+ only error code to tell the calling code when the user canceled the
+ operation.
+
+ * src/maemo/modest-account-settings-dialog.h:
+ * src/maemo/modest-account-settings-dialog.c:
+ * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
+ message if the retrieval of secure authentication methods was canceled
+ by the user. Perform the check before saving anything to configuration
+ to not end up with half-committed configuration changes, do not show
+ a "Saving to configuration failed" note when authentication methods
+ could not be retrieved.
+
+ * src/maemo/modest-main-window.c: Fixed a crash on startup when built
+ with old hildon.
+
+2007-06-26 Murray Cumming <murrayc@murrayc.com>
+
+ * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
+ Only return the first level of folders under accounts, because the
+ osso-global-search UI spec doesn't want the rest.
+ This fixed projects.maemo.org bug NB#61811.
+
+2007-06-26 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account-store.c:
+ * src/modest-tny-account-store.h:
+ Added modest_tny_account_is_memory_card_account().
+ * src/maemo/modest-main-window.c: (create_details_widget):
+ Show the same information items for the memory card as we show for the
+ local-folders, to fix projects.maemo.org bug NB#59307.
+
+2007-06-26 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account-store.c: (get_password):
+ Added some checks for NULL to maybe prevent crashes, though I think
+ it was Philip's last commit that actually prevented the crash here
+ when creating a first new account.
+ But the new account is still not usable (no messages are shown)
+ until a restart of the application.
+
+2007-06-26 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-maemo-global-settings-dialog.c:
+ (idle_select_default_focus):
+ * src/modest-mail-operation.c: (idle_notify_progress),
+ (idle_notify_progress_once), (idle_notify_update_account_queue),
+ (set_last_updated_idle), (update_account_thread),
+ (notify_get_msgs_full), (get_msgs_full_destroyer),
+ (get_msgs_full_thread):
+ * src/widgets/modest-attachment-view.c: (get_size_idle_func):
+ * src/widgets/modest-header-view.c:
+ (idle_notify_headers_count_changed_destroy),
+ (idle_notify_headers_count_changed):
+ Use gdk_threads_enter() and gdk_threads_enter_leave() in
+ all idle handlers, because some other thread could be blocking
+ the GDK lock, so that it can do GUI stuff.
+
+2007-06-26 Murray Cumming <murrayc@murrayc.com>
+
+ * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
+ (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
+ (on_idle_send_receive), (on_idle_open_default_inbox):
+ * src/maemo/modest-msg-edit-window.c:
+ (modest_msg_edit_window_attach_file_noninteractive):
+ Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
+ to prevent a hang. I don't quite understand why these are necessary,
+ beause we should already be in the main loop. I guess something outside
+ of the main loop is taking the lock.
+
+ * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
+ we are really using URIs, and use files that are more likely to exist.
+
+2007-06-26 Murray Cumming <murrayc@murrayc.com>
+
+ * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
+ necessary because configure.ac now defines different variables.
+
+2007-06-26 Murray Cumming <murrayc@murrayc.com>
+
+ * libmodest-dbus-client/libmodest-dbus-client.c:
+ * libmodest-dbus-client/libmodest-dbus-client.h:
+ Removed libmodest_dbus_client_send_mail() because it is not used by anything.
+ libmodest_dbus_client_compose_mail() is what things actually use.
+
+ * src/dbus_api/modest-dbus-api.h:
+ * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
+ * tests/dbus_api/Makefile.am:
+ * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
+ D-Bus method.
+
+2007-06-26 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-init.c: (modest_init_local_folders):
+ For memory-card (or other non local-folders) maildir accounts,
+ always create an Archive folder, so that there is somewhere to put
+ messages. This should be less confusing, because the user does not need
+ to guess that the need to create a folder.
+
+2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
+
+ * src/maemo/easysetup/modest-wizard-dialog.c: (init):
+ Fixed icon size by using (50, 50) which is the same as defined by
+ newer hildon-libs
+
+2007-06-25 Armin Burgmeier <armin@openismus.com>
+
+ * src/widgets/modest-window-mgr.c:
+ * src/modest-init.c:
+ * configure.ac: Correctly recognize hildon-notify presence and fixed
+ the build without it being installed.
+
+2007-06-25 Murray Cumming <murrayc@murrayc.com>
+
+ * libmodest-dbus-client/libmodest-dbus-client.c:
+ (libmodest_dbus_client_search): Fix the build. Sorry.
+ * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
+ (reply_forward_cb): Initialize variables to fix the build.
+
+ * src/modest-tny-account-store.c:
+ (modest_tny_account_store_get_tny_account_by): Fix the account URI
+ comparison (a silly typo) so that email search results can be opened
+ when there are more than one account.
+
+2007-06-25 Murray Cumming <murrayc@murrayc.com>
+
+ * libmodest-dbus-client/libmodest-dbus-client.c:
+ (libmodest_dbus_client_search),
+ (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
+ instead of 1 second, because the search gets folders and messages from
+ the server, which can take a long time. When it times out,
+ osso-global-search will report no results.
+
+ We need to specify whether we should search only cached information
+ (maybe with a user preference), and the osso-email-search-plugin
+ API should really be improved to allow that option, and to allow results
+ to be delivered asynchronously in batches.
+
+2007-06-25 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/easysetup/modest-wizard-dialog.c: (init):
+ Fix a typo to fix the osso 1.1. build. See the TODO comment though -
+ GTK_ICON_SIZE_DIALOG is probably the wrong size.
+
+2007-06-25 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-search.c: (modest_search_folder): Ignore a seach folder
+ that is an empty string. D-Bus seems to give us these instead of NULL.
+
+2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
+
+ * src/dbus_api/modest-dbus-callbacks.c:
+ * src/maemo/easysetup/modest-easysetup-wizard.h:
+ * src/maemo/easysetup/modest-wizard-dialog.c: (init):
+ * src/maemo/modest-connection-specific-smtp-edit-window.c:
+ (modest_connection_specific_smtp_edit_window_init):
+ * src/maemo/modest-maemo-global-settings-dialog.c:
+ (on_range_error):
+ * src/maemo/modest-maemo-utils.c:
+ (modest_maemo_utils_setup_images_filechooser):
+ * src/maemo/modest-main-window.c: (create_details_widget):
+ * src/maemo/modest-msg-edit-window.c:
+ (modest_msg_edit_window_attach_file_noninteractive),
+ (modest_msg_edit_window_color_button_change),
+ (modest_msg_edit_window_set_zoom):
+ * src/modest-mail-operation.c: (update_account_thread):
+ * src/modest-tny-account-store.c:
+ * src/modest-tny-account.c:
+ * src/widgets/modest-global-settings-dialog.c:
+ * src/widgets/modest-window.h:
+
+ Fixed build on bora!
+
+2007-06-25 Murray Cumming <murrayc@murrayc.com>
+
+ * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
+ * src/modest-search.c: (modest_search_folder),
+ (modest_search_all_accounts): Actually search only in the specified folder,
+ doing a simple match on the folder ID.
+ * src/modest-search.h: Added a folder field to the ModestSearch struct,
+ and added some documentation.
+
+2007-06-22 Armin Burgmeier <armin@openismus.com>
+
+ * src/maemo/modest-maemo-utils.h:
+ * src/maemo/modest-maemo-utils.c: Added a GError parameter to
+ modest_maemo_utils_get_supported_secure_authentication_methods.
+
+ * src/maemo/easysetup/modest-easysetup-wizard.c:
+ * src/maemo/modest-account-settings-dialog.c: Show correct error if
+ one occured, not just "Server does not support secure authentication".
+
+2007-06-22 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account-store.c: (get_password):
+ Restored the call to tny_account_set_user() because Philip seems to have
+ stopped this from crashing (by not using the freed string). It still does
+ not work, but now we can test it.
+
+2007-06-22 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-msg-edit-window.c: (init_window):
+ Comment out use of an uninitialzed GtkScrolledWindow variable,
+ to fix the build and stop a crash. Yet again.
+
+2007-06-22 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account-store.c: (get_password):
+ Remove the call to tny_account_set_user() because this actually crashes.
+ As mentioned in the last commit, it is known to not work anyway.
+
+2007-06-22 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account-store.c: (get_password):
+ Use tny_account_set_username() to tell tinymail that the username might
+ have changed too. But tinymail ignores this: see projects.maemo.org
+ bug #61463.
+ * src/modest-ui-actions.c:
+ (modest_ui_actions_on_password_requested): Remove the useless attempt to
+ reset the connection when changing the username, and improve the comments.
+ Save the changed username to gconf at least, so it is used when Modest is
+ restarted.
+
+2007-06-21 Murray Cumming <murrayc@murrayc.com>
+
+ * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
+ Do not use a query, so that we get all folders, including for POP and
+ local-folders. They work as search criteria too.
+ This fixes projects.maemo.org bug NB#57740.
+
+2007-06-21 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
+ Comment out the use of hildon_notification_set_sound() because it is
+ not declared, to fix the build. Warnings are serious, people.
+
+2007-06-21 Armin Burgmeier <armin@openismus.com>
+
+ * src/maemo/modest-maemo-utils.h:
+ * src/maemo/modest-maemo-utils.c: Added a username parameter to the
+ modest_maemo_utils_get_supported_secure_authentication_methods()
+ to query authentication methods for a specific user. This should fix
+ projects.maemo.org bug NB#61369.
+
+ * src/maemo/easysetup/modest-easysetup-wizard.c:
+ * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
+ function.
+
+2007-06-21 Murray Cumming <murrayc@murrayc.com>
+
+ * libmodest-dbus-client/libmodest-dbus-client.h:
+ * libmodest-dbus-client/libmodest-dbus-client.c:
+ (modest_dbus_message_iter_get_search_hit),
+ (libmodest_dbus_client_search):
+ Reorganised and commented this.
+ Removed modest_search_hit_free() from the public API because it
+ is not needed.
+
+ Added libmodest_dbus_client_get_folders() and
+ modest_folder_result_list_free().
+
+ * src/dbus_api/modest-dbus-api.h:
+ * src/dbus_api/modest-dbus-callbacks.c:
+ (modest_dbus_req_filter): Commented. Moved most code to
+ on_dbus_method_search() and added on_dbus_method_get_folders().
+
+ * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
+ of the extra D-Bus handler.
+
+ * tests/dbus_api/Makefile.am:
+ * tests/dbus_api/test_get_folders.c: New test for
+ libmodest_dbus_client_get_folders(). This seems to return an empty list
+ at the moment. That could be the same error that causes the message list
+ to be empty sometimes.
+ This should help with projects.maemo.org bug NB#57740.
+
+2007-06-21 Armin Burgmeier <armin@openismus.com>
+
+ * src/modest-mail-operation.c: Do not call
+ modest_mail_operation_queue_cancel_all() in _cancel() but do instead
+ notify the operation's end after having set the status to CANCELED for
+ the operation queue to listen on. This fixes a deadlock when there
+ were mail operations in the queue during its finalization.
+
+ * src/modest-singletons.c: Reordered uninitialization of the account
+ manager to happen after the mail operation queue was uninitialized
+ because the mail operation's in the queue might still try to access
+ the account manager (see modest_mail_operation_notify_end()). This
+ fixes a potential crash when terminating the application.
+
+2007-06-21 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-search.c:
+ (search_mime_part_and_child_parts): Moved some code here so we
+ can search recursively in child folders.
+ (modest_search_folder): Search in the message as a mime part, instead
+ of just its child mime parts.
+ (read_chunk), (search_mime_part_ogs):
+ Check how many bytes were read, to prevent an endless loop.
+ Searching in message bodies now works. This finishes the fix for
+ projects.maemo.org bug NB#61007.
+
+2007-06-20 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-ui-actions.c: (modest_ui_actions_on_details):
+ Add a g_warning when the item is not a folder.
+
+ * src/modest-ui-dimming-rules.c:
+ (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
+ when selected item is not a folder (for instance, an account), because
+ the UI spec only talks about folders.
+ I am not sure what the UI spec wants, so this might not totally fix
+ projects.maemo.org bug NB#60794.
+
+2007-06-20 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
+ (load_from_file): Sort the list. The unsorted list would be more noticeable
+ in non-English locales.
+
+ * src/maemo/modest-msg-edit-window.c:
+ (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
+ warning and fix the build.
+
+ * src/maemo/modest-progress-bar-widget.c:
+ (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
+ avoid a g_warning, and probably to avoid a crash.
+
+2007-06-20 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-search.c: (modest_search_folder): Check for a GError
+ when calling tny_folder_get_headers(), to show that this is not the cause
+ of later failure.
+
+2007-06-20 Murray Cumming <murrayc@murrayc.com>
+
+ * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
+ Actually set the body query instead of the subject query.
+
+ * src/modest-search.c: (search_mime_part_ogs),
+ (search_mime_part_strcmp): Remove extra space from the text/* regex,
+ which would probably cause it to fail if we got this far.
+
+ (modest_search_folder): Use simple #ifdefs instead of the function pointer,
+ to simplify the code.
+ Warn when tny_mime_part_get_parts() returns an empty list, which seems to
+ be causing search-in-body to fail.
+
+2007-06-20 Murray Cumming <murrayc@murrayc.com>
+
+ * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
+ struct item.
+ * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
+ Better debug message when the folder cannot be found.
+ This should help with fixing projects.maemo.org bug #61287.
+ * src/modest-search.c: (add_hit): Do not leak the furl string.
+
+2007-06-20 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-ui-actions.c:
+ (modest_ui_actions_on_folder_selection_changed):
+ Do not special-case TNY_MERGE_FOLDER here, because
+ modest_tny_folder_get_account() already does that. This fixes
+ projects.maemo.org bug NB#60955 (The smtp connections dialog was not
+ shown when the Outbox was selected).
+
+2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
+
+ * libmodest-dbus-client/libmodest-dbus-client.c:
+ (_dbus_iter_get_string_or_null): Initialize the string variable in
+ case this helps with Dirk's crash.
+
+2007-06-19 Murray Cumming <murrayc@murrayc.com>
+
+ * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
+ though it is not implemented yet (this function is maybe not even used),
+ to avoid breaking ABI in future.
+ * libmodest-dbus-client/libmodest-dbus-client.c:
+ (get_attachments_string): Moved some code into this generic function.
+ (libmodest_dbus_client_send_mail): Corrected the documentation. This really
+ sends email. It is maybe not used.
+ * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
+ (on_send_mail): Use attachments.
+
+ * src/widgets/modest-msg-edit-window.h: Improve the documentation.
+ * src/maemo/modest-msg-edit-window.c:
+ (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
+ a filename before using it, to fix projects.maemo.org bug NB#58233.
+
+2007-06-19 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
+ Initialize the continue_download variable to fix the build, and probably
+ to fix randome behaviour.
+
+2007-06-18 Armin Burgmeier <armin@openismus.com>
+
+ * src/modest-tny-send-queue.h:
+ * src/modest-tny-send-queue.c: Keep track of the status of messages in
+ the queue so we can later show it in the UI. Replaced
+ modest_tny_send_queue_msg_is_being_sent() by
+ modest_tny_send_queue_get_msg_status().
+
+ * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
+
+ * src/modest-tny-account.c: Changed a cast to gpointer* to one to
+ gpointer. This probably was not harmful, but just to be sure.
+
+2007-06-18 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-platform.c: (modest_platform_activate_uri):
+ Fix the build, but leave the function broken on Bora, because
+ hildon_uri_action_get_service() does not exist.
+ osso_uri_action_get_service() does not exist either, it seems.
+
+2007-06-18 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account.c:
+ (modest_tny_account_new_from_server_account):
+ Uncommented the url debug output again, because it is useful for
+ debugging, as I said in the comment.
+
+2007-06-18 Murray Cumming <murrayc@murrayc.com>
+
+ * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
+ available.
+ * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
+ for Mameo Bora, to fix the build.
+
+2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
+
+ * configure.ac:
+ Fixed build with hildon < 0.99
+
+ * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
+ Check if the selected account is busy instead of checking all accounts
+
+ * src/modest-account-mgr-priv.h:
+ * src/modest-account-mgr.c: (modest_account_mgr_class_init),
+ (modest_account_mgr_init), (compare_account_name),
+ (modest_account_mgr_set_account_busy),
+ (modest_account_mgr_account_is_busy):
+ * src/modest-account-mgr.h:
+ Added busy information to the account manager. It possible to
+ set an account to busy or not busy now.
+
+ * src/modest-mail-operation.c: (modest_mail_operation_finalize),
+ (modest_mail_operation_update_account),
+ (modest_mail_operation_notify_end):
+ Set the account to busy/not busy depending on the operation state.
+
+ * src/widgets/modest-account-view.c:
+ (modest_account_view_finalize), (get_last_updated_string),
+ (update_account_view), (on_account_busy_changed), (init_view):
+ Show string "Refreshing..." if the account is currently busy.
+
+ All this fixes projects.maemo.org bug NB#59711
+
+2007-06-14 Armin Burgmeier <armin@openismus.com>
+
+ * src/widgets/modest-attachments-view.h:
+ * src/widgets/modest-attachments-view.c: Added
+ modest_attachments_view_has_attachments() and fixed coordinate
+ transformation in get_att_view_at_coords(). This fixes attachment
+ selection.
+
+ * src/widgets/modest-msg-view.c: Make use of
+ modest_attachments_view_has_attachments() to decide whether to show
+ attachments in the header.
+
+2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
+
+ * src/maemo/modest-connection-specific-smtp-edit-window.c:
+ (on_change), (on_combo_security_changed),
+ (modest_connection_specific_smtp_edit_window_init),
+ (modest_connection_specific_smtp_edit_window_set_connection),
+ (modest_connection_specific_smtp_edit_window_is_dirty):
+ * src/maemo/modest-connection-specific-smtp-edit-window.h:
+ * src/maemo/modest-connection-specific-smtp-window.c:
+ (on_button_edit):
+
+ Show an comfirmation dialog for the smpt-edit-window if there are
+ unsaved changes and the user hits cancel.
+ (projects.maemo.org bug NB#60479)
+
+2007-06-14 Armin Burgmeier <armin@openismus.com>
+
+ * src/maemo/easysetup/modest-easysetup-wizard.c:
+ * src/maemo/modest-account-settings-dialog.c: Show "invalid email
+ address" info in banner instead of node, and select all the text as
+ per UI spec. This fixes projects.maemo.org bug NB#60550.
+
+2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
+
+ reviewed by: <delete if not using a buddy>
+
+ * src/maemo/modest-main-window.c: (_on_msg_count_changed):
+ * src/modest-ui-actions.c: (folder_refreshed_cb):
+
+2007-06-14 Murray Cumming <murrayc@murrayc.com>
+
+ * src/widgets/modest-folder-view.c: (filter_row):
+ Explictly filter out the per-account outbox accounts. I don't know why
+ these only sometimes show up, but now they should never show up in the UI.
+ This should fix projects.maemo.org bug NB#60160.
+
+2007-06-14 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
+ when the toolbar does not exist yet.
+ * src/modest-widget-memory.c: (save_settings_header_view):
+ Added g_warnings() to help us to discover when we are trying to set
+ an empty columns list in gconf.
+
+2007-06-14 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-init.h:
+ * src/modest-init.c:
+ Added modest_init_get_default_header_view_column_ids().
+
+ * src/modest-widget-memory.c: (restore_settings_header_view):
+ Use the new function to get defaults, if the gconf key is empty,
+ instead of not creating any columns. This seems to fix the
+ empty right-hand pane problems.
+
+ * src/widgets/modest-header-view.h: Improved documentation.
+
+2007-06-13 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
+ Revert the use of the display name as the account name, because this
+ is generally wrong and would break the code that follows.
+
+2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
+
+ * src/maemo/easysetup/modest-easysetup-wizard.c:
+ (check_for_supported_auth_methods), (on_before_next),
+ (create_account):
+
+ More correct fix for projects.maemo.org bug NB# 58991
+ Do not longer accept AUTH_PASSWORD as secure method and choose
+ correct method when creating the account.
+
+2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
+
+ * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
+ Fixed projects.maemo.org bug NB# 58991
+
+2007-06-13 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-init.c: (modest_init_init_core),
+ (modest_init_local_folders): Fixed compilation errors.
+
+2007-06-13 Murray Cumming <murrayc@murrayc.com>
+
+ * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
+ Remove unnecessary lib/include, though it is good in principle when needed.
+
+ * src/modest-init.c: (modest_init_one_local_folder),
+ (modest_init_local_folders):
+ * src/modest-init.h: Initialize the .modest library for memory cards,
+ instead of just doing nothing for them. This should allow us to create
+ folders there, fixing projects.maemo.org bug NB#59297.
+
+2007-06-13 Murray Cumming <murrayc@murrayc.com>
+
+ * libmodest-dbus-client/libmodest-dbus-client.c:
+ (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
+ (libmodest_dbus_client_compose_mail),
+ (libmodest_dbus_client_open_message),
+ (libmodest_dbus_client_send_and_receive),
+ (libmodest_dbus_client_open_default_inbox): Improved debug messages.
+
+ * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
+ (on_idle_open_message), (modest_dbus_req_handler),
+ (search_result_to_message), (modest_dbus_req_filter):
+ * src/modest-search.c: (add_hit), (modest_search_folder),
+ (modest_search_all_accounts): Improved debug messages.
+
+ * tests/dbus_api/test_open_message.c: (main): Improved comments.
+
+ * src/modest-tny-account-store.c:
+ (modest_tny_account_store_get_tny_account_by): Initialize a variable to
+ fix the build.
+
+2007-06-13 Murray Cumming <murrayc@murrayc.com>
+
+
+2007-06-12 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account-store.c: (get_server_accounts):
+ Call modest_tny_local_folders_account_add_merged_outbox_folders()
+ even when there are no accounts, so that the Outbox folder is always
+ visible. This fixes projects.maemo.org bug NB#60158.
+
+2007-06-12 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-main-window.c: (create_details_widget):
+ Use the mcen_va_never logical ID.
+
+2007-06-12 Murray Cumming <murrayc@murrayc.com>
+
+ * src/dbus_api/modest-dbus-api.h:
+ * src/dbus_api/modest-dbus-callbacks.c:
+ (on_idle_open_default_inbox), (on_open_default_inbox),
+ (modest_dbus_req_handler):
+ Added a new OpenDefaultInbox method.
+
+ * libmodest-dbus-client/libmodest-dbus-client.h:
+ * libmodest-dbus-client/libmodest-dbus-client.c:
+ Added libmodest_dbus_client_open_default_inbox() to call the new
+ dbus method. This should be useful to projects.maemo.org bug NB#57214,
+ though it should maybe be used by a new osso-email-interface function.
+
+ * tests/dbus_api/Makefile.am:
+ * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
+ function.
+
+2007-06-12 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
+ NULL, so that the signals get all the keys. This should not actually
+ change any behaviour because we currently update everything when anything
+ changes.
+
+2007-06-12 Murray Cumming <murrayc@murrayc.com>
+
+ * src/widgets/modest-folder-view.c: (text_cell_data),
+ (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
+ (find_inbox_iter): If tinymail tells us that the folder is
+ a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
+ This causes the inbox to be selected at startup, fixing part of
+ projects.maemo.org bug NB#56305.
+
+ * src/modest-ui-dimming-rules.c:
+ (modest_ui_dimming_rules_on_tools_smtp_servers):
+ * src/modest-ui-dimming-rules.h: Added a callback function to dim
+ the SMTP servers menu item.
+ * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
+ that the SMTP Servers menu item is dimmed when there are no accounts,
+ as a future version of the UI spec will require. This fixes
+ projects.maemo.org bug NB#56305.
+
+2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
+
+ * src/maemo/modest-maemo-utils.c:
+ (modest_maemo_utils_get_supported_secure_authentication_methods):
+ Added label to dialog instead of unreadable title
+
+ * src/maemo/modest-main-window.c: (sync_accounts_cb),
+ (modest_main_window_new):
+ Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
+ dead code.
+
+ * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
+ * src/modest-account-mgr.h:
+ Added method to avoid code duplication
+
+ * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
+ (modest_ui_actions_on_send_receive):
+ Use modest_account_mgr_has_accounts
+
+2007-06-11 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/easysetup/modest-presets.c:
+ (modest_presets_get_info_server_security): Do not report secure auth
+ if there is none.
+ * src/modest-protocol-info.c: Use the defines for the gconf key names
+ for secure authentication. This was not working because we were writing
+ Password and reading password, and the check was case sensitive.
+ With this, gmail now works for receiving and sending when created via
+ easysetup.
+
+2007-06-11 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/easysetup/modest-presets.c:
+ (modest_presets_get_info_server_security): Correct the key name for
+ SecureSmtp, because it seems to be case-sensitive.
+ * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
+ Do not try to get the 0th notebook page if there are 0 pages, to
+ avoid a g_warning().
+
+2007-06-11 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
+ Prevent use of the new notification feature for now, because it currently
+ shows one dialog for each new email, which is annoying.
+
+2007-06-11 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
+ (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
+ when no country was selected, so that we show the global ones.
+ * src/maemo/easysetup/modest-presets.c:
+ (modest_presets_get_providers): Return only the global providers, not
+ all providers when mmc=0 was requested.
+
+2007-06-11 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
+ (easysetup_provider_combo_box_fill): Remove debug code that showed the
+ provider ID in the combo.
+
+ * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
+ Do not show the page numbers, because it would be confusing when we add
+ the 2 extra pages for the custom setup, when the user chooses the "Other"
+ provider. This fixes projects.maemo.org bug NB#59028
+
+ * src/modest-init.c: (modest_init_init_core),
+ (modest_init_local_folders):
+ * src/modest-init.h:
+ * src/modest-tny-account.c:
+ (modest_tny_account_new_for_local_folders): Do not create default folders
+ for the memory card. This should fix projects.maemo.org bug NB#59328.
+
+2007-06-11 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-account-mgr.c: (modest_account_mgr_finalize):
+ Free the changed_conf_keys string items. They are already freed in the
+ idle handler if that runs first.
+
+2007-06-11 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-ui-actions.c:
+ (modest_ui_actions_on_password_requested): Check that the server name
+ is not NULL, because I just saw a password dialog with (null) as the
+ server name.
+
+ * src/modest-tny-folder.[h|c]: Added
+ modest_tny_folder_is_memory_card_folder().
+ * src/modest-ui-dimming-rules.c:
+ (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
+ menu item for memory cards, as per the UI spec (section 7.4). This should
+ fix projects.maemo.org bug NB#59297.
+
+2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
+
+ * src/maemo/modest-main-window.c: (sync_accounts_cb):
+ Fixed projects.maemo.org bug NB#58576 (not yet activated as there
+ is another problem with the code, see Murray's comment at line 772)
+
+2007-06-08 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
+ * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
+ (on_model_foreach_release), (easysetup_country_combo_box_finalize),
+ (load_from_file), (easysetup_country_combo_box_init),
+ (easysetup_country_combo_box_get_active_country_ids),
+ (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
+ instead of just one ID, to avoid duplicate country names in the UI.
+
+ * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
+ * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
+ (easysetup_provider_combo_box_fill): Adapt to use a list rather than
+ a single ID, avoiding duplicate providers.
+ * src/maemo/easysetup/modest-easysetup-wizard.c:
+ (on_combo_account_country): Adapt to use a list.
+
+2007-06-08 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
+ keys changed in the last X seconds.
+
+ * src/modest-account-mgr.h:
+ * src/modest-account-mgr.c: (on_timeout_notify_changes),
+ (on_key_change), (modest_account_mgr_class_init),
+ (modest_account_mgr_init), (modest_account_mgr_finalize):
+ As the keys are changed, save them in a GSList* and signal that GSList*
+ further every X seconds, to batch changes, to allow us to do just one
+ update per batch. This should fix bug projects.maemo.org bug NB#56472 and
+ bug NB#56941 and other (UI-blocking) delays when changing account settings.
+
+ * src/modest-tny-account-store.c: (on_account_changed): Adapted to
+ changed signal signature.
+
+ * src/modest-conf.c: (modest_conf_set_list),
+ (modest_conf_on_change): Reenable notification.
+
+ (modest_conf_maemo_fake_on_change): Comment out the hack that
+ notified immediately instead of asynchronously.
+
+ * src/widgets/modest-account-view.h:
+ * src/widgets/modest-account-view.c:
+ (update_account_view): Select the previously-selected account ID,
+ if possible. This fixes projects.maemo.org bug NB#56933.
+
+ (on_account_changed), (on_account_removed),
+ (modest_account_view_select_account):
+
+ Remove the block/unblock functions
+ because they were not useful.
+
+ * src/maemo/modest-account-view-window.c:
+ (on_delete_button_clicked), (on_edit_button_clicked),
+ (on_new_button_clicked): Remove the use of the non-working block/unblock.
+
+2007-06-08 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
+ Improve the error dialog to show Incorrect Account Settings, which seems
+ clearer, and say that the internal error message (to be removed from the
+ dialog later) is often misleading.
+ I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
+
+ * src/modest-tny-account.c:
+ (modest_tny_account_new_from_server_account): Uncomment the printf of the
+ URL because this is so useful for debugging on the device.
+
+ * src/widgets/modest-serversecurity-combo-box.c:
+ (modest_serversecurity_combo_box_fill): Correct a logical ID.
+
+2007-06-08 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-mail-operation.c:
+ (modest_mail_operation_send_new_mail):
+ Added a comment about a nasty but apparently harmless message. Details
+ added to the wiki g_warnings() page.
+
+2007-06-08 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
+ (modest_tny_send_queue_class_init):
+ Do not use the priv struct because it is empty, to avoid g_warnings
+ about a non-existant priv struct.
+
+ * src/modest-tny-account-store.c:
+ (modest_tny_account_store_get_server_account),
+ (modest_tny_account_store_get_transport_account_for_open_connection
+ ): Do not try to get transport server accounts for local folders,
+ because they don't have any. This avoids a g_warning().
+
+ * src/maemo/modest-main-window.c:
+ (modest_main_window_notify_send_receive_initied),
+ (on_configuration_key_changed):
+ * src/maemo/modest-msg-edit-window.c: (on_delete_event):
+ * src/modest-defs.h:
+ * src/modest-mail-operation.c:
+ (modest_mail_operation_update_account):
+ * src/modest-tny-account-store.h:
+ * src/modest-tny-account.c:
+ (modest_tny_account_get_special_folder),
+ (modest_tny_account_new_for_local_folders),
+ (modest_tny_account_new_for_per_account_local_outbox_folder):
+ * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
+ * src/modest-tny-local-folders-account.c:
+ (add_account_folders_to_merged_folder):
+ * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
+ (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
+ (modest_ui_actions_on_send):
+ * src/widgets/modest-folder-view.c: (update_model):
+ Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
+ MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
+ modest_tny_account_store_get_tny_account_by_account() to
+ modest_tny_account_store_get_server_account() to make the code clearer.
+
+2007-06-07 Marcus Bauer <marcusb@openismus.com>
+
+ * src/dbus_api/modest-dbus-api.h:
+ changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
+ * src/maemo/modest-msg-edit-window.c:
+ (modest_msg_edit_window_attach_file_noninteractive):
+ added g_warning in case the file to be attached does not exist
+ * tests/dbus_api/test_compose_mail.c: (main):
+ removed obsolete comment, added generic files as test case
+
+2007-06-07 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account-store.c: (get_server_accounts):
+ Create the local folders account only once, not once for each outbox, and
+ not only when there are some outboxes.
+
+2007-06-07 Murray Cumming <murrayc@murrayc.com>
+
+ * src/widgets/modest-folder-view.c: (update_model): Comment out some
+ code that is causing a crash at startup. Sergio says that he is fixing this.
+
+2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
+
+ * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
+ * src/maemo/modest-account-settings-dialog.c:
+ (create_page_outgoing),
+ (modest_account_settings_dialog_set_account_name),
+ (save_configuration):
+ - Fixed handling of the "Use secure authentication" toggle to comply with
+ the ui specification. See also projects.maemo.org bug NB#58400
+
+ - Restore the Secure connection setting combo correctly when loading
+ the settings dialog
+
+ * src/maemo/modest-maemo-utils.c:
+ (on_camel_account_get_supported_secure_authentication),
+ (modest_maemo_utils_get_supported_secure_authentication_methods):
+ Fixed a crasher if operation is canceled
+
+ * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
+ (modest_protocol_info_auth_is_secure):
+ * src/modest-protocol-info.h:
+
+ Added two new methods to determine if a protocol/auth method is secure/encrypted in
+ the sense of the "Use secure authentication" toggle.
+
+2007-06-07 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account-store.h:
+ * src/modest-tny-account-store.c:
+ Added modest_tny_account_store_get_local_folders_account().
+
+ * src/modest-tny-folder.h:
+ * src/modest-tny-folder.c:
+ (modest_tny_folder_get_account):
+ Added this replacement for tny_folder_get_account() which returns
+ the local-folders account for TnyMergeFolders, to avoid the
+ warning about the unimplemented get_account_func() vfunc().
+
+ (modest_tny_folder_get_rules),
+ * src/modest-ui-actions.c:
+ (modest_ui_actions_on_folder_selection_changed):
+ * src/modest-mail-operation.c:
+ (modest_mail_operation_remove_folder),
+ (modest_mail_operation_xfer_folder),
+ (modest_mail_operation_rename_folder),
+ (modest_mail_operation_get_msg),
+ (modest_mail_operation_get_msgs_full),
+ (modest_mail_operation_remove_msg),
+ (modest_mail_operation_xfer_msgs),
+ (modest_mail_operation_refresh_folder):
+ Use modest_tny_folder_get_account() instead of tny_folder_get_account().
+
+2007-06-07 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
+ (modest_server_account_set_security):
+ * src/modest-defs.h: Add comments explaining that our
+ UI spec means TLS when it says Normal, so these do not look like errors.
+
+ * src/modest-tny-account.c:
+ (modest_tny_account_new_from_server_account): Use the new tinymail
+ 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
+ for TLS. This should fix projects.maemo.org bug NB#58460.
+
+2007-06-06 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/easysetup/modest-easysetup-wizard.c:
+ (create_account): Correct the position of the gconf sanity check warning.
+ (on_button_edit_advanced_settings): Show the dialog immediately, instead
+ of using the g_idle_add() hack, because this does not seem to be necessary
+ on osso 1.1. It might even work on Maemo Bora if the problems were actually
+ caused by something other than maemo's gconf.
+ This fixes projects.maemo.org bug #59022.
+
+2007-06-06 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-account-mgr-helpers.c:
+ (modest_account_mgr_get_default_account): Do not check that the account
+ exists if there is no default account (NULL), to fix a runtime warning.
+
+2007-06-06 Murray Cumming <murrayc@murrayc.com>
+
+ * src/widgets/modest-folder-view.c: (update_model):
+ Do not unref the treemodel before we have finished with it.
+ This prevents a valgrind warning and an occasional crash at startup.
+
+2007-06-06 Marcus Bauer <marcusb@openismus.com>
+
+ * libmodest-dbus-client/libmodest-dbus-client.h:
+ added libmodest_dbus_client_compose_mail()
+ * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
+ (on_compose_mail):
+ added functions needed for SendAsMail() functionality
+ * src/maemo/modest-msg-edit-window.c:
+ (modest_msg_edit_window_attach_file_noninteractive):
+ non interactively attaching files to message edit window
+ * src/widgets/modest-msg-edit-window.h:
+ * tests/dbus_api/Makefile.am:
+ added test_compose_mail.c
+ * tests/dbus_api/test_compose_mail.c: (main):
+
+2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
+
+ * src/modest-account-view.c:
+ Fixed bug projects.maemo.org bug NB#59307
+
+2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
+
+ * src/maemo/easysetup/modest-easysetup-wizard.c:
+ (get_serverport_incoming), (on_before_next), (create_account):
+ * src/maemo/modest-account-settings-dialog.c:
+ (modest_account_settings_dialog_set_account_name):
+ * src/maemo/modest-maemo-utils.c:
+ (on_camel_account_get_supported_secure_authentication_status),
+ (on_camel_account_get_supported_secure_authentication),
+ (on_secure_auth_cancel),
+ (modest_maemo_utils_get_supported_secure_authentication_methods):
+
+ Implemented security authentication for settings and easysetup.
+
+2007-06-05 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-main-window.c: (create_details_widget):
+ Show the total size for memory card accounts too, instead of showing
+ the name again. Fixes bug projects.maemo.org bug NB#59307.
+
+2007-06-05 Murray Cumming <murrayc@murrayc.com>
+
+ * src/Makefile.am:
+ * src/modest-tny-simple-folder-store.c:
+ * src/modest-tny-simple-folder-store.h: Removed.
+
+ * src/modest-tny-local-folders-account.h
+ * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
+ for the local-folders maildir, with an extra TnyMergedFolder containing
+ the folders of the per-account outbox store accounts.
+ * src/modest-tny-account-store.c: (get_server_accounts):
+ Add the outboxes to the special local folders account after creating it.
+
+ * src/modest-tny-account.c:
+ (modest_tny_account_new_for_local_folders): Create the derived
+ account when creating the main local-folders account.
+
+ * src/maemo/modest-main-window.c: (create_details_widget),
+ (modest_main_window_set_contents_style):
+ Adapted to the use of the derived account instead of the folder store.
+
+ * src/modest-ui-actions.c:
+ (modest_ui_actions_on_folder_selection_changed):
+ * src/modest-ui-dimming-rules.c:
+ (modest_ui_dimming_rules_on_new_folder):
+ * src/widgets/modest-folder-view.c: (text_cell_data),
+ (icon_cell_data), (filter_row), (update_model),
+ (get_cmp_rows_type_pos):
+
+
+ * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
+ Do not get the priv struct, because no priv struct has been set,
+ to avoid a runtime warning.
+
+ * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
+ #ifelse with #else, to fix a warning, to fix the build.
+
+
+2007-06-05 Christian Kellner <ckellner@openismus.com>
+
+ * libmodest-dbus-client/libmodest-dbus-client.c:
+ Fix small typo in doc (why do you always see them
+ AFTER committing stuff?)
+
+
+2007-06-05 Christian Kellner <ckellner@openismus.com>
+
+ * libmodest-dbus-client/libmodest-dbus-client.c:
+ (libmodest_dbus_client_search):
+ Initialize hit list with NULL. Also set folder list
+ to "" if NULL was supplied.
+ Add documentation.
+
+2007-06-03 Christian Kellner <ckellner@openismus.com>
+
+ * libmodest-dbus-client/libmodest-dbus-client.c:
+ (modest_search_hit_list_free):
+ Make it save to call it with NULL.
+
+ * src/dbus_api/modest-dbus-callbacks.c:
+ * src/modest-search.c:
+ Return full ModestSearchHits as the search result list not TnyHeader
+ since can't be around withouth the correspoding TnyFolder.
+
+2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
+
+ * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
+ Added currently commented code to check for secure auth
+
+ * src/maemo/modest-account-settings-dialog.c: (on_response),
+ (save_configuration), (show_ok):
+ Fixed projects.maemo.org bugs NB #59248 and #59251
+
+ * src/maemo/modest-maemo-utils.c:
+ (on_camel_account_get_supported_secure_authentication_status),
+ (on_camel_account_get_supported_secure_authentication),
+ (modest_maemo_utils_get_supported_secure_authentication_methods):
+ * src/maemo/modest-maemo-utils.h:
+ Moved get_supported_secure_authentication() method here to be able
+ to use it from easysetup wizard.
+
+ * src/modest-pair.c: (on_pair_compare_as_string):
+ Should compare string with first part of pair and not
+ strcmp pairs which will crash.
+
+ * src/modest-protocol-info.c:
+ (modest_protocol_info_protocol_is_store):
+ * src/modest-protocol-info.h:
+ Added modest_protocol_info_get_auth_protocol_name()
+
+2007-06-03 Armin Burgmeier <armin@openismus.com>
+
+ * src/modest-mail-operation.c:
+ (modest_mail_operation_get_msgs_full): Set priv->account also when
+ only retrieving a single message. This avoids a crash when canceling
+ the operation.
+
+ (modest_mail_operation_notify_end): Do not explicitely remove the
+ operation from the queue but only emit the progress_changed signal.
+ The queue itself listens to that signal to remove the operation when
+ it is finished. This reduces coupling and removes a potential deadlock
+ when modest_mail_operation_notify_end() is called from the queue
+ itself. If that is a problem performance-wise, I would suggest to
+ implement a status-changed signal or something.
+
+ * src/modest-mail-operation-queue.c: Make sure to never call a
+ function from another file while the queue is locked. This (hopefully)
+ fixes another deadlock when exiting the application while retrieving
+ mail.
+
+2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
+
+ * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
+ Fixed build if libogs is not available
+
+2007-06-03 Christian Kellner <ckellner@openismus.com>
+
+ * libmodest-dbus-client/libmodest-dbus-client.h:
+ * libmodest-dbus-client/libmodest-dbus-client.c:
+ (libmodest_dbus_client_delete_message):
+ Implement deletion of messages (Client side).
+
+ (modest_search_hit_free),
+ (modest_search_hit_list_free):
+ Utility functions to free the result hits.
+
+ * src/dbus_api/modest-dbus-api.h:
+ * src/dbus_api/modest-dbus-callbacks.c:
+ (on_delete_message),
+ (modest_dbus_req_handler):
+ Implement deletion of messages (Server side).
+
+ * tests/dbus_api/test_search.c: (main):
+ Free the hits.
+
+ * tests/dbus_api/Makefile.am:
+ * tests/dbus_api/test_delete_message:
+ Add little test for the message deletion logic
+
+2007-06-03 Armin Burgmeier <armin@openismus.com>
+
+ * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
+ when the operation queue was not empty. projects.maemo.org bug
+ NB#58976.
+
+2007-06-03 Armin Burgmeier <armin@openismus.com>
+
+ * src/widgets/modest-account-view.c
+ (on_account_default_toggled): Toggle default account column
+ explicitely instead of waiting for gconf notification (which is
+ currently ignored). This should fix projects.maemo.org bug NB#56910
+ for now. It should probably be removed when gconf notifications are
+ re-enabled.
+
+2007-06-03 Christian Kellner <ckellner@openismus.com>
+
+ * libmodest-dbus-client/libmodest-dbus-client.c:
+ Removed debugging spew.
+
+ * src/dbus_api/modest-dbus-callbacks.c:
+ Added debugging info.
+
+ * src/modest-search.c:
+ (modest_search_all_accounts):
+ Use tny_account_store_get_accounts () on the account store
+ to get all accounts which is the way to get all accounts.
+
+ * tests/dbus_api/test_search.c: (main):
+ Make it possible to supply the search term on the command line.
+
+2007-06-03 Christian Kellner <ckellner@openismus.com>
+
+ * libmodest-dbus-client/libmodest-dbus-client.c:
+ * libmodest-dbus-client/libmodest-dbus-client.h:
+ Implement searching for mesages over raw dbus. (Client side)
+
+ * src/dbus_api/Makefile.am:
+ * src/dbus_api/modest-dbus-api.h:
+ * src/dbus_api/modest-dbus-callbacks.c:
+ * src/dbus_api/modest-dbus-callbacks.h:
+ Search framework (Server side). Also implement on_idle_open_message().
+
+ * src/maemo/modest-platform.c: (modest_platform_init):
+ Prepare for raw dbus/osso rpc interaction.
+
+ * src/modest-search.h:
+ Changed minsize from unspecific guint to guint32.
+
+ * src/modest-search.c:
+ (add_header):
+ Added strange hack which magically made tnymail work.
+
+ (modest_search_folder),
+ (modest_search_account),
+ (modest_search_all_accounts):
+ Implement helper functions to search all accounts, specific account
+ and folder.
+
+ * tests/dbus_api/Makefile.am:
+ * tests/dbus_api/test_open_message.c:
+ Read url to open from commandline.
+
+ * tests/dbus_api/test_search.c:
+ Implement small test for dbus search stuff
+
+2007-06-02 Armin Burgmeier <armin@openismus.com>
+
+ * src/maemo/modest-account-settings-dialog.c: Changed window title to
+ include account type and account title. This fixes projects.maemo.org
+ bug NB#59000.
+
+ * src/maemo/modest-account-view-window.c: Set a title for the window.
+
+2007-06-02 Armin Burgmeier <armin@openismus.com>
+
+ * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
+ incoming and outgoing server name based on email address and server
+ types as long as the names have not been edited manually. This fixes
+ projects.maemo.org bug NB#58671.
+
+2007-06-02 Armin Burgmeier <armin@openismus.com>
+
+ * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
+ server type cannot be changed in future to the incoming details page
+ when creating an account. This fixes projects.maemo.org bug NB#59029.
+
+2007-06-02 Armin Burgmeier <armin@openismus.com>
+
+ * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
+ and assigned max width chars so that they wrap instead of being
+ truncated. Fixes projects.maemo.org bug NB#56126.
+
+2007-06-02 Armin Burgmeier <armin@openismus.com>
+
+ * src/maemo/modest-connection-specific-smtp-window.c: Add an
+ introductory note to the connection specific smtp servers dialog, as
+ section 8.12 of the email UI specification requires. This fixes
+ projects.maemo.org bug NB#59212.
+
+2007-06-01 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
+ Check for running mail operations, and offer to cancel them, as per the UI
+ spec. This fixes projects.maemo.org bug NB#59041 .
+ However, I suspect that tinymail may still use the network connection
+ in ways that we cannot detect or cancel. But it should at least adapt to
+ changes fairly well.
+
+2007-06-01 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account-store.c: (recreate_all_accounts),
+ (get_cached_accounts), (get_server_accounts): Do more sensible
+ ref-counting of the temporarily-cached outbox accounts list. This seems
+ to fix a crash when entering the password when the password was wrong.
+
+2007-06-01 Murray Cumming <murrayc@murrayc.com>
+
+ * src/gnome/modest-main-window.c: (connect_signals):
+ * src/modest-tny-account-store.c: (get_password),
+ (modest_tny_account_store_alert): Added comments and clues and
+ commented-out code about how we currently fail to deal with connection
+ errors and wrong passwords, and how we should.
+
+2007-06-01 Murray Cumming <murrayc@murrayc.com>
+
+ * src/widgets/modest-retrieve-combo-box.c:
+ (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
+ This fixes projects.maemo.org bug NB#58472 .
+
+2007-06-01 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/easysetup/modest-easysetup-wizard.c:
+ (create_page_complete_easysetup):
+ (create_page_complete_custom): Correct the last commit,
+ putting the correct sentences in the correct pages.
+
+2007-06-01 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/easysetup/modest-easysetup-wizard.c:
+ (create_page_complete_custom): Show the second sentence of text
+ (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
+ NB#59023 .
+
+2007-06-01 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-account-mgr.c: (modest_account_mgr_add_account):
+ Set the leave-on-server conf key by default. This fixes
+ projects.maemo.org bug NB#59258 .
+
+2007-06-01 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-account-view-window.c:
+ (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
+ logical ID for the confirmation messages. Fixed projects.maemo.org bug
+ NB#59037 .
+
+2007-06-01 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/easysetup/modest-easysetup-wizard.c:
+ (create_caption_new_with_asterisk):
+ * src/maemo/modest-account-settings-dialog.c:
+ (create_caption_new_with_asterisk):
+ Uncomment the code to add the asterisk, because they are no longer in the
+ translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
+ (update_incoming_server_title): Add an asterisk here too.
+
+2007-06-01 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-maemo-global-settings-dialog.c:
+ (current_connection): Check that we are even connected before trying to
+ get the current connection name, to prevent a warning.
+
+ * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
+ Change the comments because tny_maemo_conic_device_connect() is now meant to
+ block.
+ * src/modest-mail-operation.c:
+ (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
+ make sure we have a connection and fail if we can't connect.
+
+2007-05-31 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-main-window.c:
+ (on_account_store_connecting_finished): Do not try to get the
+ connection ID if we are not really connected. I am surprised that
+ this signal handler is called when we are not connected.
+
+2007-05-31 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-error.h:
+ * src/modest-ui-actions.c:
+ (modest_ui_actions_get_msgs_full_error_handler):
+ Renamed an enum, added comments, added an enum
+ for retrieve-limit errors.
+
+ * src/modest-mail-operation.c: (foreach_add_item),
+ (internal_folder_observer_update), (update_account_thread),
+ (modest_mail_operation_get_msgs_full):
+ (modest_mail_operation_update_account),
+ Added comments about how this works, and some code that should
+ (but does not) check the retrieve-limit. See the TODO comment.
+
+2007-05-31 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-ui-actions.c: (modest_ui_actions_on_help):
+ Initialize help_id to fix the build. Warnings are good.
+
+2007-05-31 Murray Cumming <murrayc@murrayc.com>
+
+ * src/widgets/modest-hbox-cell-renderer.c:
+ (modest_hbox_cell_renderer_append):
+ * src/widgets/modest-vbox-cell-renderer.c:
+ (modest_vbox_cell_renderer_append):
+ Fix the last commit by doing an extra ref.
+
+2007-05-31 Murray Cumming <murrayc@murrayc.com>
+
+ * src/widgets/modest-hbox-cell-renderer.c:
+ (modest_hbox_cell_renderer_append):
+ * src/widgets/modest-vbox-cell-renderer.c:
+ (modest_vbox_cell_renderer_append):
+ For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
+ to fix the build with Maemo Bora.
+ However, there seems to be a remaining crash, probably due to reference
+ counting errors.
+
+2007-05-30 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account.c:
+ (modest_tny_account_new_for_local_folders):
+ Use hildon_file_system_info_async_new() to get a better name for
+ the memory card account, setting it as the account name.
+ The timing seems to work, but this is probably
+ not the best place to do this. See the TODO comment.
+ * src/maemo/modest-main-window.c: (create_details_widget):
+ * src/widgets/modest-folder-view.c: (text_cell_data):
+ Use the tny account name instead of hardcoding a name.
+
+2007-05-30 Christian Kellner <ckellner@openismus.com>
+
+ * src/modest-search.c: (modest_search):
+ Correctly set part_search_func even if we have already parsed
+ the query and thus a valid OgsTextSearcher object.
+
+2007-05-30 Christian Kellner <ckellner@openismus.com>
+
+ * configure.ac:
+ Search and check for libogs.
+
+ * src/Makefile.am:
+ Incooparte the ogs build env.
+
+ * src/modest-mime-part-search-stream.c:
+ * src/modest-mime-part-search-stream.h:
+ Removed since we do the real searching now in modest-search.c.
+
+ * src/modest-search.c:
+ * src/modest-search.h:
+ Implement support for ogs. We use that if available and requested
+ and fall back to modest_text_utils_utf8_strcmp (). The search logic
+ should now handle the corner case when the search term is spread
+ across multiple reads.
+ Also the logic in modest_search () was corrected to search all
+ requested fields until one is found.
+
+2007-05-30 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
+
+ * src/modest-init.h:
+ * src/modest-init.c: Made modest_init_local_folders() take a
+ path and be public so we can iniitialize maildir folders on
+ arbitrary volumes.
+
+ * src/modest-local-folder-info.h:
+ * src/modest-local-folder-info.c:
+ (modest_local_folder_info_get_maildir_path): Add a path parameter.
+
+ * src/modest-tny-account.c:
+ (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
+ still means the standard local-folders path on the local volume.
+
+ * src/modest-tny-account-store.c:
+ (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
+ signal so we can detect mount/unmount of the MMC1 card, and do an update of
+ all accounts when that happens.
+ (get_server_accounts): If the MMC1 card is mounted, create a store account for
+ this too, so it shows up in the treeview.
+
+2007-05-28 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-maemo-global-settings-dialog.c:
+ (current_connection):
+ * src/widgets/modest-global-settings-dialog.c:
+ (current_connection_default):
+ Use the enum values instead of 0, 1 and -1,
+ to make the code clearer.
+
+ * src/modest-account-mgr-helpers.c:
+ (modest_account_mgr_get_connection_specific_smtp): Make this code
+ more robust.
+
+ * src/modest-runtime.h:
+ * src/modest-runtime.c:
+ Added modest_runtime_remove_all_send_queues().
+ * src/maemo/modest-main-window.c:
+ (on_account_store_connecting_finished): Recreate the send queues,
+ using the appropriate transport accounts for this new connection.
+ Some futher adapting might be needed if the old send queues are not
+ automatically stopped at this point.
+
+ * src/modest-tny-account-store.c: (get_server_accounts):
+ Create the connection-specific transport accounts, so that they can
+ be found later by their ID.
+
+ * src/modest-tny-account.h:
+ * src/modest-tny-account.c:
+ Added modest_tny_account_new_from_server_account_name().
+ modest_tny_account_new_from_server_account(): Do not create the
+ send queues here, because they will be
+ recreated anyway when the connection changes for the first time.
+
+2007-05-28 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-local-folder-info.h:
+ * src/modest-local-folder-info.c:
+ (modest_per_account_local_outbox_folder_info_get_maildir_path),
+ (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
+ tbox_folder): Take a modest account name instead of a server TnyAccount,
+ so we can have per-modest-account rather than per-transport-account
+ outboxes.
+ We must make sure that we change or recreate the exisitng send queues
+ when the connection changes for connection-specific transport accounts.
+
+ * src/modest-tny-account-store.c:
+ (create_per_account_local_outbox_folders): Create outboxed per modest
+ account, not per transport account.
+
+ * src/modest-tny-account.h:
+ * src/modest-tny-account.c:
+ (modest_tny_account_get_special_folder): For outboxes, get the
+ parent modest account name. The account is ignored for other folders.
+ (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
+ modest account name rather than a server TnyAccount.
+
+2007-05-25 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account.c:
+ (modest_tny_account_new_from_server_account):
+ Call modest_runtime_get_send_queue() immediately after creating transport
+ accounts, so that they start trying to send email from the outbox as soon
+ as possible at startup. This is probably what we want.
+
+ * src/modest-mail-operation.c: (update_account_thread):
+ * src/modest-runtime.c: (modest_runtime_get_send_queue):
+ * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
+ * src/modest-tny-send-queue.h:
+ * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
+ (modest_ui_actions_on_send):
+ Added comments about how sending works, though it needs some more work.
+
+2007-05-25 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account.c:
+ (modest_tny_account_get_special_folder): Add TODO because this fails when
+ the network is busy.
+ (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
+ * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
+ Do not try to show this window when there is no active account. The UI
+ specs does not tell us what to do in this case.
+
+2007-05-24 Murray Cumming <murrayc@murrayc.com>
+
+ * Makefile.am:
+ * po/POTFILES.in:
+ * src/maemo/Makefile.am:
+ * src/widgets/Makefile.am: Some dist fixes.
+
+2007-05-24 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-connection-specific-smtp-window.c:
+ (on_button_edit): Make the code clearer, to prevent a double free.
+
+2007-05-24 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-account-settings-dialog.c:
+ (modest_account_settings_dialog_set_account_name),
+ Check the connection-specific smtp servers checkbox if there are any.
+
+ * src/maemo/modest-connection-specific-smtp-edit-window.c:
+ (modest_connection_specific_smtp_edit_window_init):
+ Start with a suitable port number.
+
+ * src/modest-account-mgr-helpers.h:
+ * src/modest-account-mgr-helpers.c: Added
+ modest_account_mgr_get_has_connection_specific_smtp().
+
+ (modest_account_mgr_set_connection_specific_smtp),
+ (modest_account_mgr_remove_connection_specific_smtp),
+ (modest_account_mgr_get_has_connection_specific_smtp),
+ (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
+ connection-specific smtp server accounts in the account, rather than
+ the server account conf dir.
+
+ This fixes bug projects.maemo.org bug NB#58263 .
+
+ * src/modest-tny-account-store.c:
+ (create_per_account_local_outbox_folders): Do not call get_server_accounts()
+ if there are no server accounts yet, to prevent an infinite loop when there
+ are no accounts. Document that one must be called before the other.
+
+2007-05-24 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-account-mgr-helpers.c:
+ (modest_account_mgr_get_default_account): Make sure that at least
+ one account is always the default, if there are any enabled accounts.
+ This is just a sanity check that shouldn't be necessary.
+
+ * src/modest-account-mgr-priv.c:
+ (_modest_account_mgr_account_from_key): Unescape the conf key to
+ get the real account name. For instance, this is an issue if a space
+ was in the account name, which can happen because the account name
+ is generated from the display name.
+ (_modest_account_mgr_get_account_keyname): Always escape the
+ account name.
+ * src/modest-account-mgr.c: (modest_account_mgr_account_names):
+ Unescape the conf keys to get the real account names.
+
+ For instance, previously the is-default radio button in the accounts
+ list was not checked for any accounts at first. This fixes that,
+ and might fix several similar bugs.
+
+2007-05-23 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-ui-actions.c: (set_active_account_from_tny_account):
+ Removed some debug printfs.
+
+2007-05-23 Murray Cumming <murrayc@murrayc.com>
+
+ Modest on-disk outbox directories are now here, for instance:
+ $HOME/.modest/outboxes/<account-id-1>/outbox
+ $HOME/.modest/outboxes/<account-id-2>/outbox
+ instead of here:
+ $HOME/.modest/local-folders/outbox
+ so we can have a separate outbox for each account.
+ But they are shown as one outbox in the GtkTreeView, by using a
+ TnyMergeFolder in a ModestTnySimpleFolderStore.
+
+ * src/Makefile.am:
+ * src/modest-tny-simple-folder-store.c:
+ * src/modest-tny-simple-folder-store.h:
+ Added ModestTnySimpleFolderStore, used to contain folders from
+ other folder stores, such as other accounts.
+
+ * src/modest-tny-outbox-account.h:
+ * src/modest-tny-outbox-account.c:
+ Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
+ used for the per-account local outbox folders.
+
+ * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
+ MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
+ only use this (internally) now for the non-outbox local folders.
+
+ * src/modest-init.h:
+ * src/modest-init.c: Added modest_init_one_local_folder(), for
+ setting up the directory structure for each local folder.
+
+ * src/modest-local-folder-info.c:
+ (modest_per_account_local_outbox_folder_info_get_maildir_path),
+ (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
+ tbox_folder):
+ * src/modest-local-folder-info.h:
+ * src/modest-tny-account-store.c: (on_account_removed),
+ (on_account_changed), (create_per_account_local_outbox_folders),
+ (get_server_accounts), (modest_tny_account_store_get_accounts),
+ (modest_tny_account_store_get_tny_account_by_account),
+ (modest_tny_folder_store_is_virtual_local_folders):
+
+ * src/modest-tny-account.h:
+ * src/modest-tny-account.c:
+ Added modest_tny_account_new_for_per_account_local_outbox_folder(),
+ to create an on-disk per-account local outbox folder for each
+ transport account.
+ (create_per_account_local_outbox_folders): Create a local outbox folder
+ for each transport account.
+ (modest_tny_account_new_for_local_folders): Do not create an outbox folder
+ for all local folders.
+
+ Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
+ instead of using g_object_get/set() directly. It is clearer.
+
+ (modest_tny_folder_store_get_message_count),
+ (modest_tny_folder_store_get_local_size
+ (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
+ because we now use these with non-acount folder stores.
+
+ (modest_tny_account_get_special_folder),
+ (modest_tny_account_new_from_server_account),
+ (modest_tny_account_new_from_account):
+ (recurse_folders): Adjust to the new outbox system.
+
+ * src/modest-tny-folder.h:
+ * src/modest-tny-folder.c:
+ (modest_tny_folder_is_local_folder),
+ (modest_tny_folder_get_local_folder_type),
+ (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
+
+ * src/widgets/modest-main-window.h:
+ * src/maemo/modest-main-window.c: (create_details_widget),
+ (modest_main_window_set_contents_style): Show details for any folder store,
+ not just accounts.
+
+ (modest_tny_folder_get_rules):
+ Remove the const. C does not support constness enough for this.
+
+ * src/modest-ui-actions.c:
+ update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
+ make all outboxes appear as one, in the usual local-folders tree node.
+
+ (set_active_account_from_tny_account),
+ (modest_ui_actions_on_folder_selection_changed):
+ * src/widgets/modest-folder-view.c: (text_cell_data),
+ (icon_cell_data), (filter_row),
+ (add_account_folders_to_merged_folder),
+ (add_account_folders_to_simple_folder_store), (),
+ (get_cmp_rows_type_pos), (cmp_rows),
+ (modest_folder_view_set_account_id_of_visible_server_account):
+ Adjust to the new outbox system, using generic folder stores and folders
+ in the GtkTreeModel.
+
+2007-05-23 Christian Kellner <ckellner@openismus.com>
+
+ * src/modest-mail-operation.c:
+ (modest_mail_operation_update_account):
+ Use info->max_size instead of unintialized local var [small
+ build fix]. (Added TODO to review that change since I don't
+ know the code)
+
+2007-05-23 Marcus Bauer <marcusb@openismus.com>
+
+ * libmodest-dbus-client/libmodest-dbus-client.c:
+ (libmodest_dbus_client_compose_mail): function added
+ * src/dbus_api/modest-dbus-api.h:
+ * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
+ (on_compose_mail): Implementation of the SendAsMail functionality
+
+2007-05-22 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-account-mgr.c:
+ (modest_account_mgr_add_server_account): Set the secure-connection
+ conf key for transport accounts as well as store accounts. I don't know
+ why the if was there. For instance, this makes sure that we use SSL
+ for the gmail preset from the easysetup wizard.
+
+2007-05-22 Murray Cumming <murrayc@murrayc.com>
+
+ * src/gnome/modest-main-window.c:
+ (on_account_store_connecting_finished), (connect_signals):
+ * src/maemo/modest-main-window.c:
+ (on_account_store_connecting_finished), (connect_signals),
+ (modest_main_window_new):
+ Handle TnyAccountStore::connecting-finished instead of
+ TnyDevice::connection-changed, because we cannot actually perform
+ operations on accounts until TnyAccountStore has itself responded to
+ the TnyDevice::connection-changed signal. This prevents a GError from
+ tinymail.
+ Do not try to update at startup, because we (at least on scratchbox)
+ already do an update at startup when the device goes online.
+ This prevents a GError from tinymail.
+ * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
+ Added TODO about stopping simultaneous operations.
+
+2007-05-21 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-account-mgr.c: (modest_account_mgr_add_account):
+ * src/modest-mail-operation-queue.c:
+ (modest_mail_operation_queue_remove):
+ * src/modest-tny-account-store.c: When GErrors happen, give more clues
+ about where they happened.
+
+2007-05-21 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-ui-actions.c:
+ (modest_ui_actions_on_password_requested): Make sure that the remember
+ output parameter is always TRUE.
+
+2007-05-21 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
+ Show a OK/Cancel dialog if the error is a question, though we still do not
+ know anything more about what we are asking the user.
+ * src/widgets/modest-folder-view.c: (on_drag_data_received):
+ Fix an uninitialized variable (helper). This is a logic error, however.
+
+2007-05-21 Christian Kellner <ckellner@openismus.com>
+
+ * src/modest-search.h:
+ Correct bit shifting in the ModestSearchFlags enum.
+
+2007-05-21 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account.c:
+ (modest_tny_account_new_from_server_account): Do not use the lsub and
+ check-all hard-coded IMAP options when using POP.
+
+2007-05-21 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account.c:
+ (modest_tny_account_new_from_server_account):
+ Use NULL for the secure-auth method for POP when Password auth has been
+ specified by the user, as we already do for IMAP. "auth=Login" causes
+ an error from camel or the server.
+
+2007-05-17 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-account-settings-dialog.c:
+ (create_page_account_details),
+ (modest_account_settings_dialog_set_account_name):
+ * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
+ for the leave-on-server checkbox, rathr than just the checkbox, when
+ the protocol is not POP.
+
+2007-05-17 Murray Cumming <murrayc@murrayc.com>
+
+ * src/widgets/modest-account-view.c:
+ * src/widgets/modest-account-view.h:
+ Added modest_account_view_select_account() which will be useful later
+ to asynchronously re-select the edited account.
+
+2007-05-17 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-account-settings-dialog.c:
+ (modest_account_settings_dialog_set_account_name):
+ Automatically choose the port numbers based on the secure authentication
+ methods, if they have not been chosen before.
+ This fixes projects.maemo.org bug NB#56273 .
+
+2007-05-17 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-main-window-ui.h:
+ * src/modest-ui-actions.c:
+ * src/modest-ui-actions.h:
+ Connect the Tools/SMTP Servers menu item to
+ modest_ui_actions_on_smtp_servers(), which shows the connection-specific
+ SMTP servers dialog, as in the UI specification and saves changes when it
+ is closed. This fixed projects.maemo.org bug NB#56305 .
+
+2007-05-17 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-connection-specific-smtp-window.c:
+ (modest_connection_specific_smtp_window_init):
+ Use gtk_window_set_default_size() to make this window big enough, so
+ we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
+
+2007-05-17 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-connection-specific-smtp-edit-window.h:
+ * src/maemo/modest-connection-specific-smtp-edit-window.c:
+ (modest_connection_specific_smtp_edit_window_init),
+ Do not try to connect to a combobox signal before the combobox exists.
+ This fixes the cras in projects.maemo.org bug NB#56288 .
+ (modest_connection_specific_smtp_edit_window_get_settings):
+ Remove the server_account_name parameter which was being checked for NULL
+ though it was not used.
+
+ * src/maemo/modest-connection-specific-smtp-window.c:
+ (modest_connection_specific_smtp_window_fill_with_connections),
+ (on_button_edit), (modest_connection_specific_smtp_window_init):
+ Correct the number of treemodel columns to prevent a warning.
+ Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
+ libconic does not work.
+
+2007-05-16 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account.c:
+ (modest_tny_account_new_from_server_account):
+ Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
+ SMTP when "None" was chosen by the user. However, with my SMTP server that
+ does not support ANONYMOUS, the emails do not leave the Outbox and I see
+ no error dialog.
+
+2007-05-16 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
+ to explain the memory management issue with the ID in the ModestPair.
+
+ * src/gnome/modest-account-assistant.c: (add_receiving_page),
+ (add_sending_page), (modest_account_assistant_finalize):
+ * src/gnome/modest-gnome-global-settings-dialog.c:
+ (create_updating_page), (create_composing_page):
+ * src/gnome/modest-msg-edit-window.c: (get_transports),
+ (init_window), (modest_msg_edit_window_finalize),
+ (modest_msg_edit_window_get_msg_data):
+ * src/gnome/modest-store-widget.c: (imap_pop_configuration):
+ * src/gnome/modest-transport-widget.c:
+ (modest_transport_widget_finalize), (smtp_configuration):
+ * src/maemo/modest-maemo-global-settings-dialog.c:
+ (create_updating_page), (create_composing_page):
+ * src/maemo/modest-msg-edit-window.c: (get_transports),
+ (init_window), (modest_msg_edit_window_finalize),
+ (modest_msg_edit_window_get_msg_data),
+ (modest_msg_edit_window_free_msg_data):
+ * src/maemo/modest-store-widget.c: (imap_pop_configuration),
+ (modest_store_widget_finalize):
+ * src/maemo/modest-transport-widget.c:
+ (modest_transport_widget_finalize), (smtp_configuration):
+ * src/modest-main.c: (send_mail):
+ * src/widgets/modest-combo-box.h:
+ * src/widgets/modest-global-settings-dialog-priv.h:
+ * src/widgets/modest-global-settings-dialog.c:
+ (modest_global_settings_dialog_finalize):
+ * src/widgets/modest-msg-edit-window.h:
+ Whenever using modest_combo_box_new(), keep the ModestPairList alive
+ as long as the combo box, to prevent use of freed memory for the ID.
+
+2007-05-15 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
+ get_accounts(), to make this clearer. Do not check for the enabled gconf
+ key, because we do not use this for server accounts (at least, not yet).
+ This allows us to send email again.
+
+2007-05-15 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-platform.c:
+ (on_modest_conf_update_interval_changed), (modest_platform_init):
+ Only respond to this particular key change. All these strcmp()s cannot be
+ efficient.
+
+2007-05-15 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-maemo-global-settings-dialog.c:
+ (current_connection): Prevent a crash in scratchbox when
+ ny_maemo_conic_device_get_current_iap_id() returns NULL.
+ * src/maemo/modest-platform.c:
+ (on_modest_conf_update_interval_changed), (modest_platform_init):
+ Get the update interval from gconf and reset it when the gconf key changes.
+
+2007-05-15 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-protocol-info.c:
+ * src/modest-protocol-info.h: Adde enum-specific get functions,
+ instead of using a ModestProtocolType enum parameter.
+
+ * src/gnome/modest-account-assistant.c:
+ * src/gnome/modest-store-widget.c:
+ * src/gnome/modest-store-widget.h:
+ * src/gnome/modest-transport-widget.c:
+ * src/gnome/modest-transport-widget.h:
+ * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
+ * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
+ * src/maemo/easysetup/modest-easysetup-wizard.c:
+ * src/maemo/modest-account-settings-dialog.c:
+ * src/maemo/modest-account-settings-dialog.h:
+ * src/maemo/modest-store-widget.c:
+ * src/maemo/modest-store-widget.h:
+ * src/maemo/modest-transport-widget.c:
+ * src/maemo/modest-transport-widget.h:
+ * src/modest-account-mgr-helpers.c:
+ * src/modest-account-mgr-helpers.h:
+ * src/modest-account-mgr.c:
+ * src/modest-account-mgr.h:
+ * src/modest-tny-account.c:
+ * src/modest-tny-folder.c:
+ * src/widgets/modest-account-view.c:
+ * src/widgets/modest-retrieve-combo-box.c:
+ * src/widgets/modest-retrieve-combo-box.h:
+ * src/widgets/modest-secureauth-combo-box.c:
+ * src/widgets/modest-serversecurity-combo-box.c:
+ * src/widgets/modest-serversecurity-combo-box.h:
+ * tests/check_account-mgr.c:
+ Use the specific functions, and use the re-renamed enum values for GNOME too.
+
+2007-05-15 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-pair.h:
+ * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
+ so we can get the second based on the first.
+
+ * src/maemo/modest-account-settings-dialog.h:
+ * src/maemo/modest-account-settings-dialog.c:
+ Added get_supported_secure_authentication_methods(), though it is mostly
+ commented-out for now until the necessary API is committed to tinymail.
+ (modest_account_settings_dialog_set_account_name),
+ (save_configuration): Request the supported authentication methods from the
+ server, so we can choose a working method.
+
+ * src/modest-tny-account-store.h:
+ * src/modest-tny-account-store.c:
+ (modest_tny_account_store_get_session): Rename from
+ tny_account_store_get_session().
+
+2007-05-14 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-protocol-info.h: Split the ModestProtocol enum
+ into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
+ There was no need to have these unrelated values in one enum.
+
+ * src/: many files: Adapted to changed enum. This makes the code a bit
+ clearer, and the compiler could catch some errors.
+
+2007-05-14 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
+ Show the detailed internal camel error message when an error happens
+ during the configuration, so that our testers can give us more clues.
+ For instance, in projects.maemo.org bug NB#56910 .
+
+2007-05-14 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account.c:
+ (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
+ change tny_account_set_mech() to tny_account_set_secure_auth_mech().
+
+2007-05-14 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
+ * src/maemo/modest-account-settings-dialog.c:
+ (modest_account_settings_dialog_set_account_name),
+ (save_configuration): For the incoming secure authentication checkbox,
+ use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
+ the UI specification. PLAIN does not seem to be supported for most IMAP
+ servers anyway, and I am not sure what it would mean.
+ However, we probably need to discover which of the secure-authentication
+ mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
+ * src/modest-account-mgr-helpers.c:
+ (modest_account_mgr_get_server_account_data):
+
+ * src/modest-tny-account.c:
+ (modest_tny_account_new_from_server_account):
+ Use tny_account_set_mech() to set secure-authentication methods,
+ with some special-casing for IMAP, based on my observations of how
+ evolution behaves.
+
+ * src/modest-account-mgr-helpers.h:
+ * src/modest-account-mgr.c:
+ * src/modest-defs.h: Comment that the URI is only used for local folders.
+
+2007-05-11 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
+ parameter const, just to be neat.
+ * src/modest-text-utils.c: (modest_text_utils_inline):
+ End g_strconcat() with NULL, as its documentation says. This is almost
+ certainly the cause of my crash at startup on the device. Interestingly,
+ valgrind doesn't tell us about these errors.
+
+2007-05-11 Murray Cumming <murrayc@murrayc.com>
+
+ * scripts/build-packages: Added more precise comments about how to use
+ this script, though I still get this error:
+ dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
+ error building tinymail
+
+2007-05-11 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-main-window.c: (on_account_update):
+ Very slight cleanup, hoping to make it simpler to discover what causes
+ a crash here sometimes.
+
+ * src/modest-tny-account.c:
+ (modest_tny_account_new_from_server_account): Set the port. Added
+ comments about the options and a TODO comment because I need to find out
+ how to specify the secure authentication method.
+
+2007-05-11 Marcus Bauer <marcusb@openismus.com>
+
+ * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
+ changed CFlags paths form modest to libmodest
+
+2007-05-10 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-account-mgr-helpers.c:
+ (modest_account_mgr_get_server_account_data),
+ (modest_account_mgr_free_server_account_data):
+ * src/modest-account-mgr-helpers.h:
+ * src/modest-account-mgr.c:
+ (modest_account_mgr_add_server_account):
+ * src/modest-defs.h:
+ * src/modest-tny-account.c:
+ (modest_tny_account_new_from_server_account):
+ Determine the options for tny_camel_account_add_option() here,
+ based on the settings, rather than storing them directly in gconf.
+
+2007-05-10 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
+ Show a more friendly error dialog now that we expect (from the tinymail
+ documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
+
+2007-05-10 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-main-window.c: (on_account_update): Check that
+ account_name is not NULL, to prevent a crash at startup that I am
+ seeing on the N800. I do wonder why it is NULL.
+
+ * src/maemo/easysetup/modest-easysetup-wizard.c:
+ (create_page_user_details):
+ * src/maemo/modest-account-settings-dialog.c:
+ (create_page_user_details), (create_page_outgoing):
+ * src/maemo/modest-connection-specific-smtp-edit-window.c:
+ (modest_connection_specific_smtp_edit_window_init):
+ * src/modest-ui-actions.c:
+ (modest_ui_actions_on_password_requested):
+ Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
+ might do something useful with the on-screen keyboard.
+
2007-05-10 Murray Cumming <murrayc@murrayc.com>
* src/maemo/modest-main-window.c: (on_account_update):
Added modest_ui_actions_on_new_account() as a signal handler for the
New Account menu item. It shows the easysetup wizard.
* po/en_GB.po: Added additional needed logical IDs and translations.
-
-Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
-Apparently ChangeLog is not used for some vague Nokia legal reasons.
-
projects / modest / blobdiff