* src/widgets/modest-window.c:
[modest] / ChangeLog2
index 94ae0c8..fbea86d 100644 (file)
@@ -1,3 +1,334 @@
+2007-07-02  Murray Cumming  <murrayc@murrayc.com>
+
+       * src/modest-tny-account.h:
+       * src/modest-tny-account.c:
+       (modest_tny_account_new_from_server_account),
+       (modest_tny_account_new_from_server_account_name),
+       (modest_tny_account_new_from_account): Added a TnyCamelSession parameter, 
+       because this must now be set before setting the proto. This is usd in 
+       modest_tny_account_new_from_server_account(). It avoids a (maybe harmless) 
+       warning in camel_session_get_service() caused by 
+       tny_camel_transport_account_prepare().
+       
+       * src/modest-tny-account-store.c: (get_server_accounts): Pass the new 
+       session parameter.
+
+2007-06-30  Johannes Schmid <johannes.schmid@openismus.com>
+
+       * src/maemo/modest-connection-specific-smtp-edit-window.c:
+       (on_value_changed),
+       (modest_connection_specific_smtp_edit_window_init):
+       
+       Fixed project.maemo.org bug NB#60479 by using "notify::value" instead 
+       of "changed" for now
+
+2007-06-29  Murray Cumming  <murrayc@murrayc.com>
+
+       * src/modest-tny-account.c: 
+       (modest_tny_account_new_from_server_account):
+       Handle the TnyAccount::"connection-status-changed" signal, which tinymail 
+       now uses to request a connection when it needs one, and which it uses 
+       to tell us that something is wrong with the connection, so we can force 
+       the accounts offline to prevent further problems.
+       
+       * src/modest-defs.h:
+       * src/modest-init.c: (init_default_settings):
+       * src/modest-mail-operation.c:
+       (modest_mail_operation_update_account):
+       * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
+       This should not be necessary anymore. Do not set the conf key that 
+       determined this (it was always TRUE and not set anywhere else).
+       
+       * src/modest-ui-actions.h: Remove unused and unimplemented 
+       modest_ui_actions_on_online_toggle_toggled().
+
+2007-06-29  Murray Cumming  <murrayc@murrayc.com
+
+       * src/maemo/modest-main-window.c: (connect_signals):
+       Don't connect to delete_event twice. Maybe this was harmless.
+
+2007-06-29  Murray Cumming  <murrayc@murrayc.com
+
+       * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
+       * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
+       Debug output to give some more clue when a folder move is not allowed.
+
+2007-06-28  Murray Cumming  <murrayc@murrayc.com
+
+       * src/modest-tny-account.c: (on_modest_file_system_info),
+       (modest_tny_account_get_mmc_account_name):
+       Always call the callback, without checking whether the name has changed.
+       * src/widgets/modest-folder-view.c: (strings_are_equal),
+       (on_model_foreach_set_name), (on_get_mmc_account_name),
+       (text_cell_data): Compare the name here, and use the name from 
+       the account rather than from the 
+       TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong 
+       if the name was changed after the account was added to the model.
+       That's a tinymail bug but not one that I want to fix now.
+
+       This finally fixes projects.maemo.org bug NB#59301.
+
+2007-06-27  Armin Burgmeier  <armin@openismus.com>
+
+       * src/modest-mail-operation.c: Fixed a crash when canceling a mail
+       receive operation.
+
+2007-06-27  Murray Cumming  <murrayc@murrayc.com
+
+       * src/modest-tny-account.h:
+       * src/modest-tny-account.c: 
+       Added modest_tny_account_get_mmc_account_name(), to set the memory 
+       card name asynchronously for the given account and then notify.
+       (modest_tny_account_new_for_local_folders): Use this new function instead 
+       of using hildon_file_system_info_async_new() directly.
+       
+       * src/widgets/modest-folder-view.c: (text_cell_data):
+       Use modest_tny_account_get_mmc_account_name() to get the real name, calling 
+       gtk_tree_model_row_changed() when it is available.
+       
+       This should fix projects.maemo.org bug NB#59301.
+
+2007-06-27  Murray Cumming  <murrayc@murrayc.com
+
+       * src/modest-mail-operation.c: (update_account_thread),
+       (get_msgs_full_thread): Fix typo failures in the revert
+       to fix the build.
+
+2007-06-27  Murray Cumming  <murrayc@murrayc.com
+
+       * src/maemo/modest-maemo-global-settings-dialog.c:
+       (idle_select_default_focus):
+       * src/modest-mail-operation.c: (idle_notify_progress),
+       (idle_notify_progress_once), (set_last_updated_idle),
+       (update_account_thread), (get_msgs_full_thread):
+       * src/widgets/modest-attachment-view.c: (get_size_idle_func):
+       * src/widgets/modest-header-view.c:
+       (idle_notify_headers_count_changed_destroy),
+       (idle_notify_headers_count_changed):
+       Reverted the additions of gdk_threads_enter/leave(), in case this 
+       helps with a startup hang on the device.
+
+2007-06-26  Armin Burgmeier  <armin@openismus.com>
+
+       * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
+       for supported secure authentication methods from server by
+       gtk_dialog_run(), saving CPU time and a potential race condition.
+
+2007-06-26  Armin Burgmeier  <armin@openismus.com>
+
+       * src/maemo/modest-maemo-utils.h: 
+       * src/maemo/modest-maemo-utils.c: Added a
+       ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
+       only error code to tell the calling code when the user canceled the
+       operation.
+
+       * src/maemo/modest-account-settings-dialog.h:
+       * src/maemo/modest-account-settings-dialog.c:
+       * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
+       message if the retrieval of secure authentication methods was canceled
+       by the user. Perform the check before saving anything to configuration
+       to not end up with half-committed configuration changes, do not show
+       a "Saving to configuration failed" note when authentication methods
+       could not be retrieved.
+
+       * src/maemo/modest-main-window.c: Fixed a crash on startup when built
+       with old hildon.
+
+2007-06-26  Murray Cumming  <murrayc@murrayc.com>
+
+       * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
+       Only return the first level of folders under accounts, because the 
+       osso-global-search UI spec doesn't want the rest.
+       This fixed projects.maemo.org bug NB#61811.
+
+2007-06-26  Murray Cumming  <murrayc@murrayc.com>
+
+       * src/modest-tny-account-store.c:
+       * src/modest-tny-account-store.h:
+       Added modest_tny_account_is_memory_card_account().
+       * src/maemo/modest-main-window.c: (create_details_widget):
+       Show the same information items for the memory card as we show for the 
+       local-folders, to fix projects.maemo.org bug NB#59307.
+
+2007-06-26  Murray Cumming  <murrayc@murrayc.com>
+
+       * src/modest-tny-account-store.c: (get_password):
+       Added some checks for NULL to maybe prevent crashes, though I think 
+       it was Philip's last commit that actually prevented the crash here 
+       when creating a first new account.
+       But the new account is still not usable (no messages are shown) 
+       until a restart of the application.
+
+2007-06-26  Murray Cumming  <murrayc@murrayc.com>
+
+       * src/maemo/modest-maemo-global-settings-dialog.c:
+       (idle_select_default_focus):
+       * src/modest-mail-operation.c: (idle_notify_progress),
+       (idle_notify_progress_once), (idle_notify_update_account_queue),
+       (set_last_updated_idle), (update_account_thread),
+       (notify_get_msgs_full), (get_msgs_full_destroyer),
+       (get_msgs_full_thread):
+       * src/widgets/modest-attachment-view.c: (get_size_idle_func):
+       * src/widgets/modest-header-view.c:
+       (idle_notify_headers_count_changed_destroy),
+       (idle_notify_headers_count_changed):
+       Use gdk_threads_enter() and gdk_threads_enter_leave() in 
+       all idle handlers, because some other thread could be blocking 
+       the GDK lock, so that it can do GUI stuff.
+
+2007-06-26  Murray Cumming  <murrayc@murrayc.com>
+
+       * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
+       (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
+       (on_idle_send_receive), (on_idle_open_default_inbox):
+       * src/maemo/modest-msg-edit-window.c:
+       (modest_msg_edit_window_attach_file_noninteractive):
+       Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers, 
+       to prevent a hang. I don't quite understand why these are necessary, 
+       beause we should already be in the main loop. I guess something outside 
+       of the main loop is taking the lock.
+       
+       * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so 
+       we are really using URIs, and use files that are more likely to exist.
+
+2007-06-26  Murray Cumming  <murrayc@murrayc.com>
+
+       * tests/dbus_api/Makefile.am: Fix the build of the tests. This was 
+       necessary because configure.ac now defines different variables.
+
+2007-06-26  Murray Cumming  <murrayc@murrayc.com>
+
+       * libmodest-dbus-client/libmodest-dbus-client.c:
+       * libmodest-dbus-client/libmodest-dbus-client.h:
+       Removed libmodest_dbus_client_send_mail() because it is not used by anything.
+       libmodest_dbus_client_compose_mail() is what things actually use.
+       
+       * src/dbus_api/modest-dbus-api.h:
+       * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
+       * tests/dbus_api/Makefile.am:
+       * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
+       D-Bus method.
+
+2007-06-26  Murray Cumming  <murrayc@murrayc.com>
+
+       * src/modest-init.c: (modest_init_local_folders):
+       For memory-card (or other non local-folders) maildir accounts, 
+       always create an Archive folder, so that there is somewhere to put 
+       messages. This should be less confusing, because the user does not need 
+       to guess that the need to create a folder.
+
+2007-06-25  Johannes Schmid <johannes.schmid@openismus.com>
+
+       * src/maemo/easysetup/modest-wizard-dialog.c: (init):
+       Fixed icon size by using (50, 50) which is the same as defined by
+       newer hildon-libs
+
+2007-06-25  Armin Burgmeier  <armin@openismus.com>
+
+       * src/widgets/modest-window-mgr.c:
+       * src/modest-init.c:
+       * configure.ac: Correctly recognize hildon-notify presence and fixed
+       the build without it being installed.
+
+2007-06-25  Murray Cumming  <murrayc@murrayc.com>
+
+       * libmodest-dbus-client/libmodest-dbus-client.c:
+       (libmodest_dbus_client_search): Fix the build. Sorry.
+       * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
+       (reply_forward_cb): Initialize variables to fix the build.
+       
+       * src/modest-tny-account-store.c:
+       (modest_tny_account_store_get_tny_account_by): Fix the account URI 
+       comparison (a silly typo) so that email search results can be opened 
+       when there are more than one account.
+
+2007-06-25  Murray Cumming  <murrayc@murrayc.com>
+
+       * libmodest-dbus-client/libmodest-dbus-client.c:
+       (libmodest_dbus_client_search),
+       (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes) 
+       instead of 1 second, because the search gets folders and messages from 
+       the server, which can take a long time. When it times out, 
+       osso-global-search will report no results.
+       
+       We need to specify whether we should search only cached information 
+       (maybe with a user preference), and the osso-email-search-plugin
+       API should really be improved to allow that option, and to allow results 
+       to be delivered asynchronously in batches.
+
+2007-06-25  Murray Cumming  <murrayc@murrayc.com>
+
+       * src/maemo/easysetup/modest-wizard-dialog.c: (init):
+       Fix a typo to fix the osso 1.1. build. See the TODO comment though -
+       GTK_ICON_SIZE_DIALOG is probably the wrong size.
+
+2007-06-25  Murray Cumming  <murrayc@murrayc.com>
+
+       * src/modest-search.c: (modest_search_folder): Ignore a seach folder 
+       that is an empty string. D-Bus seems to give us these instead of NULL.
+
+2007-06-25  Johannes Schmid <johannes.schmid@openismus.com>
+
+       * src/dbus_api/modest-dbus-callbacks.c:
+       * src/maemo/easysetup/modest-easysetup-wizard.h:
+       * src/maemo/easysetup/modest-wizard-dialog.c: (init):
+       * src/maemo/modest-connection-specific-smtp-edit-window.c:
+       (modest_connection_specific_smtp_edit_window_init):
+       * src/maemo/modest-maemo-global-settings-dialog.c:
+       (on_range_error):
+       * src/maemo/modest-maemo-utils.c:
+       (modest_maemo_utils_setup_images_filechooser):
+       * src/maemo/modest-main-window.c: (create_details_widget):
+       * src/maemo/modest-msg-edit-window.c:
+       (modest_msg_edit_window_attach_file_noninteractive),
+       (modest_msg_edit_window_color_button_change),
+       (modest_msg_edit_window_set_zoom):
+       * src/modest-mail-operation.c: (update_account_thread):
+       * src/modest-tny-account-store.c:
+       * src/modest-tny-account.c:
+       * src/widgets/modest-global-settings-dialog.c:
+       * src/widgets/modest-window.h:
+       
+       Fixed build on bora!
+
+2007-06-25  Murray Cumming  <murrayc@murrayc.com>
+
+       * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
+       * src/modest-search.c: (modest_search_folder),
+       (modest_search_all_accounts): Actually search only in the specified folder, 
+       doing a simple match on the folder ID.
+       * src/modest-search.h: Added a folder field to the ModestSearch struct, 
+       and added some documentation.
+
+2007-06-22  Armin Burgmeier  <armin@openismus.com>
+
+       * src/maemo/modest-maemo-utils.h:
+       * src/maemo/modest-maemo-utils.c: Added a GError parameter to
+       modest_maemo_utils_get_supported_secure_authentication_methods.
+
+       * src/maemo/easysetup/modest-easysetup-wizard.c:
+       * src/maemo/modest-account-settings-dialog.c: Show correct error if
+       one occured, not just "Server does not support secure authentication".
+
+2007-06-22  Murray Cumming  <murrayc@murrayc.com>
+
+       * src/modest-tny-account-store.c: (get_password):
+       Restored the call to tny_account_set_user() because Philip seems to have 
+       stopped this from crashing (by not using the freed string). It still does 
+       not work, but now we can test it.
+
+2007-06-22  Murray Cumming  <murrayc@murrayc.com>
+
+       * src/maemo/modest-msg-edit-window.c: (init_window):
+       Comment out use of an uninitialzed GtkScrolledWindow variable, 
+       to fix the build and stop a crash. Yet again.
+
+2007-06-22  Murray Cumming  <murrayc@murrayc.com>
+
+       * src/modest-tny-account-store.c: (get_password):
+       Remove the call to tny_account_set_user() because this actually crashes.
+       As mentioned in the last commit, it is known to not work anyway.
+
 2007-06-22  Murray Cumming  <murrayc@murrayc.com>
 
        * src/modest-tny-account-store.c: (get_password):
        Added modest_ui_actions_on_new_account() as a signal handler for the 
        New Account menu item. It shows the easysetup wizard.
        * po/en_GB.po: Added additional needed logical IDs and translations.
-