2007-07-24 Murray Cumming <murrayc@murrayc.com>
[modest] / src / dbus_api / modest-dbus-callbacks.c
index 295c359..2f39ffb 100644 (file)
@@ -53,6 +53,7 @@
 #include <tny-list.h>
 #include <tny-iterator.h>
 #include <tny-simple-list.h>
+#include <tny-merge-folder.h>
 
 typedef struct 
 {
@@ -634,17 +635,17 @@ static gint on_open_message(GArray * arguments, gpointer data, osso_rpc_t * retv
 static gboolean
 on_idle_delete_message (gpointer user_data)
 {
-       TnyList      *headers;
-       TnyFolder    *folder;
-       TnyIterator  *iter; 
-       TnyHeader    *header;
-       TnyHeader    *msg_header;
-       TnyMsg       *msg;
-       TnyAccount   *account;
-       GError       *error;
-       const char   *uri;
-       const char   *uid;
-       gint          res;
+       TnyList      *headers = NULL;
+       TnyFolder    *folder = NULL;
+       TnyIterator  *iter = NULL; 
+       TnyHeader    *header = NULL;
+       TnyHeader    *msg_header = NULL;
+       TnyMsg       *msg = NULL;
+       TnyAccount   *account = NULL;
+       GError       *error = NULL;
+       const char   *uri = NULL;
+       const char   *uid = NULL;
+       gint          res = 0;
 
        uri = (char *) user_data;
 
@@ -680,18 +681,22 @@ on_idle_delete_message (gpointer user_data)
 
        /* g_debug ("Searching header for msg in folder"); */
        while (!tny_iterator_is_done (iter)) {
-               const char *cur_id;
+               const char *cur_id = NULL;
 
                header = TNY_HEADER (tny_iterator_get_current (iter));
-               cur_id = tny_header_get_uid (header);
+               if (header)
+                       cur_id = tny_header_get_uid (header);
                
                if (cur_id && uid && g_str_equal (cur_id, uid)) {
                        /* g_debug ("Found corresponding header from folder"); */
                        break;
                }
 
-               header = NULL;
-               g_object_unref (header);
+               if (header) {
+                       g_object_unref (header);
+                       header = NULL;
+               }
+               
                tny_iterator_next (iter);
        }
 
@@ -706,7 +711,9 @@ on_idle_delete_message (gpointer user_data)
        msg = NULL;
 
        if (header == NULL) {
-               g_object_unref (folder);
+               if (folder)
+                       g_object_unref (folder);
+                       
                return OSSO_ERROR;
        }       
                
@@ -733,11 +740,39 @@ on_idle_delete_message (gpointer user_data)
        
        gdk_threads_leave ();
        
-       g_object_unref (header);
-       g_object_unref (folder);
+       if (header)
+               g_object_unref (header);
+       
+       if (folder) {
+               /* Trick: do a poke status in order to speed up the signaling
+                  of observers.
+                  A delete via the menu does this, in do_headers_action(), 
+                  though I don't know why.
+                */
+               tny_folder_poke_status (folder);
+       
+               g_object_unref (folder);
+       }
+       
+       if (account)
+               g_object_unref (account);
+               
+       /* Refilter the header view explicitly, to make sure that 
+        * deleted emails are really removed from view. 
+        * (They are not really deleted until contact is made with the server, 
+        * so they would appear with a strike-through until then):
+        */
+       ModestHeaderView *header_view = MODEST_HEADER_VIEW(modest_main_window_get_child_widget (
+               MODEST_MAIN_WINDOW(win), MODEST_WIDGET_TYPE_HEADER_VIEW));
+       if (header_view && MODEST_IS_HEADER_VIEW (header_view))
+               modest_header_view_refilter (header_view);
+       
        return res;
 }
 
+
+
+
 static gint
 on_delete_message (GArray *arguments, gpointer data, osso_rpc_t *retval)
 {
@@ -781,6 +816,7 @@ on_idle_send_receive(gpointer user_data)
 
 static gint on_send_receive(GArray * arguments, gpointer data, osso_rpc_t * retval)
 {      
+       printf("DEBUG: modest: %s\n", __FUNCTION__);
     /* Use g_idle to context-switch into the application's thread: */
 
     /* This method has no arguments. */
@@ -885,8 +921,6 @@ gint modest_dbus_req_handler(const gchar * interface, const gchar * method,
                return on_top_application (arguments, data, retval);
        }
        else { 
-               g_debug ("  debug: %s: Unexpected D-Bus method: %s\n", __FUNCTION__, method);
-       
                /* We need to return INVALID here so
                 * libosso will return DBUS_HANDLER_RESULT_NOT_YET_HANDLED,
                 * so that our modest_dbus_req_filter will then be tried instead.
@@ -1186,6 +1220,20 @@ add_single_folder_to_list (TnyFolder *folder, GList** list)
        if (!folder)
                return;
                
+       if (TNY_IS_MERGE_FOLDER (folder)) {
+               /* Ignore these because their IDs ares
+                * a) not always unique or sensible.
+                * b) not human-readable, and currently need a human-readable 
+                *    ID here, because the osso-email-interface API does not allow 
+                *    us to return both an ID and a display name.
+                * 
+                * This is actually the merged outbox folder.
+                * We could hack our D-Bus API to understand "outbox" as the merged outboxes, 
+                * but that seems unwise. murrayc.
+                */
+                return;        
+       }
+               
        /* Add this folder to the list: */
        /*
        const gchar * folder_name = tny_folder_get_name (folder);
@@ -1243,15 +1291,20 @@ add_folders_to_list (TnyFolderStore *folder_store, GList** list)
                 * be generally unsuitable for Modest.
                 */
                TnyFolder *folder = TNY_FOLDER (tny_iterator_get_current (iter));
-               add_single_folder_to_list (TNY_FOLDER (folder), list);
-                
-               #if 0
-               if (TNY_IS_FOLDER_STORE (folder))
-                       add_folders_to_list (TNY_FOLDER_STORE (folder), list);
-               else {
+               if (folder) {
                        add_single_folder_to_list (TNY_FOLDER (folder), list);
+                        
+                       #if 0
+                       if (TNY_IS_FOLDER_STORE (folder))
+                               add_folders_to_list (TNY_FOLDER_STORE (folder), list);
+                       else {
+                               add_single_folder_to_list (TNY_FOLDER (folder), list);
+                       }
+                       #endif
+                       
+                       /* tny_iterator_get_current() gave us a reference. */
+                       g_object_unref (folder);
                }
-               #endif
                
                tny_iterator_next (iter);
        }
@@ -1292,7 +1345,6 @@ on_dbus_method_get_folders (DBusConnection *con, DBusMessage *message)
        g_object_unref (account);
        account = NULL;
        
-       
        /* Also add the folders from the local folders account,
         * because they are (currently) used with all accounts:
         * TODO: This is not working. It seems to get only the Merged Folder (with an ID of "" (not NULL)).
@@ -1337,19 +1389,25 @@ modest_dbus_req_filter (DBusConnection *con,
                        DBusMessage    *message,
                        void           *user_data)
 {
+       printf ("DEBUG: %s\n", __FUNCTION__);
        gboolean handled = FALSE;
 
        if (dbus_message_is_method_call (message,
                                         MODEST_DBUS_IFACE,
                                         MODEST_DBUS_METHOD_SEARCH)) {
+               printf ("  DEBUG1: %s\n", __FUNCTION__);
                on_dbus_method_search (con, message);
                handled = TRUE;                         
        } else if (dbus_message_is_method_call (message,
                                         MODEST_DBUS_IFACE,
                                         MODEST_DBUS_METHOD_GET_FOLDERS)) {
+               printf ("  DEBUG2: %s\n", __FUNCTION__);
                on_dbus_method_get_folders (con, message);
                handled = TRUE;                         
        }
+       else {
+               g_debug ("  debug: %s: Unexpected D-Bus method\n", __FUNCTION__);
+       }
        
        return (handled ? 
                DBUS_HANDLER_RESULT_HANDLED :