Work to fix bug NB#81989:
[modest] / src / dbus_api / modest-dbus-callbacks.c
index 654b3ba..b0c4f04 100644 (file)
@@ -221,7 +221,7 @@ on_idle_mail_to(gpointer user_data)
        }
 
        gdk_threads_enter (); /* CHECKED */
-       modest_ui_actions_compose_msg(NULL, to, cc, bcc, subject, body, NULL);
+       modest_ui_actions_compose_msg(NULL, to, cc, bcc, subject, body, NULL, FALSE);
        gdk_threads_leave (); /* CHECKED */
 
 cleanup:
@@ -271,6 +271,7 @@ on_idle_compose_mail(gpointer user_data)
                g_free(idle_data->attachments);
                idle_data->attachments = tmp;
        }
+
        if (idle_data->attachments != NULL) {
                gchar **list = g_strsplit(idle_data->attachments, ",", 0);
                gint i = 0;
@@ -279,10 +280,25 @@ on_idle_compose_mail(gpointer user_data)
                }
                g_strfreev(list);
        }
+
+       /* If the message has nothing then mark the buffers as not
+          modified. This happens in Maemo for example when opening a
+          new message from Contacts plugin, it sends "" instead of
+          NULLs */
        gdk_threads_enter (); /* CHECKED */
-       modest_ui_actions_compose_msg(NULL, idle_data->to, idle_data->cc,
-                                     idle_data->bcc, idle_data->subject,
-                                     idle_data->body, attachments);
+       if (!strncmp (idle_data->to, "", 1) &&
+           !strncmp (idle_data->to, "", 1) &&
+           !strncmp (idle_data->cc, "", 1) &&
+           !strncmp (idle_data->bcc, "", 1) &&
+           !strncmp (idle_data->subject, "", 1) &&
+           !strncmp (idle_data->body, "", 1) &&
+           attachments == NULL) {
+               modest_ui_actions_compose_msg(NULL, NULL, NULL, NULL, NULL, NULL, NULL, FALSE);
+       } else {
+               modest_ui_actions_compose_msg(NULL, idle_data->to, idle_data->cc,
+                                             idle_data->bcc, idle_data->subject,
+                                             idle_data->body, attachments, TRUE);
+       }
        gdk_threads_leave (); /* CHECKED */
 cleanup:
        g_slist_foreach(attachments, (GFunc)g_free, NULL);
@@ -378,8 +394,39 @@ typedef struct {
        TnyAccount *account;
        gchar *uri;
        gboolean connect;
+       guint animation_timeout;
+       GtkWidget *animation;
 } OpenMsgPerformerInfo;
 
+static gboolean
+on_show_opening_animation (gpointer userdata)
+{
+       OpenMsgPerformerInfo *info = (OpenMsgPerformerInfo *) userdata;
+       info->animation = modest_platform_animation_banner (NULL, NULL, _("mail_me_opening"));
+       info->animation_timeout = 0;
+       
+       return FALSE;
+}
+
+static gboolean
+on_hide_opening_animation (gpointer userdata)
+{
+       OpenMsgPerformerInfo *info = (OpenMsgPerformerInfo *) userdata;
+
+       if (info->animation_timeout>0) {
+               g_source_remove (info->animation_timeout);
+               info->animation_timeout = 0;
+       }
+
+       if (info->animation) {
+               gtk_widget_destroy (info->animation);
+               info->animation = NULL;
+       }
+
+       g_slice_free (OpenMsgPerformerInfo, info);
+       return FALSE;
+}
+
 static void 
 on_open_message_performer (gboolean canceled, 
                           GError *err,
@@ -404,15 +451,26 @@ on_open_message_performer (gboolean canceled,
                goto frees;
        }
 
-       /* Get message */
-       folder = tny_store_account_find_folder (TNY_STORE_ACCOUNT (account), uri, NULL);
-       msg = tny_folder_find_msg (folder, uri, NULL);
-
+       /* Get folder */
+       if (!account) {
+               ModestTnyAccountStore *account_store;
+               ModestTnyLocalFoldersAccount *local_folders_account;
+               
+               account_store = modest_runtime_get_account_store ();
+               local_folders_account = MODEST_TNY_LOCAL_FOLDERS_ACCOUNT (
+                       modest_tny_account_store_get_local_folders_account (account_store));
+               folder = modest_tny_local_folders_account_get_merged_outbox (local_folders_account);
+               g_object_unref (local_folders_account);
+       } else {
+               folder = tny_store_account_find_folder (TNY_STORE_ACCOUNT (account), uri, NULL);
+       }
        if (modest_tny_folder_is_local_folder (folder) &&
            (modest_tny_folder_get_local_or_mmc_folder_type (folder) == TNY_FOLDER_TYPE_DRAFTS)) {
                is_draft = TRUE;
        }
 
+       /* Get message */
+       msg = tny_folder_find_msg (folder, uri, NULL);
        if (!msg) {
                g_idle_add (notify_msg_not_found_in_idle, NULL);
                goto frees;
@@ -435,9 +493,13 @@ on_open_message_performer (gboolean canceled,
 
                /* g_debug ("creating new window for this msg"); */
                modest_window_mgr_register_header (win_mgr, header, NULL);
-               
-               modest_account_name = 
-                       modest_tny_account_get_parent_modest_account_name_for_server_account (account);
+
+               if (account) {
+                       modest_account_name = 
+                               modest_tny_account_get_parent_modest_account_name_for_server_account (account);
+               } else {
+                       modest_account_name = NULL;
+               }
                        
                /* Drafts will be opened in the editor, and others will be opened in the viewer */
                if (is_draft) {
@@ -460,8 +522,9 @@ on_open_message_performer (gboolean canceled,
 
  frees:
        g_free (info->uri);
-       g_object_unref (info->account);
-       g_slice_free (OpenMsgPerformerInfo, info);
+       if (info->account)
+               g_object_unref (info->account);
+       g_idle_add (on_hide_opening_animation, info);
 }
 
 static gboolean
@@ -476,7 +539,7 @@ on_idle_open_message_performer (gpointer user_data)
        /* Lock before the call as we're in an idle handler */
        gdk_threads_enter ();
        if (info->connect) {
-               modest_platform_connect_and_perform (GTK_WINDOW (main_win), info->account, 
+               modest_platform_connect_and_perform (GTK_WINDOW (main_win), TRUE, info->account, 
                                                     on_open_message_performer, info);
        } else {
                on_open_message_performer (FALSE, NULL, GTK_WINDOW (main_win), info->account, info);
@@ -493,28 +556,45 @@ on_open_message (GArray * arguments, gpointer data, osso_rpc_t * retval)
        gchar *uri;
        TnyAccount *account = NULL;
        gint osso_retval;
+       gboolean is_merge;
 
        /* Get the arguments: */
        val = g_array_index(arguments, osso_rpc_t, MODEST_DBUS_OPEN_MESSAGE_ARG_URI);
        uri = g_strdup (val.value.s);
 
+       is_merge = g_str_has_prefix (uri, "merge:");
+
        /* Get the account */
-       account = tny_account_store_find_account (TNY_ACCOUNT_STORE (modest_runtime_get_account_store ()),
-                                                 uri);
+       if (!is_merge)
+               account = tny_account_store_find_account (TNY_ACCOUNT_STORE (modest_runtime_get_account_store ()),
+                                                         uri);
 
        
-       if (account) {
+       if (is_merge || account) {
                OpenMsgPerformerInfo *info;
                TnyFolder *folder = NULL;
 
                info = g_slice_new0 (OpenMsgPerformerInfo);
-               info->account = g_object_ref (account);
+               if (account) 
+                       info->account = g_object_ref (account);
                info->uri = uri;
                info->connect = TRUE;
+               info->animation_timeout = g_timeout_add (1000, on_show_opening_animation, info);
 
                /* Try to get the message, if it's already downloaded
                   we don't need to connect */
-               folder = tny_store_account_find_folder (TNY_STORE_ACCOUNT (account), uri, NULL);
+               if (account) {
+                       folder = tny_store_account_find_folder (TNY_STORE_ACCOUNT (account), uri, NULL);
+               } else {
+                       ModestTnyAccountStore *account_store;
+                       ModestTnyLocalFoldersAccount *local_folders_account;
+
+                       account_store = modest_runtime_get_account_store ();
+                       local_folders_account = MODEST_TNY_LOCAL_FOLDERS_ACCOUNT (
+                               modest_tny_account_store_get_local_folders_account (account_store));
+                       folder = modest_tny_local_folders_account_get_merged_outbox (local_folders_account);
+                       g_object_unref (local_folders_account);
+               }
                if (folder) {
                        TnyMsg *msg = tny_folder_find_msg (folder, uri, NULL);
                        if (msg) {
@@ -535,7 +615,8 @@ on_open_message (GArray * arguments, gpointer data, osso_rpc_t * retval)
                g_idle_add (notify_error_in_dbus_callback, NULL);
        }
 
-       g_object_unref (account);
+       if (account)
+               g_object_unref (account);
        return osso_retval;
 }
 
@@ -713,7 +794,7 @@ on_idle_send_receive(gpointer user_data)
 
        if (auto_update)
                /* Do send receive */
-               modest_ui_actions_do_send_receive_all (main_win);
+               modest_ui_actions_do_send_receive_all (main_win, FALSE, FALSE, FALSE);
        else
                /* Disable auto update */
                modest_platform_set_update_interval (0);
@@ -908,8 +989,19 @@ on_dbus_method_dump_accounts (DBusConnection *con, DBusMessage *message)
 static gint 
 on_send_receive(GArray *arguments, gpointer data, osso_rpc_t * retval)
 {      
-       /* Use g_idle to context-switch into the application's thread: */
-       g_idle_add(on_idle_send_receive, NULL);
+       ModestConnectedVia connect_when;
+
+       connect_when = modest_conf_get_int (modest_runtime_get_conf (), 
+                                           MODEST_CONF_UPDATE_WHEN_CONNECTED_BY, NULL);
+       
+       /* Perform a send and receive if the user selected to connect
+          via any mean or if the current connection method is the
+          same as the one specified by the user */
+       if (connect_when == MODEST_CONNECTED_VIA_ANY ||
+           connect_when == modest_platform_get_current_connection ()) {
+               /* Use g_idle to context-switch into the application's thread: */
+               g_idle_add(on_idle_send_receive, NULL);
+       }
        
        return OSSO_OK;
 }