* Fixes NB#100419, allow character space to be part of the username
[modest] / src / hildon2 / modest-easysetup-wizard-dialog.c
index 58129d6..9f1040f 100644 (file)
@@ -139,6 +139,8 @@ struct _ModestEasysetupWizardDialogPrivate
 
 static void save_to_settings (ModestEasysetupWizardDialog *self);
 static void real_enable_buttons (ModestWizardDialog *dialog, gboolean enable_next);
+static GList* check_for_supported_auth_methods (ModestEasysetupWizardDialog* self);
+static gboolean check_has_supported_auth_methods(ModestEasysetupWizardDialog* self);
 
 static gboolean
 on_delete_event (GtkWidget *widget,
@@ -257,6 +259,41 @@ on_picker_button_value_changed (HildonPickerButton *widget, gpointer user_data)
        invoke_enable_buttons_vfunc(self);
 }
 
+static void
+on_serviceprovider_picker_button_value_changed (HildonPickerButton *widget, gpointer user_data)
+{
+       gchar* default_account_name_start;
+       gchar* default_account_name;
+       ModestEasysetupWizardDialog *self;
+       ModestEasysetupWizardDialogPrivate *priv;
+       ModestProviderPickerIdType provider_id_type;
+
+       self = MODEST_EASYSETUP_WIZARD_DIALOG (user_data);
+       priv = MODEST_EASYSETUP_WIZARD_DIALOG_GET_PRIVATE (self);
+
+       on_picker_button_value_changed (widget, user_data);
+
+       provider_id_type = modest_provider_picker_get_active_id_type (
+               MODEST_PROVIDER_PICKER (priv->account_serviceprovider_picker));
+       if (provider_id_type == MODEST_PROVIDER_PICKER_ID_OTHER) {
+               default_account_name_start = g_strdup (_("mcen_ia_emailsetup_defaultname"));
+       } else {
+               GtkWidget *selector;
+
+               selector = GTK_WIDGET (hildon_picker_button_get_selector (HILDON_PICKER_BUTTON (widget)));
+               default_account_name_start = 
+                       g_strdup (hildon_touch_selector_get_current_text (HILDON_TOUCH_SELECTOR (selector)));
+               
+       }
+       default_account_name = modest_account_mgr_get_unused_account_display_name (
+               priv->account_manager, default_account_name_start);
+       g_free (default_account_name_start);
+       default_account_name_start = NULL;
+
+       hildon_entry_set_text (HILDON_ENTRY (priv->entry_account_title), default_account_name);
+       g_free (default_account_name);
+}
+
 /** This is a convenience function to create a caption containing a mandatory widget.
  * When the widget is edited, the enable_buttons() vfunc will be called.
  */
@@ -265,12 +302,13 @@ create_captioned (ModestEasysetupWizardDialog *self,
                  GtkSizeGroup *title_size_group,
                  GtkSizeGroup *value_size_group,
                  const gchar *value,
+                 gboolean use_markup,
                  GtkWidget *control)
 {
 
        GtkWidget *result;
        result = modest_maemo_utils_create_captioned (title_size_group, value_size_group,
-                                                     value, control);
+                                                     value, use_markup, control);
 
        /* Connect to the appropriate changed signal for the widget, 
         * so we can ask for the prev/next buttons to be enabled/disabled appropriately:
@@ -342,7 +380,7 @@ update_user_email_from_provider (ModestEasysetupWizardDialog *self)
                domain_name = g_strdup (MODEST_EXAMPLE_EMAIL_ADDRESS);
                
        if (priv->entry_user_email)
-               gtk_entry_set_text (GTK_ENTRY (priv->entry_user_email), domain_name);
+               hildon_entry_set_text (HILDON_ENTRY (priv->entry_user_email), domain_name);
                
        g_free (domain_name);
        
@@ -408,7 +446,7 @@ create_page_account_details (ModestEasysetupWizardDialog *self)
                                               _("mcen_fi_serviceprovider"), 
                                               priv->account_serviceprovider_picker);
        g_signal_connect (G_OBJECT (priv->account_serviceprovider_picker), "value-changed",
-                         G_CALLBACK (on_picker_button_value_changed), self);
+                         G_CALLBACK (on_serviceprovider_picker_button_value_changed), self);
        gtk_box_pack_start (GTK_BOX (box), priv->account_serviceprovider_picker, FALSE, FALSE, MODEST_MARGIN_HALF);
        gtk_widget_show (priv->account_serviceprovider_picker);
        
@@ -428,11 +466,11 @@ create_page_account_details (ModestEasysetupWizardDialog *self)
        g_free (default_account_name_start);
        default_account_name_start = NULL;
        
-       gtk_entry_set_text( GTK_ENTRY (priv->entry_account_title), default_account_name);
+       hildon_entry_set_text (HILDON_ENTRY (priv->entry_account_title), default_account_name);
        g_free (default_account_name);
        default_account_name = NULL;
 
-       caption = create_captioned (self, title_sizegroup, value_sizegroup, _("mcen_fi_account_title"), 
+       caption = create_captioned (self, title_sizegroup, value_sizegroup, _("mcen_fi_account_title"), FALSE,
                                    priv->entry_account_title);
        gtk_widget_show (priv->entry_account_title);
        gtk_box_pack_start (GTK_BOX (box), caption, FALSE, FALSE, MODEST_MARGIN_HALF);
@@ -501,7 +539,7 @@ create_page_user_details (ModestEasysetupWizardDialog *self)
        modest_validating_entry_set_max_func (MODEST_VALIDATING_ENTRY (priv->entry_user_name), 
                                              on_entry_max, self);
        GtkWidget *caption = create_captioned (self, title_sizegroup, value_sizegroup,
-                                              _("mcen_li_emailsetup_name"), priv->entry_user_name);
+                                              _("mcen_li_emailsetup_name"), FALSE, priv->entry_user_name);
        g_signal_connect(G_OBJECT(priv->entry_user_name), "changed", 
                         G_CALLBACK(on_easysetup_changed), self);
        gtk_widget_show (priv->entry_user_name);
@@ -524,7 +562,7 @@ create_page_user_details (ModestEasysetupWizardDialog *self)
        /* Auto-capitalization is the default, so let's turn it off: */
        hildon_gtk_entry_set_input_mode (GTK_ENTRY (priv->entry_user_username), 
                                         HILDON_GTK_INPUT_MODE_FULL);
-       caption = create_captioned (self, title_sizegroup, value_sizegroup, _("mail_fi_username"), 
+       caption = create_captioned (self, title_sizegroup, value_sizegroup, _("mail_fi_username"), FALSE,
                                    priv->entry_user_username);
        gtk_widget_show (priv->entry_user_username);
        gtk_box_pack_start (GTK_BOX (box), caption, FALSE, FALSE, MODEST_MARGIN_HALF);
@@ -534,8 +572,6 @@ create_page_user_details (ModestEasysetupWizardDialog *self)
        
        /* Prevent the use of some characters in the username, 
         * as required by our UI specification: */
-       modest_validating_entry_set_unallowed_characters_whitespace (
-               MODEST_VALIDATING_ENTRY (priv->entry_user_username));
        modest_validating_entry_set_func(MODEST_VALIDATING_ENTRY(priv->entry_user_username),
                modest_utils_on_entry_invalid_character, self);
        
@@ -546,14 +582,14 @@ create_page_user_details (ModestEasysetupWizardDialog *self)
                                              on_entry_max, self);
        
        /* The password widgets: */     
-       priv->entry_user_password = gtk_entry_new ();
+       priv->entry_user_password = hildon_entry_new (MODEST_EDITABLE_SIZE);
        /* Auto-capitalization is the default, so let's turn it off: */
        hildon_gtk_entry_set_input_mode (GTK_ENTRY (priv->entry_user_password), 
                                         HILDON_GTK_INPUT_MODE_FULL | HILDON_GTK_INPUT_MODE_INVISIBLE);
        gtk_entry_set_visibility (GTK_ENTRY (priv->entry_user_password), FALSE);
        /* gtk_entry_set_invisible_char (GTK_ENTRY (priv->entry_user_password), '*'); */
        caption = create_captioned (self, title_sizegroup, value_sizegroup,
-                                   _("mail_fi_password"), priv->entry_user_password);
+                                   _("mail_fi_password"), FALSE, priv->entry_user_password);
        g_signal_connect(G_OBJECT(priv->entry_user_password), "changed", 
                         G_CALLBACK(on_easysetup_changed), self);
        gtk_widget_show (priv->entry_user_password);
@@ -565,7 +601,7 @@ create_page_user_details (ModestEasysetupWizardDialog *self)
        /* Auto-capitalization is the default, so let's turn it off: */
        hildon_gtk_entry_set_input_mode (GTK_ENTRY (priv->entry_user_email), HILDON_GTK_INPUT_MODE_FULL);
        caption = create_captioned (self, title_sizegroup, value_sizegroup,
-                                   _("mcen_li_emailsetup_email_address"), priv->entry_user_email);
+                                   _("mcen_li_emailsetup_email_address"), FALSE, priv->entry_user_email);
        update_user_email_from_provider (self);
        gtk_widget_show (priv->entry_user_email);
        gtk_box_pack_start (GTK_BOX (box), caption, FALSE, FALSE, MODEST_MARGIN_HALF);
@@ -626,18 +662,25 @@ update_incoming_server_title (ModestEasysetupWizardDialog *self)
 
        priv = MODEST_EASYSETUP_WIZARD_DIALOG_GET_PRIVATE(self);
        protocol_registry = modest_runtime_get_protocol_registry ();
-       
+
        protocol_type = modest_servertype_picker_get_active_servertype (
                MODEST_SERVERTYPE_PICKER (priv->incoming_servertype_picker));
 
        /* This could happen when the combo box has still no active iter */
        if (protocol_type != MODEST_PROTOCOL_REGISTRY_TYPE_INVALID) {
                gchar* incomingserver_title;
-               const gchar *protocol_display_name; 
+               const gchar *protocol_display_name;
+               ModestProtocol *protocol;
+
+               protocol = modest_protocol_registry_get_protocol_by_type (protocol_registry, 
+                                                                         protocol_type);
+               protocol_display_name = modest_protocol_get_display_name (protocol);
+
+               incomingserver_title = g_strconcat (_("mcen_li_emailsetup_servertype"), "\n<small>(",
+                                                   protocol_display_name, ")</small>", NULL);
+
+               modest_maemo_utils_captioned_set_label (priv->caption_incoming, incomingserver_title, TRUE);
 
-               protocol_display_name = modest_protocol_get_display_name (modest_protocol_registry_get_protocol_by_type (protocol_registry, protocol_type));
-               
-               incomingserver_title = g_strdup_printf(_("mcen_li_emailsetup_servertype"), protocol_display_name);
                g_free(incomingserver_title);
        }
 }
@@ -739,7 +782,7 @@ create_page_custom_incoming (ModestEasysetupWizardDialog *self)
        gtk_box_pack_start (GTK_BOX (box), priv->incoming_servertype_picker, FALSE, FALSE, MODEST_MARGIN_HALF);
        gtk_widget_show (priv->incoming_servertype_picker);
        
-       priv->entry_incomingserver = gtk_entry_new ();
+       priv->entry_incomingserver = hildon_entry_new (MODEST_EDITABLE_SIZE);
        g_signal_connect(G_OBJECT(priv->entry_incomingserver), "changed", G_CALLBACK(on_easysetup_changed), self);
        /* Auto-capitalization is the default, so let's turn it off: */
        hildon_gtk_entry_set_input_mode (GTK_ENTRY (priv->entry_incomingserver), HILDON_GTK_INPUT_MODE_FULL);
@@ -747,10 +790,9 @@ create_page_custom_incoming (ModestEasysetupWizardDialog *self)
 
        /* The caption title will be updated in update_incoming_server_title().
         * so this default text will never be seen: */
-       /* (Note: Changing the title seems pointless. murrayc) */
        priv->caption_incoming = create_captioned (self, title_sizegroup, value_sizegroup,
-                                                  "Incoming Server", 
-                                                  priv->entry_incomingserver);
+                                                  "This will be removed", 
+                                                  FALSE, priv->entry_incomingserver);
        update_incoming_server_title (self);
        gtk_widget_show (priv->entry_incomingserver);
        gtk_box_pack_start (GTK_BOX (box), priv->caption_incoming, FALSE, FALSE, MODEST_MARGIN_HALF);
@@ -846,6 +888,7 @@ static GtkWidget*
 create_page_custom_outgoing (ModestEasysetupWizardDialog *self)
 {
        ModestEasysetupWizardDialogPrivate *priv;
+       gchar *smtp_caption_label;
        GtkWidget *box = gtk_vbox_new (FALSE, MODEST_MARGIN_NONE);
        
        /* Create a size group to be used by all captions.
@@ -856,13 +899,15 @@ create_page_custom_outgoing (ModestEasysetupWizardDialog *self)
         
        /* The outgoing server widgets: */
        priv = MODEST_EASYSETUP_WIZARD_DIALOG_GET_PRIVATE (self);
-       priv->entry_outgoingserver = gtk_entry_new ();
+       priv->entry_outgoingserver = hildon_entry_new (MODEST_EDITABLE_SIZE);
        g_signal_connect (G_OBJECT (priv->entry_outgoingserver), "changed",
                   G_CALLBACK (on_easysetup_changed), self);
        /* Auto-capitalization is the default, so let's turn it off: */
        hildon_gtk_entry_set_input_mode (GTK_ENTRY (priv->entry_outgoingserver), HILDON_GTK_INPUT_MODE_FULL);
+       smtp_caption_label = g_strconcat (_("mcen_li_emailsetup_smtp"), "\n<small>(SMTP)</small>", NULL);
        GtkWidget *caption = create_captioned (self, title_sizegroup, value_sizegroup,
-                                              _("mcen_li_emailsetup_smtp"), priv->entry_outgoingserver);
+                                              smtp_caption_label, TRUE, priv->entry_outgoingserver);
+       g_free (smtp_caption_label);
        gtk_widget_show (priv->entry_outgoingserver);
        gtk_box_pack_start (GTK_BOX (box), caption, FALSE, FALSE, MODEST_MARGIN_HALF);
        gtk_widget_show (caption);
@@ -1527,13 +1572,13 @@ set_default_custom_servernames (ModestEasysetupWizardDialog *self)
 
                /* This could happen when the combo box has still no active iter */
                if (protocol_type != MODEST_PROTOCOL_REGISTRY_TYPE_INVALID) {
-                       const gchar* email_address = gtk_entry_get_text (GTK_ENTRY(priv->entry_user_email));    
+                       const gchar* email_address = hildon_entry_get_text (HILDON_ENTRY(priv->entry_user_email));      
                        gchar* servername = util_get_default_servername_from_email_address (email_address, 
                                                                                            protocol_type);
 
                        /* Do not set the INCOMING_CHANGED flag because of this edit */
                        g_signal_handlers_block_by_func (G_OBJECT (priv->entry_incomingserver), G_CALLBACK (on_entry_incoming_servername_changed), self);
-                       gtk_entry_set_text (GTK_ENTRY (priv->entry_incomingserver), servername);
+                       hildon_entry_set_text (HILDON_ENTRY (priv->entry_incomingserver), servername);
                        g_signal_handlers_unblock_by_func (G_OBJECT (priv->entry_incomingserver), G_CALLBACK (on_entry_incoming_servername_changed), self);
                        
                        g_free (servername);
@@ -1548,13 +1593,13 @@ set_default_custom_servernames (ModestEasysetupWizardDialog *self)
                
        if (priv->entry_user_email
            && ((priv->server_changes & MODEST_EASYSETUP_WIZARD_DIALOG_OUTGOING_CHANGED) == 0)) {
-               const gchar* email_address = gtk_entry_get_text (GTK_ENTRY(priv->entry_user_email));
+               const gchar* email_address = hildon_entry_get_text (HILDON_ENTRY(priv->entry_user_email));
                
                gchar* servername = util_get_default_servername_from_email_address (email_address, MODEST_PROTOCOLS_TRANSPORT_SMTP);
 
                /* Do not set the OUTGOING_CHANGED flag because of this edit */
                g_signal_handlers_block_by_func (G_OBJECT (priv->entry_outgoingserver), G_CALLBACK (on_entry_outgoing_servername_changed), self);
-               gtk_entry_set_text (GTK_ENTRY (priv->entry_outgoingserver), servername);
+               hildon_entry_set_text (HILDON_ENTRY (priv->entry_outgoingserver), servername);
                g_signal_handlers_unblock_by_func (G_OBJECT (priv->entry_outgoingserver), G_CALLBACK (on_entry_outgoing_servername_changed), self);
 
                g_free (servername);
@@ -1568,7 +1613,7 @@ get_entered_account_title (ModestEasysetupWizardDialog *self)
        const gchar* account_title;
 
        priv = MODEST_EASYSETUP_WIZARD_DIALOG_GET_PRIVATE(self);
-       account_title = gtk_entry_get_text (GTK_ENTRY (priv->entry_account_title));
+       account_title = hildon_entry_get_text (HILDON_ENTRY (priv->entry_account_title));
 
        if (!account_title || (g_utf8_strlen (account_title, -1) == 0)) {
                return NULL;
@@ -1630,7 +1675,7 @@ on_before_next (ModestWizardDialog *dialog, GtkWidget *current_page, GtkWidget *
 
        } else if (current_page == priv->page_user_details) {
                /* Check that the email address is valud: */
-               const gchar* email_address = gtk_entry_get_text (GTK_ENTRY (priv->entry_user_email));
+               const gchar* email_address = hildon_entry_get_text (HILDON_ENTRY (priv->entry_user_email));
                if ((!email_address) || (g_utf8_strlen (email_address, -1) == 0))
                        return FALSE;
                        
@@ -1652,9 +1697,9 @@ on_before_next (ModestWizardDialog *dialog, GtkWidget *current_page, GtkWidget *
                set_default_custom_servernames (self);
 
                /* Check if the server supports secure authentication */
-/*             if (modest_security_options_view_auth_check (security_options)) */
-/*                     if (!check_has_supported_auth_methods (self)) */
-/*                             return FALSE; */
+               if (modest_security_options_view_auth_check (MODEST_SECURITY_OPTIONS_VIEW (priv->incoming_security)))
+                       if (!check_has_supported_auth_methods (self))
+                               return FALSE;
                gtk_widget_show (priv->outgoing_security);
        }
        
@@ -1686,7 +1731,7 @@ static gboolean entry_is_empty (GtkWidget *entry)
        if (!entry)
                return FALSE;
                
-       const gchar* text = gtk_entry_get_text (GTK_ENTRY (entry));
+       const gchar* text = hildon_entry_get_text (HILDON_ENTRY (entry));
        if ((!text) || (g_utf8_strlen (text, -1) == 0))
                return TRUE;
        else {
@@ -1860,8 +1905,8 @@ save_to_settings (ModestEasysetupWizardDialog *self)
        }
 
        /* username and password (for both incoming and outgoing): */
-       username = gtk_entry_get_text (GTK_ENTRY (priv->entry_user_username));
-       password = gtk_entry_get_text (GTK_ENTRY (priv->entry_user_password));
+       username = hildon_entry_get_text (HILDON_ENTRY (priv->entry_user_username));
+       password = hildon_entry_get_text (HILDON_ENTRY (priv->entry_user_password));
 
        store_settings = modest_account_settings_get_store_settings (priv->settings);
        transport_settings = modest_account_settings_get_transport_settings (priv->settings);
@@ -1920,7 +1965,7 @@ save_to_settings (ModestEasysetupWizardDialog *self)
                        modest_server_account_settings_set_port (store_settings, store_port);
        } else {
                /* Use custom pages because no preset was specified: */
-               store_hostname = g_strdup (gtk_entry_get_text (GTK_ENTRY (priv->entry_incomingserver) ));               
+               store_hostname = g_strdup (hildon_entry_get_text (HILDON_ENTRY (priv->entry_incomingserver) ));         
                store_protocol = modest_servertype_picker_get_active_servertype (
                        MODEST_SERVERTYPE_PICKER (priv->incoming_servertype_picker));           
 
@@ -1991,7 +2036,7 @@ save_to_settings (ModestEasysetupWizardDialog *self)
 
                registry = modest_runtime_get_protocol_registry ();
                /* Use custom pages because no preset was specified: */
-               transport_hostname = g_strdup (gtk_entry_get_text (GTK_ENTRY (priv->entry_outgoingserver) ));
+               transport_hostname = g_strdup (hildon_entry_get_text (HILDON_ENTRY (priv->entry_outgoingserver) ));
 
                store_proto = modest_protocol_registry_get_protocol_by_type (registry, 
                                                                             store_protocol);
@@ -2018,8 +2063,8 @@ save_to_settings (ModestEasysetupWizardDialog *self)
        g_object_unref (transport_settings);
        g_free (transport_hostname);
        
-       fullname = gtk_entry_get_text (GTK_ENTRY (priv->entry_user_name));
-       email_address = gtk_entry_get_text (GTK_ENTRY (priv->entry_user_email));
+       fullname = hildon_entry_get_text (HILDON_ENTRY (priv->entry_user_name));
+       email_address = hildon_entry_get_text (HILDON_ENTRY (priv->entry_user_email));
        modest_account_settings_set_fullname (priv->settings, fullname);
        modest_account_settings_set_email_address (priv->settings, email_address);
        /* we don't set retrieve type to preserve advanced settings if
@@ -2036,3 +2081,72 @@ save_to_settings (ModestEasysetupWizardDialog *self)
        g_free (provider_id);
 }
 
+static GList*
+check_for_supported_auth_methods (ModestEasysetupWizardDialog* self)
+{
+       GError *error = NULL;
+       ModestProtocolType protocol_type;
+       const gchar* hostname;
+       const gchar* username;
+       ModestProtocolType security_protocol_incoming_type;
+       ModestProtocolRegistry *registry;
+       int port_num;
+       GList *list_auth_methods;
+       ModestEasysetupWizardDialogPrivate *priv;
+       
+       priv = MODEST_EASYSETUP_WIZARD_DIALOG_GET_PRIVATE (self);
+       registry = modest_runtime_get_protocol_registry ();
+       protocol_type = modest_servertype_picker_get_active_servertype (
+               MODEST_SERVERTYPE_PICKER (priv->incoming_servertype_picker));
+       hostname = gtk_entry_get_text(GTK_ENTRY(priv->entry_incomingserver));
+       username = gtk_entry_get_text(GTK_ENTRY(priv->entry_user_username));
+       security_protocol_incoming_type = modest_security_options_view_get_connection_protocol
+               (MODEST_SECURITY_OPTIONS_VIEW (priv->incoming_security));
+       port_num = get_port_from_protocol(protocol_type, FALSE);
+       list_auth_methods = modest_utils_get_supported_secure_authentication_methods (protocol_type, hostname, port_num,
+                                                                                     username, GTK_WINDOW (self), &error);
+
+       if (list_auth_methods) {
+               /* TODO: Select the correct method */
+               GList* list = NULL;
+               GList* method;
+               for (method = list_auth_methods; method != NULL; method = g_list_next(method)) {
+                       ModestProtocolType auth_protocol_type = (ModestProtocolType) (GPOINTER_TO_INT(method->data));
+                       if (modest_protocol_registry_protocol_type_has_tag (registry, auth_protocol_type,
+                                                                           MODEST_PROTOCOL_REGISTRY_SECURE_PROTOCOLS)) {
+                               list = g_list_append(list, GINT_TO_POINTER(auth_protocol_type));
+                       }
+               }
+
+               g_list_free(list_auth_methods);
+
+               if (list)
+                       return list;
+       }
+
+       if(error == NULL || error->domain != modest_utils_get_supported_secure_authentication_error_quark() ||
+                       error->code != MODEST_UTILS_GET_SUPPORTED_SECURE_AUTHENTICATION_ERROR_CANCELED)
+       {
+               modest_platform_information_banner (GTK_WIDGET(self), NULL,
+                                                   _("mcen_ib_unableto_discover_auth_methods"));
+       }
+
+       if(error != NULL)
+               g_error_free(error);
+
+       return NULL;
+}
+
+static gboolean 
+check_has_supported_auth_methods(ModestEasysetupWizardDialog* self)
+{
+       GList* methods = check_for_supported_auth_methods(self);
+       if (!methods)
+       {
+               return FALSE;
+       }
+
+       g_list_free(methods);
+       return TRUE;
+}
+