Fixes NB#130519, country selector picker is too slow
[modest] / src / hildon2 / modest-easysetup-wizard-dialog.c
index 58c1930..c68b833 100644 (file)
@@ -72,7 +72,7 @@ G_DEFINE_TYPE (ModestEasysetupWizardDialog, modest_easysetup_wizard_dialog, MODE
                                                    MODEST_TYPE_EASYSETUP_WIZARD_DIALOG, \
                                                    ModestEasysetupWizardDialogPrivate))
 
-#define LABELS_WIDTH 480
+#define LABELS_WIDTH 520
 #define DIALOG_WIDTH LABELS_WIDTH + MODEST_MARGIN_DOUBLE
 
 typedef struct _ModestEasysetupWizardDialogPrivate ModestEasysetupWizardDialogPrivate;
@@ -104,10 +104,8 @@ struct _ModestEasysetupWizardDialogPrivate
 
        /* notebook pages: */
        GtkWidget *page_welcome;
-       GtkWidget *check_support_progress;
        gboolean  check_support_done;
        guint check_support_show_progress_id;
-       guint check_support_progress_pulse_id;
        gint pending_check_support;
        gboolean destroyed;
 
@@ -156,7 +154,6 @@ static void check_support_callback (ModestAccountProtocol *protocol,
                                    gpointer userdata);
 static void check_support_of_protocols (ModestEasysetupWizardDialog *self);
 static gboolean check_support_show_progress (gpointer userdata);
-static gboolean check_support_progress_pulse (gpointer userdata);
 
 static gboolean
 on_delete_event (GtkWidget *widget,
@@ -186,11 +183,6 @@ modest_easysetup_wizard_dialog_dispose (GObject *object)
                priv->check_support_show_progress_id = 0;
        }
 
-       if (priv->check_support_progress_pulse_id > 0) {
-               g_source_remove (priv->check_support_progress_pulse_id);
-               priv->check_support_progress_pulse_id = 0;
-       }
-
        if (G_OBJECT_CLASS (modest_easysetup_wizard_dialog_parent_class)->dispose)
                G_OBJECT_CLASS (modest_easysetup_wizard_dialog_parent_class)->dispose (object);
 }
@@ -369,8 +361,9 @@ create_captioned (ModestEasysetupWizardDialog *self,
 {
 
        GtkWidget *result;
-       result = modest_maemo_utils_create_captioned (title_size_group, value_size_group,
-                                                     value, use_markup, control);
+       result = modest_maemo_utils_create_captioned_with_size_type (title_size_group, value_size_group,
+                                                                    value, use_markup, control,
+                                                                    MODEST_EDITABLE_SIZE);
 
        /* Connect to the appropriate changed signal for the widget,
         * so we can ask for the prev/next buttons to be enabled/disabled appropriately:
@@ -399,7 +392,6 @@ create_page_welcome (ModestEasysetupWizardDialog *self)
        priv = MODEST_EASYSETUP_WIZARD_DIALOG_GET_PRIVATE (self);
        box = gtk_vbox_new (FALSE, MODEST_MARGIN_NONE);
        label = gtk_label_new(_("mcen_ia_emailsetup_intro"));
-       priv->check_support_progress = gtk_progress_bar_new ();
        align = gtk_alignment_new (0.0, 0.0, 1.0, 1.0);
        gtk_alignment_set_padding (GTK_ALIGNMENT (align), 0, 0, MODEST_MARGIN_DOUBLE, 0);
        gtk_widget_set_size_request (label, LABELS_WIDTH, -1);
@@ -408,7 +400,6 @@ create_page_welcome (ModestEasysetupWizardDialog *self)
        gtk_misc_set_alignment (GTK_MISC (label), 0.0, 0.0);
        gtk_misc_set_padding (GTK_MISC (label), MODEST_MARGIN_DOUBLE, MODEST_MARGIN_DOUBLE);
        gtk_box_pack_start (GTK_BOX (box), label, TRUE, TRUE, 0);
-       gtk_box_pack_end (GTK_BOX (box), priv->check_support_progress, FALSE, FALSE, 0);
        gtk_container_add (GTK_CONTAINER (align), box);
        gtk_widget_show (label);
        gtk_widget_show (GTK_WIDGET (box));
@@ -416,7 +407,7 @@ create_page_welcome (ModestEasysetupWizardDialog *self)
 }
 
 static void
-on_account_country_selector_changed (HildonTouchSelector *widget, gint column, gpointer user_data)
+on_account_country_selector_changed (HildonTouchSelector *widget, gpointer user_data)
 {
        ModestEasysetupWizardDialog *self = MODEST_EASYSETUP_WIZARD_DIALOG (user_data);
        g_assert(self);
@@ -607,12 +598,19 @@ on_user_username_changed(GtkWidget* widget, ModestEasysetupWizardDialog *self)
                MODEST_PROVIDER_PICKER (priv->account_serviceprovider_picker));
 
        if (provider_id) {
+               const gchar *current_username;
                gchar *email_address;
                gchar *domain_name = modest_presets_get_domain (priv->presets, provider_id);
 
-               email_address = g_strdup_printf ("%s@%s",
-                                                hildon_entry_get_text (HILDON_ENTRY (priv->entry_user_username)),
-                                                domain_name);
+               current_username = hildon_entry_get_text (HILDON_ENTRY (priv->entry_user_username));
+
+               if (current_username && strstr (current_username, "@")) {
+                       email_address = g_strdup (current_username);
+               } else {
+                       email_address = g_strdup_printf ("%s@%s",
+                                                        current_username,
+                                                        domain_name);
+               }
 
                /* Update the email address */
                hildon_entry_set_text (HILDON_ENTRY (priv->entry_user_email), email_address);
@@ -1161,28 +1159,27 @@ on_button_edit_advanced_settings (GtkButton *button, gpointer user_data)
 static GtkWidget*
 create_page_complete_custom (ModestEasysetupWizardDialog *self)
 {
+       gchar *complete_string;
        GtkWidget *align;
-       GtkWidget *box = gtk_vbox_new (FALSE, MODEST_MARGIN_DEFAULT);
-       GtkWidget *label = gtk_label_new(_("mcen_ia_emailsetup_setup_complete"));
-       GtkWidget *button_edit = gtk_button_new_with_label (_("mcen_fi_advanced_settings"));
-       hildon_gtk_widget_set_theme_size (button_edit, HILDON_SIZE_FINGER_HEIGHT | HILDON_SIZE_AUTO_WIDTH);
+       GtkWidget *box;
+       GtkWidget *label;
+       GtkWidget *button_edit;
+
+       box = gtk_vbox_new (FALSE, MODEST_MARGIN_DEFAULT);
+       complete_string = g_strconcat (_("mcen_ia_emailsetup_setup_complete"), " ",
+                                      _("mcen_ia_customsetup_complete"), NULL);
+       label = gtk_label_new(complete_string);
+       g_free (complete_string);
        gtk_misc_set_alignment (GTK_MISC (label), 0, 0.5);
        gtk_widget_set_size_request (label, LABELS_WIDTH, -1);
        gtk_label_set_line_wrap (GTK_LABEL (label), TRUE);
        gtk_misc_set_padding (GTK_MISC (label), MODEST_MARGIN_DOUBLE, MODEST_MARGIN_DOUBLE);
        gtk_misc_set_alignment (GTK_MISC (label), 0.0, 0.0);
-       gtk_box_pack_start (GTK_BOX (box), label, FALSE, FALSE, 0);
-       gtk_widget_show (label);
-
-       label = gtk_label_new (_("mcen_ia_customsetup_complete"));
-       gtk_misc_set_alignment (GTK_MISC (label), 0.0, 0.0);
-       gtk_widget_set_size_request (label, LABELS_WIDTH, -1);
-       gtk_label_set_line_wrap (GTK_LABEL (label), TRUE);
-       gtk_misc_set_padding (GTK_MISC (label), MODEST_MARGIN_DOUBLE, MODEST_MARGIN_DOUBLE);
-       gtk_misc_set_alignment (GTK_MISC (label), 0.0, 0.5);
        gtk_box_pack_start (GTK_BOX (box), label, TRUE, TRUE, 0);
        gtk_widget_show (label);
 
+       button_edit = gtk_button_new_with_label (_("mcen_fi_advanced_settings"));
+       hildon_gtk_widget_set_theme_size (button_edit, HILDON_SIZE_FINGER_HEIGHT | HILDON_SIZE_AUTO_WIDTH);
        gtk_widget_show (button_edit);
        gtk_box_pack_start (GTK_BOX (box), button_edit, FALSE, FALSE, 0);
 
@@ -1223,12 +1220,17 @@ on_response_before (ModestWizardDialog *wizard_dialog,
                /* This is mostly copied from
                 * src/maemo/modest-account-settings-dialog.c */
                if (priv->dirty) {
-                       GtkDialog *dialog = GTK_DIALOG (hildon_note_new_confirmation (GTK_WINDOW (self),
-                               _("imum_nc_wizard_confirm_lose_changes")));
-                       /* TODO: These button names will be ambiguous, and not
-                        * specified in the UI specification. */
+                       gint dialog_response;
+                       GtkWidget *dialog;
+
+                       dialog = hildon_note_new_confirmation ((GtkWindow *) self,
+                                                              _("imum_nc_wizard_confirm_lose_changes"));
+
+                       modest_window_mgr_set_modal (modest_runtime_get_window_mgr (),
+                                                    (GtkWindow *) dialog,
+                                                    (GtkWindow *) wizard_dialog);
 
-                       const gint dialog_response = gtk_dialog_run (dialog);
+                       dialog_response = gtk_dialog_run ((GtkDialog *) dialog);
                        gtk_widget_destroy (GTK_WIDGET (dialog));
 
                        if (dialog_response != GTK_RESPONSE_OK) {
@@ -1251,9 +1253,8 @@ fill_providers (ModestEasysetupWizardDialog *self)
                modest_country_picker_load_data(
                        MODEST_COUNTRY_PICKER (priv->account_country_picker));
                /* connect to country picker's changed signal, so we can fill the provider picker: */
-               g_signal_connect (G_OBJECT (hildon_picker_button_get_selector
-                                           (HILDON_PICKER_BUTTON (priv->account_country_picker))),
-                                 "changed",
+               g_signal_connect ((GObject *) priv->account_country_picker,
+                                 "value-changed",
                                  G_CALLBACK (on_account_country_selector_changed), self);
 
                modest_country_picker_set_active_country_locale (
@@ -1347,11 +1348,15 @@ modest_easysetup_wizard_dialog_append_page (GtkNotebook *notebook,
                                            const gchar *label)
 {
        gint index;
+
        /* Append page and set attributes */
        index = gtk_notebook_append_page (notebook, page, gtk_label_new (label));
        gtk_container_child_set (GTK_CONTAINER (notebook), page,
                                 "tab-expand", TRUE, "tab-fill", TRUE,
                                 NULL);
+
+       /* Give focus to page and show it */
+       gtk_container_set_focus_child (GTK_CONTAINER (notebook), page);
        gtk_widget_show (page);
 }
 
@@ -1419,7 +1424,6 @@ modest_easysetup_wizard_dialog_init (ModestEasysetupWizardDialog *self)
        /* Initialize fields */
        priv->check_support_done = FALSE;
        priv->check_support_show_progress_id = 0;
-       priv->check_support_progress_pulse_id = 0;
        priv->pending_check_support = 0;
        priv->destroyed = FALSE;
        priv->page_welcome = create_page_welcome (self);
@@ -2126,8 +2130,8 @@ save_to_settings (ModestEasysetupWizardDialog *self)
                                                                      priv->settings);
                        g_list_free (wizard_pages);
                } else {
-                       g_warning ("The selected protocol is a plugin protocol "//
-                                  "but it's not a ModestAccountProtocol");
+                       g_debug ("The selected protocol is a plugin protocol "//
+                                "but it's not a ModestAccountProtocol");
                }
 
                g_free (provider_id);
@@ -2317,6 +2321,11 @@ save_to_settings (ModestEasysetupWizardDialog *self)
        modest_account_settings_set_display_name (priv->settings, display_name);
        g_free (display_name);
        g_free (provider_id);
+
+       /* This values are hardcoded for Fremantle */
+       modest_account_settings_set_retrieve_type (priv->settings,
+                                                  MODEST_ACCOUNT_RETRIEVE_MESSAGES_AND_ATTACHMENTS);
+       modest_account_settings_set_retrieve_limit (priv->settings, 20);
 }
 
 
@@ -2416,22 +2425,6 @@ check_has_supported_auth_methods(ModestEasysetupWizardDialog* self)
 }
 
 static gboolean
-check_support_progress_pulse (gpointer userdata)
-{
-       ModestEasysetupWizardDialog *self = (ModestEasysetupWizardDialog *) userdata;
-       ModestEasysetupWizardDialogPrivate *priv = MODEST_EASYSETUP_WIZARD_DIALOG_GET_PRIVATE (self);
-
-       if (priv->destroyed) {
-               priv->check_support_progress_pulse_id = 0;
-               return FALSE;
-       }
-
-       gtk_progress_bar_pulse (GTK_PROGRESS_BAR (priv->check_support_progress));
-
-       return TRUE;
-}
-
-static gboolean
 check_support_show_progress (gpointer userdata)
 {
        ModestEasysetupWizardDialog *self = (ModestEasysetupWizardDialog *) userdata;
@@ -2442,10 +2435,7 @@ check_support_show_progress (gpointer userdata)
        if (priv->destroyed)
                return FALSE;
 
-       gtk_widget_show (priv->check_support_progress);
-       gtk_progress_bar_pulse (GTK_PROGRESS_BAR (priv->check_support_progress));
-
-       priv->check_support_progress_pulse_id = g_timeout_add (200, check_support_progress_pulse, self);
+       hildon_gtk_window_set_progress_indicator (GTK_WINDOW (self), TRUE);
 
        return FALSE;
 }
@@ -2465,18 +2455,13 @@ check_support_callback (ModestAccountProtocol *protocol,
                priv->check_support_show_progress_id = 0;
        }
 
-       if (priv->check_support_progress_pulse_id > 0) {
-               g_source_remove (priv->check_support_progress_pulse_id);
-               priv->check_support_progress_pulse_id = 0;
-       }
-
        if (priv->pending_check_support == 0) {
                priv->check_support_done = TRUE;
 
                if (!priv->destroyed) {
                        if (priv->presets)
                                fill_providers (self);
-                       gtk_widget_hide (priv->check_support_progress);
+                       hildon_gtk_window_set_progress_indicator (GTK_WINDOW (self), FALSE);
                        invoke_enable_buttons_vfunc (self);
                }
        }