Fixes NB#107139, do not dim "Save button" if the wrong value for port is

[modest] / src / hildon2 / modest-number-editor.c

diff --git a/src/hildon2/modest-number-editor.c b/src/hildon2/modest-number-editor.c
index c8ea2db..57d1ada 100644 (file)
--- a/src/hildon2/modest-number-editor.c
+++ b/src/hildon2/modest-number-editor.c
@@ -1,8 +1,31 @@
 /*
- * This file is a part of modest
+ * Copyright (C) 2008 Nokia Corporation, all rights reserved.
+ * All rights reserved.
  *
- * Copyright (C) 2005, 2006, 2008 Nokia Corporation, all rights reserved.
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are
+ * met:
  *
+ * * Redistributions of source code must retain the above copyright
+ *   notice, this list of conditions and the following disclaimer.
+ * * Redistributions in binary form must reproduce the above copyright
+ *   notice, this list of conditions and the following disclaimer in the
+ *   documentation and/or other materials provided with the distribution.
+ * * Neither the name of the Nokia Corporation nor the names of its
+ *   contributors may be used to endorse or promote products derived from
+ *   this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS
+ * IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED
+ * TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A
+ * PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER
+ * OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
+ * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
+ * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
+ * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF
+ * LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
+ * NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
+ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 /**
@@ -191,7 +214,7 @@ modest_number_editor_class_init                 (ModestNumberEditorClass *editor
         g_signal_new ("valid_changed", MODEST_TYPE_NUMBER_EDITOR,
                 G_SIGNAL_RUN_LAST, G_STRUCT_OFFSET
                 (ModestNumberEditorClass, valid_changed),
-                g_signal_accumulator_true_handled, NULL,
+                NULL, NULL,
                 g_cclosure_marshal_VOID__BOOLEAN,
                 G_TYPE_NONE, 1, G_TYPE_BOOLEAN);
 }
@@ -353,11 +376,12 @@ modest_number_editor_validate_value             (ModestNumberEditor *editor,
                modest_number_editor_set_value (editor, fixup_value);
                g_signal_emit (editor, ModestNumberEditor_signal[RANGE_ERROR], 0, error_code, &r);
                add_select_all_idle (editor);
+               is_valid = modest_number_editor_is_valid (editor);
        }
 
        if (priv->is_valid != is_valid) {
-               g_signal_emit (editor, ModestNumberEditor_signal[VALID_CHANGED], 0, is_valid);
                priv->is_valid = is_valid;
+               g_signal_emit (editor, ModestNumberEditor_signal[VALID_CHANGED], 0, is_valid);
        }
 }
 
@@ -375,10 +399,15 @@ modest_number_editor_entry_focusout             (GtkWidget *widget,
                                                  GdkEventFocus *event,
                                                  gpointer data)
 {
-    g_assert (MODEST_IS_NUMBER_EDITOR(data));
+       GtkWidget *window;
+       
+       g_assert (MODEST_IS_NUMBER_EDITOR(data));
 
-    modest_number_editor_validate_value (MODEST_NUMBER_EDITOR(data), FALSE);
-    return FALSE;
+       window = gtk_widget_get_toplevel (widget);
+       if (window && gtk_window_has_toplevel_focus (GTK_WINDOW (window)))
+               modest_number_editor_validate_value (MODEST_NUMBER_EDITOR(data), FALSE);
+
+       return FALSE;
 }
 
 static gboolean
@@ -483,6 +512,26 @@ modest_number_editor_set_range                  (ModestNumberEditor *editor,
 }
 
 /**
+ * modest_number_editor_is_valid:
+ * @editor: pointer to #ModestNumberEditor
+ *
+ * Returns: if @editor contents are valid
+ */
+gboolean
+modest_number_editor_is_valid                  (ModestNumberEditor *editor)
+{
+    ModestNumberEditorPrivate *priv;
+
+    g_return_val_if_fail (MODEST_IS_NUMBER_EDITOR (editor), FALSE);
+
+    priv = MODEST_NUMBER_EDITOR_GET_PRIVATE (editor);
+    g_assert (priv);
+
+    return priv->is_valid;
+
+}
+
+/**
  * modest_number_editor_get_value:
  * @editor: pointer to #ModestNumberEditor
  *