Fixes NB#74612
[modest] / src / maemo / easysetup / modest-easysetup-wizard.c
index b86f40d..8e32cda 100644 (file)
@@ -88,6 +88,15 @@ struct _ModestEasysetupWizardDialogPrivate
        gboolean dirty;
 };
 
+static gboolean
+on_delete_event (GtkWidget *widget,
+                GdkEvent *event,
+                ModestEasysetupWizardDialog *wizard)
+{
+       gtk_dialog_response (GTK_DIALOG (wizard), GTK_RESPONSE_CANCEL);
+       return TRUE;
+}
+
 static void
 on_easysetup_changed(GtkWidget* widget, ModestEasysetupWizardDialog* wizard)
 {
@@ -345,10 +354,12 @@ on_combo_account_country (GtkComboBox *widget, gpointer user_data)
        priv->dirty = TRUE;
        
        /* Fill the providers combo, based on the selected country: */
-       gint mcc = easysetup_country_combo_box_get_active_country_mcc (
-               EASYSETUP_COUNTRY_COMBO_BOX (self->combo_account_country));
-       easysetup_provider_combo_box_fill (
-               EASYSETUP_PROVIDER_COMBO_BOX (self->combo_account_serviceprovider), priv->presets, mcc);
+       if (priv->presets != NULL) {
+               gint mcc = easysetup_country_combo_box_get_active_country_mcc (
+                       EASYSETUP_COUNTRY_COMBO_BOX (self->combo_account_country));
+               easysetup_provider_combo_box_fill (
+                       EASYSETUP_PROVIDER_COMBO_BOX (self->combo_account_serviceprovider), priv->presets, mcc);
+       }
 }
 
 static void
@@ -437,6 +448,7 @@ create_page_account_details (ModestEasysetupWizardDialog *self)
             
        /* The service provider widgets: */     
        self->combo_account_serviceprovider = GTK_WIDGET (easysetup_provider_combo_box_new ());
+       gtk_widget_set_size_request (self->combo_account_serviceprovider, 320, -1);
        
        caption = create_caption_new_with_asterisk (self, sizegroup, _("mcen_fi_serviceprovider"), 
                                                   self->combo_account_serviceprovider, NULL, HILDON_CAPTION_OPTIONAL);
@@ -871,6 +883,7 @@ on_button_outgoing_smtp_servers (GtkButton *button, gpointer user_data)
 
        /* Show the window: */
        gtk_window_set_transient_for (GTK_WINDOW (self->specific_window), GTK_WINDOW (self));
+       gtk_window_set_modal (GTK_WINDOW (self->specific_window), TRUE);
        gtk_widget_show (self->specific_window);
 }
 
@@ -993,7 +1006,7 @@ show_advanced_edit(gpointer user_data)
        ModestAccountSettingsDialog *dialog = modest_account_settings_dialog_new ();
        modest_account_settings_dialog_set_account_name (dialog, self->saved_account_name);
        
-       gtk_window_set_transient_for (GTK_WINDOW (dialog), GTK_WINDOW (self));
+       modest_window_mgr_set_modal (modest_runtime_get_window_mgr (), GTK_WINDOW (dialog));
        
        gtk_dialog_run (GTK_DIALOG (dialog));
 
@@ -1091,9 +1104,11 @@ on_response_before (ModestWizardDialog *wizard_dialog,
                if (priv->dirty) {
                        GtkDialog *dialog = GTK_DIALOG (hildon_note_new_confirmation (GTK_WINDOW (self), 
                                _("imum_nc_wizard_confirm_lose_changes")));
-                       /* TODO: These button names will be ambiguous, and not specified in the UI specification. */
+                       /* TODO: These button names will be ambiguous, and not
+                        * specified in the UI specification. */
 
                        const gint dialog_response = gtk_dialog_run (dialog);
+                       self->combo_account_country = NULL;
                        gtk_widget_destroy (GTK_WIDGET (dialog));
 
                        if (dialog_response != GTK_RESPONSE_OK) {
@@ -1104,6 +1119,78 @@ on_response_before (ModestWizardDialog *wizard_dialog,
        }
 }
 
+typedef struct IdleData {
+       ModestEasysetupWizardDialog *dialog;
+       ModestPresets *presets;
+} IdleData;
+
+gboolean
+presets_idle (gpointer userdata)
+{
+       IdleData *idle_data = (IdleData *) userdata;
+       ModestEasysetupWizardDialog *self = MODEST_EASYSETUP_WIZARD_DIALOG (idle_data->dialog);
+       ModestEasysetupWizardDialogPrivate *priv = WIZARD_DIALOG_GET_PRIVATE (self);
+
+       g_assert (idle_data->presets);
+
+       gdk_threads_enter ();
+
+       priv->presets = idle_data->presets;
+
+       if (self->combo_account_country) {
+               gint mcc = easysetup_country_combo_box_get_active_country_mcc (
+                       EASYSETUP_COUNTRY_COMBO_BOX (self->combo_account_country));
+               easysetup_provider_combo_box_fill (
+                       EASYSETUP_PROVIDER_COMBO_BOX (self->combo_account_serviceprovider),
+                       priv->presets, mcc);
+       }
+
+       priv->dirty = FALSE;
+
+       g_object_unref (idle_data->dialog);
+       g_free (idle_data);
+
+       gdk_threads_leave ();
+
+       return FALSE;
+}
+
+gpointer
+presets_loader (gpointer userdata)
+{
+       ModestEasysetupWizardDialog *self = MODEST_EASYSETUP_WIZARD_DIALOG (userdata);
+       ModestPresets *presets = NULL;
+       IdleData *idle_data;
+
+       const gchar* path  = NULL;
+       const gchar* path1 = MODEST_PROVIDER_DATA_FILE;
+       const gchar* path2 = MODEST_MAEMO_PROVIDER_DATA_FILE;
+       
+       if (access(path1, R_OK) == 0) 
+               path = path1;
+       else if (access(path2, R_OK) == 0)
+               path = path2;
+       else {
+               g_warning ("%s: neither '%s' nor '%s' is a readable provider data file",
+                          __FUNCTION__, path1, path2);
+               return NULL;
+       }
+
+       presets = modest_presets_new (path);
+       if (!presets) {
+               g_warning ("%s: failed to parse '%s'", __FUNCTION__, path);
+               return NULL;
+       }
+       
+       idle_data = g_new0 (IdleData, 1);
+       idle_data->dialog = self;
+       idle_data->presets = presets;
+       
+       g_idle_add (presets_idle, idle_data);   
+
+       return NULL;
+}
+
 static void
 modest_easysetup_wizard_dialog_init (ModestEasysetupWizardDialog *self)
 {
@@ -1123,14 +1210,6 @@ modest_easysetup_wizard_dialog_init (ModestEasysetupWizardDialog *self)
        /* Read in the information about known service providers: */
        ModestEasysetupWizardDialogPrivate *priv = WIZARD_DIALOG_GET_PRIVATE (self);
        
-       const gchar* filepath = MODEST_PROVIDERS_DATA_PATH; /* Defined in config.h */
-       priv->presets = modest_presets_new (filepath);
-       if (!(priv->presets)) {
-               g_warning ("Could not locate the official provider data keyfile from %s", filepath);
-       }
-       
-       g_assert(priv->presets);
-
        /* The server fields did not have been manually changed yet */
        priv->server_changes = 0;
 
@@ -1198,6 +1277,9 @@ modest_easysetup_wizard_dialog_init (ModestEasysetupWizardDialog *self)
        g_signal_connect (G_OBJECT (self), "response",
                          G_CALLBACK (on_response_before), self);
 
+       g_signal_connect (G_OBJECT (self), "delete-event",
+                         G_CALLBACK (on_delete_event), self);
+
        /* Reset dirty, because there was no user input until now */
        priv->dirty = FALSE;
        
@@ -1205,6 +1287,13 @@ modest_easysetup_wizard_dialog_init (ModestEasysetupWizardDialog *self)
         * because there is no sensible way to save the state: */
        modest_window_mgr_prevent_hibernation_while_window_is_shown (
                modest_runtime_get_window_mgr (), GTK_WINDOW (self)); 
+
+       /* Load provider presets */
+       g_object_ref (self);
+       g_thread_create (presets_loader, self, FALSE, NULL);
+
+       hildon_help_dialog_help_enable (GTK_DIALOG(self), "applications_email_wizardwelcome",
+                                       modest_maemo_utils_get_osso_context()); 
 }
 
 ModestEasysetupWizardDialog*
@@ -1640,7 +1729,7 @@ static gboolean
 create_account (ModestEasysetupWizardDialog *self, gboolean enabled)
 {
        ModestEasysetupWizardDialogPrivate *priv = WIZARD_DIALOG_GET_PRIVATE (self);
-       
+       guint special_port;
        gchar* display_name = get_entered_account_title (self);
 
        /* Some checks: */
@@ -1690,7 +1779,6 @@ create_account (ModestEasysetupWizardDialog *self, gboolean enabled)
                                                                                                   provider_id, 
                                                                                                   TRUE /* incoming */);
 
-               g_warning ("security incoming: %x", security_incoming);
                        
                /* We don't check for SMTP here as that is impossible for an incoming server. */
                if (servertype_incoming == MODEST_PRESETS_SERVER_TYPE_IMAP) {
@@ -1738,6 +1826,13 @@ create_account (ModestEasysetupWizardDialog *self, gboolean enabled)
        gchar *store_name = modest_account_mgr_get_unused_account_name (self->account_manager, 
                                                                        store_name_start, TRUE /* server account */);
        g_free (store_name_start);
+
+       /* we check if there is a *special* port */
+       special_port = modest_presets_get_port (priv->presets, provider_id,
+                                               TRUE /* incoming */);
+       if (special_port != 0)
+               serverport_incoming = special_port;
+       
        gboolean created = modest_account_mgr_add_server_account (self->account_manager,
                                                                  store_name,
                                                                  servername_incoming,
@@ -1781,10 +1876,6 @@ create_account (ModestEasysetupWizardDialog *self, gboolean enabled)
                        modest_presets_get_info_server_security (priv->presets, provider_id, 
                                                                 FALSE /* incoming */);
 
-               /* TODO: The secure-smtp information in the presets data is currently wrong,
-                * so we choose a reasonable default. Remove this when the presets data is corrected: */
-               security_outgoing = security_outgoing & MODEST_PRESETS_SECURITY_SECURE_SMTP;
-
                protocol_security_outgoing = MODEST_PROTOCOL_CONNECTION_NORMAL;
                if (security_outgoing & MODEST_PRESETS_SECURITY_SECURE_SMTP) {
                        /* printf("DEBUG: %s: using secure SMTP\n", __FUNCTION__); */
@@ -1795,8 +1886,7 @@ create_account (ModestEasysetupWizardDialog *self, gboolean enabled)
                        /* printf("DEBUG: %s: using non-secure SMTP\n", __FUNCTION__); */
                        protocol_authentication_outgoing = MODEST_PROTOCOL_AUTH_NONE;
                }
-       }
-       else {
+       } else {
                /* Use custom pages because no preset was specified: */
                servername_outgoing = g_strdup (gtk_entry_get_text (GTK_ENTRY (self->entry_outgoingserver) ));
                
@@ -1814,6 +1904,13 @@ create_account (ModestEasysetupWizardDialog *self, gboolean enabled)
        gchar *transport_name = modest_account_mgr_get_unused_account_name (self->account_manager, 
                                                                            transport_name_start, TRUE /* server account */);
        g_free (transport_name_start);
+
+       /* we check if there is a *special* port */
+       special_port = modest_presets_get_port (priv->presets, provider_id,
+                                               FALSE /* incoming */);
+       if (special_port != 0)
+               serverport_outgoing = special_port;
+       
        created = modest_account_mgr_add_server_account (self->account_manager,
                                                         transport_name,
                                                         servername_outgoing,
@@ -1832,11 +1929,19 @@ create_account (ModestEasysetupWizardDialog *self, gboolean enabled)
                return FALSE;   
        }
        
+       const gchar* user_fullname = gtk_entry_get_text (GTK_ENTRY (self->entry_user_name));
+       const gchar* emailaddress = gtk_entry_get_text (GTK_ENTRY (self->entry_user_email));
+       const gchar *retrieve = MODEST_ACCOUNT_RETRIEVE_VALUE_HEADERS_ONLY;
        
        /* Create the account, which will contain the two "server accounts": */
-       created = modest_account_mgr_add_account (self->account_manager, account_name, 
-                                                 store_name, /* The name of our POP/IMAP server account. */
-                                                 transport_name, /* The name of our SMTP server account. */
+       created = modest_account_mgr_add_account (self->account_manager, 
+                                                 account_name, 
+                                                 display_name,
+                                                 user_fullname,
+                                                 emailaddress,
+                                                 retrieve,
+                                                 store_name,
+                                                 transport_name,
                                                  enabled);
        g_free (store_name);
        g_free (transport_name);
@@ -1855,20 +1960,6 @@ create_account (ModestEasysetupWizardDialog *self, gboolean enabled)
        if(!modest_account_mgr_has_accounts (self->account_manager, FALSE))
                g_warning ("modest_account_mgr_account_names() returned NULL after adding an account.");
                
-       /* The user name and email address must be set additionally: */
-       const gchar* user_name = gtk_entry_get_text (GTK_ENTRY (self->entry_user_name));
-       modest_account_mgr_set_server_account_user_fullname (self->account_manager, account_name, user_name);
-
-       const gchar* emailaddress = gtk_entry_get_text (GTK_ENTRY (self->entry_user_email));
-       modest_account_mgr_set_server_account_user_email (self->account_manager, account_name, emailaddress); 
-
-       /* Set the display name: */
-       modest_account_mgr_set_display_name (self->account_manager, account_name, display_name);
-
-       /* Set retrieve type */ 
-       const gchar *retrieve = MODEST_ACCOUNT_RETRIEVE_VALUE_HEADERS_ONLY;
-       modest_account_mgr_set_retrieve_type (self->account_manager, account_name, retrieve);
-
        /* Save the connection-specific SMTP server accounts. */
         modest_account_mgr_set_use_connection_specific_smtp(self->account_manager, account_name, 
                 gtk_toggle_button_get_active(GTK_TOGGLE_BUTTON(self->checkbox_outgoing_smtp_specific)));