projects
/
modest
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
Fixes NB#137949, show notifications even if the application is in the foreground
[modest]
/
src
/
modest-mail-operation-queue.c
diff --git
a/src/modest-mail-operation-queue.c
b/src/modest-mail-operation-queue.c
index
1ca4450
..
22bbd53
100644
(file)
--- a/
src/modest-mail-operation-queue.c
+++ b/
src/modest-mail-operation-queue.c
@@
-180,7
+180,7
@@
on_finalize_foreach(gpointer op,
g_signal_handlers_disconnect_by_func (mail_op, G_CALLBACK (on_operation_finished), user_data);
MODEST_DEBUG_BLOCK (print_queue_item (mail_op, "cancel/remove"););
g_signal_handlers_disconnect_by_func (mail_op, G_CALLBACK (on_operation_finished), user_data);
MODEST_DEBUG_BLOCK (print_queue_item (mail_op, "cancel/remove"););
-
+
modest_mail_operation_cancel (mail_op);
g_queue_remove (priv->op_queue, mail_op);
g_object_unref (G_OBJECT (mail_op));
modest_mail_operation_cancel (mail_op);
g_queue_remove (priv->op_queue, mail_op);
g_object_unref (G_OBJECT (mail_op));
@@
-245,7
+245,7
@@
modest_mail_operation_queue_add (ModestMailOperationQueue *self,
g_return_if_fail (MODEST_IS_MAIL_OPERATION_QUEUE (self));
g_return_if_fail (MODEST_IS_MAIL_OPERATION (mail_op));
g_return_if_fail (MODEST_IS_MAIL_OPERATION_QUEUE (self));
g_return_if_fail (MODEST_IS_MAIL_OPERATION (mail_op));
-
+
priv = MODEST_MAIL_OPERATION_QUEUE_GET_PRIVATE(self);
priv->running_final_sync = (modest_mail_operation_get_type_operation (mail_op) == MODEST_MAIL_OPERATION_TYPE_SHUTDOWN);
priv = MODEST_MAIL_OPERATION_QUEUE_GET_PRIVATE(self);
priv->running_final_sync = (modest_mail_operation_get_type_operation (mail_op) == MODEST_MAIL_OPERATION_TYPE_SHUTDOWN);
@@
-253,7
+253,7
@@
modest_mail_operation_queue_add (ModestMailOperationQueue *self,
g_mutex_lock (priv->queue_lock);
g_queue_push_tail (priv->op_queue, g_object_ref (mail_op));
g_mutex_unlock (priv->queue_lock);
g_mutex_lock (priv->queue_lock);
g_queue_push_tail (priv->op_queue, g_object_ref (mail_op));
g_mutex_unlock (priv->queue_lock);
-
+
MODEST_DEBUG_BLOCK (print_queue_item (mail_op, "add"););
/* Get notified when the operation ends to remove it from the
MODEST_DEBUG_BLOCK (print_queue_item (mail_op, "add"););
/* Get notified when the operation ends to remove it from the
@@
-302,7
+302,7
@@
notify_queue_empty (gpointer user_data)
}
}
-void
+void
modest_mail_operation_queue_remove (ModestMailOperationQueue *self,
ModestMailOperation *mail_op)
{
modest_mail_operation_queue_remove (ModestMailOperationQueue *self,
ModestMailOperation *mail_op)
{
@@
-342,7
+342,7
@@
modest_mail_operation_queue_remove (ModestMailOperationQueue *self,
modest_mail_operation_execute_error_handler (mail_op);
} else {
if (status == MODEST_MAIL_OPERATION_STATUS_CANCELED)
modest_mail_operation_execute_error_handler (mail_op);
} else {
if (status == MODEST_MAIL_OPERATION_STATUS_CANCELED)
- g_warning ("%s: operation canceled \n", __FUNCTION__);
+ g_debug ("%s: operation canceled \n", __FUNCTION__);
else
g_warning ("%s: possible error in a mail operation " \
"implementation. The status is not successful " \
else
g_warning ("%s: possible error in a mail operation " \
"implementation. The status is not successful " \
@@
-367,14
+367,14
@@
modest_mail_operation_queue_remove (ModestMailOperationQueue *self,
}
}
}
}
-guint
+guint
modest_mail_operation_queue_num_elements (ModestMailOperationQueue *self)
{
ModestMailOperationQueuePrivate *priv;
guint length = 0;
g_return_val_if_fail (MODEST_IS_MAIL_OPERATION_QUEUE (self), 0);
modest_mail_operation_queue_num_elements (ModestMailOperationQueue *self)
{
ModestMailOperationQueuePrivate *priv;
guint length = 0;
g_return_val_if_fail (MODEST_IS_MAIL_OPERATION_QUEUE (self), 0);
-
+
priv = MODEST_MAIL_OPERATION_QUEUE_GET_PRIVATE(self);
g_mutex_lock (priv->queue_lock);
priv = MODEST_MAIL_OPERATION_QUEUE_GET_PRIVATE(self);
g_mutex_lock (priv->queue_lock);
@@
-452,68
+452,77
@@
typedef struct
static void
on_find_by_source_foreach (gpointer op, gpointer data)
{
static void
on_find_by_source_foreach (gpointer op, gpointer data)
{
- FindBySourceInfo *info = (FindBySourceInfo*) data;
+ FindBySourceInfo *info = (FindBySourceInfo*) data;
+ GObject *source = NULL;
- if ( info->source == modest_mail_operation_get_source (MODEST_MAIL_OPERATION (op))) {
+ source = modest_mail_operation_get_source (MODEST_MAIL_OPERATION (op));
+ if (info->source == source) {
g_object_ref (G_OBJECT (op));
*(info->new_list) = g_slist_prepend (*(info->new_list), MODEST_MAIL_OPERATION (op));
}
g_object_ref (G_OBJECT (op));
*(info->new_list) = g_slist_prepend (*(info->new_list), MODEST_MAIL_OPERATION (op));
}
+ if (source)
+ g_object_unref (source);
}
GSList*
}
GSList*
-modest_mail_operation_queue_get_by_source (
- ModestMailOperationQueue *self,
- GObject *source)
+modest_mail_operation_queue_get_by_source (ModestMailOperationQueue *self,
+ GObject *source)
{
ModestMailOperationQueuePrivate *priv;
GSList* found_operations= NULL;
{
ModestMailOperationQueuePrivate *priv;
GSList* found_operations= NULL;
- FindBySourceInfo *info = g_new0 (FindBySourceInfo, 1);
+ FindBySourceInfo *info;
g_return_val_if_fail (MODEST_IS_MAIL_OPERATION_QUEUE (self), NULL);
g_return_val_if_fail (source != NULL, NULL);
g_return_val_if_fail (MODEST_IS_MAIL_OPERATION_QUEUE (self), NULL);
g_return_val_if_fail (source != NULL, NULL);
-
+
priv = MODEST_MAIL_OPERATION_QUEUE_GET_PRIVATE(self);
priv = MODEST_MAIL_OPERATION_QUEUE_GET_PRIVATE(self);
+ info = g_new0 (FindBySourceInfo, 1);
info->new_list = &found_operations;
info->source = source;
info->new_list = &found_operations;
info->source = source;
-
+
g_mutex_lock (priv->queue_lock);
g_queue_foreach (priv->op_queue, (GFunc) on_find_by_source_foreach, info);
g_mutex_unlock (priv->queue_lock);
g_mutex_lock (priv->queue_lock);
g_queue_foreach (priv->op_queue, (GFunc) on_find_by_source_foreach, info);
g_mutex_unlock (priv->queue_lock);
-
+
g_free (info);
g_free (info);
-
+
return found_operations;
}
static void
accumulate_mail_op_strings (ModestMailOperation *op, gchar **str)
{
return found_operations;
}
static void
accumulate_mail_op_strings (ModestMailOperation *op, gchar **str)
{
- *str = g_strdup_printf ("%s\n%s", *str, modest_mail_operation_to_string (op));
+ gchar *mail_op_to_str = modest_mail_operation_to_string (op);
+ *str = g_strdup_printf ("%s\n%s", *str, mail_op_to_str);
+ g_free (mail_op_to_str);
}
gchar*
modest_mail_operation_queue_to_string (ModestMailOperationQueue *self)
{
}
gchar*
modest_mail_operation_queue_to_string (ModestMailOperationQueue *self)
{
- gchar *str;
+ gchar *str = NULL;
guint len;
ModestMailOperationQueuePrivate *priv;
guint len;
ModestMailOperationQueuePrivate *priv;
-
+
g_return_val_if_fail (MODEST_IS_MAIL_OPERATION_QUEUE (self), NULL);
g_return_val_if_fail (MODEST_IS_MAIL_OPERATION_QUEUE (self), NULL);
-
+
priv = MODEST_MAIL_OPERATION_QUEUE_GET_PRIVATE(self);
len = g_queue_get_length (priv->op_queue);
str = g_strdup_printf ("mail operation queue (%02d)\n-------------------------", len);
priv = MODEST_MAIL_OPERATION_QUEUE_GET_PRIVATE(self);
len = g_queue_get_length (priv->op_queue);
str = g_strdup_printf ("mail operation queue (%02d)\n-------------------------", len);
- if (len == 0)
- str = g_strdup_printf ("%s\n%s", str, "<empty>");
- else {
+ if (len == 0) {
+ gchar *copy;
+ copy = str;
+ str = g_strdup_printf ("%s\n%s", copy, "<empty>");
+ g_free (copy);
+ } else {
g_mutex_lock (priv->queue_lock);
g_queue_foreach (priv->op_queue, (GFunc)accumulate_mail_op_strings, &str);
g_mutex_unlock (priv->queue_lock);
}
g_mutex_lock (priv->queue_lock);
g_queue_foreach (priv->op_queue, (GFunc)accumulate_mail_op_strings, &str);
g_mutex_unlock (priv->queue_lock);
}
-
+
return str;
}
return str;
}
@@
-521,9
+530,9
@@
gboolean
modest_mail_operation_queue_running_shutdown (ModestMailOperationQueue *self)
{
ModestMailOperationQueuePrivate *priv;
modest_mail_operation_queue_running_shutdown (ModestMailOperationQueue *self)
{
ModestMailOperationQueuePrivate *priv;
-
+
g_return_val_if_fail (MODEST_IS_MAIL_OPERATION_QUEUE (self), FALSE);
g_return_val_if_fail (MODEST_IS_MAIL_OPERATION_QUEUE (self), FALSE);
-
+
priv = MODEST_MAIL_OPERATION_QUEUE_GET_PRIVATE(self);
return priv->running_final_sync;
}
priv = MODEST_MAIL_OPERATION_QUEUE_GET_PRIVATE(self);
return priv->running_final_sync;
}
@@
-532,9
+541,9
@@
void
modest_mail_operation_queue_set_running_shutdown (ModestMailOperationQueue *self)
{
ModestMailOperationQueuePrivate *priv;
modest_mail_operation_queue_set_running_shutdown (ModestMailOperationQueue *self)
{
ModestMailOperationQueuePrivate *priv;
-
+
g_return_if_fail (MODEST_IS_MAIL_OPERATION_QUEUE (self));
g_return_if_fail (MODEST_IS_MAIL_OPERATION_QUEUE (self));
-
+
priv = MODEST_MAIL_OPERATION_QUEUE_GET_PRIVATE(self);
priv->running_final_sync = TRUE;
}
priv = MODEST_MAIL_OPERATION_QUEUE_GET_PRIVATE(self);
priv->running_final_sync = TRUE;
}