* src/modest-ui-actions.[ch]:
[modest] / src / modest-mail-operation.c
index bfef576..2d24e88 100644 (file)
@@ -38,6 +38,7 @@
 #include <tny-camel-stream.h>
 #include <tny-simple-list.h>
 #include <tny-send-queue.h>
+#include <tny-status.h>
 #include <camel/camel-stream-mem.h>
 #include <glib/gi18n.h>
 #include <modest-tny-account.h>
@@ -45,9 +46,9 @@
 #include <modest-runtime.h>
 #include "modest-text-utils.h"
 #include "modest-tny-msg.h"
+#include "modest-tny-folder.h"
 #include "modest-tny-platform-factory.h"
 #include "modest-marshal.h"
-#include "modest-formatter.h"
 #include "modest-error.h"
 
 /* 'private'/'protected' functions */
@@ -55,21 +56,10 @@ static void modest_mail_operation_class_init (ModestMailOperationClass *klass);
 static void modest_mail_operation_init       (ModestMailOperation *obj);
 static void modest_mail_operation_finalize   (GObject *obj);
 
-static void     status_update_cb     (TnyFolder *folder, 
-                                     const gchar *what, 
-                                     gint status, 
-                                     gint oftotal,
-                                     gpointer user_data);
-static void     folder_refresh_cb    (TnyFolder *folder, 
-                                     gboolean canceled,
-                                     GError **err,
-                                     gpointer user_data);
 static void     update_folders_cb    (TnyFolderStore *self, 
                                      TnyList *list, 
                                      GError **err, 
                                      gpointer user_data);
-static void     add_attachments      (TnyMsg *msg, 
-                                     GList *attachments_list);
 
 enum _ModestMailOperationSignals 
 {
@@ -82,7 +72,8 @@ typedef struct _ModestMailOperationPrivate ModestMailOperationPrivate;
 struct _ModestMailOperationPrivate {
        guint                      done;
        guint                      total;
-       ModestMailOperationStatus  status;
+       ModestMailOperationStatus  status;      
+       ModestMailOperationId      id;          
        GError                    *error;
 };
 
@@ -90,9 +81,8 @@ struct _ModestMailOperationPrivate {
                                                    MODEST_TYPE_MAIL_OPERATION, \
                                                    ModestMailOperationPrivate))
 
-#define CHECK_EXCEPTION(priv, new_status, op)  if (priv->error) {\
+#define CHECK_EXCEPTION(priv, new_status)  if (priv->error) {\
                                                    priv->status = new_status;\
-                                                   op;\
                                                }
 
 typedef struct _RefreshFolderAsyncHelper
@@ -104,6 +94,15 @@ typedef struct _RefreshFolderAsyncHelper
 
 } RefreshFolderAsyncHelper;
 
+typedef struct _XFerMsgAsyncHelper
+{
+       ModestMailOperation *mail_op;
+       TnyList *headers;
+       TnyFolder *dest_folder;
+
+} XFerMsgAsyncHelper;
+
+
 /* globals */
 static GObjectClass *parent_class = NULL;
 
@@ -152,7 +151,7 @@ modest_mail_operation_class_init (ModestMailOperationClass *klass)
         * Emitted when the progress of a mail operation changes
         */
        signals[PROGRESS_CHANGED_SIGNAL] = 
-               g_signal_new ("progress_changed",
+               g_signal_new ("progress-changed",
                              G_TYPE_FROM_CLASS (gobject_class),
                              G_SIGNAL_RUN_FIRST,
                              G_STRUCT_OFFSET (ModestMailOperationClass, progress_changed),
@@ -169,6 +168,7 @@ modest_mail_operation_init (ModestMailOperation *obj)
        priv = MODEST_MAIL_OPERATION_GET_PRIVATE(obj);
 
        priv->status   = MODEST_MAIL_OPERATION_STATUS_INVALID;
+       priv->id       = MODEST_MAIL_OPERATION_ID_UNKNOWN;
        priv->error    = NULL;
        priv->done     = 0;
        priv->total    = 0;
@@ -190,12 +190,32 @@ modest_mail_operation_finalize (GObject *obj)
 }
 
 ModestMailOperation*
-modest_mail_operation_new (void)
+modest_mail_operation_new (ModestMailOperationId id)
 {
-       return MODEST_MAIL_OPERATION(g_object_new(MODEST_TYPE_MAIL_OPERATION, NULL));
+       ModestMailOperation *obj;
+       ModestMailOperationPrivate *priv;
+
+
+       obj = MODEST_MAIL_OPERATION(g_object_new(MODEST_TYPE_MAIL_OPERATION, NULL));
+       priv = MODEST_MAIL_OPERATION_GET_PRIVATE(obj);
+
+       priv->id = id;
+
+       return obj;
 }
 
 
+
+ModestMailOperationId
+modest_mail_operation_get_id (ModestMailOperation *self)
+{
+       ModestMailOperationPrivate *priv;
+
+       priv = MODEST_MAIL_OPERATION_GET_PRIVATE(self);
+       
+       return priv->id;
+}
+
 void
 modest_mail_operation_send_mail (ModestMailOperation *self,
                                 TnyTransportAccount *transport_account,
@@ -205,6 +225,7 @@ modest_mail_operation_send_mail (ModestMailOperation *self,
        
        g_return_if_fail (MODEST_IS_MAIL_OPERATION (self));
        g_return_if_fail (TNY_IS_TRANSPORT_ACCOUNT (transport_account));
+       g_return_if_fail (TNY_IS_MSG (msg));
        
        send_queue = TNY_SEND_QUEUE (modest_runtime_get_send_queue (transport_account));
        if (!TNY_IS_SEND_QUEUE(send_queue))
@@ -219,6 +240,9 @@ modest_mail_operation_send_mail (ModestMailOperation *self,
                } else
                        g_message ("modest: message added to send queue");
        }
+
+       /* Notify the queue */
+       modest_mail_operation_queue_remove (modest_runtime_get_mail_operation_queue (), self);
 }
 
 void
@@ -226,11 +250,14 @@ modest_mail_operation_send_new_mail (ModestMailOperation *self,
                                     TnyTransportAccount *transport_account,
                                     const gchar *from,  const gchar *to,
                                     const gchar *cc,  const gchar *bcc,
-                                    const gchar *subject, const gchar *body,
-                                    const GList *attachments_list)
+                                    const gchar *subject, const gchar *plain_body,
+                                    const gchar *html_body,
+                                    const GList *attachments_list,
+                                    TnyHeaderFlags priority_flags)
 {
        TnyMsg *new_msg;
        ModestMailOperationPrivate *priv = NULL;
+       /* GList *node = NULL; */
 
        g_return_if_fail (MODEST_IS_MAIL_OPERATION (self));
        g_return_if_fail (TNY_IS_TRANSPORT_ACCOUNT (transport_account));
@@ -240,280 +267,180 @@ modest_mail_operation_send_new_mail (ModestMailOperation *self,
        /* Check parametters */
        if (to == NULL) {
                g_set_error (&(priv->error), MODEST_MAIL_OPERATION_ERROR,
-                            MODEST_MAIL_OPERATION_ERROR_MISSING_PARAMETER,
+                            MODEST_MAIL_OPERATION_ERROR_BAD_PARAMETER,
                             _("Error trying to send a mail. You need to set at least one recipient"));
                return;
        }
 
-       new_msg = modest_tny_msg_new (to, from, cc, bcc, subject, body, NULL); /* FIXME: attachments */
+       if (html_body == NULL) {
+               new_msg = modest_tny_msg_new (to, from, cc, bcc, subject, plain_body, (GSList *) attachments_list); /* FIXME: attachments */
+       } else {
+               new_msg = modest_tny_msg_new_html_plain (to, from, cc, bcc, subject, html_body, plain_body, (GSList *) attachments_list);
+       }
        if (!new_msg) {
                g_printerr ("modest: failed to create a new msg\n");
                return;
        }
-       
+
+       /* TODO: add priority handling. It's received in the priority_flags operator, and
+          it should have effect in the sending operation */
+
+       /* Call mail operation */
        modest_mail_operation_send_mail (self, transport_account, new_msg);
 
-       g_object_unref (G_OBJECT(new_msg));
+       /* Free */
+       g_object_unref (G_OBJECT (new_msg));
 }
 
-static void
-add_if_attachment (gpointer data, gpointer user_data)
+void
+modest_mail_operation_save_to_drafts (ModestMailOperation *self,
+                                     TnyTransportAccount *transport_account,
+                                     const gchar *from,  const gchar *to,
+                                     const gchar *cc,  const gchar *bcc,
+                                     const gchar *subject, const gchar *plain_body,
+                                     const gchar *html_body,
+                                     const GList *attachments_list,
+                                     TnyHeaderFlags priority_flags)
 {
-       TnyMimePart *part;
-       GList *attachments_list;
+       TnyMsg *msg = NULL;
+       TnyFolder *folder = NULL;
+       ModestMailOperationPrivate *priv = NULL;
+       GError *err = NULL;
 
-       part = TNY_MIME_PART (data);
-       attachments_list = (GList *) user_data;
+       /* GList *node = NULL; */
 
-       if (tny_mime_part_is_attachment (part))
-               attachments_list = g_list_prepend (attachments_list, part);
-}
+       g_return_if_fail (MODEST_IS_MAIL_OPERATION (self));
+       g_return_if_fail (TNY_IS_TRANSPORT_ACCOUNT (transport_account));
 
+       priv = MODEST_MAIL_OPERATION_GET_PRIVATE(self);
 
-static TnyMsg *
-create_reply_forward_mail (TnyMsg *msg, const gchar *from, gboolean is_reply, guint type)
-{
-       TnyMsg *new_msg;
-       TnyHeader *new_header, *header;
-       gchar *new_subject;
-       TnyMimePart *body;
-       ModestFormatter *formatter;
-
-       /* Get body from original msg. Always look for the text/plain
-          part of the message to create the reply/forwarded mail */
-       header = tny_msg_get_header (msg);
-       body   = modest_tny_msg_find_body_part (msg, FALSE);
-
-       /* TODO: select the formatter from account prefs */
-       formatter = modest_formatter_new ("text/plain");
-
-       /* Format message body */
-       if (is_reply) {
-               switch (type) {
-               case MODEST_MAIL_OPERATION_REPLY_TYPE_CITE:
-               default:
-                       new_msg = modest_formatter_cite  (formatter, body, header);
-                       break;
-               case MODEST_MAIL_OPERATION_REPLY_TYPE_QUOTE:
-                       new_msg = modest_formatter_quote (formatter, body, header);
-                       break;
-               }
+       if (html_body == NULL) {
+               msg = modest_tny_msg_new (to, from, cc, bcc, subject, plain_body, (GSList *) attachments_list); /* FIXME: attachments */
        } else {
-               switch (type) {
-               case MODEST_MAIL_OPERATION_FORWARD_TYPE_INLINE:
-               default:
-                       new_msg = modest_formatter_inline  (formatter, body, header);
-                       break;
-               case MODEST_MAIL_OPERATION_FORWARD_TYPE_ATTACHMENT:
-                       new_msg = modest_formatter_attach (formatter, body, header);
-                       break;
-               }
+               msg = modest_tny_msg_new_html_plain (to, from, cc, bcc, subject, html_body, plain_body, (GSList *) attachments_list);
+       }
+       if (!msg) {
+               g_printerr ("modest: failed to create a new msg\n");
+               goto cleanup;
        }
-       g_object_unref (G_OBJECT(formatter));
-       g_object_unref (G_OBJECT(body));
-       
-       /* Fill the header */
-       new_header = tny_msg_get_header (new_msg);      
-       tny_header_set_from (new_header, from);
-       tny_header_set_replyto (new_header, from);
-
-       /* Change the subject */
-       new_subject =
-               (gchar *) modest_text_utils_derived_subject (tny_header_get_subject(header),
-                                                            (is_reply) ? _("Re:") : _("Fwd:"));
-       tny_header_set_subject (new_header, (const gchar *) new_subject);
-       g_free (new_subject);
-
-       /* Clean */
-       g_object_unref (G_OBJECT (new_header));
-       g_object_unref (G_OBJECT (header));
-
-       return new_msg;
-}
-
-TnyMsg* 
-modest_mail_operation_create_forward_mail (TnyMsg *msg, 
-                                          const gchar *from,
-                                          ModestMailOperationForwardType forward_type)
-{
-       TnyMsg *new_msg;
-       TnyList *parts = NULL;
-       GList *attachments_list = NULL;
-
-       new_msg = create_reply_forward_mail (msg, from, FALSE, forward_type);
-
-       /* Add attachments */
-       parts = TNY_LIST (tny_simple_list_new());
-       tny_mime_part_get_parts (TNY_MIME_PART (msg), parts);
-       tny_list_foreach (parts, add_if_attachment, attachments_list);
-       add_attachments (new_msg, attachments_list);
-
-       /* Clean */
-       if (attachments_list)
-               g_list_free (attachments_list);
-       g_object_unref (G_OBJECT (parts));
-
-       return new_msg;
-}
-
-TnyMsg* 
-modest_mail_operation_create_reply_mail (TnyMsg *msg, 
-                                        const gchar *from,
-                                        ModestMailOperationReplyType reply_type,
-                                        ModestMailOperationReplyMode reply_mode)
-{
-       TnyMsg *new_msg = NULL;
-       TnyHeader *new_header, *header;
-       const gchar* reply_to;
-       gchar *new_cc = NULL;
-       const gchar *cc = NULL, *bcc = NULL;
-       GString *tmp = NULL;
-
-       new_msg = create_reply_forward_mail (msg, from, TRUE, reply_type);
-
-       /* Fill the header */
-       header = tny_msg_get_header (msg);
-       new_header = tny_msg_get_header (new_msg);
-       reply_to = tny_header_get_replyto (header);
 
-       if (reply_to)
-               tny_header_set_to (new_header, reply_to);
-       else
-               tny_header_set_to (new_header, tny_header_get_from (header));
-
-       switch (reply_mode) {
-       case MODEST_MAIL_OPERATION_REPLY_MODE_SENDER:
-               /* Do not fill neither cc nor bcc */
-               break;
-       case MODEST_MAIL_OPERATION_REPLY_MODE_LIST:
-               /* TODO */
-               break;
-       case MODEST_MAIL_OPERATION_REPLY_MODE_ALL:
-               /* Concatenate to, cc and bcc */
-               cc = tny_header_get_cc (header);
-               bcc = tny_header_get_bcc (header);
-
-               tmp = g_string_new (tny_header_get_to (header));
-               if (cc)  g_string_append_printf (tmp, ",%s",cc);
-               if (bcc) g_string_append_printf (tmp, ",%s",bcc);
-
-               /* Remove my own address from the cc list. TODO:
-                  remove also the To: of the new message, needed due
-                  to the new reply_to feature */
-               new_cc = (gchar *)
-                       modest_text_utils_remove_address ((const gchar *) tmp->str,
-                                                         from);
-               /* FIXME: remove also the mails from the new To: */
-               tny_header_set_cc (new_header, new_cc);
-
-               /* Clean */
-               g_string_free (tmp, TRUE);
-               g_free (new_cc);
-               break;
+       folder = modest_tny_account_get_special_folder (TNY_ACCOUNT (transport_account), TNY_FOLDER_TYPE_DRAFTS);
+       if (!folder) {
+               g_printerr ("modest: failed to find Drafts folder\n");
+               goto cleanup;
+       }
+       
+       tny_folder_add_msg (folder, msg, &err);
+       if (err) {
+               g_printerr ("modest: error adding msg to Drafts folder: %s",
+                           err->message);
+               g_error_free (err);
+               goto cleanup;
        }
 
-       /* Clean */
-       g_object_unref (G_OBJECT (new_header));
-       g_object_unref (G_OBJECT (header));
+       modest_mail_operation_queue_remove (modest_runtime_get_mail_operation_queue (), self);
 
-       return new_msg;
+       /* Free */
+cleanup:
+       if (msg)
+               g_object_unref (G_OBJECT(msg));
+       if (folder)
+               g_object_unref (G_OBJECT(folder));
 }
 
 static void
-status_update_cb (TnyFolder *folder, const gchar *what, gint status, gint oftotal, gpointer user_data) 
+recurse_folders (TnyFolderStore *store, TnyFolderStoreQuery *query, TnyList *all_folders)
 {
-       g_print ("%s status: %d, of total %d\n", what, status, oftotal);
-}
+       TnyIterator *iter;
+       TnyList *folders = tny_simple_list_new ();
 
-static void
-folder_refresh_cb (TnyFolder *folder, gboolean canceled, GError **err, gpointer user_data)
-{
-       ModestMailOperation *self = NULL;
-       ModestMailOperationPrivate *priv = NULL;
-       RefreshFolderAsyncHelper *helper;
+       tny_folder_store_get_folders (store, folders, query, NULL);
+       iter = tny_list_create_iterator (folders);
 
-       helper = (RefreshFolderAsyncHelper *) user_data;
-       self = MODEST_MAIL_OPERATION (helper->mail_op);
-       priv = MODEST_MAIL_OPERATION_GET_PRIVATE(self);
+       while (!tny_iterator_is_done (iter)) {
 
-       if ((canceled && *err) || *err) {
-               priv->error = g_error_copy (*err);
-               helper->failed++;
-       } else if (canceled) {
-               helper->canceled++;
-               g_set_error (&(priv->error), MODEST_MAIL_OPERATION_ERROR,
-                            MODEST_MAIL_OPERATION_ERROR_OPERATION_CANCELED,
-                            _("Error trying to refresh folder %s. Operation canceled"),
-                            tny_folder_get_name (folder));
-       } else {
-               priv->done++;
-       }
+               TnyFolderStore *folder = (TnyFolderStore*) tny_iterator_get_current (iter);
 
-       if (priv->done == priv->total)
-               priv->status = MODEST_MAIL_OPERATION_STATUS_SUCCESS;
-       else if ((priv->done + helper->canceled + helper->failed) == priv->total) {
-               if (helper->failed == priv->total)
-                       priv->status = MODEST_MAIL_OPERATION_STATUS_FAILED;
-               else if (helper->failed == priv->total)
-                       priv->status = MODEST_MAIL_OPERATION_STATUS_CANCELED;
-               else
-                       priv->status = MODEST_MAIL_OPERATION_STATUS_FINISHED_WITH_ERRORS;
-       }
-       tny_iterator_next (helper->iter);
-       if (tny_iterator_is_done (helper->iter)) {
-               TnyList *list;
-               list = tny_iterator_get_list (helper->iter);
-               g_object_unref (G_OBJECT (helper->iter));
-               g_object_unref (G_OBJECT (list));
-               g_slice_free (RefreshFolderAsyncHelper, helper);
-       } else {
-               TnyFolder *folder = TNY_FOLDER (tny_iterator_get_current (helper->iter));
-               if (folder) {
-                       g_message ("modest: refreshing folder %s",
-                                  tny_folder_get_name (folder));
-                       tny_folder_refresh_async (folder, folder_refresh_cb, status_update_cb, helper);
-                       g_object_unref (G_OBJECT(folder)); // FIXME: don't unref yet
-               }
+               tny_list_prepend (all_folders, G_OBJECT (folder));
+
+               recurse_folders (folder, query, all_folders);
+           
+               g_object_unref (G_OBJECT (folder));
+
+               tny_iterator_next (iter);
        }
-       g_signal_emit (G_OBJECT (self), signals[PROGRESS_CHANGED_SIGNAL], 0, NULL);
+        g_object_unref (G_OBJECT (iter));
+        g_object_unref (G_OBJECT (folders));
 }
 
-
 static void
 update_folders_cb (TnyFolderStore *folder_store, TnyList *list, GError **err, gpointer user_data)
 {
        ModestMailOperation *self;
        ModestMailOperationPrivate *priv;
-       RefreshFolderAsyncHelper *helper;
-       TnyFolder *folder;
+       TnyIterator *iter;
+       TnyList *all_folders;
        
        self  = MODEST_MAIL_OPERATION (user_data);
        priv  = MODEST_MAIL_OPERATION_GET_PRIVATE (self);
 
+       g_message (__FUNCTION__);
+       
        if (*err) {
                priv->error = g_error_copy (*err);
                priv->status = MODEST_MAIL_OPERATION_STATUS_FAILED;
-               return;
+               goto out;
        }
 
-       priv->total = tny_list_get_length (list);
-       priv->done = 0;
-       priv->status = MODEST_MAIL_OPERATION_STATUS_IN_PROGRESS;
+       /* Get all the folders We can do it synchronously because
+          we're already running in a different thread than the UI */
+       all_folders = tny_list_copy (list);
+       iter = tny_list_create_iterator (all_folders);
+       while (!tny_iterator_is_done (iter)) {
+               TnyFolderStore *folder = TNY_FOLDER_STORE (tny_iterator_get_current (iter));
 
-       helper = g_slice_new0 (RefreshFolderAsyncHelper);
-       helper->mail_op = self;
-       helper->iter = tny_list_create_iterator (list);
-       helper->failed = 0;
-       helper->canceled = 0;
-
-       /* Async refresh folders */
-       folder = TNY_FOLDER (tny_iterator_get_current (helper->iter));
-       if (folder) {
-               g_message ("modest: refreshing folder %s", tny_folder_get_name (folder));
-               tny_folder_refresh_async (folder, folder_refresh_cb,
-                                         status_update_cb, helper);
+               recurse_folders (folder, NULL, all_folders);
+               tny_iterator_next (iter);
        }
-       //g_object_unref (G_OBJECT(folder)); /* FIXME -==> don't unref yet... */
+       g_object_unref (G_OBJECT (iter));
+
+       /* Refresh folders */
+       iter = tny_list_create_iterator (all_folders);
+       priv->total = tny_list_get_length (all_folders);
+
+       while (!tny_iterator_is_done (iter) && !priv->error) {
+
+               TnyFolderStore *folder = TNY_FOLDER_STORE (tny_iterator_get_current (iter));
+
+               /* Refresh the folder */
+               tny_folder_refresh (TNY_FOLDER (folder), &(priv->error));
+
+               if (priv->error) {
+                       priv->status = MODEST_MAIL_OPERATION_STATUS_FAILED;
+               } else {        
+                       /* Update status and notify */
+                       priv->done++;
+                       g_signal_emit (G_OBJECT (self), signals[PROGRESS_CHANGED_SIGNAL], 0, NULL);
+               }
+    
+               g_object_unref (G_OBJECT (folder));
+           
+               tny_iterator_next (iter);
+       }
+
+       g_object_unref (G_OBJECT (iter));
+ out:
+       g_object_unref (G_OBJECT (list));
+
+       /* Check if the operation was a success */
+       if (priv->done == priv->total && !priv->error)
+               priv->status = MODEST_MAIL_OPERATION_STATUS_SUCCESS;
+
+       /* Free */
+       g_object_unref (G_OBJECT (folder_store));
+
+       /* Notify the queue */
+       modest_mail_operation_queue_remove (modest_runtime_get_mail_operation_queue (), self);
 }
 
 gboolean
@@ -522,25 +449,25 @@ modest_mail_operation_update_account (ModestMailOperation *self,
 {
        ModestMailOperationPrivate *priv;
        TnyList *folders;
-       TnyFolderStoreQuery *query;
 
        g_return_val_if_fail (MODEST_IS_MAIL_OPERATION (self), FALSE);
        g_return_val_if_fail (TNY_IS_STORE_ACCOUNT(store_account), FALSE);
 
+       /* Pick async call reference */
+       g_object_ref (store_account);
+
        priv = MODEST_MAIL_OPERATION_GET_PRIVATE(self);
 
+       priv->total = 0;
+       priv->done  = 0;
+       priv->status = MODEST_MAIL_OPERATION_STATUS_IN_PROGRESS;
+       
        /* Get subscribed folders & refresh them */
        folders = TNY_LIST (tny_simple_list_new ());
-       query = NULL; //tny_folder_store_query_new ();
 
-       /* FIXME: is this needed? */
-       tny_device_force_online (TNY_DEVICE(modest_runtime_get_device()));
-       
-       /* FIXME: let query be NULL: do it for all */ 
-       //tny_folder_store_query_add_item (query, NULL, TNY_FOLDER_STORE_QUERY_OPTION_SUBSCRIBED);
+       g_message ("tny_folder_store_get_folders_async");
        tny_folder_store_get_folders_async (TNY_FOLDER_STORE (store_account),
-                                           folders, update_folders_cb, query, self);
-       //g_object_unref (query); /* FIXME */
+                                           folders, update_folders_cb, NULL, self);
        
        return TRUE;
 }
@@ -634,25 +561,40 @@ modest_mail_operation_create_folder (ModestMailOperation *self,
                                     TnyFolderStore *parent,
                                     const gchar *name)
 {
+       ModestTnyFolderRules rules;
        ModestMailOperationPrivate *priv;
        TnyFolder *new_folder = NULL;
-       TnyStoreAccount *store_account;
+       gboolean can_create = FALSE;
 
        g_return_val_if_fail (TNY_IS_FOLDER_STORE (parent), NULL);
        g_return_val_if_fail (name, NULL);
 
        priv = MODEST_MAIL_OPERATION_GET_PRIVATE (self);
 
-       /* Create the folder */
-       new_folder = tny_folder_store_create_folder (parent, name, &(priv->error));
-       CHECK_EXCEPTION (priv, MODEST_MAIL_OPERATION_STATUS_FAILED, return NULL);
+       /* Check parent */
+       if (!TNY_IS_FOLDER (parent)) {
+               g_set_error (&(priv->error), MODEST_MAIL_OPERATION_ERROR,
+                            MODEST_MAIL_OPERATION_ERROR_BAD_PARAMETER,
+                            _("mail_in_ui_folder_create_error"));
+       } else {
+               /* Check folder rules */
+               rules = modest_tny_folder_get_rules (TNY_FOLDER (parent));
+               if (rules & MODEST_FOLDER_RULES_FOLDER_NON_WRITEABLE)
+                       g_set_error (&(priv->error), MODEST_MAIL_OPERATION_ERROR,
+                                    MODEST_MAIL_OPERATION_ERROR_FOLDER_RULES,
+                                    _("mail_in_ui_folder_create_error"));
+               else
+                       can_create = TRUE;              
+       }
+
+       if (can_create) {
+               /* Create the folder */
+               new_folder = tny_folder_store_create_folder (parent, name, &(priv->error));
+               CHECK_EXCEPTION (priv, MODEST_MAIL_OPERATION_STATUS_FAILED);
+       }
 
-/*     /\* Subscribe to folder *\/ */
-/*     if (!tny_folder_is_subscribed (new_folder)) { */
-/*             store_account = TNY_STORE_ACCOUNT (tny_folder_get_account (TNY_FOLDER (parent))); */
-/*             tny_store_account_subscribe (store_account, new_folder); */
-/*             g_object_unref (G_OBJECT (store_account)); */
-/*     } */
+       /* Notify the queue */
+       modest_mail_operation_queue_remove (modest_runtime_get_mail_operation_queue (), self);
 
        return new_folder;
 }
@@ -662,15 +604,24 @@ modest_mail_operation_remove_folder (ModestMailOperation *self,
                                     TnyFolder           *folder,
                                     gboolean             remove_to_trash)
 {
-       TnyFolderStore *parent;
        TnyAccount *account;
        ModestMailOperationPrivate *priv;
+       ModestTnyFolderRules rules;
 
        g_return_if_fail (MODEST_IS_MAIL_OPERATION (self));
        g_return_if_fail (TNY_IS_FOLDER (folder));
 
        priv = MODEST_MAIL_OPERATION_GET_PRIVATE (self);
 
+       /* Check folder rules */
+       rules = modest_tny_folder_get_rules (TNY_FOLDER (folder));
+       if (rules & MODEST_FOLDER_RULES_FOLDER_NON_DELETABLE) {
+               g_set_error (&(priv->error), MODEST_MAIL_OPERATION_ERROR,
+                            MODEST_MAIL_OPERATION_ERROR_FOLDER_RULES,
+                            _("mail_in_ui_folder_delete_error"));
+               goto end;
+       }
+
        /* Get the account */
        account = tny_folder_get_account (folder);
 
@@ -684,15 +635,19 @@ modest_mail_operation_remove_folder (ModestMailOperation *self,
                                                                TNY_FOLDER_STORE (trash_folder), TRUE);
                g_object_unref (G_OBJECT (new_folder));
        } else {
-               parent = tny_folder_get_folder_store (folder);
+               TnyFolderStore *parent = tny_folder_get_folder_store (folder);
 
                tny_folder_store_remove_folder (parent, folder, &(priv->error));
-               CHECK_EXCEPTION (priv, MODEST_MAIL_OPERATION_STATUS_FAILED, );
+               CHECK_EXCEPTION (priv, MODEST_MAIL_OPERATION_STATUS_FAILED);
 
                if (parent)
                        g_object_unref (G_OBJECT (parent));
        }
        g_object_unref (G_OBJECT (account));
+
+ end:
+       /* Notify the queue */
+       modest_mail_operation_queue_remove (modest_runtime_get_mail_operation_queue (), self);
 }
 
 void
@@ -701,6 +656,7 @@ modest_mail_operation_rename_folder (ModestMailOperation *self,
                                     const gchar *name)
 {
        ModestMailOperationPrivate *priv;
+       ModestTnyFolderRules rules;
 
        g_return_if_fail (MODEST_IS_MAIL_OPERATION (self));
        g_return_if_fail (TNY_IS_FOLDER_STORE (folder));
@@ -708,13 +664,20 @@ modest_mail_operation_rename_folder (ModestMailOperation *self,
 
        priv = MODEST_MAIL_OPERATION_GET_PRIVATE (self);
 
-       /* FIXME: better error handling */
-       if (strrchr (name, '/') != NULL)
-               return;
+       /* Check folder rules */
+       rules = modest_tny_folder_get_rules (TNY_FOLDER (folder));
+       if (rules & MODEST_FOLDER_RULES_FOLDER_NON_RENAMEABLE) {
+               g_set_error (&(priv->error), MODEST_MAIL_OPERATION_ERROR,
+                            MODEST_MAIL_OPERATION_ERROR_FOLDER_RULES,
+                            _("FIXME: unable to rename"));
+       } else {
+               /* Rename. Camel handles folder subscription/unsubscription */
+               tny_folder_set_name (folder, name, &(priv->error));
+               CHECK_EXCEPTION (priv, MODEST_MAIL_OPERATION_STATUS_FAILED);
+       }
 
-       /* Rename. Camel handles folder subscription/unsubscription */
-       tny_folder_set_name (folder, name, &(priv->error));
-       CHECK_EXCEPTION (priv, MODEST_MAIL_OPERATION_STATUS_FAILED, return);
+       /* Notify the queue */
+       modest_mail_operation_queue_remove (modest_runtime_get_mail_operation_queue (), self);
  }
 
 TnyFolder *
@@ -724,6 +687,8 @@ modest_mail_operation_xfer_folder (ModestMailOperation *self,
                                   gboolean delete_original)
 {
        ModestMailOperationPrivate *priv;
+       TnyFolder *new_folder = NULL;
+       ModestTnyFolderRules rules;
 
        g_return_val_if_fail (MODEST_IS_MAIL_OPERATION (self), NULL);
        g_return_val_if_fail (TNY_IS_FOLDER_STORE (parent), NULL);
@@ -731,11 +696,25 @@ modest_mail_operation_xfer_folder (ModestMailOperation *self,
 
        priv = MODEST_MAIL_OPERATION_GET_PRIVATE (self);
 
-       return tny_folder_copy (folder, 
-                               parent, 
-                               tny_folder_get_name (folder), 
-                               delete_original, 
-                               &(priv->error));
+       /* The moveable restriction is applied also to copy operation */
+       rules = modest_tny_folder_get_rules (TNY_FOLDER (parent));
+       if (rules & MODEST_FOLDER_RULES_FOLDER_NON_MOVEABLE) {
+               g_set_error (&(priv->error), MODEST_MAIL_OPERATION_ERROR,
+                            MODEST_MAIL_OPERATION_ERROR_FOLDER_RULES,
+                            _("FIXME: unable to rename"));
+       } else {
+               /* Move/Copy folder */
+               new_folder = tny_folder_copy (folder,
+                                             parent,
+                                             tny_folder_get_name (folder),
+                                             delete_original, 
+                                             &(priv->error));
+       }
+
+       /* Notify the queue */
+       modest_mail_operation_queue_remove (modest_runtime_get_mail_operation_queue (), self);
+
+       return new_folder;
 }
 
 
@@ -749,11 +728,16 @@ modest_mail_operation_remove_msg (ModestMailOperation *self,
                                  gboolean remove_to_trash)
 {
        TnyFolder *folder;
+       ModestMailOperationPrivate *priv;
 
+       g_return_if_fail (MODEST_IS_MAIL_OPERATION (self));
        g_return_if_fail (TNY_IS_HEADER (header));
 
+       priv = MODEST_MAIL_OPERATION_GET_PRIVATE (self);
        folder = tny_header_get_folder (header);
 
+       priv->status = MODEST_MAIL_OPERATION_STATUS_IN_PROGRESS;
+
        /* Delete or move to trash */
        if (remove_to_trash) {
                TnyFolder *trash_folder;
@@ -763,7 +747,16 @@ modest_mail_operation_remove_msg (ModestMailOperation *self,
                trash_folder = modest_tny_account_get_special_folder (TNY_ACCOUNT(store_account),
                                                                      TNY_FOLDER_TYPE_TRASH);
                if (trash_folder) {
-                       modest_mail_operation_xfer_msg (self, header, trash_folder, TRUE);
+                       TnyList *headers;
+
+                       /* Create list */
+                       headers = tny_simple_list_new ();
+                       tny_list_append (headers, G_OBJECT (header));
+                       g_object_unref (header);
+
+                       /* Move to trash */
+                       modest_mail_operation_xfer_msgs (self, headers, trash_folder, TRUE);
+                       g_object_unref (headers);
 /*                     g_object_unref (trash_folder); */
                } else {
                        ModestMailOperationPrivate *priv;
@@ -778,20 +771,34 @@ modest_mail_operation_remove_msg (ModestMailOperation *self,
 
                g_object_unref (G_OBJECT (store_account));
        } else {
-               tny_folder_remove_msg (folder, header, NULL); /* FIXME */
-               tny_folder_sync(folder, TRUE, NULL); /* FIXME */
+               tny_folder_remove_msg (folder, header, &(priv->error));
+               if (!priv->error)
+                       tny_folder_sync(folder, TRUE, &(priv->error));
        }
 
+       /* Set status */
+       if (!priv->error)
+               priv->status = MODEST_MAIL_OPERATION_STATUS_SUCCESS;
+       else
+               priv->status = MODEST_MAIL_OPERATION_STATUS_FAILED;
+
        /* Free */
-       g_object_unref (folder);
+       g_object_unref (G_OBJECT (folder));
+
+       /* Notify the queue */
+       modest_mail_operation_queue_remove (modest_runtime_get_mail_operation_queue (), self);
 }
 
 static void
 transfer_msgs_cb (TnyFolder *folder, GError **err, gpointer user_data)
 {
+       XFerMsgAsyncHelper *helper;
+       ModestMailOperation *self;
        ModestMailOperationPrivate *priv;
 
-       priv = MODEST_MAIL_OPERATION_GET_PRIVATE(user_data);
+       helper = (XFerMsgAsyncHelper *) user_data;
+       self = helper->mail_op;
+       priv = MODEST_MAIL_OPERATION_GET_PRIVATE (self);
 
        if (*err) {
                priv->error = g_error_copy (*err);
@@ -802,77 +809,147 @@ transfer_msgs_cb (TnyFolder *folder, GError **err, gpointer user_data)
                priv->status = MODEST_MAIL_OPERATION_STATUS_SUCCESS;
        }
 
-       g_signal_emit (G_OBJECT (user_data), signals[PROGRESS_CHANGED_SIGNAL], 0, NULL);
+       /* Free */
+       g_object_unref (helper->headers);
+       g_object_unref (helper->dest_folder);
+       g_object_unref (folder);
+       g_free (helper);
+
+       /* Notify the queue */
+       modest_mail_operation_queue_remove (modest_runtime_get_mail_operation_queue (), self);
 }
 
-gboolean
-modest_mail_operation_xfer_msg (ModestMailOperation *self,
-                               TnyHeader *header, 
-                               TnyFolder *folder, 
-                               gboolean delete_original)
+void
+modest_mail_operation_xfer_msgs (ModestMailOperation *self,
+                                TnyList *headers, 
+                                TnyFolder *folder, 
+                                gboolean delete_original)
 {
        ModestMailOperationPrivate *priv;
+       TnyIterator *iter;
        TnyFolder *src_folder;
-       TnyList *headers;
+       XFerMsgAsyncHelper *helper;
+       TnyHeader *header;
 
-       g_return_val_if_fail (MODEST_IS_MAIL_OPERATION (self), FALSE);
-       g_return_val_if_fail (TNY_IS_HEADER (header), FALSE);
-       g_return_val_if_fail (TNY_IS_FOLDER (folder), FALSE);
+       g_return_if_fail (MODEST_IS_MAIL_OPERATION (self));
+       g_return_if_fail (TNY_IS_LIST (headers));
+       g_return_if_fail (TNY_IS_FOLDER (folder));
 
-       src_folder = tny_header_get_folder (header);
-       headers = tny_simple_list_new ();
+       /* Pick references for async calls */
+       g_object_ref (folder);
 
        priv = MODEST_MAIL_OPERATION_GET_PRIVATE(self);
        priv->total = 1;
        priv->done = 0;
        priv->status = MODEST_MAIL_OPERATION_STATUS_IN_PROGRESS;
 
-       tny_list_prepend (headers, G_OBJECT (header));
-       tny_folder_transfer_msgs_async (src_folder, headers, folder, 
-                                       delete_original, transfer_msgs_cb, 
-                                       g_object_ref(self));
+       /* Create the helper */
+       helper = g_malloc0 (sizeof (XFerMsgAsyncHelper));
+       helper->mail_op = self;
+       helper->dest_folder = folder;
+       helper->headers = headers;
+
+       /* Get source folder */
+       iter = tny_list_create_iterator (headers);
+       header = TNY_HEADER (tny_iterator_get_current (iter));
+       src_folder = tny_header_get_folder (header);
+       g_object_unref (header);
+       g_object_unref (iter);
+
+       /* Transfer messages */
+       tny_folder_transfer_msgs_async (src_folder, 
+                                       headers, 
+                                       folder, 
+                                       delete_original, 
+                                       transfer_msgs_cb, 
+                                       helper);
+}
+
+static void
+on_refresh_folder (TnyFolder   *folder, 
+                  gboolean     cancelled, 
+                  GError     **error,
+                  gpointer     user_data)
+{
+       ModestMailOperation *self;
+       ModestMailOperationPrivate *priv;
+
+       self = MODEST_MAIL_OPERATION (user_data);
+       priv = MODEST_MAIL_OPERATION_GET_PRIVATE(self);
+
+       if (*error) {
+               priv->error = g_error_copy (*error);
+               priv->status = MODEST_MAIL_OPERATION_STATUS_FAILED;
+               goto out;
+       }
+
+       if (cancelled) {
+               priv->status = MODEST_MAIL_OPERATION_STATUS_CANCELED;
+               g_set_error (&(priv->error), MODEST_MAIL_OPERATION_ERROR,
+                            MODEST_MAIL_OPERATION_ERROR_ITEM_NOT_FOUND,
+                            _("Error trying to refresh the contents of %s"),
+                            tny_folder_get_name (folder));
+               goto out;
+       }
+
+       priv->status = MODEST_MAIL_OPERATION_STATUS_SUCCESS;
 
+ out:
        /* Free */
-       /* FIXME: don't free 'm yet */
-       ///g_object_unref (headers);
-       ///g_object_unref (src_folder);
+       g_object_unref (folder);
 
-       return TRUE;
+       /* Notify the queue */
+       modest_mail_operation_queue_remove (modest_runtime_get_mail_operation_queue (), self);
 }
 
+static void
+on_refresh_folder_status_update (GObject *obj,
+                                TnyStatus *status,  
+                                gpointer user_data)
+{
+       ModestMailOperation *self;
+       ModestMailOperationPrivate *priv;
 
-/* ******************************************************************* */
-/* ************************* UTILIY FUNCTIONS ************************ */
-/* ******************************************************************* */
+       g_return_if_fail (status != NULL);
+       g_return_if_fail (status->code == TNY_FOLDER_STATUS_CODE_REFRESH);
 
-static void
-add_attachments (TnyMsg *msg, GList *attachments_list)
-{
-       GList *pos;
-       TnyMimePart *attachment_part, *old_attachment;
-       const gchar *attachment_content_type;
-       const gchar *attachment_filename;
-       TnyStream *attachment_stream;
-
-       for (pos = (GList *)attachments_list; pos; pos = pos->next) {
-
-               old_attachment = pos->data;
-               attachment_filename = tny_mime_part_get_filename (old_attachment);
-               attachment_stream = tny_mime_part_get_stream (old_attachment);
-               attachment_part = tny_platform_factory_new_mime_part
-                       (modest_runtime_get_platform_factory());
-               
-               attachment_content_type = tny_mime_part_get_content_type (old_attachment);
-                                
-               tny_mime_part_construct_from_stream (attachment_part,
-                                                    attachment_stream,
-                                                    attachment_content_type);
-               tny_stream_reset (attachment_stream);
-               
-               tny_mime_part_set_filename (attachment_part, attachment_filename);
-               
-               tny_mime_part_add_part (TNY_MIME_PART (msg), attachment_part);
-/*             g_object_unref (attachment_part); */
-       }
+       self = MODEST_MAIL_OPERATION (user_data);
+       priv = MODEST_MAIL_OPERATION_GET_PRIVATE(self);
+
+       priv->done = status->position;
+       priv->total = status->of_total;
+
+       if (priv->done == 1 && priv->total == 100)
+               return;
+
+       g_signal_emit (G_OBJECT (self), signals[PROGRESS_CHANGED_SIGNAL], 0, NULL);
 }
 
+void 
+modest_mail_operation_refresh_folder  (ModestMailOperation *self,
+                                      TnyFolder *folder)
+{
+       ModestMailOperationPrivate *priv;
+
+       priv = MODEST_MAIL_OPERATION_GET_PRIVATE(self);
+
+       /* Pick a reference */
+       g_object_ref (folder);
+
+       priv->status = MODEST_MAIL_OPERATION_STATUS_IN_PROGRESS;
+
+       /* Refresh the folder. TODO: tinymail could issue a status
+          updates before the callback call then this could happen. We
+          must review the design */
+       tny_folder_refresh_async (folder,
+                                 on_refresh_folder,
+                                 on_refresh_folder_status_update,
+/*                               NULL, */
+                                 self);
+}
+
+void
+_modest_mail_operation_notify_end (ModestMailOperation *self)
+{
+       g_signal_emit (G_OBJECT (self), signals[PROGRESS_CHANGED_SIGNAL], 0, NULL);
+}