Merge branch 'fixtests'
[modest] / src / modest-text-utils.c
index aead8af..4ed9ca3 100644 (file)
@@ -145,8 +145,9 @@ static GSList*  get_url_matches         (GString *txt, gint offset);
 
 static GString* get_next_line           (const char *b, const gsize blen, const gchar * iter);
 static int      get_indent_level        (const char *l);
-static void     unquote_line            (GString * l);
-static void     append_quoted           (GString * buf, const int indent, const GString * str, 
+static void     unquote_line            (GString * l, const gchar *quote_symbol);
+static void     append_quoted           (GString * buf, const gchar *quote_symbol,
+                                        const int indent, const GString * str, 
                                         const int cutpoint);
 static int      get_breakpoint_utf8     (const gchar * s, const gint indent, const gint limit);
 static int      get_breakpoint_ascii    (const gchar * s, const gint indent, const gint limit);
@@ -212,14 +213,17 @@ modest_text_utils_cite (const gchar *text,
        g_return_val_if_fail (text, NULL);
        g_return_val_if_fail (content_type, NULL);
        
-       if (!signature)
-               retval = g_strdup ("");
-       else if (strcmp(content_type, "text/html") == 0) {
-               tmp_sig = g_strconcat ("\n", SIGNATURE_MARKER,"\n", signature, NULL);
-               retval = modest_text_utils_convert_to_html_body(tmp_sig, -1, TRUE);
+       if (!signature) {
+               tmp_sig = g_strdup (text);
+       } else {
+               tmp_sig = g_strconcat (text, "\n", SIGNATURE_MARKER, "\n", signature, NULL);
+       }
+
+       if (strcmp (content_type, "text/html") == 0) {
+               retval = modest_text_utils_convert_to_html_body (tmp_sig, -1, TRUE);
                g_free (tmp_sig);
        } else {
-               retval = g_strconcat (text, "\n", SIGNATURE_MARKER, "\n", signature, NULL);
+               retval = tmp_sig;
        }
 
        return retval;
@@ -612,6 +616,7 @@ modest_text_utils_split_addresses_list (const gchar *addresses)
        const gchar *my_addrs = addresses;
        const gchar *end;
        gchar *addr;
+       gboolean after_at = FALSE;
 
        g_return_val_if_fail (addresses, NULL);
        
@@ -626,11 +631,14 @@ modest_text_utils_split_addresses_list (const gchar *addresses)
        /* nope, we are at the start of some address
         * now, let's find the end of the address */
        end = my_addrs + 1;
-       while (end[0] && (end[0] != ';') && (end[0] != ',')) {
+       while (end[0] && end[0] != ';' && !(after_at && end[0] == ',')) {
                if (end[0] == '\"') {
                        while (end[0] && end[0] != '\"')
                                ++end;
                }
+               if (end[0] == '@') {
+                       after_at = TRUE;
+               }
                if ((end[0] && end[0] == '>')&&(end[1] && end[1] == ',')) {
                        ++end;
                        break;
@@ -766,15 +774,17 @@ get_indent_level (const char *l)
 }
 
 static void
-unquote_line (GString * l)
+unquote_line (GString * l, const gchar *quote_symbol)
 {
        gchar *p;
+       gint quote_len;
 
        p = l->str;
+       quote_len = strlen (quote_symbol);
        while (p[0]) {
-               if (p[0] == '>') {
-                       if (p[1] == ' ') {
-                               p++;
+               if (g_str_has_prefix (p, quote_symbol)) {
+                       if (p[quote_len] == ' ') {
+                               p += quote_len;
                        }
                } else {
                        break;
@@ -785,15 +795,19 @@ unquote_line (GString * l)
 }
 
 static void
-append_quoted (GString * buf, int indent, const GString * str,
+append_quoted (GString * buf, const gchar *quote_symbol,
+              int indent, const GString * str,
               const int cutpoint)
 {
        int i;
+       gchar *quote_concat;
 
        indent = indent < 0 ? abs (indent) - 1 : indent;
+       quote_concat = g_strconcat (quote_symbol, " ", NULL);
        for (i = 0; i <= indent; i++) {
-               g_string_append (buf, "> ");
+               g_string_append (buf, quote_concat);
        }
+       g_free (quote_concat);
        if (cutpoint > 0) {
                g_string_append_len (buf, str->str, cutpoint);
        } else {
@@ -882,40 +896,25 @@ quoted_attachments (GList *attachments)
 
 }
 
-static gchar *
-modest_text_utils_quote_plain_text (const gchar *text, 
-                                   const gchar *cite, 
-                                   const gchar *signature,
-                                   GList *attachments,
-                                   int limit)
+static GString *
+modest_text_utils_quote_body (GString *output, const gchar *text,
+                             const gchar *quote_symbol,
+                             int limit)
 {
+
        const gchar *iter;
-       gint indent, breakpoint, rem_indent = 0;
-       GString *q, *l, *remaining;
        gsize len;
-       gchar *attachments_string = NULL;
-
-       q = g_string_new ("");
-
-       if (signature != NULL) {
-               q = g_string_append (q, "\n--\n");
-               q = g_string_append (q, signature);
-       }
-
-       q = g_string_append (q, "\n");
-       q = g_string_append (q, cite);
-       q = g_string_append_c (q, '\n');
-
-       /* remaining will store the rest of the line if we have to break it */
-       remaining = g_string_new ("");
+       gint indent, breakpoint, rem_indent = 0;
+       GString *l, *remaining;
 
        iter = text;
        len = strlen(text);
+       remaining = g_string_new ("");
        do {
                l = get_next_line (text, len, iter);
                iter = iter + l->len + 1;
                indent = get_indent_level (l->str);
-               unquote_line (l);
+               unquote_line (l, quote_symbol);
 
                if (remaining->len) {
                        if (l->len && indent == rem_indent) {
@@ -927,7 +926,7 @@ modest_text_utils_quote_plain_text (const gchar *text,
                                                get_breakpoint (remaining->str,
                                                                rem_indent,
                                                                limit);
-                                       append_quoted (q, rem_indent,
+                                       append_quoted (output, quote_symbol, rem_indent,
                                                       remaining, breakpoint);
                                        g_string_erase (remaining, 0,
                                                        breakpoint);
@@ -945,10 +944,36 @@ modest_text_utils_quote_plain_text (const gchar *text,
                        g_string_erase (remaining, 0, 1);
                }
                rem_indent = indent;
-               append_quoted (q, indent, l, breakpoint);
+               append_quoted (output, quote_symbol, indent, l, breakpoint);
                g_string_free (l, TRUE);
        } while ((iter < text + len) || (remaining->str[0]));
 
+       return output;
+}
+
+static gchar *
+modest_text_utils_quote_plain_text (const gchar *text, 
+                                   const gchar *cite, 
+                                   const gchar *signature,
+                                   GList *attachments,
+                                   int limit)
+{
+       GString *q;
+       gchar *attachments_string = NULL;
+
+       q = g_string_new ("");
+
+       if (signature != NULL) {
+               q = g_string_append (q, "\n--\n");
+               q = g_string_append (q, signature);
+       }
+
+       q = g_string_append (q, "\n");
+       q = g_string_append (q, cite);
+       q = g_string_append_c (q, '\n');
+
+       q = modest_text_utils_quote_body (q, text, ">", limit);
+
        attachments_string = quoted_attachments (attachments);
        q = g_string_append (q, attachments_string);
        g_free (attachments_string);
@@ -983,13 +1008,17 @@ modest_text_utils_quote_html (const gchar *text,
                              "<body>\n<br/>\n");
 
        if (text || cite || signature) {
+               GString *quoted_text;
                g_string_append (result_string, "<pre>\n");
                if (signature) {
                        quote_html_add_to_gstring (result_string, SIGNATURE_MARKER);
                        quote_html_add_to_gstring (result_string, signature);
                }
                quote_html_add_to_gstring (result_string, cite);
-               quote_html_add_to_gstring (result_string, text);
+               quoted_text = g_string_new ("");
+               quoted_text = modest_text_utils_quote_body (quoted_text, text, ">", limit);
+               quote_html_add_to_gstring (result_string, quoted_text->str);
+               g_string_free (quoted_text, TRUE);
                if (attachments) {
                        gchar *attachments_string = quoted_attachments (attachments);
                        quote_html_add_to_gstring (result_string, attachments_string);
@@ -1221,14 +1250,16 @@ modest_text_utils_get_display_address (gchar *address)
                
        for (i = 0; address[i]; ++i) {
                if (address[i] == '<') {
-                       if (G_UNLIKELY(i == 0))
-                               return; /* there's nothing else, leave it */
-                       else {
+                       if (G_UNLIKELY(i == 0)) {
+                               break; /* there's nothing else, leave it */
+                       }else {
                                address[i] = '\0'; /* terminate the string here */
-                               return;
+                               break;
                        }
                }
        }
+
+       g_strchomp (address);
 }
 
 
@@ -1629,8 +1660,10 @@ modest_text_utils_get_display_size (guint64 size)
        const guint MB=1024 * KB;
        const guint GB=1024 * MB;
 
+       if (size == 0)
+               return g_strdup_printf (_FM("sfil_li_size_kb"));
        if (0 <= size && size < KB)
-               return g_strdup_printf (_FM("sfil_li_size_kb"), 1);
+               return g_strdup_printf (_FM("sfil_li_size_1kb_99kb"), 1);
        else if (KB <= size && size < 100 * KB)
                return g_strdup_printf (_FM("sfil_li_size_1kb_99kb"), size / KB);
        else if (100*KB <= size && size < MB)