Patch to compile Modest with the most recent changes
[modest] / src / modest-tny-account-store.c
index a1c1f3d..2bdb4eb 100644 (file)
@@ -50,9 +50,8 @@
 #include <modest-account-mgr.h>
 #include <modest-account-mgr-helpers.h>
 #include <widgets/modest-window-mgr.h>
-#include <modest-account-settings-dialog.h>
-#include <maemo/modest-maemo-utils.h>
 #include <modest-signal-mgr.h>
+#include <modest-debug.h>
 
 #include "modest-tny-account-store.h"
 #include "modest-tny-platform-factory.h"
@@ -62,6 +61,8 @@
 
 #ifdef MODEST_PLATFORM_MAEMO
 #include <tny-maemo-conic-device.h>
+#include <maemo/modest-maemo-utils.h>
+#include <maemo/modest-account-settings-dialog.h>
 #endif
 
 #include <libgnomevfs/gnome-vfs-volume-monitor.h>
@@ -120,7 +121,9 @@ typedef struct _ModestTnyAccountStorePrivate ModestTnyAccountStorePrivate;
 struct _ModestTnyAccountStorePrivate {
        gchar              *cache_dir;  
        GHashTable         *password_hash;
+#ifdef MODEST_PLATFORM_MAEMO
        GHashTable         *account_settings_dialog_hash;
+#endif
        ModestAccountMgr   *account_mgr;
        TnySessionCamel    *session;
        TnyDevice          *device;
@@ -213,15 +216,6 @@ modest_tny_account_store_base_init (gpointer g_class)
                                      NULL, NULL,
                                      g_cclosure_marshal_VOID__OBJECT,
                                      G_TYPE_NONE, 1, TNY_TYPE_ACCOUNT);
-               
-/*             signals[TNY_ACCOUNT_STORE_CONNECTING_FINISHED] = */
-/*                     g_signal_new ("connecting_finished", */
-/*                                   TNY_TYPE_ACCOUNT_STORE, */
-/*                                   G_SIGNAL_RUN_FIRST, */
-/*                                   G_STRUCT_OFFSET (TnyAccountStoreIface, connecting_finished), */
-/*                                   NULL, NULL, */
-/*                                   g_cclosure_marshal_VOID__VOID,  */
-/*                                   G_TYPE_NONE, 0); */
 
                signals[PASSWORD_REQUESTED_SIGNAL] =
                        g_signal_new ("password_requested",
@@ -276,11 +270,13 @@ modest_tny_account_store_instance_init (ModestTnyAccountStore *obj)
          */
        priv->password_hash = g_hash_table_new_full (g_str_hash, g_str_equal,
                                                     g_free, g_free);
-                                                            
+
+#ifdef MODEST_PLATFORM_MAEMO                                                        
        /* A hash-map of modest account names to dialog pointers,
         * so we can avoid showing the account settings twice for the same modest account: */                                 
        priv->account_settings_dialog_hash = g_hash_table_new_full (g_str_hash, g_str_equal, 
                                                                    g_free, NULL);
+#endif
        
        /* Respond to volume mounts and unmounts, such 
         * as the insertion/removal of the memory card: */
@@ -300,19 +296,35 @@ modest_tny_account_store_instance_init (ModestTnyAccountStore *obj)
 
 /* disconnect the list of TnyAccounts */
 static void
-foreach_account_disconnect (gpointer data, 
-                           gpointer user_data)
+account_disconnect (TnyAccount *account)
+{
+       g_return_if_fail (account && TNY_IS_ACCOUNT(account));
+       tny_camel_account_set_online (TNY_CAMEL_ACCOUNT(account), FALSE, NULL, NULL);
+}
+
+
+/* disconnect the list of TnyAccounts */
+static void
+account_verify_last_ref (TnyAccount *account, const gchar *str)
 {
-       tny_camel_account_set_online (TNY_CAMEL_ACCOUNT(data), FALSE, NULL, NULL);
+       gchar *txt;
+
+       g_return_if_fail (account && TNY_IS_ACCOUNT(account));
+
+       txt = g_strdup_printf ("%s: %s", str ? str : "?", tny_account_get_name(account));
+       MODEST_DEBUG_VERIFY_OBJECT_LAST_REF(G_OBJECT(account),txt);
+       g_free (txt);
 }
 
 
+
+
 static void
 foreach_account_append_to_list (gpointer data, 
                                gpointer user_data)
 {
        TnyList *list;
-
+       
        list = TNY_LIST (user_data);
        tny_list_append (list, G_OBJECT (data));
 }
@@ -405,7 +417,7 @@ on_vfs_volume_unmounted(GnomeVFSVolumeMonitor *volume_monitor,
                if (found) {
                        /* Remove from the list */
                        tny_list_remove (priv->store_accounts, G_OBJECT (mmc_account));
-                      
+                       
                        /* Notify observers */
                        g_signal_emit (G_OBJECT (self),
                                       signals [ACCOUNT_REMOVED_SIGNAL],
@@ -461,15 +473,10 @@ on_account_changed (ModestAccountMgr *acc_mgr,
                TnyAccount *tny_account;
                tny_account = TNY_ACCOUNT (tny_iterator_get_current (iter));
                if (tny_account) {
-                       TnyConnectionStatus conn_status = tny_account_get_connection_status (tny_account);
-
-                       if (conn_status != TNY_CONNECTION_STATUS_RECONNECTING &&
-                           conn_status != TNY_CONNECTION_STATUS_INIT) {
-                               if (!strcmp (tny_account_get_id (tny_account), account_name)) {
-                                       found = TRUE;
-                                       modest_tny_account_update_from_account (tny_account);
-                                       g_signal_emit (G_OBJECT(self), signals[ACCOUNT_CHANGED_SIGNAL], 0, tny_account);
-                               }
+                       if (!strcmp (tny_account_get_id (tny_account), account_name)) {
+                               found = TRUE;
+                               modest_tny_account_update_from_account (tny_account);
+                               g_signal_emit (G_OBJECT(self), signals[ACCOUNT_CHANGED_SIGNAL], 0, tny_account);
                        }
                        g_object_unref (tny_account);
                }
@@ -480,6 +487,7 @@ on_account_changed (ModestAccountMgr *acc_mgr,
                g_object_unref (iter);
 }
 
+#ifdef MODEST_PLATFORM_MAEMO
 static void 
 on_account_settings_hide (GtkWidget *widget, gpointer user_data)
 {
@@ -494,27 +502,40 @@ on_account_settings_hide (GtkWidget *widget, gpointer user_data)
        if (modest_account_name)
                g_hash_table_remove (priv->account_settings_dialog_hash, modest_account_name);
 }
+#endif
 
 static void 
 show_password_warning_only ()
 {
        ModestWindow *main_window = 
-                               modest_window_mgr_get_main_window (modest_runtime_get_window_mgr ());
-                               
+               modest_window_mgr_get_main_window (modest_runtime_get_window_mgr (), FALSE); /* don't create */
+       
        /* Show an explanatory temporary banner: */
-       hildon_banner_show_information ( 
-               GTK_WIDGET(main_window), NULL, _("mcen_ib_username_pw_incorrect"));
+       if (main_window) 
+               modest_platform_information_banner (GTK_WIDGET(main_window), NULL, 
+                                                   _("mcen_ib_username_pw_incorrect"));
+       else
+               g_warning ("%s: %s", __FUNCTION__, _("mcen_ib_username_pw_incorrect"));
 }
-               
+
+#ifdef MODEST_PLATFORM_MAEMO
 static void 
 show_wrong_password_dialog (TnyAccount *account)
 { 
        /* This is easier than using a struct for the user_data: */
        ModestTnyAccountStore *self = modest_runtime_get_account_store();
        ModestTnyAccountStorePrivate *priv = MODEST_TNY_ACCOUNT_STORE_GET_PRIVATE(self);
-       
-       const gchar *modest_account_name = 
-                       modest_tny_account_get_parent_modest_account_name_for_server_account (account);
+       ModestWindow *main_window;
+       const gchar *modest_account_name;
+
+       main_window = modest_window_mgr_get_main_window (modest_runtime_get_window_mgr (),
+                                                        FALSE); /* don't create */
+       if (!main_window) {
+               g_warning ("%s: password was wrong; ignoring because no main window", __FUNCTION__);
+               return;
+       }
+
+       modest_account_name = modest_tny_account_get_parent_modest_account_name_for_server_account (account);
        if (!modest_account_name) {
                g_warning ("%s: modest_tny_account_get_parent_modest_account_name_for_server_account() failed.\n", 
                        __FUNCTION__);
@@ -531,13 +552,13 @@ show_wrong_password_dialog (TnyAccount *account)
        }
        ModestAccountSettingsDialog *dialog = dialog_as_gpointer;
                                        
-       ModestWindow *main_window = 
-                               modest_window_mgr_get_main_window (modest_runtime_get_window_mgr ());
-
        gboolean created_dialog = FALSE;
        if (!found || !dialog) {
+               ModestAccountSettings *settings;
                dialog = modest_account_settings_dialog_new ();
-               modest_account_settings_dialog_set_account_name (dialog, modest_account_name);
+               settings = modest_account_mgr_load_account_settings (priv->account_mgr, modest_account_name);
+               modest_account_settings_dialog_set_account (dialog, settings);
+               g_object_unref (settings);
                modest_account_settings_dialog_switch_to_user_info (dialog);
                modest_window_mgr_set_modal (modest_runtime_get_window_mgr (), GTK_WINDOW (dialog));
                
@@ -547,7 +568,7 @@ show_wrong_password_dialog (TnyAccount *account)
        }
        
        /* Show an explanatory temporary banner: */
-       hildon_banner_show_information (GTK_WIDGET(dialog), NULL, _("mcen_ib_username_pw_incorrect"));
+       modest_platform_information_banner (GTK_WIDGET(dialog), NULL, _("mcen_ib_username_pw_incorrect"));
                
        if (created_dialog) {
                /* Forget it when it closes: */
@@ -555,7 +576,12 @@ show_wrong_password_dialog (TnyAccount *account)
                        account, 0);
                        
                /* Show it and delete it when it closes: */
-               modest_maemo_show_dialog_and_forget (GTK_WINDOW (main_window), GTK_DIALOG (dialog));
+               gtk_window_set_transient_for (GTK_WINDOW (dialog), GTK_WINDOW (main_window));
+               g_signal_connect_swapped (dialog, 
+                                         "response", 
+                                         G_CALLBACK (gtk_widget_destroy), 
+                                         dialog);
+               gtk_widget_show (GTK_WIDGET (dialog));
        }
        else {
                /* Just show it instead of showing it and deleting it when it closes,
@@ -563,21 +589,7 @@ show_wrong_password_dialog (TnyAccount *account)
                gtk_window_present (GTK_WINDOW (dialog));
        }
 }
-
-
-
-static void
-request_password_and_wait (ModestTnyAccountStore *account_store, 
-                                        const gchar* server_account_id,
-                                        gchar **username,
-                                        gchar **password,
-                                        gboolean *cancel, 
-                                        gboolean *remember)
-{
-                       g_signal_emit (G_OBJECT(account_store), signals[PASSWORD_REQUESTED_SIGNAL], 0,
-                              server_account_id, /* server_account_name */
-                              username, password, cancel, remember);
-}
+#endif
 
 /* This callback will be called by Tinymail when it needs the password
  * from the user or the account settings.
@@ -590,12 +602,7 @@ get_password (TnyAccount *account, const gchar * prompt_not_used, gboolean *canc
        /* TODO: Settting cancel to FALSE does not actually cancel everything.
         * We still get multiple requests afterwards, so we end up showing the 
         * same dialogs repeatedly.
-        */
-        
-       printf ("DEBUG: modest: %s: prompt (not shown) = %s\n", __FUNCTION__, prompt_not_used);
-         
-       g_return_val_if_fail (account, NULL);
-         
+        */       
        const TnyAccountStore *account_store = NULL;
        ModestTnyAccountStore *self = NULL;
        ModestTnyAccountStorePrivate *priv;
@@ -604,6 +611,12 @@ get_password (TnyAccount *account, const gchar * prompt_not_used, gboolean *canc
        gpointer pwd_ptr = NULL;
        gboolean already_asked = FALSE;
 
+       g_return_val_if_fail (account, NULL);
+       
+       MODEST_DEBUG_BLOCK(
+               g_debug ("%s: prompt (not shown) = %s\n", __FUNCTION__, prompt_not_used);
+       );
+       
        /* Initialize the output parameter: */
        if (cancel)
                *cancel = FALSE;
@@ -633,9 +646,10 @@ get_password (TnyAccount *account, const gchar * prompt_not_used, gboolean *canc
                                                      server_account_name,
                                                      NULL,
                                                      (gpointer*)&pwd_ptr);
-                                                     
-       printf ("DEBUG: modest: %s: Already asked = %d\n", __FUNCTION__, already_asked);
-
+       MODEST_DEBUG_BLOCK(
+               g_debug ("%s: Already asked = %d\n", __FUNCTION__, already_asked);
+       );
+               
        /* If the password is not already there, try ModestConf */
        if (!already_asked) {
                pwd  = modest_account_mgr_get_server_account_password (priv->account_mgr,
@@ -651,10 +665,15 @@ get_password (TnyAccount *account, const gchar * prompt_not_used, gboolean *canc
                 */
                const gboolean settings_have_password = 
                        modest_account_mgr_get_server_account_has_password (priv->account_mgr, server_account_name);
-               printf ("DEBUG: modest: %s: settings_have_password=%d\n", __FUNCTION__, settings_have_password);
+               MODEST_DEBUG_BLOCK(
+                       printf ("%s: settings_have_password=%d\n",
+                               __FUNCTION__, settings_have_password);
+               );
                if (settings_have_password) {
                        /* The password must be wrong, so show the account settings dialog so it can be corrected: */
+#ifdef MODEST_PLATFORM_MAEMO
                        show_wrong_password_dialog (account);
+#endif
                        
                        if (cancel)
                                *cancel = TRUE;
@@ -671,9 +690,12 @@ get_password (TnyAccount *account, const gchar * prompt_not_used, gboolean *canc
                        /* Show an info banner, before we show the protected password dialog: */
                        show_password_warning_only();
                }
-               
-               request_password_and_wait (self, account_id, 
+
+               /* Request password */
+               g_signal_emit (G_OBJECT(account_store), signals[PASSWORD_REQUESTED_SIGNAL], 0,
+                              account_id, /* server_account_name */
                               &username, &pwd, cancel, &remember);
+
                
                if (!*cancel) {
                        /* The password will be returned as the result,
@@ -699,10 +721,8 @@ get_password (TnyAccount *account, const gchar * prompt_not_used, gboolean *canc
                g_free (username);
                username = NULL;
        } else
-               *cancel = FALSE;
-    /* printf("  DEBUG: %s: returning %s\n", __FUNCTION__, pwd); */
-       
+               if (cancel)
+                       *cancel = FALSE;        
        return pwd;
 }
 
@@ -743,7 +763,6 @@ modest_tny_account_store_forget_already_asked (ModestTnyAccountStore *self, TnyA
 static void
 forget_password (TnyAccount *account)
 {
-       printf ("DEBUG: %s\n", __FUNCTION__);
        ModestTnyAccountStore *self;
        ModestTnyAccountStorePrivate *priv;
        const TnyAccountStore *account_store;
@@ -785,10 +804,12 @@ modest_tny_account_store_finalize (GObject *obj)
                priv->password_hash = NULL;
        }
 
+#ifdef MODEST_PLATFORM_MAEMO
        if (priv->account_settings_dialog_hash) {
                g_hash_table_destroy (priv->account_settings_dialog_hash);
                priv->account_settings_dialog_hash = NULL;
        }
+#endif
 
        if (priv->outbox_of_transport) {
                g_hash_table_destroy (priv->outbox_of_transport);
@@ -810,13 +831,15 @@ modest_tny_account_store_finalize (GObject *obj)
 
        /* Destroy all accounts. Disconnect all accounts before they are destroyed */
        if (priv->store_accounts) {
-               tny_list_foreach (priv->store_accounts, foreach_account_disconnect, NULL);
+               tny_list_foreach (priv->store_accounts, (GFunc)account_disconnect, NULL);
+               tny_list_foreach (priv->store_accounts, (GFunc)account_verify_last_ref, "store");
                g_object_unref (priv->store_accounts);
                priv->store_accounts = NULL;
        }
-
+       
        if (priv->transport_accounts) {
-               tny_list_foreach (priv->transport_accounts, foreach_account_disconnect, NULL);
+               tny_list_foreach (priv->transport_accounts, (GFunc)account_disconnect, NULL);
+               tny_list_foreach (priv->transport_accounts, (GFunc)account_verify_last_ref, "transport");
                g_object_unref (priv->transport_accounts);
                priv->transport_accounts = NULL;
        }
@@ -948,7 +971,7 @@ modest_tny_account_store_new (ModestAccountMgr *account_mgr,
           it will return NULL because there is no outbox folder for
           this specific transport accounts, and it's a must that the
           send queue returns an outbox */
-       if (FALSE)
+       if (TRUE)
                /* Add connection-specific transport accounts */
                add_connection_specific_transport_accounts (MODEST_TNY_ACCOUNT_STORE(obj));
        
@@ -1017,8 +1040,8 @@ modest_tny_account_store_get_device (TnyAccountStore *self)
        g_return_val_if_fail (self, NULL);
        
        priv = MODEST_TNY_ACCOUNT_STORE_GET_PRIVATE(self);
-
-       if (priv->device)
+       
+       if (priv->device) 
                return g_object_ref (G_OBJECT(priv->device));
        else
                return NULL;
@@ -1052,9 +1075,6 @@ modest_tny_account_store_alert (TnyAccountStore *self,
        g_return_val_if_fail (account, FALSE);
        g_return_val_if_fail (error, FALSE);
        
-       if ((error->domain != TNY_ACCOUNT_ERROR) && (error->domain != TNY_ACCOUNT_STORE_ERROR))
-               return FALSE;
-       
        /* Get the server name: */
        server_name = tny_account_get_hostname (account);
 
@@ -1070,14 +1090,18 @@ modest_tny_account_store_alert (TnyAccountStore *self,
        }
 
        switch (error->code) {
-       case TNY_ACCOUNT_STORE_ERROR_CANCEL_ALERT:
-       case TNY_ACCOUNT_ERROR_TRY_CONNECT_USER_CANCEL:
+       case TNY_SYSTEM_ERROR_CANCEL:
                /* Don't show waste the user's time by showing him a dialog telling 
                 * him that he has just cancelled something: */
                return TRUE;
 
-       case TNY_ACCOUNT_ERROR_TRY_CONNECT_HOST_LOOKUP_FAILED:
-       case TNY_ACCOUNT_ERROR_TRY_CONNECT_SERVICE_UNAVAILABLE:
+       case TNY_SERVICE_ERROR_PROTOCOL:
+               /* Like a BAD from IMAP (protocol error) */
+       case TNY_SERVICE_ERROR_LOST_CONNECTION:
+               /* Lost the connection with the service */
+       case TNY_SERVICE_ERROR_UNAVAILABLE:
+               /* You must be working online for this operation */
+       case TNY_SERVICE_ERROR_CONNECT:
                /* TODO: Show the appropriate message, depending on whether it's POP or IMAP: */                
                switch (proto) {
                case MODEST_PROTOCOL_STORE_POP:
@@ -1097,32 +1121,27 @@ modest_tny_account_store_alert (TnyAccountStore *self,
                }
                break;
                
-       case TNY_ACCOUNT_ERROR_TRY_CONNECT_AUTHENTICATION_NOT_SUPPORTED:
+       case TNY_SERVICE_ERROR_AUTHENTICATE:
                /* This is "Secure connection failed", even though the logical
                 * ID has _certificate_ in the name: */
                prompt = g_strdup (_("mail_ni_ssl_certificate_error")); 
                break;
                        
-       case TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE:
+       case TNY_SERVICE_ERROR_CERTIFICATE:
                /* We'll show the proper dialog later */
                break;
-               
-       case TNY_ACCOUNT_ERROR_TRY_CONNECT:
-               /* The tinymail camel implementation just sends us this for almost 
-                * everything, so we have to guess at the cause.
-                * It could be a wrong password, or inability to resolve a hostname, 
-                * or lack of network, or incorrect authentication method, or something entirely different: */
-               /* TODO: Fix camel to provide specific error codes, and then use the 
-                * specific dialog messages from Chapter 12 of the UI spec.
-                */
-       case TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT: 
+
+       case TNY_SYSTEM_ERROR_MEMORY:
+               /* Can't allocate memory for this operation */
+
+       case TNY_SERVICE_ERROR_UNKNOWN: 
                return FALSE;                   
        default:
                g_return_val_if_reached (FALSE);
        }
        
 
-       if (error->code == TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE)
+       if (error->code == TNY_SERVICE_ERROR_CERTIFICATE)
                retval = modest_platform_run_certificate_confirmation_dialog (server_name,
                                                                              error->message);
        else
@@ -1180,6 +1199,8 @@ get_tny_account_by (TnyList *accounts,
        gboolean found = FALSE;
        TnyAccount *retval = NULL;
 
+       g_return_val_if_fail (accounts && TNY_IS_LIST(accounts), NULL);
+
        iter = tny_list_create_iterator (accounts);
        while (!tny_iterator_is_done (iter) && !found) {
                TnyAccount *tmp_account = NULL;
@@ -1251,6 +1272,7 @@ modest_tny_account_store_get_tny_account_by (ModestTnyAccountStore *self,
        return account;
 }
 
+
 TnyAccount*
 modest_tny_account_store_get_server_account (ModestTnyAccountStore *self,
                                             const gchar *account_name,
@@ -1291,7 +1313,7 @@ modest_tny_account_store_get_server_account (ModestTnyAccountStore *self,
                modest_acc_name = 
                        modest_tny_account_get_parent_modest_account_name_for_server_account (tmp_account);
                
-               if (!strcmp (account_name, modest_acc_name)) {
+               if (account_name && modest_acc_name && !strcmp (account_name, modest_acc_name)) {
                        found = TRUE;
                        retval = g_object_ref (tmp_account);
                }
@@ -1311,21 +1333,24 @@ modest_tny_account_store_get_server_account (ModestTnyAccountStore *self,
        return retval;
 }
 
-static TnyAccount*
-get_smtp_specific_transport_account_for_open_connection (ModestTnyAccountStore *self,
-       const gchar *account_name)
+TnyAccount*
+modest_tny_account_store_get_smtp_specific_transport_account_for_open_connection (ModestTnyAccountStore *self,
+                                                                                 const gchar *account_name)
 {
+       TnyDevice *device;
+
+       g_return_val_if_fail (self && MODEST_IS_TNY_ACCOUNT_STORE(self), NULL);
+       g_return_val_if_fail (account_name, NULL);
+
        /* Get the current connection: */
-       TnyDevice *device = modest_runtime_get_device ();
+       device = modest_runtime_get_device ();
        
        if (!tny_device_is_online (device))
                return NULL;
-
-       g_return_val_if_fail (self, NULL);
        
+#ifdef MODEST_HAVE_CONIC
+       g_return_val_if_fail (TNY_IS_MAEMO_CONIC_DEVICE (device), NULL);
        
-#ifdef MODEST_PLATFORM_MAEMO
-       g_assert (TNY_IS_MAEMO_CONIC_DEVICE (device));
        TnyMaemoConicDevice *maemo_device = TNY_MAEMO_CONIC_DEVICE (device);    
        const gchar* iap_id = tny_maemo_conic_device_get_current_iap_id (maemo_device);
        /* printf ("DEBUG: %s: iap_id=%s\n", __FUNCTION__, iap_id); */
@@ -1336,9 +1361,9 @@ get_smtp_specific_transport_account_for_open_connection (ModestTnyAccountStore *
        if (!connection)
                return NULL;
                
-       const gchar *connection_name = con_ic_iap_get_name (connection);
-       /* printf ("DEBUG: %s: connection_name=%s\n", __FUNCTION__, connection_name); */
-       if (!connection_name)
+       const gchar *connection_id = con_ic_iap_get_id (connection);
+       /* printf ("DEBUG: %s: connection_id=%s\n", __FUNCTION__, connection_id); */
+       if (!connection_id)
                return NULL;
        
        /*  Get the connection-specific transport acccount, if any: */
@@ -1350,7 +1375,7 @@ get_smtp_specific_transport_account_for_open_connection (ModestTnyAccountStore *
        }
 
        gchar* server_account_name = modest_account_mgr_get_connection_specific_smtp (account_manager, 
-               connection_name);
+               connection_id);
 
        /* printf ("DEBUG: %s: server_account_name=%s\n", __FUNCTION__, server_account_name); */
        if (!server_account_name) {
@@ -1370,7 +1395,7 @@ get_smtp_specific_transport_account_for_open_connection (ModestTnyAccountStore *
        return account;
 #else
        return NULL; /* TODO: Implement this for GNOME, instead of just Maemo? */
-#endif /* MODEST_PLATFORM_MAEMO */
+#endif /* MODEST_HAVE_CONIC */
 }
 
                                                                 
@@ -1387,7 +1412,7 @@ modest_tny_account_store_get_transport_account_for_open_connection (ModestTnyAcc
        /*  Get the connection-specific transport acccount, if any: */
        /* Note: This gives us a reference: */
        TnyAccount *account =
-               get_smtp_specific_transport_account_for_open_connection (self, account_name);
+               modest_tny_account_store_get_smtp_specific_transport_account_for_open_connection (self, account_name);
                        
        /* If there is no connection-specific transport account (the common case), 
         * just get the regular transport account: */
@@ -1523,8 +1548,11 @@ add_outbox_from_transport_account_to_global_outbox (ModestTnyAccountStore *self,
        /* Get the outbox folder */
        folders = tny_simple_list_new ();
        tny_folder_store_get_folders (TNY_FOLDER_STORE (account_outbox), folders, NULL, NULL);
-       g_assert (tny_list_get_length (folders) == 1);
-               
+       if (tny_list_get_length (folders) != 1) {
+               g_warning ("%s: > 1 outbox found (%d)?!", __FUNCTION__,
+                          tny_list_get_length (folders));
+       }
+                       
        iter_folders = tny_list_create_iterator (folders);
        per_account_outbox = TNY_FOLDER (tny_iterator_get_current (iter_folders));
        g_object_unref (iter_folders);
@@ -1564,15 +1592,22 @@ insert_account (ModestTnyAccountStore *self,
 
        /* Get the server and the transport account */
        store_account = create_tny_account (self, account, TNY_ACCOUNT_TYPE_STORE);
-       transport_account = create_tny_account (self, account, TNY_ACCOUNT_TYPE_TRANSPORT);
+       if (!store_account || !TNY_IS_ACCOUNT(store_account)) {
+               g_warning ("%s: failed to create store account", __FUNCTION__);
+               return;
+       }
 
-       g_assert (store_account);
-       g_assert (transport_account);
+       transport_account = create_tny_account (self, account, TNY_ACCOUNT_TYPE_TRANSPORT);
+       if (!transport_account || !TNY_IS_ACCOUNT(transport_account)) {
+               g_warning ("%s: failed to create transport account", __FUNCTION__);
+               g_object_unref (store_account);
+               return;
+       }
 
        /* Add accounts to the lists */
        tny_list_append (priv->store_accounts, G_OBJECT (store_account));
        tny_list_append (priv->transport_accounts, G_OBJECT (transport_account));
-
+       
        /* Create a new pseudo-account with an outbox for this
           transport account and add it to the global outbox
           in the local account */
@@ -1607,29 +1642,64 @@ on_account_inserted (ModestAccountMgr *acc_mgr,
        insert_account (MODEST_TNY_ACCOUNT_STORE (user_data), account, TRUE);
 }
 
+/* This is the callback of the tny_camel_account_set_online called in
+   on_account_removed to disconnect the account */
+static void
+on_account_disconnect_when_removing (TnyCamelAccount *account, 
+                                    gboolean canceled, 
+                                    GError *err, 
+                                    gpointer user_data)
+{
+       ModestTnyAccountStore *self;
+       ModestTnyAccountStorePrivate *priv;
+
+       self = MODEST_TNY_ACCOUNT_STORE (user_data);
+       priv = MODEST_TNY_ACCOUNT_STORE_GET_PRIVATE (self);
+
+       /* Remove it from the list of accounts */
+       if (TNY_IS_STORE_ACCOUNT (account))
+               tny_list_remove (priv->store_accounts, (GObject *) account);
+       else
+               tny_list_remove (priv->transport_accounts, (GObject *) account);
+
+       /* Notify the observers */
+       g_signal_emit (G_OBJECT (self), signals [ACCOUNT_REMOVED_SIGNAL], 
+                      0, account);
+       
+       /* Unref the extra reference added by get_server_account */
+       g_object_unref (account);
+
+       /* Clear the cache if it's an store account */
+       if (TNY_IS_STORE_ACCOUNT (account))
+               tny_store_account_delete_cache (TNY_STORE_ACCOUNT (account));
+}
+
 static void
 on_account_removed (ModestAccountMgr *acc_mgr, 
                    const gchar *account,
                    gpointer user_data)
 {
        TnyAccount *store_account = NULL, *transport_account = NULL;
-       ModestTnyAccountStore *self = MODEST_TNY_ACCOUNT_STORE(user_data);
+       ModestTnyAccountStore *self;
+       ModestTnyAccountStorePrivate *priv;
        
+       self = MODEST_TNY_ACCOUNT_STORE (user_data);
+       priv = MODEST_TNY_ACCOUNT_STORE_GET_PRIVATE (self);
+
        /* Get the server and the transport account */
        store_account = 
                modest_tny_account_store_get_server_account (self, account, TNY_ACCOUNT_TYPE_STORE);
        transport_account = 
                modest_tny_account_store_get_server_account (self, account, TNY_ACCOUNT_TYPE_TRANSPORT);
-
+       
        /* If there was any problem creating the account, for example,
           with the configuration system this could not exist */
        if (store_account) {
-               /* Clear the cache */
-               tny_store_account_delete_cache (TNY_STORE_ACCOUNT (store_account));
-
-               /* Notify the observers */
-               g_signal_emit (G_OBJECT (self), signals [ACCOUNT_REMOVED_SIGNAL], 0, store_account);
-               g_object_unref (store_account);
+               /* Disconnect before deleting the cache, because the
+                  disconnection will rewrite the cache to the
+                  disk */
+               tny_camel_account_set_online (TNY_CAMEL_ACCOUNT (store_account), FALSE,
+                                             on_account_disconnect_when_removing, self);
        } else {
                g_warning ("There is no store account for account %s\n", account);
        }
@@ -1658,14 +1728,48 @@ on_account_removed (ModestAccountMgr *acc_mgr,
                        g_warning ("Removing a transport account that has no outbox");
                }
 
-               /* Notify the observers */
-               g_signal_emit (G_OBJECT (self), signals [ACCOUNT_REMOVED_SIGNAL], 0, transport_account);
-               g_object_unref (transport_account);
+               /* Disconnect and notify the observers. The callback will free the reference */
+               tny_camel_account_set_online (TNY_CAMEL_ACCOUNT (transport_account), FALSE,
+                                             on_account_disconnect_when_removing, self);
        } else {
                g_warning ("There is no transport account for account %s\n", account);
        }
 }
 
+TnyTransportAccount *
+modest_tny_account_store_new_connection_specific_transport_account (ModestTnyAccountStore *self,
+                                                                   const gchar *name)
+{
+       ModestTnyAccountStorePrivate *priv = NULL;
+       TnyAccount * tny_account = NULL;
+
+       priv = MODEST_TNY_ACCOUNT_STORE_GET_PRIVATE(self);
+
+       /* Add the account: */
+       tny_account = 
+               modest_tny_account_new_from_server_account_name (priv->account_mgr, 
+                                                                priv->session, 
+                                                                name,
+                                                                get_password,
+                                                                forget_password);
+       if (tny_account) {
+               g_object_set_data (G_OBJECT(tny_account), 
+                                  "account_store", 
+                                  (gpointer)self);
+               
+               tny_list_append (priv->transport_accounts, G_OBJECT (tny_account));
+               add_outbox_from_transport_account_to_global_outbox (self, 
+                                                                   name, 
+                                                                   tny_account);
+               
+       } else
+               g_printerr ("modest: failed to create smtp-specific account for %s\n",
+                           name);
+
+       return TNY_TRANSPORT_ACCOUNT (tny_account);
+}
+
+
 static void
 add_connection_specific_transport_accounts (ModestTnyAccountStore *self)
 {
@@ -1694,24 +1798,11 @@ add_connection_specific_transport_accounts (ModestTnyAccountStore *self)
                iter = g_slist_next (iter);
                if (iter) {
                        const gchar* transport_account_name = (const gchar*) (iter->data);
-                       if (transport_account_name) {
-                               TnyAccount * tny_account = NULL;
-                               /* Add the account: */
-                               tny_account = 
-                                       modest_tny_account_new_from_server_account_name (priv->account_mgr, 
-                                                                                        priv->session, 
-                                                                                        transport_account_name);
-                               if (tny_account) {
-                                       g_object_set_data (G_OBJECT(tny_account), 
-                                                          "account_store", 
-                                                          (gpointer)self);
-
-                                       tny_list_append (priv->transport_accounts, G_OBJECT (tny_account));
-                                       g_object_unref (tny_account);
-                               } else
-                                       g_printerr ("modest: failed to create smtp-specific account for %s\n",
-                                                   transport_account_name);
-                       }
+                       TnyTransportAccount * account = NULL;
+                       account = modest_tny_account_store_new_connection_specific_transport_account (
+                               self, transport_account_name);
+                       if (account)
+                               g_object_unref (account);
                }                               
                iter = g_slist_next (iter);
        }