* added better support for passwords
[modest] / src / modest-tny-account-store.c
index ddb2af2..e9fba72 100644 (file)
@@ -9,6 +9,7 @@
 #include <tny-store-account-iface.h>
 #include <tny-transport-account-iface.h>
 #include <tny-device-iface.h>
+#include <tny-device.h>
 #include <tny-account-store.h>
 
 #include <tny-store-account.h>
@@ -38,16 +39,28 @@ enum {
        LAST_SIGNAL
 };
 
+/* Password Status */
+enum {
+        PW_NOT_INVALID,
+        PW_INVALID,
+};
+
+static const gchar *transport_protocols[] = { "smtp", NULL };
+
 typedef struct _ModestTnyAccountStorePrivate ModestTnyAccountStorePrivate;
 struct _ModestTnyAccountStorePrivate {
 
+       GMutex *store_lock;
+       GMutex *transport_lock;
        GList *store_accounts;
        GList *transport_accounts;
        gchar *cache_dir;
 
        TnySessionCamel *tny_session_camel;
-       
-       ModestAccountMgr *modest_acc_mgr;       
+       TnyDeviceIface  *device;
+
+        ModestAccountMgr *modest_acc_mgr;
+        gint pw_invalid;
 };
 #define MODEST_TNY_ACCOUNT_STORE_GET_PRIVATE(o)      (G_TYPE_INSTANCE_GET_PRIVATE((o), \
                                                       MODEST_TYPE_TNY_ACCOUNT_STORE, \
@@ -55,7 +68,7 @@ struct _ModestTnyAccountStorePrivate {
 /* globals */
 static GObjectClass *parent_class = NULL;
 
-static guint signals[LAST_SIGNAL] = {0}; 
+static guint signals[LAST_SIGNAL] = {0};
 
 GType
 modest_tny_account_store_get_type (void)
@@ -79,12 +92,11 @@ modest_tny_account_store_get_type (void)
                        NULL,         /* interface_finalize */
                        NULL          /* interface_data */
                 };
-
                /* hack hack */
-               my_type = g_type_register_static (TNY_TYPE_ACCOUNT_STORE, 
+               my_type = g_type_register_static (TNY_TYPE_ACCOUNT_STORE,
                                                  "ModestTnyAccountStore", &my_info, 0);
-               
-                g_type_add_interface_static (my_type, TNY_TYPE_ACCOUNT_STORE_IFACE,
+
+               g_type_add_interface_static (my_type, TNY_TYPE_ACCOUNT_STORE_IFACE,
                                             &iface_info);
        }
        return my_type;
@@ -102,16 +114,16 @@ modest_tny_account_store_class_init (ModestTnyAccountStoreClass *klass)
        g_type_class_add_private (gobject_class,
                                  sizeof(ModestTnyAccountStorePrivate));
 
-       signals[PASSWORD_REQUESTED_SIGNAL] = 
+       signals[PASSWORD_REQUESTED_SIGNAL] =
                g_signal_new ("password_requested",
                              G_TYPE_FROM_CLASS (gobject_class),
                              G_SIGNAL_RUN_FIRST,
-                             G_STRUCT_OFFSET(ModestTnyAccountStoreClass,password_requested),
+                             G_STRUCT_OFFSET(ModestTnyAccountStoreClass, password_requested),
                              NULL, NULL,
                              g_cclosure_marshal_VOID__POINTER,
                              G_TYPE_NONE, 1, G_TYPE_POINTER);
 }
-       
+
 static void
 modest_tny_account_store_init (ModestTnyAccountStore *obj)
 {
@@ -119,12 +131,17 @@ modest_tny_account_store_init (ModestTnyAccountStore *obj)
                MODEST_TNY_ACCOUNT_STORE_GET_PRIVATE(obj);
 
        priv->modest_acc_mgr         = NULL;
+       priv->device                 = NULL;
 
+       priv->store_lock             = NULL;
+       priv->transport_lock         = NULL;
        priv->store_accounts         = NULL;
        priv->transport_accounts     = NULL;
        priv->cache_dir              = NULL;
 
-       priv->tny_session_camel      = NULL;
+        priv->tny_session_camel      = NULL;
+        /* Meaning: if not indicated otherwise, we have valid password data */
+        priv->pw_invalid             = PW_NOT_INVALID;
 }
 
 
@@ -146,152 +163,54 @@ free_gobject_list (GList *list)
        return NULL;
 }
 
-
-static void
-modest_tny_account_store_finalize (GObject *obj)
-{
-       ModestTnyAccountStore *self = MODEST_TNY_ACCOUNT_STORE(obj);
-       ModestTnyAccountStorePrivate *priv =
-               MODEST_TNY_ACCOUNT_STORE_GET_PRIVATE(self);
-
-       if (priv->modest_acc_mgr) {
-               g_object_unref (G_OBJECT(priv->modest_acc_mgr));
-               priv->modest_acc_mgr = NULL;
-       }
-
-       if (priv->tny_session_camel) {
-               g_object_unref (G_OBJECT(priv->tny_session_camel));
-               priv->tny_session_camel = NULL;
-       }
-       
-       priv->store_accounts     = free_gobject_list (priv->store_accounts);
-       priv->transport_accounts = free_gobject_list (priv->store_accounts);
-       
-       g_free (priv->cache_dir);
-       priv->cache_dir = NULL;
-
-       
-
-}
-
-GObject*
-modest_tny_account_store_new (ModestAccountMgr *modest_acc_mgr)
-{
-       GObject *obj;
-       ModestTnyAccountStorePrivate *priv;
-
-       g_return_val_if_fail (modest_acc_mgr, NULL);
-
-       obj  = G_OBJECT(g_object_new(MODEST_TYPE_TNY_ACCOUNT_STORE, NULL));
-
-       priv = MODEST_TNY_ACCOUNT_STORE_GET_PRIVATE(obj);
-       g_object_ref(G_OBJECT(priv->modest_acc_mgr = modest_acc_mgr));
-
-       priv->tny_session_camel = tny_session_camel_new
-               (TNY_ACCOUNT_STORE_IFACE(obj));
-       if (!priv->tny_session_camel) {
-               g_warning ("cannot create TnySessionCamel instance");
-               g_object_unref (obj);
-               return NULL;
-       }
-       
-       return obj;
-}
-
-
 static gchar*
-get_password (TnyAccountIface *account, const gchar *prompt)
-{
-       const gchar *key; 
-       const TnyAccountStoreIface *account_store; 
+get_password (TnyAccountIface *account,
+              const gchar *prompt,
+              gboolean *cancel) {
+
+       const gchar *key;
+       const TnyAccountStoreIface *account_store;
        ModestTnyAccountStore *self;
        ModestTnyAccountStorePrivate *priv;
-       gchar *val;
+       gchar *retval;
 
-       g_message (__FUNCTION__);
-       
        g_return_val_if_fail (account, NULL);
-       
+
        key = tny_account_iface_get_id (account);
        account_store = tny_account_iface_get_account_store(account);
 
        self = MODEST_TNY_ACCOUNT_STORE (account_store);
        priv = MODEST_TNY_ACCOUNT_STORE_GET_PRIVATE(self);
 
-       val = modest_account_mgr_get_server_account_string (priv->modest_acc_mgr, key,
-                                                           MODEST_ACCOUNT_PASSWORD,
-                                                           NULL);
-       if (!val)
-               g_signal_emit (G_OBJECT(self), signals[PASSWORD_REQUESTED_SIGNAL], 0,
-                              key); 
-
-       return val;
+        if (priv->pw_invalid==PW_NOT_INVALID) {
+                retval = modest_account_mgr_get_server_account_string (priv->modest_acc_mgr,
+                                                                       key,
+                                                                       MODEST_ACCOUNT_PASSWORD,
+                                                                       NULL);
+        } else {
+                g_signal_emit(G_OBJECT(self), signals[PASSWORD_REQUESTED_SIGNAL], 0, key);
+                priv->pw_invalid=PW_NOT_INVALID;
+                retval=NULL;
+        }
+        return retval;
 }
 
 
 static void
-forget_password (TnyAccountIface *account)
-{
-       g_warning (__FUNCTION__);
-}
-
-
+forget_password (TnyAccountIface *account) {
 
-static gboolean
-add_account  (TnyAccountStoreIface *self, TnyAccountIface *account)
-{
-       TnyAccountIface       *account_iface;
-       ModestTnyAccountStore *account_store;
+       ModestTnyAccountStore *self;
        ModestTnyAccountStorePrivate *priv;
+       const TnyAccountStoreIface *account_store;
 
-       const gchar* account_name;
-       const gchar *hostname, *username, *proto;
-
-       g_return_val_if_fail (self, FALSE);
-       g_return_val_if_fail (account, FALSE);
-
-       account_iface  = TNY_ACCOUNT_IFACE(account);
-       account_store  = MODEST_TNY_ACCOUNT_STORE(self);
-       priv           = MODEST_TNY_ACCOUNT_STORE_GET_PRIVATE(self);
-
-       account_name   = tny_account_iface_get_id(account_iface);
-       if (!account_name) {
-               g_warning ("failed to retrieve account name");
-               return FALSE;
-       }
-
-       hostname =  tny_account_iface_get_hostname(account_iface);
-       username =  tny_account_iface_get_user(account_iface);
-       proto    =  tny_account_iface_get_proto(account_iface);
-
-       return modest_account_mgr_add_server_account (priv->modest_acc_mgr,
-                                                     account_name,
-                                                     hostname, username, NULL,
-                                                     proto);
-}
-
-
-
-static void
-modest_tny_account_store_add_store_account  (TnyAccountStoreIface *self,
-                                            TnyStoreAccountIface *account)
-{
-       if (!add_account (self, TNY_ACCOUNT_IFACE(account)))
-               g_warning ("failed to add store account");
-}
-
-
+        account_store = tny_account_iface_get_account_store(account);
+       self = MODEST_TNY_ACCOUNT_STORE (account_store);
+        priv = MODEST_TNY_ACCOUNT_STORE_GET_PRIVATE(self);
 
-static void
-modest_tny_account_store_add_transport_account  (TnyAccountStoreIface *self,
-                                                TnyTransportAccountIface *account)
-{
-       if (!add_account (self, TNY_ACCOUNT_IFACE(account)))
-               g_warning ("failed to add transport account");
+        priv->pw_invalid=PW_INVALID;
 }
 
 
-
 static TnyAccountIface*
 tny_account_from_key (ModestTnyAccountStore *self, const gchar *key,
                      gboolean is_store)
@@ -302,25 +221,26 @@ tny_account_from_key (ModestTnyAccountStore *self, const gchar *key,
 
        g_return_val_if_fail (self, NULL);
        g_return_val_if_fail (key, NULL);
-       
+
        priv = MODEST_TNY_ACCOUNT_STORE_GET_PRIVATE(self);
-       
+
        /* is it a store or a transport? */
        if (is_store)
                tny_account = TNY_ACCOUNT_IFACE(tny_store_account_new ());
        else
                tny_account = TNY_ACCOUNT_IFACE(tny_transport_account_new ());
-       
+
        if (!tny_account) {
                g_warning ("failed to create new tny %s account",
                           is_store ? "store" : "transport");
                return NULL;
        }
-       
+
        tny_account_iface_set_account_store (TNY_ACCOUNT_IFACE(tny_account),
                                             TNY_ACCOUNT_STORE_IFACE(self));
        /* id */
        tny_account_iface_set_id (tny_account, key);
+       tny_account_iface_set_name (tny_account, key);
 
        /* proto */
        val = modest_account_mgr_get_server_account_string (priv->modest_acc_mgr, key,
@@ -331,10 +251,9 @@ tny_account_from_key (ModestTnyAccountStore *self, const gchar *key,
        } else {
                g_warning ("protocol not defined for %s", key);
                g_object_unref (G_OBJECT(tny_account));
-               return NULL;    
+               return NULL;
        }
 
-       
        /* hostname */
        val = modest_account_mgr_get_server_account_string (priv->modest_acc_mgr, key,
                                                            MODEST_ACCOUNT_HOSTNAME,
@@ -343,7 +262,7 @@ tny_account_from_key (ModestTnyAccountStore *self, const gchar *key,
                tny_account_iface_set_hostname (tny_account, val);
                g_free (val);
        }
-               
+
 
        /* username */
        val = modest_account_mgr_get_server_account_string (priv->modest_acc_mgr, key,
@@ -356,7 +275,7 @@ tny_account_from_key (ModestTnyAccountStore *self, const gchar *key,
 
        tny_account_iface_set_pass_func (tny_account, get_password);
        tny_account_iface_set_forget_pass_func (tny_account, forget_password);
-       
+
        return tny_account;
 }
 
@@ -367,12 +286,11 @@ tny_accounts_from_server_accounts (ModestTnyAccountStore *self, GSList *accounts
 {
        GSList *cursor = accounts;
        GList *tny_accounts = NULL;
-       
+
        g_return_val_if_fail (self, NULL);
-       
+
        while (cursor) {
                TnyAccountIface *tny_account;
-               gchar *key = cursor->data;      
                tny_account = tny_account_from_key (self, (gchar*)cursor->data,
                                                    is_store);
                if (!tny_account) {
@@ -384,47 +302,293 @@ tny_accounts_from_server_accounts (ModestTnyAccountStore *self, GSList *accounts
                }
                cursor = cursor->next;
        }
-       
+
        return tny_accounts;
 }
 
 
+static void
+manager_new_account (ModestAccountMgr *modest_acc_mgr, gchar *name, gpointer data)
+{
+       ModestTnyAccountStore *self = data;
+       ModestTnyAccountStorePrivate *priv = MODEST_TNY_ACCOUNT_STORE_GET_PRIVATE(self);
+       TnyAccountIface *new_account;
+       gchar *proto;
+       gint i = 0;
+       gboolean is_store = TRUE;
+
+       g_print ("new account signal %s\n", name);
+
+       proto = modest_account_mgr_get_server_account_string (priv->modest_acc_mgr, name,
+                                                           MODEST_ACCOUNT_PROTO, NULL);
+       if (!proto) {
+               g_printerr ("Cannot add account: unknown type.");
+               return;
+       }
+
+       while (transport_protocols [i]) {
+               if (!strcmp (transport_protocols [i], proto)) {
+                       is_store = FALSE;
+                       break;
+               }
+               i++;
+       }
+
+       /* fill account lists */
+       if (!priv->store_accounts)
+               modest_tny_account_store_get_store_accounts (TNY_ACCOUNT_STORE_IFACE(self));
+       if (!priv->transport_accounts)
+               modest_tny_account_store_get_transport_accounts (TNY_ACCOUNT_STORE_IFACE(self));
+
+
+       if (is_store) {
+                       new_account = tny_account_from_key (self, name, is_store);
+                       g_mutex_lock (priv->store_lock);
+                       priv->store_accounts = g_list_append (priv->store_accounts, new_account);
+                       g_mutex_unlock (priv->store_lock);
+       } else {
+                       new_account = tny_account_from_key (self, name, is_store);
+                       g_mutex_lock (priv->transport_lock);
+                       priv->transport_accounts = g_list_append (priv->transport_accounts, new_account);
+                       g_mutex_unlock (priv->transport_lock);
+       }
+       g_signal_emit (self,
+               tny_account_store_iface_signals [TNY_ACCOUNT_STORE_IFACE_ACCOUNT_INSERTED], 0, new_account);
+}
+
+
+static void
+manager_remove_account (ModestAccountMgr *modest_acc_mgr, gchar *name, gpointer data)
+{
+       g_print ("remove account signal %s\n", name);
+}
+
+
+static void
+manager_change_account (ModestAccountMgr *modest_acc_mgr, gchar *accountname,
+       gchar *key, gchar* value, gpointer data)
+{
+       ModestTnyAccountStore *self = data;
+       ModestTnyAccountStorePrivate *priv = MODEST_TNY_ACCOUNT_STORE_GET_PRIVATE(self);
+       GList *iter;
+       TnyAccountIface *account = NULL;
+
+       g_print ("account change signal: account: %s key: %s value: %s\n", accountname, key, value);
+
+       /* fill account lists */
+       if (!priv->store_accounts)
+               modest_tny_account_store_get_store_accounts (TNY_ACCOUNT_STORE_IFACE(self));
+       if (!priv->transport_accounts)
+               modest_tny_account_store_get_transport_accounts (TNY_ACCOUNT_STORE_IFACE(self));
+
+       for (iter = priv->store_accounts; iter; iter = iter->next) {
+               TnyAccountIface *acc = iter->data;
+               if (!strcmp (tny_account_iface_get_name (acc), accountname)) {
+                       account = acc;
+                       break;
+               }
+       }
+
+       if (!account)
+               for (iter = priv->transport_accounts; iter; iter = iter->next) {
+                       TnyAccountIface *acc = iter->data;
+                       if (!strcmp (tny_account_iface_get_name (acc), accountname)) {
+                               account = acc;
+                               break;
+                       }
+               }
+
+       if (!account) {
+               g_printerr ("Couldn't find account - returning without applying changes.");
+               return;
+       }
+
+       g_mutex_lock (priv->store_lock);
+       g_mutex_lock (priv->transport_lock);
+
+       if (!strcmp (key, MODEST_ACCOUNT_HOSTNAME))
+               tny_account_iface_set_hostname (account, value);
+       if (!strcmp (key, MODEST_ACCOUNT_USERNAME))
+               tny_account_iface_set_user (account, value);
+
+       g_mutex_unlock (priv->transport_lock);
+       g_mutex_unlock (priv->store_lock);
+
+       /* TODO: handle protocol and password changes */
+       g_signal_emit (self,
+               tny_account_store_iface_signals [TNY_ACCOUNT_STORE_IFACE_ACCOUNTS_RELOADED], 0);
+}
+
+
+static void
+modest_tny_account_store_finalize (GObject *obj)
+{
+       ModestTnyAccountStore *self = MODEST_TNY_ACCOUNT_STORE(obj);
+       ModestTnyAccountStorePrivate *priv =
+               MODEST_TNY_ACCOUNT_STORE_GET_PRIVATE(self);
+
+       g_signal_handlers_disconnect_by_func (G_OBJECT (priv->modest_acc_mgr),
+               G_CALLBACK(manager_new_account), NULL);
+       g_signal_handlers_disconnect_by_func (G_OBJECT (priv->modest_acc_mgr),
+               G_CALLBACK(manager_remove_account), NULL);
+       g_signal_handlers_disconnect_by_func (G_OBJECT (priv->modest_acc_mgr),
+               G_CALLBACK(manager_change_account), NULL);
+
+       if (priv->modest_acc_mgr) {
+               g_object_unref (G_OBJECT(priv->modest_acc_mgr));
+               priv->modest_acc_mgr = NULL;
+       }
+
+       if (priv->tny_session_camel) {
+               g_object_unref (G_OBJECT(priv->tny_session_camel));
+               priv->tny_session_camel = NULL;
+       }
+
+       if (priv->device) {
+               g_object_unref (G_OBJECT(priv->device));
+               priv->device = NULL;
+       }
+
+       g_mutex_lock (priv->store_lock);
+       priv->store_accounts     = free_gobject_list (priv->store_accounts);
+       g_mutex_unlock (priv->store_lock);
+
+       g_mutex_lock (priv->transport_lock);
+       priv->transport_accounts = free_gobject_list (priv->store_accounts);
+       g_mutex_unlock (priv->transport_lock);
+
+
+       g_mutex_free (priv->store_lock);
+       g_mutex_free (priv->transport_lock);
+
+       g_free (priv->cache_dir);
+       priv->cache_dir = NULL;
+
+}
+
+
+GObject*
+modest_tny_account_store_new (ModestAccountMgr *modest_acc_mgr) {
+
+       GObject *obj;
+       ModestTnyAccountStorePrivate *priv;
+
+       g_return_val_if_fail (modest_acc_mgr, NULL);
+
+       obj  = G_OBJECT(g_object_new(MODEST_TYPE_TNY_ACCOUNT_STORE, NULL));
+
+       priv = MODEST_TNY_ACCOUNT_STORE_GET_PRIVATE(obj);
+
+       g_object_ref(G_OBJECT(modest_acc_mgr));
+       priv->modest_acc_mgr = modest_acc_mgr;
+
+       priv->store_lock = g_mutex_new ();
+       priv->transport_lock = g_mutex_new ();
+
+       priv->device = (TnyDeviceIface*)tny_device_new();
+       if (!priv->device) {
+               g_warning ("Cannot create Device instance");
+               g_object_unref (obj);
+               return NULL;
+       }
+       priv->tny_session_camel = tny_session_camel_new
+               (TNY_ACCOUNT_STORE_IFACE(obj));
+       if (!priv->tny_session_camel) {
+               g_warning ("Cannot create TnySessionCamel instance");
+               g_object_unref (obj);
+               return NULL;
+       }
+
+       g_signal_connect (G_OBJECT (modest_acc_mgr), "account-add",
+               G_CALLBACK(manager_new_account), obj);
+       g_signal_connect (G_OBJECT (modest_acc_mgr), "account-remove",
+               G_CALLBACK(manager_remove_account), obj);
+       g_signal_connect (G_OBJECT (modest_acc_mgr), "account-change",
+               G_CALLBACK(manager_change_account), obj);
+
+       return obj;
+}
+
+
+static gboolean
+add_account  (TnyAccountStoreIface *self, TnyAccountIface *account) {
+
+       TnyAccountIface       *account_iface;
+       ModestTnyAccountStore *account_store;
+       ModestTnyAccountStorePrivate *priv;
+
+       const gchar *account_name;
+       const gchar *hostname, *username, *proto;
+
+       g_return_val_if_fail (self, FALSE);
+       g_return_val_if_fail (account, FALSE);
+
+       account_iface  = TNY_ACCOUNT_IFACE(account);
+       account_store  = MODEST_TNY_ACCOUNT_STORE(self);
+       priv           = MODEST_TNY_ACCOUNT_STORE_GET_PRIVATE(self);
+
+       account_name   = tny_account_iface_get_id(account_iface);
+       if (!account_name) {
+               g_warning ("failed to retrieve account name");
+               return FALSE;
+       }
+
+       hostname =  tny_account_iface_get_hostname(account_iface);
+       username =  tny_account_iface_get_user(account_iface);
+       proto    =  tny_account_iface_get_proto(account_iface);
+
+       return modest_account_mgr_add_server_account (priv->modest_acc_mgr,
+                                                     account_name,
+                                                     hostname, username, NULL,
+                                                     proto);
+}
+
+
+static void
+modest_tny_account_store_add_store_account  (TnyAccountStoreIface *self,
+                                            TnyStoreAccountIface *account)
+{
+       if (!add_account (self, TNY_ACCOUNT_IFACE(account)))
+               g_warning ("failed to add store account");
+}
+
+
+static void
+modest_tny_account_store_add_transport_account  (TnyAccountStoreIface *self,
+                                                TnyTransportAccountIface *account)
+{
+       if (!add_account (self, TNY_ACCOUNT_IFACE(account)))
+               g_warning ("failed to add transport account");
+}
+
 
 static const GList*
 modest_tny_account_store_get_store_accounts  (TnyAccountStoreIface *iface)
 {
        ModestTnyAccountStore        *self;
        ModestTnyAccountStorePrivate *priv;
-       GSList                       *accounts, *cursor;
-       GList                        *tny_accounts;
-       
+       GSList                       *accounts;
+
        g_return_val_if_fail (iface, NULL);
-       
+
        self = MODEST_TNY_ACCOUNT_STORE(iface);
        priv = MODEST_TNY_ACCOUNT_STORE_GET_PRIVATE(self);
-       
-       accounts =
-               modest_account_mgr_server_account_names (priv->modest_acc_mgr,
-                                                        NULL,
-                                                        MODEST_PROTO_TYPE_STORE,
-                                                        NULL, FALSE);
-
-       g_message ("accounts: %d", g_slist_length (accounts));
-       tny_accounts = tny_accounts_from_server_accounts (self, accounts, TRUE);
-       g_slist_free (accounts);
-       g_message ("store accounts: %d", g_list_length (tny_accounts)); 
-
-
-       /*
-        * FIXME: after gconf notification support is added,
-        * we can simply return priv->store_account
-        */
-       priv->store_accounts = free_gobject_list (priv->store_accounts);
-       priv->store_accounts = tny_accounts;
-       
-       return tny_accounts; 
-}
 
+       if (!priv->store_accounts) {
+               accounts =
+                       modest_account_mgr_server_account_names (priv->modest_acc_mgr,
+                                                                NULL,
+                                                                MODEST_PROTO_TYPE_STORE,
+                                                                NULL, FALSE);
+
+               g_mutex_lock (priv->store_lock);
+               priv->store_accounts = tny_accounts_from_server_accounts (self, accounts, TRUE);
+               g_mutex_unlock (priv->store_lock);
+               g_slist_free (accounts);
+       }
+
+       return priv->store_accounts;
+}
 
 
 static const GList*
@@ -432,35 +596,41 @@ modest_tny_account_store_get_transport_accounts (TnyAccountStoreIface *iface)
 {
        ModestTnyAccountStore        *self;
        ModestTnyAccountStorePrivate *priv;
-       GSList                       *accounts, *cursor;
-       GList                        *tny_accounts;
+       GSList                       *accounts;
 
        g_return_val_if_fail (iface, NULL);
 
        self = MODEST_TNY_ACCOUNT_STORE(iface);
        priv = MODEST_TNY_ACCOUNT_STORE_GET_PRIVATE(self);
 
-       accounts =
-               modest_account_mgr_server_account_names (priv->modest_acc_mgr,
-                                                        NULL,
-                                                        MODEST_PROTO_TYPE_TRANSPORT,
-                                                        NULL, FALSE);
-       tny_accounts = tny_accounts_from_server_accounts (self, accounts, FALSE);
-       g_warning ("transport accounts: %d", g_list_length (tny_accounts));
-
-       g_slist_free (accounts);
-       
-       /*
-        * FIXME: after gconf notification support is added,
-        * we can simply return priv->store_account
-        */
-       priv->transport_accounts = free_gobject_list (priv->transport_accounts);
-       priv->transport_accounts = tny_accounts;
-       
-       return tny_accounts; /* FIXME: who will free this? */
+
+       if (!priv->transport_accounts) {
+               accounts =
+                       modest_account_mgr_server_account_names (priv->modest_acc_mgr,
+                                                                NULL,
+                                                                MODEST_PROTO_TYPE_TRANSPORT,
+                                                                NULL, FALSE);
+               g_mutex_lock (priv->transport_lock);
+               priv->transport_accounts = tny_accounts_from_server_accounts (self, accounts, FALSE);
+               g_mutex_unlock (priv->transport_lock);
+               g_slist_free (accounts);
+       }
+
+
+       return priv->transport_accounts;
 }
 
 
+ModestAccountMgr
+*modest_tny_account_store_get_accout_mgr(ModestTnyAccountStore *self)
+{
+       ModestTnyAccountStorePrivate *priv;
+       g_return_val_if_fail (self, NULL);
+
+       priv = MODEST_TNY_ACCOUNT_STORE_GET_PRIVATE(self);
+
+       return priv->modest_acc_mgr;
+}
 
 
 TnySessionCamel*
@@ -471,14 +641,10 @@ tny_account_store_get_session (TnyAccountStore *self)
 
        priv = MODEST_TNY_ACCOUNT_STORE_GET_PRIVATE(self);
 
-       g_message ("returning tny session camel %p",
-                  priv->tny_session_camel);
-       
        return priv->tny_session_camel;
 }
 
 
-
 /**
  * modest_tny_account_store_get_cache_dir:
  * @self: self a TnyAccountStoreIface instance
@@ -495,8 +661,6 @@ modest_tny_account_store_get_cache_dir (TnyAccountStoreIface *self)
        ModestTnyAccountStorePrivate *priv;
        priv = MODEST_TNY_ACCOUNT_STORE_GET_PRIVATE(self);
 
-       gchar *cache_dir;
-       
        if (!priv->cache_dir) {
                if (g_getenv("HOME") != NULL)
                        priv->cache_dir = g_strconcat(g_getenv("HOME"),
@@ -506,13 +670,15 @@ modest_tny_account_store_get_cache_dir (TnyAccountStoreIface *self)
 }
 
 
-
 static const TnyDeviceIface*
 modest_tny_account_store_get_device (TnyAccountStoreIface *self)
 {
-       return NULL; /* FIXME */
-}
+       ModestTnyAccountStorePrivate *priv;
+
+       priv = MODEST_TNY_ACCOUNT_STORE_GET_PRIVATE (self);
 
+       return priv->device;
+}
 
 
 static void
@@ -524,17 +690,16 @@ modest_tny_account_store_iface_init (gpointer g_iface, gpointer iface_data)
 
        klass = (TnyAccountStoreIfaceClass *)g_iface;
 
-        klass->add_store_account_func      =
+       klass->add_store_account_func      =
                modest_tny_account_store_add_store_account;
-        klass->get_store_accounts_func     =
+       klass->get_store_accounts_func     =
                modest_tny_account_store_get_store_accounts;
-        klass->add_transport_account_func  =
+       klass->add_transport_account_func  =
                modest_tny_account_store_add_transport_account;
-        klass->get_transport_accounts_func =
+       klass->get_transport_accounts_func =
                modest_tny_account_store_get_transport_accounts;
        klass->get_cache_dir_func =
                modest_tny_account_store_get_cache_dir;
        klass->get_device_func =
-               modest_tny_account_store_get_device;    
-
+               modest_tny_account_store_get_device;
 }