* bugfix: register the new dialog as the new modal dialog; this
[modest] / src / modest-ui-actions.c
index 8c55c56..a0f44e6 100644 (file)
@@ -197,6 +197,8 @@ msgs_already_deleted_from_server (TnyList *headers, const TnyFolderStore *src_fo
         return (src_is_pop && !uncached_msgs);
 }
 
+
+/* FIXME: this should be merged with the similar code in modest-account-view-window */
 /* Show the account creation wizard dialog.
  * returns: TRUE if an account was created. FALSE if the user cancelled.
  */
@@ -204,25 +206,39 @@ gboolean
 modest_run_account_setup_wizard (ModestWindow *win)
 {
        gboolean result = FALSE;
-       GtkDialog *wizard;
-       
-       wizard = modest_window_mgr_get_easysetup_dialog
-               (modest_runtime_get_window_mgr());
-       if (wizard) {
-               /* old wizard is active already; present it and
-                * act as if the user cancelled the non-existing
-                * new one
+       GtkDialog *wizard, *dialog;
+
+       /* Show the easy-setup wizard: */       
+       dialog = modest_window_mgr_get_modal_dialog (modest_runtime_get_window_mgr());
+       if (dialog && MODEST_IS_EASYSETUP_WIZARD_DIALOG(dialog)) {
+               /* old wizard is active already; 
                 */
-               printf ("wizard already active\n");
+               gtk_window_present (GTK_WINDOW(dialog));
                return FALSE;
-       } else {
-               /* there is no such wizard yet */
-               wizard = GTK_DIALOG(modest_easysetup_wizard_dialog_new ());
-               modest_window_mgr_set_easysetup_dialog
-                       (modest_runtime_get_window_mgr(), GTK_DIALOG(wizard));
-       } 
+       }
+       
 
+       /* there is no such wizard yet */
+               
+       wizard = GTK_DIALOG(modest_easysetup_wizard_dialog_new ());
+       if (!wizard) {
+               g_printerr ("modest: failed to create easysetup wizard\n");
+               return FALSE;
+       }
        
+       modest_window_mgr_set_modal_dialog
+               (modest_runtime_get_window_mgr(), GTK_DIALOG(wizard));
+
+
+       /* there is no such wizard yet */
+       wizard = GTK_DIALOG(modest_easysetup_wizard_dialog_new ());
+       modest_window_mgr_set_modal_dialog (modest_runtime_get_window_mgr(), 
+                                           GTK_DIALOG(wizard));
+
+       /* make it non-modal; if though we register it as a modal dialog above
+        * apparently, making it modal *at all* gives hangs -- FIXME: check this*/
+       gtk_window_set_modal (GTK_WINDOW(dialog), FALSE);
+
        /* always present a main window in the background 
         * we do it here, so we cannot end up with to wizards (as this
         * function might be called in modest_window_mgr_get_main_window as well */
@@ -251,7 +267,7 @@ modest_run_account_setup_wizard (ModestWindow *win)
        gtk_widget_destroy (GTK_WIDGET (wizard));
 
        /* clear it from the window mgr */
-       modest_window_mgr_set_easysetup_dialog
+       modest_window_mgr_set_modal_dialog
                (modest_runtime_get_window_mgr(), NULL);
        
        return result;
@@ -385,29 +401,19 @@ void modest_do_messages_delete (TnyList *headers, ModestWindow *win)
        g_object_unref (G_OBJECT (mail_op));
 }
 
-/* static void */
-/* headers_action_delete (TnyHeader *header, */
-/*                    ModestWindow *win, */
-/*                    gpointer user_data) */
-/* { */
-/*     modest_do_message_delete (header, win); */
-
-/* } */
-
 /** After deleing a message that is currently visible in a window, 
  * show the next message from the list, or close the window if there are no more messages.
  **/
-void modest_ui_actions_refresh_message_window_after_delete (ModestMsgViewWindow* win)
+void 
+modest_ui_actions_refresh_message_window_after_delete (ModestMsgViewWindow* win)
 {
        /* Close msg view window or select next */
        if (modest_msg_view_window_last_message_selected (win) &&
                modest_msg_view_window_first_message_selected (win)) {
                modest_ui_actions_on_close_window (NULL, MODEST_WINDOW (win));
-       } else {
-               if (!modest_msg_view_window_select_next_message (win)) {
-                       gboolean ret_value;
-                       g_signal_emit_by_name (G_OBJECT (win), "delete-event", NULL, &ret_value);
-               }
+       } else if (!modest_msg_view_window_select_next_message (win)) {
+               gboolean ret_value;
+               g_signal_emit_by_name (G_OBJECT (win), "delete-event", NULL, &ret_value);       
        }
 }
 
@@ -441,31 +447,30 @@ modest_ui_actions_on_delete_message (GtkAction *action, ModestWindow *win)
                        
        /* Check if any of the headers are already opened, or in the process of being opened */
        if (MODEST_IS_MAIN_WINDOW (win)) {
-               gboolean found;
+               gint opened_headers = 0;
+
                iter = tny_list_create_iterator (header_list);
-               found = FALSE;
                mgr = modest_runtime_get_window_mgr ();
-               while (!tny_iterator_is_done (iter) && !found) {
+               while (!tny_iterator_is_done (iter)) {
                        header = TNY_HEADER (tny_iterator_get_current (iter));
                        if (header) {
-                               found =  modest_window_mgr_find_registered_header (mgr, header, NULL);
+                               if (modest_window_mgr_find_registered_header (mgr, header, NULL))
+                                       opened_headers++;
                                g_object_unref (header);
                        }
-
                        tny_iterator_next (iter);
                }
                g_object_unref (iter);
 
-               if (found) {
-                       gchar *num, *msg;
+               if (opened_headers > 0) {
+                       gchar *msg;
 
-                       num = g_strdup_printf ("%d", tny_list_get_length (header_list));
-                       msg = g_strdup_printf (_("mcen_nc_unable_to_delete_n_messages"), num);
+                       msg = g_strdup_printf (_("mcen_nc_unable_to_delete_n_messages"), 
+                                              opened_headers);
 
                        modest_platform_run_information_dialog (GTK_WINDOW (win), (const gchar *) msg);
                        
                        g_free (msg);
-                       g_free (num);
                        g_object_unref (header_list);
                        return;
                }
@@ -528,7 +533,9 @@ modest_ui_actions_on_delete_message (GtkAction *action, ModestWindow *win)
                modest_do_messages_delete (header_list, win);
                
                /* Enable window dimming management */
-               gtk_tree_selection_unselect_all (sel);
+               if (sel != NULL) {
+                       gtk_tree_selection_unselect_all (sel);
+               }
                modest_window_enable_dimming (MODEST_WINDOW(win));
                
                if (MODEST_IS_MSG_VIEW_WINDOW (win)) {
@@ -1550,7 +1557,7 @@ new_messages_arrived (ModestMailOperation *self,
        }       
 
        /* Notify new messages have been downloaded */
-       if (tny_list_get_length (new_headers) > 0) {
+       if ((new_headers != NULL) && (tny_list_get_length (new_headers) > 0)) {
                TnyIterator *iter = tny_list_create_iterator (new_headers);
                do {
                        TnyHeader *header =  NULL;
@@ -2611,7 +2618,7 @@ modest_ui_actions_delete_folder_error_handler (ModestMailOperation *mail_op,
        g_object_unref (win);
 }
 
-static void
+static gboolean
 delete_folder (ModestMainWindow *main_window, gboolean move_to_trash) 
 {
        TnyFolderStore *folder;
@@ -2620,12 +2627,12 @@ delete_folder (ModestMainWindow *main_window, gboolean move_to_trash)
        gchar *message;
         gboolean do_delete = TRUE;
 
-       g_return_if_fail (MODEST_IS_MAIN_WINDOW (main_window));
+       g_return_val_if_fail (MODEST_IS_MAIN_WINDOW (main_window), FALSE);
 
        folder_view = modest_main_window_get_child_widget (main_window,
                                                           MODEST_MAIN_WINDOW_WIDGET_TYPE_FOLDER_VIEW);
        if (!folder_view)
-               return;
+               return FALSE;
 
        folder = modest_folder_view_get_selected (MODEST_FOLDER_VIEW (folder_view));
 
@@ -2634,7 +2641,7 @@ delete_folder (ModestMainWindow *main_window, gboolean move_to_trash)
                modest_platform_run_information_dialog (GTK_WINDOW (main_window),
                                                        _("mail_in_ui_folder_delete_error"));
                g_object_unref (G_OBJECT (folder));
-               return ;
+               return FALSE;
        }
 
        /* Ask the user */      
@@ -2675,21 +2682,23 @@ delete_folder (ModestMainWindow *main_window, gboolean move_to_trash)
        }
 
        g_object_unref (G_OBJECT (folder));
+
+       return do_delete;
 }
 
 void 
 modest_ui_actions_on_delete_folder (GtkAction *action,
                                     ModestMainWindow *main_window)
 {
-       GtkWidget *folder_view;
        g_return_if_fail (MODEST_IS_MAIN_WINDOW(main_window));
 
-       delete_folder (main_window, FALSE);
-       folder_view = modest_main_window_get_child_widget (main_window,
-                                                          MODEST_MAIN_WINDOW_WIDGET_TYPE_FOLDER_VIEW);
-       if (!folder_view)
-               return;
-       modest_folder_view_select_first_inbox_or_local (MODEST_FOLDER_VIEW (folder_view));
+       if (delete_folder (main_window, FALSE)) {
+               GtkWidget *folder_view;
+
+               folder_view = modest_main_window_get_child_widget (main_window,
+                                                                  MODEST_MAIN_WINDOW_WIDGET_TYPE_FOLDER_VIEW);
+               modest_folder_view_select_first_inbox_or_local (MODEST_FOLDER_VIEW (folder_view));
+       }
 }
 
 void 
@@ -3042,11 +3051,8 @@ modest_ui_actions_on_redo (GtkAction *action,
 
 
 static void
-paste_msgs_cb (const GObject *object, gpointer user_data)
+destroy_information_note (ModestMailOperation *mail_op, gpointer user_data)
 {
-       g_return_if_fail (MODEST_IS_MAIN_WINDOW (object));
-       g_return_if_fail (GTK_IS_WIDGET (user_data));
-       
        /* destroy information note */
        gtk_widget_destroy (GTK_WIDGET(user_data));
 }
@@ -3151,10 +3157,11 @@ modest_ui_actions_on_paste (GtkAction *action,
                        gint response = 0;
 
                        /* Ask for user confirmation */
-                       response = msgs_move_to_confirmation (GTK_WINDOW (window), 
-                                                             TNY_FOLDER (folder_store), 
-                                                             delete,
-                                                             data);
+                       response = 
+                               modest_ui_actions_msgs_move_to_confirmation (GTK_WINDOW (window), 
+                                                                            TNY_FOLDER (folder_store), 
+                                                                            delete,
+                                                                            data);
                        
                        if (response == GTK_RESPONSE_OK) {
                                /* Launch notification */
@@ -3170,7 +3177,7 @@ modest_ui_actions_on_paste (GtkAction *action,
                                                                 data,
                                                                 TNY_FOLDER (folder_store),
                                                                 delete,
-                                                                paste_msgs_cb,
+                                                                destroy_information_note,
                                                                 inf_note);                             
                        } else {
                                g_object_unref (mail_op);
@@ -3190,7 +3197,7 @@ modest_ui_actions_on_paste (GtkAction *action,
                                                           src_folder,
                                                           folder_store,
                                                           delete,
-                                                          paste_msgs_cb,
+                                                          destroy_information_note,
                                                           inf_note);
                }
 
@@ -3838,10 +3845,10 @@ has_retrieved_msgs (TnyList *list)
  *     drag_and_drop_from_header_view (for d&d in modest_folder_view.c)
  */
 gint
-msgs_move_to_confirmation (GtkWindow *win,
-                          TnyFolder *dest_folder,
-                          gboolean delete,
-                          TnyList *headers)
+modest_ui_actions_msgs_move_to_confirmation (GtkWindow *win,
+                                            TnyFolder *dest_folder,
+                                            gboolean delete,
+                                            TnyList *headers)
 {
        gint response = GTK_RESPONSE_OK;
 
@@ -3886,20 +3893,26 @@ msgs_move_to_confirmation (GtkWindow *win,
 
 
 static void
-move_to_cb (const GObject *object, gpointer user_data)
+move_to_cb (ModestMailOperation *mail_op, gpointer user_data)
 {
-       ModestMsgViewWindow *self = NULL;
-       g_return_if_fail (GTK_IS_WIDGET (user_data));
-       g_return_if_fail (MODEST_IS_WINDOW (object));
+       /* Note that the operation could have failed, in that case do
+          nothing */
+       if (modest_mail_operation_get_status (mail_op) == 
+           MODEST_MAIL_OPERATION_STATUS_SUCCESS) {
 
-       if (MODEST_IS_MSG_VIEW_WINDOW (object)) {
-                self = MODEST_MSG_VIEW_WINDOW (object);
+               GObject *object = modest_mail_operation_get_source (mail_op);
+               if (MODEST_IS_MSG_VIEW_WINDOW (object)) {
+                       ModestMsgViewWindow *self = MODEST_MSG_VIEW_WINDOW (object);
 
-               if (!modest_msg_view_window_select_next_message (self))
-                       if (!modest_msg_view_window_select_previous_message (self))
-                               /* No more messages to view, so close this window */
-                                modest_ui_actions_on_close_window (NULL, MODEST_WINDOW(self));
+                       if (!modest_msg_view_window_select_next_message (self))
+                               if (!modest_msg_view_window_select_previous_message (self))
+                                       /* No more messages to view, so close this window */
+                                       modest_ui_actions_on_close_window (NULL, MODEST_WINDOW(self));
+               }
+               g_object_unref (object);
         }
+
+       /* Close the "Pasting" information banner */
        gtk_widget_destroy (GTK_WIDGET(user_data));
 }
 
@@ -3907,7 +3920,7 @@ void
 modest_ui_actions_move_folder_error_handler (ModestMailOperation *mail_op, 
                                             gpointer user_data)
 {
-       ModestMainWindow *main_window = NULL;
+       ModestWindow *main_window = NULL;
        GtkWidget *folder_view = NULL;
        GObject *win = modest_mail_operation_get_source (mail_op);
        const GError *error = NULL;
@@ -3922,11 +3935,14 @@ modest_ui_actions_move_folder_error_handler (ModestMailOperation *mail_op,
        }
        
        /* Disable next automatic folder selection */
-       if (MODEST_IS_MAIN_WINDOW (user_data)) {
-               main_window = MODEST_MAIN_WINDOW(user_data);
-               folder_view = modest_main_window_get_child_widget (main_window,
+       main_window = modest_window_mgr_get_main_window (modest_runtime_get_window_mgr ());
+       folder_view = modest_main_window_get_child_widget (MODEST_MAIN_WINDOW (main_window),
                                                           MODEST_MAIN_WINDOW_WIDGET_TYPE_FOLDER_VIEW); 
-               modest_folder_view_disable_next_folder_selection (MODEST_FOLDER_VIEW(folder_view));             
+       modest_folder_view_disable_next_folder_selection (MODEST_FOLDER_VIEW(folder_view));
+       
+       if (user_data && TNY_IS_FOLDER (user_data)) {
+               modest_folder_view_select_folder (MODEST_FOLDER_VIEW (folder_view), 
+                                                 TNY_FOLDER (user_data), FALSE);
        }
 
        /* Show notification dialog */
@@ -3998,6 +4014,8 @@ open_msg_for_purge_cb (ModestMailOperation *mail_op,
 
                tny_iterator_next (iter);
        }
+       g_object_unref (iter);
+       
 
        if (pending_purges>0) {
                gint response;
@@ -4005,7 +4023,7 @@ open_msg_for_purge_cb (ModestMailOperation *mail_op,
 
                if (response == GTK_RESPONSE_OK) {
                        modest_platform_information_banner (NULL, NULL, _("mcen_ib_removing_attachment"));
-                       tny_iterator_first (iter);
+                       iter = tny_list_create_iterator (parts);
                        while (!tny_iterator_is_done (iter)) {
                                TnyMimePart *part;
                                
@@ -4024,26 +4042,10 @@ open_msg_for_purge_cb (ModestMailOperation *mail_op,
        } else {
                modest_platform_information_banner (NULL, NULL, _("mail_ib_attachment_already_purged"));
        }
+       g_object_unref (iter);
 
-       /* remove attachments */
-       tny_iterator_first (iter);
-       while (!tny_iterator_is_done (iter)) {
-               TnyMimePart *part;
-                       
-               part = TNY_MIME_PART (tny_iterator_get_current (iter));
-               if (part) {
-                       /* One for the reference given by tny_iterator_get_current(): */
-                       g_object_unref (part);
-
-                       /* TODO: Is this meant to remove the attachment by doing another unref()? 
-                        * Otherwise, this seems useless. */
-               }
-
-               tny_iterator_next (iter);
-       }
        modest_window_mgr_unregister_header (mgr, header);
 
-       g_object_unref (iter);
        g_object_unref (parts);
 }
 
@@ -4232,7 +4234,7 @@ modest_ui_actions_on_main_window_move_to (GtkAction *action,
                           modest_mail_operation_new_with_error_handling (MODEST_MAIL_OPERATION_TYPE_RECEIVE,
                                                                          G_OBJECT(win),
                                                                          modest_ui_actions_move_folder_error_handler,
-                                                                         win);
+                                                                         src_folder);
                         modest_mail_operation_queue_add (modest_runtime_get_mail_operation_queue (),
                                                          mail_op);
 
@@ -4244,7 +4246,9 @@ modest_ui_actions_on_main_window_move_to (GtkAction *action,
                         modest_mail_operation_xfer_folder (mail_op,
                                                            TNY_FOLDER (src_folder),
                                                            dst_folder,
-                                                           TRUE, move_to_cb, inf_note);
+                                                           TRUE, 
+                                                          move_to_cb, 
+                                                          inf_note);
                         /* Unref mail operation */
                         g_object_unref (G_OBJECT (mail_op));
                 }