* Fixed some reference leaks
[modest] / src / modest-ui-actions.c
index c25a287..ab37fee 100644 (file)
@@ -258,6 +258,20 @@ headers_action_delete (TnyHeader *header,
 /*             modest_header_view_refilter (MODEST_HEADER_VIEW (user_data)); */
 }
 
+/** After deleing a message that is currently visible in a window, 
+ * show the next message from the list, or close the window if there are no more messages.
+ **/
+void modest_ui_actions_refresh_message_window_after_delete (ModestMsgViewWindow* win)
+{
+       /* Close msg view window or select next */
+       if (modest_msg_view_window_last_message_selected (win) &&
+               modest_msg_view_window_first_message_selected (win)) {
+               modest_ui_actions_on_close_window (NULL, MODEST_WINDOW (win));
+       } else {
+               modest_msg_view_window_select_next_message (win);
+       }
+}
+
 void
 modest_ui_actions_on_delete_message (GtkAction *action, ModestWindow *win)
 {
@@ -284,7 +298,7 @@ modest_ui_actions_on_delete_message (GtkAction *action, ModestWindow *win)
        header_list = get_selected_headers (win);
        if (!header_list) return;
 
-       /* Check if any of the headers is already opened, or in the process of being opened */
+       /* Check if any of the headers are already opened, or in the process of being opened */
        if (MODEST_IS_MAIN_WINDOW (win)) {
                gboolean found;
                iter = tny_list_create_iterator (header_list);
@@ -324,7 +338,8 @@ modest_ui_actions_on_delete_message (GtkAction *action, ModestWindow *win)
        message = g_strdup_printf(ngettext("emev_nc_delete_message", "emev_nc_delete_messages", 
                                           tny_list_get_length(header_list)), desc);
 
-       /* Confirmation dialog */               
+       /* Confirmation dialog */
+       printf("DEBUG: %s\n", __FUNCTION__);    
        response = modest_platform_run_confirmation_dialog (GTK_WINDOW (win),
                                                            message);
        
@@ -357,13 +372,7 @@ modest_ui_actions_on_delete_message (GtkAction *action, ModestWindow *win)
                do_headers_action (win, headers_action_delete, header_view);
 
                if (MODEST_IS_MSG_VIEW_WINDOW (win)) {
-                       /* Close msg view window or select next */
-                       if (modest_msg_view_window_last_message_selected (MODEST_MSG_VIEW_WINDOW (win)) &&
-                           modest_msg_view_window_first_message_selected (MODEST_MSG_VIEW_WINDOW (win))) {
-                               modest_ui_actions_on_close_window (NULL, MODEST_WINDOW (win));
-                       } else {
-                               modest_msg_view_window_select_next_message (MODEST_MSG_VIEW_WINDOW (win));
-                       }
+                       modest_ui_actions_refresh_message_window_after_delete (MODEST_MSG_VIEW_WINDOW (win));
                        
                        /* Get main window */
                        mgr = modest_runtime_get_window_mgr ();
@@ -701,8 +710,6 @@ open_msg_cb (ModestMailOperation *mail_op,
           operation. The error will be shown by the error_handler of
           the mail operation */
        if (!modest_ui_actions_msg_retrieval_check (mail_op, header, msg)) {
-               printf ("DEBUG: %s: modest_ui_actions_msg_retrieval_check() failed.\n", 
-                       __FUNCTION__);
                return;
        }
 
@@ -785,7 +792,6 @@ cleanup:
        /* Free */
        g_free(account);
        g_object_unref (parent_win);
-/*     g_object_unref (msg); */
        g_object_unref (folder);
 }
 
@@ -2283,6 +2289,8 @@ modest_ui_actions_on_rename_folder (GtkAction *action,
                return;
 
        folder = modest_folder_view_get_selected (MODEST_FOLDER_VIEW(folder_view));
+       if (!folder)
+               return;
 
        /* Offer the connection dialog if necessary: */
        if (!modest_platform_connect_and_wait_if_network_folderstore (NULL, folder)) {
@@ -2291,7 +2299,7 @@ modest_ui_actions_on_rename_folder (GtkAction *action,
        }
 
        
-       if (folder && TNY_IS_FOLDER (folder)) {
+       if (TNY_IS_FOLDER (folder)) {
                gchar *folder_name;
                gint response;
                const gchar *current_name;
@@ -2314,7 +2322,13 @@ modest_ui_actions_on_rename_folder (GtkAction *action,
                                                         mail_op);
 
                        modest_header_view_clear (MODEST_HEADER_VIEW (header_view));
+                       
+                       modest_folder_view_select_folder (MODEST_FOLDER_VIEW(folder_view),
+                                                         TNY_FOLDER(folder), TRUE);
 
+
+                       modest_header_view_clear ((ModestHeaderView *) header_view);
                        modest_mail_operation_rename_folder (mail_op,
                                                             TNY_FOLDER (folder),
                                                             (const gchar *) folder_name);
@@ -2322,8 +2336,8 @@ modest_ui_actions_on_rename_folder (GtkAction *action,
                        g_object_unref (mail_op);
                        g_free (folder_name);
                }
-               g_object_unref (folder);
        }
+       g_object_unref (folder);
 }
 
 static void
@@ -2345,7 +2359,7 @@ delete_folder (ModestMainWindow *main_window, gboolean move_to_trash)
        gint response;
        gchar *message;
        
-       g_return_if_fail (MODEST_IS_MAIN_WINDOW(main_window));
+       g_return_if_fail (MODEST_IS_MAIN_WINDOW (main_window));
 
        folder_view = modest_main_window_get_child_widget (main_window,
                                                           MODEST_WIDGET_TYPE_FOLDER_VIEW);
@@ -3162,7 +3176,7 @@ create_move_to_dialog (GtkWindow *win,
                modest_folder_view_update_model (MODEST_FOLDER_VIEW (*tree_view), 
                                                 TNY_ACCOUNT_STORE (modest_runtime_get_account_store ()));
 
-       modest_folder_view_show_non_move_folders(MODEST_FOLDER_VIEW (*tree_view), FALSE);
+       modest_folder_view_show_non_move_folders (MODEST_FOLDER_VIEW (*tree_view), FALSE);
        
        gtk_container_add (GTK_CONTAINER (scroll), *tree_view);
 
@@ -3172,9 +3186,6 @@ create_move_to_dialog (GtkWindow *win,
 
        gtk_widget_show_all (GTK_WIDGET(GTK_DIALOG(dialog)->vbox));
 
-       /* Select INBOX or local account */
-       modest_folder_view_select_first_inbox_or_local (MODEST_FOLDER_VIEW (*tree_view));
-
        return dialog;
 }
 
@@ -3261,22 +3272,14 @@ static void
 transfer_msgs_from_viewer_cb (const GObject *object, gpointer user_data)
 {
        ModestMsgViewWindow *self = NULL;
-       gboolean last, first;
 
        g_return_if_fail (MODEST_IS_MSG_VIEW_WINDOW (object));
        self = MODEST_MSG_VIEW_WINDOW (object);
        
-       last = modest_msg_view_window_last_message_selected (self);
-       first = modest_msg_view_window_first_message_selected (self);   
-       if (last & first) {
-               /* No more messages to view, so close this window */
-/*             gboolean ret_value; */
-/*             g_signal_emit_by_name (G_OBJECT (self), "delete-event", NULL, &ret_value); */
-               modest_ui_actions_on_close_window (NULL, MODEST_WINDOW(self));
-       } else if (last)
-               modest_msg_view_window_select_previous_message (self);
-       else 
-               modest_msg_view_window_select_next_message (self);
+       if (!modest_msg_view_window_select_next_message (self))
+               if (!modest_msg_view_window_select_previous_message (self))
+                       /* No more messages to view, so close this window */
+                       modest_ui_actions_on_close_window (NULL, MODEST_WINDOW(self));
 }
 
 void
@@ -3451,65 +3454,90 @@ modest_ui_actions_on_main_window_remove_attachments (GtkAction *action,
                g_object_unref (header_list);
 }
 
+/**
+ * Utility function that transfer messages from both the main window
+ * and the msg view window when using the "Move to" dialog
+ */
+static void
+modest_ui_actions_xfer_messages_from_move_to (TnyFolderStore *dst_folder,
+                                             ModestWindow *win)
+{
+       TnyList *headers = NULL;
+       gint response = 0;
+
+       if (!TNY_IS_FOLDER (dst_folder)) {
+               modest_platform_information_banner (GTK_WIDGET (win),
+                                                   NULL,
+                                                   _CS("ckdg_ib_unable_to_move_to_current_location"));
+               return;
+       }
+
+       /* Get selected headers */
+       headers = get_selected_headers (MODEST_WINDOW (win));
+
+       /* Ask for user confirmation */
+       response = msgs_move_to_confirmation (GTK_WINDOW (win), 
+                                             TNY_FOLDER (dst_folder), 
+                                             headers);
+
+       /* Transfer messages */
+       if (response == GTK_RESPONSE_OK) {
+               ModestMailOperation *mail_op = 
+                       modest_mail_operation_new_with_error_handling (MODEST_MAIL_OPERATION_TYPE_RECEIVE, 
+                                                                      G_OBJECT(win),
+                                                                      modest_ui_actions_move_folder_error_handler,
+                                                                      NULL);
+               modest_mail_operation_queue_add (modest_runtime_get_mail_operation_queue (), 
+                                                mail_op);
+
+               modest_mail_operation_xfer_msgs (mail_op, 
+                                                headers,
+                                                TNY_FOLDER (dst_folder),
+                                                TRUE,
+                                                (MODEST_IS_MSG_VIEW_WINDOW (win)) ? transfer_msgs_from_viewer_cb : NULL,
+                                                NULL);
+
+               g_object_unref (G_OBJECT (mail_op));
+       }
+       g_object_unref (headers);
+}
+
+
 /*
  * UI handler for the "Move to" action when invoked from the
  * ModestMainWindow
  */
 static void 
 modest_ui_actions_on_main_window_move_to (GtkAction *action, 
+                                         GtkWidget *folder_view,
+                                         TnyFolderStore *dst_folder,
                                          ModestMainWindow *win)
 {
-       GtkWidget *dialog = NULL, *folder_view = NULL, *tree_view = NULL;
        GtkWidget *header_view = NULL;
-       gint result = 0;
-       TnyFolderStore *folder_store = NULL;
        ModestMailOperation *mail_op = NULL;
+       TnyFolderStore *src_folder;
 
        g_return_if_fail (MODEST_IS_MAIN_WINDOW (win));
 
-       /* Get the folder view */
-       folder_view = modest_main_window_get_child_widget (win,
-                                                          MODEST_WIDGET_TYPE_FOLDER_VIEW);
-                                                          
-       TnyFolderStore *src_folder = modest_folder_view_get_selected (MODEST_FOLDER_VIEW (folder_view));
+       /* Get the source folder */
+       src_folder = modest_folder_view_get_selected (MODEST_FOLDER_VIEW (folder_view));
        
        /* Offer the connection dialog if necessary, if the source folder is in a networked account: */
-       if (!modest_platform_connect_and_wait_if_network_folderstore (GTK_WINDOW (win), src_folder)) {
-               if (src_folder) {
-                       g_object_unref (src_folder);
-               }
-               
-               return;
-       }
-
-       /* Get header view */
-       header_view = modest_main_window_get_child_widget (win,
-                                                          MODEST_WIDGET_TYPE_HEADER_VIEW);
-
-       /* Create and run the dialog */
-       dialog = create_move_to_dialog (GTK_WINDOW(win), folder_view, &tree_view);
-       modest_folder_view_select_first_inbox_or_local (MODEST_FOLDER_VIEW (tree_view));
-       result = gtk_dialog_run (GTK_DIALOG(dialog));
-       modest_folder_view_show_non_move_folders(MODEST_FOLDER_VIEW (tree_view), TRUE);
-       g_object_ref (tree_view);
-
-       /* We do this to save an indentation level ;-) */
-       if (result != GTK_RESPONSE_ACCEPT)
+       if (!modest_platform_connect_and_wait_if_network_folderstore (GTK_WINDOW (win), 
+                                                                     src_folder))
                goto end;
 
-       folder_store = modest_folder_view_get_selected (MODEST_FOLDER_VIEW (tree_view));
-
-       if (TNY_IS_ACCOUNT (folder_store) && 
-           !MODEST_IS_TNY_LOCAL_FOLDERS_ACCOUNT (folder_store))
-               goto end;
-
-       /* Offer the connection dialog if necessary: */
-       if (!modest_platform_connect_and_wait_if_network_folderstore (GTK_WINDOW (win), folder_store)) {
-                       goto end;
-       }
+       /* Get header view */
+       header_view = 
+               modest_main_window_get_child_widget (win, MODEST_WIDGET_TYPE_HEADER_VIEW);
 
        /* Get folder or messages to transfer */
        if (gtk_widget_is_focus (folder_view)) {
+
+               /* Allow only to transfer folders to the local root folder */
+               if (TNY_IS_ACCOUNT (dst_folder) && 
+                   !MODEST_IS_TNY_LOCAL_FOLDERS_ACCOUNT (dst_folder))
+                       goto end;
                
                /* Clean folder on header view before moving it */
                modest_header_view_clear (MODEST_HEADER_VIEW (header_view)); 
@@ -3517,64 +3545,29 @@ modest_ui_actions_on_main_window_move_to (GtkAction *action,
                if (TNY_IS_FOLDER (src_folder)) {
                        mail_op = 
                                modest_mail_operation_new_with_error_handling (MODEST_MAIL_OPERATION_TYPE_RECEIVE, 
-                                                                      G_OBJECT(win),
-                                                                      modest_ui_actions_move_folder_error_handler,
-                                                                      NULL);
-                       modest_mail_operation_queue_add (modest_runtime_get_mail_operation_queue (), mail_op);
+                                                                              G_OBJECT(win),
+                                                                              modest_ui_actions_move_folder_error_handler,
+                                                                              NULL);
+                       modest_mail_operation_queue_add (modest_runtime_get_mail_operation_queue (), 
+                                                        mail_op);
 
                        modest_mail_operation_xfer_folder (mail_op, 
                                                           TNY_FOLDER (src_folder),
-                                                          folder_store,
+                                                          dst_folder,
                                                           TRUE, NULL, NULL);
                        /* Unref mail operation */
                        g_object_unref (G_OBJECT (mail_op));
                } else {
                        g_warning ("%s: src_folder is not a TnyFolder.\n", __FUNCTION__);       
                }
-       } else {
-               if (gtk_widget_is_focus (header_view)) {
-                       TnyList *headers = NULL;
-                       gint response = 0;
-
-                       /* TODO: Check for connection if the headers are on a network account. */
-                       headers = modest_header_view_get_selected_headers (MODEST_HEADER_VIEW (header_view));
-
-                       /* Ask for user confirmation */
-                       response = msgs_move_to_confirmation (GTK_WINDOW (win), 
-                                                             TNY_FOLDER (folder_store), 
-                                                             headers);
-
-                       /* Transfer messages */
-                       if (response == GTK_RESPONSE_OK) {
-                               mail_op = 
-                                       modest_mail_operation_new_with_error_handling (MODEST_MAIL_OPERATION_TYPE_RECEIVE, 
-                                                                                      G_OBJECT(win),
-                                                                                      modest_ui_actions_move_folder_error_handler,
-                                                                                      NULL);
-                               modest_mail_operation_queue_add (modest_runtime_get_mail_operation_queue (), 
-                                                                mail_op);
-
-                               modest_mail_operation_xfer_msgs (mail_op, 
-                                                                headers,
-                                                                TNY_FOLDER (folder_store),
-                                                                TRUE,
-                                                                NULL,
-                                                                NULL);
-
-                               g_object_unref (G_OBJECT (mail_op));
-                       }
-                       g_object_unref (headers);
-               }
+       } else if (gtk_widget_is_focus (header_view)) {
+               /* Transfer messages */
+               modest_ui_actions_xfer_messages_from_move_to (dst_folder, MODEST_WINDOW (win));
        }
        
  end:
     if (src_folder)
        g_object_unref (src_folder);
-                       
-       if (folder_store)
-               g_object_unref (folder_store);
-
-       gtk_widget_destroy (dialog);
 }
 
 
@@ -3584,97 +3577,78 @@ modest_ui_actions_on_main_window_move_to (GtkAction *action,
  */
 static void 
 modest_ui_actions_on_msg_view_window_move_to (GtkAction *action, 
+                                             TnyFolderStore *dst_folder,
                                              ModestMsgViewWindow *win)
 {
-       GtkWidget *dialog, *folder_view, *tree_view = NULL;
-       gint result = 0;
-       ModestMainWindow *main_window = NULL;
        TnyHeader *header = NULL;
-       TnyList *headers = NULL;
-
-       /* Get the folder view */
-       main_window = MODEST_MAIN_WINDOW (modest_window_mgr_get_main_window (modest_runtime_get_window_mgr ()));
-       if (main_window)
-               folder_view = modest_main_window_get_child_widget (main_window,
-                                                                  MODEST_WIDGET_TYPE_FOLDER_VIEW);
-       else
-               folder_view = NULL;
-
-       /* Create and run the dialog */
-       dialog = create_move_to_dialog (GTK_WINDOW (win), folder_view, &tree_view);     
-       result = gtk_dialog_run (GTK_DIALOG(dialog));
-       modest_folder_view_show_non_move_folders(MODEST_FOLDER_VIEW (tree_view), TRUE);
-
-       if (result == GTK_RESPONSE_ACCEPT) {
-               TnyFolderStore *folder_store;
-               gint response;
-
-               /* Create header list */
-               header = modest_msg_view_window_get_header (MODEST_MSG_VIEW_WINDOW (win));              
-               g_return_if_fail (header != NULL);
+       TnyFolder *src_folder;
 
-               /* Offer the connection dialog if necessary: */
-               /* TODO: What's the extra g_object_ref() for? Isn't this leaking a ref? */
-               folder_store = modest_folder_view_get_selected (MODEST_FOLDER_VIEW (g_object_ref (tree_view)));
-               TnyFolder *header_folder = tny_header_get_folder(header);
-               if (modest_platform_connect_and_wait_if_network_folderstore (NULL, folder_store) &&
-                   modest_platform_connect_and_wait_if_network_folderstore (NULL, TNY_FOLDER_STORE (header_folder))) {
-                       
-                       headers = tny_simple_list_new ();
-                       tny_list_prepend (headers, G_OBJECT (header));
-                       g_object_unref (header);
-
-                       /* Ask user for confirmation. MSG-NOT404 */
-                       response = msgs_move_to_confirmation (GTK_WINDOW (win), 
-                                                     TNY_FOLDER (folder_store), 
-                                                     headers);
+       /* Create header list */
+       header = modest_msg_view_window_get_header (MODEST_MSG_VIEW_WINDOW (win));              
+       src_folder = tny_header_get_folder(header);
+       g_object_unref (header);
 
-                       /* Transfer current msg */
-                       if (response == GTK_RESPONSE_OK) {
-                               ModestMailOperation *mail_op;
+       /* Transfer the message */
+       if (modest_platform_connect_and_wait_if_network_folderstore (NULL, TNY_FOLDER_STORE (src_folder)))
+               modest_ui_actions_xfer_messages_from_move_to (dst_folder, MODEST_WINDOW (win));
 
-                               /* Create mail op */
-                               mail_op = modest_mail_operation_new (MODEST_MAIL_OPERATION_TYPE_RECEIVE, G_OBJECT(win));
-                               modest_mail_operation_queue_add (modest_runtime_get_mail_operation_queue (), 
-                                                        mail_op);
-                       
-                               /* Transfer messages */
-                               modest_mail_operation_xfer_msgs (mail_op, 
-                                                        headers,
-                                                        TNY_FOLDER (folder_store),
-                                                        TRUE,
-                                                        transfer_msgs_from_viewer_cb,
-                                                        NULL);
-                               g_object_unref (G_OBJECT (mail_op));
-                       }
-               }
-               
-               if (header_folder)
-                       g_object_unref (header_folder);
-
-               if (headers)
-                       g_object_unref (headers);
-                       
-               if (folder_store)
-                       g_object_unref (folder_store);
-       }
-       
-       gtk_widget_destroy (dialog);
+       g_object_unref (src_folder);
 }
 
 void 
 modest_ui_actions_on_move_to (GtkAction *action, 
                              ModestWindow *win)
 {
+       GtkWidget *dialog = NULL, *folder_view = NULL, *tree_view = NULL;
+       gint result = 0;
+       TnyFolderStore *dst_folder = NULL;
+       ModestMainWindow *main_window;
+
        g_return_if_fail (MODEST_IS_MAIN_WINDOW (win) ||
                          MODEST_IS_MSG_VIEW_WINDOW (win));
 
-       if (MODEST_IS_MAIN_WINDOW (win)) 
-               modest_ui_actions_on_main_window_move_to (action, 
-                                                         MODEST_MAIN_WINDOW (win));
+       /* Get the main window if exists */
+       if (MODEST_IS_MAIN_WINDOW (win))
+               main_window = MODEST_MAIN_WINDOW (win);
        else
-               modest_ui_actions_on_msg_view_window_move_to (action, 
-                                                             MODEST_MSG_VIEW_WINDOW (win));
+               main_window = 
+                       MODEST_MAIN_WINDOW (modest_window_mgr_get_main_window (modest_runtime_get_window_mgr ()));
+
+       /* Get the folder view widget if exists */
+       if (main_window)
+               folder_view = modest_main_window_get_child_widget (main_window,
+                                                                  MODEST_WIDGET_TYPE_FOLDER_VIEW);
+       else
+               folder_view = NULL;
+
+       /* Create and run the dialog */
+       dialog = create_move_to_dialog (GTK_WINDOW (win), folder_view, &tree_view);
+       modest_folder_view_select_first_inbox_or_local (MODEST_FOLDER_VIEW (tree_view));
+       result = gtk_dialog_run (GTK_DIALOG(dialog));
+       g_object_ref (tree_view);
+       gtk_widget_destroy (dialog);
+
+       if (result != GTK_RESPONSE_ACCEPT)
+               return;
+
+       dst_folder = modest_folder_view_get_selected (MODEST_FOLDER_VIEW (tree_view));
+       /* Offer the connection dialog if necessary: */
+       if (modest_platform_connect_and_wait_if_network_folderstore (GTK_WINDOW (win), 
+                                                                     dst_folder)) {
+
+               /* Do window specific stuff */
+               if (MODEST_IS_MAIN_WINDOW (win))
+                       modest_ui_actions_on_main_window_move_to (action,
+                                                                 folder_view,
+                                                                 dst_folder,
+                                                                 MODEST_MAIN_WINDOW (win));
+               else
+                       modest_ui_actions_on_msg_view_window_move_to (action,
+                                                                     dst_folder,
+                                                                     MODEST_MSG_VIEW_WINDOW (win));
+       }
+       if (dst_folder)
+               g_object_unref (dst_folder);
 }
 
 /*
@@ -3794,9 +3768,9 @@ modest_ui_actions_on_help (GtkAction *action,
 
                        /* Switch help_id */
                        if (TNY_IS_FOLDER (folder_store)) {
-                               switch (tny_folder_get_folder_type (TNY_FOLDER (folder_store))) {
+                               switch (modest_tny_folder_guess_folder_type (TNY_FOLDER (folder_store))) {
                                case TNY_FOLDER_TYPE_NORMAL:
-                                       help_id = "applications_email_userfolder";
+                                       help_id = "applications_email_managefolders";
                                        break;
                                case TNY_FOLDER_TYPE_INBOX:
                                        help_id = "applications_email_inbox";
@@ -3811,10 +3785,10 @@ modest_ui_actions_on_help (GtkAction *action,
                                        help_id = "applications_email_drafts";
                                        break;
                                case TNY_FOLDER_TYPE_ARCHIVE:
-                                       help_id = "applications_email_archive";
+                                       help_id = "applications_email_managefolders";
                                        break;
                                default:
-                                       help_id = "applications_email_mainview";
+                                       help_id = "applications_email_managefolders";
                                }
                        } else {
                                help_id = "applications_email_mainview";