TNY_GTK_FOLDER_STORE_TREE_MODEL_TYPE_COLUMN, &type,
TNY_GTK_FOLDER_STORE_TREE_MODEL_INSTANCE_COLUMN, &instance,
-1);
- if (!fname)
- return;
-
- if (!instance) {
- g_free (fname);
- return;
- }
+ if (!fname || !instance)
+ goto end;
ModestFolderView *self = MODEST_FOLDER_VIEW (data);
priv = MODEST_FOLDER_VIEW_GET_PRIVATE (self);
modest_tny_account_get_mmc_account_name (TNY_STORE_ACCOUNT (instance),
on_get_mmc_account_name, callback_data);
}
-
- g_object_unref (G_OBJECT (instance));
- g_free (fname);
+ end:
+ if (instance)
+ g_object_unref (G_OBJECT (instance));
+ if (fname)
+ g_free (fname);
}
modest_mail_operation_queue_add (modest_runtime_get_mail_operation_queue (),
mail_op);
modest_mail_operation_sync_folder (mail_op, TNY_FOLDER (priv->cur_folder_store), FALSE);
+ g_object_unref (mail_op);
}
g_object_unref (priv->cur_folder_store);
priv = MODEST_FOLDER_VIEW_GET_PRIVATE (user_data);
+
/* If we're adding a new account, and there is no previous
one, we need to select the visible server account */
if (priv->style == MODEST_FOLDER_VIEW_STYLE_SHOW_ONE &&
G_OBJECT (user_data),
MODEST_CONF_FOLDER_VIEW_KEY);
+ if (!GTK_IS_TREE_VIEW(user_data)) {
+ g_warning ("BUG: %s: not a valid tree view", __FUNCTION__);
+ return;
+ }
+
/* Get the inner model */
+ /* check, is some rare cases, we did not get the right thing here,
+ * NB#84097 */
filter_model = gtk_tree_view_get_model (GTK_TREE_VIEW (user_data));
+ if (!GTK_IS_TREE_MODEL_FILTER(filter_model)) {
+ g_warning ("BUG: %s: not a valid filter model", __FUNCTION__);
+ return;
+ }
+
+ /* check, is some rare cases, we did not get the right thing here,
+ * NB#84097 */
sort_model = gtk_tree_model_filter_get_model (GTK_TREE_MODEL_FILTER (filter_model));
+ if (!GTK_IS_TREE_MODEL_SORT(sort_model)) {
+ g_warning ("BUG: %s: not a valid sort model", __FUNCTION__);
+ return;
+ }
/* Insert the account in the model */
tny_list_append (TNY_LIST (gtk_tree_model_sort_get_model (GTK_TREE_MODEL_SORT (sort_model))),
G_OBJECT (account));
-
+
/* Refilter the model */
gtk_tree_model_filter_refilter (GTK_TREE_MODEL_FILTER (filter_model));
}
{
ModestFolderViewPrivate *priv;
GtkTreeModel *sort_model, *filter_model;
+ GtkTreeSelection *sel;
/* Ignore transport account insertions, we're not showing them
in the folder view */
if (TNY_IS_TRANSPORT_ACCOUNT (tny_account))
return;
+ if (!MODEST_IS_FOLDER_VIEW(user_data)) {
+ g_warning ("BUG: %s: not a valid folder view", __FUNCTION__);
+ return;
+ }
+
+
priv = MODEST_FOLDER_VIEW_GET_PRIVATE (user_data);
/* Get the inner model */
filter_model = gtk_tree_view_get_model (GTK_TREE_VIEW (user_data));
+ if (!GTK_IS_TREE_MODEL_FILTER(filter_model)) {
+ g_warning ("BUG: %s: not a valid filter model", __FUNCTION__);
+ return;
+ }
+
+
sort_model = gtk_tree_model_filter_get_model (GTK_TREE_MODEL_FILTER (filter_model));
+ if (!GTK_IS_TREE_MODEL_SORT(sort_model)) {
+ g_warning ("BUG: %s: not a valid sort model", __FUNCTION__);
+ return;
+ }
+
+ /* Unselect the folder, clear the header list */
+ sel = gtk_tree_view_get_selection (GTK_TREE_VIEW (user_data));
+ gtk_tree_selection_unselect_all (sel);
/* Remove the account from the model */
tny_list_remove (TNY_LIST (gtk_tree_model_sort_get_model (GTK_TREE_MODEL_SORT (sort_model))),
G_OBJECT (tny_account));
-
+
/* Insert the account in the model */
tny_list_append (TNY_LIST (gtk_tree_model_sort_get_model (GTK_TREE_MODEL_SORT (sort_model))),
G_OBJECT (tny_account));
{
ModestFolderView *self = MODEST_FOLDER_VIEW (user_data);
+ gdk_threads_enter ();
modest_folder_view_select_first_inbox_or_local (self);
+ gdk_threads_leave ();
return FALSE;
}
if (TNY_IS_TRANSPORT_ACCOUNT (account))
return;
+ if (!MODEST_IS_FOLDER_VIEW(user_data)) {
+ g_warning ("BUG: %s: not a valid folder view", __FUNCTION__);
+ return;
+ }
+
self = MODEST_FOLDER_VIEW (user_data);
priv = MODEST_FOLDER_VIEW_GET_PRIVATE (self);
/* Remove the account from the model */
filter_model = gtk_tree_view_get_model (GTK_TREE_VIEW (self));
+ if (!GTK_IS_TREE_MODEL_FILTER(filter_model)) {
+ g_warning ("BUG: %s: not a valid filter model", __FUNCTION__);
+ return;
+ }
+
sort_model = gtk_tree_model_filter_get_model (GTK_TREE_MODEL_FILTER (filter_model));
+ if (!GTK_IS_TREE_MODEL_SORT(sort_model)) {
+ g_warning ("BUG: %s: not a valid sort model", __FUNCTION__);
+ return;
+ }
+
tny_list_remove (TNY_LIST (gtk_tree_model_sort_get_model (GTK_TREE_MODEL_SORT (sort_model))),
G_OBJECT (account));
priv = MODEST_FOLDER_VIEW_GET_PRIVATE(self);
/* Notify that there is no folder selected */
- g_signal_emit (G_OBJECT(self),
+ g_signal_emit (G_OBJECT(self),
signals[FOLDER_SELECTION_CHANGED_SIGNAL], 0,
NULL, FALSE);
if (priv->cur_folder_store) {
g_signal_connect (G_OBJECT(filter_model), "row-inserted",
(GCallback) on_row_inserted_maybe_select_folder, self);
-
g_object_unref (model);
g_object_unref (filter_model);
g_object_unref (sortable);
ModestFolderView *folder_view;
gboolean delete_source;
GtkTreePath *source_row;
- GdkDragContext *context;
- guint time;
} DndHelper;
static void
dnd_helper_destroyer (DndHelper *helper)
{
/* Free the helper */
- g_object_unref (helper->folder_view);
gtk_tree_path_free (helper->source_row);
g_slice_free (DndHelper, helper);
}
static void
-xfer_cb (ModestMailOperation *mail_op,
- gpointer user_data)
-{
- gboolean success;
- DndHelper *helper;
-
- helper = (DndHelper *) user_data;
-
- if (modest_mail_operation_get_status (mail_op) ==
- MODEST_MAIL_OPERATION_STATUS_SUCCESS) {
- success = TRUE;
- } else {
- success = FALSE;
- }
-
- /* Notify the drag source. Never call delete, the monitor will
- do the job if needed */
- gtk_drag_finish (helper->context, success, FALSE, helper->time);
-
- /* Free the helper */
- dnd_helper_destroyer (helper);
-}
-
-static void
-xfer_msgs_cb (ModestMailOperation *mail_op,
- gpointer user_data)
-{
- /* Common part */
- xfer_cb (mail_op, user_data);
-}
-
-static void
xfer_folder_cb (ModestMailOperation *mail_op,
TnyFolder *new_folder,
gpointer user_data)
{
- DndHelper *helper;
- GtkWidget *folder_view;
-
- helper = (DndHelper *) user_data;
- folder_view = g_object_ref (helper->folder_view);
-
- /* Common part */
- xfer_cb (mail_op, user_data);
-
- /* Select the folder */
- if (new_folder)
- modest_folder_view_select_folder (MODEST_FOLDER_VIEW (folder_view),
- new_folder, FALSE);
- g_object_unref (folder_view);
+ if (new_folder) {
+ /* Select the folder */
+ modest_folder_view_select_folder (MODEST_FOLDER_VIEW (user_data),
+ new_folder, TRUE);
+ }
}
return folder;
}
+
/*
* This function is used by drag_data_received_cb to manage drag and
* drop of a header, i.e, and drag from the header view to the folder
drag_and_drop_from_header_view (GtkTreeModel *source_model,
GtkTreeModel *dest_model,
GtkTreePath *dest_row,
- GtkSelectionData *selection_data,
- DndHelper *helper)
+ GtkSelectionData *selection_data)
{
TnyList *headers = NULL;
- TnyFolder *folder = NULL;
+ TnyFolder *folder = NULL, *src_folder = NULL;
TnyFolderType folder_type;
- ModestMailOperation *mail_op = NULL;
GtkTreeIter source_iter, dest_iter;
ModestWindowMgr *mgr = NULL;
ModestWindow *main_win = NULL;
gchar **uris, **tmp;
- gint response;
-
+
/* Build the list of headers */
mgr = modest_runtime_get_window_mgr ();
headers = tny_simple_list_new ();
while (*tmp != NULL) {
TnyHeader *header;
GtkTreePath *path;
+ gboolean first = TRUE;
/* Get header */
path = gtk_tree_path_new_from_string (*tmp);
if (!modest_window_mgr_find_registered_header(mgr, header, NULL))
tny_list_append (headers, G_OBJECT (header));
+ if (G_UNLIKELY (first)) {
+ src_folder = tny_header_get_folder (header);
+ first = FALSE;
+ }
+
/* Free and go on */
gtk_tree_path_free (path);
g_object_unref (header);
goto cleanup;
}
- response = modest_ui_actions_msgs_move_to_confirmation (main_win, folder,
- TRUE, headers);
- if (response == GTK_RESPONSE_CANCEL)
- goto cleanup;
-
/* Transfer messages */
- mail_op = modest_mail_operation_new_with_error_handling ((GObject *) main_win,
- modest_ui_actions_move_folder_error_handler,
- NULL, NULL);
-
- modest_mail_operation_queue_add (modest_runtime_get_mail_operation_queue (),
- mail_op);
-
- modest_mail_operation_xfer_msgs (mail_op,
- headers,
- folder,
- helper->delete_source,
- xfer_msgs_cb, helper);
+ modest_ui_actions_transfer_messages_helper (GTK_WINDOW (main_win), src_folder,
+ headers, folder);
/* Frees */
cleanup:
- if (G_IS_OBJECT(mail_op))
- g_object_unref (G_OBJECT (mail_op));
+ if (G_IS_OBJECT (src_folder))
+ g_object_unref (src_folder);
if (G_IS_OBJECT(folder))
g_object_unref (G_OBJECT (folder));
if (G_IS_OBJECT(headers))
g_object_unref (info->src_folder);
if (info->dst_folder)
g_object_unref (info->dst_folder);
- if (info->folder_view)
- g_object_unref (info->folder_view);
g_slice_free (DndFolderInfo, info);
}
GtkWindow *parent_window,
TnyAccount *account)
{
- time_t dnd_time = info->helper->time;
- GdkDragContext *context = info->helper->context;
-
/* Show error */
modest_ui_actions_on_account_connection_error (parent_window, account);
/* Free the helper & info */
dnd_helper_destroyer (info->helper);
dnd_folder_info_destroyer (info);
-
- /* Notify the drag source. Never call delete, the monitor will
- do the job if needed */
- gtk_drag_finish (context, FALSE, FALSE, dnd_time);
- return;
}
static void
info->dst_folder,
info->helper->delete_source,
xfer_folder_cb,
- info->helper);
-
-/* modest_folder_view_select_folder (MODEST_FOLDER_VIEW(info->folder_view), */
-/* TNY_FOLDER (info->dst_folder), TRUE); */
+ info->helper->folder_view);
+ /* Frees */
g_object_unref (G_OBJECT (mail_op));
+ dnd_helper_destroyer (info->helper);
+ dnd_folder_info_destroyer (info);
}
win = modest_window_mgr_get_main_window (modest_runtime_get_window_mgr(), FALSE); /* don't create */
if (!win) {
g_warning ("%s: BUG: no main window", __FUNCTION__);
+ dnd_helper_destroyer (helper);
return;
}
/* Check if the drag is possible */
if (forbidden || !gtk_tree_path_compare (helper->source_row, dest_row)) {
- gtk_drag_finish (helper->context, FALSE, FALSE, helper->time);
- gtk_tree_path_free (helper->source_row);
- g_slice_free (DndHelper, helper);
+ dnd_helper_destroyer (helper);
return;
}
info = g_slice_new (DndFolderInfo);
info->src_folder = g_object_ref (folder);
info->dst_folder = g_object_ref (dest_folder);
- info->folder_view = g_object_ref (helper->folder_view);
info->helper = helper;
/* Connect to the destination folder and perform the copy/move */
GtkTreeModel *dest_model, *source_model;
GtkTreePath *source_row, *dest_row;
GtkTreeViewDropPosition pos;
- gboolean success = FALSE, delete_source = FALSE;
- DndHelper *helper = NULL;
+ gboolean delete_source = FALSE;
+ gboolean success = FALSE;
/* Do not allow further process */
g_signal_stop_emission_by_name (widget, "drag-data-received");
/* Check if the get_data failed */
if (selection_data == NULL || selection_data->length < 0)
- gtk_drag_finish (context, success, FALSE, time);
+ goto end;
/* Select the destination model */
- dest_model = gtk_tree_view_get_model (GTK_TREE_VIEW (widget));
+ dest_model = gtk_tree_view_get_model (GTK_TREE_VIEW (widget));
/* Get the path to the destination row. Can not call
gtk_tree_view_get_drag_dest_row() because the source row
if (!dest_row ||
pos == GTK_TREE_VIEW_DROP_BEFORE ||
pos == GTK_TREE_VIEW_DROP_AFTER)
- gtk_drag_finish (context, success, FALSE, time);
-
- /* Create the helper */
- helper = g_slice_new0 (DndHelper);
- helper->delete_source = delete_source;
- helper->context = context;
- helper->time = time;
- helper->folder_view = g_object_ref (widget);
+ goto end;
+ success = TRUE;
/* Drags from the header view */
if (source_widget != widget) {
source_model = gtk_tree_view_get_model (GTK_TREE_VIEW (source_widget));
drag_and_drop_from_header_view (source_model,
dest_model,
dest_row,
- selection_data,
- helper);
+ selection_data);
} else {
+ DndHelper *helper = NULL;
+
/* Get the source model and row */
gtk_tree_get_row_drag_data (selection_data,
&source_model,
&source_row);
+
+ /* Create the helper */
+ helper = g_slice_new0 (DndHelper);
+ helper->delete_source = delete_source;
helper->source_row = gtk_tree_path_copy (source_row);
+ helper->folder_view = MODEST_FOLDER_VIEW (widget);
drag_and_drop_from_folder_view (source_model,
dest_model,
/* Frees */
gtk_tree_path_free (dest_row);
+
+ end:
+ /* Finish the drag and drop */
+ gtk_drag_finish (context, success, FALSE, time);
}
/*
priv->folder_to_select = g_object_ref (instance);
}
g_object_unref (instance);
-
if (priv->folder_to_select) {
gtk_tree_selection_select_iter (sel, iter);
gtk_tree_view_set_cursor (GTK_TREE_VIEW(self), path, NULL, FALSE);
- gtk_tree_path_free (path);
-
+ gtk_tree_path_free (path);
}
/* Disable next */
projects / modest / blobdiff