Fixes NB#63571
[modest] / src / widgets / modest-folder-view.c
index b400c29..f91f587 100644 (file)
@@ -76,7 +76,8 @@ static void         tny_account_store_view_init (gpointer g,
 static void         modest_folder_view_set_account_store (TnyAccountStoreView *self, 
                                                          TnyAccountStore     *account_store);
 
-static void         on_selection_changed   (GtkTreeSelection *sel, gpointer data);
+static void         on_selection_changed   (GtkTreeSelection *sel, 
+                                           gpointer data);
 
 static void         on_account_removed     (TnyAccountStore *self, 
                                            TnyAccount *account,
@@ -376,7 +377,6 @@ text_cell_data  (GtkTreeViewColumn *column,
                            TNY_GTK_FOLDER_STORE_TREE_MODEL_TYPE_COLUMN, &type,
                            TNY_GTK_FOLDER_STORE_TREE_MODEL_INSTANCE_COLUMN, &instance,
                            -1);
-
        if (!fname)
                return;
 
@@ -855,7 +855,7 @@ get_folder_icons (TnyFolderType type, GObject *instance)
            if (!normal_pixbuf_open) {
                GdkPixbuf *emblem = modest_platform_get_icon ("qgn_list_gene_fldr_exp");
                normal_pixbuf_open = gdk_pixbuf_copy (normal_pixbuf);
-               gdk_pixbuf_composite (emblem, draft_pixbuf_open, 0, 0, 
+               gdk_pixbuf_composite (emblem, normal_pixbuf_open, 0, 0, 
                                      MIN (gdk_pixbuf_get_width (emblem), 
                                           gdk_pixbuf_get_width (normal_pixbuf_open)),
                                      MIN (gdk_pixbuf_get_height (emblem), 
@@ -1222,7 +1222,6 @@ on_account_changed (TnyAccountStore *account_store,
                    TnyAccount *tny_account,
                    gpointer user_data)
 {
-       /* do nothing */
        ModestFolderViewPrivate *priv;
        GtkTreeModel *sort_model, *filter_model;
 
@@ -1236,7 +1235,7 @@ on_account_changed (TnyAccountStore *account_store,
        /* Get the inner model */
        filter_model = gtk_tree_view_get_model (GTK_TREE_VIEW (user_data));
        sort_model = gtk_tree_model_filter_get_model (GTK_TREE_MODEL_FILTER (filter_model));
-       
+
        /* Remove the account from the model */
        tny_list_remove (TNY_LIST (gtk_tree_model_sort_get_model (GTK_TREE_MODEL_SORT (sort_model))),
                         G_OBJECT (tny_account));
@@ -1249,6 +1248,19 @@ on_account_changed (TnyAccountStore *account_store,
        gtk_tree_model_filter_refilter (GTK_TREE_MODEL_FILTER (filter_model));
 }
 
+/**
+ *
+ * Selects the first inbox or the local account in an idle
+ */
+static gboolean
+on_idle_select_first_inbox_or_local (gpointer user_data)
+{
+       ModestFolderView *self = MODEST_FOLDER_VIEW (user_data);
+
+       modest_folder_view_select_first_inbox_or_local (self);
+
+       return FALSE;
+}
 
 
 static void
@@ -1260,6 +1272,7 @@ on_account_removed (TnyAccountStore *account_store,
        ModestFolderViewPrivate *priv;
        GtkTreeModel *sort_model, *filter_model;
        GtkTreeSelection *sel = NULL;
+       gboolean same_account_selected = FALSE;
 
        /* Ignore transport account removals, we're not showing them
           in the folder view */
@@ -1285,6 +1298,7 @@ on_account_removed (TnyAccountStore *account_store,
                if (selected_folder_account == account) {
                        sel = gtk_tree_view_get_selection (GTK_TREE_VIEW (self));
                        gtk_tree_selection_unselect_all (sel);
+                       same_account_selected = TRUE;
                }
                g_object_unref (selected_folder_account);
        }
@@ -1296,7 +1310,7 @@ on_account_removed (TnyAccountStore *account_store,
 
                folder_to_select_account = tny_folder_get_account (priv->folder_to_select);
                if (folder_to_select_account == account) {
-/*                     modest_folder_view_disable_next_folder_selection (self); */
+                       modest_folder_view_disable_next_folder_selection (self);
                        g_object_unref (priv->folder_to_select);
                        priv->folder_to_select = NULL;
                }
@@ -1327,16 +1341,8 @@ on_account_removed (TnyAccountStore *account_store,
 
        /* Select the first INBOX if the currently selected folder
           belongs to the account that is being deleted */
-       if (priv->cur_folder_store) {
-               TnyAccount *folder_selected_account;
-
-               folder_selected_account = (TNY_IS_FOLDER (priv->cur_folder_store)) ?
-                       modest_tny_folder_get_account (TNY_FOLDER (priv->cur_folder_store)) :
-                       TNY_ACCOUNT (g_object_ref (priv->cur_folder_store));
-               if (account == folder_selected_account)
-                       modest_folder_view_select_first_inbox_or_local (self);
-               g_object_unref (folder_selected_account);
-       }
+       if (same_account_selected)
+               g_idle_add (on_idle_select_first_inbox_or_local, self);
 }
 
 void
@@ -1344,7 +1350,7 @@ modest_folder_view_set_title (ModestFolderView *self, const gchar *title)
 {
        GtkTreeViewColumn *col;
        
-       g_return_if_fail (self);
+       g_return_if_fail (self && MODEST_IS_FOLDER_VIEW(self));
 
        col = gtk_tree_view_get_column (GTK_TREE_VIEW(self), 0);
        if (!col) {
@@ -1440,9 +1446,7 @@ expand_root_items (ModestFolderView *self)
  * account in this case, and the local folders.
  */
 static gboolean 
-filter_row (GtkTreeModel *model,
-           GtkTreeIter *iter,
-           gpointer data)
+filter_row (GtkTreeModel *model, GtkTreeIter *iter, gpointer data)
 {
        ModestFolderViewPrivate *priv;
        gboolean retval = TRUE;
@@ -1550,9 +1554,10 @@ modest_folder_view_update_model (ModestFolderView *self,
        GtkTreeModel *model /* , *old_model */;                                                    
        GtkTreeModel *filter_model = NULL, *sortable = NULL;
 
-       g_return_val_if_fail (MODEST_IS_FOLDER_VIEW (self), FALSE);
-       g_return_val_if_fail (account_store, FALSE);
-
+       g_return_val_if_fail (self && MODEST_IS_FOLDER_VIEW (self), FALSE);
+       g_return_val_if_fail (account_store && MODEST_IS_TNY_ACCOUNT_STORE(account_store),
+                             FALSE);
+       
        priv =  MODEST_FOLDER_VIEW_GET_PRIVATE(self);
        
        /* Notify that there is no folder selected */
@@ -1659,18 +1664,21 @@ on_selection_changed (GtkTreeSelection *sel, gpointer user_data)
        /* New current references */
        priv->cur_folder_store = folder;
 
-       /* New folder has been selected */
-       g_signal_emit (G_OBJECT(tree_view),
-                      signals[FOLDER_SELECTION_CHANGED_SIGNAL],
-                      0, priv->cur_folder_store, TRUE);
+       /* New folder has been selected. Do not notify if there is
+          nothing new selected */
+       if (selected) {
+               g_signal_emit (G_OBJECT(tree_view),
+                              signals[FOLDER_SELECTION_CHANGED_SIGNAL],
+                              0, priv->cur_folder_store, TRUE);
+       }
 }
 
 TnyFolderStore *
 modest_folder_view_get_selected (ModestFolderView *self)
 {
        ModestFolderViewPrivate *priv;
-
-       g_return_val_if_fail (self, NULL);
+       
+       g_return_val_if_fail (self && MODEST_IS_FOLDER_VIEW(self), NULL);
        
        priv = MODEST_FOLDER_VIEW_GET_PRIVATE(self);
        if (priv->cur_folder_store)
@@ -1858,18 +1866,14 @@ finish:
  * source for dnd after the event drop happened
  */
 static void
-on_drag_data_get (GtkWidget *widget, 
-                 GdkDragContext *context, 
-                 GtkSelectionData *selection_data, 
-                 guint info, 
-                 guint time, 
-                 gpointer data)
+on_drag_data_get (GtkWidget *widget, GdkDragContext *context, GtkSelectionData *selection_data, 
+                 guint info, guint time, gpointer data)
 {
        GtkTreeSelection *selection;
        GtkTreeModel *model;
        GtkTreeIter iter;
        GtkTreePath *source_row;
-
+       
        selection = gtk_tree_view_get_selection (GTK_TREE_VIEW (widget));
        if (gtk_tree_selection_get_selected (selection, &model, &iter)) {
 
@@ -2144,7 +2148,7 @@ drag_and_drop_from_folder_view_dst_folder_performer (gboolean canceled,
        }
 
        /* Connect to source folder and perform the copy/move */
-       modest_platform_connect_and_perform_if_network_folderstore (NULL, 
+       modest_platform_connect_if_remote_and_perform (NULL, 
                                                                    info->src_folder,
                                                                    drag_and_drop_from_folder_view_src_folder_performer,
                                                                    info);
@@ -2228,7 +2232,7 @@ drag_and_drop_from_folder_view (GtkTreeModel     *source_model,
        info->helper = helper;
 
        /* Connect to the destination folder and perform the copy/move */
-       modest_platform_connect_and_perform_if_network_folderstore (GTK_WINDOW (win), 
+       modest_platform_connect_if_remote_and_perform (GTK_WINDOW (win), 
                                                                    dest_folder,
                                                                    drag_and_drop_from_folder_view_dst_folder_performer,
                                                                    info);
@@ -2423,7 +2427,7 @@ on_drag_motion (GtkWidget      *widget,
        ModestFolderViewPrivate *priv;
        GdkDragAction suggested_action;
        gboolean valid_location = FALSE;
-       TnyFolderStore *folder;
+       TnyFolderStore *folder = NULL;
 
        priv = MODEST_FOLDER_VIEW_GET_PRIVATE (widget);
 
@@ -2460,7 +2464,6 @@ on_drag_motion (GtkWidget      *widget,
                        goto out;
                }
        }
-       g_object_unref (folder);
 
        /* Expand the selected row after 1/2 second */
        if (!gtk_tree_view_row_expanded (GTK_TREE_VIEW (widget), dest_row)) {
@@ -2481,6 +2484,8 @@ on_drag_motion (GtkWidget      *widget,
             gdk_drag_status(context, GDK_ACTION_DEFAULT, time);
 
  out:
+       if (folder)
+               g_object_unref (folder);
        if (dest_row)
                gtk_tree_path_free (dest_row);
        g_signal_stop_emission_by_name (widget, "drag-motion");
@@ -2618,10 +2623,13 @@ modest_folder_view_set_style (ModestFolderView *self,
 {
        ModestFolderViewPrivate *priv;
 
-       g_return_if_fail (self);
+       g_return_if_fail (self && MODEST_IS_FOLDER_VIEW(self));
+       g_return_if_fail (style == MODEST_FOLDER_VIEW_STYLE_SHOW_ALL ||
+                         style == MODEST_FOLDER_VIEW_STYLE_SHOW_ONE);
        
        priv = MODEST_FOLDER_VIEW_GET_PRIVATE(self);
 
+       
        priv->style = style;
 }
 
@@ -2632,7 +2640,7 @@ modest_folder_view_set_account_id_of_visible_server_account (ModestFolderView *s
        ModestFolderViewPrivate *priv;
        GtkTreeModel *model;
 
-       g_return_if_fail (self);
+       g_return_if_fail (self && MODEST_IS_FOLDER_VIEW(self));
        
        priv = MODEST_FOLDER_VIEW_GET_PRIVATE(self);
 
@@ -2660,7 +2668,7 @@ modest_folder_view_get_account_id_of_visible_server_account (ModestFolderView *s
 {
        ModestFolderViewPrivate *priv;
 
-       g_return_val_if_fail (self, NULL);
+       g_return_val_if_fail (self && MODEST_IS_FOLDER_VIEW(self), NULL);
        
        priv = MODEST_FOLDER_VIEW_GET_PRIVATE(self);
 
@@ -2708,6 +2716,8 @@ modest_folder_view_select_first_inbox_or_local (ModestFolderView *self)
        GtkTreeSelection *sel;
        GtkTreePath *path = NULL;
 
+       g_return_if_fail (self && MODEST_IS_FOLDER_VIEW(self));
+       
        model = gtk_tree_view_get_model (GTK_TREE_VIEW (self));
        if (!model)
                return;
@@ -2818,6 +2828,9 @@ on_row_inserted_maybe_select_folder (GtkTreeModel *tree_model, GtkTreePath  *pat
                modest_folder_view_disable_next_folder_selection (self);
 /*             g_object_unref (priv->folder_to_select); */
 /*             priv->folder_to_select = NULL; */
+               
+               /* Refilter the model */
+               gtk_tree_model_filter_refilter (GTK_TREE_MODEL_FILTER (tree_model));
        }
 }
 
@@ -2825,9 +2838,10 @@ on_row_inserted_maybe_select_folder (GtkTreeModel *tree_model, GtkTreePath  *pat
 void
 modest_folder_view_disable_next_folder_selection (ModestFolderView *self) 
 {
-       ModestFolderViewPrivate *priv = NULL;
+       ModestFolderViewPrivate *priv;
+
+       g_return_if_fail (self && MODEST_IS_FOLDER_VIEW(self));
 
-       g_return_if_fail (MODEST_IS_FOLDER_VIEW (self));        
        priv = MODEST_FOLDER_VIEW_GET_PRIVATE (self);
 
        if (priv->folder_to_select)
@@ -2845,13 +2859,12 @@ modest_folder_view_select_folder (ModestFolderView *self, TnyFolder *folder,
        GtkTreeSelection *sel;
        ModestFolderViewPrivate *priv = NULL;
        
-       g_return_val_if_fail (MODEST_IS_FOLDER_VIEW (self), FALSE);     
-       g_return_val_if_fail (TNY_IS_FOLDER (folder), FALSE);   
+       g_return_val_if_fail (self && MODEST_IS_FOLDER_VIEW (self), FALSE);     
+       g_return_val_if_fail (folder && TNY_IS_FOLDER (folder), FALSE); 
                
        priv = MODEST_FOLDER_VIEW_GET_PRIVATE (self);
 
        if (after_change) {
-
                sel = gtk_tree_view_get_selection (GTK_TREE_VIEW (self));
                gtk_tree_selection_unselect_all (sel);
 
@@ -2888,10 +2901,12 @@ modest_folder_view_select_folder (ModestFolderView *self, TnyFolder *folder,
 
 
 void 
-modest_folder_view_copy_selection (ModestFolderView *folder_view)
+modest_folder_view_copy_selection (ModestFolderView *self)
 {
+       g_return_if_fail (self && MODEST_IS_FOLDER_VIEW(self));
+       
        /* Copy selection */
-       _clipboard_set_selected_data (folder_view, FALSE);
+       _clipboard_set_selected_data (self, FALSE);
 }
 
 void 
@@ -2902,7 +2917,7 @@ modest_folder_view_cut_selection (ModestFolderView *folder_view)
        const gchar **hidding = NULL;
        guint i, n_selected;
 
-       g_return_if_fail (MODEST_IS_FOLDER_VIEW (folder_view));
+       g_return_if_fail (folder_view && MODEST_IS_FOLDER_VIEW (folder_view));
        priv = MODEST_FOLDER_VIEW_GET_PRIVATE (folder_view);
 
        /* Copy selection */
@@ -2934,9 +2949,9 @@ modest_folder_view_copy_model (ModestFolderView *folder_view_src,
        GtkTreeModel *model = NULL;
        GtkTreeModel *new_filter_model = NULL;
        
-       g_return_if_fail (MODEST_IS_FOLDER_VIEW (folder_view_src));
-       g_return_if_fail (MODEST_IS_FOLDER_VIEW (folder_view_dst));
-
+       g_return_if_fail (folder_view_src && MODEST_IS_FOLDER_VIEW (folder_view_src));
+       g_return_if_fail (folder_view_dst && MODEST_IS_FOLDER_VIEW (folder_view_dst));
+       
        /* Get src model*/
        filter_model = gtk_tree_view_get_model (GTK_TREE_VIEW (folder_view_src));
        model = gtk_tree_model_filter_get_model (GTK_TREE_MODEL_FILTER(filter_model));
@@ -2961,7 +2976,11 @@ modest_folder_view_show_non_move_folders (ModestFolderView *folder_view,
                                          gboolean show)
 {
        GtkTreeModel *model = NULL;
-       ModestFolderViewPrivate* priv = MODEST_FOLDER_VIEW_GET_PRIVATE(folder_view);
+       ModestFolderViewPrivate* priv;
+
+       g_return_if_fail (folder_view && MODEST_IS_FOLDER_VIEW (folder_view));
+
+       priv = MODEST_FOLDER_VIEW_GET_PRIVATE(folder_view);     
        priv->show_non_move = show;
 /*     modest_folder_view_update_model(folder_view, */
 /*                                     TNY_ACCOUNT_STORE(modest_runtime_get_account_store())); */