LImit the number of changes for correcting scroll to avoid infinite loop.
[modest] / src / widgets / modest-gtkhtml-msg-view.c
index 8ca07e3..d35ea17 100644 (file)
@@ -86,6 +86,7 @@ static gboolean on_activate_link (GtkWidget *widget, const gchar *uri, ModestGtk
 static gboolean on_fetch_url (GtkWidget *widget, const gchar *uri, TnyStream *stream,
                              ModestGtkhtmlMsgView *msg_view);
 static gboolean on_link_hover (GtkWidget *widget, const gchar *uri, ModestGtkhtmlMsgView *msg_view);
+static void on_limit_error (GtkWidget *widget, ModestGtkhtmlMsgView *msg_view);
 
 #ifdef MAEMO_CHANGES
 static void     on_tap_and_hold (GtkWidget *widget, gpointer userdata); 
@@ -186,6 +187,7 @@ static TnyList *modest_gtkhtml_msg_view_get_attachments (ModestMsgView *self);
 static void modest_gtkhtml_msg_view_grab_focus (ModestMsgView *self);
 static void modest_gtkhtml_msg_view_remove_attachment (ModestMsgView *view, TnyMimePart *attachment);
 static void modest_gtkhtml_msg_view_request_fetch_images (ModestMsgView *view);
+static void modest_gtkhtml_msg_view_set_branding (ModestMsgView *view, const gchar *brand_name, const GdkPixbuf *brand_icon);
 static gboolean modest_gtkhtml_msg_view_has_blocked_external_images (ModestMsgView *view);
 static void modest_gtkhtml_msg_view_set_msg_with_other_body_default (ModestMsgView *view, TnyMsg *msg, TnyMimePart *part);
 static GtkAdjustment *modest_gtkhtml_msg_view_get_vadjustment_default (ModestMsgView *self);
@@ -202,6 +204,7 @@ static void modest_gtkhtml_msg_view_grab_focus_default (ModestMsgView *self);
 static void modest_gtkhtml_msg_view_remove_attachment_default (ModestMsgView *view, TnyMimePart *attachment);
 static gboolean modest_gtkhtml_msg_view_has_blocked_external_images_default (ModestMsgView *view);
 static void modest_gtkhtml_msg_view_request_fetch_images_default (ModestMsgView *view);
+static void modest_gtkhtml_msg_view_set_branding_default (ModestMsgView *view, const gchar *brand_name, const GdkPixbuf *brand_icon);
 
 /* internal api */
 static void     set_header     (ModestGtkhtmlMsgView *self, TnyHeader *header);
@@ -225,6 +228,7 @@ static TnyList *get_attachments (ModestGtkhtmlMsgView *self);
 static void grab_focus (ModestGtkhtmlMsgView *self);
 static void remove_attachment (ModestGtkhtmlMsgView *view, TnyMimePart *attachment);
 static void request_fetch_images (ModestGtkhtmlMsgView *view);
+static void set_branding (ModestGtkhtmlMsgView *view, const gchar *brand_name, const GdkPixbuf *brand_icon);
 static gboolean has_blocked_external_images (ModestGtkhtmlMsgView *view);
 
 /* list properties */
@@ -266,6 +270,10 @@ struct _ModestGtkhtmlMsgViewPrivate {
        /* id handler for dragged scroll */
        guint idle_motion_id;
 
+       /* idle changes count */
+       gint idle_changes_count;
+       guint idle_readjust_scroll_id;
+
        /* zoom */
        gdouble current_zoom;
 
@@ -433,6 +441,7 @@ modest_gtkhtml_msg_view_class_init (ModestGtkhtmlMsgViewClass *klass)
        klass->grab_focus_func = modest_gtkhtml_msg_view_grab_focus_default;
        klass->remove_attachment_func = modest_gtkhtml_msg_view_remove_attachment_default;
        klass->request_fetch_images_func = modest_gtkhtml_msg_view_request_fetch_images_default;
+       klass->set_branding_func = modest_gtkhtml_msg_view_set_branding_default;
        klass->has_blocked_external_images_func = modest_gtkhtml_msg_view_has_blocked_external_images_default;
 
        g_type_class_add_private (gobject_class, sizeof(ModestGtkhtmlMsgViewPrivate));
@@ -592,6 +601,8 @@ set_hadjustment_values (ModestGtkhtmlMsgView *self,
 {
        GtkAllocation view_allocation;
        GtkAdjustment *hadj = get_hadjustment (self);
+       gint full_width = 0;
+       ModestGtkhtmlMsgViewPrivate *priv = MODEST_GTKHTML_MSG_VIEW_GET_PRIVATE (self);
 
        get_view_allocation (self, &view_allocation);
        hadj->page_size = view_allocation.width;
@@ -601,11 +612,20 @@ set_hadjustment_values (ModestGtkhtmlMsgView *self,
        hadj->lower = 0;
        hadj->upper = view_allocation.width;
 
+       /* Get the real width of the embedded html */
+       if (priv->html_scroll && GTK_WIDGET_VISIBLE(priv->html_scroll)) {
+               GtkAdjustment *html_hadj;
+               html_hadj = gtk_scrolled_window_get_hadjustment (GTK_SCROLLED_WINDOW (priv->html_scroll));
+               full_width += html_hadj->upper;
+       }
+
+       hadj->upper = MAX (view_allocation.width, full_width);
+
        reclamp_adjustment (hadj, value_changed);
 
 }
 
-static void 
+static void
 set_vadjustment_values (ModestGtkhtmlMsgView *self,
                        gboolean *value_changed)
 {
@@ -892,6 +912,12 @@ size_allocate (GtkWidget *widget,
             allocation->height != widget->allocation.height))
                gdk_window_invalidate_rect (widget->window, NULL, FALSE);
 
+       if (priv->idle_readjust_scroll_id == 0 && priv->idle_changes_count < 5 && widget->allocation.width != allocation->width) {
+               g_object_ref (self);
+               priv->idle_readjust_scroll_id = g_idle_add ((GSourceFunc) idle_readjust_scroll, self);
+               priv->idle_changes_count ++;
+       }
+
        widget->allocation = *allocation;
        set_hadjustment_values (self, &hadj_value_changed);
        set_vadjustment_values (self, &vadj_value_changed);
@@ -1040,27 +1066,42 @@ html_adjustment_changed (GtkAdjustment *adj,
 gboolean
 idle_readjust_scroll (ModestGtkhtmlMsgView *self)
 {
+       ModestGtkhtmlMsgViewPrivate *priv = MODEST_GTKHTML_MSG_VIEW_GET_PRIVATE (self);
 
        /* We're out the main lock */
        gdk_threads_enter ();
 
        if (GTK_WIDGET_DRAWABLE (self)) {
-               ModestGtkhtmlMsgViewPrivate *priv = MODEST_GTKHTML_MSG_VIEW_GET_PRIVATE (self);
                GtkAdjustment *html_vadj;
+               GtkAdjustment *html_hadj;
+
                html_vadj = gtk_scrolled_window_get_vadjustment (GTK_SCROLLED_WINDOW (priv->html_scroll));
-               html_vadj->page_size = html_vadj->upper;
-               gtk_adjustment_changed (html_vadj);
-               gtk_widget_queue_resize (GTK_WIDGET (self));
-               gtk_widget_queue_draw (GTK_WIDGET (self));
+               html_vadj->upper = 0;
+               html_vadj->page_size = 0;
+               g_signal_emit_by_name (G_OBJECT (html_vadj), "changed");
+
+               html_hadj = gtk_scrolled_window_get_hadjustment (GTK_SCROLLED_WINDOW (priv->html_scroll));
+               html_hadj->upper = 0;
+               html_hadj->page_size = 0;
+               g_signal_emit_by_name (G_OBJECT (html_hadj), "changed");
+
+               gtk_widget_set_size_request (GTK_WIDGET (priv->body_view), 1, 1);
+               gtk_widget_set_size_request (GTK_WIDGET (priv->body_view), -1, -1);
+
+               gtk_widget_queue_resize (GTK_WIDGET (priv->body_view));
+               gtk_widget_queue_draw (GTK_WIDGET (priv->body_view));
 
                /* Just another hack for making readjust really work. This forces an update
                 * of the scroll, and then, make the scroll really update properly the
                 * the size and not corrupt scrollable area */
                gtk_adjustment_set_value (priv->vadj, 1.0);
                gtk_adjustment_set_value (priv->vadj, 0.0);
+
        }
+       priv->idle_readjust_scroll_id = 0;
        g_object_unref (G_OBJECT (self));
 
+
        gdk_threads_leave ();
 
        return FALSE;
@@ -1071,7 +1112,6 @@ modest_gtkhtml_msg_view_init (ModestGtkhtmlMsgView *obj)
 {
        ModestGtkhtmlMsgViewPrivate *priv;
        GtkAdjustment *html_vadj;
-       GtkWidget *separator;
 
        GTK_WIDGET_UNSET_FLAGS (obj, GTK_NO_WINDOW);
        gtk_widget_set_redraw_on_allocate (GTK_WIDGET (obj), TRUE);
@@ -1080,6 +1120,8 @@ modest_gtkhtml_msg_view_init (ModestGtkhtmlMsgView *obj)
        
        priv = MODEST_GTKHTML_MSG_VIEW_GET_PRIVATE(obj);
 
+       priv->idle_changes_count = 0;
+       priv->idle_readjust_scroll_id = 0;
        priv->current_zoom = 1.0;
 
        priv->hadj = NULL;
@@ -1121,6 +1163,8 @@ modest_gtkhtml_msg_view_init (ModestGtkhtmlMsgView *obj)
                                       G_CALLBACK(on_fetch_url), obj);
        g_signal_connect (G_OBJECT(priv->body_view), "link_hover",
                                       G_CALLBACK(on_link_hover), obj);
+       g_signal_connect (G_OBJECT(priv->body_view), "limit_error",
+                         G_CALLBACK(on_limit_error), obj);
 #ifdef MAEMO_CHANGES
        g_signal_connect (G_OBJECT(priv->body_view), "motion-notify-event",
                          G_CALLBACK (motion_notify_event), obj);
@@ -1180,8 +1224,10 @@ modest_gtkhtml_msg_view_init (ModestGtkhtmlMsgView *obj)
                g_free (att_label);
        }
 
+#ifndef MODEST_TOOLKIT_HILDON2
        separator = gtk_hseparator_new ();
        gtk_box_pack_start (GTK_BOX(priv->headers_box), separator, FALSE, FALSE, 0);
+#endif
 
        gtk_widget_set_parent (priv->headers_box, GTK_WIDGET (obj));
 
@@ -1209,6 +1255,11 @@ modest_gtkhtml_msg_view_finalize (GObject *obj)
                priv->msg = NULL;
        }
 
+       if (priv->idle_readjust_scroll_id > 0) {
+               g_source_remove (priv->idle_readjust_scroll_id);
+               priv->idle_readjust_scroll_id = 0;
+       }
+
        if (priv->idle_motion_id > 0) {
                g_source_remove (priv->idle_motion_id);
                priv->idle_motion_id = 0;
@@ -1507,6 +1558,14 @@ request_fetch_images (ModestGtkhtmlMsgView *self)
        }
 }
 
+static void
+set_branding (ModestGtkhtmlMsgView *self, const gchar *brand_name, const GdkPixbuf *brand_icon)
+{
+       ModestGtkhtmlMsgViewPrivate *priv = MODEST_GTKHTML_MSG_VIEW_GET_PRIVATE (self);
+
+       modest_mail_header_view_set_branding (MODEST_MAIL_HEADER_VIEW (priv->mail_header_view), brand_name, brand_icon);
+}
+
 static gboolean
 has_blocked_external_images (ModestGtkhtmlMsgView *self)
 {
@@ -1542,6 +1601,11 @@ on_link_hover (GtkWidget *widget, const gchar *uri, ModestGtkhtmlMsgView *self)
        return result;
 }
 
+static void 
+on_limit_error (GtkWidget *widget, ModestGtkhtmlMsgView *msg_view)
+{
+       g_signal_emit_by_name (G_OBJECT (msg_view), "limit-error");
+}
 
 
 static TnyMimePart *
@@ -1669,7 +1733,7 @@ set_message (ModestGtkhtmlMsgView *self, TnyMsg *msg, TnyMimePart *other_body)
        TnyMimePart *body;
        ModestGtkhtmlMsgViewPrivate *priv;
        TnyHeader *header;
-       GtkAdjustment *html_vadj;
+       GtkAdjustment *html_vadj, *html_hadj;
 
        g_return_if_fail (self);
 
@@ -1678,12 +1742,6 @@ set_message (ModestGtkhtmlMsgView *self, TnyMsg *msg, TnyMimePart *other_body)
        gtk_widget_set_no_show_all (priv->mail_header_view, FALSE);
        modest_mime_part_view_set_view_images (MODEST_MIME_PART_VIEW (priv->body_view), FALSE);
 
-       html_vadj = gtk_scrolled_window_get_vadjustment (GTK_SCROLLED_WINDOW (priv->html_scroll));
-       html_vadj->upper = 0;
-       html_vadj->page_size = 0;
-       g_signal_emit_by_name (G_OBJECT (html_vadj), "changed");
-
-
        if (msg != priv->msg) {
                if (priv->msg)
                        g_object_unref (G_OBJECT(priv->msg));
@@ -1702,6 +1760,23 @@ set_message (ModestGtkhtmlMsgView *self, TnyMsg *msg, TnyMimePart *other_body)
 #endif
                gtk_widget_set_no_show_all (priv->mail_header_view, TRUE);
                tny_mime_part_view_clear (TNY_MIME_PART_VIEW (priv->body_view));
+
+               html_vadj = gtk_scrolled_window_get_vadjustment (GTK_SCROLLED_WINDOW (priv->html_scroll));
+               html_vadj->upper = 0;
+               html_vadj->page_size = 0;
+               g_signal_emit_by_name (G_OBJECT (html_vadj), "changed");
+
+               html_hadj = gtk_scrolled_window_get_hadjustment (GTK_SCROLLED_WINDOW (priv->html_scroll));
+               html_hadj->upper = 0;
+               html_hadj->page_size = 0;
+               g_signal_emit_by_name (G_OBJECT (html_hadj), "changed");
+
+               gtk_widget_set_size_request (GTK_WIDGET (priv->body_view), 1, 1);
+               gtk_widget_set_size_request (GTK_WIDGET (priv->body_view), -1, -1);
+
+               priv->idle_changes_count = 0;
+               gtk_widget_queue_resize (GTK_WIDGET (priv->body_view));
+
                gtk_widget_queue_resize (GTK_WIDGET(self));
                gtk_widget_queue_draw (GTK_WIDGET(self));
                return;
@@ -1737,11 +1812,15 @@ set_message (ModestGtkhtmlMsgView *self, TnyMsg *msg, TnyMimePart *other_body)
                        children = gtk_container_get_children (GTK_CONTAINER (priv->attachments_box));
                        label = GTK_LABEL (children->data);
                        gtk_widget_show_all (priv->attachments_box);
+#ifdef MODEST_TOOLKIT_HILDON2
                        if (modest_attachments_view_get_num_attachments (widget) > 1) {
                                text = _("mail_va_attachments");
                        } else {
                                text = _("mail_va_attachment");
                        }
+#else
+                               text = _("mail_va_attachment");
+#endif
                        gtk_label_set_text (label, text);
                } else {
                        gtk_widget_hide_all (priv->attachments_box);
@@ -1765,6 +1844,23 @@ set_message (ModestGtkhtmlMsgView *self, TnyMsg *msg, TnyMimePart *other_body)
        gtk_widget_set_no_show_all (priv->priority_box, FALSE);
 #endif
        gtk_widget_set_no_show_all (priv->mail_header_view, TRUE);
+
+       html_vadj = gtk_scrolled_window_get_vadjustment (GTK_SCROLLED_WINDOW (priv->html_scroll));
+       html_vadj->upper = 0;
+       html_vadj->page_size = 0;
+       g_signal_emit_by_name (G_OBJECT (html_vadj), "changed");
+
+       html_hadj = gtk_scrolled_window_get_hadjustment (GTK_SCROLLED_WINDOW (priv->html_scroll));
+       html_hadj->upper = 0;
+       html_hadj->page_size = 0;
+       g_signal_emit_by_name (G_OBJECT (html_hadj), "changed");
+
+       gtk_widget_set_size_request (GTK_WIDGET (priv->body_view), 1, 1);
+       gtk_widget_set_size_request (GTK_WIDGET (priv->body_view), -1, -1);
+
+       priv->idle_changes_count = 0;
+       gtk_widget_queue_resize (GTK_WIDGET (priv->body_view));
+
        gtk_widget_queue_resize (GTK_WIDGET(self));
        gtk_widget_queue_draw (GTK_WIDGET(self));
 
@@ -1778,15 +1874,17 @@ set_message (ModestGtkhtmlMsgView *self, TnyMsg *msg, TnyMimePart *other_body)
        /* This is a hack to force reallocation of scroll after drawing all the stuff. This
         * makes the html view get the proper and expected size and prevent being able to scroll
         * the buffer when it shouldn't be scrollable */
-       g_object_ref (self);
-       g_timeout_add (250, (GSourceFunc) idle_readjust_scroll, self);
+       if (priv->idle_readjust_scroll_id == 0) {
+               g_object_ref (self);
+               priv->idle_readjust_scroll_id = g_idle_add ((GSourceFunc) idle_readjust_scroll, self);
+       }
 }
 
 static void
 set_header (ModestGtkhtmlMsgView *self, TnyHeader *header)
 {
        ModestGtkhtmlMsgViewPrivate *priv;
-       GtkAdjustment *html_vadj;
+       GtkAdjustment *html_vadj, *html_hadj;
        
        g_return_if_fail (self);
 
@@ -1805,6 +1903,15 @@ set_header (ModestGtkhtmlMsgView *self, TnyHeader *header)
        html_vadj->page_size = 0;
        g_signal_emit_by_name (G_OBJECT (html_vadj), "changed");
 
+       html_hadj = gtk_scrolled_window_get_hadjustment (GTK_SCROLLED_WINDOW (priv->html_scroll));
+       html_hadj->upper = 0;
+       html_hadj->page_size = 0;
+       g_signal_emit_by_name (G_OBJECT (html_hadj), "changed");
+
+       priv->idle_changes_count = 0;
+       gtk_widget_set_size_request (GTK_WIDGET (priv->body_view), 1, 1);
+       gtk_widget_set_size_request (GTK_WIDGET (priv->body_view), -1, -1);
+       gtk_widget_queue_resize (GTK_WIDGET (priv->body_view));
 
        if (priv->msg) {
                g_object_unref (G_OBJECT(priv->msg));
@@ -1820,6 +1927,7 @@ set_header (ModestGtkhtmlMsgView *self, TnyHeader *header)
 #endif
        gtk_widget_set_no_show_all (priv->mail_header_view, TRUE);
        tny_mime_part_view_clear (TNY_MIME_PART_VIEW (priv->body_view));
+       priv->idle_changes_count = 0;
        gtk_widget_queue_resize (GTK_WIDGET(self));
        gtk_widget_queue_draw (GTK_WIDGET(self));
 }
@@ -1852,12 +1960,27 @@ static void
 set_zoom (ModestGtkhtmlMsgView *self, gdouble zoom)
 {
        ModestGtkhtmlMsgViewPrivate *priv;
+       GtkAdjustment *html_vadj, *html_hadj;
 
        g_return_if_fail (MODEST_IS_GTKHTML_MSG_VIEW (self));
        priv = MODEST_GTKHTML_MSG_VIEW_GET_PRIVATE (self);
 
        modest_zoomable_set_zoom (MODEST_ZOOMABLE(priv->body_view), zoom);
 
+       html_vadj = gtk_scrolled_window_get_vadjustment (GTK_SCROLLED_WINDOW (priv->html_scroll));
+       html_vadj->upper = 0;
+       html_vadj->page_size = 0;
+       g_signal_emit_by_name (G_OBJECT (html_vadj), "changed");
+
+       html_hadj = gtk_scrolled_window_get_hadjustment (GTK_SCROLLED_WINDOW (priv->html_scroll));
+       html_hadj->upper = 0;
+       html_hadj->page_size = 0;
+       g_signal_emit_by_name (G_OBJECT (html_hadj), "changed");
+
+       gtk_widget_set_size_request (GTK_WIDGET (priv->body_view), 1, 1);
+       gtk_widget_set_size_request (GTK_WIDGET (priv->body_view), -1, -1);
+
+       priv->idle_changes_count = 0;
        gtk_widget_queue_resize (priv->body_view);
 }
 
@@ -2365,6 +2488,7 @@ modest_msg_view_init (gpointer g, gpointer iface_data)
        klass->grab_focus_func = modest_gtkhtml_msg_view_grab_focus;
        klass->remove_attachment_func = modest_gtkhtml_msg_view_remove_attachment;
        klass->request_fetch_images_func = modest_gtkhtml_msg_view_request_fetch_images;
+       klass->set_branding_func = modest_gtkhtml_msg_view_set_branding;
        klass->has_blocked_external_images_func = modest_gtkhtml_msg_view_has_blocked_external_images;
 
        return;
@@ -2538,6 +2662,18 @@ modest_gtkhtml_msg_view_request_fetch_images_default (ModestMsgView *self)
        request_fetch_images (MODEST_GTKHTML_MSG_VIEW (self));
 }
 
+static void
+modest_gtkhtml_msg_view_set_branding (ModestMsgView *self, const gchar *brand_name, const GdkPixbuf *brand_icon)
+{
+       MODEST_GTKHTML_MSG_VIEW_GET_CLASS (self)->set_branding_func (self, brand_name, brand_icon);
+}
+
+static void
+modest_gtkhtml_msg_view_set_branding_default (ModestMsgView *self, const gchar *brand_name, const GdkPixbuf *brand_icon)
+{
+       set_branding (MODEST_GTKHTML_MSG_VIEW (self), brand_name, brand_icon);
+}
+
 static gboolean
 modest_gtkhtml_msg_view_has_blocked_external_images (ModestMsgView *self)
 {