#include "widgets/modest-main-window.h"
#include "widgets/modest-msg-edit-window.h"
#include "widgets/modest-msg-view-window.h"
-/* include other impl specific header files */
+
/* 'private'/'protected' functions */
static void modest_window_mgr_class_init (ModestWindowMgrClass *klass);
static void modest_window_mgr_init (ModestWindowMgr *obj);
static void modest_window_mgr_finalize (GObject *obj);
-/* static void on_window_destroy (ModestWindow *window, */
-/* ModestWindowMgr *self); */
static gboolean on_window_destroy (ModestWindow *window,
GdkEvent *event,
ModestWindowMgr *self);
GSList *preregistered_uids;
GHashTable *destroy_handlers;
GHashTable *viewer_handlers;
+
+ guint closing_time;
};
#define MODEST_WINDOW_MGR_GET_PRIVATE(o) (G_TYPE_INSTANCE_GET_PRIVATE((o), \
MODEST_TYPE_WINDOW_MGR, \
priv->show_toolbars_fullscreen = FALSE;
priv->destroy_handlers = g_hash_table_new_full (g_direct_hash, g_direct_equal, NULL, g_free);
priv->viewer_handlers = g_hash_table_new_full (g_direct_hash, g_direct_equal, NULL, g_free);
+
+ priv->closing_time = 0;
}
static void
priv = MODEST_WINDOW_MGR_GET_PRIVATE (self);
uid = modest_tny_folder_get_header_unique_id (header);
-
- if (!has_uid (priv->preregistered_uids, uid))
+
+
+ if (!has_uid (priv->preregistered_uids, uid)) {
+ g_debug ("registering new uid %s", uid);
priv->preregistered_uids = append_uid (priv->preregistered_uids, uid);
+ } else
+ g_debug ("already had uid %s", uid);
g_free (uid);
}
priv = MODEST_WINDOW_MGR_GET_PRIVATE (self);
uid = modest_tny_folder_get_header_unique_id (header);
- if (has_uid (priv->preregistered_uids, uid))
+ if (!has_uid (priv->preregistered_uids, uid)) {
+ g_debug ("trying to unregister non-existing uid %s", uid);
+ priv->preregistered_uids = append_uid (priv->preregistered_uids, uid);
+ } else
+ g_debug ("unregistering uid %s", uid);
+
+ if (has_uid (priv->preregistered_uids, uid)) {
priv->preregistered_uids = remove_uid (priv->preregistered_uids, uid);
+ if (has_uid (priv->preregistered_uids, uid))
+ g_debug ("BUG: uid %s NOT removed", uid);
+ else
+ g_debug ("uid %s removed", uid);
+ }
g_free (uid);
}
{
const gchar *msg_uid;
- if (!MODEST_IS_MSG_VIEW_WINDOW (win))
+ if ((!MODEST_IS_MSG_EDIT_WINDOW (win)) && (!MODEST_IS_MSG_VIEW_WINDOW (win)))
return 1;
/* Get message uid from msg window */
- msg_uid = modest_msg_view_window_get_message_uid (MODEST_MSG_VIEW_WINDOW (win));
+ if (MODEST_IS_MSG_EDIT_WINDOW (win)) {
+ msg_uid = modest_msg_edit_window_get_message_uid (MODEST_MSG_EDIT_WINDOW (win));
+ } else {
+ msg_uid = modest_msg_view_window_get_message_uid (MODEST_MSG_VIEW_WINDOW (win));
+ }
if (msg_uid && uid &&!strcmp (msg_uid, uid))
return 0;
{
ModestWindowMgrPrivate *priv;
gchar* uid;
- gboolean retval = FALSE;
+ gboolean has_header, has_window = FALSE;
GList *item = NULL;
g_return_val_if_fail (MODEST_IS_WINDOW_MGR (self), FALSE);
uid = modest_tny_folder_get_header_unique_id (header);
- /* first, look for the window */
- /* note, the UID cannot be in both the window list and the preregistered uid list */
- if (priv->window_list) {
- item = g_list_find_custom (priv->window_list,
- uid, (GCompareFunc) compare_msguids);
- if (item)
- retval = TRUE;
- if (win)
- *win = item ? MODEST_WINDOW(item->data) : NULL;
- }
+ if (win)
+ *win = NULL;
+/* g_debug ("windows in list: %d", g_list_length (priv->window_list)); */
+/* g_debug ("headers in list: %d", g_slist_length (priv->preregistered_uids)); */
- /* IF It's not in the window list. maybe it's in our uid list... */
- retval = retval || has_uid (priv->preregistered_uids, uid);
+ has_header = has_uid (priv->preregistered_uids, uid);
+
+ item = g_list_find_custom (priv->window_list, uid, (GCompareFunc) compare_msguids);
+ if (item) {
+ has_window = TRUE;
+ if (win) {
+ if ((!MODEST_IS_MSG_VIEW_WINDOW(item->data)) &&
+ (!MODEST_IS_MSG_EDIT_WINDOW (item->data)))
+ g_debug ("not a valid window!");
+ else {
+ g_debug ("found a window");
+ *win = MODEST_WINDOW (item->data);
+ }
+ }
+ }
g_free (uid);
-
- return retval;
+ return has_header || has_window;
}
g_warning ("Trying to register an already registered window");
return;
}
-
+
/* Check that it's not a second main window */
if (MODEST_IS_MAIN_WINDOW (window)) {
if (priv->main_window) {
/* remove from the list of pre-registered uids */
if (MODEST_IS_MSG_VIEW_WINDOW(window)) {
+ const gchar *uid = modest_msg_view_window_get_message_uid
+ (MODEST_MSG_VIEW_WINDOW (window));
+
+ g_debug ("registering window for %s", uid);
+
+ if (!has_uid (priv->preregistered_uids, uid))
+ g_debug ("weird: no uid for window (%s)", uid);
+
priv->preregistered_uids =
remove_uid (priv->preregistered_uids,
modest_msg_view_window_get_message_uid
(MODEST_MSG_VIEW_WINDOW (window)));
+ } else if (MODEST_IS_MSG_EDIT_WINDOW(window)) {
+ const gchar *uid = modest_msg_edit_window_get_message_uid
+ (MODEST_MSG_EDIT_WINDOW (window));
+
+ g_debug ("registering window for %s", uid);
+
+ if (!has_uid (priv->preregistered_uids, uid))
+ g_debug ("weird: no uid for window (%s)", uid);
+
+ priv->preregistered_uids =
+ remove_uid (priv->preregistered_uids,
+ modest_msg_edit_window_get_message_uid
+ (MODEST_MSG_EDIT_WINDOW (window)));
}
/* Add to list. Keep a reference to the window */
modest_window_show_toolbar (window, show);
}
-/* static void */
-/* on_window_destroy (ModestWindow *window, ModestWindowMgr *self) */
static gboolean
on_window_destroy (ModestWindow *window,
GdkEvent *event,
if (response != GTK_RESPONSE_CANCEL)
modest_ui_actions_on_save_to_drafts (NULL, MODEST_MSG_EDIT_WINDOW (window));
- }
+ }
}
}
}
+
+/* interval before retrying to close the application */
+#define CLOSING_RETRY_INTERVAL 3000
+/* interval before cancel whatever is left in the queue, and closing anyway */
+#define MAX_WAIT_FOR_CLOSING 30 * 1000
+
+static gboolean
+on_quit_maybe (ModestWindowMgr *self)
+{
+ ModestWindowMgrPrivate *priv;
+ guint queue_num;
+
+ priv = MODEST_WINDOW_MGR_GET_PRIVATE (self);
+
+ /* it seems, in the meantime some windows were
+ * created. in that case, stop 'on_quit_maybe' */
+ if (priv->window_list) {
+ priv->closing_time = 0;
+ return FALSE;
+ }
+
+ if (priv->closing_time >= MAX_WAIT_FOR_CLOSING) {
+ /* we waited long enough: cancel all remaining operations */
+ g_debug ("%s: we waited long enough (%ds), cancelling queue and quiting",
+ __FUNCTION__, priv->closing_time/1000);
+ /* FIXME: below gives me a lot of:
+ * GLIB CRITICAL ** default - modest_mail_operation_cancel:
+ * assertion `priv->account' failed
+ * which means there is no account for the given operation
+ * so, we're not trying to be nice, we're just quiting.
+ */
+ //modest_mail_operation_queue_cancel_all
+ // (modest_runtime_get_mail_operation_queue());
+ } else {
+
+ /* if there is anything left in our operation queue,
+ * wait another round
+ */
+ queue_num = modest_mail_operation_queue_num_elements
+ (modest_runtime_get_mail_operation_queue());
+ if (queue_num > 0) {
+ g_debug ("%s: waiting, there are still %d operation(s) queued",
+ __FUNCTION__, queue_num);
+ priv->closing_time += CLOSING_RETRY_INTERVAL;
+ return TRUE;
+ }
+ }
+
+ /* so: no windows left, nothing in the queue: quit */
+ priv->closing_time = 0;
+ gtk_main_quit ();
+ return FALSE;
+}
+
+
void
modest_window_mgr_unregister_window (ModestWindowMgr *self,
ModestWindow *window)
{
GList *win;
ModestWindowMgrPrivate *priv;
- gint *tmp, handler_id;
+ gulong *tmp, handler_id;
g_return_if_fail (MODEST_IS_WINDOW_MGR (self));
g_return_if_fail (MODEST_IS_WINDOW (window));
priv->viewer_handlers = NULL;
}
+ /* Remove the viewer window handler from the hash table. The
+ HashTable could not exist if the main window was closeed
+ when there were other windows remaining */
+ if (MODEST_IS_MSG_VIEW_WINDOW (window) && priv->viewer_handlers) {
+ tmp = (gulong *) g_hash_table_lookup (priv->viewer_handlers, window);
+ g_signal_handler_disconnect (window, *tmp);
+ g_hash_table_remove (priv->viewer_handlers, window);
+ }
+
/* Save state */
modest_window_save_state (window);
/* Disconnect the "delete-event" handler, we won't need it anymore */
g_signal_handler_disconnect (window, handler_id);
+ /* Disconnect all the window signals */
+ modest_window_disconnect_signals (window);
+
/* Destroy the window */
gtk_widget_destroy (win->data);
-
+
/* If there are no more windows registered then exit program */
if (priv->window_list == NULL) {
+
ModestConf *conf = modest_runtime_get_conf ();
-
/* Save show toolbar status */
modest_conf_set_bool (conf, MODEST_CONF_SHOW_TOOLBAR_FULLSCREEN,
priv->show_toolbars_fullscreen, NULL);
modest_conf_set_bool (conf, MODEST_CONF_SHOW_TOOLBAR,
priv->show_toolbars, NULL);
- /* Quit main loop */
- /* FIXME: do we ever need to do this here? */
- if (gtk_main_level() > 0)
- gtk_main_quit ();
+ g_timeout_add (CLOSING_RETRY_INTERVAL,
+ (GSourceFunc)on_quit_maybe, self);
}
}
+
+
void
modest_window_mgr_set_fullscreen_mode (ModestWindowMgr *self,
gboolean on)
modest_window_mgr_get_main_window (ModestWindowMgr *self)
{
ModestWindowMgrPrivate *priv;
-
+
g_return_val_if_fail (MODEST_IS_WINDOW_MGR (self), NULL);
-
priv = MODEST_WINDOW_MGR_GET_PRIVATE (self);
+ /* create the main window, if it hasn't been created yet */
+ if (!priv->main_window) {
+ g_debug ("%s: creating main window\n", __FUNCTION__);
+ modest_window_mgr_register_window (self, modest_main_window_new ());
+ }
+
return priv->main_window;
}
projects / modest / blobdiff