X-Git-Url: http://git.maemo.org/git/?p=modest;a=blobdiff_plain;f=ChangeLog2;h=11cbbcec6e9696a5fb7900817622a205260c0976;hp=59900812b167915c0a0292fb58bdc671a67cb528;hb=2c42f21178287256da1a51613e0653327f49f51e;hpb=0b5e030296f33e7885cccec59bd309de9ac0130d diff --git a/ChangeLog2 b/ChangeLog2 index 5990081..11cbbce 100644 --- a/ChangeLog2 +++ b/ChangeLog2 @@ -1,3 +1,320 @@ +2007-07-12 Murray Cumming + + * src/modest-tny-account-store.c: (get_password): + Show the password dialog (via the signal) only in the mainloop, via + an idle handler that we wait for. This could theoretically prevent + hangs, though I worry that it could introduce some too. + +2007-07-12 Murray Cumming + + * src/gnome/modest-platform.c: (modest_platform_connect_and_wait): + * src/maemo/modest-platform.c: + (modest_platform_connect_and_wait): + Take a TnyAccount* parameter and try to set it to online + (a TnyCamel-only API), because tinymail sets accounts to offline + when the user cancels a password dialog, and doesn't ask again until + it has been set to online. + However, this is commented out because it causes a hang now. + + (modest_platform_connect_and_wait_if_network_account): + * src/modest-mail-operation.c: + (modest_mail_operation_update_account): + * src/modest-platform.h: + * src/modest-ui-actions.c: (_modest_ui_actions_open), + (download_uncached_messages), (modest_ui_actions_on_send): Adapted. + +2007-07-12 Armin Burgmeier + + * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error. + + * src/modest-mail-operation.c: + * src/modest-ui-actions.c: Check for already existing folder before + querying the server, show error message from camel if the request + still fails. This fixes projects.maemo.org bug NB#58701. + +2007-07-12 Murray Cumming + + * src/modest-tny-account-store.h: + * src/modest-tny-account-store.c: + Added modest_tny_account_store_forget_password_in_memory(), + (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory() + when creating a new account, so that new passwords will be used, instead of + us thinking that it's a second request as a result of a failed password again. + +2007-07-12 Murray Cumming + + * src/dbus_api/modest-dbus-callbacks.c: + (on_idle_open_message): If the message is in drafts then open it + in an edit window instead of a view window. This fixes + projects.maemo.org bug NB#63005. + +2007-07-12 Murray Cumming + + * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message): + Avoided a harmless g_warning(). + +2007-07-12 Murray Cumming + + * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message), + Pass the modest account name, not the TnyAccount display name to + modest_msg_view_window_new() so that the reply feature works, + fixing projects.maemo.org bug NB#62892. + + * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new), + (modest_msg_view_window_new_with_header_model): + * src/maemo/modest-msg-view-window.c: + (modest_msg_view_window_new_with_header_model), + (modest_msg_view_window_new): + * src/modest-ui-actions.c: (reply_forward): + * src/widgets/modest-msg-view-window.h: + * src/widgets/modest-window.c: (modest_window_set_active_account): + Rename an account parameter to modest_account_name to make this clearer. + +2007-07-11 Murray Cumming + + * src/modest-ui-actions.h: + * src/modest-ui-actions.c: (headers_action_delete): Moved some code into + modest_do_message_delete(). + * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message): + Call modest_do_message_delete(), hoping that this would cause messages + to be really deleted from search instead of just marked with strike through. + Does not seem to help. + +2007-07-11 Armin Burgmeier + + * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set + priv->reselect to FALSE prior to calling + modest_folder_view_select_first_inbox_or_local() to prevent endless + recursion and thus a crash on startup. + +2007-07-11 Armin Burgmeier + + * src/maemo/modest-account-settings-dialog.h: Include + to fix the build (at least for me). + + * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog): + Use "New FolderN" as default suggested name if "New folder" already + exists, with N being the first free number, though never exceed "New + folder99" in which case we just fall back to "New Folder" even though + it already exists. This fixes projects.maemo.org bug NB#58663. + +2007-07-11 Murray Cumming + + * src/maemo/modest-account-view-window.c: (on_new_button_clicked): + Do not use gtk_dialog_run() to avoid modality hang problems. This fixes + projects.maemo.org bug NB#62778. + +2007-07-11 Murray Cumming + + * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account): + Ignore the wrong (for now) secure-smtp setting in the presets - + just default to requiring secure authentication for SMTP, because + that is most common. + +2007-07-11 Johannes Schmid + + * src/widgets/modest-folder-view.c: (filter_row) + Do not show drafts folder (see UI specs) + +2007-07-11 Johannes Schmid + + * src/modest-ui-actions.c: + Remove call to show_non_move_folders(TRUE) which was moved to a wrong + place and also not necessary. + + * src/widgets/modest-folder-view.c: (filter_row) + Guess folder type and hide Sent & Outbox if necessary. + Fixed project.maemo.org NB#57328 + +2007-07-11 Murray Cumming + + * src/modest-ui-actions.h: + * src/modest-ui-actions.c: + (modest_ui_actions_on_delete_message): + Move some code into a new + modest_ui_actions_refresh_message_window_after_delete() + function so we can use it from elsewhere. + + * src/dbus_api/modest-dbus-callbacks.c: + (on_idle_delete_message), (on_delete_message): Used an idle + handler, as we do for the other D-Bus method handlers. + Call modest_ui_actions_refresh_message_window_after_delete() + if the deleted message was open in a window. This fixed + projects.maemo.org bug NB#62862. + +2007-07-11 Murray Cumming + + * src/modest-main.c: (main): Only show the UI at the start if + the showui command line option was given. For instance, + run-standalone src/modest showui + Otherwise, we wait for the top_application D-Bus method to + be sent by hildon-desktop when the application is selected + from the menu. + This allows us to run without a UI when osso-global-search + uses our D-Bus methods. + +2007-07-11 Murray Cumming + + * src/dbus_api/modest-dbus-api.h: Added a define for a + top-application D-Bus method. + * src/dbus_api/modest-dbus-callbacks.c: + (on_top_application), + (modest_dbus_req_handler): Handle the top-application D-Bus + method, which might be an undocumented D-Bus signal sent by + hildon-desktop when it starts the application from the menu. + But I am not sure and I need to test it on the device, because + my scratchbox does not have the application in the menu now. + This method shows the main window, so that it can be invisible + when started, for instance, just for email searching from + osso-global-search. + + * src/maemo/modest-main-window.c: (restore_settings), + (modest_main_window_new): Do not show the window immediately + upon creation. We show it later. + * src/modest-widget-memory.c: (save_settings_paned): + Try (unsuccessfully) to avoid saving the paned position when + it is not even visible. + (restore_settings_paned): Do not allow a silly paned position. + This seems necessary when not showing the window at first. + + * tests/dbus_api/Makefile.am: + * tests/dbus_api/test_top_application.c: (main): Test for the + new D-Bus method. + +2007-07-10 Murray Cumming + + * src/modest-ui-dimming-rules.c: + (modest_ui_dimming_rules_on_new_msg), + (modest_ui_dimming_rules_on_reply_msg), + (modest_ui_dimming_rules_on_delete_msg), + (modest_ui_dimming_rules_on_details), + (modest_ui_dimming_rules_on_view_window_move_to), + (modest_ui_dimming_rules_on_view_previous), + (modest_ui_dimming_rules_on_view_next), + (_invalid_folder_for_purge): Added checks before + casting the window. This looks like an actual + logic error in _invalid_folder_for_purge(), because it + tries to use a ModestMainWindow as a message window. + +2007-07-10 Murray Cumming + + * src/maemo/modest-account-settings-dialog.c: + (show_error): Use the same implementation as in + modest-easysetup-wizard.c: + (on_entry_invalid_character): The logical ID contains a %s. + Guessed what it should be. + (on_entry_max), (check_data), (on_response): Adapt to + changed show_error(). + (create_page_account_details): Really call + modest_validating_entry_set_func() on the correct widgets. + * src/maemo/easysetup/modest-easysetup-wizard.c: + (on_entry_invalid_character): Fix the logical ID here too. + (create_page_account_details), + (create_page_user_details): + Really call + modest_validating_entry_set_func() on the correct widgets. + + * src/modest-tny-account-store.c: (modest_tny_account_store_alert): + Do not try to use the account if it is NULL. + +2007-07-10 Johannes Schmid + + * src/modest-ui-actions.c: (create_move_to_dialog), + (modest_ui_actions_on_main_window_move_to), + (modest_ui_actions_on_msg_view_window_move_to): + * src/widgets/modest-folder-view.c: (modest_folder_view_init), + (filter_row), (modest_folder_view_show_non_move_folders): + * src/widgets/modest-folder-view.h: + + Hide Sent & Outbox folder in "move to"-dialog. Does not work for + the Sent folder yet as it does not report the correct folder type. + +2007-07-10 Johannes Schmid + + * src/maemo/modest-msg-edit-window.c: (init_window): + Fixed bora build + +2007-07-10 Murray Cumming + + * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error): + Take a parent widget instead of a parent window, and + implement this with hildon_banner_show_information() instead. + Non-Maemo builds can just ifdef that there. + This fixed projects.maemo.org bug NB#62766. + + (on_entry_invalid_character): Use show_error() again instead + of using hildon directly, and use the _CS() macro to use the correct + translation domain. + (create_account), (check_for_supported_auth_methods), (on_entry_max): + Pass a widget instead od a window to show_error(). + +2007-07-10 Murray Cumming + + * src/modest-tny-account-store.c: (modest_tny_account_store_alert): + Adapt to the changed tinymail API, using the new TnyAccount* parameter. + This allows us to show the server name in the error message, fixing + projects.maemo.org bug NB#62904. + Also, use the appropriate logical ID message for the account protocol. + +2007-07-10 Murray Cumming + + * src/modest-tny-account-store.c: (on_idle_wrong_password): + A compilation fix, though the build wasn't broken for me. + +2007-07-09 Murray Cumming + + * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive): + Do not try to unref a NULL folder store, to avoid a runtime warning. + This seems to happen sometimes when changing accounts settings. + +2007-07-09 Murray Cumming + + * src/modest-tny-account-store.c: + (modest_tny_account_store_instance_init), + (modest_tny_account_store_finalize), + (on_account_settings_hide), (on_idle_wrong_password): + Use a GHashTable to ensure that we only show one account settings + dialog per modest account. This avoids us having a dialog open for + both the store and transport accounts, or due to repeated get_password() + calls that shouldn't happen anyway. + +2007-07-09 Murray Cumming + + * src/maemo/modest-maemo-utils.c: (on_hide), + (modest_maemo_show_dialog_and_forget): Handle the response, because + the window is not even hidden by default. + + * src/maemo/modest-account-view-window.c: (on_edit_button_clicked): + * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): + Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run() + which seems to prevent some modality problems. + + * src/maemo/modest-main-window.c: (on_sendqueue_error_happened): + Ignore user cancellation errors. + + * src/modest-account-mgr-helpers.h: + * src/modest-account-mgr-helpers.c: + Added modest_server_account_get_password() and + modest_server_account_get_has_password() to avoid direct use of + conf enums. + + * src/maemo/modest-account-settings-dialog.h: + * src/maemo/modest-account-settings-dialog.c: + (modest_account_settings_dialog_init): Store the notebook so we can + use it later. + Added modest_account_settings_dialog_switch_to_user_info(). + + * src/modest-tny-account-store.c: + (get_password): When the password in the account settings is wrong (we think), + show the relevant page of the account settings dialog, in the mainloop. + However, we currently get many of these at once because cancel does not + seem to cancel. + (forget_password): Do not forget the password + from the account settings, because this causes side-effects when + tinymail seems to call it at strange time, maybe because of how we + are cancelling get_password(). + (modest_tny_account_store_alert): Ignore user cancellations. + 2007-07-09 Murray Cumming * src/maemo/modest-maemo-utils.h: