X-Git-Url: http://git.maemo.org/git/?p=modest;a=blobdiff_plain;f=ChangeLog2;h=3620bb5336cac93f63df3d646228accb900bd3d4;hp=a117ac157538f5426dffa21695acb3398c076250;hb=d2766e0125d45ae66dbe70b51eb90e3b0e493982;hpb=e58f14c0d0f1c548c697abd437a2ed2d770f612a diff --git a/ChangeLog2 b/ChangeLog2 index a117ac1..3620bb5 100644 --- a/ChangeLog2 +++ b/ChangeLog2 @@ -1,3 +1,752 @@ +2007-06-12 Murray Cumming + + * src/modest-account-mgr.c: (on_key_change): Append to the list, not to + NULL, so that the signals get all the keys. This should not actually + change any behaviour because we currently update everything when anything + changes. + +2007-06-12 Murray Cumming + + * src/widgets/modest-folder-view.c: (text_cell_data), + (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows), + (find_inbox_iter): If tinymail tells us that the folder is + a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name. + This causes the inbox to be selected at startup, fixing part of + projects.maemo.org bug NB#56305. + + * src/modest-ui-dimming-rules.c: + (modest_ui_dimming_rules_on_tools_smtp_servers): + * src/modest-ui-dimming-rules.h: Added a callback function to dim + the SMTP servers menu item. + * src/maemo/modest-main-window-ui-dimming.h: Used the function, so + that the SMTP Servers menu item is dimmed when there are no accounts, + as a future version of the UI spec will require. This fixes + projects.maemo.org bug NB#56305. + +2007-06-11 Johannes Schmid + + * src/maemo/modest-maemo-utils.c: + (modest_maemo_utils_get_supported_secure_authentication_methods): + Added label to dialog instead of unreadable title + + * src/maemo/modest-main-window.c: (sync_accounts_cb), + (modest_main_window_new): + Fixed projects.maemo.org bug NB#58576 by moving previous fix out of + dead code. + + * src/modest-account-mgr.c: (modest_account_mgr_has_accounts): + * src/modest-account-mgr.h: + Added method to avoid code duplication + + * src/modest-ui-actions.c: (modest_ui_actions_on_accounts), + (modest_ui_actions_on_send_receive): + Use modest_account_mgr_has_accounts + +2007-06-11 Murray Cumming + + * src/maemo/easysetup/modest-presets.c: + (modest_presets_get_info_server_security): Do not report secure auth + if there is none. + * src/modest-protocol-info.c: Use the defines for the gconf key names + for secure authentication. This was not working because we were writing + Password and reading password, and the check was case sensitive. + With this, gmail now works for receiving and sending when created via + easysetup. + +2007-06-11 Murray Cumming + + * src/maemo/easysetup/modest-presets.c: + (modest_presets_get_info_server_security): Correct the key name for + SecureSmtp, because it seems to be case-sensitive. + * src/maemo/easysetup/modest-wizard-dialog.c: (create_title): + Do not try to get the 0th notebook page if there are 0 pages, to + avoid a g_warning(). + +2007-06-11 Murray Cumming + + * src/maemo/modest-platform.c: (modest_platform_on_new_msg): + Prevent use of the new notification feature for now, because it currently + shows one dialog for each new email, which is annoying. + +2007-06-11 Murray Cumming + + * src/maemo/easysetup/modest-easysetup-provider-combo-box.c: + (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0 + when no country was selected, so that we show the global ones. + * src/maemo/easysetup/modest-presets.c: + (modest_presets_get_providers): Return only the global providers, not + all providers when mmc=0 was requested. + +2007-06-11 Murray Cumming + + * src/maemo/easysetup/modest-easysetup-provider-combo-box.c: + (easysetup_provider_combo_box_fill): Remove debug code that showed the + provider ID in the combo. + + * src/maemo/easysetup/modest-wizard-dialog.c: (create_title): + Do not show the page numbers, because it would be confusing when we add + the 2 extra pages for the custom setup, when the user chooses the "Other" + provider. This fixes projects.maemo.org bug NB#59028 + + * src/modest-init.c: (modest_init_init_core), + (modest_init_local_folders): + * src/modest-init.h: + * src/modest-tny-account.c: + (modest_tny_account_new_for_local_folders): Do not create default folders + for the memory card. This should fix projects.maemo.org bug NB#59328. + +2007-06-11 Murray Cumming + + * src/modest-account-mgr.c: (modest_account_mgr_finalize): + Free the changed_conf_keys string items. They are already freed in the + idle handler if that runs first. + +2007-06-11 Murray Cumming + + * src/modest-ui-actions.c: + (modest_ui_actions_on_password_requested): Check that the server name + is not NULL, because I just saw a password dialog with (null) as the + server name. + + * src/modest-tny-folder.[h|c]: Added + modest_tny_folder_is_memory_card_folder(). + * src/modest-ui-dimming-rules.c: + (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context + menu item for memory cards, as per the UI spec (section 7.4). This should + fix projects.maemo.org bug NB#59297. + +2007-06-10 Johannes Schmid + + * src/maemo/modest-main-window.c: (sync_accounts_cb): + Fixed projects.maemo.org bug NB#58576 (not yet activated as there + is another problem with the code, see Murray's comment at line 772) + +2007-06-08 Murray Cumming + + * src/maemo/easysetup/modest-easysetup-country-combo-box.h: + * src/maemo/easysetup/modest-easysetup-country-combo-box.c: + (on_model_foreach_release), (easysetup_country_combo_box_finalize), + (load_from_file), (easysetup_country_combo_box_init), + (easysetup_country_combo_box_get_active_country_ids), + (on_model_foreach_select_id): Store a GSList* of IDs in the model row, + instead of just one ID, to avoid duplicate country names in the UI. + + * src/maemo/easysetup/modest-easysetup-provider-combo-box.h: + * src/maemo/easysetup/modest-easysetup-provider-combo-box.c: + (easysetup_provider_combo_box_fill): Adapt to use a list rather than + a single ID, avoiding duplicate providers. + * src/maemo/easysetup/modest-easysetup-wizard.c: + (on_combo_account_country): Adapt to use a list. + +2007-06-08 Murray Cumming + + * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of + keys changed in the last X seconds. + + * src/modest-account-mgr.h: + * src/modest-account-mgr.c: (on_timeout_notify_changes), + (on_key_change), (modest_account_mgr_class_init), + (modest_account_mgr_init), (modest_account_mgr_finalize): + As the keys are changed, save them in a GSList* and signal that GSList* + further every X seconds, to batch changes, to allow us to do just one + update per batch. This should fix bug projects.maemo.org bug NB#56472 and + bug NB#56941 and other (UI-blocking) delays when changing account settings. + + * src/modest-tny-account-store.c: (on_account_changed): Adapted to + changed signal signature. + + * src/modest-conf.c: (modest_conf_set_list), + (modest_conf_on_change): Reenable notification. + + (modest_conf_maemo_fake_on_change): Comment out the hack that + notified immediately instead of asynchronously. + + * src/widgets/modest-account-view.h: + * src/widgets/modest-account-view.c: + (update_account_view): Select the previously-selected account ID, + if possible. This fixes projects.maemo.org bug NB#56933. + + (on_account_changed), (on_account_removed), + (modest_account_view_select_account): + + Remove the block/unblock functions + because they were not useful. + + * src/maemo/modest-account-view-window.c: + (on_delete_button_clicked), (on_edit_button_clicked), + (on_new_button_clicked): Remove the use of the non-working block/unblock. + +2007-06-08 Murray Cumming + + * src/modest-tny-account-store.c: (modest_tny_account_store_alert): + Improve the error dialog to show Incorrect Account Settings, which seems + clearer, and say that the internal error message (to be removed from the + dialog later) is often misleading. + I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem. + + * src/modest-tny-account.c: + (modest_tny_account_new_from_server_account): Uncomment the printf of the + URL because this is so useful for debugging on the device. + + * src/widgets/modest-serversecurity-combo-box.c: + (modest_serversecurity_combo_box_fill): Correct a logical ID. + +2007-06-08 Murray Cumming + + * src/modest-mail-operation.c: + (modest_mail_operation_send_new_mail): + Added a comment about a nasty but apparently harmless message. Details + added to the wiki g_warnings() page. + +2007-06-08 Murray Cumming + + * src/modest-tny-send-queue.c: (modest_tny_send_queue_add), + (modest_tny_send_queue_class_init): + Do not use the priv struct because it is empty, to avoid g_warnings + about a non-existant priv struct. + + * src/modest-tny-account-store.c: + (modest_tny_account_store_get_server_account), + (modest_tny_account_store_get_transport_account_for_open_connection + ): Do not try to get transport server accounts for local folders, + because they don't have any. This avoids a g_warning(). + + * src/maemo/modest-main-window.c: + (modest_main_window_notify_send_receive_initied), + (on_configuration_key_changed): + * src/maemo/modest-msg-edit-window.c: (on_delete_event): + * src/modest-defs.h: + * src/modest-mail-operation.c: + (modest_mail_operation_update_account): + * src/modest-tny-account-store.h: + * src/modest-tny-account.c: + (modest_tny_account_get_special_folder), + (modest_tny_account_new_for_local_folders), + (modest_tny_account_new_for_per_account_local_outbox_folder): + * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder): + * src/modest-tny-local-folders-account.c: + (add_account_folders_to_merged_folder): + * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg), + (reply_forward_cb), (modest_ui_actions_on_save_to_drafts), + (modest_ui_actions_on_send): + * src/widgets/modest-folder-view.c: (update_model): + Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to + MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename + modest_tny_account_store_get_tny_account_by_account() to + modest_tny_account_store_get_server_account() to make the code clearer. + +2007-06-07 Marcus Bauer + + * src/dbus_api/modest-dbus-api.h: + changed MODEST_DBUS_NAME in order to get dbus auto-activation to work + * src/maemo/modest-msg-edit-window.c: + (modest_msg_edit_window_attach_file_noninteractive): + added g_warning in case the file to be attached does not exist + * tests/dbus_api/test_compose_mail.c: (main): + removed obsolete comment, added generic files as test case + +2007-06-07 Murray Cumming + + * src/modest-tny-account-store.c: (get_server_accounts): + Create the local folders account only once, not once for each outbox, and + not only when there are some outboxes. + +2007-06-07 Murray Cumming + + * src/widgets/modest-folder-view.c: (update_model): Comment out some + code that is causing a crash at startup. Sergio says that he is fixing this. + +2007-06-07 Johannes Schmid + + * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next): + * src/maemo/modest-account-settings-dialog.c: + (create_page_outgoing), + (modest_account_settings_dialog_set_account_name), + (save_configuration): + - Fixed handling of the "Use secure authentication" toggle to comply with + the ui specification. See also projects.maemo.org bug NB#58400 + + - Restore the Secure connection setting combo correctly when loading + the settings dialog + + * src/maemo/modest-maemo-utils.c: + (on_camel_account_get_supported_secure_authentication), + (modest_maemo_utils_get_supported_secure_authentication_methods): + Fixed a crasher if operation is canceled + + * src/modest-protocol-info.c: (modest_protocol_info_is_secure), + (modest_protocol_info_auth_is_secure): + * src/modest-protocol-info.h: + + Added two new methods to determine if a protocol/auth method is secure/encrypted in + the sense of the "Use secure authentication" toggle. + +2007-06-07 Murray Cumming + + * src/modest-tny-account-store.h: + * src/modest-tny-account-store.c: + Added modest_tny_account_store_get_local_folders_account(). + + * src/modest-tny-folder.h: + * src/modest-tny-folder.c: + (modest_tny_folder_get_account): + Added this replacement for tny_folder_get_account() which returns + the local-folders account for TnyMergeFolders, to avoid the + warning about the unimplemented get_account_func() vfunc(). + + (modest_tny_folder_get_rules), + * src/modest-ui-actions.c: + (modest_ui_actions_on_folder_selection_changed): + * src/modest-mail-operation.c: + (modest_mail_operation_remove_folder), + (modest_mail_operation_xfer_folder), + (modest_mail_operation_rename_folder), + (modest_mail_operation_get_msg), + (modest_mail_operation_get_msgs_full), + (modest_mail_operation_remove_msg), + (modest_mail_operation_xfer_msgs), + (modest_mail_operation_refresh_folder): + Use modest_tny_folder_get_account() instead of tny_folder_get_account(). + +2007-06-07 Murray Cumming + + * src/modest-account-mgr-helpers.c: (get_security_for_conf_string), + (modest_server_account_set_security): + * src/modest-defs.h: Add comments explaining that our + UI spec means TLS when it says Normal, so these do not look like errors. + + * src/modest-tny-account.c: + (modest_tny_account_new_from_server_account): Use the new tinymail + 'wrapped' option for regular SSL, and use the new tinymail 'tls' option + for TLS. This should fix projects.maemo.org bug NB#58460. + +2007-06-06 Murray Cumming + + * src/maemo/easysetup/modest-easysetup-wizard.c: + (create_account): Correct the position of the gconf sanity check warning. + (on_button_edit_advanced_settings): Show the dialog immediately, instead + of using the g_idle_add() hack, because this does not seem to be necessary + on osso 1.1. It might even work on Maemo Bora if the problems were actually + caused by something other than maemo's gconf. + This fixes projects.maemo.org bug #59022. + +2007-06-06 Murray Cumming + + * src/modest-account-mgr-helpers.c: + (modest_account_mgr_get_default_account): Do not check that the account + exists if there is no default account (NULL), to fix a runtime warning. + +2007-06-06 Murray Cumming + + * src/widgets/modest-folder-view.c: (update_model): + Do not unref the treemodel before we have finished with it. + This prevents a valgrind warning and an occasional crash at startup. + +2007-06-06 Marcus Bauer + + * libmodest-dbus-client/libmodest-dbus-client.h: + added libmodest_dbus_client_compose_mail() + * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail), + (on_compose_mail): + added functions needed for SendAsMail() functionality + * src/maemo/modest-msg-edit-window.c: + (modest_msg_edit_window_attach_file_noninteractive): + non interactively attaching files to message edit window + * src/widgets/modest-msg-edit-window.h: + * tests/dbus_api/Makefile.am: + added test_compose_mail.c + * tests/dbus_api/test_compose_mail.c: (main): + +2007-06-05 Johannes Schmid + + * src/modest-account-view.c: + Fixed bug projects.maemo.org bug NB#59307 + +2007-06-05 Johannes Schmid + + * src/maemo/easysetup/modest-easysetup-wizard.c: + (get_serverport_incoming), (on_before_next), (create_account): + * src/maemo/modest-account-settings-dialog.c: + (modest_account_settings_dialog_set_account_name): + * src/maemo/modest-maemo-utils.c: + (on_camel_account_get_supported_secure_authentication_status), + (on_camel_account_get_supported_secure_authentication), + (on_secure_auth_cancel), + (modest_maemo_utils_get_supported_secure_authentication_methods): + + Implemented security authentication for settings and easysetup. + +2007-06-05 Murray Cumming + + * src/maemo/modest-main-window.c: (create_details_widget): + Show the total size for memory card accounts too, instead of showing + the name again. Fixes bug projects.maemo.org bug NB#59307. + +2007-06-05 Murray Cumming + + * src/Makefile.am: + * src/modest-tny-simple-folder-store.c: + * src/modest-tny-simple-folder-store.h: Removed. + + * src/modest-tny-local-folders-account.h + * src/modest-tny-local-folders-account.c: Added a derived TnyAccount + for the local-folders maildir, with an extra TnyMergedFolder containing + the folders of the per-account outbox store accounts. + * src/modest-tny-account-store.c: (get_server_accounts): + Add the outboxes to the special local folders account after creating it. + + * src/modest-tny-account.c: + (modest_tny_account_new_for_local_folders): Create the derived + account when creating the main local-folders account. + + * src/maemo/modest-main-window.c: (create_details_widget), + (modest_main_window_set_contents_style): + Adapted to the use of the derived account instead of the folder store. + + * src/modest-ui-actions.c: + (modest_ui_actions_on_folder_selection_changed): + * src/modest-ui-dimming-rules.c: + (modest_ui_dimming_rules_on_new_folder): + * src/widgets/modest-folder-view.c: (text_cell_data), + (icon_cell_data), (filter_row), (update_model), + (get_cmp_rows_type_pos): + + + * src/modest-tny-send-queue.c: (modest_tny_send_queue_new): + Do not get the priv struct, because no priv struct has been set, + to avoid a runtime warning. + + * src/maemo/modest-platform.c: (modest_platform_show_help): Replace + #ifelse with #else, to fix a warning, to fix the build. + + +2007-06-05 Christian Kellner + + * libmodest-dbus-client/libmodest-dbus-client.c: + Fix small typo in doc (why do you always see them + AFTER committing stuff?) + + +2007-06-05 Christian Kellner + + * libmodest-dbus-client/libmodest-dbus-client.c: + (libmodest_dbus_client_search): + Initialize hit list with NULL. Also set folder list + to "" if NULL was supplied. + Add documentation. + +2007-06-03 Christian Kellner + + * libmodest-dbus-client/libmodest-dbus-client.c: + (modest_search_hit_list_free): + Make it save to call it with NULL. + + * src/dbus_api/modest-dbus-callbacks.c: + * src/modest-search.c: + Return full ModestSearchHits as the search result list not TnyHeader + since can't be around withouth the correspoding TnyFolder. + +2007-06-03 Johannes Schmid + + * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next): + Added currently commented code to check for secure auth + + * src/maemo/modest-account-settings-dialog.c: (on_response), + (save_configuration), (show_ok): + Fixed projects.maemo.org bugs NB #59248 and #59251 + + * src/maemo/modest-maemo-utils.c: + (on_camel_account_get_supported_secure_authentication_status), + (on_camel_account_get_supported_secure_authentication), + (modest_maemo_utils_get_supported_secure_authentication_methods): + * src/maemo/modest-maemo-utils.h: + Moved get_supported_secure_authentication() method here to be able + to use it from easysetup wizard. + + * src/modest-pair.c: (on_pair_compare_as_string): + Should compare string with first part of pair and not + strcmp pairs which will crash. + + * src/modest-protocol-info.c: + (modest_protocol_info_protocol_is_store): + * src/modest-protocol-info.h: + Added modest_protocol_info_get_auth_protocol_name() + +2007-06-03 Armin Burgmeier + + * src/modest-mail-operation.c: + (modest_mail_operation_get_msgs_full): Set priv->account also when + only retrieving a single message. This avoids a crash when canceling + the operation. + + (modest_mail_operation_notify_end): Do not explicitely remove the + operation from the queue but only emit the progress_changed signal. + The queue itself listens to that signal to remove the operation when + it is finished. This reduces coupling and removes a potential deadlock + when modest_mail_operation_notify_end() is called from the queue + itself. If that is a problem performance-wise, I would suggest to + implement a status-changed signal or something. + + * src/modest-mail-operation-queue.c: Make sure to never call a + function from another file while the queue is locked. This (hopefully) + fixes another deadlock when exiting the application while retrieving + mail. + +2007-06-03 Johannes Schmid + + * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter): + Fixed build if libogs is not available + +2007-06-03 Christian Kellner + + * libmodest-dbus-client/libmodest-dbus-client.h: + * libmodest-dbus-client/libmodest-dbus-client.c: + (libmodest_dbus_client_delete_message): + Implement deletion of messages (Client side). + + (modest_search_hit_free), + (modest_search_hit_list_free): + Utility functions to free the result hits. + + * src/dbus_api/modest-dbus-api.h: + * src/dbus_api/modest-dbus-callbacks.c: + (on_delete_message), + (modest_dbus_req_handler): + Implement deletion of messages (Server side). + + * tests/dbus_api/test_search.c: (main): + Free the hits. + + * tests/dbus_api/Makefile.am: + * tests/dbus_api/test_delete_message: + Add little test for the message deletion logic + +2007-06-03 Armin Burgmeier + + * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize() + when the operation queue was not empty. projects.maemo.org bug + NB#58976. + +2007-06-03 Armin Burgmeier + + * src/widgets/modest-account-view.c + (on_account_default_toggled): Toggle default account column + explicitely instead of waiting for gconf notification (which is + currently ignored). This should fix projects.maemo.org bug NB#56910 + for now. It should probably be removed when gconf notifications are + re-enabled. + +2007-06-03 Christian Kellner + + * libmodest-dbus-client/libmodest-dbus-client.c: + Removed debugging spew. + + * src/dbus_api/modest-dbus-callbacks.c: + Added debugging info. + + * src/modest-search.c: + (modest_search_all_accounts): + Use tny_account_store_get_accounts () on the account store + to get all accounts which is the way to get all accounts. + + * tests/dbus_api/test_search.c: (main): + Make it possible to supply the search term on the command line. + +2007-06-03 Christian Kellner + + * libmodest-dbus-client/libmodest-dbus-client.c: + * libmodest-dbus-client/libmodest-dbus-client.h: + Implement searching for mesages over raw dbus. (Client side) + + * src/dbus_api/Makefile.am: + * src/dbus_api/modest-dbus-api.h: + * src/dbus_api/modest-dbus-callbacks.c: + * src/dbus_api/modest-dbus-callbacks.h: + Search framework (Server side). Also implement on_idle_open_message(). + + * src/maemo/modest-platform.c: (modest_platform_init): + Prepare for raw dbus/osso rpc interaction. + + * src/modest-search.h: + Changed minsize from unspecific guint to guint32. + + * src/modest-search.c: + (add_header): + Added strange hack which magically made tnymail work. + + (modest_search_folder), + (modest_search_account), + (modest_search_all_accounts): + Implement helper functions to search all accounts, specific account + and folder. + + * tests/dbus_api/Makefile.am: + * tests/dbus_api/test_open_message.c: + Read url to open from commandline. + + * tests/dbus_api/test_search.c: + Implement small test for dbus search stuff + +2007-06-02 Armin Burgmeier + + * src/maemo/modest-account-settings-dialog.c: Changed window title to + include account type and account title. This fixes projects.maemo.org + bug NB#59000. + + * src/maemo/modest-account-view-window.c: Set a title for the window. + +2007-06-02 Armin Burgmeier + + * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill + incoming and outgoing server name based on email address and server + types as long as the names have not been edited manually. This fixes + projects.maemo.org bug NB#58671. + +2007-06-02 Armin Burgmeier + + * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the + server type cannot be changed in future to the incoming details page + when creating an account. This fixes projects.maemo.org bug NB#59029. + +2007-06-02 Armin Burgmeier + + * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping + and assigned max width chars so that they wrap instead of being + truncated. Fixes projects.maemo.org bug NB#56126. + +2007-06-02 Armin Burgmeier + + * src/maemo/modest-connection-specific-smtp-window.c: Add an + introductory note to the connection specific smtp servers dialog, as + section 8.12 of the email UI specification requires. This fixes + projects.maemo.org bug NB#59212. + +2007-06-01 Murray Cumming + + * src/maemo/modest-account-view-window.c: (on_edit_button_clicked): + Check for running mail operations, and offer to cancel them, as per the UI + spec. This fixes projects.maemo.org bug NB#59041 . + However, I suspect that tinymail may still use the network connection + in ways that we cannot detect or cancel. But it should at least adapt to + changes fairly well. + +2007-06-01 Murray Cumming + + * src/modest-tny-account-store.c: (recreate_all_accounts), + (get_cached_accounts), (get_server_accounts): Do more sensible + ref-counting of the temporarily-cached outbox accounts list. This seems + to fix a crash when entering the password when the password was wrong. + +2007-06-01 Murray Cumming + + * src/gnome/modest-main-window.c: (connect_signals): + * src/modest-tny-account-store.c: (get_password), + (modest_tny_account_store_alert): Added comments and clues and + commented-out code about how we currently fail to deal with connection + errors and wrong passwords, and how we should. + +2007-06-01 Murray Cumming + + * src/widgets/modest-retrieve-combo-box.c: + (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP. + This fixes projects.maemo.org bug NB#58472 . + +2007-06-01 Murray Cumming + + * src/maemo/easysetup/modest-easysetup-wizard.c: + (create_page_complete_easysetup): + (create_page_complete_custom): Correct the last commit, + putting the correct sentences in the correct pages. + +2007-06-01 Murray Cumming + + * src/maemo/easysetup/modest-easysetup-wizard.c: + (create_page_complete_custom): Show the second sentence of text + (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug + NB#59023 . + +2007-06-01 Murray Cumming + + * src/modest-account-mgr.c: (modest_account_mgr_add_account): + Set the leave-on-server conf key by default. This fixes + projects.maemo.org bug NB#59258 . + +2007-06-01 Murray Cumming + + * src/maemo/modest-account-view-window.c: + (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap + logical ID for the confirmation messages. Fixed projects.maemo.org bug + NB#59037 . + +2007-06-01 Murray Cumming + + * src/maemo/easysetup/modest-easysetup-wizard.c: + (create_caption_new_with_asterisk): + * src/maemo/modest-account-settings-dialog.c: + (create_caption_new_with_asterisk): + Uncomment the code to add the asterisk, because they are no longer in the + translated text in the .po file. Fixes projects.maemo.org bug NB#59202 . + (update_incoming_server_title): Add an asterisk here too. + +2007-06-01 Murray Cumming + + * src/maemo/modest-maemo-global-settings-dialog.c: + (current_connection): Check that we are even connected before trying to + get the current connection name, to prevent a warning. + + * src/maemo/modest-platform.c: (modest_platform_connect_and_wait): + Change the comments because tny_maemo_conic_device_connect() is now meant to + block. + * src/modest-mail-operation.c: + (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to + make sure we have a connection and fail if we can't connect. + +2007-05-31 Murray Cumming + + * src/maemo/modest-main-window.c: + (on_account_store_connecting_finished): Do not try to get the + connection ID if we are not really connected. I am surprised that + this signal handler is called when we are not connected. + +2007-05-31 Murray Cumming + + * src/modest-error.h: + * src/modest-ui-actions.c: + (modest_ui_actions_get_msgs_full_error_handler): + Renamed an enum, added comments, added an enum + for retrieve-limit errors. + + * src/modest-mail-operation.c: (foreach_add_item), + (internal_folder_observer_update), (update_account_thread), + (modest_mail_operation_get_msgs_full): + (modest_mail_operation_update_account), + Added comments about how this works, and some code that should + (but does not) check the retrieve-limit. See the TODO comment. + +2007-05-31 Murray Cumming + + * src/modest-ui-actions.c: (modest_ui_actions_on_help): + Initialize help_id to fix the build. Warnings are good. + +2007-05-31 Murray Cumming + + * src/widgets/modest-hbox-cell-renderer.c: + (modest_hbox_cell_renderer_append): + * src/widgets/modest-vbox-cell-renderer.c: + (modest_vbox_cell_renderer_append): + Fix the last commit by doing an extra ref. + +2007-05-31 Murray Cumming + + * src/widgets/modest-hbox-cell-renderer.c: + (modest_hbox_cell_renderer_append): + * src/widgets/modest-vbox-cell-renderer.c: + (modest_vbox_cell_renderer_append): + For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(), + to fix the build with Maemo Bora. + However, there seems to be a remaining crash, probably due to reference + counting errors. + 2007-05-30 Murray Cumming * src/modest-tny-account.c: @@ -2026,4 +2775,3 @@ Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc. Apparently ChangeLog is not used for some vague Nokia legal reasons. -