X-Git-Url: http://git.maemo.org/git/?p=modest;a=blobdiff_plain;f=ChangeLog2;h=3c5d4456ddd08b4b96a0c45f94a3e02782acd637;hp=567ff6d987d3b1a391a768354685b3b3753a5709;hb=930a2c61d481d3f1d1d0cdb3dd8b03d5b6b87bd1;hpb=d6453962febe54a4b8f739e5255490310eb9f985 diff --git a/ChangeLog2 b/ChangeLog2 index 567ff6d..3c5d445 100644 --- a/ChangeLog2 +++ b/ChangeLog2 @@ -1,3 +1,681 @@ +2007-07-11 Murray Cumming + + * src/modest-main.c: (main): Only show the UI at the start if + the showui command line option was given. For instance, + run-standalone src/modest showui + Otherwise, we wait for the top_application D-Bus method to + be sent by hildon-desktop when the application is selected + from the menu. + This allows us to run without a UI when osso-global-search + uses our D-Bus methods. + +2007-07-11 Murray Cumming + + * src/dbus_api/modest-dbus-api.h: Added a define for a + top-application D-Bus method. + * src/dbus_api/modest-dbus-callbacks.c: + (on_top_application), + (modest_dbus_req_handler): Handle the top-application D-Bus + method, which might be an undocumented D-Bus signal sent by + hildon-desktop when it starts the application from the menu. + But I am not sure and I need to test it on the device, because + my scratchbox does not have the application in the menu now. + This method shows the main window, so that it can be invisible + when started, for instance, just for email searching from + osso-global-search. + + * src/maemo/modest-main-window.c: (restore_settings), + (modest_main_window_new): Do not show the window immediately + upon creation. We show it later. + * src/modest-widget-memory.c: (save_settings_paned): + Try (unsuccessfully) to avoid saving the paned position when + it is not even visible. + (restore_settings_paned): Do not allow a silly paned position. + This seems necessary when not showing the window at first. + + * tests/dbus_api/Makefile.am: + * tests/dbus_api/test_top_application.c: (main): Test for the + new D-Bus method. + +2007-07-10 Murray Cumming + + * src/modest-ui-dimming-rules.c: + (modest_ui_dimming_rules_on_new_msg), + (modest_ui_dimming_rules_on_reply_msg), + (modest_ui_dimming_rules_on_delete_msg), + (modest_ui_dimming_rules_on_details), + (modest_ui_dimming_rules_on_view_window_move_to), + (modest_ui_dimming_rules_on_view_previous), + (modest_ui_dimming_rules_on_view_next), + (_invalid_folder_for_purge): Added checks before + casting the window. This looks like an actual + logic error in _invalid_folder_for_purge(), because it + tries to use a ModestMainWindow as a message window. + +2007-07-10 Murray Cumming + + * src/maemo/modest-account-settings-dialog.c: + (show_error): Use the same implementation as in + modest-easysetup-wizard.c: + (on_entry_invalid_character): The logical ID contains a %s. + Guessed what it should be. + (on_entry_max), (check_data), (on_response): Adapt to + changed show_error(). + (create_page_account_details): Really call + modest_validating_entry_set_func() on the correct widgets. + * src/maemo/easysetup/modest-easysetup-wizard.c: + (on_entry_invalid_character): Fix the logical ID here too. + (create_page_account_details), + (create_page_user_details): + Really call + modest_validating_entry_set_func() on the correct widgets. + + * src/modest-tny-account-store.c: (modest_tny_account_store_alert): + Do not try to use the account if it is NULL. + +2007-07-10 Johannes Schmid + + * src/modest-ui-actions.c: (create_move_to_dialog), + (modest_ui_actions_on_main_window_move_to), + (modest_ui_actions_on_msg_view_window_move_to): + * src/widgets/modest-folder-view.c: (modest_folder_view_init), + (filter_row), (modest_folder_view_show_non_move_folders): + * src/widgets/modest-folder-view.h: + + Hide Sent & Outbox folder in "move to"-dialog. Does not work for + the Sent folder yet as it does not report the correct folder type. + +2007-07-10 Johannes Schmid + + * src/maemo/modest-msg-edit-window.c: (init_window): + Fixed bora build + +2007-07-10 Murray Cumming + + * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error): + Take a parent widget instead of a parent window, and + implement this with hildon_banner_show_information() instead. + Non-Maemo builds can just ifdef that there. + This fixed projects.maemo.org bug NB#62766. + + (on_entry_invalid_character): Use show_error() again instead + of using hildon directly, and use the _CS() macro to use the correct + translation domain. + (create_account), (check_for_supported_auth_methods), (on_entry_max): + Pass a widget instead od a window to show_error(). + +2007-07-10 Murray Cumming + + * src/modest-tny-account-store.c: (modest_tny_account_store_alert): + Adapt to the changed tinymail API, using the new TnyAccount* parameter. + This allows us to show the server name in the error message, fixing + projects.maemo.org bug NB#62904. + Also, use the appropriate logical ID message for the account protocol. + +2007-07-10 Murray Cumming + + * src/modest-tny-account-store.c: (on_idle_wrong_password): + A compilation fix, though the build wasn't broken for me. + +2007-07-09 Murray Cumming + + * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive): + Do not try to unref a NULL folder store, to avoid a runtime warning. + This seems to happen sometimes when changing accounts settings. + +2007-07-09 Murray Cumming + + * src/modest-tny-account-store.c: + (modest_tny_account_store_instance_init), + (modest_tny_account_store_finalize), + (on_account_settings_hide), (on_idle_wrong_password): + Use a GHashTable to ensure that we only show one account settings + dialog per modest account. This avoids us having a dialog open for + both the store and transport accounts, or due to repeated get_password() + calls that shouldn't happen anyway. + +2007-07-09 Murray Cumming + + * src/maemo/modest-maemo-utils.c: (on_hide), + (modest_maemo_show_dialog_and_forget): Handle the response, because + the window is not even hidden by default. + + * src/maemo/modest-account-view-window.c: (on_edit_button_clicked): + * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): + Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run() + which seems to prevent some modality problems. + + * src/maemo/modest-main-window.c: (on_sendqueue_error_happened): + Ignore user cancellation errors. + + * src/modest-account-mgr-helpers.h: + * src/modest-account-mgr-helpers.c: + Added modest_server_account_get_password() and + modest_server_account_get_has_password() to avoid direct use of + conf enums. + + * src/maemo/modest-account-settings-dialog.h: + * src/maemo/modest-account-settings-dialog.c: + (modest_account_settings_dialog_init): Store the notebook so we can + use it later. + Added modest_account_settings_dialog_switch_to_user_info(). + + * src/modest-tny-account-store.c: + (get_password): When the password in the account settings is wrong (we think), + show the relevant page of the account settings dialog, in the mainloop. + However, we currently get many of these at once because cancel does not + seem to cancel. + (forget_password): Do not forget the password + from the account settings, because this causes side-effects when + tinymail seems to call it at strange time, maybe because of how we + are cancelling get_password(). + (modest_tny_account_store_alert): Ignore user cancellations. + +2007-07-09 Murray Cumming + + * src/maemo/modest-maemo-utils.h: + * src/maemo/modest-maemo-utils.c: + Added modest_maemo_show_information_note_and_forget() for use instead of + gtk_dialog_run() when the response is not needed, to avoid an extra + mainloop which could cause a hang. + + * src/maemo/modest-main-window.c: (on_sendqueue_error_happened): + Use the logical IDs for the error message, though they are not + specific enough. Note that I used modest_maemo_show_information_note_and_forget() + because gtk_dialog_run() caused a hang here (the window did not close). + This fixes projects.maemo.org bug NB#62646. + +2007-07-09 Murray Cumming + + * src/modest-account-mgr-helpers.h: + * src/modest-account-mgr-helpers.c: + Added modest_account_mgr_get_store_protocol(). + + * src/maemo/modest-account-view-window.c: + (on_delete_button_clicked): Show different warning text depending on + the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead + of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug + NB#59037. + +2007-07-09 Murray Cumming + + * src/maemo/modest-msg-edit-window.c: + (modest_msg_edit_window_attach_file): Set the file chooser dialog title + as per the UI spec. This fixes proejcts.maemo.org bug NB#59056. + +2007-07-07 Armin Burgmeier + + * src/maemo/easysetup/modest-easysetup-wizard.c: Translate + ckdg_ib_maximum_characters_reached from correct package. + + * src/modest-ui-actions.c: Show an error message when a folder could + not be created. Tinymail does not give us specific error codes about + what has gone wrong, so we assume that a folder with that name + already exists, though there might be other reasons. + +2007-07-06 Murray Cumming + + * src/modest-tny-account-store.c: (modest_tny_account_store_alert): + Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to + give a more exact error message that can be partly translated. + +2007-07-05 Murray Cumming + + * src/maemo/modest-address-book.c: + (select_email_addrs_for_contact): Specify a default window size for the + select-email-address dialog, so that it is probably big enough for the + title. This should fix projects.maemo.org bug NB#62277. + +2007-07-05 Murray Cumming + + * src/maemo/easysetup/modest-easysetup-wizard.c: + (create_page_complete_easysetup): Use + gtk_widget_set_size() request to ensure that the text wraps + even in osso 1.1. + +2007-07-05 Johannes Schmid + + * src/maemo/easysetup/modest-easysetup-wizard.c: + (on_entry_invalid_character), (create_page_account_details), + (create_page_user_details): + Use new API of ModestValidatingEntry. But for some reason the banner is + not shown. I will have to investigate that further. + + * src/widgets/modest-validating-entry.c: (on_insert_text), + (modest_validating_entry_set_func): + * src/widgets/modest-validating-entry.h: + Added a new callback function to be able to react to prevented + characters whitespaces to e.g show a banner. + +2007-07-05 Armin Burgmeier + + * src/maemo/modest-account-settings-dialog.c: Use the notify::value + notification of HildonNumberEditor instead of remembering the port + number. Thanks to Johannes for pointing this out. + +2007-07-05 Johannes Schmid + + * src/maemo/easysetup/modest-easysetup-wizard.c: + Check if there are any user changes before showing a confirmation + dialog (projects.maemo.org NB#60946) + +2007-07-05 Armin Burgmeier + + * src/maemo/modest-account-settings-dialog.c: Remember custom port + number at the beginning of the dialog and set the modified flag at the + end if the port number has changed. This is necessary because + HildonNumberEditor does not support notification when the value has + changed. + +2007-07-05 Murray Cumming + + * src/modest-ui-actions.c: + (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs + a connection before asking anything else. Correct the check for the destination + folder so that it succeeds when online. + This fixed projects.maemo.org bug NB#61645. + +2007-07-05 Murray Cumming + + * src/modest-ui-actions.c: (modest_ui_actions_on_send): + Call modest_platform_connect_and_wait() to ask for a connection if necessary, + to fix projects.maemo.org bug NB#62439. + +2007-07-05 Murray Cumming + + * src/modest-tny-account.c: (on_connection_status_changed): + Really do not use tny_device_force_offline() here. See the previous comment. + +2007-07-04 Murray Cumming + + * src/modest-tny-account.c: (on_connection_status_changed): + Do not use tny_device_force_offline() when tinymail says that something + went wrong with the connection. It seems to report this unnecessarily. + +2007-07-04 Murray Cumming + + * src/maemo/modest-connection-specific-smtp-window.c: + (modest_connection_specific_smtp_window_init): + Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars() + does not seem to have any effect in osso 1.1 (though it works in + Maemo Bora). This fixes bug projects.maemo.org NB#59212. + +2007-07-04 Johannes Schmid + + * src/maemo/modest-connection-specific-smtp-window.c: + Fix UI specification problems with projects.meamo.org NB#60479 + +2007-07-04 Murray Cumming + + * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a + clue when this has failed, because the error dialog is not always shown + (at least in earlier version). + + (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual + GError message, because the generic error dialog is not helpful. + I am getting + 'This message is not currently available (can't let a new connection go online)' + when trying to open an IMAP message. + + (_modest_ui_actions_open): Offer a connection when some messages would + have to be downloaded and we are offline. + +2007-07-04 Johannes Schmid + + * src/widgets/modest-folder-view.c: + Don't check for MERGE type anymore as we use the correct type + now. + NOTE: For the last two changes you need to update your tinymail copy + because of API changes! + +2007-07-04 Johannes Schmid + + * src/modest-tny-local-folders-account.c: + Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX + (see projects.maemo.org NB#61580) + +2007-07-04 Murray Cumming + + * src/modest-tny-account.c: (on_connection_status_changed): + Commented out the call to modest_platform_connect_and_wait() because this + seems to always hang, and I would like to know if this is the only thing + that causes a hang when showing the connection dialog. + It is not very useful anyway. + +2007-07-04 Murray Cumming + + * src/maemo/modest-msg-view-window.c: + (modest_msg_view_window_select_next_message): + + * src/modest-platform.h: + * src/maemo/modest-platform.c: + Added modest_platform_connect_and_wait(), which calls + tny_maemo_conic_device_connect() always in the main thread, by calling it + in an idle handler and waiting for the idle handler to run. It should be + in the main thread because it uses GTK+ UI code. It just returns TRUE + if the device is already online. + + There is some nasty code to ensure that subsequent calls to + modest_platform_connect_and_wait() just wait for the first one to finish, + by checking repeatedly in another idle handler. This is necessary, + because other threads (or even the main thread, via another idle handler) + can call modest_platform_connect_and_wait() while + modest_platform_connect_and_wait() is running. + + (modest_platform_connect_and_wait_if_network_account), + (modest_platform_connect_and_wait_if_network_folderstore): + Convenience functions that calls modest_platform_connect_and_wait() if + the account or folder might want network access. + + * src/modest-mail-operation.c: + (modest_mail_operation_update_account): + * src/modest-ui-actions.c: (download_uncached_messages), + (modest_ui_actions_on_rename_folder), (delete_folder), + (modest_ui_actions_on_main_window_move_to), + (modest_ui_actions_on_msg_view_window_move_to): + * src/widgets/modest-folder-view.c: + (drag_and_drop_from_folder_view): + Offer a connection if we are offline. + + * src/modest-tny-account.c: (on_connection_status_changed): + Document this as only handling errors during network operations in progress, + and replace the idle code with a simple call to + modest_platform_connect_and_wait(), which does this instead. + +2007-07-03 Murray Cumming + + * src/modest-tny-account.c: + (modest_tny_account_get_special_folder): (util_on_idle), + Handle the GError so we can see when tny_folder_store_get_folders() + fails, as it currently does while something else is connecting. + + Added util_run_in_main_thread_and_wait() + which uses an idlen handler and mainloop to ensure that the function + is called in the main thread. + (on_connection_status_changed): Use util_run_in_main_thread_and_wait() + to make sure that we call attempt the connection in the mainloop only, + which might solve some hangs. + +2007-07-03 Murray Cumming + + (modest_tny_account_store_get_tny_account_by): Do not allow accounts to + be found by their display name. This is never useful. + * src/modest-tny-account-store.c: (on_account_removed): Find the account + by its ID, instead of trying to use its ID as its display name. + + * src/modest-tny-account-store.h: + * src/modest-tny-account.c: + (modest_tny_account_get_special_folder): Add a g_warning() when + tny_folder_store_get_folders() returns an empty list for the maildir. + + * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox): + Add a g_warning() when this returns NULL, because that it not allowed + by tinymail. + +2007-07-02 Armin Burgmeier + + * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation + note when trying to cancel the wizard. This fixes projects.maemo.org + bug NB#60946. + +2007-07-02 Murray Cumming + + * src/modest-tny-account.h: + * src/modest-tny-account.c: + (modest_tny_account_new_from_server_account), + (modest_tny_account_new_from_server_account_name), + (modest_tny_account_new_from_account): Added a TnyCamelSession parameter, + because this must now be set before setting the proto. This is usd in + modest_tny_account_new_from_server_account(). It avoids a (maybe harmless) + warning in camel_session_get_service() caused by + tny_camel_transport_account_prepare(). + + * src/modest-tny-account-store.c: (get_server_accounts): Pass the new + session parameter. + +2007-06-30 Johannes Schmid + + * src/maemo/modest-connection-specific-smtp-edit-window.c: + (on_value_changed), + (modest_connection_specific_smtp_edit_window_init): + + Fixed project.maemo.org bug NB#60479 by using "notify::value" instead + of "changed" for now + +2007-06-29 Murray Cumming + + * src/modest-tny-account.c: + (modest_tny_account_new_from_server_account): + Handle the TnyAccount::"connection-status-changed" signal, which tinymail + now uses to request a connection when it needs one, and which it uses + to tell us that something is wrong with the connection, so we can force + the accounts offline to prevent further problems. + + * src/modest-defs.h: + * src/modest-init.c: (init_default_settings): + * src/modest-mail-operation.c: + (modest_mail_operation_update_account): + * src/modest-main.c: (on_show): Do not try to connect explicitly on startup. + This should not be necessary anymore. Do not set the conf key that + determined this (it was always TRUE and not set anywhere else). + + * src/modest-ui-actions.h: Remove unused and unimplemented + modest_ui_actions_on_online_toggle_toggled(). + +2007-06-29 Murray Cumming + + * src/modest-mail-operation.c: Fixed a crash when canceling a mail + receive operation. + +2007-06-27 Murray Cumming + + * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting + for supported secure authentication methods from server by + gtk_dialog_run(), saving CPU time and a potential race condition. + +2007-06-26 Armin Burgmeier + + * src/maemo/modest-maemo-utils.h: + * src/maemo/modest-maemo-utils.c: Added a + ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as + only error code to tell the calling code when the user canceled the + operation. + + * src/maemo/modest-account-settings-dialog.h: + * src/maemo/modest-account-settings-dialog.c: + * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error + message if the retrieval of secure authentication methods was canceled + by the user. Perform the check before saving anything to configuration + to not end up with half-committed configuration changes, do not show + a "Saving to configuration failed" note when authentication methods + could not be retrieved. + + * src/maemo/modest-main-window.c: Fixed a crash on startup when built + with old hildon. + +2007-06-26 Murray Cumming + + * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list): + Only return the first level of folders under accounts, because the + osso-global-search UI spec doesn't want the rest. + This fixed projects.maemo.org bug NB#61811. + +2007-06-26 Murray Cumming + + * src/modest-tny-account-store.c: + * src/modest-tny-account-store.h: + Added modest_tny_account_is_memory_card_account(). + * src/maemo/modest-main-window.c: (create_details_widget): + Show the same information items for the memory card as we show for the + local-folders, to fix projects.maemo.org bug NB#59307. + +2007-06-26 Murray Cumming + + * src/modest-tny-account-store.c: (get_password): + Added some checks for NULL to maybe prevent crashes, though I think + it was Philip's last commit that actually prevented the crash here + when creating a first new account. + But the new account is still not usable (no messages are shown) + until a restart of the application. + +2007-06-26 Murray Cumming + + * src/maemo/modest-maemo-global-settings-dialog.c: + (idle_select_default_focus): + * src/modest-mail-operation.c: (idle_notify_progress), + (idle_notify_progress_once), (idle_notify_update_account_queue), + (set_last_updated_idle), (update_account_thread), + (notify_get_msgs_full), (get_msgs_full_destroyer), + (get_msgs_full_thread): + * src/widgets/modest-attachment-view.c: (get_size_idle_func): + * src/widgets/modest-header-view.c: + (idle_notify_headers_count_changed_destroy), + (idle_notify_headers_count_changed): + Use gdk_threads_enter() and gdk_threads_enter_leave() in + all idle handlers, because some other thread could be blocking + the GDK lock, so that it can do GUI stuff. + +2007-06-26 Murray Cumming + + * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to), + (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message), + (on_idle_send_receive), (on_idle_open_default_inbox): + * src/maemo/modest-msg-edit-window.c: + (modest_msg_edit_window_attach_file_noninteractive): + Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers, + to prevent a hang. I don't quite understand why these are necessary, + beause we should already be in the main loop. I guess something outside + of the main loop is taking the lock. + + * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so + we are really using URIs, and use files that are more likely to exist. + +2007-06-26 Murray Cumming + + * tests/dbus_api/Makefile.am: Fix the build of the tests. This was + necessary because configure.ac now defines different variables. + +2007-06-26 Murray Cumming + + * libmodest-dbus-client/libmodest-dbus-client.c: + * libmodest-dbus-client/libmodest-dbus-client.h: + Removed libmodest_dbus_client_send_mail() because it is not used by anything. + libmodest_dbus_client_compose_mail() is what things actually use. + + * src/dbus_api/modest-dbus-api.h: + * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler): + * tests/dbus_api/Makefile.am: + * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL + D-Bus method. + +2007-06-26 Murray Cumming + + * src/modest-init.c: (modest_init_local_folders): + For memory-card (or other non local-folders) maildir accounts, + always create an Archive folder, so that there is somewhere to put + messages. This should be less confusing, because the user does not need + to guess that the need to create a folder. + +2007-06-25 Johannes Schmid + + * src/maemo/easysetup/modest-wizard-dialog.c: (init): + Fixed icon size by using (50, 50) which is the same as defined by + newer hildon-libs + +2007-06-25 Armin Burgmeier + + * src/widgets/modest-window-mgr.c: + * src/modest-init.c: + * configure.ac: Correctly recognize hildon-notify presence and fixed + the build without it being installed. + +2007-06-25 Murray Cumming + + * libmodest-dbus-client/libmodest-dbus-client.c: + (libmodest_dbus_client_search): Fix the build. Sorry. + * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg), + (reply_forward_cb): Initialize variables to fix the build. + + * src/modest-tny-account-store.c: + (modest_tny_account_store_get_tny_account_by): Fix the account URI + comparison (a silly typo) so that email search results can be opened + when there are more than one account. + +2007-06-25 Murray Cumming + + * libmodest-dbus-client/libmodest-dbus-client.c: + (libmodest_dbus_client_search), + (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes) + instead of 1 second, because the search gets folders and messages from + the server, which can take a long time. When it times out, + osso-global-search will report no results. + + We need to specify whether we should search only cached information + (maybe with a user preference), and the osso-email-search-plugin + API should really be improved to allow that option, and to allow results + to be delivered asynchronously in batches. + 2007-06-25 Murray Cumming * src/maemo/easysetup/modest-wizard-dialog.c: (init):