X-Git-Url: http://git.maemo.org/git/?p=modest;a=blobdiff_plain;f=ChangeLog2;h=5de6f114ade8a1eb5b873f4a459b179707478415;hp=c31fa8f1158a0f5a5fdebdc73c490b0d1cf222b0;hb=434f59409e20ea0ae3a828422d1c9cc91fdde8fa;hpb=82db6696192ac4f9319952f1aaa650b979df3870 diff --git a/ChangeLog2 b/ChangeLog2 index c31fa8f..5de6f11 100644 --- a/ChangeLog2 +++ b/ChangeLog2 @@ -1,3 +1,917 @@ +2007-07-09 Murray Cumming + + * src/maemo/modest-maemo-utils.h: + * src/maemo/modest-maemo-utils.c: + Added modest_maemo_show_information_note_and_forget() for use instead of + gtk_dialog_run() when the response is not needed, to avoid an extra + mainloop which could cause a hang. + + * src/maemo/modest-main-window.c: (on_sendqueue_error_happened): + Use the logical IDs for the error message, though they are not + specific enough. Note that I used modest_maemo_show_information_note_and_forget() + because gtk_dialog_run() caused a hang here (the window did not close). + +2007-07-09 Murray Cumming + + * src/modest-account-mgr-helpers.h: + * src/modest-account-mgr-helpers.c: + Added modest_account_mgr_get_store_protocol(). + + * src/maemo/modest-account-view-window.c: + (on_delete_button_clicked): Show different warning text depending on + the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead + of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug + NB#59037. + +2007-07-09 Murray Cumming + + * src/maemo/modest-msg-edit-window.c: + (modest_msg_edit_window_attach_file): Set the file chooser dialog title + as per the UI spec. This fixes proejcts.maemo.org bug NB#59056. + +2007-07-07 Armin Burgmeier + + * src/maemo/easysetup/modest-easysetup-wizard.c: Translate + ckdg_ib_maximum_characters_reached from correct package. + + * src/modest-ui-actions.c: Show an error message when a folder could + not be created. Tinymail does not give us specific error codes about + what has gone wrong, so we assume that a folder with that name + already exists, though there might be other reasons. + +2007-07-06 Murray Cumming + + * src/modest-tny-account-store.c: (modest_tny_account_store_alert): + Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to + give a more exact error message that can be partly translated. + +2007-07-05 Murray Cumming + + * src/maemo/modest-address-book.c: + (select_email_addrs_for_contact): Specify a default window size for the + select-email-address dialog, so that it is probably big enough for the + title. This should fix projects.maemo.org bug NB#62277. + +2007-07-05 Murray Cumming + + * src/maemo/easysetup/modest-easysetup-wizard.c: + (create_page_complete_easysetup): Use + gtk_widget_set_size() request to ensure that the text wraps + even in osso 1.1. + +2007-07-05 Johannes Schmid + + * src/maemo/easysetup/modest-easysetup-wizard.c: + (on_entry_invalid_character), (create_page_account_details), + (create_page_user_details): + Use new API of ModestValidatingEntry. But for some reason the banner is + not shown. I will have to investigate that further. + + * src/widgets/modest-validating-entry.c: (on_insert_text), + (modest_validating_entry_set_func): + * src/widgets/modest-validating-entry.h: + Added a new callback function to be able to react to prevented + characters whitespaces to e.g show a banner. + +2007-07-05 Armin Burgmeier + + * src/maemo/modest-account-settings-dialog.c: Use the notify::value + notification of HildonNumberEditor instead of remembering the port + number. Thanks to Johannes for pointing this out. + +2007-07-05 Johannes Schmid + + * src/maemo/easysetup/modest-easysetup-wizard.c: + Check if there are any user changes before showing a confirmation + dialog (projects.maemo.org NB#60946) + +2007-07-05 Armin Burgmeier + + * src/maemo/modest-account-settings-dialog.c: Remember custom port + number at the beginning of the dialog and set the modified flag at the + end if the port number has changed. This is necessary because + HildonNumberEditor does not support notification when the value has + changed. + +2007-07-05 Murray Cumming + + * src/modest-ui-actions.c: + (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs + a connection before asking anything else. Correct the check for the destination + folder so that it succeeds when online. + This fixed projects.maemo.org bug NB#61645. + +2007-07-05 Murray Cumming + + * src/modest-ui-actions.c: (modest_ui_actions_on_send): + Call modest_platform_connect_and_wait() to ask for a connection if necessary, + to fix projects.maemo.org bug NB#62439. + +2007-07-05 Murray Cumming + + * src/modest-tny-account.c: (on_connection_status_changed): + Really do not use tny_device_force_offline() here. See the previous comment. + +2007-07-04 Murray Cumming + + * src/modest-tny-account.c: (on_connection_status_changed): + Do not use tny_device_force_offline() when tinymail says that something + went wrong with the connection. It seems to report this unnecessarily. + +2007-07-04 Murray Cumming + + * src/maemo/modest-connection-specific-smtp-window.c: + (modest_connection_specific_smtp_window_init): + Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars() + does not seem to have any effect in osso 1.1 (though it works in + Maemo Bora). This fixes bug projects.maemo.org NB#59212. + +2007-07-04 Johannes Schmid + + * src/maemo/modest-connection-specific-smtp-window.c: + Fix UI specification problems with projects.meamo.org NB#60479 + +2007-07-04 Murray Cumming + + * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a + clue when this has failed, because the error dialog is not always shown + (at least in earlier version). + + (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual + GError message, because the generic error dialog is not helpful. + I am getting + 'This message is not currently available (can't let a new connection go online)' + when trying to open an IMAP message. + + (_modest_ui_actions_open): Offer a connection when some messages would + have to be downloaded and we are offline. + +2007-07-04 Johannes Schmid + + * src/widgets/modest-folder-view.c: + Don't check for MERGE type anymore as we use the correct type + now. + NOTE: For the last two changes you need to update your tinymail copy + because of API changes! + +2007-07-04 Johannes Schmid + + * src/modest-tny-local-folders-account.c: + Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX + (see projects.maemo.org NB#61580) + +2007-07-04 Murray Cumming + + * src/modest-tny-account.c: (on_connection_status_changed): + Commented out the call to modest_platform_connect_and_wait() because this + seems to always hang, and I would like to know if this is the only thing + that causes a hang when showing the connection dialog. + It is not very useful anyway. + +2007-07-04 Murray Cumming + + * src/maemo/modest-msg-view-window.c: + (modest_msg_view_window_select_next_message): + + * src/modest-platform.h: + * src/maemo/modest-platform.c: + Added modest_platform_connect_and_wait(), which calls + tny_maemo_conic_device_connect() always in the main thread, by calling it + in an idle handler and waiting for the idle handler to run. It should be + in the main thread because it uses GTK+ UI code. It just returns TRUE + if the device is already online. + + There is some nasty code to ensure that subsequent calls to + modest_platform_connect_and_wait() just wait for the first one to finish, + by checking repeatedly in another idle handler. This is necessary, + because other threads (or even the main thread, via another idle handler) + can call modest_platform_connect_and_wait() while + modest_platform_connect_and_wait() is running. + + (modest_platform_connect_and_wait_if_network_account), + (modest_platform_connect_and_wait_if_network_folderstore): + Convenience functions that calls modest_platform_connect_and_wait() if + the account or folder might want network access. + + * src/modest-mail-operation.c: + (modest_mail_operation_update_account): + * src/modest-ui-actions.c: (download_uncached_messages), + (modest_ui_actions_on_rename_folder), (delete_folder), + (modest_ui_actions_on_main_window_move_to), + (modest_ui_actions_on_msg_view_window_move_to): + * src/widgets/modest-folder-view.c: + (drag_and_drop_from_folder_view): + Offer a connection if we are offline. + + * src/modest-tny-account.c: (on_connection_status_changed): + Document this as only handling errors during network operations in progress, + and replace the idle code with a simple call to + modest_platform_connect_and_wait(), which does this instead. + +2007-07-03 Murray Cumming + + * src/modest-tny-account.c: + (modest_tny_account_get_special_folder): (util_on_idle), + Handle the GError so we can see when tny_folder_store_get_folders() + fails, as it currently does while something else is connecting. + + Added util_run_in_main_thread_and_wait() + which uses an idlen handler and mainloop to ensure that the function + is called in the main thread. + (on_connection_status_changed): Use util_run_in_main_thread_and_wait() + to make sure that we call attempt the connection in the mainloop only, + which might solve some hangs. + +2007-07-03 Murray Cumming + + (modest_tny_account_store_get_tny_account_by): Do not allow accounts to + be found by their display name. This is never useful. + * src/modest-tny-account-store.c: (on_account_removed): Find the account + by its ID, instead of trying to use its ID as its display name. + + * src/modest-tny-account-store.h: + * src/modest-tny-account.c: + (modest_tny_account_get_special_folder): Add a g_warning() when + tny_folder_store_get_folders() returns an empty list for the maildir. + + * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox): + Add a g_warning() when this returns NULL, because that it not allowed + by tinymail. + +2007-07-02 Armin Burgmeier + + * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation + note when trying to cancel the wizard. This fixes projects.maemo.org + bug NB#60946. + +2007-07-02 Murray Cumming + + * src/modest-tny-account.h: + * src/modest-tny-account.c: + (modest_tny_account_new_from_server_account), + (modest_tny_account_new_from_server_account_name), + (modest_tny_account_new_from_account): Added a TnyCamelSession parameter, + because this must now be set before setting the proto. This is usd in + modest_tny_account_new_from_server_account(). It avoids a (maybe harmless) + warning in camel_session_get_service() caused by + tny_camel_transport_account_prepare(). + + * src/modest-tny-account-store.c: (get_server_accounts): Pass the new + session parameter. + +2007-06-30 Johannes Schmid + + * src/maemo/modest-connection-specific-smtp-edit-window.c: + (on_value_changed), + (modest_connection_specific_smtp_edit_window_init): + + Fixed project.maemo.org bug NB#60479 by using "notify::value" instead + of "changed" for now + +2007-06-29 Murray Cumming + + * src/modest-tny-account.c: + (modest_tny_account_new_from_server_account): + Handle the TnyAccount::"connection-status-changed" signal, which tinymail + now uses to request a connection when it needs one, and which it uses + to tell us that something is wrong with the connection, so we can force + the accounts offline to prevent further problems. + + * src/modest-defs.h: + * src/modest-init.c: (init_default_settings): + * src/modest-mail-operation.c: + (modest_mail_operation_update_account): + * src/modest-main.c: (on_show): Do not try to connect explicitly on startup. + This should not be necessary anymore. Do not set the conf key that + determined this (it was always TRUE and not set anywhere else). + + * src/modest-ui-actions.h: Remove unused and unimplemented + modest_ui_actions_on_online_toggle_toggled(). + +2007-06-29 Murray Cumming + + * src/modest-mail-operation.c: Fixed a crash when canceling a mail + receive operation. + +2007-06-27 Murray Cumming + + * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting + for supported secure authentication methods from server by + gtk_dialog_run(), saving CPU time and a potential race condition. + +2007-06-26 Armin Burgmeier + + * src/maemo/modest-maemo-utils.h: + * src/maemo/modest-maemo-utils.c: Added a + ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as + only error code to tell the calling code when the user canceled the + operation. + + * src/maemo/modest-account-settings-dialog.h: + * src/maemo/modest-account-settings-dialog.c: + * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error + message if the retrieval of secure authentication methods was canceled + by the user. Perform the check before saving anything to configuration + to not end up with half-committed configuration changes, do not show + a "Saving to configuration failed" note when authentication methods + could not be retrieved. + + * src/maemo/modest-main-window.c: Fixed a crash on startup when built + with old hildon. + +2007-06-26 Murray Cumming + + * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list): + Only return the first level of folders under accounts, because the + osso-global-search UI spec doesn't want the rest. + This fixed projects.maemo.org bug NB#61811. + +2007-06-26 Murray Cumming + + * src/modest-tny-account-store.c: + * src/modest-tny-account-store.h: + Added modest_tny_account_is_memory_card_account(). + * src/maemo/modest-main-window.c: (create_details_widget): + Show the same information items for the memory card as we show for the + local-folders, to fix projects.maemo.org bug NB#59307. + +2007-06-26 Murray Cumming + + * src/modest-tny-account-store.c: (get_password): + Added some checks for NULL to maybe prevent crashes, though I think + it was Philip's last commit that actually prevented the crash here + when creating a first new account. + But the new account is still not usable (no messages are shown) + until a restart of the application. + +2007-06-26 Murray Cumming + + * src/maemo/modest-maemo-global-settings-dialog.c: + (idle_select_default_focus): + * src/modest-mail-operation.c: (idle_notify_progress), + (idle_notify_progress_once), (idle_notify_update_account_queue), + (set_last_updated_idle), (update_account_thread), + (notify_get_msgs_full), (get_msgs_full_destroyer), + (get_msgs_full_thread): + * src/widgets/modest-attachment-view.c: (get_size_idle_func): + * src/widgets/modest-header-view.c: + (idle_notify_headers_count_changed_destroy), + (idle_notify_headers_count_changed): + Use gdk_threads_enter() and gdk_threads_enter_leave() in + all idle handlers, because some other thread could be blocking + the GDK lock, so that it can do GUI stuff. + +2007-06-26 Murray Cumming + + * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to), + (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message), + (on_idle_send_receive), (on_idle_open_default_inbox): + * src/maemo/modest-msg-edit-window.c: + (modest_msg_edit_window_attach_file_noninteractive): + Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers, + to prevent a hang. I don't quite understand why these are necessary, + beause we should already be in the main loop. I guess something outside + of the main loop is taking the lock. + + * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so + we are really using URIs, and use files that are more likely to exist. + +2007-06-26 Murray Cumming + + * tests/dbus_api/Makefile.am: Fix the build of the tests. This was + necessary because configure.ac now defines different variables. + +2007-06-26 Murray Cumming + + * libmodest-dbus-client/libmodest-dbus-client.c: + * libmodest-dbus-client/libmodest-dbus-client.h: + Removed libmodest_dbus_client_send_mail() because it is not used by anything. + libmodest_dbus_client_compose_mail() is what things actually use. + + * src/dbus_api/modest-dbus-api.h: + * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler): + * tests/dbus_api/Makefile.am: + * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL + D-Bus method. + +2007-06-26 Murray Cumming + + * src/modest-init.c: (modest_init_local_folders): + For memory-card (or other non local-folders) maildir accounts, + always create an Archive folder, so that there is somewhere to put + messages. This should be less confusing, because the user does not need + to guess that the need to create a folder. + +2007-06-25 Johannes Schmid + + * src/maemo/easysetup/modest-wizard-dialog.c: (init): + Fixed icon size by using (50, 50) which is the same as defined by + newer hildon-libs + +2007-06-25 Armin Burgmeier + + * src/widgets/modest-window-mgr.c: + * src/modest-init.c: + * configure.ac: Correctly recognize hildon-notify presence and fixed + the build without it being installed. + +2007-06-25 Murray Cumming + + * libmodest-dbus-client/libmodest-dbus-client.c: + (libmodest_dbus_client_search): Fix the build. Sorry. + * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg), + (reply_forward_cb): Initialize variables to fix the build. + + * src/modest-tny-account-store.c: + (modest_tny_account_store_get_tny_account_by): Fix the account URI + comparison (a silly typo) so that email search results can be opened + when there are more than one account. + +2007-06-25 Murray Cumming + + * libmodest-dbus-client/libmodest-dbus-client.c: + (libmodest_dbus_client_search), + (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes) + instead of 1 second, because the search gets folders and messages from + the server, which can take a long time. When it times out, + osso-global-search will report no results. + + We need to specify whether we should search only cached information + (maybe with a user preference), and the osso-email-search-plugin + API should really be improved to allow that option, and to allow results + to be delivered asynchronously in batches. + +2007-06-25 Murray Cumming + + * src/maemo/easysetup/modest-wizard-dialog.c: (init): + Fix a typo to fix the osso 1.1. build. See the TODO comment though - + GTK_ICON_SIZE_DIALOG is probably the wrong size. + +2007-06-25 Murray Cumming + + * src/modest-search.c: (modest_search_folder): Ignore a seach folder + that is an empty string. D-Bus seems to give us these instead of NULL. + +2007-06-25 Johannes Schmid + + * src/dbus_api/modest-dbus-callbacks.c: + * src/maemo/easysetup/modest-easysetup-wizard.h: + * src/maemo/easysetup/modest-wizard-dialog.c: (init): + * src/maemo/modest-connection-specific-smtp-edit-window.c: + (modest_connection_specific_smtp_edit_window_init): + * src/maemo/modest-maemo-global-settings-dialog.c: + (on_range_error): + * src/maemo/modest-maemo-utils.c: + (modest_maemo_utils_setup_images_filechooser): + * src/maemo/modest-main-window.c: (create_details_widget): + * src/maemo/modest-msg-edit-window.c: + (modest_msg_edit_window_attach_file_noninteractive), + (modest_msg_edit_window_color_button_change), + (modest_msg_edit_window_set_zoom): + * src/modest-mail-operation.c: (update_account_thread): + * src/modest-tny-account-store.c: + * src/modest-tny-account.c: + * src/widgets/modest-global-settings-dialog.c: + * src/widgets/modest-window.h: + + Fixed build on bora! + +2007-06-25 Murray Cumming + + * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search): + * src/modest-search.c: (modest_search_folder), + (modest_search_all_accounts): Actually search only in the specified folder, + doing a simple match on the folder ID. + * src/modest-search.h: Added a folder field to the ModestSearch struct, + and added some documentation. + +2007-06-22 Armin Burgmeier + + * src/maemo/modest-maemo-utils.h: + * src/maemo/modest-maemo-utils.c: Added a GError parameter to + modest_maemo_utils_get_supported_secure_authentication_methods. + + * src/maemo/easysetup/modest-easysetup-wizard.c: + * src/maemo/modest-account-settings-dialog.c: Show correct error if + one occured, not just "Server does not support secure authentication". + +2007-06-22 Murray Cumming + + * src/modest-tny-account-store.c: (get_password): + Restored the call to tny_account_set_user() because Philip seems to have + stopped this from crashing (by not using the freed string). It still does + not work, but now we can test it. + +2007-06-22 Murray Cumming + + * src/maemo/modest-msg-edit-window.c: (init_window): + Comment out use of an uninitialzed GtkScrolledWindow variable, + to fix the build and stop a crash. Yet again. + +2007-06-22 Murray Cumming + + * src/modest-tny-account-store.c: (get_password): + Remove the call to tny_account_set_user() because this actually crashes. + As mentioned in the last commit, it is known to not work anyway. + +2007-06-22 Murray Cumming + + * src/modest-tny-account-store.c: (get_password): + Use tny_account_set_username() to tell tinymail that the username might + have changed too. But tinymail ignores this: see projects.maemo.org + bug #61463. + * src/modest-ui-actions.c: + (modest_ui_actions_on_password_requested): Remove the useless attempt to + reset the connection when changing the username, and improve the comments. + Save the changed username to gconf at least, so it is used when Modest is + restarted. + +2007-06-21 Murray Cumming + + * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list): + Do not use a query, so that we get all folders, including for POP and + local-folders. They work as search criteria too. + This fixes projects.maemo.org bug NB#57740. + +2007-06-21 Murray Cumming + + * src/maemo/modest-platform.c: (modest_platform_on_new_msg): + Comment out the use of hildon_notification_set_sound() because it is + not declared, to fix the build. Warnings are serious, people. + +2007-06-21 Armin Burgmeier + + * src/maemo/modest-maemo-utils.h: + * src/maemo/modest-maemo-utils.c: Added a username parameter to the + modest_maemo_utils_get_supported_secure_authentication_methods() + to query authentication methods for a specific user. This should fix + projects.maemo.org bug NB#61369. + + * src/maemo/easysetup/modest-easysetup-wizard.c: + * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that + function. + +2007-06-21 Murray Cumming + + * libmodest-dbus-client/libmodest-dbus-client.h: + * libmodest-dbus-client/libmodest-dbus-client.c: + (modest_dbus_message_iter_get_search_hit), + (libmodest_dbus_client_search): + Reorganised and commented this. + Removed modest_search_hit_free() from the public API because it + is not needed. + + Added libmodest_dbus_client_get_folders() and + modest_folder_result_list_free(). + + * src/dbus_api/modest-dbus-api.h: + * src/dbus_api/modest-dbus-callbacks.c: + (modest_dbus_req_filter): Commented. Moved most code to + on_dbus_method_search() and added on_dbus_method_get_folders(). + + * src/maemo/modest-platform.c: (modest_platform_init): Commented the use + of the extra D-Bus handler. + + * tests/dbus_api/Makefile.am: + * tests/dbus_api/test_get_folders.c: New test for + libmodest_dbus_client_get_folders(). This seems to return an empty list + at the moment. That could be the same error that causes the message list + to be empty sometimes. + This should help with projects.maemo.org bug NB#57740. + +2007-06-21 Armin Burgmeier + + * src/modest-mail-operation.c: Do not call + modest_mail_operation_queue_cancel_all() in _cancel() but do instead + notify the operation's end after having set the status to CANCELED for + the operation queue to listen on. This fixes a deadlock when there + were mail operations in the queue during its finalization. + + * src/modest-singletons.c: Reordered uninitialization of the account + manager to happen after the mail operation queue was uninitialized + because the mail operation's in the queue might still try to access + the account manager (see modest_mail_operation_notify_end()). This + fixes a potential crash when terminating the application. + +2007-06-21 Murray Cumming + + * src/modest-search.c: + (search_mime_part_and_child_parts): Moved some code here so we + can search recursively in child folders. + (modest_search_folder): Search in the message as a mime part, instead + of just its child mime parts. + (read_chunk), (search_mime_part_ogs): + Check how many bytes were read, to prevent an endless loop. + Searching in message bodies now works. This finishes the fix for + projects.maemo.org bug NB#61007. + +2007-06-20 Murray Cumming + + * src/modest-ui-actions.c: (modest_ui_actions_on_details): + Add a g_warning when the item is not a folder. + + * src/modest-ui-dimming-rules.c: + (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item + when selected item is not a folder (for instance, an account), because + the UI spec only talks about folders. + I am not sure what the UI spec wants, so this might not totally fix + projects.maemo.org bug NB#60794. + +2007-06-20 Murray Cumming + + * src/maemo/easysetup/modest-easysetup-country-combo-box.c: + (load_from_file): Sort the list. The unsorted list would be more noticeable + in non-English locales. + + * src/maemo/modest-msg-edit-window.c: + (modest_msg_edit_window_attach_file): Initialize a variable to avoid a + warning and fix the build. + + * src/maemo/modest-progress-bar-widget.c: + (modest_progress_bar_widget_set_progress): Avoid a division by zero, to + avoid a g_warning, and probably to avoid a crash. + +2007-06-20 Murray Cumming + + * src/modest-search.c: (modest_search_folder): Check for a GError + when calling tny_folder_get_headers(), to show that this is not the cause + of later failure. + +2007-06-20 Murray Cumming + + * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter): + Actually set the body query instead of the subject query. + + * src/modest-search.c: (search_mime_part_ogs), + (search_mime_part_strcmp): Remove extra space from the text/* regex, + which would probably cause it to fail if we got this far. + + (modest_search_folder): Use simple #ifdefs instead of the function pointer, + to simplify the code. + Warn when tny_mime_part_get_parts() returns an empty list, which seems to + be causing search-in-body to fail. + +2007-06-20 Murray Cumming + + * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder + struct item. + * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url): + Better debug message when the folder cannot be found. + This should help with fixing projects.maemo.org bug #61287. + * src/modest-search.c: (add_hit): Do not leak the furl string. + +2007-06-20 Murray Cumming + + * src/modest-ui-actions.c: + (modest_ui_actions_on_folder_selection_changed): + Do not special-case TNY_MERGE_FOLDER here, because + modest_tny_folder_get_account() already does that. This fixes + projects.maemo.org bug NB#60955 (The smtp connections dialog was not + shown when the Outbox was selected). + +2007-06-19 Murray Cumming,,, + + * libmodest-dbus-client/libmodest-dbus-client.c: + (_dbus_iter_get_string_or_null): Initialize the string variable in + case this helps with Dirk's crash. + +2007-06-19 Murray Cumming + + * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail, + though it is not implemented yet (this function is maybe not even used), + to avoid breaking ABI in future. + * libmodest-dbus-client/libmodest-dbus-client.c: + (get_attachments_string): Moved some code into this generic function. + (libmodest_dbus_client_send_mail): Corrected the documentation. This really + sends email. It is maybe not used. + * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail), + (on_send_mail): Use attachments. + + * src/widgets/modest-msg-edit-window.h: Improve the documentation. + * src/maemo/modest-msg-edit-window.c: + (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to + a filename before using it, to fix projects.maemo.org bug NB#58233. + +2007-06-19 Murray Cumming + + * src/modest-ui-actions.c: (modest_ui_actions_on_copy): + Initialize the continue_download variable to fix the build, and probably + to fix randome behaviour. + +2007-06-18 Armin Burgmeier + + * src/modest-tny-send-queue.h: + * src/modest-tny-send-queue.c: Keep track of the status of messages in + the queue so we can later show it in the UI. Replaced + modest_tny_send_queue_msg_is_being_sent() by + modest_tny_send_queue_get_msg_status(). + + * src/modest-ui-dimming-rules.c: Adjust for the replaced function. + + * src/modest-tny-account.c: Changed a cast to gpointer* to one to + gpointer. This probably was not harmful, but just to be sure. + +2007-06-18 Murray Cumming + + * src/maemo/modest-platform.c: (modest_platform_activate_uri): + Fix the build, but leave the function broken on Bora, because + hildon_uri_action_get_service() does not exist. + osso_uri_action_get_service() does not exist either, it seems. + +2007-06-18 Murray Cumming + + * src/modest-tny-account.c: + (modest_tny_account_new_from_server_account): + Uncommented the url debug output again, because it is useful for + debugging, as I said in the comment. + +2007-06-18 Murray Cumming + + * configure.ac: Do not require hildon-notify for Maemo Bora. It is not + available. + * src/modest-init.c: (modest_init_init_ui): Do not call notify_init() + for Mameo Bora, to fix the build. + +2007-06-17 Johannes Schmid + + * configure.ac: + Fixed build with hildon < 0.99 + + * src/maemo/modest-account-view-window.c: (on_edit_button_clicked): + Check if the selected account is busy instead of checking all accounts + + * src/modest-account-mgr-priv.h: + * src/modest-account-mgr.c: (modest_account_mgr_class_init), + (modest_account_mgr_init), (compare_account_name), + (modest_account_mgr_set_account_busy), + (modest_account_mgr_account_is_busy): + * src/modest-account-mgr.h: + Added busy information to the account manager. It possible to + set an account to busy or not busy now. + + * src/modest-mail-operation.c: (modest_mail_operation_finalize), + (modest_mail_operation_update_account), + (modest_mail_operation_notify_end): + Set the account to busy/not busy depending on the operation state. + + * src/widgets/modest-account-view.c: + (modest_account_view_finalize), (get_last_updated_string), + (update_account_view), (on_account_busy_changed), (init_view): + Show string "Refreshing..." if the account is currently busy. + + All this fixes projects.maemo.org bug NB#59711 + +2007-06-14 Armin Burgmeier + + * src/widgets/modest-attachments-view.h: + * src/widgets/modest-attachments-view.c: Added + modest_attachments_view_has_attachments() and fixed coordinate + transformation in get_att_view_at_coords(). This fixes attachment + selection. + + * src/widgets/modest-msg-view.c: Make use of + modest_attachments_view_has_attachments() to decide whether to show + attachments in the header. + +2007-06-14 Johannes Schmid + + * src/maemo/modest-connection-specific-smtp-edit-window.c: + (on_change), (on_combo_security_changed), + (modest_connection_specific_smtp_edit_window_init), + (modest_connection_specific_smtp_edit_window_set_connection), + (modest_connection_specific_smtp_edit_window_is_dirty): + * src/maemo/modest-connection-specific-smtp-edit-window.h: + * src/maemo/modest-connection-specific-smtp-window.c: + (on_button_edit): + + Show an comfirmation dialog for the smpt-edit-window if there are + unsaved changes and the user hits cancel. + (projects.maemo.org bug NB#60479) + +2007-06-14 Armin Burgmeier + + * src/maemo/easysetup/modest-easysetup-wizard.c: + * src/maemo/modest-account-settings-dialog.c: Show "invalid email + address" info in banner instead of node, and select all the text as + per UI spec. This fixes projects.maemo.org bug NB#60550. + +2007-06-14 set REAL_NAME environment variable + + reviewed by: + + * src/maemo/modest-main-window.c: (_on_msg_count_changed): + * src/modest-ui-actions.c: (folder_refreshed_cb): + +2007-06-14 Murray Cumming + + * src/widgets/modest-folder-view.c: (filter_row): + Explictly filter out the per-account outbox accounts. I don't know why + these only sometimes show up, but now they should never show up in the UI. + This should fix projects.maemo.org bug NB#60160. + +2007-06-14 Murray Cumming + + * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning + when the toolbar does not exist yet. + * src/modest-widget-memory.c: (save_settings_header_view): + Added g_warnings() to help us to discover when we are trying to set + an empty columns list in gconf. + +2007-06-14 Murray Cumming + + * src/modest-init.h: + * src/modest-init.c: + Added modest_init_get_default_header_view_column_ids(). + + * src/modest-widget-memory.c: (restore_settings_header_view): + Use the new function to get defaults, if the gconf key is empty, + instead of not creating any columns. This seems to fix the + empty right-hand pane problems. + + * src/widgets/modest-header-view.h: Improved documentation. + +2007-06-13 Murray Cumming + + * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account): + Revert the use of the display name as the account name, because this + is generally wrong and would break the code that follows. + +2007-06-13 Johannes Schmid + + * src/maemo/easysetup/modest-easysetup-wizard.c: + (check_for_supported_auth_methods), (on_before_next), + (create_account): + + More correct fix for projects.maemo.org bug NB# 58991 + Do not longer accept AUTH_PASSWORD as secure method and choose + correct method when creating the account. + +2007-06-13 Johannes Schmid + + * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account): + Fixed projects.maemo.org bug NB# 58991 + 2007-06-13 Murray Cumming * src/modest-init.c: (modest_init_init_core), @@ -2842,6 +3756,3 @@ Added modest_ui_actions_on_new_account() as a signal handler for the New Account menu item. It shows the easysetup wizard. * po/en_GB.po: Added additional needed logical IDs and translations. - -Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc. -Apparently ChangeLog is not used for some vague Nokia legal reasons.