X-Git-Url: http://git.maemo.org/git/?p=modest;a=blobdiff_plain;f=ChangeLog2;h=934bd571fa90c037d870fe90aa278a3482f6fa3e;hp=862cfbdf05afe019620e00034f9a7aa48949a0a7;hb=92bef44ea70f8b4e16c78591bc12f58fac9a7c53;hpb=283500d53f02ac53cd731a23025b8a3ba53e1352 diff --git a/ChangeLog2 b/ChangeLog2 index 862cfbd..934bd57 100644 --- a/ChangeLog2 +++ b/ChangeLog2 @@ -1,4 +1,361 @@ -2007-07-16 Murray Cumming +2007-08-04 Johannes Schmid + + * src/modest-text-utils.c: + Fixed invalid jump due to incorrect string/pointer + operation. + (See https://projects.maemo.org/trac/email/wiki/ValgrindErrors + for details) + +2007-08-01 Murray Cumming + + * src/modest-account-mgr-helpers.h: + * src/modest-account-mgr-helpers.c: + Added modest_account_mgr_get_first_account_name(), + using code from modest_account_mgr_set_first_account_as_default(). + + * src/maemo/modest-main-window.c: Added set_at_least_one_account_visible(). + (account_number_changed): Call set_at_least_one_account_visible() so that + the first account is visible when first added, without the user having to + use the View menu. + I do wonder how this worked before. + +2007-08-01 Murray Cumming + + * src/modest-tny-account-store.c: (show_password_warning_only), + (show_wrong_password), (request_password_and_wait), (get_password), + (modest_tny_account_store_alert): Remove the (incomplete anyway) + attempts to show UI only in the main context, which used g_idle_add() + and mainloops, because tinymail now guarantees that it only calls these + callbacks in the mainloop with the gdk lock. This makes everything much + simpler. + +2007-08-01 Murray Cumming + + * src/modest-tny-account-store.c: (modest_tny_account_store_alert): + Handle TNY_ACCOUNT_ERROR_TRY_CONNECT_SERVICE_UNAVAILABLE in the same + way as TNY_ACCOUNT_ERROR_TRY_CONNECT_HOST_LOOKUP_FAILED, showing an + error dialog, instead of ignoring it. + +2007-08-01 Murray Cumming + + * src/maemo/modest-msg-view-window.c: + (modest_msg_view_window_get_header), + (modest_msg_view_window_last_message_selected): + Added comments to explain the use of priv->header_model. + * src/modest-ui-dimming-rules.c: + (modest_ui_dimming_rules_on_open_msg), + (modest_ui_dimming_rules_on_mark_as_read_msg), + (modest_ui_dimming_rules_on_mark_as_unread_msg), + (modest_ui_dimming_rules_on_remove_attachments), + (_invalid_attach_selected), (_selected_msg_marked_as): + Renamed _marked_as_deleted() to _selected_message_is_marked_as_deleted(), + and changed the parameter to a ModestMainWindow to make it clearer that + it never uses any other kind of window. + Added _message_is_marked_as_deleted() for examining a ModestMsgViewWindow + instead of the selected message. + I notice that much of the dimming code and the ModestMsgViewWindow code + hard-codes the assumption that the viewed message is always selected in + the header view. This does not seem wise or simple. + + (modest_ui_dimming_rules_on_delete_msg): For a ModestMsgViewWindow, + examine the actual message instead of whatever might be selected + in the header view. This stops the delete toolbar button and menu item + from being dimmed when opening a message view the search UI, + partially fixing projects.maemo.org bug NB#63811. + + However, when actually deleting, I now get this warning: + "tny_header_set_flags: This is a header instance for a new message. + Only priority and attachment flags are supported" + +2007-07-30 Johannes Schmid + + * src/modest-ui-actions.c: (modest_ui_actions_on_send): + + Show account wizard if no accounts are defined while sending + (automatic sending after the account wizard finished does not + work because it takes some time until the account manager + synchronizes everything. (projects.maemo.org NB#62792) + +2007-07-30 Murray Cumming + + * src/modest-tny-account-store.c: (on_account_removed), + (on_account_changed): Emit the ACCOUNT_UPDATE signal so that the + account is removed from the View menu. We have TnyAccountStore + and ModestTnyAccountStore signals that seem very similar, but this + seems to work for now. + + * src/maemo/modest-main-window.c: + (on_show_account_action_activated): Prevent dereference + of a NULL if the accoutn does not really exist, though that + should not happen anymore. + + This fixes projects.maemo.org bug NB#64606. + +2007-07-30 Murray Cumming + + * src/modest-ui-actions.c: (run_account_setup_wizard), + (modest_ui_actions_on_accounts): Revert a change that set these + to modal dialogs, freezing the UI when they show secondary dialogs. + This fixed projects.maemo.org bug NB#64519. + +2007-07-27 Murray Cumming + + * src/widgets/modest-header-view-render.c: + (_modest_header_view_compact_header_cell_data): + Some checks and initialization to try to deal with a crash, + probably ineffective. + +2007-07-27 Murray Cumming + + * src/maemo/modest-maemo-utils.c: + (modest_maemo_utils_get_supported_secure_authentication_methods): + Make sure that we have a connection, asking the user for one + if necessary. + * src/maemo/modest-main-window.c: (modest_main_window_on_show): + Check for a connection before showing the wizard, because + the wizard needs a connection to check for server capabilities. + +2007-07-27 Murray Cumming + + * src/maemo/modest-account-view-window.c: + (on_new_button_clicked): Remember the wizard dialog instance, + so we can just present it again if necessary. This prevents + multiple windows from appearing if you click again quickly on the + New button before the dialog appears, fixing projects.maemo.org + bug NB#64169. + +2007-07-27 Murray Cumming + + * src/maemo/modest-main-window.c: (modest_main_window_on_show): + Offer a connection dialog if there is no connection when + starting modest. This should fix projects.maemo.org bug NB#61134. + +2007-07-27 Murray Cumming + + * src/maemo/modest-msg-edit-window.c: (replace_with_attachments): + Reverted my last commit. I was able to fix the build by doing + apt-get install wpeditor0 (replacing other wpeditor packages) and + an explicit apt-get install wpeditor-dev to upgrade the -dev + package. + +2007-07-27 Murray Cumming + + * src/maemo/modest-msg-edit-window.c: (replace_with_attachments): + Commented out the use of wp_text_buffer_replace_image() + because it does not exist, to break the build. Added a TODO for it. + +2007-07-26 Murray Cumming + + * src/modest-tny-account-store.c: (recreate_all_accounts): + Recreate them even if they were NULL before. I guess something + else was already creating them before, or this would never + have worked. + (modest_tny_account_store_get_server_account): Make sure that + the tny accounts have been created before trying to find one. + This allows libmodest_dbus_client_compose_mail() to work + when the UI is not yet visible. + This is probably useful in other cases too. + + (get_password): When the password is wrong after it is entered + in the protected password dialog, show an info banner (in an + idle handler) before showing the protected password dialog + again. + +2007-07-26 Murray Cumming + + * src/modest-ui-actions.h: + * src/modest-ui-actions.c: Added + modest_do_refresh_current_folder() containing some code from + modest_ui_actions_on_send_receive(). + * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive): + Call modest_do_refresh_current_folder() before refreshing the + requested account, as in modest_ui_actions_on_send_receive(). + This is strange, but seems to be necessary to show new mails. + Now new emails are finally visible in the UI when downloaded + via the automatic update interval, fixing bug NB#57458. + This also works because bug NB#57458 has been fixed somehow. + +2007-07-26 Murray Cumming + + * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter): + printf more details when we get unhandled D-Bus methods, because + it is interesting. + + * src/modest-mail-operation.c: (update_account_thread): + Comment out the tny_camel_pop_store_account_reconnect(), because this + is apparently no longer needed, and it did not work before anyway. + See the comment in the code. + + * src/modest-search.c: (modest_search_folder): Ignore deleted emails, + by checking the header flags. This fixes projects.maemo.org bug + NB#64225. + +2007-07-25 Murray Cumming + + * src/maemo/modest-maemo-utils.h: + * src/maemo/modest-maemo-utils.c: Added + modest_maemo_show_information_note_in_main_context_and_forget(). + * src/modest-tny-account-store.c: (modest_tny_account_store_alert): + Use the new function to show simple error dialogs in the main + context, though question dialogs are still in the current context, + which is unfortunately usually not the main context. This should + fix some hangs. + +2007-07-25 Murray Cumming + + * src/modest-tny-account-store.c: (get_password): + Never save the entered username and password in gconf, + because the UI spec says we should not. This helps + slightly with projects.maemo.org bug NB#63671. + +2007-07-25 Murray Cumming + + * src/widgets/modest-msg-edit-window.h: + * src/maemo/modest-msg-edit-window.c: (create_stream_for_uri): + Moved some code here to make it simpler. + (modest_msg_edit_window_attach_file_one): Renamed from + modest_msg_edit_window_attach_file_interactive(). + (modest_msg_edit_window_offer_attach_file): Renamed from + modest_msg_edit_window_attach_file() and used + modest_msg_edit_window_attach_file_one() instead of + copy/pasting the code. The old code for one was not using + GnomeVFS. This allows use of smb:// URLs when using send-as + from external applications, fixing bug NB#63741. + + (modest_msg_edit_window_insert_image), + (modest_msg_edit_window_add_attachment_clicked): + * src/modest-ui-actions.c: (modest_ui_actions_on_attach_file): + * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail): + Adapted to the new function names. + +2007-07-25 Murray Cumming + + (modest_platform_set_update_interval): Set the alarm recurrence + fields so that auto-update does not just happen the first time. + This should have fixed projects.maemo.org bug NB#63938. + + When this happens you can see a printf when the D-Bus method is + called: + GLIB DEBUG default - debug: modest_dbus_req_handler: method received: SendReceive + + However, I do not actually seem to get new POP messages even when + clicking the refresh button manually. A restart gets them. + This might be a problem in today's tinymail only. + +2007-07-24 Murray Cumming + + * src/maemo/modest-maemo-global-settings-dialog.c: + (current_connection): + Avoid a crash (probably only in scratchbox) when strcmp()ing a + NULL when closing the dialog. + +2007-07-24 Murray Cumming + + * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message): + Remove the hacky send/receive that didn't work, and instead + refilter the treemodel to make the deleted email really vanish from + the UI (though the delete-from-menu code does has commented out + the code that does that). This fixes projects.maemo.org bug + NB#62859. + +2007-07-24 Murray Cumming + + * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message): + Try a couple of tricks to force the treeview to update ( + poke the folder, and do a send/receive refresh), but the deleted + email still appears with a strike-through instead of really being + removed. + +2007-07-23 Murray Cumming + + * src/dbus_api/modest-dbus-callbacks.c: + (add_single_folder_to_list): Ignore TnyMergeFolder folders, + because their ID is not human-readable (see the comment about + improvements needed to the osso-email-interface API) and + TnyMergeFolder::get_id_func() currently crashes with DBC enabled. + +2007-07-23 Murray Cumming + + * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler), + (add_folders_to_list), (on_dbus_method_get_folders), + (modest_dbus_req_filter): + * src/maemo/modest-maemo-utils.c: + (on_camel_account_get_supported_secure_authentication): + * src/maemo/modest-main-window.c: (modest_main_window_set_style), + (on_header_view_focus_in): + * src/modest-email-clipboard.c: (modest_email_clipboard_set_data): + * src/modest-formatter.c: (modest_formatter_create_body_part): + * src/modest-mail-operation.c: (recurse_folders), + (update_account_thread), (get_msgs_full_thread), + (modest_mail_operation_get_msgs_full), + (modest_mail_operation_xfer_msgs): + * src/modest-search.c: (search_mime_part_and_child_parts), + (modest_search_account), (modest_search_all_accounts): + * src/modest-tny-account.c: + (modest_tny_account_get_special_folder), (recurse_folders): + * src/modest-tny-local-folders-account.c: + (modest_tny_local_folders_account_query_passes): + * src/modest-tny-msg.c: (copy_mime_part), + (modest_tny_msg_find_body_part_from_mime_part): + * src/modest-tny-send-queue.c: (modest_tny_send_queue_cancel), + (modest_tny_send_queue_try_to_send): + * src/modest-ui-actions.c: (modest_ui_actions_on_delete_message), + (_modest_ui_actions_open), (download_uncached_messages), + (reply_forward), (modest_ui_actions_on_copy), + (modest_ui_actions_on_details), (has_retrieved_msgs), + (msgs_move_to_confirmation), (open_msg_for_purge_cb), + (do_headers_action): + * src/modest-ui-dimming-rules.c: (_already_opened_msg), + (_selected_msg_marked_as), (_msg_download_completed), + (_selected_msg_sent_in_progress): + * src/widgets/modest-attachments-view.c: + (modest_attachments_view_set_message): + * src/widgets/modest-msg-view.c: (find_cid_image): + * tests/check_folder-transfer.c: (find_folders): + * tests/check_update-account.c: (func): + * tests/dbus_api/test_get_folders.c: (main): + Checked all uses of tny_iterator_get_current(), making sure + that the object is unreferenced (3 or 4 places did not), + and adding checks for NULL. + +2007-07-23 Murray Cumming + + * src/dbus_api/modest-dbus-callbacks.c: + (on_idle_open_default_inbox): Make sure that the application UI is + visible. + * src/maemo/easysetup/modest-easysetup-wizard.c: + (on_entry_invalid_character): Show the word whitespace instead + of (null) in the banner when whitespace was entered. + (show_error): Add a comment that this does not work in + Maemo Bora, though we do not know why. + +2007-07-23 Murray Cumming + + * src/modest-tny-account.c: + (modest_tny_account_get_special_folder): Use an if instead of + an assert for when the parent account name is NULL, because this + might be causing a crash in projects.maemo.org bug 63192. + * src/modest-mail-operation.c: + (modest_mail_operation_send_new_mail_cb), + (modest_mail_operation_remove_folder): unref the folder that is + returned from modest_tny_account_get_special_folder(). + +2007-07-23 Murray Cumming + + * src/modest-ui-actions.c: + (modest_ui_actions_on_password_requested): + Show mail_ib_login_cancelled info banner when the user cancels + the protected password dialog, to fix projects.maemo.org + bug NB#63617. + +2007-07-23 Murray Cumming + + * src/maemo/modest-account-settings-dialog.c: + (create_page_outgoing): Put this page in a GtkScrolledWindow, + matching the UI mock-up in the UI spec, and allowing access + to all widgets even when the on-screen keyboard is active. + +2007-07-23 Murray Cumming Reverted this previous commit from Johannes, because the scrollbars are always visible and because