X-Git-Url: http://git.maemo.org/git/?p=modest;a=blobdiff_plain;f=ChangeLog2;h=e7cbef7250249cd2f2c222bb7b399fd84f94708a;hp=aa7f76abb5a77745bed48cf773fa78fcaf36399e;hb=92bef44ea70f8b4e16c78591bc12f58fac9a7c53;hpb=eed204e3afa5e864f1329725cb5adc8764991a2a diff --git a/ChangeLog2 b/ChangeLog2 index aa7f76a..934bd57 100644 --- a/ChangeLog2 +++ b/ChangeLog2 @@ -1,3 +1,2077 @@ +2007-08-04 Johannes Schmid + + * src/modest-text-utils.c: + Fixed invalid jump due to incorrect string/pointer + operation. + (See https://projects.maemo.org/trac/email/wiki/ValgrindErrors + for details) + +2007-08-01 Murray Cumming + + * src/modest-account-mgr-helpers.h: + * src/modest-account-mgr-helpers.c: + Added modest_account_mgr_get_first_account_name(), + using code from modest_account_mgr_set_first_account_as_default(). + + * src/maemo/modest-main-window.c: Added set_at_least_one_account_visible(). + (account_number_changed): Call set_at_least_one_account_visible() so that + the first account is visible when first added, without the user having to + use the View menu. + I do wonder how this worked before. + +2007-08-01 Murray Cumming + + * src/modest-tny-account-store.c: (show_password_warning_only), + (show_wrong_password), (request_password_and_wait), (get_password), + (modest_tny_account_store_alert): Remove the (incomplete anyway) + attempts to show UI only in the main context, which used g_idle_add() + and mainloops, because tinymail now guarantees that it only calls these + callbacks in the mainloop with the gdk lock. This makes everything much + simpler. + +2007-08-01 Murray Cumming + + * src/modest-tny-account-store.c: (modest_tny_account_store_alert): + Handle TNY_ACCOUNT_ERROR_TRY_CONNECT_SERVICE_UNAVAILABLE in the same + way as TNY_ACCOUNT_ERROR_TRY_CONNECT_HOST_LOOKUP_FAILED, showing an + error dialog, instead of ignoring it. + +2007-08-01 Murray Cumming + + * src/maemo/modest-msg-view-window.c: + (modest_msg_view_window_get_header), + (modest_msg_view_window_last_message_selected): + Added comments to explain the use of priv->header_model. + * src/modest-ui-dimming-rules.c: + (modest_ui_dimming_rules_on_open_msg), + (modest_ui_dimming_rules_on_mark_as_read_msg), + (modest_ui_dimming_rules_on_mark_as_unread_msg), + (modest_ui_dimming_rules_on_remove_attachments), + (_invalid_attach_selected), (_selected_msg_marked_as): + Renamed _marked_as_deleted() to _selected_message_is_marked_as_deleted(), + and changed the parameter to a ModestMainWindow to make it clearer that + it never uses any other kind of window. + Added _message_is_marked_as_deleted() for examining a ModestMsgViewWindow + instead of the selected message. + I notice that much of the dimming code and the ModestMsgViewWindow code + hard-codes the assumption that the viewed message is always selected in + the header view. This does not seem wise or simple. + + (modest_ui_dimming_rules_on_delete_msg): For a ModestMsgViewWindow, + examine the actual message instead of whatever might be selected + in the header view. This stops the delete toolbar button and menu item + from being dimmed when opening a message view the search UI, + partially fixing projects.maemo.org bug NB#63811. + + However, when actually deleting, I now get this warning: + "tny_header_set_flags: This is a header instance for a new message. + Only priority and attachment flags are supported" + +2007-07-30 Johannes Schmid + + * src/modest-ui-actions.c: (modest_ui_actions_on_send): + + Show account wizard if no accounts are defined while sending + (automatic sending after the account wizard finished does not + work because it takes some time until the account manager + synchronizes everything. (projects.maemo.org NB#62792) + +2007-07-30 Murray Cumming + + * src/modest-tny-account-store.c: (on_account_removed), + (on_account_changed): Emit the ACCOUNT_UPDATE signal so that the + account is removed from the View menu. We have TnyAccountStore + and ModestTnyAccountStore signals that seem very similar, but this + seems to work for now. + + * src/maemo/modest-main-window.c: + (on_show_account_action_activated): Prevent dereference + of a NULL if the accoutn does not really exist, though that + should not happen anymore. + + This fixes projects.maemo.org bug NB#64606. + +2007-07-30 Murray Cumming + + * src/modest-ui-actions.c: (run_account_setup_wizard), + (modest_ui_actions_on_accounts): Revert a change that set these + to modal dialogs, freezing the UI when they show secondary dialogs. + This fixed projects.maemo.org bug NB#64519. + +2007-07-27 Murray Cumming + + * src/widgets/modest-header-view-render.c: + (_modest_header_view_compact_header_cell_data): + Some checks and initialization to try to deal with a crash, + probably ineffective. + +2007-07-27 Murray Cumming + + * src/maemo/modest-maemo-utils.c: + (modest_maemo_utils_get_supported_secure_authentication_methods): + Make sure that we have a connection, asking the user for one + if necessary. + * src/maemo/modest-main-window.c: (modest_main_window_on_show): + Check for a connection before showing the wizard, because + the wizard needs a connection to check for server capabilities. + +2007-07-27 Murray Cumming + + * src/maemo/modest-account-view-window.c: + (on_new_button_clicked): Remember the wizard dialog instance, + so we can just present it again if necessary. This prevents + multiple windows from appearing if you click again quickly on the + New button before the dialog appears, fixing projects.maemo.org + bug NB#64169. + +2007-07-27 Murray Cumming + + * src/maemo/modest-main-window.c: (modest_main_window_on_show): + Offer a connection dialog if there is no connection when + starting modest. This should fix projects.maemo.org bug NB#61134. + +2007-07-27 Murray Cumming + + * src/maemo/modest-msg-edit-window.c: (replace_with_attachments): + Reverted my last commit. I was able to fix the build by doing + apt-get install wpeditor0 (replacing other wpeditor packages) and + an explicit apt-get install wpeditor-dev to upgrade the -dev + package. + +2007-07-27 Murray Cumming + + * src/maemo/modest-msg-edit-window.c: (replace_with_attachments): + Commented out the use of wp_text_buffer_replace_image() + because it does not exist, to break the build. Added a TODO for it. + +2007-07-26 Murray Cumming + + * src/modest-tny-account-store.c: (recreate_all_accounts): + Recreate them even if they were NULL before. I guess something + else was already creating them before, or this would never + have worked. + (modest_tny_account_store_get_server_account): Make sure that + the tny accounts have been created before trying to find one. + This allows libmodest_dbus_client_compose_mail() to work + when the UI is not yet visible. + This is probably useful in other cases too. + + (get_password): When the password is wrong after it is entered + in the protected password dialog, show an info banner (in an + idle handler) before showing the protected password dialog + again. + +2007-07-26 Murray Cumming + + * src/modest-ui-actions.h: + * src/modest-ui-actions.c: Added + modest_do_refresh_current_folder() containing some code from + modest_ui_actions_on_send_receive(). + * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive): + Call modest_do_refresh_current_folder() before refreshing the + requested account, as in modest_ui_actions_on_send_receive(). + This is strange, but seems to be necessary to show new mails. + Now new emails are finally visible in the UI when downloaded + via the automatic update interval, fixing bug NB#57458. + This also works because bug NB#57458 has been fixed somehow. + +2007-07-26 Murray Cumming + + * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter): + printf more details when we get unhandled D-Bus methods, because + it is interesting. + + * src/modest-mail-operation.c: (update_account_thread): + Comment out the tny_camel_pop_store_account_reconnect(), because this + is apparently no longer needed, and it did not work before anyway. + See the comment in the code. + + * src/modest-search.c: (modest_search_folder): Ignore deleted emails, + by checking the header flags. This fixes projects.maemo.org bug + NB#64225. + +2007-07-25 Murray Cumming + + * src/maemo/modest-maemo-utils.h: + * src/maemo/modest-maemo-utils.c: Added + modest_maemo_show_information_note_in_main_context_and_forget(). + * src/modest-tny-account-store.c: (modest_tny_account_store_alert): + Use the new function to show simple error dialogs in the main + context, though question dialogs are still in the current context, + which is unfortunately usually not the main context. This should + fix some hangs. + +2007-07-25 Murray Cumming + + * src/modest-tny-account-store.c: (get_password): + Never save the entered username and password in gconf, + because the UI spec says we should not. This helps + slightly with projects.maemo.org bug NB#63671. + +2007-07-25 Murray Cumming + + * src/widgets/modest-msg-edit-window.h: + * src/maemo/modest-msg-edit-window.c: (create_stream_for_uri): + Moved some code here to make it simpler. + (modest_msg_edit_window_attach_file_one): Renamed from + modest_msg_edit_window_attach_file_interactive(). + (modest_msg_edit_window_offer_attach_file): Renamed from + modest_msg_edit_window_attach_file() and used + modest_msg_edit_window_attach_file_one() instead of + copy/pasting the code. The old code for one was not using + GnomeVFS. This allows use of smb:// URLs when using send-as + from external applications, fixing bug NB#63741. + + (modest_msg_edit_window_insert_image), + (modest_msg_edit_window_add_attachment_clicked): + * src/modest-ui-actions.c: (modest_ui_actions_on_attach_file): + * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail): + Adapted to the new function names. + +2007-07-25 Murray Cumming + + (modest_platform_set_update_interval): Set the alarm recurrence + fields so that auto-update does not just happen the first time. + This should have fixed projects.maemo.org bug NB#63938. + + When this happens you can see a printf when the D-Bus method is + called: + GLIB DEBUG default - debug: modest_dbus_req_handler: method received: SendReceive + + However, I do not actually seem to get new POP messages even when + clicking the refresh button manually. A restart gets them. + This might be a problem in today's tinymail only. + +2007-07-24 Murray Cumming + + * src/maemo/modest-maemo-global-settings-dialog.c: + (current_connection): + Avoid a crash (probably only in scratchbox) when strcmp()ing a + NULL when closing the dialog. + +2007-07-24 Murray Cumming + + * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message): + Remove the hacky send/receive that didn't work, and instead + refilter the treemodel to make the deleted email really vanish from + the UI (though the delete-from-menu code does has commented out + the code that does that). This fixes projects.maemo.org bug + NB#62859. + +2007-07-24 Murray Cumming + + * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message): + Try a couple of tricks to force the treeview to update ( + poke the folder, and do a send/receive refresh), but the deleted + email still appears with a strike-through instead of really being + removed. + +2007-07-23 Murray Cumming + + * src/dbus_api/modest-dbus-callbacks.c: + (add_single_folder_to_list): Ignore TnyMergeFolder folders, + because their ID is not human-readable (see the comment about + improvements needed to the osso-email-interface API) and + TnyMergeFolder::get_id_func() currently crashes with DBC enabled. + +2007-07-23 Murray Cumming + + * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler), + (add_folders_to_list), (on_dbus_method_get_folders), + (modest_dbus_req_filter): + * src/maemo/modest-maemo-utils.c: + (on_camel_account_get_supported_secure_authentication): + * src/maemo/modest-main-window.c: (modest_main_window_set_style), + (on_header_view_focus_in): + * src/modest-email-clipboard.c: (modest_email_clipboard_set_data): + * src/modest-formatter.c: (modest_formatter_create_body_part): + * src/modest-mail-operation.c: (recurse_folders), + (update_account_thread), (get_msgs_full_thread), + (modest_mail_operation_get_msgs_full), + (modest_mail_operation_xfer_msgs): + * src/modest-search.c: (search_mime_part_and_child_parts), + (modest_search_account), (modest_search_all_accounts): + * src/modest-tny-account.c: + (modest_tny_account_get_special_folder), (recurse_folders): + * src/modest-tny-local-folders-account.c: + (modest_tny_local_folders_account_query_passes): + * src/modest-tny-msg.c: (copy_mime_part), + (modest_tny_msg_find_body_part_from_mime_part): + * src/modest-tny-send-queue.c: (modest_tny_send_queue_cancel), + (modest_tny_send_queue_try_to_send): + * src/modest-ui-actions.c: (modest_ui_actions_on_delete_message), + (_modest_ui_actions_open), (download_uncached_messages), + (reply_forward), (modest_ui_actions_on_copy), + (modest_ui_actions_on_details), (has_retrieved_msgs), + (msgs_move_to_confirmation), (open_msg_for_purge_cb), + (do_headers_action): + * src/modest-ui-dimming-rules.c: (_already_opened_msg), + (_selected_msg_marked_as), (_msg_download_completed), + (_selected_msg_sent_in_progress): + * src/widgets/modest-attachments-view.c: + (modest_attachments_view_set_message): + * src/widgets/modest-msg-view.c: (find_cid_image): + * tests/check_folder-transfer.c: (find_folders): + * tests/check_update-account.c: (func): + * tests/dbus_api/test_get_folders.c: (main): + Checked all uses of tny_iterator_get_current(), making sure + that the object is unreferenced (3 or 4 places did not), + and adding checks for NULL. + +2007-07-23 Murray Cumming + + * src/dbus_api/modest-dbus-callbacks.c: + (on_idle_open_default_inbox): Make sure that the application UI is + visible. + * src/maemo/easysetup/modest-easysetup-wizard.c: + (on_entry_invalid_character): Show the word whitespace instead + of (null) in the banner when whitespace was entered. + (show_error): Add a comment that this does not work in + Maemo Bora, though we do not know why. + +2007-07-23 Murray Cumming + + * src/modest-tny-account.c: + (modest_tny_account_get_special_folder): Use an if instead of + an assert for when the parent account name is NULL, because this + might be causing a crash in projects.maemo.org bug 63192. + * src/modest-mail-operation.c: + (modest_mail_operation_send_new_mail_cb), + (modest_mail_operation_remove_folder): unref the folder that is + returned from modest_tny_account_get_special_folder(). + +2007-07-23 Murray Cumming + + * src/modest-ui-actions.c: + (modest_ui_actions_on_password_requested): + Show mail_ib_login_cancelled info banner when the user cancels + the protected password dialog, to fix projects.maemo.org + bug NB#63617. + +2007-07-23 Murray Cumming + + * src/maemo/modest-account-settings-dialog.c: + (create_page_outgoing): Put this page in a GtkScrolledWindow, + matching the UI mock-up in the UI spec, and allowing access + to all widgets even when the on-screen keyboard is active. + +2007-07-23 Murray Cumming + + Reverted this previous commit from Johannes, + because the scrollbars are always visible and because + I think we only need it on onepage of the account + settings, not the account wizard. + (I wrote the wrong instructions in the bug.) + + * src/maemo/easysetup/modest-easysetup-wizard.c: + Added scrollbars to account wizard dialog. + Fixed projects.maemo.org NB #62744 + +2007-07-22 Johannes Schmid + + * src/maemo/easysetup/modest-easysetup-wizard.c: + (create_page_user_details): + Use auto-cap for name (projects.maemo.org NB#63716) + * src/widgets/modest-account-view.c: (on_account_busy_changed): + +2007-07-22 Armin Burgmeier + + * src/maemo/modest-ui-actions.c: Use current account instead of + default account for creating viewer windows, so that the viewer + window knows to which account the viewed message belongs. + + * src/maemo/modest-msg-view-window.c: Destroy the window when the + corresponding account is deleted. This fixes projects.maemo.org bug + NB#62936. + +2007-07-18 Armin Burgmeier + + * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let + the dialog close after entering an invalid port number and clicking + OK. This fixes projects.maemo.org bug NB#63602. + +2007-07-18 Armin Burgmeier + + * src/modest-tny-account-store.c: + (get_server_accounts): Set parent modest account name for each + connection-specific transport account so that special folders of such + an account can be looked up. This fixes a crash when changing account + settings. This might also be related to projects.maemo.org bug + NB#63594. + +2007-07-16 Armin Burgmeier + + * src/modest-ui-actions.c: Added a button to create a folder to the + move-to dialog. This fixes projects.maemo.org bug NB#. + +2007-07-16 Johannes Schmid + + * src/maemo/easysetup/modest-easysetup-wizard.c: + Added scrollbars to account wizard dialog. + Fixed projects.maemo.org NB #62744 + +2007-07-16 Murray Cumming + + * src/widgets/modest-msg-view.h: + * src/widgets/modest-msg-view.c: + Added modest_msg_view_get_message_is_empty() but this needs + to be implemented. + * src/maemo/modest-msg-edit-window.c: (message_is_empty): + Check if there is any text in the message yet. + But this needs to be implemented properly. + (modest_msg_edit_window_toggle_find_toolbar): + * src/maemo/modest-msg-view-window.c: + (modest_msg_view_window_toggle_find_toolbar): + Show a banner warning if there is no text to search, when + trying to start a search. This partially fixes + projects.maemo.org bug NB#62350. + +2007-07-13 Murray Cumming + + * src/modest-mail-operation.c: (update_account_thread): + Initialized num_new_headers to fix the build. + +2007-07-13 Murray Cumming + + * src/modest-account-mgr.c: (modest_account_mgr_account_names): + Ignore modest accounts whose server accounts don't exist in gconf. + This prevents us trying to create TnyAccount instances for those + server accounts when the server account has been removed from gconf, + but the parent modest account has not yet been removed from modest. + I don't know why this is only noticeable now. It was probably just + a harmeless g_warning() anyway. + +2007-07-13 Murray Cumming + + * src/modest-ui-dimming-rules.c: (_selected_folder_is_root): + Fix my previous commit, to avoid unrefing a NULL TnyFolderStore. + +2007-07-12 Armin Burgmeier + + * src/maemo/modest-main-window.c: Make default account appear bold + in view, tools/send & receive and toolbar/send & receive SCM menus. + This fixes projects.maemo.org bug NB#59010. + +2007-07-12 Murray Cumming + + * src/modest-ui-dimming-rules.c: (_selected_folder_is_root): + Add a short-cut, by checking if the folder store is an account. + This ensures that the Sort menu item and toolbar is dimmed for + the local-folders account root item, fixing + projects.maemo.org bug NB#62545. + +2007-07-12 Murray Cumming + + * src/modest-tny-account-store.c: (get_password): + Show the password dialog (via the signal) only in the mainloop, via + an idle handler that we wait for. This could theoretically prevent + hangs, though I worry that it could introduce some too. + +2007-07-12 Murray Cumming + + * src/gnome/modest-platform.c: (modest_platform_connect_and_wait): + * src/maemo/modest-platform.c: + (modest_platform_connect_and_wait): + Take a TnyAccount* parameter and try to set it to online + (a TnyCamel-only API), because tinymail sets accounts to offline + when the user cancels a password dialog, and doesn't ask again until + it has been set to online. + However, this is commented out because it causes a hang now. + + (modest_platform_connect_and_wait_if_network_account): + * src/modest-mail-operation.c: + (modest_mail_operation_update_account): + * src/modest-platform.h: + * src/modest-ui-actions.c: (_modest_ui_actions_open), + (download_uncached_messages), (modest_ui_actions_on_send): Adapted. + +2007-07-12 Armin Burgmeier + + * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error. + + * src/modest-mail-operation.c: + * src/modest-ui-actions.c: Check for already existing folder before + querying the server, show error message from camel if the request + still fails. This fixes projects.maemo.org bug NB#58701. + +2007-07-12 Murray Cumming + + * src/modest-tny-account-store.h: + * src/modest-tny-account-store.c: + Added modest_tny_account_store_forget_password_in_memory(), + (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory() + when creating a new account, so that new passwords will be used, instead of + us thinking that it's a second request as a result of a failed password again. + +2007-07-12 Murray Cumming + + * src/dbus_api/modest-dbus-callbacks.c: + (on_idle_open_message): If the message is in drafts then open it + in an edit window instead of a view window. This fixes + projects.maemo.org bug NB#63005. + +2007-07-12 Murray Cumming + + * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message): + Avoided a harmless g_warning(). + +2007-07-12 Murray Cumming + + * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message), + Pass the modest account name, not the TnyAccount display name to + modest_msg_view_window_new() so that the reply feature works, + fixing projects.maemo.org bug NB#62892. + + * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new), + (modest_msg_view_window_new_with_header_model): + * src/maemo/modest-msg-view-window.c: + (modest_msg_view_window_new_with_header_model), + (modest_msg_view_window_new): + * src/modest-ui-actions.c: (reply_forward): + * src/widgets/modest-msg-view-window.h: + * src/widgets/modest-window.c: (modest_window_set_active_account): + Rename an account parameter to modest_account_name to make this clearer. + +2007-07-11 Murray Cumming + + * src/modest-ui-actions.h: + * src/modest-ui-actions.c: (headers_action_delete): Moved some code into + modest_do_message_delete(). + * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message): + Call modest_do_message_delete(), hoping that this would cause messages + to be really deleted from search instead of just marked with strike through. + Does not seem to help. + +2007-07-11 Armin Burgmeier + + * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set + priv->reselect to FALSE prior to calling + modest_folder_view_select_first_inbox_or_local() to prevent endless + recursion and thus a crash on startup. + +2007-07-11 Armin Burgmeier + + * src/maemo/modest-account-settings-dialog.h: Include + to fix the build (at least for me). + + * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog): + Use "New FolderN" as default suggested name if "New folder" already + exists, with N being the first free number, though never exceed "New + folder99" in which case we just fall back to "New Folder" even though + it already exists. This fixes projects.maemo.org bug NB#58663. + +2007-07-11 Murray Cumming + + * src/maemo/modest-account-view-window.c: (on_new_button_clicked): + Do not use gtk_dialog_run() to avoid modality hang problems. This fixes + projects.maemo.org bug NB#62778. + +2007-07-11 Murray Cumming + + * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account): + Ignore the wrong (for now) secure-smtp setting in the presets - + just default to requiring secure authentication for SMTP, because + that is most common. + +2007-07-11 Johannes Schmid + + * src/widgets/modest-folder-view.c: (filter_row) + Do not show drafts folder (see UI specs) + +2007-07-11 Johannes Schmid + + * src/modest-ui-actions.c: + Remove call to show_non_move_folders(TRUE) which was moved to a wrong + place and also not necessary. + + * src/widgets/modest-folder-view.c: (filter_row) + Guess folder type and hide Sent & Outbox if necessary. + Fixed project.maemo.org NB#57328 + +2007-07-11 Murray Cumming + + * src/modest-ui-actions.h: + * src/modest-ui-actions.c: + (modest_ui_actions_on_delete_message): + Move some code into a new + modest_ui_actions_refresh_message_window_after_delete() + function so we can use it from elsewhere. + + * src/dbus_api/modest-dbus-callbacks.c: + (on_idle_delete_message), (on_delete_message): Used an idle + handler, as we do for the other D-Bus method handlers. + Call modest_ui_actions_refresh_message_window_after_delete() + if the deleted message was open in a window. This fixed + projects.maemo.org bug NB#62862. + +2007-07-11 Murray Cumming + + * src/modest-main.c: (main): Only show the UI at the start if + the showui command line option was given. For instance, + run-standalone src/modest showui + Otherwise, we wait for the top_application D-Bus method to + be sent by hildon-desktop when the application is selected + from the menu. + This allows us to run without a UI when osso-global-search + uses our D-Bus methods. + +2007-07-11 Murray Cumming + + * src/dbus_api/modest-dbus-api.h: Added a define for a + top-application D-Bus method. + * src/dbus_api/modest-dbus-callbacks.c: + (on_top_application), + (modest_dbus_req_handler): Handle the top-application D-Bus + method, which might be an undocumented D-Bus signal sent by + hildon-desktop when it starts the application from the menu. + But I am not sure and I need to test it on the device, because + my scratchbox does not have the application in the menu now. + This method shows the main window, so that it can be invisible + when started, for instance, just for email searching from + osso-global-search. + + * src/maemo/modest-main-window.c: (restore_settings), + (modest_main_window_new): Do not show the window immediately + upon creation. We show it later. + * src/modest-widget-memory.c: (save_settings_paned): + Try (unsuccessfully) to avoid saving the paned position when + it is not even visible. + (restore_settings_paned): Do not allow a silly paned position. + This seems necessary when not showing the window at first. + + * tests/dbus_api/Makefile.am: + * tests/dbus_api/test_top_application.c: (main): Test for the + new D-Bus method. + +2007-07-10 Murray Cumming + + * src/modest-ui-dimming-rules.c: + (modest_ui_dimming_rules_on_new_msg), + (modest_ui_dimming_rules_on_reply_msg), + (modest_ui_dimming_rules_on_delete_msg), + (modest_ui_dimming_rules_on_details), + (modest_ui_dimming_rules_on_view_window_move_to), + (modest_ui_dimming_rules_on_view_previous), + (modest_ui_dimming_rules_on_view_next), + (_invalid_folder_for_purge): Added checks before + casting the window. This looks like an actual + logic error in _invalid_folder_for_purge(), because it + tries to use a ModestMainWindow as a message window. + +2007-07-10 Murray Cumming + + * src/maemo/modest-account-settings-dialog.c: + (show_error): Use the same implementation as in + modest-easysetup-wizard.c: + (on_entry_invalid_character): The logical ID contains a %s. + Guessed what it should be. + (on_entry_max), (check_data), (on_response): Adapt to + changed show_error(). + (create_page_account_details): Really call + modest_validating_entry_set_func() on the correct widgets. + * src/maemo/easysetup/modest-easysetup-wizard.c: + (on_entry_invalid_character): Fix the logical ID here too. + (create_page_account_details), + (create_page_user_details): + Really call + modest_validating_entry_set_func() on the correct widgets. + + * src/modest-tny-account-store.c: (modest_tny_account_store_alert): + Do not try to use the account if it is NULL. + +2007-07-10 Johannes Schmid + + * src/modest-ui-actions.c: (create_move_to_dialog), + (modest_ui_actions_on_main_window_move_to), + (modest_ui_actions_on_msg_view_window_move_to): + * src/widgets/modest-folder-view.c: (modest_folder_view_init), + (filter_row), (modest_folder_view_show_non_move_folders): + * src/widgets/modest-folder-view.h: + + Hide Sent & Outbox folder in "move to"-dialog. Does not work for + the Sent folder yet as it does not report the correct folder type. + +2007-07-10 Johannes Schmid + + * src/maemo/modest-msg-edit-window.c: (init_window): + Fixed bora build + +2007-07-10 Murray Cumming + + * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error): + Take a parent widget instead of a parent window, and + implement this with hildon_banner_show_information() instead. + Non-Maemo builds can just ifdef that there. + This fixed projects.maemo.org bug NB#62766. + + (on_entry_invalid_character): Use show_error() again instead + of using hildon directly, and use the _CS() macro to use the correct + translation domain. + (create_account), (check_for_supported_auth_methods), (on_entry_max): + Pass a widget instead od a window to show_error(). + +2007-07-10 Murray Cumming + + * src/modest-tny-account-store.c: (modest_tny_account_store_alert): + Adapt to the changed tinymail API, using the new TnyAccount* parameter. + This allows us to show the server name in the error message, fixing + projects.maemo.org bug NB#62904. + Also, use the appropriate logical ID message for the account protocol. + +2007-07-10 Murray Cumming + + * src/modest-tny-account-store.c: (on_idle_wrong_password): + A compilation fix, though the build wasn't broken for me. + +2007-07-09 Murray Cumming + + * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive): + Do not try to unref a NULL folder store, to avoid a runtime warning. + This seems to happen sometimes when changing accounts settings. + +2007-07-09 Murray Cumming + + * src/modest-tny-account-store.c: + (modest_tny_account_store_instance_init), + (modest_tny_account_store_finalize), + (on_account_settings_hide), (on_idle_wrong_password): + Use a GHashTable to ensure that we only show one account settings + dialog per modest account. This avoids us having a dialog open for + both the store and transport accounts, or due to repeated get_password() + calls that shouldn't happen anyway. + +2007-07-09 Murray Cumming + + * src/maemo/modest-maemo-utils.c: (on_hide), + (modest_maemo_show_dialog_and_forget): Handle the response, because + the window is not even hidden by default. + + * src/maemo/modest-account-view-window.c: (on_edit_button_clicked): + * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): + Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run() + which seems to prevent some modality problems. + + * src/maemo/modest-main-window.c: (on_sendqueue_error_happened): + Ignore user cancellation errors. + + * src/modest-account-mgr-helpers.h: + * src/modest-account-mgr-helpers.c: + Added modest_server_account_get_password() and + modest_server_account_get_has_password() to avoid direct use of + conf enums. + + * src/maemo/modest-account-settings-dialog.h: + * src/maemo/modest-account-settings-dialog.c: + (modest_account_settings_dialog_init): Store the notebook so we can + use it later. + Added modest_account_settings_dialog_switch_to_user_info(). + + * src/modest-tny-account-store.c: + (get_password): When the password in the account settings is wrong (we think), + show the relevant page of the account settings dialog, in the mainloop. + However, we currently get many of these at once because cancel does not + seem to cancel. + (forget_password): Do not forget the password + from the account settings, because this causes side-effects when + tinymail seems to call it at strange time, maybe because of how we + are cancelling get_password(). + (modest_tny_account_store_alert): Ignore user cancellations. + +2007-07-09 Murray Cumming + + * src/maemo/modest-maemo-utils.h: + * src/maemo/modest-maemo-utils.c: + Added modest_maemo_show_information_note_and_forget() for use instead of + gtk_dialog_run() when the response is not needed, to avoid an extra + mainloop which could cause a hang. + + * src/maemo/modest-main-window.c: (on_sendqueue_error_happened): + Use the logical IDs for the error message, though they are not + specific enough. Note that I used modest_maemo_show_information_note_and_forget() + because gtk_dialog_run() caused a hang here (the window did not close). + This fixes projects.maemo.org bug NB#62646. + +2007-07-09 Murray Cumming + + * src/modest-account-mgr-helpers.h: + * src/modest-account-mgr-helpers.c: + Added modest_account_mgr_get_store_protocol(). + + * src/maemo/modest-account-view-window.c: + (on_delete_button_clicked): Show different warning text depending on + the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead + of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug + NB#59037. + +2007-07-09 Murray Cumming + + * src/maemo/modest-msg-edit-window.c: + (modest_msg_edit_window_attach_file): Set the file chooser dialog title + as per the UI spec. This fixes proejcts.maemo.org bug NB#59056. + +2007-07-07 Armin Burgmeier + + * src/maemo/easysetup/modest-easysetup-wizard.c: Translate + ckdg_ib_maximum_characters_reached from correct package. + + * src/modest-ui-actions.c: Show an error message when a folder could + not be created. Tinymail does not give us specific error codes about + what has gone wrong, so we assume that a folder with that name + already exists, though there might be other reasons. + +2007-07-06 Murray Cumming + + * src/modest-tny-account-store.c: (modest_tny_account_store_alert): + Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to + give a more exact error message that can be partly translated. + +2007-07-05 Murray Cumming + + * src/maemo/modest-address-book.c: + (select_email_addrs_for_contact): Specify a default window size for the + select-email-address dialog, so that it is probably big enough for the + title. This should fix projects.maemo.org bug NB#62277. + +2007-07-05 Murray Cumming + + * src/maemo/easysetup/modest-easysetup-wizard.c: + (create_page_complete_easysetup): Use + gtk_widget_set_size() request to ensure that the text wraps + even in osso 1.1. + +2007-07-05 Johannes Schmid + + * src/maemo/easysetup/modest-easysetup-wizard.c: + (on_entry_invalid_character), (create_page_account_details), + (create_page_user_details): + Use new API of ModestValidatingEntry. But for some reason the banner is + not shown. I will have to investigate that further. + + * src/widgets/modest-validating-entry.c: (on_insert_text), + (modest_validating_entry_set_func): + * src/widgets/modest-validating-entry.h: + Added a new callback function to be able to react to prevented + characters whitespaces to e.g show a banner. + +2007-07-05 Armin Burgmeier + + * src/maemo/modest-account-settings-dialog.c: Use the notify::value + notification of HildonNumberEditor instead of remembering the port + number. Thanks to Johannes for pointing this out. + +2007-07-05 Johannes Schmid + + * src/maemo/easysetup/modest-easysetup-wizard.c: + Check if there are any user changes before showing a confirmation + dialog (projects.maemo.org NB#60946) + +2007-07-05 Armin Burgmeier + + * src/maemo/modest-account-settings-dialog.c: Remember custom port + number at the beginning of the dialog and set the modified flag at the + end if the port number has changed. This is necessary because + HildonNumberEditor does not support notification when the value has + changed. + +2007-07-05 Murray Cumming + + * src/modest-ui-actions.c: + (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs + a connection before asking anything else. Correct the check for the destination + folder so that it succeeds when online. + This fixed projects.maemo.org bug NB#61645. + +2007-07-05 Murray Cumming + + * src/modest-ui-actions.c: (modest_ui_actions_on_send): + Call modest_platform_connect_and_wait() to ask for a connection if necessary, + to fix projects.maemo.org bug NB#62439. + +2007-07-05 Murray Cumming + + * src/modest-tny-account.c: (on_connection_status_changed): + Really do not use tny_device_force_offline() here. See the previous comment. + +2007-07-04 Murray Cumming + + * src/modest-tny-account.c: (on_connection_status_changed): + Do not use tny_device_force_offline() when tinymail says that something + went wrong with the connection. It seems to report this unnecessarily. + +2007-07-04 Murray Cumming + + * src/maemo/modest-connection-specific-smtp-window.c: + (modest_connection_specific_smtp_window_init): + Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars() + does not seem to have any effect in osso 1.1 (though it works in + Maemo Bora). This fixes bug projects.maemo.org NB#59212. + +2007-07-04 Johannes Schmid + + * src/maemo/modest-connection-specific-smtp-window.c: + Fix UI specification problems with projects.meamo.org NB#60479 + +2007-07-04 Murray Cumming + + * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a + clue when this has failed, because the error dialog is not always shown + (at least in earlier version). + + (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual + GError message, because the generic error dialog is not helpful. + I am getting + 'This message is not currently available (can't let a new connection go online)' + when trying to open an IMAP message. + + (_modest_ui_actions_open): Offer a connection when some messages would + have to be downloaded and we are offline. + +2007-07-04 Johannes Schmid + + * src/widgets/modest-folder-view.c: + Don't check for MERGE type anymore as we use the correct type + now. + NOTE: For the last two changes you need to update your tinymail copy + because of API changes! + +2007-07-04 Johannes Schmid + + * src/modest-tny-local-folders-account.c: + Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX + (see projects.maemo.org NB#61580) + +2007-07-04 Murray Cumming + + * src/modest-tny-account.c: (on_connection_status_changed): + Commented out the call to modest_platform_connect_and_wait() because this + seems to always hang, and I would like to know if this is the only thing + that causes a hang when showing the connection dialog. + It is not very useful anyway. + +2007-07-04 Murray Cumming + + * src/maemo/modest-msg-view-window.c: + (modest_msg_view_window_select_next_message): + + * src/modest-platform.h: + * src/maemo/modest-platform.c: + Added modest_platform_connect_and_wait(), which calls + tny_maemo_conic_device_connect() always in the main thread, by calling it + in an idle handler and waiting for the idle handler to run. It should be + in the main thread because it uses GTK+ UI code. It just returns TRUE + if the device is already online. + + There is some nasty code to ensure that subsequent calls to + modest_platform_connect_and_wait() just wait for the first one to finish, + by checking repeatedly in another idle handler. This is necessary, + because other threads (or even the main thread, via another idle handler) + can call modest_platform_connect_and_wait() while + modest_platform_connect_and_wait() is running. + + (modest_platform_connect_and_wait_if_network_account), + (modest_platform_connect_and_wait_if_network_folderstore): + Convenience functions that calls modest_platform_connect_and_wait() if + the account or folder might want network access. + + * src/modest-mail-operation.c: + (modest_mail_operation_update_account): + * src/modest-ui-actions.c: (download_uncached_messages), + (modest_ui_actions_on_rename_folder), (delete_folder), + (modest_ui_actions_on_main_window_move_to), + (modest_ui_actions_on_msg_view_window_move_to): + * src/widgets/modest-folder-view.c: + (drag_and_drop_from_folder_view): + Offer a connection if we are offline. + + * src/modest-tny-account.c: (on_connection_status_changed): + Document this as only handling errors during network operations in progress, + and replace the idle code with a simple call to + modest_platform_connect_and_wait(), which does this instead. + +2007-07-03 Murray Cumming + + * src/modest-tny-account.c: + (modest_tny_account_get_special_folder): (util_on_idle), + Handle the GError so we can see when tny_folder_store_get_folders() + fails, as it currently does while something else is connecting. + + Added util_run_in_main_thread_and_wait() + which uses an idlen handler and mainloop to ensure that the function + is called in the main thread. + (on_connection_status_changed): Use util_run_in_main_thread_and_wait() + to make sure that we call attempt the connection in the mainloop only, + which might solve some hangs. + +2007-07-03 Murray Cumming + + (modest_tny_account_store_get_tny_account_by): Do not allow accounts to + be found by their display name. This is never useful. + * src/modest-tny-account-store.c: (on_account_removed): Find the account + by its ID, instead of trying to use its ID as its display name. + + * src/modest-tny-account-store.h: + * src/modest-tny-account.c: + (modest_tny_account_get_special_folder): Add a g_warning() when + tny_folder_store_get_folders() returns an empty list for the maildir. + + * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox): + Add a g_warning() when this returns NULL, because that it not allowed + by tinymail. + +2007-07-02 Armin Burgmeier + + * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation + note when trying to cancel the wizard. This fixes projects.maemo.org + bug NB#60946. + +2007-07-02 Murray Cumming + + * src/modest-tny-account.h: + * src/modest-tny-account.c: + (modest_tny_account_new_from_server_account), + (modest_tny_account_new_from_server_account_name), + (modest_tny_account_new_from_account): Added a TnyCamelSession parameter, + because this must now be set before setting the proto. This is usd in + modest_tny_account_new_from_server_account(). It avoids a (maybe harmless) + warning in camel_session_get_service() caused by + tny_camel_transport_account_prepare(). + + * src/modest-tny-account-store.c: (get_server_accounts): Pass the new + session parameter. + +2007-06-30 Johannes Schmid + + * src/maemo/modest-connection-specific-smtp-edit-window.c: + (on_value_changed), + (modest_connection_specific_smtp_edit_window_init): + + Fixed project.maemo.org bug NB#60479 by using "notify::value" instead + of "changed" for now + +2007-06-29 Murray Cumming + + * src/modest-tny-account.c: + (modest_tny_account_new_from_server_account): + Handle the TnyAccount::"connection-status-changed" signal, which tinymail + now uses to request a connection when it needs one, and which it uses + to tell us that something is wrong with the connection, so we can force + the accounts offline to prevent further problems. + + * src/modest-defs.h: + * src/modest-init.c: (init_default_settings): + * src/modest-mail-operation.c: + (modest_mail_operation_update_account): + * src/modest-main.c: (on_show): Do not try to connect explicitly on startup. + This should not be necessary anymore. Do not set the conf key that + determined this (it was always TRUE and not set anywhere else). + + * src/modest-ui-actions.h: Remove unused and unimplemented + modest_ui_actions_on_online_toggle_toggled(). + +2007-06-29 Murray Cumming + + * src/modest-mail-operation.c: Fixed a crash when canceling a mail + receive operation. + +2007-06-27 Murray Cumming + + * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting + for supported secure authentication methods from server by + gtk_dialog_run(), saving CPU time and a potential race condition. + +2007-06-26 Armin Burgmeier + + * src/maemo/modest-maemo-utils.h: + * src/maemo/modest-maemo-utils.c: Added a + ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as + only error code to tell the calling code when the user canceled the + operation. + + * src/maemo/modest-account-settings-dialog.h: + * src/maemo/modest-account-settings-dialog.c: + * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error + message if the retrieval of secure authentication methods was canceled + by the user. Perform the check before saving anything to configuration + to not end up with half-committed configuration changes, do not show + a "Saving to configuration failed" note when authentication methods + could not be retrieved. + + * src/maemo/modest-main-window.c: Fixed a crash on startup when built + with old hildon. + +2007-06-26 Murray Cumming + + * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list): + Only return the first level of folders under accounts, because the + osso-global-search UI spec doesn't want the rest. + This fixed projects.maemo.org bug NB#61811. + +2007-06-26 Murray Cumming + + * src/modest-tny-account-store.c: + * src/modest-tny-account-store.h: + Added modest_tny_account_is_memory_card_account(). + * src/maemo/modest-main-window.c: (create_details_widget): + Show the same information items for the memory card as we show for the + local-folders, to fix projects.maemo.org bug NB#59307. + +2007-06-26 Murray Cumming + + * src/modest-tny-account-store.c: (get_password): + Added some checks for NULL to maybe prevent crashes, though I think + it was Philip's last commit that actually prevented the crash here + when creating a first new account. + But the new account is still not usable (no messages are shown) + until a restart of the application. + +2007-06-26 Murray Cumming + + * src/maemo/modest-maemo-global-settings-dialog.c: + (idle_select_default_focus): + * src/modest-mail-operation.c: (idle_notify_progress), + (idle_notify_progress_once), (idle_notify_update_account_queue), + (set_last_updated_idle), (update_account_thread), + (notify_get_msgs_full), (get_msgs_full_destroyer), + (get_msgs_full_thread): + * src/widgets/modest-attachment-view.c: (get_size_idle_func): + * src/widgets/modest-header-view.c: + (idle_notify_headers_count_changed_destroy), + (idle_notify_headers_count_changed): + Use gdk_threads_enter() and gdk_threads_enter_leave() in + all idle handlers, because some other thread could be blocking + the GDK lock, so that it can do GUI stuff. + +2007-06-26 Murray Cumming + + * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to), + (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message), + (on_idle_send_receive), (on_idle_open_default_inbox): + * src/maemo/modest-msg-edit-window.c: + (modest_msg_edit_window_attach_file_noninteractive): + Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers, + to prevent a hang. I don't quite understand why these are necessary, + beause we should already be in the main loop. I guess something outside + of the main loop is taking the lock. + + * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so + we are really using URIs, and use files that are more likely to exist. + +2007-06-26 Murray Cumming + + * tests/dbus_api/Makefile.am: Fix the build of the tests. This was + necessary because configure.ac now defines different variables. + +2007-06-26 Murray Cumming + + * libmodest-dbus-client/libmodest-dbus-client.c: + * libmodest-dbus-client/libmodest-dbus-client.h: + Removed libmodest_dbus_client_send_mail() because it is not used by anything. + libmodest_dbus_client_compose_mail() is what things actually use. + + * src/dbus_api/modest-dbus-api.h: + * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler): + * tests/dbus_api/Makefile.am: + * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL + D-Bus method. + +2007-06-26 Murray Cumming + + * src/modest-init.c: (modest_init_local_folders): + For memory-card (or other non local-folders) maildir accounts, + always create an Archive folder, so that there is somewhere to put + messages. This should be less confusing, because the user does not need + to guess that the need to create a folder. + +2007-06-25 Johannes Schmid + + * src/maemo/easysetup/modest-wizard-dialog.c: (init): + Fixed icon size by using (50, 50) which is the same as defined by + newer hildon-libs + +2007-06-25 Armin Burgmeier + + * src/widgets/modest-window-mgr.c: + * src/modest-init.c: + * configure.ac: Correctly recognize hildon-notify presence and fixed + the build without it being installed. + +2007-06-25 Murray Cumming + + * libmodest-dbus-client/libmodest-dbus-client.c: + (libmodest_dbus_client_search): Fix the build. Sorry. + * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg), + (reply_forward_cb): Initialize variables to fix the build. + + * src/modest-tny-account-store.c: + (modest_tny_account_store_get_tny_account_by): Fix the account URI + comparison (a silly typo) so that email search results can be opened + when there are more than one account. + +2007-06-25 Murray Cumming + + * libmodest-dbus-client/libmodest-dbus-client.c: + (libmodest_dbus_client_search), + (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes) + instead of 1 second, because the search gets folders and messages from + the server, which can take a long time. When it times out, + osso-global-search will report no results. + + We need to specify whether we should search only cached information + (maybe with a user preference), and the osso-email-search-plugin + API should really be improved to allow that option, and to allow results + to be delivered asynchronously in batches. + +2007-06-25 Murray Cumming + + * src/maemo/easysetup/modest-wizard-dialog.c: (init): + Fix a typo to fix the osso 1.1. build. See the TODO comment though - + GTK_ICON_SIZE_DIALOG is probably the wrong size. + +2007-06-25 Murray Cumming + + * src/modest-search.c: (modest_search_folder): Ignore a seach folder + that is an empty string. D-Bus seems to give us these instead of NULL. + +2007-06-25 Johannes Schmid + + * src/dbus_api/modest-dbus-callbacks.c: + * src/maemo/easysetup/modest-easysetup-wizard.h: + * src/maemo/easysetup/modest-wizard-dialog.c: (init): + * src/maemo/modest-connection-specific-smtp-edit-window.c: + (modest_connection_specific_smtp_edit_window_init): + * src/maemo/modest-maemo-global-settings-dialog.c: + (on_range_error): + * src/maemo/modest-maemo-utils.c: + (modest_maemo_utils_setup_images_filechooser): + * src/maemo/modest-main-window.c: (create_details_widget): + * src/maemo/modest-msg-edit-window.c: + (modest_msg_edit_window_attach_file_noninteractive), + (modest_msg_edit_window_color_button_change), + (modest_msg_edit_window_set_zoom): + * src/modest-mail-operation.c: (update_account_thread): + * src/modest-tny-account-store.c: + * src/modest-tny-account.c: + * src/widgets/modest-global-settings-dialog.c: + * src/widgets/modest-window.h: + + Fixed build on bora! + +2007-06-25 Murray Cumming + + * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search): + * src/modest-search.c: (modest_search_folder), + (modest_search_all_accounts): Actually search only in the specified folder, + doing a simple match on the folder ID. + * src/modest-search.h: Added a folder field to the ModestSearch struct, + and added some documentation. + +2007-06-22 Armin Burgmeier + + * src/maemo/modest-maemo-utils.h: + * src/maemo/modest-maemo-utils.c: Added a GError parameter to + modest_maemo_utils_get_supported_secure_authentication_methods. + + * src/maemo/easysetup/modest-easysetup-wizard.c: + * src/maemo/modest-account-settings-dialog.c: Show correct error if + one occured, not just "Server does not support secure authentication". + +2007-06-22 Murray Cumming + + * src/modest-tny-account-store.c: (get_password): + Restored the call to tny_account_set_user() because Philip seems to have + stopped this from crashing (by not using the freed string). It still does + not work, but now we can test it. + +2007-06-22 Murray Cumming + + * src/maemo/modest-msg-edit-window.c: (init_window): + Comment out use of an uninitialzed GtkScrolledWindow variable, + to fix the build and stop a crash. Yet again. + +2007-06-22 Murray Cumming + + * src/modest-tny-account-store.c: (get_password): + Remove the call to tny_account_set_user() because this actually crashes. + As mentioned in the last commit, it is known to not work anyway. + +2007-06-22 Murray Cumming + + * src/modest-tny-account-store.c: (get_password): + Use tny_account_set_username() to tell tinymail that the username might + have changed too. But tinymail ignores this: see projects.maemo.org + bug #61463. + * src/modest-ui-actions.c: + (modest_ui_actions_on_password_requested): Remove the useless attempt to + reset the connection when changing the username, and improve the comments. + Save the changed username to gconf at least, so it is used when Modest is + restarted. + +2007-06-21 Murray Cumming + + * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list): + Do not use a query, so that we get all folders, including for POP and + local-folders. They work as search criteria too. + This fixes projects.maemo.org bug NB#57740. + +2007-06-21 Murray Cumming + + * src/maemo/modest-platform.c: (modest_platform_on_new_msg): + Comment out the use of hildon_notification_set_sound() because it is + not declared, to fix the build. Warnings are serious, people. + +2007-06-21 Armin Burgmeier + + * src/maemo/modest-maemo-utils.h: + * src/maemo/modest-maemo-utils.c: Added a username parameter to the + modest_maemo_utils_get_supported_secure_authentication_methods() + to query authentication methods for a specific user. This should fix + projects.maemo.org bug NB#61369. + + * src/maemo/easysetup/modest-easysetup-wizard.c: + * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that + function. + +2007-06-21 Murray Cumming + + * libmodest-dbus-client/libmodest-dbus-client.h: + * libmodest-dbus-client/libmodest-dbus-client.c: + (modest_dbus_message_iter_get_search_hit), + (libmodest_dbus_client_search): + Reorganised and commented this. + Removed modest_search_hit_free() from the public API because it + is not needed. + + Added libmodest_dbus_client_get_folders() and + modest_folder_result_list_free(). + + * src/dbus_api/modest-dbus-api.h: + * src/dbus_api/modest-dbus-callbacks.c: + (modest_dbus_req_filter): Commented. Moved most code to + on_dbus_method_search() and added on_dbus_method_get_folders(). + + * src/maemo/modest-platform.c: (modest_platform_init): Commented the use + of the extra D-Bus handler. + + * tests/dbus_api/Makefile.am: + * tests/dbus_api/test_get_folders.c: New test for + libmodest_dbus_client_get_folders(). This seems to return an empty list + at the moment. That could be the same error that causes the message list + to be empty sometimes. + This should help with projects.maemo.org bug NB#57740. + +2007-06-21 Armin Burgmeier + + * src/modest-mail-operation.c: Do not call + modest_mail_operation_queue_cancel_all() in _cancel() but do instead + notify the operation's end after having set the status to CANCELED for + the operation queue to listen on. This fixes a deadlock when there + were mail operations in the queue during its finalization. + + * src/modest-singletons.c: Reordered uninitialization of the account + manager to happen after the mail operation queue was uninitialized + because the mail operation's in the queue might still try to access + the account manager (see modest_mail_operation_notify_end()). This + fixes a potential crash when terminating the application. + +2007-06-21 Murray Cumming + + * src/modest-search.c: + (search_mime_part_and_child_parts): Moved some code here so we + can search recursively in child folders. + (modest_search_folder): Search in the message as a mime part, instead + of just its child mime parts. + (read_chunk), (search_mime_part_ogs): + Check how many bytes were read, to prevent an endless loop. + Searching in message bodies now works. This finishes the fix for + projects.maemo.org bug NB#61007. + +2007-06-20 Murray Cumming + + * src/modest-ui-actions.c: (modest_ui_actions_on_details): + Add a g_warning when the item is not a folder. + + * src/modest-ui-dimming-rules.c: + (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item + when selected item is not a folder (for instance, an account), because + the UI spec only talks about folders. + I am not sure what the UI spec wants, so this might not totally fix + projects.maemo.org bug NB#60794. + +2007-06-20 Murray Cumming + + * src/maemo/easysetup/modest-easysetup-country-combo-box.c: + (load_from_file): Sort the list. The unsorted list would be more noticeable + in non-English locales. + + * src/maemo/modest-msg-edit-window.c: + (modest_msg_edit_window_attach_file): Initialize a variable to avoid a + warning and fix the build. + + * src/maemo/modest-progress-bar-widget.c: + (modest_progress_bar_widget_set_progress): Avoid a division by zero, to + avoid a g_warning, and probably to avoid a crash. + +2007-06-20 Murray Cumming + + * src/modest-search.c: (modest_search_folder): Check for a GError + when calling tny_folder_get_headers(), to show that this is not the cause + of later failure. + +2007-06-20 Murray Cumming + + * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter): + Actually set the body query instead of the subject query. + + * src/modest-search.c: (search_mime_part_ogs), + (search_mime_part_strcmp): Remove extra space from the text/* regex, + which would probably cause it to fail if we got this far. + + (modest_search_folder): Use simple #ifdefs instead of the function pointer, + to simplify the code. + Warn when tny_mime_part_get_parts() returns an empty list, which seems to + be causing search-in-body to fail. + +2007-06-20 Murray Cumming + + * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder + struct item. + * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url): + Better debug message when the folder cannot be found. + This should help with fixing projects.maemo.org bug #61287. + * src/modest-search.c: (add_hit): Do not leak the furl string. + +2007-06-20 Murray Cumming + + * src/modest-ui-actions.c: + (modest_ui_actions_on_folder_selection_changed): + Do not special-case TNY_MERGE_FOLDER here, because + modest_tny_folder_get_account() already does that. This fixes + projects.maemo.org bug NB#60955 (The smtp connections dialog was not + shown when the Outbox was selected). + +2007-06-19 Murray Cumming,,, + + * libmodest-dbus-client/libmodest-dbus-client.c: + (_dbus_iter_get_string_or_null): Initialize the string variable in + case this helps with Dirk's crash. + +2007-06-19 Murray Cumming + + * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail, + though it is not implemented yet (this function is maybe not even used), + to avoid breaking ABI in future. + * libmodest-dbus-client/libmodest-dbus-client.c: + (get_attachments_string): Moved some code into this generic function. + (libmodest_dbus_client_send_mail): Corrected the documentation. This really + sends email. It is maybe not used. + * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail), + (on_send_mail): Use attachments. + + * src/widgets/modest-msg-edit-window.h: Improve the documentation. + * src/maemo/modest-msg-edit-window.c: + (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to + a filename before using it, to fix projects.maemo.org bug NB#58233. + +2007-06-19 Murray Cumming + + * src/modest-ui-actions.c: (modest_ui_actions_on_copy): + Initialize the continue_download variable to fix the build, and probably + to fix randome behaviour. + +2007-06-18 Armin Burgmeier + + * src/modest-tny-send-queue.h: + * src/modest-tny-send-queue.c: Keep track of the status of messages in + the queue so we can later show it in the UI. Replaced + modest_tny_send_queue_msg_is_being_sent() by + modest_tny_send_queue_get_msg_status(). + + * src/modest-ui-dimming-rules.c: Adjust for the replaced function. + + * src/modest-tny-account.c: Changed a cast to gpointer* to one to + gpointer. This probably was not harmful, but just to be sure. + +2007-06-18 Murray Cumming + + * src/maemo/modest-platform.c: (modest_platform_activate_uri): + Fix the build, but leave the function broken on Bora, because + hildon_uri_action_get_service() does not exist. + osso_uri_action_get_service() does not exist either, it seems. + +2007-06-18 Murray Cumming + + * src/modest-tny-account.c: + (modest_tny_account_new_from_server_account): + Uncommented the url debug output again, because it is useful for + debugging, as I said in the comment. + +2007-06-18 Murray Cumming + + * configure.ac: Do not require hildon-notify for Maemo Bora. It is not + available. + * src/modest-init.c: (modest_init_init_ui): Do not call notify_init() + for Mameo Bora, to fix the build. + +2007-06-17 Johannes Schmid + + * configure.ac: + Fixed build with hildon < 0.99 + + * src/maemo/modest-account-view-window.c: (on_edit_button_clicked): + Check if the selected account is busy instead of checking all accounts + + * src/modest-account-mgr-priv.h: + * src/modest-account-mgr.c: (modest_account_mgr_class_init), + (modest_account_mgr_init), (compare_account_name), + (modest_account_mgr_set_account_busy), + (modest_account_mgr_account_is_busy): + * src/modest-account-mgr.h: + Added busy information to the account manager. It possible to + set an account to busy or not busy now. + + * src/modest-mail-operation.c: (modest_mail_operation_finalize), + (modest_mail_operation_update_account), + (modest_mail_operation_notify_end): + Set the account to busy/not busy depending on the operation state. + + * src/widgets/modest-account-view.c: + (modest_account_view_finalize), (get_last_updated_string), + (update_account_view), (on_account_busy_changed), (init_view): + Show string "Refreshing..." if the account is currently busy. + + All this fixes projects.maemo.org bug NB#59711 + +2007-06-14 Armin Burgmeier + + * src/widgets/modest-attachments-view.h: + * src/widgets/modest-attachments-view.c: Added + modest_attachments_view_has_attachments() and fixed coordinate + transformation in get_att_view_at_coords(). This fixes attachment + selection. + + * src/widgets/modest-msg-view.c: Make use of + modest_attachments_view_has_attachments() to decide whether to show + attachments in the header. + +2007-06-14 Johannes Schmid + + * src/maemo/modest-connection-specific-smtp-edit-window.c: + (on_change), (on_combo_security_changed), + (modest_connection_specific_smtp_edit_window_init), + (modest_connection_specific_smtp_edit_window_set_connection), + (modest_connection_specific_smtp_edit_window_is_dirty): + * src/maemo/modest-connection-specific-smtp-edit-window.h: + * src/maemo/modest-connection-specific-smtp-window.c: + (on_button_edit): + + Show an comfirmation dialog for the smpt-edit-window if there are + unsaved changes and the user hits cancel. + (projects.maemo.org bug NB#60479) + +2007-06-14 Armin Burgmeier + + * src/maemo/easysetup/modest-easysetup-wizard.c: + * src/maemo/modest-account-settings-dialog.c: Show "invalid email + address" info in banner instead of node, and select all the text as + per UI spec. This fixes projects.maemo.org bug NB#60550. + +2007-06-14 set REAL_NAME environment variable + + reviewed by: + + * src/maemo/modest-main-window.c: (_on_msg_count_changed): + * src/modest-ui-actions.c: (folder_refreshed_cb): + +2007-06-14 Murray Cumming + + * src/widgets/modest-folder-view.c: (filter_row): + Explictly filter out the per-account outbox accounts. I don't know why + these only sometimes show up, but now they should never show up in the UI. + This should fix projects.maemo.org bug NB#60160. + +2007-06-14 Murray Cumming + + * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning + when the toolbar does not exist yet. + * src/modest-widget-memory.c: (save_settings_header_view): + Added g_warnings() to help us to discover when we are trying to set + an empty columns list in gconf. + +2007-06-14 Murray Cumming + + * src/modest-init.h: + * src/modest-init.c: + Added modest_init_get_default_header_view_column_ids(). + + * src/modest-widget-memory.c: (restore_settings_header_view): + Use the new function to get defaults, if the gconf key is empty, + instead of not creating any columns. This seems to fix the + empty right-hand pane problems. + + * src/widgets/modest-header-view.h: Improved documentation. + +2007-06-13 Murray Cumming + + * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account): + Revert the use of the display name as the account name, because this + is generally wrong and would break the code that follows. + +2007-06-13 Johannes Schmid + + * src/maemo/easysetup/modest-easysetup-wizard.c: + (check_for_supported_auth_methods), (on_before_next), + (create_account): + + More correct fix for projects.maemo.org bug NB# 58991 + Do not longer accept AUTH_PASSWORD as secure method and choose + correct method when creating the account. + +2007-06-13 Johannes Schmid + + * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account): + Fixed projects.maemo.org bug NB# 58991 + +2007-06-13 Murray Cumming + + * src/modest-init.c: (modest_init_init_core), + (modest_init_local_folders): Fixed compilation errors. + +2007-06-13 Murray Cumming + + * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in: + Remove unnecessary lib/include, though it is good in principle when needed. + + * src/modest-init.c: (modest_init_one_local_folder), + (modest_init_local_folders): + * src/modest-init.h: Initialize the .modest library for memory cards, + instead of just doing nothing for them. This should allow us to create + folders there, fixing projects.maemo.org bug NB#59297. + +2007-06-13 Murray Cumming + + * libmodest-dbus-client/libmodest-dbus-client.c: + (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to), + (libmodest_dbus_client_compose_mail), + (libmodest_dbus_client_open_message), + (libmodest_dbus_client_send_and_receive), + (libmodest_dbus_client_open_default_inbox): Improved debug messages. + + * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url), + (on_idle_open_message), (modest_dbus_req_handler), + (search_result_to_message), (modest_dbus_req_filter): + * src/modest-search.c: (add_hit), (modest_search_folder), + (modest_search_all_accounts): Improved debug messages. + + * tests/dbus_api/test_open_message.c: (main): Improved comments. + + * src/modest-tny-account-store.c: + (modest_tny_account_store_get_tny_account_by): Initialize a variable to + fix the build. + +2007-06-13 Murray Cumming + + +2007-06-12 Murray Cumming + + * src/modest-tny-account-store.c: (get_server_accounts): + Call modest_tny_local_folders_account_add_merged_outbox_folders() + even when there are no accounts, so that the Outbox folder is always + visible. This fixes projects.maemo.org bug NB#60158. + +2007-06-12 Murray Cumming + + * src/maemo/modest-main-window.c: (create_details_widget): + Use the mcen_va_never logical ID. + +2007-06-12 Murray Cumming + + * src/dbus_api/modest-dbus-api.h: + * src/dbus_api/modest-dbus-callbacks.c: + (on_idle_open_default_inbox), (on_open_default_inbox), + (modest_dbus_req_handler): + Added a new OpenDefaultInbox method. + + * libmodest-dbus-client/libmodest-dbus-client.h: + * libmodest-dbus-client/libmodest-dbus-client.c: + Added libmodest_dbus_client_open_default_inbox() to call the new + dbus method. This should be useful to projects.maemo.org bug NB#57214, + though it should maybe be used by a new osso-email-interface function. + + * tests/dbus_api/Makefile.am: + * tests/dbus_api/test_open_default_inbox.c: Added a test for the new + function. + +2007-06-12 Murray Cumming + + * src/modest-account-mgr.c: (on_key_change): Append to the list, not to + NULL, so that the signals get all the keys. This should not actually + change any behaviour because we currently update everything when anything + changes. + +2007-06-12 Murray Cumming + + * src/widgets/modest-folder-view.c: (text_cell_data), + (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows), + (find_inbox_iter): If tinymail tells us that the folder is + a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name. + This causes the inbox to be selected at startup, fixing part of + projects.maemo.org bug NB#56305. + + * src/modest-ui-dimming-rules.c: + (modest_ui_dimming_rules_on_tools_smtp_servers): + * src/modest-ui-dimming-rules.h: Added a callback function to dim + the SMTP servers menu item. + * src/maemo/modest-main-window-ui-dimming.h: Used the function, so + that the SMTP Servers menu item is dimmed when there are no accounts, + as a future version of the UI spec will require. This fixes + projects.maemo.org bug NB#56305. + +2007-06-11 Johannes Schmid + + * src/maemo/modest-maemo-utils.c: + (modest_maemo_utils_get_supported_secure_authentication_methods): + Added label to dialog instead of unreadable title + + * src/maemo/modest-main-window.c: (sync_accounts_cb), + (modest_main_window_new): + Fixed projects.maemo.org bug NB#58576 by moving previous fix out of + dead code. + + * src/modest-account-mgr.c: (modest_account_mgr_has_accounts): + * src/modest-account-mgr.h: + Added method to avoid code duplication + + * src/modest-ui-actions.c: (modest_ui_actions_on_accounts), + (modest_ui_actions_on_send_receive): + Use modest_account_mgr_has_accounts + +2007-06-11 Murray Cumming + + * src/maemo/easysetup/modest-presets.c: + (modest_presets_get_info_server_security): Do not report secure auth + if there is none. + * src/modest-protocol-info.c: Use the defines for the gconf key names + for secure authentication. This was not working because we were writing + Password and reading password, and the check was case sensitive. + With this, gmail now works for receiving and sending when created via + easysetup. + +2007-06-11 Murray Cumming + + * src/maemo/easysetup/modest-presets.c: + (modest_presets_get_info_server_security): Correct the key name for + SecureSmtp, because it seems to be case-sensitive. + * src/maemo/easysetup/modest-wizard-dialog.c: (create_title): + Do not try to get the 0th notebook page if there are 0 pages, to + avoid a g_warning(). + +2007-06-11 Murray Cumming + + * src/maemo/modest-platform.c: (modest_platform_on_new_msg): + Prevent use of the new notification feature for now, because it currently + shows one dialog for each new email, which is annoying. + +2007-06-11 Murray Cumming + + * src/maemo/easysetup/modest-easysetup-provider-combo-box.c: + (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0 + when no country was selected, so that we show the global ones. + * src/maemo/easysetup/modest-presets.c: + (modest_presets_get_providers): Return only the global providers, not + all providers when mmc=0 was requested. + +2007-06-11 Murray Cumming + + * src/maemo/easysetup/modest-easysetup-provider-combo-box.c: + (easysetup_provider_combo_box_fill): Remove debug code that showed the + provider ID in the combo. + + * src/maemo/easysetup/modest-wizard-dialog.c: (create_title): + Do not show the page numbers, because it would be confusing when we add + the 2 extra pages for the custom setup, when the user chooses the "Other" + provider. This fixes projects.maemo.org bug NB#59028 + + * src/modest-init.c: (modest_init_init_core), + (modest_init_local_folders): + * src/modest-init.h: + * src/modest-tny-account.c: + (modest_tny_account_new_for_local_folders): Do not create default folders + for the memory card. This should fix projects.maemo.org bug NB#59328. + +2007-06-11 Murray Cumming + + * src/modest-account-mgr.c: (modest_account_mgr_finalize): + Free the changed_conf_keys string items. They are already freed in the + idle handler if that runs first. + +2007-06-11 Murray Cumming + + * src/modest-ui-actions.c: + (modest_ui_actions_on_password_requested): Check that the server name + is not NULL, because I just saw a password dialog with (null) as the + server name. + + * src/modest-tny-folder.[h|c]: Added + modest_tny_folder_is_memory_card_folder(). + * src/modest-ui-dimming-rules.c: + (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context + menu item for memory cards, as per the UI spec (section 7.4). This should + fix projects.maemo.org bug NB#59297. + +2007-06-10 Johannes Schmid + + * src/maemo/modest-main-window.c: (sync_accounts_cb): + Fixed projects.maemo.org bug NB#58576 (not yet activated as there + is another problem with the code, see Murray's comment at line 772) + +2007-06-08 Murray Cumming + + * src/maemo/easysetup/modest-easysetup-country-combo-box.h: + * src/maemo/easysetup/modest-easysetup-country-combo-box.c: + (on_model_foreach_release), (easysetup_country_combo_box_finalize), + (load_from_file), (easysetup_country_combo_box_init), + (easysetup_country_combo_box_get_active_country_ids), + (on_model_foreach_select_id): Store a GSList* of IDs in the model row, + instead of just one ID, to avoid duplicate country names in the UI. + + * src/maemo/easysetup/modest-easysetup-provider-combo-box.h: + * src/maemo/easysetup/modest-easysetup-provider-combo-box.c: + (easysetup_provider_combo_box_fill): Adapt to use a list rather than + a single ID, avoiding duplicate providers. + * src/maemo/easysetup/modest-easysetup-wizard.c: + (on_combo_account_country): Adapt to use a list. + +2007-06-08 Murray Cumming + + * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of + keys changed in the last X seconds. + + * src/modest-account-mgr.h: + * src/modest-account-mgr.c: (on_timeout_notify_changes), + (on_key_change), (modest_account_mgr_class_init), + (modest_account_mgr_init), (modest_account_mgr_finalize): + As the keys are changed, save them in a GSList* and signal that GSList* + further every X seconds, to batch changes, to allow us to do just one + update per batch. This should fix bug projects.maemo.org bug NB#56472 and + bug NB#56941 and other (UI-blocking) delays when changing account settings. + + * src/modest-tny-account-store.c: (on_account_changed): Adapted to + changed signal signature. + + * src/modest-conf.c: (modest_conf_set_list), + (modest_conf_on_change): Reenable notification. + + (modest_conf_maemo_fake_on_change): Comment out the hack that + notified immediately instead of asynchronously. + + * src/widgets/modest-account-view.h: + * src/widgets/modest-account-view.c: + (update_account_view): Select the previously-selected account ID, + if possible. This fixes projects.maemo.org bug NB#56933. + + (on_account_changed), (on_account_removed), + (modest_account_view_select_account): + + Remove the block/unblock functions + because they were not useful. + + * src/maemo/modest-account-view-window.c: + (on_delete_button_clicked), (on_edit_button_clicked), + (on_new_button_clicked): Remove the use of the non-working block/unblock. + +2007-06-08 Murray Cumming + + * src/modest-tny-account-store.c: (modest_tny_account_store_alert): + Improve the error dialog to show Incorrect Account Settings, which seems + clearer, and say that the internal error message (to be removed from the + dialog later) is often misleading. + I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem. + + * src/modest-tny-account.c: + (modest_tny_account_new_from_server_account): Uncomment the printf of the + URL because this is so useful for debugging on the device. + + * src/widgets/modest-serversecurity-combo-box.c: + (modest_serversecurity_combo_box_fill): Correct a logical ID. + +2007-06-08 Murray Cumming + + * src/modest-mail-operation.c: + (modest_mail_operation_send_new_mail): + Added a comment about a nasty but apparently harmless message. Details + added to the wiki g_warnings() page. + +2007-06-08 Murray Cumming + + * src/modest-tny-send-queue.c: (modest_tny_send_queue_add), + (modest_tny_send_queue_class_init): + Do not use the priv struct because it is empty, to avoid g_warnings + about a non-existant priv struct. + + * src/modest-tny-account-store.c: + (modest_tny_account_store_get_server_account), + (modest_tny_account_store_get_transport_account_for_open_connection + ): Do not try to get transport server accounts for local folders, + because they don't have any. This avoids a g_warning(). + + * src/maemo/modest-main-window.c: + (modest_main_window_notify_send_receive_initied), + (on_configuration_key_changed): + * src/maemo/modest-msg-edit-window.c: (on_delete_event): + * src/modest-defs.h: + * src/modest-mail-operation.c: + (modest_mail_operation_update_account): + * src/modest-tny-account-store.h: + * src/modest-tny-account.c: + (modest_tny_account_get_special_folder), + (modest_tny_account_new_for_local_folders), + (modest_tny_account_new_for_per_account_local_outbox_folder): + * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder): + * src/modest-tny-local-folders-account.c: + (add_account_folders_to_merged_folder): + * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg), + (reply_forward_cb), (modest_ui_actions_on_save_to_drafts), + (modest_ui_actions_on_send): + * src/widgets/modest-folder-view.c: (update_model): + Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to + MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename + modest_tny_account_store_get_tny_account_by_account() to + modest_tny_account_store_get_server_account() to make the code clearer. + +2007-06-07 Marcus Bauer + + * src/dbus_api/modest-dbus-api.h: + changed MODEST_DBUS_NAME in order to get dbus auto-activation to work + * src/maemo/modest-msg-edit-window.c: + (modest_msg_edit_window_attach_file_noninteractive): + added g_warning in case the file to be attached does not exist + * tests/dbus_api/test_compose_mail.c: (main): + removed obsolete comment, added generic files as test case + +2007-06-07 Murray Cumming + + * src/modest-tny-account-store.c: (get_server_accounts): + Create the local folders account only once, not once for each outbox, and + not only when there are some outboxes. + +2007-06-07 Murray Cumming + + * src/widgets/modest-folder-view.c: (update_model): Comment out some + code that is causing a crash at startup. Sergio says that he is fixing this. + +2007-06-07 Johannes Schmid + + * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next): + * src/maemo/modest-account-settings-dialog.c: + (create_page_outgoing), + (modest_account_settings_dialog_set_account_name), + (save_configuration): + - Fixed handling of the "Use secure authentication" toggle to comply with + the ui specification. See also projects.maemo.org bug NB#58400 + + - Restore the Secure connection setting combo correctly when loading + the settings dialog + + * src/maemo/modest-maemo-utils.c: + (on_camel_account_get_supported_secure_authentication), + (modest_maemo_utils_get_supported_secure_authentication_methods): + Fixed a crasher if operation is canceled + + * src/modest-protocol-info.c: (modest_protocol_info_is_secure), + (modest_protocol_info_auth_is_secure): + * src/modest-protocol-info.h: + + Added two new methods to determine if a protocol/auth method is secure/encrypted in + the sense of the "Use secure authentication" toggle. + +2007-06-07 Murray Cumming + + * src/modest-tny-account-store.h: + * src/modest-tny-account-store.c: + Added modest_tny_account_store_get_local_folders_account(). + + * src/modest-tny-folder.h: + * src/modest-tny-folder.c: + (modest_tny_folder_get_account): + Added this replacement for tny_folder_get_account() which returns + the local-folders account for TnyMergeFolders, to avoid the + warning about the unimplemented get_account_func() vfunc(). + + (modest_tny_folder_get_rules), + * src/modest-ui-actions.c: + (modest_ui_actions_on_folder_selection_changed): + * src/modest-mail-operation.c: + (modest_mail_operation_remove_folder), + (modest_mail_operation_xfer_folder), + (modest_mail_operation_rename_folder), + (modest_mail_operation_get_msg), + (modest_mail_operation_get_msgs_full), + (modest_mail_operation_remove_msg), + (modest_mail_operation_xfer_msgs), + (modest_mail_operation_refresh_folder): + Use modest_tny_folder_get_account() instead of tny_folder_get_account(). + 2007-06-07 Murray Cumming * src/modest-account-mgr-helpers.c: (get_security_for_conf_string), @@ -2462,6 +4536,3 @@ Added modest_ui_actions_on_new_account() as a signal handler for the New Account menu item. It shows the easysetup wizard. * po/en_GB.po: Added additional needed logical IDs and translations. - -Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc. -Apparently ChangeLog is not used for some vague Nokia legal reasons.