X-Git-Url: http://git.maemo.org/git/?p=modest;a=blobdiff_plain;f=src%2Fmaemo%2Fmodest-main-window.c;h=0f1379a7f5b14a3250c91b6d7c63b0ab200d2e15;hp=e3b830a281fbd872eadef4f43e149b15032aac9e;hb=5ed358c5ab48fafa987c9c1d4ec9b837dc637412;hpb=c3da84683c35ffe81b2e07b8acae82bcbd739f54 diff --git a/src/maemo/modest-main-window.c b/src/maemo/modest-main-window.c index e3b830a..0f1379a 100644 --- a/src/maemo/modest-main-window.c +++ b/src/maemo/modest-main-window.c @@ -59,7 +59,7 @@ #include "modest-tny-msg.h" #include "modest-mail-operation.h" #include "modest-icon-names.h" -#include "modest-progress-bar-widget.h" +#include "modest-progress-bar.h" #include "modest-text-utils.h" #include "modest-ui-dimming-manager.h" #include "maemo/modest-osso-state-saving.h" @@ -176,6 +176,15 @@ static void on_updating_msg_list (ModestHeaderView *header_view, static gboolean restore_paned_timeout_handler (gpointer *data); +static gboolean show_retrieving_banner (gpointer user_data); + +static void on_window_destroy (GtkObject *widget, + gpointer userdata); + +static void on_window_hide (GObject *gobject, + GParamSpec *arg1, + gpointer user_data); + typedef struct _ModestMainWindowPrivate ModestMainWindowPrivate; struct _ModestMainWindowPrivate { GtkWidget *msg_paned; @@ -214,6 +223,7 @@ struct _ModestMainWindowPrivate { ModestMainWindowStyle style; ModestMainWindowContentsStyle contents_style; + gboolean wait_for_settings; guint progress_bar_timeout; guint restore_paned_timeout; @@ -226,6 +236,10 @@ struct _ModestMainWindowPrivate { GtkWidget *updating_banner; guint updating_banner_timeout; + /* "Retrieving" banner for header view */ + GtkWidget *retrieving_banner; + guint retrieving_banner_timeout; + /* Display state */ osso_display_state_t display_state; }; @@ -257,7 +271,7 @@ static const GtkActionEntry modest_folder_view_action_entries [] = { { "FolderViewCSMPasteMsgs", NULL, N_("mcen_me_inbox_paste"), NULL, NULL, G_CALLBACK (modest_ui_actions_on_paste)}, { "FolderViewCSMDeleteFolder", NULL, N_("mcen_me_inbox_delete"), NULL, NULL, G_CALLBACK (modest_ui_actions_on_delete_folder) }, { "FolderViewCSMSearchMessages", NULL, N_("mcen_me_inbox_search"), NULL, NULL, G_CALLBACK (modest_ui_actions_on_search_messages) }, - { "FolderViewCSMHelp", NULL, N_("mcen_me_inbox_help"), NULL, NULL, G_CALLBACK (modest_ui_actions_on_help) }, + { "FolderViewCSMHelp", NULL, N_("mcen_me_inbox_help"), NULL, NULL, G_CALLBACK (modest_ui_actions_on_csm_help) }, }; static const GtkActionEntry modest_header_view_action_entries [] = { @@ -345,6 +359,7 @@ modest_main_window_init (ModestMainWindow *obj) priv->progress_bar = NULL; priv->current_toolbar_mode = TOOLBAR_MODE_NORMAL; priv->style = MODEST_MAIN_WINDOW_STYLE_SPLIT; + priv->wait_for_settings = TRUE; priv->contents_style = -1; /* invalid contents style. We need this to select it for the first time */ priv->merge_ids = NULL; priv->optimized_view = FALSE; @@ -354,6 +369,8 @@ modest_main_window_init (ModestMainWindow *obj) priv->sighandlers = NULL; priv->updating_banner = NULL; priv->updating_banner_timeout = 0; + priv->retrieving_banner = NULL; + priv->retrieving_banner_timeout = 0; priv->display_state = OSSO_DISPLAY_ON; modest_window_mgr_register_help_id (modest_runtime_get_window_mgr(), @@ -392,6 +409,16 @@ modest_main_window_finalize (GObject *obj) priv->updating_banner = NULL; } + if (priv->retrieving_banner_timeout > 0) { + g_source_remove (priv->retrieving_banner_timeout); + priv->retrieving_banner_timeout = 0; + } + + if (priv->retrieving_banner) { + gtk_widget_destroy (priv->retrieving_banner); + priv->retrieving_banner = NULL; + } + if (priv->restore_paned_timeout > 0) { g_source_remove (priv->restore_paned_timeout); priv->restore_paned_timeout = 0; @@ -422,7 +449,9 @@ modest_main_window_get_child_widget (ModestMainWindow *self, return NULL; } - return widget ? GTK_WIDGET(widget) : NULL; + /* Note that the window could have been destroyed, and so + their children, but still have some references */ + return (widget && GTK_IS_WIDGET(widget)) ? GTK_WIDGET(widget) : NULL; } static gboolean @@ -465,10 +494,10 @@ restore_settings (ModestMainWindow *self, gboolean do_folder_view_too) modest_widget_memory_restore (conf, G_OBJECT(priv->folder_view), MODEST_CONF_FOLDER_VIEW_KEY); - modest_widget_memory_restore (conf, G_OBJECT(priv->main_paned), - MODEST_CONF_MAIN_PANED_KEY); +/* modest_widget_memory_restore (conf, G_OBJECT(priv->main_paned), */ +/* MODEST_CONF_MAIN_PANED_KEY); */ - g_timeout_add (500, (GSourceFunc) restore_paned_timeout_handler, self); + g_timeout_add (250, (GSourceFunc) restore_paned_timeout_handler, self); /* We need to force a redraw here in order to get the right position of the horizontal paned separator */ @@ -488,10 +517,10 @@ save_state (ModestWindow *window) modest_widget_memory_save (conf,G_OBJECT(self), MODEST_CONF_MAIN_WINDOW_KEY); - modest_widget_memory_save (conf, G_OBJECT(priv->main_paned), - MODEST_CONF_MAIN_PANED_KEY); - // modest_widget_memory_save (conf, G_OBJECT(priv->header_view), - // MODEST_CONF_HEADER_VIEW_KEY); + /* Only save main paned position if we're in split mode */ + if (priv->style == MODEST_MAIN_WINDOW_STYLE_SPLIT) + modest_widget_memory_save (conf, G_OBJECT(priv->main_paned), + MODEST_CONF_MAIN_PANED_KEY); modest_widget_memory_save (conf, G_OBJECT(priv->folder_view), MODEST_CONF_FOLDER_VIEW_KEY); } @@ -504,6 +533,14 @@ compare_display_names (ModestAccountSettings *a, modest_account_settings_get_display_name (b)); } +/* We use this function to prevent the send&receive CSM to be shown + when there are less than two account */ +static gboolean +tap_and_hold_query_cb (GtkWidget *widget, GdkEvent *event) +{ + return TRUE; +} + static void update_menus (ModestMainWindow* self) { @@ -623,6 +660,8 @@ update_menus (ModestMainWindow* self) display_name = g_strdup_printf (_("mcen_me_toolbar_sendreceive_mailbox_n"), modest_account_settings_get_display_name (settings)); } + + /* Create action and add it to the action group. The action name must be the account name, this way we @@ -631,9 +670,13 @@ update_menus (ModestMainWindow* self) gchar* item_name, *refresh_action_name; guint8 merge_id = 0; GtkAction *view_account_action, *refresh_account_action; + gchar *escaped_display_name; + + escaped_display_name = modest_text_utils_escape_mnemonics (display_name); view_account_action = GTK_ACTION (gtk_radio_action_new (account_name, - display_name, NULL, NULL, 0)); + escaped_display_name, NULL, NULL, 0)); + g_free (escaped_display_name); gtk_action_group_add_action (priv->view_additions_group, view_account_action); gtk_radio_action_set_group (GTK_RADIO_ACTION (view_account_action), radio_group); radio_group = gtk_radio_action_get_group (GTK_RADIO_ACTION (view_account_action)); @@ -693,17 +736,14 @@ update_menus (ModestMainWindow* self) /* Create item and add it to the send&receive CSM. If there is only one account then it'll be no menu */ - if (priv->accounts_popup) { + if (num_accounts > 1) { GtkWidget *label = gtk_label_new(NULL); gtk_misc_set_alignment (GTK_MISC (label), 0.0, 0.5); - if (default_account && (strcmp(account_name, default_account) == 0)) - { + if (default_account && (strcmp(account_name, default_account) == 0)) { gchar *escaped = g_markup_printf_escaped ("%s", display_name); gtk_label_set_markup (GTK_LABEL (label), escaped); g_free (escaped); - } - else - { + } else { gtk_label_set_text (GTK_LABEL (label), display_name); } @@ -731,56 +771,82 @@ update_menus (ModestMainWindow* self) * group being inserted. This makes the default account appear in bold. * I agree it is a rather ugly way, but I don't see another possibility. armin. */ for (i = 0; i < num_accounts; i++) { - ModestAccountSettings *settings = (ModestAccountSettings *) g_slist_nth_data (accounts, i); + gchar *item_name, *path; + GtkWidget *item; + ModestAccountSettings *settings; const gchar *account_name; + gboolean is_default; + settings = (ModestAccountSettings *) g_slist_nth_data (accounts, i); account_name = modest_account_settings_get_account_name (settings); + is_default = (account_name && default_account && !strcmp (account_name, default_account)); - if(account_name && default_account && - strcmp (account_name, default_account) == 0) { - gchar *item_name = g_strconcat (account_name, "Menu", NULL); - - gchar *path = g_strconcat ("/MenuBar/ViewMenu/ViewMenuAdditions/", item_name, NULL); - GtkWidget *item = gtk_ui_manager_get_widget (parent_priv->ui_manager, path); - g_free(path); - - if (item) { - GtkWidget *child = gtk_bin_get_child (GTK_BIN (item)); - if (GTK_IS_LABEL (child)) { - const gchar *cur_name = gtk_label_get_text (GTK_LABEL (child)); + /* Get the item of the view menu */ + item_name = g_strconcat (account_name, "Menu", NULL); + path = g_strconcat ("/MenuBar/ViewMenu/ViewMenuAdditions/", item_name, NULL); + item = gtk_ui_manager_get_widget (parent_priv->ui_manager, path); + g_free(path); + + if (item) { + GtkWidget *child = gtk_bin_get_child (GTK_BIN (item)); + if (GTK_IS_LABEL (child)) { + const gchar *cur_name = gtk_label_get_text (GTK_LABEL (child)); + if (is_default) { gchar *bold_name = g_markup_printf_escaped("%s", cur_name); gtk_label_set_markup (GTK_LABEL (child), bold_name); g_free (bold_name); } + gtk_label_set_ellipsize (GTK_LABEL (child), PANGO_ELLIPSIZE_END); } + } - path = g_strconcat("/MenuBar/ToolsMenu/ToolsSendReceiveMainMenu/ToolsMenuAdditions/", item_name, NULL); - item = gtk_ui_manager_get_widget (parent_priv->ui_manager, path); - g_free (path); - - if (item) { - GtkWidget *child = gtk_bin_get_child (GTK_BIN (item)); - if (GTK_IS_LABEL (child)) { - const gchar *cur_name = gtk_label_get_text (GTK_LABEL (child)); + /* Get the item of the tools menu */ + path = g_strconcat("/MenuBar/ToolsMenu/ToolsSendReceiveMainMenu/ToolsMenuAdditions/", item_name, NULL); + item = gtk_ui_manager_get_widget (parent_priv->ui_manager, path); + g_free (path); + + if (item) { + GtkWidget *child = gtk_bin_get_child (GTK_BIN (item)); + if (GTK_IS_LABEL (child)) { + const gchar *cur_name = gtk_label_get_text (GTK_LABEL (child)); + if (is_default) { gchar *bold_name = g_markup_printf_escaped("%s", cur_name); gtk_label_set_markup (GTK_LABEL (child), bold_name); g_free (bold_name); } + gtk_label_set_ellipsize (GTK_LABEL (child), PANGO_ELLIPSIZE_END); } - - g_free(item_name); } + g_free(item_name); g_object_unref (settings); } - if (priv->accounts_popup) { + if (num_accounts > 1) { + /* Disconnect the tap-and-hold-query if it's connected */ + if (modest_signal_mgr_is_connected (priv->sighandlers, + G_OBJECT (send_receive_button), + "tap-and-hold-query")) + priv->sighandlers = modest_signal_mgr_disconnect (priv->sighandlers, + G_OBJECT (send_receive_button), + "tap-and-hold-query"); + /* Mandatory in order to view the menu contents */ gtk_widget_show_all (priv->accounts_popup); /* Setup tap_and_hold just if was not done before*/ if (!gtk_menu_get_attach_widget (GTK_MENU (priv->accounts_popup))) gtk_widget_tap_and_hold_setup (send_receive_button, priv->accounts_popup, NULL, 0); + } else { + /* Connect the tap-and-hold-query in order not to show the CSM */ + if (!modest_signal_mgr_is_connected (priv->sighandlers, + G_OBJECT (send_receive_button), + "tap-and-hold-query")) + priv->sighandlers = modest_signal_mgr_connect (priv->sighandlers, + G_OBJECT (send_receive_button), + "tap-and-hold-query", + G_CALLBACK (tap_and_hold_query_cb), + NULL); } /* Frees */ @@ -828,6 +894,26 @@ modest_main_window_cleanup_queue_error_signals (ModestMainWindow *self) static void +_folder_view_csm_menu_activated (GtkWidget *widget, gpointer user_data) +{ + g_return_if_fail (MODEST_IS_MAIN_WINDOW (user_data)); + + /* Update dimmed */ + modest_ui_actions_check_menu_dimming_rules (MODEST_WINDOW(user_data)); +} + +static void +_header_view_csm_menu_activated (GtkWidget *widget, gpointer user_data) +{ + g_return_if_fail (MODEST_IS_MAIN_WINDOW (user_data)); + + /* Update visibility */ + + /* Update dimmed */ + modest_ui_actions_check_menu_dimming_rules (MODEST_WINDOW(user_data)); +} + +static void modest_main_window_disconnect_signals (ModestWindow *self) { ModestMainWindowPrivate *priv; @@ -872,6 +958,9 @@ connect_signals (ModestMainWindow *self) /* Folder view CSM */ menu = gtk_ui_manager_get_widget (parent_priv->ui_manager, "/FolderViewCSM"); gtk_widget_tap_and_hold_setup (GTK_WIDGET (priv->folder_view), menu, NULL, 0); + priv->sighandlers = modest_signal_mgr_connect (priv->sighandlers, G_OBJECT(priv->folder_view), "tap-and-hold", + G_CALLBACK(_folder_view_csm_menu_activated), + self); /* header view */ priv->sighandlers = modest_signal_mgr_connect (priv->sighandlers,G_OBJECT(priv->header_view), "header_selected", @@ -901,12 +990,21 @@ connect_signals (ModestMainWindow *self) /* Header view CSM */ menu = gtk_ui_manager_get_widget (parent_priv->ui_manager, "/HeaderViewCSM"); gtk_widget_tap_and_hold_setup (GTK_WIDGET (priv->header_view), menu, NULL, 0); + priv->sighandlers = + modest_signal_mgr_connect (priv->sighandlers,G_OBJECT(priv->header_view), "tap-and-hold", + G_CALLBACK(_header_view_csm_menu_activated), + self); /* window */ priv->sighandlers = modest_signal_mgr_connect (priv->sighandlers,G_OBJECT (self), "window-state-event", G_CALLBACK (modest_main_window_window_state_event), NULL); + /* we don't register this in sighandlers, as it should be run after disconnecting all signals, + * in destroy stage */ + g_signal_connect (G_OBJECT (self), "destroy", G_CALLBACK (on_window_destroy), NULL); + + g_signal_connect (G_OBJECT (self), "notify::visible", G_CALLBACK (on_window_hide), NULL); /* Mail Operation Queue */ priv->sighandlers = @@ -1023,7 +1121,9 @@ modest_main_window_on_show (GtkWidget *self, gpointer user_data) modest_osso_load_state (); /* Restore window & widget settings */ + priv->wait_for_settings = TRUE; restore_settings (MODEST_MAIN_WINDOW(self), TRUE); + priv->wait_for_settings = FALSE; /* Check if accounts exist and show the account wizard if not */ gboolean accounts_exist = @@ -1067,7 +1167,8 @@ modest_main_window_new (void) ModestMainWindowPrivate *priv = NULL; ModestWindowPrivate *parent_priv = NULL; GtkWidget *folder_win = NULL; - ModestDimmingRulesGroup *window_rules_group = NULL; + ModestDimmingRulesGroup *menu_rules_group = NULL; + ModestDimmingRulesGroup *toolbar_rules_group = NULL; GtkActionGroup *action_group = NULL; GError *error = NULL; HildonProgram *app; @@ -1085,7 +1186,8 @@ modest_main_window_new (void) action_group = gtk_action_group_new ("ModestMainWindowActions"); gtk_action_group_set_translation_domain (action_group, GETTEXT_PACKAGE); - window_rules_group = modest_dimming_rules_group_new ("ModestWindowDimmingRules", TRUE); + menu_rules_group = modest_dimming_rules_group_new (MODEST_DIMMING_RULES_MENU, FALSE); + toolbar_rules_group = modest_dimming_rules_group_new (MODEST_DIMMING_RULES_TOOLBAR, TRUE); /* Add common actions */ gtk_action_group_add_actions (action_group, @@ -1126,18 +1228,20 @@ modest_main_window_new (void) } /* Add common dimming rules */ - modest_dimming_rules_group_add_rules (window_rules_group, - modest_main_window_toolbar_dimming_entries, - G_N_ELEMENTS (modest_main_window_toolbar_dimming_entries), - MODEST_WINDOW (self)); - modest_dimming_rules_group_add_rules (window_rules_group, + modest_dimming_rules_group_add_rules (menu_rules_group, modest_main_window_menu_dimming_entries, G_N_ELEMENTS (modest_main_window_menu_dimming_entries), MODEST_WINDOW (self)); + modest_dimming_rules_group_add_rules (toolbar_rules_group, + modest_main_window_toolbar_dimming_entries, + G_N_ELEMENTS (modest_main_window_toolbar_dimming_entries), + MODEST_WINDOW (self)); /* Insert dimming rules group for this window */ - modest_ui_dimming_manager_insert_rules_group (parent_priv->ui_dimming_manager, window_rules_group); - g_object_unref (window_rules_group); + modest_ui_dimming_manager_insert_rules_group (parent_priv->ui_dimming_manager, menu_rules_group); + modest_ui_dimming_manager_insert_rules_group (parent_priv->ui_dimming_manager, toolbar_rules_group); + g_object_unref (menu_rules_group); + g_object_unref (toolbar_rules_group); /* Add accelerators */ gtk_window_add_accel_group (GTK_WINDOW (self), @@ -1267,6 +1371,10 @@ modest_main_window_set_style (ModestMainWindow *self, priv->style = style; switch (style) { case MODEST_MAIN_WINDOW_STYLE_SIMPLE: + + if (!priv->wait_for_settings) + modest_widget_memory_save (modest_runtime_get_conf (), G_OBJECT (priv->main_paned), + MODEST_CONF_MAIN_PANED_KEY); /* Remove main paned */ g_object_ref (priv->main_paned); gtk_container_remove (GTK_CONTAINER (priv->main_vbox), priv->main_paned); @@ -1284,6 +1392,8 @@ modest_main_window_set_style (ModestMainWindow *self, gtk_paned_add2 (GTK_PANED (priv->main_paned), priv->contents_widget); gtk_container_add (GTK_CONTAINER (priv->main_vbox), priv->main_paned); + g_timeout_add (500, (GSourceFunc) restore_paned_timeout_handler, self); + break; default: g_return_if_reached (); @@ -1419,7 +1529,7 @@ modest_main_window_show_toolbar (ModestWindow *self, toolbar_resize (MODEST_MAIN_WINDOW (self)); /* Add ProgressBar (Transfer toolbar) */ - priv->progress_bar = modest_progress_bar_widget_new (); + priv->progress_bar = modest_progress_bar_new (); gtk_widget_set_no_show_all (priv->progress_bar, TRUE); placeholder = gtk_ui_manager_get_widget (parent_priv->ui_manager, "/ToolBar/ProgressBarView"); insert_index = gtk_toolbar_get_item_index(GTK_TOOLBAR (parent_priv->toolbar), GTK_TOOL_ITEM(placeholder)); @@ -1484,7 +1594,13 @@ on_account_inserted (TnyAccountStore *accoust_store, TnyAccount *account, gpointer user_data) { - update_menus (MODEST_MAIN_WINDOW (user_data)); + /* Transport accounts and local ones (MMC and the Local + folders account do now cause menu changes */ + if (TNY_IS_STORE_ACCOUNT (account) && + modest_tny_folder_store_is_remote (TNY_FOLDER_STORE (account))) { + /* Update menus */ + update_menus (MODEST_MAIN_WINDOW (user_data)); + } } static void @@ -1499,7 +1615,11 @@ on_account_removed (TnyAccountStore *accoust_store, TnyAccount *account, gpointer user_data) { - update_menus (MODEST_MAIN_WINDOW (user_data)); + /* Transport accounts and local ones (MMC and the Local + folders account do now cause menu changes */ + if (TNY_IS_STORE_ACCOUNT (account) && + modest_tny_folder_store_is_remote (TNY_FOLDER_STORE (account))) + update_menus (MODEST_MAIN_WINDOW (user_data)); } static void @@ -1508,14 +1628,18 @@ on_account_changed (TnyAccountStore *account_store, gpointer user_data) { ModestMainWindow *win = MODEST_MAIN_WINDOW (user_data); - - /* We need to refresh the details widget because it could have changed */ - if (modest_main_window_get_contents_style(win) == MODEST_MAIN_WINDOW_CONTENTS_STYLE_DETAILS) { - modest_main_window_set_contents_style (win, MODEST_MAIN_WINDOW_CONTENTS_STYLE_DETAILS); - } - /* Update the menus as well, the account name could be changed */ - update_menus (MODEST_MAIN_WINDOW (user_data)); + /* Transport accounts and local ones (MMC and the Local + folders account do now cause menu changes */ + if (TNY_IS_STORE_ACCOUNT (account)) { + /* We need to refresh the details widget because it could have changed */ + if (modest_main_window_get_contents_style(win) == MODEST_MAIN_WINDOW_CONTENTS_STYLE_DETAILS) + modest_main_window_set_contents_style (win, MODEST_MAIN_WINDOW_CONTENTS_STYLE_DETAILS); + + /* Update the menus as well, name could change */ + if (modest_tny_folder_store_is_remote (TNY_FOLDER_STORE (account))) + update_menus (MODEST_MAIN_WINDOW (user_data)); + } } /* @@ -1537,6 +1661,9 @@ on_inner_widgets_key_pressed (GtkWidget *widget, { ModestMainWindowPrivate *priv; + if (event->type == GDK_KEY_RELEASE) + return FALSE; + priv = MODEST_MAIN_WINDOW_GET_PRIVATE (user_data); /* Do nothing if we're in SIMPLE style */ @@ -1551,6 +1678,20 @@ on_inner_widgets_key_pressed (GtkWidget *widget, if (selected_headers > 1) { hildon_banner_show_information (NULL, NULL, _("mcen_ib_select_one_message")); return TRUE; + } else { + GtkTreePath * cursor_path; + gtk_tree_view_get_cursor (GTK_TREE_VIEW (widget), &cursor_path, NULL); + if (cursor_path == NULL) { + GtkTreeSelection *selection; + GList *list; + selection = gtk_tree_view_get_selection (GTK_TREE_VIEW (widget)); + list = gtk_tree_selection_get_selected_rows (selection, NULL); + + if (list != NULL) + gtk_tree_view_set_cursor (GTK_TREE_VIEW (widget), (GtkTreePath *) list->data, NULL, FALSE); + g_list_foreach (list, (GFunc) gtk_tree_path_free, NULL); + g_list_free (list); + } } } } else if (MODEST_IS_FOLDER_VIEW (widget) && event->keyval == GDK_Right) @@ -1702,7 +1843,7 @@ create_details_widget (GtkWidget *styled_widget, TnyAccount *account) g_free (label); /* Folder count */ - label = g_markup_printf_escaped ("%s: %d", + label = g_markup_printf_escaped ("%s: %d", gray_color_markup, _("mcen_fi_rootfolder_folders"), modest_tny_folder_store_get_folder_count (folder_store)); @@ -1819,10 +1960,11 @@ on_msg_count_changed (ModestHeaderView *header_view, TnyFolderChange *change, ModestMainWindow *main_window) { + gboolean refilter = FALSE; gboolean folder_empty = FALSE; gboolean all_marked_as_deleted = FALSE; ModestMainWindowPrivate *priv; - + g_return_if_fail (MODEST_IS_MAIN_WINDOW (main_window)); g_return_if_fail (TNY_IS_FOLDER(folder)); priv = MODEST_MAIN_WINDOW_GET_PRIVATE (main_window); @@ -1833,25 +1975,25 @@ on_msg_count_changed (ModestHeaderView *header_view, changed = tny_folder_change_get_changed (change); /* If something changes */ if ((changed) & TNY_FOLDER_CHANGE_CHANGED_ALL_COUNT) - folder_empty = (tny_folder_change_get_new_all_count (change) == 0); + folder_empty = (((guint) tny_folder_change_get_new_all_count (change)) == 0); else - folder_empty = (tny_folder_get_all_count (TNY_FOLDER (folder)) == 0); - + folder_empty = (((guint) tny_folder_get_all_count (TNY_FOLDER (folder))) == 0); + /* Play a sound (if configured) and make the LED blink */ if (changed & TNY_FOLDER_CHANGE_CHANGED_ADDED_HEADERS) { - modest_platform_on_new_headers_received (NULL, FALSE); - } - - /* Checks header removed (hide marked as DELETED headers) */ - if (changed & TNY_FOLDER_CHANGE_CHANGED_EXPUNGED_HEADERS) { - modest_header_view_refilter (MODEST_HEADER_VIEW(priv->header_view)); + modest_platform_push_email_notification (); } + + if ((changed) & TNY_FOLDER_CHANGE_CHANGED_EXPUNGED_HEADERS) + refilter = TRUE; + } else { + folder_empty = (((guint) tny_folder_get_all_count (TNY_FOLDER (folder))) == 0); } /* Check if all messages are marked to be deleted */ all_marked_as_deleted = modest_header_view_is_empty (header_view); - folder_empty = folder_empty || all_marked_as_deleted ; - + folder_empty = folder_empty || all_marked_as_deleted; + /* Set contents style of headers view */ if (folder_empty) { modest_main_window_set_contents_style (main_window, @@ -1861,6 +2003,9 @@ on_msg_count_changed (ModestHeaderView *header_view, modest_main_window_set_contents_style (main_window, MODEST_MAIN_WINDOW_CONTENTS_STYLE_HEADERS); } + + if (refilter) + modest_header_view_refilter (header_view); } @@ -2040,7 +2185,8 @@ set_toolbar_mode (ModestMainWindow *self, priv->current_toolbar_mode = mode; /* Checks the dimming rules */ - modest_ui_actions_check_window_dimming_rules (MODEST_WINDOW (self)); + modest_ui_actions_check_toolbar_dimming_rules (MODEST_WINDOW (self)); + modest_ui_actions_check_menu_dimming_rules (MODEST_WINDOW (self)); /* Show and hide toolbar items */ switch (mode) { @@ -2154,6 +2300,7 @@ get_toolbar_mode_from_mail_operation (ModestMainWindow *self, /* Get toolbar mode from operation id*/ switch (modest_mail_operation_get_type_operation (mail_op)) { + case MODEST_MAIL_OPERATION_TYPE_SEND_AND_RECEIVE: case MODEST_MAIL_OPERATION_TYPE_RECEIVE: case MODEST_MAIL_OPERATION_TYPE_OPEN: mode = TOOLBAR_MODE_TRANSFER; @@ -2176,7 +2323,7 @@ on_mail_operation_started (ModestMailOperation *mail_op, ModestToolBarModes mode; GSList *tmp; gboolean mode_changed = FALSE; - TnyAccount *account; + TnyAccount *account = NULL; self = MODEST_MAIN_WINDOW (user_data); priv = MODEST_MAIN_WINDOW_GET_PRIVATE (self); @@ -2190,10 +2337,24 @@ on_mail_operation_started (ModestMailOperation *mail_op, is_remote = !(modest_tny_account_is_virtual_local_folders (account) || modest_tny_account_is_memory_card_account (account)); - g_object_unref (account); - if (!is_remote) + if (!is_remote) { + g_object_unref (account); return; + } + + /* Show information banner. Remove old timeout */ + if (priv->retrieving_banner_timeout > 0) { + g_source_remove (priv->retrieving_banner_timeout); + priv->retrieving_banner_timeout = 0; + } + /* Create a new timeout */ + priv->retrieving_banner_timeout = + g_timeout_add (2000, show_retrieving_banner, self); } + + /* Not every mail operation has account, noop does not */ + if (account) + g_object_unref (account); /* Get toolbar mode from operation id*/ mode = get_toolbar_mode_from_mail_operation (self, mail_op, &mode_changed); @@ -2215,6 +2376,10 @@ on_mail_operation_started (ModestMailOperation *mail_op, tmp = g_slist_next (tmp); } } + + /* Update the main menu as well, we need to explicitely do + this in order to enable/disable accelerators */ + modest_ui_actions_check_menu_dimming_rules (MODEST_WINDOW (self)); } static void @@ -2226,7 +2391,7 @@ on_mail_operation_finished (ModestMailOperation *mail_op, GSList *tmp = NULL; ModestMainWindow *self; gboolean mode_changed; - TnyAccount *account; + TnyAccount *account = NULL; ModestMainWindowPrivate *priv; self = MODEST_MAIN_WINDOW (user_data); @@ -2241,11 +2406,28 @@ on_mail_operation_finished (ModestMailOperation *mail_op, is_remote = !(modest_tny_account_is_virtual_local_folders (account) || modest_tny_account_is_memory_card_account (account)); - g_object_unref (account); - if (!is_remote) + if (!is_remote) { + g_object_unref (account); return; + } + + /* Remove old timeout */ + if (priv->retrieving_banner_timeout > 0) { + g_source_remove (priv->retrieving_banner_timeout); + priv->retrieving_banner_timeout = 0; + } + + /* Remove the banner if exists */ + if (priv->retrieving_banner) { + gtk_widget_destroy (priv->retrieving_banner); + priv->retrieving_banner = NULL; + } } + /* Not every mail operation has account, noop does not */ + if (account) + g_object_unref (account); + /* Get toolbar mode from operation id*/ mode = get_toolbar_mode_from_mail_operation (self, mail_op, &mode_changed); @@ -2397,9 +2579,9 @@ refresh_account (const gchar *account_name) /* If account_name == NULL, we must update all (option All) */ if (!account_name) - modest_ui_actions_do_send_receive_all (win); + modest_ui_actions_do_send_receive_all (win, TRUE, TRUE, TRUE); else - modest_ui_actions_do_send_receive (account_name, win); + modest_ui_actions_do_send_receive (account_name, TRUE, TRUE, TRUE, win); } @@ -2435,8 +2617,9 @@ on_folder_view_focus_in (GtkWidget *widget, GdkEventFocus *event, gpointer userd g_return_val_if_fail (MODEST_IS_MAIN_WINDOW (userdata), FALSE); main_window = MODEST_MAIN_WINDOW (userdata); - /* Update window dimming state */ - modest_ui_actions_check_window_dimming_rules (MODEST_WINDOW (main_window)); + /* Update toolbar dimming state */ + modest_ui_actions_check_toolbar_dimming_rules (MODEST_WINDOW (main_window)); + modest_ui_actions_check_menu_dimming_rules (MODEST_WINDOW (main_window)); return FALSE; } @@ -2452,8 +2635,9 @@ on_header_view_focus_in (GtkWidget *widget, main_window = MODEST_MAIN_WINDOW (userdata); - /* Update window dimming state */ - modest_ui_actions_check_window_dimming_rules (MODEST_WINDOW (main_window)); + /* Update toolbar dimming state */ + modest_ui_actions_check_toolbar_dimming_rules (MODEST_WINDOW (main_window)); + modest_ui_actions_check_menu_dimming_rules (MODEST_WINDOW (main_window)); return FALSE; } @@ -2615,7 +2799,99 @@ modest_main_window_screen_is_on (ModestMainWindow *self) { ModestMainWindowPrivate *priv = NULL; + g_return_val_if_fail (MODEST_IS_MAIN_WINDOW(self), FALSE); + priv = MODEST_MAIN_WINDOW_GET_PRIVATE (self); return (priv->display_state == OSSO_DISPLAY_ON) ? TRUE : FALSE; } + +static void +remove_banners (ModestMainWindow *window) +{ + ModestMainWindowPrivate *priv; + + priv = MODEST_MAIN_WINDOW_GET_PRIVATE (window); + + if (priv->retrieving_banner_timeout > 0) { + g_source_remove (priv->retrieving_banner_timeout); + priv->retrieving_banner_timeout = 0; + } + + if (priv->retrieving_banner != NULL) { + gtk_widget_destroy (priv->retrieving_banner); + priv->retrieving_banner = NULL; + } + + if (priv->updating_banner_timeout > 0) { + g_source_remove (priv->updating_banner_timeout); + priv->updating_banner_timeout = 0; + } + + if (priv->updating_banner != NULL) { + gtk_widget_destroy (priv->updating_banner); + priv->updating_banner = NULL; + } +} + + +static void +on_window_hide (GObject *gobject, + GParamSpec *arg1, + gpointer user_data) +{ + g_return_if_fail (MODEST_IS_MAIN_WINDOW (gobject)); + + if (!GTK_WIDGET_VISIBLE (gobject)) { + TnyFolderStore *folder_store; + ModestMainWindowPrivate *priv; + + /* Remove the currently shown banners */ + remove_banners (MODEST_MAIN_WINDOW (gobject)); + + /* Force the folder view to sync the currently selected folder + to save the read/unread status and to expunge messages */ + priv = MODEST_MAIN_WINDOW_GET_PRIVATE (gobject); + folder_store = modest_folder_view_get_selected (priv->folder_view); + if (TNY_IS_FOLDER (folder_store)) { + ModestMailOperation *mail_op; + + mail_op = modest_mail_operation_new (NULL); + modest_mail_operation_queue_add (modest_runtime_get_mail_operation_queue (), + mail_op); + modest_mail_operation_sync_folder (mail_op, TNY_FOLDER (folder_store), FALSE); + g_object_unref (mail_op); + } + } +} + +static void +on_window_destroy (GtkObject *widget, + gpointer user_data) +{ + g_return_if_fail (MODEST_IS_MAIN_WINDOW (widget)); + + remove_banners (MODEST_MAIN_WINDOW (widget)); +} + +static gboolean +show_retrieving_banner (gpointer user_data) +{ + ModestMainWindowPrivate *priv = NULL; + + priv = MODEST_MAIN_WINDOW_GET_PRIVATE (user_data); + + if (priv->retrieving_banner == NULL) { + + /* We're outside the main lock */ + gdk_threads_enter (); + priv->retrieving_banner = + modest_platform_animation_banner (GTK_WIDGET (user_data), NULL, + _("mcen_ib_getting_items")); + gdk_threads_leave (); + } + + /* Remove timeout */ + priv->retrieving_banner_timeout = 0; + return FALSE; +}