X-Git-Url: http://git.maemo.org/git/?p=modest;a=blobdiff_plain;f=src%2Fmaemo%2Fmodest-msg-view-window.c;h=3a5f47e592c1488bdd65ac4b7bf98a6f8bbd7f96;hp=c3b2116c3678daf96bf620d6be0de72e66fcdbf5;hb=f9300629125062bd4d908bd1211a8b8f697adecf;hpb=917e780c80f0f00c2b22bc399b55e4ec58a255ad diff --git a/src/maemo/modest-msg-view-window.c b/src/maemo/modest-msg-view-window.c index c3b2116..3a5f47e 100644 --- a/src/maemo/modest-msg-view-window.c +++ b/src/maemo/modest-msg-view-window.c @@ -30,8 +30,10 @@ #include #include #include -#include +#include +#include #include +#include "modest-marshal.h" #include "modest-platform.h" #include #include @@ -51,6 +53,7 @@ #include #include "modest-ui-dimming-manager.h" #include +#include #define DEFAULT_FOLDER "MyDocs/.documents" @@ -93,6 +96,10 @@ static void on_queue_changed (ModestMailOperationQue ModestMailOperation *mail_op, ModestMailOperationQueueNotification type, ModestMsgViewWindow *self); +static void on_account_removed (ModestAccountMgr *obj, + const gchar *account, + gboolean server_account, + gpointer user_data); static void view_msg_cb (ModestMailOperation *mail_op, TnyHeader *header, TnyMsg *msg, gpointer user_data); @@ -101,19 +108,17 @@ static void set_toolbar_mode (ModestMsgViewWindow *self, static gboolean set_toolbar_transfer_mode (ModestMsgViewWindow *self); - static void update_window_title (ModestMsgViewWindow *window); /* list my signals */ enum { - /* MY_SIGNAL_1, */ - /* MY_SIGNAL_2, */ + MSG_CHANGED_SIGNAL, LAST_SIGNAL }; static const GtkToggleActionEntry msg_view_toggle_action_entries [] = { - { "FindInMessage", GTK_STOCK_FIND, N_("qgn_toolb_gene_find"), NULL, NULL, G_CALLBACK (modest_msg_view_window_toggle_find_toolbar), FALSE }, + { "FindInMessage", MODEST_TOOLBAR_ICON_FIND, N_("qgn_toolb_gene_find"), NULL, NULL, G_CALLBACK (modest_msg_view_window_toggle_find_toolbar), FALSE }, { "ToolsFindInMessage", NULL, N_("mcen_me_viewer_find"), NULL, NULL, G_CALLBACK (modest_msg_view_window_toggle_find_toolbar), FALSE }, }; @@ -150,9 +155,11 @@ struct _ModestMsgViewWindowPrivate { GtkTreeModel *header_model; GtkTreeRowReference *row_reference; + GtkTreeRowReference *next_row_reference; guint clipboard_change_handler; guint queue_change_handler; + guint account_removed_handler; guint progress_bar_timeout; @@ -166,7 +173,7 @@ struct _ModestMsgViewWindowPrivate { static GtkWindowClass *parent_class = NULL; /* uncomment the following if you have defined any signals */ -/* static guint signals[LAST_SIGNAL] = {0}; */ +static guint signals[LAST_SIGNAL] = {0}; GType modest_msg_view_window_get_type (void) @@ -229,6 +236,15 @@ modest_msg_view_window_class_init (ModestMsgViewWindowClass *klass) g_type_class_add_private (gobject_class, sizeof(ModestMsgViewWindowPrivate)); modest_window_class->save_state_func = save_state; + + signals[MSG_CHANGED_SIGNAL] = + g_signal_new ("msg-changed", + G_TYPE_FROM_CLASS (gobject_class), + G_SIGNAL_RUN_FIRST, + G_STRUCT_OFFSET (ModestMsgViewWindowClass, msg_changed), + NULL, NULL, + modest_marshal_VOID__POINTER_POINTER, + G_TYPE_NONE, 2, G_TYPE_POINTER, G_TYPE_POINTER); } static void @@ -240,6 +256,8 @@ modest_msg_view_window_init (ModestMsgViewWindow *obj) priv->msg_view = NULL; priv->header_model = NULL; priv->clipboard_change_handler = 0; + priv->queue_change_handler = 0; + priv->account_removed_handler = 0; priv->current_toolbar_mode = TOOLBAR_MODE_NORMAL; priv->optimized_view = FALSE; @@ -403,19 +421,20 @@ init_window (ModestMsgViewWindow *obj, TnyMsg *msg) priv->main_scroll = gtk_scrolled_window_new (NULL, NULL); gtk_scrolled_window_set_policy (GTK_SCROLLED_WINDOW (priv->main_scroll), GTK_POLICY_NEVER, GTK_POLICY_AUTOMATIC); gtk_scrolled_window_set_shadow_type (GTK_SCROLLED_WINDOW (priv->main_scroll), GTK_SHADOW_NONE); + modest_maemo_set_thumbable_scrollbar (GTK_SCROLLED_WINDOW(priv->main_scroll), TRUE); gtk_container_add (GTK_CONTAINER (priv->main_scroll), priv->msg_view); gtk_box_pack_start (GTK_BOX(main_vbox), priv->main_scroll, TRUE, TRUE, 0); gtk_container_add (GTK_CONTAINER(obj), main_vbox); priv->find_toolbar = hildon_find_toolbar_new (NULL); + hildon_window_add_toolbar (HILDON_WINDOW (obj), GTK_TOOLBAR (priv->find_toolbar)); gtk_widget_set_no_show_all (priv->find_toolbar, TRUE); g_signal_connect (G_OBJECT (priv->find_toolbar), "close", G_CALLBACK (modest_msg_view_window_find_toolbar_close), obj); g_signal_connect (G_OBJECT (priv->find_toolbar), "search", G_CALLBACK (modest_msg_view_window_find_toolbar_search), obj); priv->clipboard_change_handler = g_signal_connect (G_OBJECT (gtk_clipboard_get (GDK_SELECTION_PRIMARY)), "owner-change", G_CALLBACK (modest_msg_view_window_clipboard_owner_change), obj); gtk_widget_show_all (GTK_WIDGET(main_vbox)); - gtk_box_pack_end (GTK_BOX (main_vbox), priv->find_toolbar, FALSE, FALSE, 0); } @@ -434,13 +453,15 @@ modest_msg_view_window_finalize (GObject *obj) g_signal_handler_disconnect (G_OBJECT (modest_runtime_get_mail_operation_queue ()), priv->queue_change_handler); priv->queue_change_handler = 0; } + if (priv->account_removed_handler > 0) { + g_signal_handler_disconnect (G_OBJECT (modest_runtime_get_account_mgr ()), priv->account_removed_handler); + priv->account_removed_handler = 0; + } if (priv->header_model != NULL) { g_object_unref (priv->header_model); priv->header_model = NULL; } - /* disconnet operations queue observer */ - if (priv->progress_bar_timeout > 0) { g_source_remove (priv->progress_bar_timeout); priv->progress_bar_timeout = 0; @@ -451,6 +472,11 @@ modest_msg_view_window_finalize (GObject *obj) priv->row_reference = NULL; } + if (priv->next_row_reference) { + gtk_tree_row_reference_free (priv->next_row_reference); + priv->next_row_reference = NULL; + } + if (priv->msg_uid) { g_free (priv->msg_uid); priv->msg_uid = NULL; @@ -459,18 +485,45 @@ modest_msg_view_window_finalize (GObject *obj) G_OBJECT_CLASS(parent_class)->finalize (obj); } - - static gboolean -on_delete_event (GtkWidget *widget, GdkEvent *event, ModestMsgViewWindow *self) +select_next_valid_row (GtkTreeModel *model, + GtkTreeRowReference **row_reference, + gboolean cycle) { - modest_window_save_state (MODEST_WINDOW (self)); - return FALSE; + GtkTreeIter tmp_iter; + GtkTreePath *path, *next; + gboolean retval = FALSE; + + g_return_val_if_fail (gtk_tree_row_reference_valid (*row_reference), FALSE); + + path = gtk_tree_row_reference_get_path (*row_reference); + gtk_tree_model_get_iter (model, &tmp_iter, path); + gtk_tree_row_reference_free (*row_reference); + *row_reference = NULL; + + if (gtk_tree_model_iter_next (model, &tmp_iter)) { + next = gtk_tree_model_get_path (model, &tmp_iter); + *row_reference = gtk_tree_row_reference_new (model, next); + retval = TRUE; + } else if (cycle && gtk_tree_model_get_iter_first (model, &tmp_iter)) { + next = gtk_tree_model_get_path (model, &tmp_iter); + + /* Ensure that we are not selecting the same */ + if (gtk_tree_path_compare (path, next) != 0) { + *row_reference = gtk_tree_row_reference_new (model, next); + retval = TRUE; + } + } + + /* Free */ + gtk_tree_path_free (path); + + return retval; } ModestWindow * modest_msg_view_window_new_with_header_model (TnyMsg *msg, - const gchar *account_name, + const gchar *modest_account_name, const gchar *msg_uid, GtkTreeModel *model, GtkTreeRowReference *row_reference) @@ -478,7 +531,7 @@ modest_msg_view_window_new_with_header_model (TnyMsg *msg, ModestMsgViewWindow *window = NULL; ModestMsgViewWindowPrivate *priv = NULL; - window = MODEST_MSG_VIEW_WINDOW(modest_msg_view_window_new (msg, account_name, msg_uid)); + window = MODEST_MSG_VIEW_WINDOW(modest_msg_view_window_new (msg, modest_account_name, msg_uid)); g_return_val_if_fail (MODEST_IS_MSG_VIEW_WINDOW (window), NULL); priv = MODEST_MSG_VIEW_WINDOW_GET_PRIVATE (window); @@ -486,6 +539,8 @@ modest_msg_view_window_new_with_header_model (TnyMsg *msg, g_object_ref (model); priv->header_model = model; priv->row_reference = gtk_tree_row_reference_copy (row_reference); + priv->next_row_reference = gtk_tree_row_reference_copy (row_reference); + select_next_valid_row (model, &(priv->next_row_reference), TRUE); modest_msg_view_window_update_priority (window); @@ -498,7 +553,7 @@ modest_msg_view_window_new_with_header_model (TnyMsg *msg, ModestWindow * modest_msg_view_window_new (TnyMsg *msg, - const gchar *account_name, + const gchar *modest_account_name, const gchar *msg_uid) { ModestMsgViewWindow *self = NULL; @@ -509,7 +564,7 @@ modest_msg_view_window_new (TnyMsg *msg, ModestDimmingRulesGroup *toolbar_rules_group = NULL; GtkActionGroup *action_group = NULL; GError *error = NULL; - GdkPixbuf *window_icon = NULL; + GdkPixbuf *window_icon; g_return_val_if_fail (msg, NULL); @@ -526,8 +581,8 @@ modest_msg_view_window_new (TnyMsg *msg, action_group = gtk_action_group_new ("ModestMsgViewWindowActions"); gtk_action_group_set_translation_domain (action_group, GETTEXT_PACKAGE); - menu_rules_group = modest_dimming_rules_group_new ("ModestMenuDimmingRules"); - toolbar_rules_group = modest_dimming_rules_group_new ("ModestToolbarDimmingRules"); + menu_rules_group = modest_dimming_rules_group_new ("ModestMenuDimmingRules", FALSE); + toolbar_rules_group = modest_dimming_rules_group_new ("ModestToolbarDimmingRules", TRUE); /* Add common actions */ gtk_action_group_add_actions (action_group, @@ -586,7 +641,14 @@ modest_msg_view_window_new (TnyMsg *msg, init_window (MODEST_MSG_VIEW_WINDOW(obj), msg); restore_settings (MODEST_MSG_VIEW_WINDOW(obj)); - g_signal_connect (G_OBJECT(obj), "delete-event", G_CALLBACK(on_delete_event), obj); + /* Set window icon */ + window_icon = modest_platform_get_icon (MODEST_APP_MSG_VIEW_ICON); + if (window_icon) { + gtk_window_set_icon (GTK_WINDOW (obj), window_icon); + g_object_unref (window_icon); + } + + /* g_signal_connect (G_OBJECT(obj), "delete-event", G_CALLBACK(on_delete_event), obj); */ g_signal_connect (G_OBJECT(priv->msg_view), "link_clicked", G_CALLBACK (modest_ui_actions_on_msg_link_clicked), obj); @@ -613,14 +675,15 @@ modest_msg_view_window_new (TnyMsg *msg, G_CALLBACK (on_queue_changed), obj); - modest_window_set_active_account (MODEST_WINDOW(obj), account_name); - - priv->last_search = NULL; + /* Account manager */ + priv->account_removed_handler = g_signal_connect (G_OBJECT(modest_runtime_get_account_mgr()), + "account-removed", + G_CALLBACK(on_account_removed), + obj); + modest_window_set_active_account (MODEST_WINDOW(obj), modest_account_name); - /* Set window icon */ - window_icon = modest_platform_get_icon (MODEST_APP_MSG_VIEW_ICON); - gtk_window_set_icon (GTK_WINDOW (obj), window_icon); + priv->last_search = NULL; /* Init the clipboard actions dim status */ modest_msg_view_grab_focus(MODEST_MSG_VIEW (priv->msg_view)); @@ -651,6 +714,7 @@ modest_msg_view_window_get_header (ModestMsgViewWindow *self) ModestMsgViewWindowPrivate *priv= NULL; TnyMsg *msg = NULL; TnyHeader *header = NULL; + GtkTreePath *path = NULL; GtkTreeIter iter; g_return_val_if_fail (MODEST_IS_MSG_VIEW_WINDOW (self), NULL); @@ -665,15 +729,18 @@ modest_msg_view_window_get_header (ModestMsgViewWindow *self) } /* Get current message iter */ + path = gtk_tree_row_reference_get_path (priv->row_reference); + g_return_val_if_fail (path != NULL, NULL); gtk_tree_model_get_iter (priv->header_model, &iter, - gtk_tree_row_reference_get_path (priv->row_reference)); + path); /* Get current message header */ gtk_tree_model_get (priv->header_model, &iter, TNY_GTK_HEADER_LIST_MODEL_INSTANCE_COLUMN, &header, -1); + gtk_tree_path_free (path); return header; } @@ -695,32 +762,15 @@ modest_msg_view_window_get_message (ModestMsgViewWindow *self) const gchar* modest_msg_view_window_get_message_uid (ModestMsgViewWindow *self) { - ModestMsgViewWindowPrivate *priv = MODEST_MSG_VIEW_WINDOW_GET_PRIVATE (self); - return (const gchar*) priv->msg_uid; -} - -static void -toggle_action_set_active_block_notify (GtkToggleAction *action, - gboolean value) -{ - GSList *proxies = NULL; - - for (proxies = gtk_action_get_proxies (GTK_ACTION (action)); - proxies != NULL; proxies = g_slist_next (proxies)) { - GtkWidget *widget = (GtkWidget *) proxies->data; - gtk_action_block_activate_from (GTK_ACTION (action), widget); - } + ModestMsgViewWindowPrivate *priv; - gtk_toggle_action_set_active (action, value); + g_return_val_if_fail (self, NULL); + + priv = MODEST_MSG_VIEW_WINDOW_GET_PRIVATE (self); - for (proxies = gtk_action_get_proxies (GTK_ACTION (action)); - proxies != NULL; proxies = g_slist_next (proxies)) { - GtkWidget *widget = (GtkWidget *) proxies->data; - gtk_action_unblock_activate_from (GTK_ACTION (action), widget); - } + return (const gchar*) priv->msg_uid; } - static void modest_msg_view_window_toggle_find_toolbar (GtkToggleAction *toggle, gpointer data) @@ -742,9 +792,9 @@ modest_msg_view_window_toggle_find_toolbar (GtkToggleAction *toggle, /* update the toggle buttons status */ action = gtk_ui_manager_get_action (parent_priv->ui_manager, "/ToolBar/FindInMessage"); - toggle_action_set_active_block_notify (GTK_TOGGLE_ACTION (action), is_active); + modest_maemo_toggle_action_set_active_block_notify (GTK_TOGGLE_ACTION (action), is_active); action = gtk_ui_manager_get_action (parent_priv->ui_manager, "/MenuBar/ToolsMenu/ToolsFindInMessageMenu"); - toggle_action_set_active_block_notify (GTK_TOGGLE_ACTION (action), is_active); + modest_maemo_toggle_action_set_active_block_notify (GTK_TOGGLE_ACTION (action), is_active); } @@ -767,6 +817,11 @@ modest_msg_view_window_find_toolbar_search (GtkWidget *widget, gchar *current_search; ModestMsgViewWindowPrivate *priv = MODEST_MSG_VIEW_WINDOW_GET_PRIVATE (obj); + if (modest_msg_view_get_message_is_empty (MODEST_MSG_VIEW (priv->msg_view))) { + hildon_banner_show_information (NULL, NULL, _("mail_ib_nothing_to_find")); + return; + } + g_object_get (G_OBJECT (widget), "prefix", ¤t_search, NULL); if ((current_search == NULL) || (strcmp (current_search, "") == 0)) { @@ -783,6 +838,8 @@ modest_msg_view_window_find_toolbar_search (GtkWidget *widget, priv->last_search); if (!result) { hildon_banner_show_information (NULL, NULL, dgettext("hildon-libs", "ckct_ib_find_no_matches")); + g_free (priv->last_search); + priv->last_search = NULL; } } else { if (!modest_msg_view_search_next (MODEST_MSG_VIEW (priv->msg_view))) { @@ -902,18 +959,20 @@ static void modest_msg_view_window_scroll_up (ModestWindow *window) { ModestMsgViewWindowPrivate *priv; + gboolean return_value; priv = MODEST_MSG_VIEW_WINDOW_GET_PRIVATE (window); - g_signal_emit_by_name (G_OBJECT (priv->main_scroll), "scroll-child", GTK_SCROLL_STEP_UP, FALSE); + g_signal_emit_by_name (G_OBJECT (priv->main_scroll), "scroll-child", GTK_SCROLL_STEP_UP, FALSE, &return_value); } static void modest_msg_view_window_scroll_down (ModestWindow *window) { ModestMsgViewWindowPrivate *priv; + gboolean return_value; priv = MODEST_MSG_VIEW_WINDOW_GET_PRIVATE (window); - g_signal_emit_by_name (G_OBJECT (priv->main_scroll), "scroll-child", GTK_SCROLL_STEP_DOWN, FALSE); + g_signal_emit_by_name (G_OBJECT (priv->main_scroll), "scroll-child", GTK_SCROLL_STEP_DOWN, FALSE, &return_value); } gboolean @@ -929,8 +988,7 @@ modest_msg_view_window_last_message_selected (ModestMsgViewWindow *window) if (priv->header_model) { path = gtk_tree_row_reference_get_path (priv->row_reference); - if (!path) - return TRUE; + if (path == NULL) return FALSE; while (!has_next) { TnyHeader *header; gtk_tree_path_next (path); @@ -1008,6 +1066,7 @@ modest_msg_view_window_first_message_selected (ModestMsgViewWindow *window) } g_free (path_string); } + gtk_tree_path_free (path); return result; } else { return TRUE; @@ -1015,72 +1074,117 @@ modest_msg_view_window_first_message_selected (ModestMsgViewWindow *window) } +/** + * Reads the message whose summary item is @header. It takes care of + * several things, among others: + * + * If the message was not previously downloaded then ask the user + * before downloading. If there is no connection launch the connection + * dialog. Update toolbar dimming rules. + * + * Returns: TRUE if the mail operation was started, otherwise if the + * user do not want to download the message, or if the user do not + * want to connect, then the operation is not issued + **/ +static gboolean +message_reader (ModestMsgViewWindow *window, + ModestMsgViewWindowPrivate *priv, + TnyHeader *header, + GtkTreePath *path) +{ + ModestMailOperation *mail_op = NULL; + ModestMailOperationTypeOperation op_type; + + g_return_val_if_fail (path != NULL, FALSE); + + /* Msg download completed */ + if (tny_header_get_flags (header) & TNY_HEADER_FLAG_CACHED) { + op_type = MODEST_MAIL_OPERATION_TYPE_OPEN; + } else { + TnyFolder *folder; + GtkResponseType response; + + op_type = MODEST_MAIL_OPERATION_TYPE_RECEIVE; + + /* Ask the user if he wants to download the message */ + response = modest_platform_run_confirmation_dialog (GTK_WINDOW (window), + _("mcen_nc_get_msg")); + if (response == GTK_RESPONSE_CANCEL) + return FALSE; + + /* Offer the connection dialog if necessary */ + /* FIXME: should this stuff go directly to the mail + operation instead of spread it all over the + code? */ + folder = tny_header_get_folder (header); + if (folder) { + if (!modest_platform_connect_and_wait_if_network_folderstore (NULL, TNY_FOLDER_STORE (folder))) { + g_object_unref (folder); + return FALSE; + } + g_object_unref (folder); + } + } + + /* New mail operation */ + mail_op = modest_mail_operation_new_with_error_handling (op_type, + G_OBJECT(window), + modest_ui_actions_get_msgs_full_error_handler, + NULL); + + modest_mail_operation_queue_add (modest_runtime_get_mail_operation_queue (), mail_op); + modest_mail_operation_get_msg (mail_op, header, view_msg_cb, path); + g_object_unref (mail_op); + + /* Update toolbar dimming rules */ + modest_ui_actions_check_toolbar_dimming_rules (MODEST_WINDOW (window)); + + return TRUE; +} + gboolean modest_msg_view_window_select_next_message (ModestMsgViewWindow *window) { - TnyHeaderFlags flags; - ModestMailOperation *mail_op = NULL; ModestMsgViewWindowPrivate *priv; + GtkTreePath *path= NULL; GtkTreeIter tmp_iter; + TnyHeader *header; + gboolean retval = TRUE; g_return_val_if_fail (MODEST_IS_MSG_VIEW_WINDOW (window), FALSE); priv = MODEST_MSG_VIEW_WINDOW_GET_PRIVATE (window); - if (priv->header_model) { - gtk_tree_model_get_iter (priv->header_model, - &tmp_iter, - gtk_tree_row_reference_get_path (priv->row_reference)); - while (gtk_tree_model_iter_next (priv->header_model, &tmp_iter)) { - TnyHeader *header; - GtkTreePath *path; - - gtk_tree_model_get (priv->header_model, &tmp_iter, TNY_GTK_HEADER_LIST_MODEL_INSTANCE_COLUMN, - &header, -1); - if (!header) - break; - if (tny_header_get_flags (header) & TNY_HEADER_FLAG_DELETED) - continue; - - /* Update the row reference */ - gtk_tree_row_reference_free (priv->row_reference); - path = gtk_tree_model_get_path (priv->header_model, &tmp_iter); - priv->row_reference = gtk_tree_row_reference_new (priv->header_model, path); - gtk_tree_path_free (path); + path = gtk_tree_row_reference_get_path (priv->next_row_reference); + if (path == NULL) + return FALSE; - /* Mark as read */ - flags = tny_header_get_flags (header); - if (!(flags & TNY_HEADER_FLAG_SEEN)) - tny_header_set_flags (header, TNY_HEADER_FLAG_SEEN); + gtk_tree_model_get_iter (priv->header_model, + &tmp_iter, + path); - /* Msg download completed */ - if (flags & TNY_HEADER_FLAG_CACHED) - mail_op = modest_mail_operation_new (MODEST_MAIL_OPERATION_TYPE_OPEN, G_OBJECT(window)); - else - mail_op = modest_mail_operation_new (MODEST_MAIL_OPERATION_TYPE_RECEIVE, G_OBJECT(window)); - - /* New mail operation */ - modest_mail_operation_queue_add (modest_runtime_get_mail_operation_queue (), mail_op); - modest_mail_operation_get_msg (mail_op, header, view_msg_cb, NULL); - g_object_unref (mail_op); + gtk_tree_model_get (priv->header_model, &tmp_iter, + TNY_GTK_HEADER_LIST_MODEL_INSTANCE_COLUMN, + &header, -1); + + /* Read the message & show it */ + if (!message_reader (window, priv, header, path)) { + retval = FALSE; + gtk_tree_path_free (path); + } - /* Update toolbar dimming rules */ - modest_ui_actions_check_toolbar_dimming_rules (MODEST_WINDOW (window)); + /* Free */ + g_object_unref (header); - return TRUE; - } - } - return FALSE; + return retval; } gboolean modest_msg_view_window_select_first_message (ModestMsgViewWindow *self) { ModestMsgViewWindowPrivate *priv = NULL; - ModestMailOperation *mail_op = NULL; TnyHeader *header = NULL; - TnyHeaderFlags flags; - GtkTreePath *path = NULL; GtkTreeIter iter; + GtkTreePath *path; g_return_val_if_fail (MODEST_IS_MSG_VIEW_WINDOW (self), FALSE); priv = MODEST_MSG_VIEW_WINDOW_GET_PRIVATE (self); @@ -1094,37 +1198,16 @@ modest_msg_view_window_select_first_message (ModestMsgViewWindow *self) &iter, TNY_GTK_HEADER_LIST_MODEL_INSTANCE_COLUMN, &header, -1); - g_return_val_if_fail (TNY_IS_HEADER (header), FALSE); if (tny_header_get_flags (header) & TNY_HEADER_FLAG_DELETED) { g_object_unref (header); return modest_msg_view_window_select_next_message (self); } - /* Update the row reference */ - gtk_tree_row_reference_free (priv->row_reference); - path = gtk_tree_path_new_first (); - priv->row_reference = gtk_tree_row_reference_new (priv->header_model, path); - gtk_tree_path_free (path); - - /* Mark as read */ - flags = tny_header_get_flags (header); - if (!(flags & TNY_HEADER_FLAG_SEEN)) - tny_header_set_flags (header, TNY_HEADER_FLAG_SEEN); - - /* Msg download completed */ - if (flags & TNY_HEADER_FLAG_CACHED) - mail_op = modest_mail_operation_new (MODEST_MAIL_OPERATION_TYPE_OPEN, G_OBJECT(self)); - else - mail_op = modest_mail_operation_new (MODEST_MAIL_OPERATION_TYPE_RECEIVE, G_OBJECT(self)); + path = gtk_tree_model_get_path (priv->header_model, &iter); - /* New mail operation */ - modest_mail_operation_queue_add (modest_runtime_get_mail_operation_queue (), mail_op); - modest_mail_operation_get_msg (mail_op, header, view_msg_cb, NULL); - g_object_unref (mail_op); - - /* Update toolbar dimming rules */ - modest_ui_actions_check_toolbar_dimming_rules (MODEST_WINDOW (self)); + /* Read the message & show it */ + message_reader (self, priv, header, path); /* Free */ g_object_unref (header); @@ -1135,10 +1218,8 @@ modest_msg_view_window_select_first_message (ModestMsgViewWindow *self) gboolean modest_msg_view_window_select_previous_message (ModestMsgViewWindow *window) { - TnyHeaderFlags flags; ModestMsgViewWindowPrivate *priv = NULL; GtkTreePath *path; - ModestMailOperation *mail_op = NULL; g_return_val_if_fail (MODEST_IS_MSG_VIEW_WINDOW (window), FALSE); priv = MODEST_MSG_VIEW_WINDOW_GET_PRIVATE (window); @@ -1163,33 +1244,18 @@ modest_msg_view_window_select_previous_message (ModestMsgViewWindow *window) continue; } - /* Update the row reference */ - gtk_tree_row_reference_free (priv->row_reference); - priv->row_reference = gtk_tree_row_reference_new (priv->header_model, path); - - /* Mark as read */ - flags = tny_header_get_flags (header); - if (!(flags & TNY_HEADER_FLAG_SEEN)) - tny_header_set_flags (header, TNY_HEADER_FLAG_SEEN); - - /* Msg download completed */ - if (flags & TNY_HEADER_FLAG_CACHED) - mail_op = modest_mail_operation_new (MODEST_MAIL_OPERATION_TYPE_OPEN, G_OBJECT(window)); - else - mail_op = modest_mail_operation_new (MODEST_MAIL_OPERATION_TYPE_RECEIVE, G_OBJECT(window)); - - /* New mail operation */ - modest_mail_operation_queue_add (modest_runtime_get_mail_operation_queue (), mail_op); - modest_mail_operation_get_msg (mail_op, header, view_msg_cb, NULL); - - /* Update toolbar dimming rules */ - modest_ui_actions_check_toolbar_dimming_rules (MODEST_WINDOW (window)); + /* Read the message & show it */ + if (!message_reader (window, priv, header, path)) { + g_object_unref (header); + break; + } g_object_unref (header); return TRUE; } + gtk_tree_path_free (path); return FALSE; } @@ -1201,21 +1267,47 @@ view_msg_cb (ModestMailOperation *mail_op, { ModestMsgViewWindow *self = NULL; ModestMsgViewWindowPrivate *priv = NULL; + GtkTreePath *path; - g_return_if_fail (TNY_IS_MSG (msg)); + /* If there was any error */ + path = (GtkTreePath *) user_data; + if (!modest_ui_actions_msg_retrieval_check (mail_op, header, msg)) { + gtk_tree_path_free (path); + return; + } /* Get the window */ self = (ModestMsgViewWindow *) modest_mail_operation_get_source (mail_op); g_return_if_fail (MODEST_IS_MSG_VIEW_WINDOW (self)); - priv = MODEST_MSG_VIEW_WINDOW_GET_PRIVATE (self); + /* Update the row reference */ + gtk_tree_row_reference_free (priv->row_reference); + priv->row_reference = gtk_tree_row_reference_new (priv->header_model, path); + priv->next_row_reference = gtk_tree_row_reference_copy (priv->row_reference); + select_next_valid_row (priv->header_model, &(priv->next_row_reference), TRUE); + gtk_tree_path_free (path); + + /* Mark header as read */ + if (!(tny_header_get_flags (header) & TNY_HEADER_FLAG_SEEN)) + tny_header_set_flags (header, TNY_HEADER_FLAG_SEEN); + /* Set new message */ modest_msg_view_set_message (MODEST_MSG_VIEW (priv->msg_view), msg); modest_msg_view_window_update_priority (self); update_window_title (MODEST_MSG_VIEW_WINDOW (self)); modest_msg_view_grab_focus (MODEST_MSG_VIEW (priv->msg_view)); + /* Set the new message uid of the window */ + if (priv->msg_uid) { + g_free (priv->msg_uid); + priv->msg_uid = modest_tny_folder_get_header_unique_id (header); + } + + /* Notify the observers */ + g_signal_emit (G_OBJECT (self), signals[MSG_CHANGED_SIGNAL], + 0, priv->header_model, priv->row_reference); + /* Free new references */ g_object_unref (self); } @@ -1265,7 +1357,10 @@ modest_msg_view_window_update_priority (ModestMsgViewWindow *window) if (priv->header_model) { TnyHeader *header; GtkTreeIter iter; + GtkTreePath *path = NULL; + path = gtk_tree_row_reference_get_path (priv->row_reference); + g_return_if_fail (path != NULL); gtk_tree_model_get_iter (priv->header_model, &iter, gtk_tree_row_reference_get_path (priv->row_reference)); @@ -1273,6 +1368,7 @@ modest_msg_view_window_update_priority (ModestMsgViewWindow *window) gtk_tree_model_get (priv->header_model, &iter, TNY_GTK_HEADER_LIST_MODEL_INSTANCE_COLUMN, &header, -1); flags = tny_header_get_flags (header); + gtk_tree_path_free (path); } modest_msg_view_set_priority (MODEST_MSG_VIEW(priv->msg_view), flags); @@ -1414,10 +1510,13 @@ modest_msg_view_window_clipboard_owner_change (GtkClipboard *clipboard, gchar *selection; GtkWidget *focused; + if (!GTK_WIDGET_VISIBLE (window)) + return; + parent_priv = MODEST_WINDOW_GET_PRIVATE (window); selection = gtk_clipboard_wait_for_text (clipboard); - is_address = ((selection != NULL) && (modest_text_utils_validate_recipient (selection))); + is_address = ((selection != NULL) && (modest_text_utils_validate_recipient (selection, NULL))); /* action = gtk_ui_manager_get_action (parent_priv->ui_manager, "/MenuBar/ToolsMenu/ToolsAddToContactsMenu"); */ /* gtk_action_set_sensitive (action, is_address); */ @@ -1484,6 +1583,25 @@ observers_empty (ModestMsgViewWindow *self) return is_empty; } +static void +on_account_removed (ModestAccountMgr *mgr, + const gchar *account, + gboolean server_account, + gpointer user_data) +{ + ModestTnyAccountStore *store = modest_runtime_get_account_store (); + const gchar *our_acc = modest_window_get_active_account (MODEST_WINDOW (user_data)); + + TnyAccount *tny_acc = modest_tny_account_store_get_tny_account_by (store, MODEST_TNY_ACCOUNT_STORE_QUERY_ID, account); + if(tny_acc != NULL) + { + const gchar* parent_acc = modest_tny_account_get_parent_modest_account_name_for_server_account (tny_acc); + if (strcmp (parent_acc, our_acc) == 0) + { + gtk_widget_destroy (GTK_WIDGET (user_data)); + } + } +} static void on_queue_changed (ModestMailOperationQueue *queue, @@ -1506,7 +1624,7 @@ on_queue_changed (ModestMailOperationQueue *queue, /* Get toolbar mode from operation id*/ op_type = modest_mail_operation_get_type_operation (mail_op); switch (op_type) { - case MODEST_MAIL_OPERATION_TYPE_SEND: +/* case MODEST_MAIL_OPERATION_TYPE_SEND: */ case MODEST_MAIL_OPERATION_TYPE_RECEIVE: case MODEST_MAIL_OPERATION_TYPE_OPEN: mode = TOOLBAR_MODE_TRANSFER; @@ -1593,6 +1711,12 @@ modest_msg_view_window_view_attachment (ModestMsgViewWindow *window, TnyMimePart g_object_ref (mime_part); } + if (tny_mime_part_is_purged (mime_part)) { + g_object_unref (mime_part); + hildon_banner_show_information (NULL, NULL, _("mail_ib_attach_not_local")); + return; + } + if (!TNY_IS_MSG (mime_part)) { gchar *filepath = NULL; const gchar *att_filename = tny_mime_part_get_filename (mime_part); @@ -1622,67 +1746,161 @@ modest_msg_view_window_view_attachment (ModestMsgViewWindow *window, TnyMimePart TnyHeader *header = NULL; ModestWindowMgr *mgr; ModestWindow *msg_win = NULL; - + gboolean found; + header = tny_msg_get_header (TNY_MSG (mime_part)); - mgr = modest_runtime_get_window_mgr (); - msg_win = modest_window_mgr_find_window_by_header (mgr, header); - - if (!msg_win) { + mgr = modest_runtime_get_window_mgr (); + found = modest_window_mgr_find_registered_header (mgr, header, &msg_win); + + if (found) { + if (msg_win) /* there is already a window for this uid; top it */ + gtk_window_present (GTK_WINDOW(msg_win)); + else + /* if it's found, but there is no msg_win, it's probably in the process of being created; + * thus, we don't do anything */ + g_warning ("window for is already being created"); + } else { + /* it's not found, so create a new window for it */ + modest_window_mgr_register_header (mgr, header); /* register the uid before building the window */ gchar *account = g_strdup (modest_window_get_active_account (MODEST_WINDOW (window))); if (!account) account = modest_account_mgr_get_default_account (modest_runtime_get_account_mgr ()); msg_win = modest_msg_view_window_new (TNY_MSG (mime_part), account, NULL); modest_window_mgr_register_window (mgr, msg_win); gtk_window_set_transient_for (GTK_WINDOW (msg_win), GTK_WINDOW (window)); + gtk_widget_show_all (GTK_WIDGET (msg_win)); } - - gtk_widget_show_all (GTK_WIDGET (msg_win)); } g_object_unref (mime_part); } +typedef struct +{ + gchar *filename; + TnyMimePart *part; +} SaveMimePartPair; + +typedef struct +{ + GList *pairs; + GtkWidget *banner; + gboolean result; +} SaveMimePartInfo; + +static void save_mime_part_info_free (SaveMimePartInfo *info, gboolean with_struct); +static gboolean idle_save_mime_part_show_result (SaveMimePartInfo *info); +static gpointer save_mime_part_to_file (SaveMimePartInfo *info); +static void save_mime_parts_to_file_with_checks (SaveMimePartInfo *info); + +static void +save_mime_part_info_free (SaveMimePartInfo *info, gboolean with_struct) +{ + + GList *node; + for (node = info->pairs; node != NULL; node = g_list_next (node)) { + SaveMimePartPair *pair = (SaveMimePartPair *) node->data; + g_free (pair->filename); + g_object_unref (pair->part); + g_slice_free (SaveMimePartPair, pair); + } + g_list_free (info->pairs); + info->pairs = NULL; + if (with_struct) { + gtk_widget_destroy (info->banner); + g_object_unref (info->banner); + g_slice_free (SaveMimePartInfo, info); + } +} + static gboolean -save_mime_part_to_file (const gchar *filename, TnyMimePart *mime_part) +idle_save_mime_part_show_result (SaveMimePartInfo *info) +{ + if (info->pairs != NULL) { + gdk_threads_enter (); + save_mime_parts_to_file_with_checks (info); + gdk_threads_leave (); + } else { + gboolean result; + result = info->result; + + gdk_threads_enter (); + save_mime_part_info_free (info, TRUE); + if (result) { + hildon_banner_show_information (NULL, NULL, _CS("sfil_ib_saved")); + } else { + hildon_banner_show_information (NULL, NULL, _("mail_ib_file_operation_failed")); + } + gdk_threads_leave (); + } + + return FALSE; +} + +static gpointer +save_mime_part_to_file (SaveMimePartInfo *info) { GnomeVFSResult result; GnomeVFSHandle *handle; TnyStream *stream; - - result = gnome_vfs_create (&handle, filename, GNOME_VFS_OPEN_WRITE, FALSE, 0777); - if (result != GNOME_VFS_OK) { - hildon_banner_show_information (NULL, NULL, _("mail_ib_file_operation_failed")); - return FALSE; + SaveMimePartPair *pair = (SaveMimePartPair *) info->pairs->data; + + result = gnome_vfs_create (&handle, pair->filename, GNOME_VFS_OPEN_WRITE, FALSE, 0777); + if (result == GNOME_VFS_OK) { + stream = tny_vfs_stream_new (handle); + tny_mime_part_decode_to_stream (pair->part, stream); + g_object_unref (G_OBJECT (stream)); + g_object_unref (pair->part); + g_slice_free (SaveMimePartPair, pair); + info->pairs = g_list_delete_link (info->pairs, info->pairs); + info->result = TRUE; + } else { + save_mime_part_info_free (info, FALSE); + info->result = FALSE; } - stream = tny_vfs_stream_new (handle); - tny_mime_part_decode_to_stream (mime_part, stream); - g_object_unref (G_OBJECT (stream)); - return TRUE; + + g_idle_add ((GSourceFunc) idle_save_mime_part_show_result, info); + return NULL; } -static gboolean -save_mime_part_to_file_with_checks (GtkWindow *parent, const gchar *filename, TnyMimePart *mime_part) +static void +save_mime_parts_to_file_with_checks (SaveMimePartInfo *info) { - if (modest_maemo_utils_file_exists (filename)) { + SaveMimePartPair *pair; + gboolean is_ok = TRUE; + + pair = info->pairs->data; + if (modest_maemo_utils_file_exists (pair->filename)) { GtkWidget *confirm_overwrite_dialog; - confirm_overwrite_dialog = hildon_note_new_confirmation (GTK_WINDOW (parent), + confirm_overwrite_dialog = hildon_note_new_confirmation (NULL, _("emev_nc_replace_files")); if (gtk_dialog_run (GTK_DIALOG (confirm_overwrite_dialog)) != GTK_RESPONSE_OK) { - gtk_widget_destroy (confirm_overwrite_dialog); - return FALSE; + is_ok = FALSE; } gtk_widget_destroy (confirm_overwrite_dialog); } - return save_mime_part_to_file (filename, mime_part); + if (!is_ok) { + save_mime_part_info_free (info, TRUE); + } else { + g_thread_create ((GThreadFunc)save_mime_part_to_file, info, FALSE, NULL); + } + } + void modest_msg_view_window_save_attachments (ModestMsgViewWindow *window, GList *mime_parts) { gboolean clean_list = FALSE; ModestMsgViewWindowPrivate *priv; - g_return_if_fail (MODEST_IS_MSG_VIEW_WINDOW (window)); + GList *files_to_save = NULL; + GtkWidget *save_dialog = NULL; + gchar *folder = NULL; + gboolean canceled = FALSE; + const gchar *filename = NULL; + gchar *save_multiple_str = NULL; + g_return_if_fail (MODEST_IS_MSG_VIEW_WINDOW (window)); priv = MODEST_MSG_VIEW_WINDOW_GET_PRIVATE (window); if (mime_parts == NULL) { @@ -1692,91 +1910,96 @@ modest_msg_view_window_save_attachments (ModestMsgViewWindow *window, GList *mim clean_list = TRUE; } + /* prepare dialog */ if (mime_parts->next == NULL) { /* only one attachment selected */ - GtkWidget *save_dialog = NULL; TnyMimePart *mime_part = (TnyMimePart *) mime_parts->data; if (!TNY_IS_MSG (mime_part) && tny_mime_part_is_attachment (mime_part)) { - const gchar *filename; - gchar *folder; - save_dialog = hildon_file_chooser_dialog_new (GTK_WINDOW (window), GTK_FILE_CHOOSER_ACTION_SAVE); - folder = g_build_filename (g_get_home_dir (), DEFAULT_FOLDER, NULL); - gtk_file_chooser_set_current_folder (GTK_FILE_CHOOSER (save_dialog), folder); - g_free (folder); filename = tny_mime_part_get_filename (mime_part); - if (filename != NULL) - gtk_file_chooser_set_current_name (GTK_FILE_CHOOSER (save_dialog), filename); - while (gtk_dialog_run (GTK_DIALOG (save_dialog)) == GTK_RESPONSE_OK) { - gchar *filename_tmp = gtk_file_chooser_get_uri (GTK_FILE_CHOOSER (save_dialog)); - gboolean save_result; - if (!modest_maemo_utils_folder_writable (filename_tmp)) { - g_free (filename_tmp); - hildon_banner_show_information (NULL, NULL, _("TODO: read only location")); - continue; - } - save_result = save_mime_part_to_file_with_checks (GTK_WINDOW (save_dialog), - filename_tmp, mime_part); - g_free (filename_tmp); - if (save_result) - break; - else - continue; - } - gtk_widget_destroy (save_dialog); } else { g_warning ("Tried to save a non-file attachment"); + canceled = TRUE; } } else { - GtkWidget *save_dialog = NULL; - gchar *folder; - gchar *save_multiple_str = g_strdup_printf (_("FIXME: %d attachments"), - g_list_length (mime_parts)); - save_dialog = hildon_file_chooser_dialog_new (GTK_WINDOW (window), GTK_FILE_CHOOSER_ACTION_SAVE); + save_multiple_str = g_strdup_printf (_("FIXME: %d attachments"), + g_list_length (mime_parts)); + } + + save_dialog = hildon_file_chooser_dialog_new (GTK_WINDOW (window), + GTK_FILE_CHOOSER_ACTION_SAVE); + + /* set folder */ + folder = g_build_filename (g_get_home_dir (), DEFAULT_FOLDER, NULL); + gtk_file_chooser_set_current_folder (GTK_FILE_CHOOSER (save_dialog), folder); + g_free (folder); + + /* set filename */ + if (filename != NULL) + gtk_file_chooser_set_current_name (GTK_FILE_CHOOSER (save_dialog), + filename); + + /* if multiple, set multiple string */ + if (save_multiple_str) { g_object_set (G_OBJECT (save_dialog), "save-multiple", save_multiple_str, NULL); + } - folder = g_build_filename (g_get_home_dir (), DEFAULT_FOLDER, NULL); - gtk_file_chooser_set_current_folder (GTK_FILE_CHOOSER (save_dialog), folder); - g_free (folder); - if (gtk_dialog_run (GTK_DIALOG (save_dialog)) == GTK_RESPONSE_OK) { - gchar *foldername = gtk_file_chooser_get_uri (GTK_FILE_CHOOSER (save_dialog)); + /* show dialog */ + if (gtk_dialog_run (GTK_DIALOG (save_dialog)) == GTK_RESPONSE_OK) { + gchar *chooser_uri = gtk_file_chooser_get_uri (GTK_FILE_CHOOSER (save_dialog)); + + if (!modest_maemo_utils_folder_writable (chooser_uri)) { + hildon_banner_show_information + (NULL, NULL, dgettext("hildon-fm", "sfil_ib_readonly_location")); + } else { GList *node = NULL; - gboolean attachment_found = FALSE; - if (!modest_maemo_utils_folder_writable (foldername)) { - g_free (foldername); - hildon_banner_show_information (NULL, NULL, _("TODO: read only location")); - } + for (node = mime_parts; node != NULL; node = g_list_next (node)) { TnyMimePart *mime_part = (TnyMimePart *) node->data; + if (tny_mime_part_is_attachment (mime_part)) { - const gchar *att_filename = tny_mime_part_get_filename (mime_part); - if (att_filename != NULL) { - gchar *full_filename; - gboolean save_result; - full_filename = g_build_filename (foldername, att_filename, NULL); - attachment_found = TRUE; - - save_result = save_mime_part_to_file_with_checks (GTK_WINDOW (save_dialog), - full_filename, mime_part); - g_free (full_filename); - if (!save_result) - break; + SaveMimePartPair *pair; + + if ((mime_parts->next != NULL) && + (tny_mime_part_get_filename (mime_part) == NULL)) + continue; + + pair = g_slice_new0 (SaveMimePartPair); + if (mime_parts->next == NULL) { + pair->filename = g_strdup (chooser_uri); + } else { + pair->filename = + g_build_filename (chooser_uri, + tny_mime_part_get_filename (mime_part), NULL); } + pair->part = g_object_ref (mime_part); + files_to_save = g_list_prepend (files_to_save, pair); } } - gtk_widget_destroy (save_dialog); - } else { - g_warning ("Tried to save a non-file attachment"); } - /* more than one attachment selected */ + g_free (chooser_uri); } + + gtk_widget_destroy (save_dialog); + if (clean_list) { g_list_foreach (mime_parts, (GFunc) g_object_unref, NULL); g_list_free (mime_parts); } + + if (files_to_save != NULL) { + SaveMimePartInfo *info = g_slice_new0 (SaveMimePartInfo); + GtkWidget *banner = hildon_banner_show_animation (NULL, NULL, + _CS("sfil_ib_saving")); + info->pairs = files_to_save; + info->banner = banner; + info->result = TRUE; + g_object_ref (banner); + save_mime_parts_to_file_with_checks (info); + } } void -modest_msg_view_window_remove_attachments (ModestMsgViewWindow *window) +modest_msg_view_window_remove_attachments (ModestMsgViewWindow *window, gboolean get_all) { ModestMsgViewWindowPrivate *priv; GList *mime_parts = NULL, *node; @@ -1789,7 +2012,25 @@ modest_msg_view_window_remove_attachments (ModestMsgViewWindow *window) g_return_if_fail (MODEST_IS_MSG_VIEW_WINDOW (window)); priv = MODEST_MSG_VIEW_WINDOW_GET_PRIVATE (window); - mime_parts = modest_msg_view_get_selected_attachments (MODEST_MSG_VIEW (priv->msg_view)); + if (get_all) + mime_parts = modest_msg_view_get_attachments (MODEST_MSG_VIEW (priv->msg_view)); + else + mime_parts = modest_msg_view_get_selected_attachments (MODEST_MSG_VIEW (priv->msg_view)); + + /* Remove already purged messages from mime parts list */ + node = mime_parts; + while (node != NULL) { + TnyMimePart *part = TNY_MIME_PART (node->data); + if (tny_mime_part_is_purged (part)) { + GList *deleted_node = node; + node = g_list_next (node); + g_object_unref (part); + mime_parts = g_list_delete_link (mime_parts, deleted_node); + } else { + node = g_list_next (node); + } + } + if (mime_parts == NULL) return; @@ -1820,22 +2061,26 @@ modest_msg_view_window_remove_attachments (ModestMsgViewWindow *window) if (response != GTK_RESPONSE_OK) return; - msg = modest_msg_view_get_message (MODEST_MSG_VIEW (priv->msg_view)); /* folder = tny_msg_get_folder (msg); */ /* tny_msg_uncache_attachments (msg); */ /* tny_folder_refresh (folder, NULL); */ /* g_object_unref (folder); */ - modest_msg_view_set_message (MODEST_MSG_VIEW (priv->msg_view), msg); + modest_platform_information_banner (NULL, NULL, _("mcen_ib_removing_attachment")); for (node = mime_parts; node != NULL; node = g_list_next (node)) { tny_mime_part_set_purged (TNY_MIME_PART (node->data)); /* modest_msg_view_remove_attachment (MODEST_MSG_VIEW (priv->msg_view), node->data); */ } + + msg = modest_msg_view_get_message (MODEST_MSG_VIEW (priv->msg_view)); + modest_msg_view_set_message (MODEST_MSG_VIEW (priv->msg_view), NULL); tny_msg_rewrite_cache (msg); + modest_msg_view_set_message (MODEST_MSG_VIEW (priv->msg_view), msg); + g_list_foreach (mime_parts, (GFunc) g_object_unref, NULL); g_list_free (mime_parts); - modest_platform_information_banner (NULL, NULL, _("mcen_ib_removing_attachment")); + } @@ -1860,5 +2105,3 @@ update_window_title (ModestMsgViewWindow *window) gtk_window_set_title (GTK_WINDOW (window), subject); } - -