X-Git-Url: http://git.maemo.org/git/?p=modest;a=blobdiff_plain;f=src%2Fmodest-account-mgr-helpers.c;h=bbf8f9d9df858984f3ed4ad7b5c865bc35585625;hp=9ff28f37ead617a7dd54d81dd9c00ba528141942;hb=f65289e467bc8ce1c1c4d8c13fafff637ae13034;hpb=5b20214853dcf7416c0e9b2590fed93af2c635e0 diff --git a/src/modest-account-mgr-helpers.c b/src/modest-account-mgr-helpers.c index 9ff28f3..bbf8f9d 100644 --- a/src/modest-account-mgr-helpers.c +++ b/src/modest-account-mgr-helpers.c @@ -31,7 +31,17 @@ #include #include #include +#include #include +#include + +static const gchar * null_means_empty (const gchar * str); + +static const gchar * +null_means_empty (const gchar * str) +{ + return str ? str : ""; +} gboolean modest_account_mgr_set_enabled (ModestAccountMgr *self, const gchar* name, @@ -53,46 +63,48 @@ gboolean modest_account_mgr_set_signature (ModestAccountMgr *self, const gchar* gboolean result = modest_account_mgr_set_bool (self, name, MODEST_ACCOUNT_USE_SIGNATURE, use_signature, FALSE); result = result && modest_account_mgr_set_string (self, name, MODEST_ACCOUNT_SIGNATURE, - signature, FALSE); + null_means_empty (signature), FALSE); return result; } -gchar* modest_account_mgr_get_signature (ModestAccountMgr *self, const gchar* name, - gboolean* use_signature) +gchar* +modest_account_mgr_get_signature (ModestAccountMgr *self, + const gchar* name, + gboolean* use_signature) { - if (use_signature) { - *use_signature = - modest_account_mgr_get_bool (self, name, MODEST_ACCOUNT_USE_SIGNATURE, FALSE); - } + *use_signature = + modest_account_mgr_get_bool (self, name, MODEST_ACCOUNT_USE_SIGNATURE, FALSE); return modest_account_mgr_get_string (self, name, MODEST_ACCOUNT_SIGNATURE, FALSE); } - -ModestTransportStoreProtocol modest_account_mgr_get_store_protocol (ModestAccountMgr *self, const gchar* name) +ModestProtocolType modest_account_mgr_get_store_protocol (ModestAccountMgr *self, const gchar* name) { - ModestTransportStoreProtocol result = MODEST_PROTOCOL_STORE_POP; /* Arbitrary default */ - - gchar *server_account_name = modest_account_mgr_get_string (self, name, - MODEST_ACCOUNT_STORE_ACCOUNT, - FALSE); - if (server_account_name) { - ModestServerAccountData* server_data = - modest_account_mgr_get_server_account_data (self, server_account_name); - result = server_data->proto; - - modest_account_mgr_free_server_account_data (self, server_data); - - g_free (server_account_name); - } - - return result; + ModestProtocolType result = MODEST_PROTOCOLS_STORE_POP; /* Arbitrary default */ + + gchar *server_account_name = modest_account_mgr_get_string (self, name, + MODEST_ACCOUNT_STORE_ACCOUNT, + FALSE); + if (server_account_name) { + ModestServerAccountSettings* server_settings = + modest_account_mgr_load_server_settings (self, server_account_name, FALSE); + result = modest_server_account_settings_get_protocol (server_settings); + + g_object_unref (server_settings); + + g_free (server_account_name); + } + + return result; } -gboolean modest_account_mgr_set_connection_specific_smtp (ModestAccountMgr *self, - const gchar* connection_name, const gchar* server_account_name) + +gboolean +modest_account_mgr_set_connection_specific_smtp (ModestAccountMgr *self, + const gchar* connection_id, + const gchar* server_account_name) { - modest_account_mgr_remove_connection_specific_smtp (self, connection_name); + modest_account_mgr_remove_connection_specific_smtp (self, connection_id); ModestConf *conf = MODEST_ACCOUNT_MGR_GET_PRIVATE (self)->modest_conf; @@ -107,8 +119,8 @@ gboolean modest_account_mgr_set_connection_specific_smtp (ModestAccountMgr *self result = FALSE; } else { /* The server account is in the item after the connection name: */ - list = g_slist_append (list, (gpointer)connection_name); - list = g_slist_append (list, (gpointer)server_account_name); + list = g_slist_append (list, g_strdup (connection_id)); + list = g_slist_append (list, g_strdup (server_account_name)); /* Reset the changed list: */ modest_conf_set_list (conf, MODEST_CONF_CONNECTION_SPECIFIC_SMTP_LIST, list, @@ -120,8 +132,11 @@ gboolean modest_account_mgr_set_connection_specific_smtp (ModestAccountMgr *self } } - /* TODO: Should we free the items too, or just the list? */ - g_slist_free (list); + /* Free the list */ + if (list) { + g_slist_foreach (list, (GFunc) g_free, NULL); + g_slist_free (list); + } return result; } @@ -130,22 +145,23 @@ gboolean modest_account_mgr_set_connection_specific_smtp (ModestAccountMgr *self * modest_account_mgr_remove_connection_specific_smtp * @self: a ModestAccountMgr instance * @name: the account name - * @connection_name: A libconic IAP connection name + * @connection_id: A libconic IAP connection id * * Disassacoiate a server account to use with the specific connection for this account. * * Returns: TRUE if it worked, FALSE otherwise */ -gboolean modest_account_mgr_remove_connection_specific_smtp (ModestAccountMgr *self, - const gchar* connection_name) +gboolean +modest_account_mgr_remove_connection_specific_smtp (ModestAccountMgr *self, + const gchar* connection_id) { ModestAccountMgrPrivate *priv = MODEST_ACCOUNT_MGR_GET_PRIVATE (self); gboolean result = TRUE; GError *err = NULL; GSList *list = modest_conf_get_list (priv->modest_conf, - MODEST_CONF_CONNECTION_SPECIFIC_SMTP_LIST, - MODEST_CONF_VALUE_STRING, &err); + MODEST_CONF_CONNECTION_SPECIFIC_SMTP_LIST, + MODEST_CONF_VALUE_STRING, &err); if (err) { g_printerr ("modest: %s: error getting list: %s.\n", __FUNCTION__, err->message); g_error_free (err); @@ -157,7 +173,7 @@ gboolean modest_account_mgr_remove_connection_specific_smtp (ModestAccountMgr *s return FALSE; /* The server account is in the item after the connection name: */ - GSList *list_connection = g_slist_find_custom (list, connection_name, (GCompareFunc)strcmp); + GSList *list_connection = g_slist_find_custom (list, connection_id, (GCompareFunc)strcmp); if (list_connection) { GSList *account_node = g_slist_next (list_connection); /* remove both items: */ @@ -174,8 +190,11 @@ gboolean modest_account_mgr_remove_connection_specific_smtp (ModestAccountMgr *s result = FALSE; } - /* TODO: Should we free the items too, or just the list? */ - g_slist_free (list); + /* Free the list */ + if (list) { + g_slist_foreach (list, (GFunc) g_free, NULL); + g_slist_free (list); + } return result; } @@ -197,13 +216,13 @@ gboolean modest_account_mgr_set_use_connection_specific_smtp (ModestAccountMgr * /** * modest_account_mgr_get_connection_specific_smtp * @self: a ModestAccountMgr instance - * @connection_name: A libconic IAP connection name + * @connection_id: A libconic IAP connection id * * Retrieve a server account to use with this specific connection for this account. * * Returns: a server account name to use for this connection, or NULL if none is specified. */ -gchar* modest_account_mgr_get_connection_specific_smtp (ModestAccountMgr *self, const gchar* connection_name) +gchar* modest_account_mgr_get_connection_specific_smtp (ModestAccountMgr *self, const gchar* connection_id) { gchar *result = NULL; @@ -224,8 +243,8 @@ gchar* modest_account_mgr_get_connection_specific_smtp (ModestAccountMgr *self, /* The server account is in the item after the connection name: */ GSList *iter = list; while (iter) { - const gchar* this_connection_name = (const gchar*)(iter->data); - if (strcmp (this_connection_name, connection_name) == 0) { + const gchar* this_connection_id = (const gchar*)(iter->data); + if (strcmp (this_connection_id, connection_id) == 0) { iter = g_slist_next (iter); if (iter) { @@ -243,14 +262,11 @@ gchar* modest_account_mgr_get_connection_specific_smtp (ModestAccountMgr *self, iter = g_slist_next (iter); } - /* - if (!result) { - printf (" debug: no server found for connection_name=%s.\n", connection_name); + /* Free the list */ + if (list) { + g_slist_foreach (list, (GFunc) g_free, NULL); + g_slist_free (list); } - */ - - /* TODO: Should we free the items too, or just the list? */ - g_slist_free (list); return result; } @@ -276,7 +292,7 @@ modest_account_mgr_set_server_account_username (ModestAccountMgr *self, const gc /* We don't know anything about new usernames: */ if (strcmp (existing_username, username) != 0) - modest_account_mgr_get_server_account_username_has_succeeded (self, account_name); + modest_account_mgr_set_server_account_username_has_succeeded (self, account_name, FALSE); g_free (existing_username); } @@ -297,15 +313,6 @@ modest_account_mgr_set_server_account_username_has_succeeded (ModestAccountMgr * succeeded, TRUE /* server account */); } -void -modest_account_mgr_set_server_account_password (ModestAccountMgr *self, const gchar* account_name, - const gchar* password) -{ - modest_account_mgr_set_string (self, account_name, MODEST_ACCOUNT_PASSWORD, - password, TRUE /* server account */); -} - - gchar* modest_account_mgr_get_server_account_password (ModestAccountMgr *self, const gchar* account_name) { @@ -321,8 +328,11 @@ modest_account_mgr_get_server_account_has_password (ModestAccountMgr *self, cons TRUE /* server account */); if (password && strlen (password)) { result = TRUE; - } + /* Clean password */ + bzero (password, strlen (password)); + } + g_free (password); return result; } @@ -351,33 +361,27 @@ modest_account_mgr_set_server_account_hostname (ModestAccountMgr *self, } -static ModestAuthProtocol -get_secure_auth_for_conf_string(const gchar* value) -{ - ModestAuthProtocol result = MODEST_PROTOCOL_AUTH_NONE; - if (value) { - if (strcmp(value, MODEST_ACCOUNT_AUTH_MECH_VALUE_NONE) == 0) - result = MODEST_PROTOCOL_AUTH_NONE; - else if (strcmp(value, MODEST_ACCOUNT_AUTH_MECH_VALUE_PASSWORD) == 0) - result = MODEST_PROTOCOL_AUTH_PASSWORD; - else if (strcmp(value, MODEST_ACCOUNT_AUTH_MECH_VALUE_CRAMMD5) == 0) - result = MODEST_PROTOCOL_AUTH_CRAMMD5; - } - - return result; -} -ModestAuthProtocol +ModestProtocolType modest_account_mgr_get_server_account_secure_auth (ModestAccountMgr *self, const gchar* account_name) { - ModestAuthProtocol result = MODEST_PROTOCOL_AUTH_NONE; - gchar* value = modest_account_mgr_get_string (self, account_name, MODEST_ACCOUNT_AUTH_MECH, - TRUE /* server account */); + ModestProtocolRegistry *protocol_registry; + ModestProtocolType result = MODEST_PROTOCOLS_AUTH_NONE; + gchar* value; + + protocol_registry = modest_runtime_get_protocol_registry (); + value = modest_account_mgr_get_string (self, account_name, MODEST_ACCOUNT_AUTH_MECH, + TRUE /* server account */); if (value) { - result = get_secure_auth_for_conf_string (value); - + ModestProtocol *protocol; + + protocol = modest_protocol_registry_get_protocol_by_name (protocol_registry, MODEST_PROTOCOL_REGISTRY_AUTH_PROTOCOLS, value); g_free (value); + + if (protocol) + result = modest_protocol_get_type_id (protocol); + } return result; @@ -386,49 +390,42 @@ modest_account_mgr_get_server_account_secure_auth (ModestAccountMgr *self, void modest_account_mgr_set_server_account_secure_auth (ModestAccountMgr *self, - const gchar* account_name, ModestAuthProtocol secure_auth) -{ - /* Get the conf string for the enum value: */ - const gchar* str_value = NULL; - if (secure_auth == MODEST_PROTOCOL_AUTH_NONE) - str_value = MODEST_ACCOUNT_AUTH_MECH_VALUE_NONE; - else if (secure_auth == MODEST_PROTOCOL_AUTH_PASSWORD) - str_value = MODEST_ACCOUNT_AUTH_MECH_VALUE_PASSWORD; - else if (secure_auth == MODEST_PROTOCOL_AUTH_CRAMMD5) - str_value = MODEST_ACCOUNT_AUTH_MECH_VALUE_CRAMMD5; + const gchar* account_name, ModestProtocolType secure_auth) +{ + const gchar* str_value; + ModestProtocolRegistry *protocol_registry; + ModestProtocol *protocol; + + /* Get the conf string for the protocol: */ + protocol_registry = modest_runtime_get_protocol_registry (); + protocol = modest_protocol_registry_get_protocol_by_type (protocol_registry, secure_auth); + str_value = modest_protocol_get_name (protocol); /* Set it in the configuration: */ modest_account_mgr_set_string (self, account_name, MODEST_ACCOUNT_AUTH_MECH, str_value, TRUE); } -static ModestConnectionProtocol -get_security_for_conf_string(const gchar* value) -{ - ModestConnectionProtocol result = MODEST_PROTOCOL_CONNECTION_NORMAL; - if (value) { - if (strcmp(value, MODEST_ACCOUNT_SECURITY_VALUE_NONE) == 0) - result = MODEST_PROTOCOL_CONNECTION_NORMAL; - else if (strcmp(value, MODEST_ACCOUNT_SECURITY_VALUE_NORMAL) == 0) { - /* The UI has "Normal (TLS)": */ - result = MODEST_PROTOCOL_CONNECTION_TLS; - } else if (strcmp(value, MODEST_ACCOUNT_SECURITY_VALUE_SSL) == 0) - result = MODEST_PROTOCOL_CONNECTION_SSL; - } - - return result; -} - -ModestConnectionProtocol +ModestProtocolType modest_account_mgr_get_server_account_security (ModestAccountMgr *self, const gchar* account_name) { - ModestConnectionProtocol result = MODEST_PROTOCOL_CONNECTION_NORMAL; - gchar* value = modest_account_mgr_get_string (self, account_name, MODEST_ACCOUNT_SECURITY, - TRUE /* server account */); + ModestProtocolType result = MODEST_PROTOCOLS_CONNECTION_NONE; + gchar* value; + + value = modest_account_mgr_get_string (self, account_name, MODEST_ACCOUNT_SECURITY, + TRUE /* server account */); if (value) { - result = get_security_for_conf_string (value); - + ModestProtocolRegistry *protocol_registry; + ModestProtocol *protocol; + + protocol_registry = modest_runtime_get_protocol_registry (); + protocol = modest_protocol_registry_get_protocol_by_name (protocol_registry, + MODEST_PROTOCOL_REGISTRY_CONNECTION_PROTOCOLS, + value); g_free (value); + + if (protocol) + result = modest_protocol_get_type_id (protocol); } return result; @@ -436,89 +433,212 @@ modest_account_mgr_get_server_account_security (ModestAccountMgr *self, void modest_account_mgr_set_server_account_security (ModestAccountMgr *self, - const gchar* account_name, ModestConnectionProtocol security) -{ - /* Get the conf string for the enum value: */ - const gchar* str_value = NULL; - if (security == MODEST_PROTOCOL_CONNECTION_NORMAL) - str_value = MODEST_ACCOUNT_SECURITY_VALUE_NONE; - else if (security == MODEST_PROTOCOL_CONNECTION_TLS) { - /* The UI has "Normal (TLS)": */ - str_value = MODEST_ACCOUNT_SECURITY_VALUE_NORMAL; - } else if (security == MODEST_PROTOCOL_CONNECTION_SSL) - str_value = MODEST_ACCOUNT_SECURITY_VALUE_SSL; + const gchar* account_name, + ModestProtocolType security) +{ + const gchar* str_value; + ModestProtocolRegistry *protocol_registry; + ModestProtocol *protocol; + + /* Get the conf string for the protocol type: */ + protocol_registry = modest_runtime_get_protocol_registry (); + protocol = modest_protocol_registry_get_protocol_by_type (protocol_registry, security); + str_value = modest_protocol_get_name (protocol); /* Set it in the configuration: */ modest_account_mgr_set_string (self, account_name, MODEST_ACCOUNT_SECURITY, str_value, TRUE); } -ModestServerAccountData* -modest_account_mgr_get_server_account_data (ModestAccountMgr *self, const gchar* name) +ModestServerAccountSettings * +modest_account_mgr_load_server_settings (ModestAccountMgr *self, const gchar* name, gboolean is_transport_and_not_store) { - ModestServerAccountData *data; - gchar *proto; - - g_return_val_if_fail (modest_account_mgr_account_exists (self, name, TRUE), NULL); - data = g_slice_new0 (ModestServerAccountData); - - data->account_name = g_strdup (name); - data->hostname = modest_account_mgr_get_string (self, name, MODEST_ACCOUNT_HOSTNAME,TRUE); - data->username = modest_account_mgr_get_string (self, name, MODEST_ACCOUNT_USERNAME,TRUE); - proto = modest_account_mgr_get_string (self, name, MODEST_ACCOUNT_PROTO, TRUE); - data->proto = modest_protocol_info_get_transport_store_protocol (proto); - g_free (proto); - - data->port = modest_account_mgr_get_int (self, name, MODEST_ACCOUNT_PORT, TRUE); - - gchar *secure_auth_str = modest_account_mgr_get_string (self, name, MODEST_ACCOUNT_AUTH_MECH, TRUE); - data->secure_auth = get_secure_auth_for_conf_string(secure_auth_str); - g_free (secure_auth_str); - - gchar *security_str = modest_account_mgr_get_string (self, name, MODEST_ACCOUNT_SECURITY, TRUE); - data->security = get_security_for_conf_string(security_str); - g_free (security_str); - - data->last_updated = modest_account_mgr_get_int (self, name, MODEST_ACCOUNT_LAST_UPDATED,TRUE); - - data->password = modest_account_mgr_get_string (self, name, MODEST_ACCOUNT_PASSWORD, TRUE); - - return data; -} + ModestServerAccountSettings *settings = NULL; + ModestProtocol *protocol; + ModestProtocolRegistry *registry; + gchar *hostname, *username, *pwd, *uri, *proto, *auth, *sec; + if (!modest_account_mgr_account_exists (self, name, TRUE)) { + g_message ("%s account %s does not exist", __FUNCTION__, name); + return NULL; + } -void -modest_account_mgr_free_server_account_data (ModestAccountMgr *self, - ModestServerAccountData* data) -{ - g_return_if_fail (self); + registry = modest_runtime_get_protocol_registry (); + settings = modest_server_account_settings_new (); - if (!data) - return; /* not an error */ + modest_server_account_settings_set_account_name (settings, name); - g_free (data->account_name); - data->account_name = NULL; - - g_free (data->hostname); - data->hostname = NULL; + proto = modest_account_mgr_get_string (self, name, MODEST_ACCOUNT_PROTO, TRUE); + if (proto) { + gchar *tag = NULL; + if (is_transport_and_not_store) { + tag = MODEST_PROTOCOL_REGISTRY_TRANSPORT_PROTOCOLS; + } else { + tag = MODEST_PROTOCOL_REGISTRY_STORE_PROTOCOLS; + } + protocol = modest_protocol_registry_get_protocol_by_name (registry, tag, proto); + + modest_server_account_settings_set_protocol (settings, + modest_protocol_get_type_id (protocol)); + g_free (proto); + } else { + goto on_error; + } + + modest_server_account_settings_set_port (settings, + modest_account_mgr_get_int (self, name, MODEST_ACCOUNT_PORT, TRUE)); + + auth = modest_account_mgr_get_string (self, name, MODEST_ACCOUNT_AUTH_MECH, TRUE); + if (auth) { + protocol = modest_protocol_registry_get_protocol_by_name (registry, MODEST_PROTOCOL_REGISTRY_AUTH_PROTOCOLS, auth); + modest_server_account_settings_set_auth_protocol (settings, + modest_protocol_get_type_id (protocol)); + g_free (auth); + } else { + modest_server_account_settings_set_auth_protocol (settings, MODEST_PROTOCOLS_AUTH_NONE); + } + + sec = modest_account_mgr_get_string (self, name, MODEST_ACCOUNT_SECURITY, TRUE); + if (sec) { + protocol = modest_protocol_registry_get_protocol_by_name (registry, MODEST_PROTOCOL_REGISTRY_CONNECTION_PROTOCOLS, sec); + modest_server_account_settings_set_security_protocol (settings, + modest_protocol_get_type_id (protocol)); + g_free (sec); + } else { + modest_server_account_settings_set_security_protocol (settings, + MODEST_PROTOCOLS_CONNECTION_NONE); + } + + /* Username, password and URI. Note that the URI could include + the former two, so in this case there is no need to have + them */ + username = modest_account_mgr_get_string (self, name, + MODEST_ACCOUNT_USERNAME,TRUE); + if (username) + modest_server_account_settings_set_username (settings, username); + + pwd = modest_account_mgr_get_string (self, name, + MODEST_ACCOUNT_PASSWORD, TRUE); + if (pwd) { + modest_server_account_settings_set_password (settings, pwd); + g_free (pwd); + } + + uri = modest_account_mgr_get_string (self, name, + MODEST_ACCOUNT_URI, TRUE); + if (uri) + modest_server_account_settings_set_uri (settings, uri); + + hostname = modest_account_mgr_get_string (self, name, + MODEST_ACCOUNT_HOSTNAME,TRUE); + if (hostname) + modest_server_account_settings_set_hostname (settings, hostname); + + if (!uri) { + if (!username || !hostname) { + g_free (username); + g_free (hostname); + goto on_error; + } + } + + g_free (username); + g_free (hostname); + g_free (uri); + + return settings; + + on_error: + if (settings) + g_object_unref (settings); + return NULL; +} + +gboolean +modest_account_mgr_save_server_settings (ModestAccountMgr *self, + ModestServerAccountSettings *settings) +{ + gboolean has_errors = FALSE; + const gchar *account_name; + const gchar *protocol_name; + const gchar *uri; + ModestProtocolRegistry *protocol_registry; + ModestProtocol *protocol; - g_free (data->username); - data->username = NULL; + g_return_val_if_fail (MODEST_IS_SERVER_ACCOUNT_SETTINGS (settings), FALSE); + protocol_registry = modest_runtime_get_protocol_registry (); + account_name = modest_server_account_settings_get_account_name (settings); + + /* if we don't have a valid account name we cannot save */ + g_return_val_if_fail (account_name, FALSE); + + protocol = modest_protocol_registry_get_protocol_by_type (protocol_registry, + modest_server_account_settings_get_protocol (settings)); + protocol_name = modest_protocol_get_name (protocol); + uri = modest_server_account_settings_get_uri (settings); + if (!uri) { + const gchar *hostname; + const gchar *username; + const gchar *password; + gint port; + const gchar *auth_protocol_name; + const gchar *security_name; + + hostname = null_means_empty (modest_server_account_settings_get_hostname (settings)); + username = null_means_empty (modest_server_account_settings_get_username (settings)); + password = null_means_empty (modest_server_account_settings_get_password (settings)); + port = modest_server_account_settings_get_port (settings); + protocol = modest_protocol_registry_get_protocol_by_type (protocol_registry, + modest_server_account_settings_get_auth_protocol (settings)); + auth_protocol_name = modest_protocol_get_name (protocol); + protocol = modest_protocol_registry_get_protocol_by_type (protocol_registry, + modest_server_account_settings_get_security_protocol (settings)); + security_name = modest_protocol_get_name (protocol); + + has_errors = !modest_account_mgr_set_string (self, account_name, MODEST_ACCOUNT_HOSTNAME, + hostname, TRUE); + if (!has_errors) + (has_errors = !modest_account_mgr_set_string (self, account_name, MODEST_ACCOUNT_USERNAME, + username, TRUE)); + if (!has_errors) + (has_errors = !modest_account_mgr_set_string (self, account_name, MODEST_ACCOUNT_PASSWORD, + password, TRUE)); + if (!has_errors) + (has_errors = !modest_account_mgr_set_string (self, account_name, MODEST_ACCOUNT_PROTO, + protocol_name, TRUE)); + if (!has_errors) + (has_errors = !modest_account_mgr_set_int (self, account_name, MODEST_ACCOUNT_PORT, + port, TRUE)); + if (!has_errors) + (has_errors = !modest_account_mgr_set_string (self, account_name, + MODEST_ACCOUNT_AUTH_MECH, + auth_protocol_name, TRUE)); + if (!has_errors) + (has_errors = !modest_account_mgr_set_string (self, account_name, MODEST_ACCOUNT_SECURITY, + security_name, + TRUE)); + } else { + const gchar *uri = modest_server_account_settings_get_uri (settings); + has_errors = !modest_account_mgr_set_string (self, account_name, MODEST_ACCOUNT_URI, + uri, TRUE); + if (!has_errors) + (has_errors = !modest_account_mgr_set_string (self, account_name, MODEST_ACCOUNT_PROTO, + protocol_name, TRUE)); + } - g_free (data->password); - data->password = NULL; + return !has_errors; - g_slice_free (ModestServerAccountData, data); } -/** You must use modest_account_mgr_free_account_data() on the result. - */ -ModestAccountData * -modest_account_mgr_get_account_data (ModestAccountMgr *self, - const gchar* name) + +ModestAccountSettings * +modest_account_mgr_load_account_settings (ModestAccountMgr *self, + const gchar* name) { - ModestAccountData *data; + ModestAccountSettings *settings; + gchar *string; gchar *server_account; gchar *default_account; + gboolean use_signature = FALSE; g_return_val_if_fail (self, NULL); g_return_val_if_fail (name, NULL); @@ -529,33 +649,67 @@ modest_account_mgr_get_account_data (ModestAccountMgr *self, return NULL; } - data = g_slice_new0 (ModestAccountData); - - data->account_name = g_strdup (name); + settings = modest_account_settings_new (); - data->display_name = modest_account_mgr_get_string (self, name, - MODEST_ACCOUNT_DISPLAY_NAME, - FALSE); - data->fullname = modest_account_mgr_get_string (self, name, - MODEST_ACCOUNT_FULLNAME, - FALSE); - data->email = modest_account_mgr_get_string (self, name, - MODEST_ACCOUNT_EMAIL, - FALSE); - data->is_enabled = modest_account_mgr_get_enabled (self, name); + modest_account_settings_set_account_name (settings, name); + + string = modest_account_mgr_get_string (self, name, + MODEST_ACCOUNT_DISPLAY_NAME, + FALSE); + modest_account_settings_set_display_name (settings, string); + g_free (string); + + string = modest_account_mgr_get_string (self, name, + MODEST_ACCOUNT_FULLNAME, + FALSE); + modest_account_settings_set_fullname (settings, string); + g_free (string); + + string = modest_account_mgr_get_string (self, name, + MODEST_ACCOUNT_EMAIL, + FALSE); + modest_account_settings_set_email_address (settings, string); + g_free (string); + + modest_account_settings_set_enabled (settings, modest_account_mgr_get_enabled (self, name)); + modest_account_settings_set_retrieve_type (settings, modest_account_mgr_get_retrieve_type (self, name)); + modest_account_settings_set_retrieve_limit (settings, modest_account_mgr_get_retrieve_limit (self, name)); default_account = modest_account_mgr_get_default_account (self); - data->is_default = (default_account && strcmp (default_account, name) == 0); + modest_account_settings_set_is_default (settings, + (default_account && strcmp (default_account, name) == 0)); g_free (default_account); + string = modest_account_mgr_get_signature (self, name, &use_signature); + modest_account_settings_set_use_signature (settings, use_signature); + modest_account_settings_set_signature (settings, string); + g_free (string); + + modest_account_settings_set_leave_messages_on_server + (settings, modest_account_mgr_get_leave_on_server (self, name)); + modest_account_settings_set_use_connection_specific_smtp + (settings, modest_account_mgr_get_use_connection_specific_smtp (self, name)); + /* store */ server_account = modest_account_mgr_get_string (self, name, MODEST_ACCOUNT_STORE_ACCOUNT, FALSE); if (server_account) { - data->store_account = - modest_account_mgr_get_server_account_data (self, server_account); + ModestServerAccountSettings *store_settings; + store_settings = modest_account_mgr_load_server_settings (self, server_account, FALSE); g_free (server_account); + + /* It could happen that the account data is corrupted + so it's not loaded properly */ + if (store_settings) { + modest_account_settings_set_store_settings (settings, + store_settings); + g_object_unref (store_settings); + } else { + g_message ("%s can not load server settings. Account corrupted?", __FUNCTION__); + g_object_unref (settings); + return NULL; + } } /* transport */ @@ -563,34 +717,77 @@ modest_account_mgr_get_account_data (ModestAccountMgr *self, MODEST_ACCOUNT_TRANSPORT_ACCOUNT, FALSE); if (server_account) { - data->transport_account = - modest_account_mgr_get_server_account_data (self, server_account); + ModestServerAccountSettings *transport_settings; + transport_settings = modest_account_mgr_load_server_settings (self, server_account, TRUE); g_free (server_account); + + if (transport_settings) { + modest_account_settings_set_transport_settings (settings, transport_settings); + g_object_unref (transport_settings); + } else { + g_message ("%s can not load server settings. Account corrupted?", __FUNCTION__); + g_object_unref (settings); + return NULL; + } } - return data; + return settings; } - void -modest_account_mgr_free_account_data (ModestAccountMgr *self, ModestAccountData *data) +modest_account_mgr_save_account_settings (ModestAccountMgr *mgr, + ModestAccountSettings *settings) { - g_return_if_fail (self); - - if (!data) /* not an error */ - return; - - g_free (data->account_name); - g_free (data->display_name); - g_free (data->fullname); - g_free (data->email); + g_return_if_fail (MODEST_IS_ACCOUNT_MGR (mgr)); + g_return_if_fail (MODEST_IS_ACCOUNT_SETTINGS (settings)); + + const gchar *account_name; + const gchar *store_account_name; + const gchar *transport_account_name; + ModestServerAccountSettings *store_settings; + ModestServerAccountSettings *transport_settings; + + account_name = modest_account_settings_get_account_name (settings); + g_return_if_fail (account_name != NULL); + + modest_account_mgr_set_display_name (mgr, account_name, + modest_account_settings_get_display_name (settings)); + modest_account_mgr_set_user_fullname (mgr, account_name, + modest_account_settings_get_fullname (settings)); + modest_account_mgr_set_user_email (mgr, account_name, + modest_account_settings_get_email_address (settings)); + modest_account_mgr_set_retrieve_type (mgr, account_name, + modest_account_settings_get_retrieve_type (settings)); + modest_account_mgr_set_retrieve_limit (mgr, account_name, + modest_account_settings_get_retrieve_limit (settings)); + modest_account_mgr_set_leave_on_server (mgr, account_name, + modest_account_settings_get_leave_messages_on_server (settings)); + modest_account_mgr_set_signature (mgr, account_name, + modest_account_settings_get_signature (settings), + modest_account_settings_get_use_signature (settings)); + modest_account_mgr_set_use_connection_specific_smtp + (mgr, account_name, + modest_account_settings_get_use_connection_specific_smtp (settings)); + + store_settings = modest_account_settings_get_store_settings (settings); + store_account_name = modest_server_account_settings_get_account_name (store_settings); + if (store_settings != NULL) { + modest_account_mgr_save_server_settings (mgr, store_settings); + } + modest_account_mgr_set_string (mgr, account_name, MODEST_ACCOUNT_STORE_ACCOUNT, store_account_name, FALSE); + g_object_unref (store_settings); - modest_account_mgr_free_server_account_data (self, data->store_account); - modest_account_mgr_free_server_account_data (self, data->transport_account); - - g_slice_free (ModestAccountData, data); + transport_settings = modest_account_settings_get_transport_settings (settings); + transport_account_name = modest_server_account_settings_get_account_name (transport_settings); + if (transport_settings != NULL) { + modest_account_mgr_save_server_settings (mgr, transport_settings); + } + modest_account_mgr_set_string (mgr, account_name, MODEST_ACCOUNT_TRANSPORT_ACCOUNT, transport_account_name, FALSE); + g_object_unref (transport_settings); + modest_account_mgr_set_enabled (mgr, account_name, TRUE); } + gint on_accounts_list_sort_by_title(gconstpointer a, gconstpointer b) { @@ -676,6 +873,8 @@ modest_account_mgr_get_from_string (ModestAccountMgr *self, const gchar* name) static gchar* util_increment_name (const gchar* text) { + g_return_val_if_fail (text, NULL); + /* Get the end character, * also doing a UTF-8 validation which is required for using g_utf8_prev_char(). */ @@ -700,7 +899,7 @@ util_increment_name (const gchar* text) break; } - p = g_utf8_prev_char (p); + p = g_utf8_find_prev_char (text, p); } if(!alpha_end) { @@ -861,25 +1060,65 @@ modest_account_mgr_get_server_account_name (ModestAccountMgr *self, FALSE); } -gchar* +static const gchar * +get_retrieve_type_name (ModestAccountRetrieveType retrieve_type) +{ + switch(retrieve_type) { + case MODEST_ACCOUNT_RETRIEVE_HEADERS_ONLY: + return MODEST_ACCOUNT_RETRIEVE_VALUE_HEADERS_ONLY; + break; + case MODEST_ACCOUNT_RETRIEVE_MESSAGES: + return MODEST_ACCOUNT_RETRIEVE_VALUE_MESSAGES; + break; + case MODEST_ACCOUNT_RETRIEVE_MESSAGES_AND_ATTACHMENTS: + return MODEST_ACCOUNT_RETRIEVE_VALUE_MESSAGES_AND_ATTACHMENTS; + break; + default: + return MODEST_ACCOUNT_RETRIEVE_VALUE_HEADERS_ONLY; + }; +} + +static ModestAccountRetrieveType +get_retrieve_type (const gchar *name) +{ + if (!name || name[0] == 0) + return MODEST_ACCOUNT_RETRIEVE_HEADERS_ONLY; + if (strcmp (name, MODEST_ACCOUNT_RETRIEVE_VALUE_MESSAGES) == 0) { + return MODEST_ACCOUNT_RETRIEVE_MESSAGES; + } else if (strcmp (name, MODEST_ACCOUNT_RETRIEVE_VALUE_MESSAGES_AND_ATTACHMENTS) == 0) { + return MODEST_ACCOUNT_RETRIEVE_MESSAGES_AND_ATTACHMENTS; + } else { + /* we fall back to headers only */ + return MODEST_ACCOUNT_RETRIEVE_HEADERS_ONLY; + } +} + +ModestAccountRetrieveType modest_account_mgr_get_retrieve_type (ModestAccountMgr *self, const gchar *account_name) { - return modest_account_mgr_get_string (self, - account_name, - MODEST_ACCOUNT_RETRIEVE, - FALSE /* not server account */); + gchar *string; + ModestAccountRetrieveType result; + + string = modest_account_mgr_get_string (self, + account_name, + MODEST_ACCOUNT_RETRIEVE, + FALSE /* not server account */); + result = get_retrieve_type (string); + g_free (string); + + return result; } void modest_account_mgr_set_retrieve_type (ModestAccountMgr *self, const gchar *account_name, - const gchar *retrieve_type) + ModestAccountRetrieveType retrieve_type) { modest_account_mgr_set_string (self, account_name, MODEST_ACCOUNT_RETRIEVE, - retrieve_type, + get_retrieve_type_name (retrieve_type), FALSE /* not server account */); }