X-Git-Url: http://git.maemo.org/git/?p=modest;a=blobdiff_plain;f=src%2Fmodest-conf.c;h=9b2d95f73f96e48016e1487abb93b5d4e97b2685;hp=86a9ef147a25e86d196a14c7baa5989990d27379;hb=12f0687cf55bb339ad9892cbce8c7d35a6509af5;hpb=fd44d68efc59bf8d3f70e70bb1df7e6885228188 diff --git a/src/modest-conf.c b/src/modest-conf.c index 86a9ef1..9b2d95f 100644 --- a/src/modest-conf.c +++ b/src/modest-conf.c @@ -28,10 +28,12 @@ */ #include +#include #include #include #include "modest-conf.h" #include "modest-marshal.h" +#include static void modest_conf_class_init (ModestConfClass *klass); static void modest_conf_init (ModestConf *obj); @@ -40,6 +42,11 @@ static void modest_conf_on_change (GConfClient *client, guint conn_id, GConfEntry *entry, gpointer data); static GConfValueType modest_conf_type_to_gconf_type (ModestConfValueType value_type, GError **err); + + +static void +modest_conf_maemo_fake_on_change (ModestConf *conf, const gchar* key, ModestConfEvent event); + /* list my signals */ enum { KEY_CHANGED_SIGNAL, @@ -53,8 +60,8 @@ struct _ModestConfPrivate { GConfClient *gconf_client; }; #define MODEST_CONF_GET_PRIVATE(o) (G_TYPE_INSTANCE_GET_PRIVATE((o), \ - MODEST_TYPE_CONF, \ - ModestConfPrivate)) + MODEST_TYPE_CONF, \ + ModestConfPrivate)) /* globals */ static GObjectClass *parent_class = NULL; @@ -109,6 +116,7 @@ modest_conf_init (ModestConf *obj) GConfClient *conf = NULL; ModestConfPrivate *priv = MODEST_CONF_GET_PRIVATE(obj); GError *err = NULL; + priv->gconf_client = NULL; @@ -117,7 +125,6 @@ modest_conf_init (ModestConf *obj) g_printerr ("modest: could not get gconf client\n"); return; } - gconf_client_add_dir (conf,MODEST_CONF_NAMESPACE, GCONF_CLIENT_PRELOAD_NONE, &err); @@ -139,7 +146,6 @@ modest_conf_init (ModestConf *obj) g_error_free (err); return; } - priv->gconf_client = conf; /* all went well! */ } @@ -226,17 +232,17 @@ GSList * modest_conf_get_list (ModestConf* self, const gchar* key, ModestConfValueType list_type, GError **err) { - ModestConfPrivate *priv; - GConfValueType gconf_type; + ModestConfPrivate *priv; + GConfValueType gconf_type; - g_return_val_if_fail (self, NULL); - g_return_val_if_fail (key, NULL); + g_return_val_if_fail (self, NULL); + g_return_val_if_fail (key, NULL); - priv = MODEST_CONF_GET_PRIVATE(self); + priv = MODEST_CONF_GET_PRIVATE(self); - gconf_type = modest_conf_type_to_gconf_type (list_type, err); + gconf_type = modest_conf_type_to_gconf_type (list_type, err); - return gconf_client_get_list (priv->gconf_client, key, gconf_type, err); + return gconf_client_get_list (priv->gconf_client, key, gconf_type, err); } @@ -250,6 +256,7 @@ modest_conf_set_string (ModestConf* self, const gchar* key, const gchar* val, g_return_val_if_fail (self,FALSE); g_return_val_if_fail (key, FALSE); + g_return_val_if_fail (val, FALSE); priv = MODEST_CONF_GET_PRIVATE(self); @@ -258,7 +265,11 @@ modest_conf_set_string (ModestConf* self, const gchar* key, const gchar* val, return FALSE; } - return gconf_client_set_string (priv->gconf_client, key, val, err); + if (gconf_client_set_string (priv->gconf_client, key, val, err)) { + modest_conf_maemo_fake_on_change (self, key, MODEST_CONF_EVENT_KEY_CHANGED); + return TRUE; + } else + return FALSE; } @@ -278,7 +289,11 @@ modest_conf_set_int (ModestConf* self, const gchar* key, gint val, return FALSE; } - return gconf_client_set_int (priv->gconf_client, key, val, err); + if (gconf_client_set_int (priv->gconf_client, key, val, err)) { + modest_conf_maemo_fake_on_change (self, key, MODEST_CONF_EVENT_KEY_CHANGED); + return TRUE; + } else + return FALSE; } @@ -297,8 +312,12 @@ modest_conf_set_bool (ModestConf* self, const gchar* key, gboolean val, g_warning ("modest: '%s' is not writable\n", key); return FALSE; } - - return gconf_client_set_bool (priv->gconf_client,key,val, err); + + if (gconf_client_set_bool (priv->gconf_client, key, val, err)) { + modest_conf_maemo_fake_on_change (self, key, MODEST_CONF_EVENT_KEY_CHANGED); + return TRUE; + } else + return FALSE; } @@ -307,19 +326,44 @@ modest_conf_set_list (ModestConf* self, const gchar* key, GSList *val, ModestConfValueType list_type, GError **err) { - ModestConfPrivate *priv; - GConfValueType gconf_type; + ModestConfPrivate *priv; + GConfValueType gconf_type; + gboolean result; - g_return_val_if_fail (self, FALSE); - g_return_val_if_fail (key, FALSE); + g_return_val_if_fail (self, FALSE); + g_return_val_if_fail (key, FALSE); - priv = MODEST_CONF_GET_PRIVATE(self); + priv = MODEST_CONF_GET_PRIVATE(self); - gconf_type = modest_conf_type_to_gconf_type (list_type, err); - if (*err) - return FALSE; + gconf_type = modest_conf_type_to_gconf_type (list_type, err); + if (*err) + return FALSE; - return gconf_client_set_list (priv->gconf_client, key, gconf_type, val, err); + result = gconf_client_set_list (priv->gconf_client, key, gconf_type, val, err); + if(*err) { + g_warning("gconf_client_set_list() failed with key=%s. error=%s", key, + (*err)->message); + result = FALSE; + } + + /* TODO: Remove this, when we fix the problem: */ + /* This shows that sometimes set_list fails, while saying that it succeeded: */ + if (result) { + const gint debug_list_length_start = g_slist_length(val); + GSList* debug_list = gconf_client_get_list(priv->gconf_client, key, gconf_type, err); + const gint debug_list_length_after = g_slist_length(debug_list); + + if(debug_list_length_start != debug_list_length_after) + g_warning("modest_conf_set_list(): The list length after setting is " + "not the same as the specified list. key=%s. " + "We think that we fixed this, so tell us if you see this.", key); + g_slist_free(debug_list); + } + + if (result) + modest_conf_maemo_fake_on_change (self, key, MODEST_CONF_EVENT_KEY_CHANGED); + + return result; } @@ -351,7 +395,11 @@ modest_conf_remove_key (ModestConf* self, const gchar* key, GError **err) retval = gconf_client_recursive_unset (priv->gconf_client,key,0,err); gconf_client_suggest_sync (priv->gconf_client, NULL); - return retval; + if (retval) { + modest_conf_maemo_fake_on_change (self, key, MODEST_CONF_EVENT_KEY_UNSET); + return TRUE; + } else + return FALSE; } @@ -384,7 +432,8 @@ gchar* modest_conf_key_escape (const gchar* key) { g_return_val_if_fail (key, NULL); - + g_return_val_if_fail (strlen (key) > 0, g_strdup (key)); + return gconf_escape_key (key, strlen(key)); } @@ -403,9 +452,7 @@ modest_conf_key_is_valid (const gchar* key) return gconf_valid_key (key, NULL); } - - - +/* hmmm... might need to make specific callback for specific keys */ static void modest_conf_on_change (GConfClient *client, guint conn_id, GConfEntry *entry, gpointer data) @@ -421,10 +468,11 @@ modest_conf_on_change (GConfClient *client, guint conn_id, GConfEntry *entry, key, event); } + static GConfValueType modest_conf_type_to_gconf_type (ModestConfValueType value_type, GError **err) { - GConfValueType gconf_type = 0; + GConfValueType gconf_type; switch (value_type) { case MODEST_CONF_VALUE_INT: @@ -441,7 +489,84 @@ modest_conf_type_to_gconf_type (ModestConfValueType value_type, GError **err) break; default: /* FIXME: use MODEST_ERROR, and error code */ - *err = g_error_new_literal (0, 0, _("Invalid list value type")); - } + gconf_type = GCONF_VALUE_INVALID; + g_printerr ("modest: invalid list value type %d\n", value_type); + *err = g_error_new_literal (0, 0, "invalid list value type"); + } return gconf_type; } + + + +//////////////////////////////////////////////////////////////////////////////// +/* workaround for the b0rked dbus-gconf on maemo */ +/* fires a fake change notification after 0.3 secs. + * Might not be necessary anymore. */ +#if 0 +#ifdef MODEST_PLATFORM_MAEMO +typedef struct { + GObject *obj; + gchar *key; +} ChangeHelper; + +ChangeHelper* +change_helper_new (ModestConf *conf, const gchar *key) +{ + ChangeHelper *helper = g_slice_alloc (sizeof(ChangeHelper)); + helper->obj = g_object_ref(G_OBJECT(conf)); + helper->key = g_strdup (key); + return helper; +} + +static void +change_helper_free (ChangeHelper *helper) +{ + g_object_unref (helper->obj); + g_free (helper->key); + helper->key = NULL; + helper->obj = NULL; + g_slice_free (ChangeHelper,helper); +} + +static gboolean +emit_change_cb (ChangeHelper *helper) +{ + if (!helper) + return FALSE; + g_signal_emit (G_OBJECT(helper->obj),signals[KEY_CHANGED_SIGNAL], 0, + helper->key, MODEST_CONF_EVENT_KEY_CHANGED); + change_helper_free (helper); + + return FALSE; +} + +static gboolean +emit_remove_cb (ChangeHelper *helper) +{ + if (!helper) + return FALSE; + g_signal_emit (G_OBJECT(helper->obj),signals[KEY_CHANGED_SIGNAL], 0, + helper->key, MODEST_CONF_EVENT_KEY_UNSET); + change_helper_free (helper); + + return FALSE; +} +#endif /* MODEST_PLATFORM_MAEMO */ +#endif + +static void +modest_conf_maemo_fake_on_change (ModestConf *conf, const gchar* key, ModestConfEvent event) +{ +/* hack for faster notification, might not be necessary anymore: */ +#if 0 +#ifdef MODEST_PLATFORM_MAEMO + + ChangeHelper *helper = change_helper_new (conf,key); + g_timeout_add (100, /* after 100 ms */ + (event == MODEST_CONF_EVENT_KEY_CHANGED) + ? (GSourceFunc)emit_change_cb : (GSourceFunc)emit_remove_cb, + (gpointer)helper); +#endif /* MODEST_PLATFORM_MAEMO */ +#endif +} +//////////////////////////////////////////////////////////////////////////////////