X-Git-Url: http://git.maemo.org/git/?p=modest;a=blobdiff_plain;f=src%2Fmodest-tny-account.c;h=9b55d10e26fa81d5fc2a01ad9aa30f18b76ea504;hp=8b750e300b1a5b05202dd38ba706e05fb9ae8327;hb=16d7f8b9f45217e350735e33ee6d0255aa894074;hpb=622a810e13a3b84ecff6c620ae39c3828ea3214e diff --git a/src/modest-tny-account.c b/src/modest-tny-account.c index 8b750e3..9b55d10 100644 --- a/src/modest-tny-account.c +++ b/src/modest-tny-account.c @@ -27,12 +27,12 @@ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ +#include #include #include #include #include #include -#include #include #include #include @@ -63,7 +63,7 @@ modest_tny_account_get_special_folder (TnyAccount *account, NULL); TnyAccount *local_account = NULL; - + /* The accounts have already been instantiated by * modest_tny_account_store_get_accounts(), which is the * TnyAccountStore::get_accounts_func() implementation, @@ -74,21 +74,24 @@ modest_tny_account_get_special_folder (TnyAccount *account, if (special_type == TNY_FOLDER_TYPE_OUTBOX) { const gchar *modest_account_name = modest_tny_account_get_parent_modest_account_name_for_server_account (account); - g_assert (modest_account_name); - - gchar *account_id = g_strdup_printf ( - MODEST_PER_ACCOUNT_LOCAL_OUTBOX_FOLDER_ACCOUNT_ID_PREFIX "%s", - modest_account_name); - local_account = modest_tny_account_store_get_tny_account_by (modest_runtime_get_account_store(), - MODEST_TNY_ACCOUNT_STORE_QUERY_ID, - account_id); - if (!local_account) { - g_printerr ("modest: %s: modest_tny_account_store_get_tny_account_by(ID) returned NULL for %s\n", __FUNCTION__, account_id); - return NULL; + if (modest_account_name) { + gchar *account_id = g_strdup_printf ( + MODEST_PER_ACCOUNT_LOCAL_OUTBOX_FOLDER_ACCOUNT_ID_PREFIX "%s", + modest_account_name); + + local_account = modest_tny_account_store_get_tny_account_by (modest_runtime_get_account_store(), + MODEST_TNY_ACCOUNT_STORE_QUERY_ID, + account_id); + if (!local_account) { + g_printerr ("modest: %s: modest_tny_account_store_get_tny_account_by(ID) returned NULL for %s\n", __FUNCTION__, account_id); + return NULL; + } + + g_free (account_id); + } else { + g_warning ("%s: modest_account_name was NULL.", __FUNCTION__); } - - g_free (account_id); } else { /* Other local folders are all in one on-disk directory: */ local_account = modest_tny_account_store_get_tny_account_by (modest_runtime_get_account_store(), @@ -106,8 +109,13 @@ modest_tny_account_get_special_folder (TnyAccount *account, /* There is no need to do this _async, as these are local folders. */ /* TODO: However, this seems to fail sometimes when the network is busy, * returning an empty list. murrayc. */ + GError *error = NULL; tny_folder_store_get_folders (TNY_FOLDER_STORE (local_account), - folders, NULL, NULL); + folders, NULL, &error); + if (error) { + g_warning ("%s: tny_folder_store_get_folders() failed:\n error=%s\n", + __FUNCTION__, error->message); + } if (tny_list_get_length (folders) == 0) { gchar* url_string = tny_account_get_url_string (local_account); @@ -121,12 +129,15 @@ modest_tny_account_get_special_folder (TnyAccount *account, while (!tny_iterator_is_done (iter)) { TnyFolder *folder = TNY_FOLDER (tny_iterator_get_current (iter)); - if (modest_tny_folder_get_local_folder_type (folder) == special_type) { - special_folder = folder; - break; - } + if (folder) { + if (modest_tny_folder_get_local_or_mmc_folder_type (folder) == special_type) { + special_folder = folder; + break; /* Leaving a ref for the special_folder return value. */ + } - g_object_unref (G_OBJECT(folder)); + g_object_unref (G_OBJECT(folder)); + } + tny_iterator_next (iter); } @@ -143,34 +154,72 @@ modest_tny_account_get_special_folder (TnyAccount *account, return special_folder; } -static void -on_connection_status_changed (TnyAccount *account, TnyConnectionStatus status, gpointer user_data) +/** + * create_tny_account: + * @account_mgr: a valid account mgr instance + * @session: A valid TnySessionCamel instance. + * @account_data: the server account for which to create a corresponding tny account + * + * get a tnyaccount corresponding to the server_accounts (store or transport) for this account. + * NOTE: this function does not set the camel session or the get/forget password functions + * + * Returns: a new TnyAccount or NULL in case of error. + */ +static TnyAccount* +create_tny_account (ModestAccountMgr *account_mgr, + TnySessionCamel *session, + ModestServerAccountData *account_data) { - printf ("DEBUG: %s: status=%d\n", __FUNCTION__, status); + g_return_val_if_fail (account_mgr, NULL); + g_return_val_if_fail (session, NULL); + g_return_val_if_fail (account_data, NULL); + + /* sanity checks */ + if (account_data->proto == MODEST_PROTOCOL_TRANSPORT_STORE_UNKNOWN) { + g_printerr ("modest: '%s' does not provide a protocol\n", + account_data->account_name); + return NULL; + } + + TnyAccount *tny_account = NULL; - if (status == TNY_CONNECTION_STATUS_DISCONNECTED) { - /* We are trying to use the network with an account, - * but the accounts are set as offline, because our TnyDevice is offline, - * because libconic says we are offline. - * So ask the user to go online: - */ - modest_platform_connect_and_wait(NULL); - } else if (status == TNY_CONNECTION_STATUS_CONNECTED_BROKEN) { - printf ("DEBUG: %s: Connection broken. Forcing TnyDevice offline.\n", - __FUNCTION__); - - /* Something went wrong during some network operation. - * Stop trying to use the network now, - * by forcing accounts into offline mode: - * - * When libconic reconnects, it will set the device back online again, - * regardless of it being forced offline before. + switch (account_data->proto) { + case MODEST_PROTOCOL_TRANSPORT_SENDMAIL: + case MODEST_PROTOCOL_TRANSPORT_SMTP: + tny_account = TNY_ACCOUNT(tny_camel_transport_account_new ()); break; + case MODEST_PROTOCOL_STORE_POP: + tny_account = TNY_ACCOUNT(tny_camel_pop_store_account_new ()); break; + case MODEST_PROTOCOL_STORE_IMAP: + tny_account = TNY_ACCOUNT(tny_camel_imap_store_account_new ()); break; + case MODEST_PROTOCOL_STORE_MAILDIR: + case MODEST_PROTOCOL_STORE_MBOX: + /* Note that this is not where we create the special local folders account. + * That happens in modest_tny_account_new_for_local_folders() instead. */ - TnyDevice *device = modest_runtime_get_device (); - tny_device_force_offline (device); + tny_account = TNY_ACCOUNT(tny_camel_store_account_new()); break; + default: + g_return_val_if_reached (NULL); + } + if (!tny_account) { + g_printerr ("modest: could not create tny account for '%s'\n", + account_data->account_name); + return NULL; } + tny_account_set_id (tny_account, account_data->account_name); + + /* This must be set quite early, or other set() functions will fail. */ + tny_camel_account_set_session (TNY_CAMEL_ACCOUNT (tny_account), session); + + /* Proto */ + const gchar* proto_name = + modest_protocol_info_get_transport_store_protocol_name(account_data->proto); + tny_account_set_proto (tny_account, proto_name); + + return tny_account; } + + /* Camel options: */ /* These seem to be listed in @@ -193,7 +242,6 @@ on_connection_status_changed (TnyAccount *account, TnyConnectionStatus status, g #define MODEST_ACCOUNT_OPTION_USE_LSUB "use_lsub" /* Show only subscribed folders */ #define MODEST_ACCOUNT_OPTION_CHECK_ALL "check_all" /* Check for new messages in all folders */ - /* Posssible values for tny_account_set_secure_auth_mech(). * These might be camel-specific. * Really, tinymail should use an enum. @@ -209,90 +257,38 @@ on_connection_status_changed (TnyAccount *account, TnyConnectionStatus status, g #define MODEST_ACCOUNT_AUTH_PASSWORD "LOGIN" #define MODEST_ACCOUNT_AUTH_CRAMMD5 "CRAM-MD5" - /** - * modest_tny_account_new_from_server_account: + * update_tny_account: * @account_mgr: a valid account mgr instance - * @session: A valid TnySessionCamel instance. * @account_data: the server account for which to create a corresponding tny account - * @type: the type of account to create (TNY_ACCOUNT_TYPE_STORE or TNY_ACCOUNT_TYPE_TRANSPORT) * * get a tnyaccount corresponding to the server_accounts (store or transport) for this account. * NOTE: this function does not set the camel session or the get/forget password functions * * Returns: a new TnyAccount or NULL in case of error. */ -static TnyAccount* -modest_tny_account_new_from_server_account (ModestAccountMgr *account_mgr, - TnySessionCamel *session, - ModestServerAccountData *account_data) +static gboolean +update_tny_account (TnyAccount *tny_account, ModestAccountMgr *account_mgr, + ModestServerAccountData *account_data) { gchar *url = NULL; - - g_return_val_if_fail (account_mgr, NULL); - g_return_val_if_fail (session, NULL); - g_return_val_if_fail (account_data, NULL); - - /* sanity checks */ - if (account_data->proto == MODEST_PROTOCOL_TRANSPORT_STORE_UNKNOWN) { - g_printerr ("modest: '%s' does not provide a protocol\n", - account_data->account_name); - return NULL; - } - - TnyAccount *tny_account = NULL; - switch (account_data->proto) { - case MODEST_PROTOCOL_TRANSPORT_SENDMAIL: - case MODEST_PROTOCOL_TRANSPORT_SMTP: - tny_account = TNY_ACCOUNT(tny_camel_transport_account_new ()); break; - case MODEST_PROTOCOL_STORE_POP: - tny_account = TNY_ACCOUNT(tny_camel_pop_store_account_new ()); break; - case MODEST_PROTOCOL_STORE_IMAP: - tny_account = TNY_ACCOUNT(tny_camel_imap_store_account_new ()); break; - case MODEST_PROTOCOL_STORE_MAILDIR: - case MODEST_PROTOCOL_STORE_MBOX: - /* Note that this is not where we create the special local folders account. - * That happens in modest_tny_account_new_for_local_folders() instead. - */ - tny_account = TNY_ACCOUNT(tny_camel_store_account_new()); break; - default: - g_return_val_if_reached (NULL); - } - if (!tny_account) { - g_printerr ("modest: could not create tny account for '%s'\n", - account_data->account_name); - return NULL; - } - tny_account_set_id (tny_account, account_data->account_name); - - /* This must be set quite early, or other set() functions will fail. */ - tny_camel_account_set_session (TNY_CAMEL_ACCOUNT (tny_account), session); - - /* Handle connection requests: - * This (badly-named) signal will be called when we try to use an offline account. */ - g_signal_connect (G_OBJECT (tny_account), "connection-status-changed", - G_CALLBACK (on_connection_status_changed), NULL); - - /* Proto */ - const gchar* proto_name = - modest_protocol_info_get_transport_store_protocol_name(account_data->proto); - tny_account_set_proto (tny_account, proto_name); + g_return_val_if_fail (account_mgr, FALSE); + g_return_val_if_fail (account_data, FALSE); + g_return_val_if_fail (tny_account, FALSE); + tny_account_set_id (tny_account, account_data->account_name); /* mbox and maildir accounts use a URI instead of the rest: * Note that this is not where we create the special local folders account. * We do that in modest_tny_account_new_for_local_folders() instead. */ - if (account_data->uri) { + if (account_data->uri) tny_account_set_url_string (TNY_ACCOUNT(tny_account), account_data->uri); -/* g_message ("DEBUG: %s: local account-url:\n %s", __FUNCTION__, account_data->uri); */ - } else { /* Set camel-specific options: */ /* Enable secure connection settings: */ - /* printf("DEBUG: %s: security=%d\n", __FUNCTION__, account_data->security); */ const gchar* option_security = NULL; switch (account_data->security) { case MODEST_PROTOCOL_CONNECTION_NORMAL: @@ -319,7 +315,7 @@ modest_tny_account_new_from_server_account (ModestAccountMgr *account_mgr, option_security); /* Secure authentication: */ - /* printf("DEBUG: %s: secure-auth=%d\n", __FUNCTION__, account_data->secure_auth); */ + const gchar* auth_mech_name = NULL; switch (account_data->secure_auth) { case MODEST_PROTOCOL_AUTH_NONE: @@ -383,33 +379,114 @@ modest_tny_account_new_from_server_account (ModestAccountMgr *account_mgr, /* FIXME: for debugging. * Let's keep this because it is very useful for debugging. */ url = tny_account_get_url_string (TNY_ACCOUNT(tny_account)); - - printf ("DEBUG %s:\n account-url: %s\n", __FUNCTION__, url); + g_debug ("%s:\n account-url: %s\n", __FUNCTION__, url); g_free (url); - /***********************/ - - return tny_account; + return TRUE; } TnyAccount* modest_tny_account_new_from_server_account_name (ModestAccountMgr *account_mgr, - TnySessionCamel *session, - const gchar *server_account_name) + TnySessionCamel *session, + const gchar *server_account_name) { - ModestServerAccountData *account_data = - modest_account_mgr_get_server_account_data (account_mgr, - server_account_name); + ModestServerAccountData *account_data; + TnyAccount *tny_account; + + g_return_val_if_fail (session, NULL); + g_return_val_if_fail (server_account_name, NULL); + + account_data = modest_account_mgr_get_server_account_data (account_mgr, + server_account_name); if (!account_data) return NULL; - TnyAccount *result = modest_tny_account_new_from_server_account ( - account_mgr, session, account_data); - + tny_account = create_tny_account (account_mgr, session, account_data); + if (!tny_account) + g_warning ("%s: failed to create tny_account", __FUNCTION__); + else if (!update_tny_account (tny_account, account_mgr, account_data)) + g_warning ("%s: failed to initialize tny_account", __FUNCTION__); + modest_account_mgr_free_server_account_data (account_mgr, account_data); - return result; + return tny_account; +} + + +#if 0 +gboolean +modest_tny_account_update_from_server_account_name (TnyAccount *tny_account, + ModestAccountMgr *account_mgr, + const gchar *server_account_name) +{ + ModestServerAccountData *account_data; + gboolean valid_account_type; + + g_return_val_if_fail (tny_account, FALSE); + g_return_val_if_fail (server_account_name, FALSE); + + account_data = modest_account_mgr_get_server_account_data (account_mgr, + server_account_name); + if (!account_data) { + g_warning ("%s: failed to get server account data for %s", + __FUNCTION__, server_account_name); + return FALSE; + } + + valid_account_type = FALSE; + + /* you cannot change the protocol type of an existing account; + * so double check we don't even try + */ + switch (account_data->proto) { + case MODEST_PROTOCOL_TRANSPORT_SENDMAIL: + case MODEST_PROTOCOL_TRANSPORT_SMTP: + if (!TNY_IS_CAMEL_TRANSPORT_ACCOUNT(tny_account)) + g_warning ("%s: expecting transport account", __FUNCTION__); + else + valid_account_type = TRUE; + break; + case MODEST_PROTOCOL_STORE_POP: + if (!TNY_IS_CAMEL_POP_STORE_ACCOUNT(tny_account)) + g_warning ("%s: expecting pop account", __FUNCTION__); + else + valid_account_type = TRUE; + break; + case MODEST_PROTOCOL_STORE_IMAP: + if (!TNY_IS_CAMEL_IMAP_STORE_ACCOUNT(tny_account)) + g_warning ("%s: expecting imap account", __FUNCTION__); + else + valid_account_type = TRUE; + break; + case MODEST_PROTOCOL_STORE_MAILDIR: + case MODEST_PROTOCOL_STORE_MBOX: + if (!TNY_IS_CAMEL_STORE_ACCOUNT(tny_account)) + g_warning ("%s: expecting store account", __FUNCTION__); + else + valid_account_type = TRUE; + break; + default: + g_warning ("invalid account type"); + } + + if (!valid_account_type) { + g_warning ("%s: protocol type cannot be changed", __FUNCTION__); + modest_account_mgr_free_server_account_data (account_mgr, account_data); + return FALSE; + } + + if (!update_tny_account (tny_account, account_mgr, account_data)) { + g_warning ("%s: failed to update account", __FUNCTION__); + modest_account_mgr_free_server_account_data (account_mgr, account_data); + return FALSE; + } + + modest_account_mgr_free_server_account_data (account_mgr, account_data); + return TRUE; } +#endif + + /* we need these dummy functions, or tinymail will complain */ @@ -424,8 +501,90 @@ forget_pass_dummy (TnyAccount *account) /* intentionally left blank */ } + +static void +set_online_callback (TnyCamelAccount *account, gboolean canceled, GError *err, gpointer user_data) +{ + /* MODEST TODO: Show a real error message here, this is a significant error! + * Perhaps show the account's settings dialog again?! Reconnecting after + * changing the settings of an account failed in this situation. */ + + if (err && !canceled) + g_warning ("err: %s", err->message); +} + +gboolean +modest_tny_account_update_from_account (TnyAccount *tny_account) +{ + ModestAccountData *account_data = NULL; + ModestServerAccountData *server_data = NULL; + TnyConnectionStatus conn_status; + ModestAccountMgr *account_mgr; + const gchar *account_name; + TnyAccountType type; + + g_return_val_if_fail (tny_account, FALSE); + + account_mgr = modest_runtime_get_account_mgr (); + account_name = modest_tny_account_get_parent_modest_account_name_for_server_account (tny_account); + type = tny_account_get_account_type (tny_account); + account_data = modest_account_mgr_get_account_data (account_mgr, account_name); + if (!account_data) { + g_printerr ("modest: %s: cannot get account data for account %s\n", + __FUNCTION__, account_name); + return FALSE; + } + + if (type == TNY_ACCOUNT_TYPE_STORE && account_data->store_account) + server_data = account_data->store_account; + else if (type == TNY_ACCOUNT_TYPE_TRANSPORT && account_data->transport_account) + server_data = account_data->transport_account; + if (!server_data) { + g_printerr ("modest: no %s account defined for '%s'\n", + type == TNY_ACCOUNT_TYPE_STORE ? "store" : "transport", + account_data->display_name); + modest_account_mgr_free_account_data (account_mgr, account_data); + return FALSE; + } + + update_tny_account (tny_account, account_mgr, server_data); + + /* This name is what shows up in the folder view -- so for some POP/IMAP/... server + * account, we set its name to the account of which it is part. */ + + if (account_data->display_name) + tny_account_set_name (tny_account, account_data->display_name); + + modest_account_mgr_free_account_data (account_mgr, account_data); + + /* If the account was online, reconnect to apply the changes */ + conn_status = tny_account_get_connection_status (tny_account); + if (conn_status != TNY_CONNECTION_STATUS_DISCONNECTED) { + TnyAccountStore *account_store = NULL; + + /* The callback will have an error for you if the reconnect + * failed. Please handle it (this is TODO). */ + + account_store = TNY_ACCOUNT_STORE(g_object_get_data (G_OBJECT(tny_account), + "account_store")); + + if (account_store) { + modest_tny_account_store_forget_already_asked (MODEST_TNY_ACCOUNT_STORE (account_store), + tny_account); + } + + tny_camel_account_set_online (TNY_CAMEL_ACCOUNT(tny_account), TRUE, + set_online_callback, "online"); + } + + return TRUE; +} + + + TnyAccount* -modest_tny_account_new_from_account (ModestAccountMgr *account_mgr, const gchar *account_name, +modest_tny_account_new_from_account (ModestAccountMgr *account_mgr, + const gchar *account_name, TnyAccountType type, TnySessionCamel *session, TnyGetPassFunc get_pass_func, @@ -438,10 +597,13 @@ modest_tny_account_new_from_account (ModestAccountMgr *account_mgr, const gchar g_return_val_if_fail (account_mgr, NULL); g_return_val_if_fail (account_name, NULL); g_return_val_if_fail (session, NULL); + g_return_val_if_fail (type == TNY_ACCOUNT_TYPE_STORE || type == TNY_ACCOUNT_TYPE_TRANSPORT, + NULL); account_data = modest_account_mgr_get_account_data (account_mgr, account_name); if (!account_data) { - g_printerr ("modest: %s: cannot get account data for account %s\n", __FUNCTION__, account_name); + g_printerr ("modest: %s: cannot get account data for account %s\n", + __FUNCTION__, account_name); return NULL; } @@ -457,46 +619,30 @@ modest_tny_account_new_from_account (ModestAccountMgr *account_mgr, const gchar return NULL; } - tny_account = modest_tny_account_new_from_server_account (account_mgr, session, server_data); + tny_account = create_tny_account (account_mgr,session, server_data); if (!tny_account) { g_printerr ("modest: failed to create tny account for %s (%s)\n", account_data->account_name, server_data->account_name); modest_account_mgr_free_account_data (account_mgr, account_data); return NULL; - } - + } else + update_tny_account (tny_account, account_mgr, server_data); + + /* This name is what shows up in the folder view -- so for some POP/IMAP/... server + * account, we set its name to the account of which it is part. */ + + if (account_data->display_name) + tny_account_set_name (tny_account, account_data->display_name); + tny_account_set_forget_pass_func (tny_account, forget_pass_func ? forget_pass_func : forget_pass_dummy); tny_account_set_pass_func (tny_account, get_pass_func ? get_pass_func: get_pass_dummy); - - /* This name is what shows up in the folder view -- so for some POP/IMAP/... server - * account, we set its name to the account of which it is part. */ - - if (account_data->display_name) - tny_account_set_name (tny_account, account_data->display_name); - - modest_tny_account_set_parent_modest_account_name_for_server_account (tny_account, account_name); - + modest_tny_account_set_parent_modest_account_name_for_server_account (tny_account, + account_name); modest_account_mgr_free_account_data (account_mgr, account_data); -/* - TnyAccountStore *astore = (TnyAccountStore *) modest_runtime_get_account_store (); - if (astore) { - TnyDevice *device = tny_account_store_get_device (astore); - GError *err = NULL; - g_object_set_data (G_OBJECT(tny_account), "account_store", (gpointer)astore); - tny_camel_account_set_online (TNY_CAMEL_ACCOUNT (tny_account), - tny_device_is_online (device), &err); - if (err) { - g_print ("%s: tny_camel_account_set_online() failed: %s\n", __FUNCTION__, err->message); - g_error_free (err); - } - g_object_unref (device); - } -*/ - return tny_account; } @@ -534,7 +680,10 @@ on_modest_file_system_info(HildonFileSystemInfoHandle *handle, } /* printf ("DEBUG: %s: display name=%s\n", __FUNCTION__, display_name); */ - tny_account_set_name (account, display_name); + if (display_name && previous_display_name && + (strcmp (display_name, previous_display_name) != 0)) { + tny_account_set_name (account, display_name); + } /* Inform the application that the name is now ready: */ if (callback_data->callback) @@ -758,9 +907,12 @@ modest_tny_account_new_for_per_account_local_outbox_folder (ModestAccountMgr *ac typedef gint (*TnyStatsFunc) (TnyFolderStats *stats); +#define TASK_GET_ALL_COUNT 0 +#define TASK_GET_LOCAL_SIZE 1 +#define TASK_GET_FOLDER_COUNT 2 typedef struct _RecurseFoldersHelper { - TnyStatsFunc function; + gint task; guint sum; guint folders; } RecurseFoldersHelper; @@ -779,23 +931,22 @@ recurse_folders (TnyFolderStore *store, helper->folders += tny_list_get_length (folders); while (!tny_iterator_is_done (iter)) { - TnyFolderStats *stats; TnyFolder *folder; folder = TNY_FOLDER (tny_iterator_get_current (iter)); - stats = tny_folder_get_stats (folder); + if (folder) { + if (helper->task == TASK_GET_ALL_COUNT) + helper->sum += tny_folder_get_all_count (folder); - if (stats) { - /* initially, we sometimes get -1 from tinymail; ignore that */ - if (helper->function && helper->function (stats) > 0) - helper->sum += helper->function (stats); + if (helper->task == TASK_GET_LOCAL_SIZE) + helper->sum += tny_folder_get_local_size (folder); - if (TNY_IS_FOLDER_STORE (folder)) { + if (TNY_IS_FOLDER_STORE (folder)) recurse_folders (TNY_FOLDER_STORE (folder), query, helper); - } - g_object_unref (stats); - } - g_object_unref (folder); + + g_object_unref (folder); + } + tny_iterator_next (iter); } g_object_unref (G_OBJECT (iter)); @@ -812,8 +963,7 @@ modest_tny_folder_store_get_folder_count (TnyFolderStore *self) /* Create helper */ helper = g_malloc0 (sizeof (RecurseFoldersHelper)); - helper->function = NULL; - helper->sum = 0; + helper->task = TASK_GET_FOLDER_COUNT; helper->folders = 0; recurse_folders (self, NULL, helper); @@ -835,8 +985,9 @@ modest_tny_folder_store_get_message_count (TnyFolderStore *self) /* Create helper */ helper = g_malloc0 (sizeof (RecurseFoldersHelper)); - helper->function = (TnyStatsFunc) tny_folder_stats_get_all_count; - helper->sum = 0; + helper->task = TASK_GET_ALL_COUNT; + if (TNY_IS_FOLDER (self)) + helper->sum = tny_folder_get_all_count (TNY_FOLDER (self)); recurse_folders (self, NULL, helper); @@ -857,8 +1008,9 @@ modest_tny_folder_store_get_local_size (TnyFolderStore *self) /* Create helper */ helper = g_malloc0 (sizeof (RecurseFoldersHelper)); - helper->function = (TnyStatsFunc) tny_folder_stats_get_local_size; - helper->sum = 0; + helper->task = TASK_GET_LOCAL_SIZE; + if (TNY_IS_FOLDER (self)) + helper->sum = tny_folder_get_local_size (TNY_FOLDER (self)); recurse_folders (self, NULL, helper); @@ -869,17 +1021,43 @@ modest_tny_folder_store_get_local_size (TnyFolderStore *self) return retval; } -const gchar* modest_tny_account_get_parent_modest_account_name_for_server_account (TnyAccount *self) +const gchar* +modest_tny_account_get_parent_modest_account_name_for_server_account (TnyAccount *self) { return (const gchar *)g_object_get_data (G_OBJECT (self), "modest_account"); } -void modest_tny_account_set_parent_modest_account_name_for_server_account (TnyAccount *self, const gchar* parent_modest_acount_name) +void +modest_tny_account_set_parent_modest_account_name_for_server_account (TnyAccount *self, + const gchar* parent_modest_account_name) { g_object_set_data_full (G_OBJECT(self), "modest_account", - (gpointer) g_strdup (parent_modest_acount_name), g_free); + (gpointer) g_strdup (parent_modest_account_name), g_free); } +gboolean +modest_tny_account_is_virtual_local_folders (TnyAccount *self) +{ + /* We should make this more sophisticated if we ever use ModestTnyLocalFoldersAccount + * for anything else. */ + return MODEST_IS_TNY_LOCAL_FOLDERS_ACCOUNT (self); +} +gboolean +modest_tny_account_is_memory_card_account (TnyAccount *self) +{ + const gchar* account_id = NULL; + + g_return_val_if_fail (TNY_ACCOUNT (self), FALSE); + if (!self) + return FALSE; + + account_id = tny_account_get_id (self); + + if (!account_id) + return FALSE; + else + return (strcmp (account_id, MODEST_MMC_ACCOUNT_ID) == 0); +}