X-Git-Url: http://git.maemo.org/git/?p=modest;a=blobdiff_plain;f=src%2Fmodest-tny-msg.c;h=627839991b8cb072f7e95e0ca14168f3ed65a3f8;hp=0164e212e024a773ec6e63d9abce5b2c8e4de3b9;hb=99e438caf4679a1daf2060f73fb5a97408fca388;hpb=ae6cc4558ea0f5afc82a06376200904ee7b061dd

diff --git a/src/modest-tny-msg.c b/src/modest-tny-msg.c
index 0164e21..6278399 100644
--- a/src/modest-tny-msg.c
+++ b/src/modest-tny-msg.c
@@ -211,15 +211,15 @@ copy_mime_part (TnyMimePart *part)
 	TnyStream *attachment_stream;
 
 	if (TNY_IS_MSG (part)) {
-		result = TNY_MIME_PART (tny_platform_factory_new_msg (modest_runtime_get_platform_factory ()));
-		attachment_content_type = "message/rfc822";
-		tny_mime_part_set_content_type (result, attachment_content_type);
-	} else {
-		result = tny_platform_factory_new_mime_part (
-			modest_runtime_get_platform_factory());
-		attachment_content_type = tny_mime_part_get_content_type (part);
+		g_object_ref (part);
+		return part;
 	}
 
+	result = tny_platform_factory_new_mime_part (
+		modest_runtime_get_platform_factory());
+
+	attachment_content_type = tny_mime_part_get_content_type (part);
+
 	/* get mime part headers */
 	attachment_filename = tny_mime_part_get_filename (part);
 	attachment_cid = tny_mime_part_get_content_id (part);
@@ -242,9 +242,12 @@ copy_mime_part (TnyMimePart *part)
 	iterator = tny_list_create_iterator (parts);
 	while (!tny_iterator_is_done (iterator)) {
 		TnyMimePart *subpart = TNY_MIME_PART (tny_iterator_get_current (iterator));
-		TnyMimePart *subpart_copy = copy_mime_part (subpart);
-		tny_mime_part_add_part (result, subpart_copy);
-		g_object_unref (subpart);
+		if (subpart) {
+			TnyMimePart *subpart_copy = copy_mime_part (subpart);
+			tny_mime_part_add_part (result, subpart_copy);
+			g_object_unref (subpart);
+		}
+
 		tny_iterator_next (iterator);
 	}
 	g_object_unref (iterator);
@@ -265,18 +268,20 @@ add_attachments (TnyMsg *msg, GList *attachments_list)
 		old_attachment = pos->data;
 		attachment_part = copy_mime_part (old_attachment);
 		tny_mime_part_add_part (TNY_MIME_PART (msg), attachment_part);
+		g_object_unref (attachment_part);
 	}
 }
 
 
 gchar * 
-modest_tny_msg_get_body (TnyMsg *msg, gboolean want_html)
+modest_tny_msg_get_body (TnyMsg *msg, gboolean want_html, gboolean *is_html)
 {
 	TnyStream *stream;
 	TnyMimePart *body;
 	GtkTextBuffer *buf;
 	GtkTextIter start, end;
 	gchar *to_quote;
+	gboolean result_was_html = TRUE;
 
 	body = modest_tny_msg_find_body_part(msg, want_html);
 	if (!body)
@@ -294,12 +299,16 @@ modest_tny_msg_get_body (TnyMsg *msg, gboolean want_html)
 		gchar *to_quote_converted = modest_text_utils_convert_to_html (to_quote);
 		g_free (to_quote);
 		to_quote = to_quote_converted;
+		result_was_html = FALSE;
 	}
 
 	g_object_unref (buf);
 	g_object_unref (G_OBJECT(stream));
 	g_object_unref (G_OBJECT(body));
 
+	if (is_html != NULL)
+		*is_html = result_was_html;
+
 	return to_quote;
 }
 
@@ -309,8 +318,8 @@ modest_tny_msg_find_body_part_from_mime_part (TnyMimePart *msg, gboolean want_ht
 {
 	const gchar *mime_type = want_html ? "text/html" : "text/plain";
 	TnyMimePart *part = NULL;
-	TnyList *parts;
-	TnyIterator *iter;
+	TnyList *parts = NULL;
+	TnyIterator *iter = NULL;
 
 	if (!msg)
 		return NULL;
@@ -328,12 +337,19 @@ modest_tny_msg_find_body_part_from_mime_part (TnyMimePart *msg, gboolean want_ht
 		gchar *content_type = NULL;
 		do {
 			part = TNY_MIME_PART(tny_iterator_get_current (iter));
+			if (part && TNY_IS_MSG (part)) {
+				g_object_unref (part);
+				tny_iterator_next (iter);
+				continue;
+			}
 
 			/* we need to strdown the content type, because
 			 * tny_mime_part_has_content_type does not do it...
 			 */
-			content_type = g_ascii_strdown
-				(tny_mime_part_get_content_type (part), -1);
+			if (part) {
+				content_type = g_ascii_strdown
+					(tny_mime_part_get_content_type (part), -1);
+			}
 							
 			if (g_str_has_prefix (content_type, mime_type) &&
 			    !tny_mime_part_is_attachment (part))
@@ -344,6 +360,7 @@ modest_tny_msg_find_body_part_from_mime_part (TnyMimePart *msg, gboolean want_ht
 				if (part)
 					break;
 			}
+
 			if (part)
 				g_object_unref (G_OBJECT(part));
 
@@ -381,20 +398,25 @@ modest_tny_msg_find_body_part (TnyMsg *msg, gboolean want_html)
 
 
 static TnyMsg *
-create_reply_forward_mail (TnyMsg *msg, const gchar *from, const gchar *signature, 
+create_reply_forward_mail (TnyMsg *msg, TnyHeader *header, const gchar *from, const gchar *signature, 
 			   gboolean is_reply, guint type, GList *attachments)
 {
 	TnyMsg *new_msg;
-	TnyHeader *new_header, *header;
+	TnyHeader *new_header;
 	gchar *new_subject;
-	TnyMimePart *body;
+	TnyMimePart *body = NULL;
 	ModestFormatter *formatter;
 	gchar *subject_prefix;
 
 	/* Get body from original msg. Always look for the text/plain
 	   part of the message to create the reply/forwarded mail */
-	header = tny_msg_get_header (msg);
-	body   = modest_tny_msg_find_body_part (msg, FALSE);
+	if (header)
+		g_object_ref (header);
+	else
+		header = tny_msg_get_header (msg);
+
+	if (msg != NULL)
+		body   = modest_tny_msg_find_body_part (msg, FALSE);
 
 	/* TODO: select the formatter from account prefs */
 	if (modest_conf_get_bool (modest_runtime_get_conf (), MODEST_CONF_PREFER_FORMATTED_TEXT, NULL))
@@ -425,7 +447,8 @@ create_reply_forward_mail (TnyMsg *msg, const gchar *from, const gchar *signatur
 		}
 	}
 	g_object_unref (G_OBJECT(formatter));
-	g_object_unref (G_OBJECT(body));
+	if (body)
+		g_object_unref (G_OBJECT(body));
 	
 	/* Fill the header */
 	new_header = tny_msg_get_header (new_msg);	
@@ -460,8 +483,10 @@ add_if_attachment (gpointer data, gpointer user_data)
 	part = TNY_MIME_PART (data);
 	attachments_list = ((GList **) user_data);
 
-	if ((tny_mime_part_is_attachment (part))||(TNY_IS_MSG (part)))
+	if ((tny_mime_part_is_attachment (part))||(TNY_IS_MSG (part))) {
 		*attachments_list = g_list_prepend (*attachments_list, part);
+		g_object_ref (part);
+	}
 }
 
 TnyMsg* 
@@ -479,7 +504,7 @@ modest_tny_msg_create_forward_msg (TnyMsg *msg,
 	tny_mime_part_get_parts (TNY_MIME_PART (msg), parts);
 	tny_list_foreach (parts, add_if_attachment, &attachments_list);
 
-	new_msg = create_reply_forward_mail (msg, from, signature, FALSE, forward_type, attachments_list);
+	new_msg = create_reply_forward_mail (msg, NULL, from, signature, FALSE, forward_type, attachments_list);
 	add_attachments (new_msg, attachments_list);
 
 	/* Clean */
@@ -491,14 +516,15 @@ modest_tny_msg_create_forward_msg (TnyMsg *msg,
 }
 
 TnyMsg* 
-modest_tny_msg_create_reply_msg (TnyMsg *msg, 
+modest_tny_msg_create_reply_msg (TnyMsg *msg,
+				 TnyHeader *header,
 				 const gchar *from,
 				 const gchar *signature,
 				 ModestTnyMsgReplyType reply_type,
 				 ModestTnyMsgReplyMode reply_mode)
 {
 	TnyMsg *new_msg = NULL;
-	TnyHeader *new_header, *header;
+	TnyHeader *new_header;
 	const gchar* reply_to;
 	gchar *new_cc = NULL;
 	const gchar *cc = NULL, *bcc = NULL;
@@ -507,19 +533,25 @@ modest_tny_msg_create_reply_msg (TnyMsg *msg,
 	GList *attachments_list = NULL;
 
 	/* Add attachments */
-	parts = TNY_LIST (tny_simple_list_new());
-	tny_mime_part_get_parts (TNY_MIME_PART (msg), parts);
-	tny_list_foreach (parts, add_if_attachment, &attachments_list);
+	if (msg != NULL) {
+		parts = TNY_LIST (tny_simple_list_new());
+		tny_mime_part_get_parts (TNY_MIME_PART (msg), parts);
+		tny_list_foreach (parts, add_if_attachment, &attachments_list);
+	}
 
-	new_msg = create_reply_forward_mail (msg, from, signature, TRUE, reply_type, attachments_list);
+	new_msg = create_reply_forward_mail (msg, header, from, signature, TRUE, reply_type, attachments_list);
 	if (attachments_list) {
 		g_list_foreach (attachments_list, (GFunc) g_object_unref, NULL);
 		g_list_free (attachments_list);
 	}
-	g_object_unref (G_OBJECT (parts));
+	if (parts)
+		g_object_unref (G_OBJECT (parts));
 
 	/* Fill the header */
-	header = tny_msg_get_header (msg);
+	if (header)
+		g_object_ref (header);
+	else
+		header = tny_msg_get_header (msg);
 	new_header = tny_msg_get_header (new_msg);
 	reply_to = tny_header_get_replyto (header);