X-Git-Url: http://git.maemo.org/git/?p=modest;a=blobdiff_plain;f=src%2Fmodest-tny-send-queue.c;h=bb103ab95a9794c9f5833f74bb0f05973696444d;hp=37e26f95ef8873039a248011542f12bf34b445ba;hb=f541209a85cb6c71c79da1df81afbe10c448690a;hpb=6c17aba6bf6657b38b47e8f08971a692583d4840;ds=sidebyside

diff --git a/src/modest-tny-send-queue.c b/src/modest-tny-send-queue.c
index 37e26f9..bb103ab 100644
--- a/src/modest-tny-send-queue.c
+++ b/src/modest-tny-send-queue.c
@@ -105,6 +105,9 @@ struct _ModestTnySendQueuePrivate {
 	/* Special folders */
 	TnyFolder *outbox;
 	TnyFolder *sentbox;
+
+	/* last was send receive operation?*/
+	gboolean requested_send_receive;
 };
 
 #define MODEST_TNY_SEND_QUEUE_GET_PRIVATE(o)      (G_TYPE_INSTANCE_GET_PRIVATE((o), \
@@ -189,6 +192,11 @@ modest_tny_send_queue_to_string (ModestTnySendQueue *self)
 	return str;
 }
 
+typedef struct {
+	TnySendQueueAddCallback callback;
+	gpointer user_data;
+} AddAsyncHelper;
+
 static void
 _on_added_to_outbox (TnySendQueue *self, 
 		     gboolean cancelled, 
@@ -201,13 +209,17 @@ _on_added_to_outbox (TnySendQueue *self,
 	SendInfo *info = NULL;
 	GList* existing = NULL;
 	gchar* msg_id = NULL;
+	AddAsyncHelper *helper;
 
 	g_return_if_fail (TNY_IS_SEND_QUEUE(self));
 	g_return_if_fail (TNY_IS_CAMEL_MSG(msg));
 
 	header = tny_msg_get_header (msg);
 	msg_id = modest_tny_send_queue_get_msg_id (header);
-	g_return_if_fail(msg_id != NULL);
+	if (!msg_id) {
+		g_warning ("%s: No msg_id returned for header", __FUNCTION__);
+		goto end;
+	}
 
 	/* Put newly added message in WAITING state */
 	existing = modest_tny_send_queue_lookup_info (MODEST_TNY_SEND_QUEUE(self), msg_id);
@@ -223,7 +235,14 @@ _on_added_to_outbox (TnySendQueue *self,
 
 	g_signal_emit (self, signals[STATUS_CHANGED_SIGNAL], 0, info->msg_id, info->status);
 
-	g_object_unref(G_OBJECT(header));
+ end:
+	g_object_unref (G_OBJECT(header));
+
+	/* Call the user callback */
+	helper = (AddAsyncHelper *) user_data;
+	if (helper->callback)
+		helper->callback (self, cancelled, msg, err, helper->user_data);
+	g_slice_free (AddAsyncHelper, helper);
 }
 
 static void
@@ -261,7 +280,7 @@ _add_message (ModestTnySendQueue *self, TnyHeader *header)
 			break;
 		
 		/* Add new meesage info */
-		info = g_slice_new (SendInfo);
+		info = g_slice_new0 (SendInfo);
 		info->msg_id = strdup(msg_uid);
 		info->status = MODEST_TNY_SEND_QUEUE_WAITING;
 		g_queue_push_tail (priv->queue, info);
@@ -281,8 +300,15 @@ modest_tny_send_queue_add_async (TnySendQueue *self,
 				 TnyStatusCallback status_callback, 
 				 gpointer user_data)
 {
+	AddAsyncHelper *helper = g_slice_new0 (AddAsyncHelper);
+	helper->callback = callback;
+	helper->user_data = user_data;
+
 	/* Call the superclass passing our own callback */
-	TNY_CAMEL_SEND_QUEUE_CLASS(parent_class)->add_async (self, msg, _on_added_to_outbox, NULL, NULL);
+	TNY_CAMEL_SEND_QUEUE_CLASS(parent_class)->add_async (self, msg, 
+							     _on_added_to_outbox, 
+							     status_callback, 
+							     helper);
 }
 
 
@@ -391,18 +417,84 @@ modest_tny_send_queue_finalize (GObject *obj)
 	G_OBJECT_CLASS(parent_class)->finalize (obj);
 }
 
+typedef struct {
+	TnyCamelTransportAccount *account;
+	ModestTnySendQueue *queue;
+} GetHeadersInfo;
+
+static void
+new_queue_get_headers_async_cb (TnyFolder *folder, 
+				gboolean cancelled, 
+				TnyList *headers, 
+				GError *err, 
+				gpointer user_data)
+{
+	ModestTnySendQueue *self;
+	TnyIterator *iter;
+	GetHeadersInfo *info;
+
+	info = (GetHeadersInfo *) user_data;
+	self = MODEST_TNY_SEND_QUEUE (info->queue);
+
+	/* In case of error set the transport account anyway */
+	if (cancelled || err)
+		goto set_transport;
+
+	/* Add messages to our internal queue */
+	iter = tny_list_create_iterator (headers);
+	while (!tny_iterator_is_done (iter)) {
+		TnyHeader *header = TNY_HEADER (tny_iterator_get_current (iter));
+		_add_message (self, header);
+		g_object_unref (header);	
+		tny_iterator_next (iter);
+	}
+
+	/* Reenable suspended items */
+	modest_tny_send_queue_wakeup (self);
+
+	/* Frees */
+	g_object_unref (iter);
+	g_object_unref (headers);
+
+ set_transport:
+	/* Do this at the end, because it'll call tny_send_queue_flush
+	   which will call tny_send_queue_get_outbox and
+	   tny_send_queue_get_sentbox */
+	tny_camel_send_queue_set_transport_account (TNY_CAMEL_SEND_QUEUE(self),
+						    info->account);
+
+	/* Frees */
+	g_object_unref (info->account); 
+	g_object_unref (info->queue); 
+	g_slice_free (GetHeadersInfo, info);
+}
+
 ModestTnySendQueue*
 modest_tny_send_queue_new (TnyCamelTransportAccount *account)
 {
 	ModestTnySendQueue *self = NULL;
 	ModestTnySendQueuePrivate *priv = NULL;
-	TnyIterator *iter = NULL;
 	TnyList *headers = NULL;
+	GetHeadersInfo *info;
 	
 	g_return_val_if_fail (TNY_IS_CAMEL_TRANSPORT_ACCOUNT(account), NULL);
 	
 	self = MODEST_TNY_SEND_QUEUE(g_object_new(MODEST_TYPE_TNY_SEND_QUEUE, NULL));
-	
+
+	/* Set outbox and sentbox */
+	priv = MODEST_TNY_SEND_QUEUE_GET_PRIVATE (self);
+	priv->outbox  = modest_tny_account_get_special_folder (TNY_ACCOUNT(account),
+							       TNY_FOLDER_TYPE_OUTBOX);
+	priv->sentbox = modest_tny_account_get_special_folder (TNY_ACCOUNT(account),
+							       TNY_FOLDER_TYPE_SENT);
+
+	/* NOTE that this could happen if there was not enough disk
+	   space when the account was created */
+	if (!priv->outbox || !priv->sentbox) {
+		g_object_unref (self);
+		return NULL;
+	}
+
 	/* Connect signals to control when a msg is being or has been sent */
 	g_signal_connect (G_OBJECT(self), "msg-sending",
 			  G_CALLBACK(_on_msg_start_sending),
@@ -417,39 +509,16 @@ modest_tny_send_queue_new (TnyCamelTransportAccount *account)
 			  G_CALLBACK (_on_queue_start),
 			  NULL);
 
-	/* Set outbox and sentbox */
-	priv = MODEST_TNY_SEND_QUEUE_GET_PRIVATE (self);
-	priv->outbox  = modest_tny_account_get_special_folder (TNY_ACCOUNT(account),
-							       TNY_FOLDER_TYPE_OUTBOX);
-	priv->sentbox = modest_tny_account_get_special_folder (TNY_ACCOUNT(account),
-							       TNY_FOLDER_TYPE_SENT);
-
-
-	headers = tny_simple_list_new ();	
-	tny_folder_get_headers (priv->outbox, headers, TRUE, NULL);
-
-	/* Add messages to our internal queue */
-	iter = tny_list_create_iterator (headers);
-	while (!tny_iterator_is_done (iter)) {
-		TnyHeader *header = TNY_HEADER (tny_iterator_get_current (iter));
-		_add_message (self, header); 
-		g_object_unref (header);		
-
-		tny_iterator_next (iter);
-	}
-
-	/* Reenable suspended items */
-	modest_tny_send_queue_wakeup (self);
 
-	/* Frees */
-	g_object_unref (headers);
-	g_object_unref (iter);
+	priv->requested_send_receive = FALSE;
 
-	/* Do this at the end, because it'll call tny_send_queue_flush
-	   which will call tny_send_queue_get_outbox and
-	   tny_send_queue_get_sentbox */
-	tny_camel_send_queue_set_transport_account (TNY_CAMEL_SEND_QUEUE(self),
-						    account); 
+	headers = tny_simple_list_new ();
+	info = g_slice_new0 (GetHeadersInfo);
+	info->account = g_object_ref (account);
+	info->queue = g_object_ref (self);
+	tny_folder_get_headers_async (priv->outbox, headers, TRUE, 
+				      new_queue_get_headers_async_cb, 
+				      NULL, info);
 
 	return self;
 }
@@ -497,16 +566,17 @@ gchar *
 modest_tny_send_queue_get_msg_id (TnyHeader *header)
 {
 	gchar* msg_uid = NULL;
-	const gchar *subject;
+	gchar *subject;
 	time_t date_received;
 		
 	g_return_val_if_fail (header && TNY_IS_HEADER(header), NULL);
 
 	/* Get message uid */
-	subject = tny_header_get_subject (header);
+	subject = tny_header_dup_subject (header);
 	date_received = tny_header_get_date_received (header);
 
 	msg_uid = g_strdup_printf ("%s %d", subject, (int) date_received);
+	g_free (subject);
 
 	return msg_uid;
 }
@@ -562,6 +632,8 @@ _on_msg_has_been_sent (TnySendQueue *self,
 
 	tny_header_set_flag (header, TNY_HEADER_FLAG_SEEN);
 
+	tny_folder_sync_async (priv->sentbox, FALSE, NULL, NULL, NULL);
+
 	/* Get status info */
 	item = modest_tny_send_queue_lookup_info (MODEST_TNY_SEND_QUEUE (self), msg_id);
 
@@ -598,7 +670,7 @@ _on_msg_error_happened (TnySendQueue *self,
 	   generic send queue errors with this signal as well, and
 	   those notifications are not bound to any particular header
 	   or message */
-	if (header) {
+	if (header && TNY_IS_HEADER (header)) {
 		SendInfo *info = NULL;
 		GList *item = NULL;
 		gchar* msg_uid = NULL;
@@ -606,16 +678,39 @@ _on_msg_error_happened (TnySendQueue *self,
 		/* Get sending info (create new if it doesn not exist) */
 		msg_uid = modest_tny_send_queue_get_msg_id (header);
 		item = modest_tny_send_queue_lookup_info (MODEST_TNY_SEND_QUEUE (self), 
-							  msg_uid);	
+							  msg_uid);
+
+		/* TODO: this should not happen (but it does), so the
+		   problem should be located in the way we generate
+		   the message uids */
+		if (!item) {
+			g_warning ("%s: could not find item with id '%s'", __FUNCTION__, msg_uid);
+			g_free(msg_uid);
+			return;
+		}
 		
 		info = item->data;
 
 		/* Keep in queue so that we remember that the opertion has failed */
 		/* and was not just cancelled */
-		if (err->code == TNY_SYSTEM_ERROR_CANCEL)
+		if (err->code == TNY_SYSTEM_ERROR_CANCEL) {
 			info->status = MODEST_TNY_SEND_QUEUE_SUSPENDED;
-		else
+		} else {
+			if (err->code == TNY_SERVICE_ERROR_CONNECT) {
+				TnyCamelTransportAccount* transport;
+
+				transport = tny_camel_send_queue_get_transport_account (TNY_CAMEL_SEND_QUEUE (self));
+				if (transport) {
+					gchar *message;					
+					message = g_strdup_printf (_("emev_ib_ui_smtp_server_invalid"), 
+								   tny_account_get_hostname (TNY_ACCOUNT (transport)));
+					modest_platform_run_alert_dialog (message, FALSE);
+					g_free (message);
+					g_object_unref (transport);
+				}
+			}
 			info->status = MODEST_TNY_SEND_QUEUE_FAILED;
+		}
 		priv->current = NULL;
 		
 		/* Notify status has changed */
@@ -681,13 +776,14 @@ modest_tny_all_send_queues_get_msg_status (TnyHeader *header)
 		iter = tny_list_create_iterator (accounts);
 		while (!tny_iterator_is_done (iter)) {			
 			account = TNY_TRANSPORT_ACCOUNT(tny_iterator_get_current (iter));
-			send_queue = modest_runtime_get_send_queue(TNY_TRANSPORT_ACCOUNT(account));
+			send_queue = modest_runtime_get_send_queue(TNY_TRANSPORT_ACCOUNT(account), TRUE);
 			g_object_unref(account);
-
-			queue_status = modest_tny_send_queue_get_msg_status (send_queue, msg_uid);
-			if (queue_status != MODEST_TNY_SEND_QUEUE_UNKNOWN) {
-				status = queue_status;
-				break;
+			if (TNY_IS_SEND_QUEUE (send_queue)) {
+				queue_status = modest_tny_send_queue_get_msg_status (send_queue, msg_uid);
+				if (queue_status != MODEST_TNY_SEND_QUEUE_UNKNOWN) {
+					status = queue_status;
+					break;
+				}
 			}
 			tny_iterator_next (iter);
 		}
@@ -711,19 +807,25 @@ modest_tny_all_send_queues_get_msg_status (TnyHeader *header)
 	return status;
 }
 
-void   
-modest_tny_send_queue_wakeup (ModestTnySendQueue *self)
+static void
+wakeup_get_headers_async_cb (TnyFolder *folder, 
+			     gboolean cancelled, 
+			     TnyList *headers, 
+			     GError *err, 
+			     gpointer user_data)
 {
+	ModestTnySendQueue *self;
 	ModestTnySendQueuePrivate *priv;
-	TnyList *headers;
 	TnyIterator *iter;
 
-	g_return_if_fail (MODEST_IS_TNY_SEND_QUEUE (self));
-
+	self = MODEST_TNY_SEND_QUEUE (user_data);
 	priv = MODEST_TNY_SEND_QUEUE_GET_PRIVATE (self);
 
-	headers = tny_simple_list_new ();
-	tny_folder_get_headers (priv->outbox, headers, TRUE, NULL);
+	if (cancelled || err) {
+		g_debug ("Failed to wake up the headers of the send queue");
+		g_object_unref (self);
+		return;
+	}
 
 	/* Wake up every single suspended header */
 	iter = tny_list_create_iterator (headers);
@@ -759,5 +861,45 @@ modest_tny_send_queue_wakeup (ModestTnySendQueue *self)
 
 	/* Frees */
 	g_object_unref (iter);
-	g_object_unref (G_OBJECT (headers));
+	g_object_unref (headers);
+	g_object_unref (self);
+}
+
+
+void   
+modest_tny_send_queue_wakeup (ModestTnySendQueue *self)
+{
+	ModestTnySendQueuePrivate *priv;
+	TnyList *headers;
+
+	g_return_if_fail (MODEST_IS_TNY_SEND_QUEUE (self));
+
+	priv = MODEST_TNY_SEND_QUEUE_GET_PRIVATE (self);
+
+	headers = tny_simple_list_new ();
+	tny_folder_get_headers_async (priv->outbox, headers, TRUE, 
+				      wakeup_get_headers_async_cb, 
+				      NULL, g_object_ref (self));
+}
+
+gboolean 
+modest_tny_send_queue_get_requested_send_receive (ModestTnySendQueue *self)
+{
+	ModestTnySendQueuePrivate *priv;
+
+	g_return_val_if_fail (MODEST_IS_TNY_SEND_QUEUE (self), FALSE);
+	priv = MODEST_TNY_SEND_QUEUE_GET_PRIVATE (self);
+
+	return priv->requested_send_receive;
+}
+
+void 
+modest_tny_send_queue_set_requested_send_receive (ModestTnySendQueue *self, gboolean requested_send_receive)
+{
+	ModestTnySendQueuePrivate *priv;
+
+	g_return_if_fail (MODEST_IS_TNY_SEND_QUEUE (self));
+	priv = MODEST_TNY_SEND_QUEUE_GET_PRIVATE (self);
+
+	priv->requested_send_receive = requested_send_receive;
 }