X-Git-Url: http://git.maemo.org/git/?p=modest;a=blobdiff_plain;f=src%2Fmodest-ui-actions.c;h=2239f56772cf9a6ceede9ac18a35a5a18f11853f;hp=8a0620ef17691cf4968a346a7c11a3be927f7885;hb=f6d386ff93e929092ba105385a29d760aeba9ff7;hpb=e90e0178c9c9874b3d45ffff4133a80fec30e2dd diff --git a/src/modest-ui-actions.c b/src/modest-ui-actions.c index 8a0620e..2239f56 100644 --- a/src/modest-ui-actions.c +++ b/src/modest-ui-actions.c @@ -41,7 +41,6 @@ #include #include "modest-error.h" #include "modest-ui-actions.h" -#include "modest-protocol-info.h" #include "modest-tny-platform-factory.h" #include "modest-platform.h" #include "modest-debug.h" @@ -52,9 +51,11 @@ #ifdef MODEST_PLATFORM_MAEMO #include "maemo/modest-osso-state-saving.h" +#endif /* MODEST_PLATFORM_MAEMO */ +#ifndef MODEST_TOOLKIT_GTK #include "maemo/modest-hildon-includes.h" #include "maemo/modest-connection-specific-smtp-window.h" -#endif /* MODEST_PLATFORM_MAEMO */ +#endif /* !MODEST_TOOLKIT_GTK */ #include #include "widgets/modest-ui-constants.h" @@ -82,6 +83,8 @@ #include +#define MIN_FREE_SPACE 5 * 1024 * 1024 + typedef struct _GetMsgAsyncHelper { ModestWindow *window; ModestMailOperation *mail_op; @@ -102,6 +105,7 @@ typedef struct _ReplyForwardHelper { ReplyForwardAction action; gchar *account_name; GtkWidget *parent_window; + TnyHeader *header; } ReplyForwardHelper; typedef struct _MoveToHelper { @@ -154,7 +158,7 @@ static gboolean connect_to_get_msg (ModestWindow *win, gint num_of_uncached_msgs, TnyAccount *account); -static gboolean remote_folder_is_pop (TnyFolderStore *folder); +static gboolean remote_folder_has_leave_on_server (TnyFolderStore *folder); static void do_create_folder (GtkWindow *window, TnyFolderStore *parent_folder, @@ -164,27 +168,23 @@ static GtkWidget* get_folder_view_from_move_to_dialog (GtkWidget *move_to_dialog static TnyAccount *get_account_from_folder_store (TnyFolderStore *folder_store); -static void transfer_messages_helper (GtkWindow *win, - TnyFolder *src_folder, - TnyList *headers, - TnyFolder *dst_folder); - /* * This function checks whether a TnyFolderStore is a pop account */ static gboolean -remote_folder_is_pop (TnyFolderStore *folder) +remote_folder_has_leave_on_server (TnyFolderStore *folder) { - const gchar *proto = NULL; - TnyAccount *account = NULL; + TnyAccount *account; + gboolean result; g_return_val_if_fail (TNY_IS_FOLDER_STORE (folder), FALSE); account = get_account_from_folder_store (folder); - proto = tny_account_get_proto (account); + result = (modest_protocol_registry_protocol_type_has_leave_on_server (modest_runtime_get_protocol_registry (), + modest_tny_account_get_protocol_type (account))); g_object_unref (account); - return (modest_protocol_info_get_transport_store_protocol (proto) == MODEST_PROTOCOL_STORE_POP); + return result; } /* FIXME: this should be merged with the similar code in modest-account-view-window */ @@ -219,10 +219,17 @@ modest_ui_actions_run_account_setup_wizard (ModestWindow *win) win = modest_window_mgr_get_main_window (modest_runtime_get_window_mgr(), TRUE); /* create if not existent */ - /* make sure the mainwindow is visible */ gtk_window_set_transient_for (GTK_WINDOW (wizard), GTK_WINDOW (win)); - gtk_widget_show_all (GTK_WIDGET(win)); - gtk_window_present (GTK_WINDOW(win)); + + /* make sure the mainwindow is visible. We need to present the + wizard again to give it the focus back. show_all are needed + in order to get the widgets properly drawn (MainWindow main + paned won't be in its right position and the dialog will be + missplaced */ + gtk_widget_show_all (GTK_WIDGET (win)); + gtk_widget_show_all (GTK_WIDGET (wizard)); + gtk_window_present (GTK_WINDOW (win)); + gtk_window_present (GTK_WINDOW (wizard)); dialog_response = gtk_dialog_run (GTK_DIALOG (wizard)); gtk_widget_destroy (GTK_WIDGET (wizard)); @@ -516,7 +523,6 @@ modest_ui_actions_on_delete_message (GtkAction *action, ModestWindow *win) /* Select next or previous row */ if (gtk_tree_row_reference_valid (next_row_reference)) { -/* next_path = gtk_tree_row_reference_get_path (row_reference); */ gtk_tree_selection_select_path (sel, next_path); } else if (gtk_tree_row_reference_valid (prev_row_reference)) { @@ -531,12 +537,14 @@ modest_ui_actions_on_delete_message (GtkAction *action, ModestWindow *win) if (prev_row_reference != NULL) gtk_tree_row_reference_free (prev_row_reference); if (prev_path != NULL) - gtk_tree_path_free (prev_path); + gtk_tree_path_free (prev_path); } /* Update toolbar dimming state */ - if (main_window) + if (main_window) { + modest_ui_actions_check_menu_dimming_rules (MODEST_WINDOW (main_window)); modest_ui_actions_check_toolbar_dimming_rules (MODEST_WINDOW (main_window)); + } /* Free */ g_list_foreach (sel_list, (GFunc) gtk_tree_path_free, NULL); @@ -653,7 +661,6 @@ modest_ui_actions_on_accounts (GtkAction *action, } else { /* Show the list of accounts */ GtkWindow *account_win = GTK_WINDOW (modest_account_view_window_new ()); - gtk_window_set_transient_for (account_win, GTK_WINDOW (win)); /* The accounts dialog must be modal */ modest_window_mgr_set_modal (modest_runtime_get_window_mgr (), account_win); @@ -661,18 +668,6 @@ modest_ui_actions_on_accounts (GtkAction *action, } } -#ifdef MODEST_PLATFORM_MAEMO -static void -on_smtp_servers_window_hide (GtkWindow* window, gpointer user_data) -{ - /* Save any changes. */ - modest_connection_specific_smtp_window_save_server_accounts ( - MODEST_CONNECTION_SPECIFIC_SMTP_WINDOW (window)); - gtk_widget_destroy (GTK_WIDGET (window)); -} -#endif - - void modest_ui_actions_on_smtp_servers (GtkAction *action, ModestWindow *win) { @@ -680,7 +675,7 @@ modest_ui_actions_on_smtp_servers (GtkAction *action, ModestWindow *win) * because it requires an API (libconic) to detect different connection * possiblities. */ -#ifdef MODEST_PLATFORM_MAEMO /* Defined in config.h */ +#ifndef MODEST_TOOLKIT_GTK /* Defined in config.h */ /* Create the window if necessary: */ GtkWidget *specific_window = GTK_WIDGET (modest_connection_specific_smtp_window_new ()); @@ -688,15 +683,11 @@ modest_ui_actions_on_smtp_servers (GtkAction *action, ModestWindow *win) MODEST_CONNECTION_SPECIFIC_SMTP_WINDOW (specific_window), modest_runtime_get_account_mgr()); - /* Show the window: */ - gtk_window_set_transient_for (GTK_WINDOW (specific_window), GTK_WINDOW (win)); - gtk_window_set_modal (GTK_WINDOW (specific_window), TRUE); + /* Show the window: */ + modest_window_mgr_set_modal (modest_runtime_get_window_mgr (), + GTK_WINDOW (specific_window)); gtk_widget_show (specific_window); - - /* Save changes when the window is hidden: */ - g_signal_connect (specific_window, "hide", - G_CALLBACK (on_smtp_servers_window_hide), win); -#endif /* MODEST_PLATFORM_MAEMO */ +#endif /* !MODEST_TOOLKIT_GTK */ } void @@ -718,6 +709,13 @@ modest_ui_actions_compose_msg(ModestWindow *win, ModestWindow *msg_win = NULL; ModestAccountMgr *mgr = modest_runtime_get_account_mgr(); ModestTnyAccountStore *store = modest_runtime_get_account_store(); + GnomeVFSFileSize total_size, allowed_size; + + /* we check for low-mem; in that case, show a warning, and don't allow + * composing a message with attachments + */ + if (attachments && modest_platform_check_memory_low (win, TRUE)) + goto cleanup; account_name = modest_account_mgr_get_default_account(mgr); if (!account_name) { @@ -742,12 +740,12 @@ modest_ui_actions_compose_msg(ModestWindow *win, signature = modest_account_mgr_get_signature (mgr, account_name, &use_signature); if (body_str != NULL) { - body = use_signature ? g_strconcat(body_str, "\n", signature, NULL) : g_strdup(body_str); + body = use_signature ? g_strconcat(body_str, "\n--\n", signature, NULL) : g_strdup(body_str); } else { - body = use_signature ? g_strconcat("\n", signature, NULL) : g_strdup(""); + body = use_signature ? g_strconcat("\n--\n", signature, NULL) : g_strdup(""); } - msg = modest_tny_msg_new (to_str, from_str, cc_str, bcc_str, subject_str, body, NULL); + msg = modest_tny_msg_new (to_str, from_str, cc_str, bcc_str, subject_str, body, NULL, NULL, NULL); if (!msg) { g_printerr ("modest: failed to create new msg\n"); goto cleanup; @@ -755,26 +753,40 @@ modest_ui_actions_compose_msg(ModestWindow *win, /* Create and register edit window */ /* This is destroyed by TODO. */ + total_size = 0; + allowed_size = MODEST_MAX_ATTACHMENT_SIZE; msg_win = modest_msg_edit_window_new (msg, account_name, FALSE); - while (attachments) { - modest_msg_edit_window_attach_file_one((ModestMsgEditWindow *)msg_win, - attachments->data); - attachments = g_slist_next(attachments); - } + modest_window_mgr_register_window (modest_runtime_get_window_mgr(), msg_win); modest_msg_edit_window_set_modified (MODEST_MSG_EDIT_WINDOW (msg_win), set_as_modified); - gtk_widget_show_all (GTK_WIDGET (msg_win)); + while (attachments) { + total_size += + modest_msg_edit_window_attach_file_one((ModestMsgEditWindow *)msg_win, + attachments->data, allowed_size); + + if (total_size > allowed_size) { + g_warning ("%s: total size: %u", + __FUNCTION__, (unsigned int)total_size); + break; + } + allowed_size -= total_size; + + attachments = g_slist_next(attachments); + } + cleanup: g_free (from_str); g_free (signature); g_free (body); g_free (account_name); - if (account) g_object_unref (G_OBJECT(account)); - if (folder) g_object_unref (G_OBJECT(folder)); - if (msg_win) g_object_unref (G_OBJECT(msg_win)); - if (msg) g_object_unref (G_OBJECT(msg)); + if (account) + g_object_unref (G_OBJECT(account)); + if (folder) + g_object_unref (G_OBJECT(folder)); + if (msg) + g_object_unref (G_OBJECT(msg)); } void @@ -799,6 +811,18 @@ modest_ui_actions_msg_retrieval_check (ModestMailOperation *mail_op, /* If there is no message or the operation was not successful */ status = modest_mail_operation_get_status (mail_op); if (!msg || status != MODEST_MAIL_OPERATION_STATUS_SUCCESS) { + const GError *error; + + /* If it's a memory low issue, then show a banner */ + error = modest_mail_operation_get_error (mail_op); + if (error && error->domain == MODEST_MAIL_OPERATION_ERROR && + error->code == MODEST_MAIL_OPERATION_ERROR_LOW_MEMORY) { + GObject *source = modest_mail_operation_get_source (mail_op); + modest_platform_run_information_dialog (GTK_IS_WINDOW (source) ? GTK_WINDOW (source) : NULL, + dgettext("ke-recv","memr_ib_operation_disabled"), + TRUE); + g_object_unref (source); + } /* Remove the header from the preregistered uids */ modest_window_mgr_unregister_header (modest_runtime_get_window_mgr (), @@ -831,7 +855,8 @@ open_msg_banner_idle (gpointer userdata) gdk_threads_enter (); banner_info->idle_handler = 0; banner_info->banner = modest_platform_animation_banner (NULL, NULL, banner_info->message); - g_object_ref (banner_info->banner); + if (banner_info) + g_object_ref (banner_info->banner); gdk_threads_leave (); @@ -886,14 +911,16 @@ open_msg_cb (ModestMailOperation *mail_op, char *msg_id; account = g_strdup(modest_tny_account_get_parent_modest_account_name_for_server_account( TNY_ACCOUNT(traccount))); - send_queue = modest_runtime_get_send_queue(traccount); - msg_id = modest_tny_send_queue_get_msg_id (header); - status = modest_tny_send_queue_get_msg_status(send_queue, msg_id); - /* Only open messages in outbox with the editor if they are in Failed state */ - if (status == MODEST_TNY_SEND_QUEUE_FAILED) { - open_in_editor = TRUE; + send_queue = modest_runtime_get_send_queue(traccount, TRUE); + if (TNY_IS_SEND_QUEUE (send_queue)) { + msg_id = modest_tny_send_queue_get_msg_id (header); + status = modest_tny_send_queue_get_msg_status(send_queue, msg_id); + /* Only open messages in outbox with the editor if they are in Failed state */ + if (status == MODEST_TNY_SEND_QUEUE_FAILED) { + open_in_editor = TRUE; + } + g_free(msg_id); } - g_free(msg_id); g_object_unref(traccount); } else { g_warning("Cannot get transport account for message in outbox!!"); @@ -910,43 +937,28 @@ open_msg_cb (ModestMailOperation *mail_op, if (open_in_editor) { ModestAccountMgr *mgr = modest_runtime_get_account_mgr (); - gchar *from_header = NULL; + gchar *from_header = NULL, *acc_name; from_header = tny_header_dup_from (header); /* we cannot edit without a valid account... */ if (!modest_account_mgr_has_accounts(mgr, TRUE)) { if (!modest_ui_actions_run_account_setup_wizard(parent_win)) { - modest_window_mgr_unregister_header (modest_runtime_get_window_mgr (), + modest_window_mgr_unregister_header (modest_runtime_get_window_mgr (), header); g_free (from_header); goto cleanup; } } - - if (from_header) { - GSList *accounts = modest_account_mgr_account_names (mgr, TRUE); - GSList *node = NULL; - for (node = accounts; node != NULL; node = g_slist_next (node)) { - gchar *from = modest_account_mgr_get_from_string (mgr, node->data); - - if (from && (strcmp (from_header, from) == 0)) { - g_free (account); - account = g_strdup (node->data); - g_free (from); - break; - } - g_free (from); - } - g_free (from_header); - g_slist_foreach (accounts, (GFunc) g_free, NULL); - g_slist_free (accounts); + + acc_name = modest_utils_get_account_name_from_recipient (from_header); + g_free (from_header); + if (acc_name) { + g_free (account); + account = acc_name; } win = modest_msg_edit_window_new (msg, account, TRUE); - - - } else { gchar *uid = modest_tny_folder_get_header_unique_id (header); @@ -967,7 +979,6 @@ open_msg_cb (ModestMailOperation *mail_op, if (win != NULL) { mgr = modest_runtime_get_window_mgr (); modest_window_mgr_register_window (mgr, win); - g_object_unref (win); gtk_widget_show_all (GTK_WIDGET(win)); } @@ -986,15 +997,56 @@ cleanup: static gboolean is_memory_full_error (GError *error) { - if (error->code == TNY_SYSTEM_ERROR_MEMORY || - error->code == TNY_IO_ERROR_WRITE || - error->code == TNY_IO_ERROR_READ) { + gboolean enough_free_space = TRUE; + GnomeVFSURI *cache_dir_uri; + const gchar *cache_dir; + GnomeVFSFileSize free_space; + + cache_dir = tny_account_store_get_cache_dir (TNY_ACCOUNT_STORE (modest_runtime_get_account_store ())); + cache_dir_uri = gnome_vfs_uri_new (cache_dir); + if (gnome_vfs_get_volume_free_space (cache_dir_uri, &free_space) == GNOME_VFS_OK) { + if (free_space < MIN_FREE_SPACE) + enough_free_space = FALSE; + } + gnome_vfs_uri_unref (cache_dir_uri); + + if ((error->code == TNY_SYSTEM_ERROR_MEMORY || + /* When asking for a mail and no space left on device + tinymail returns this error */ + error->code == TNY_SERVICE_ERROR_MESSAGE_NOT_AVAILABLE || + /* When the folder summary could not be read or + written */ + error->code == TNY_IO_ERROR_WRITE || + error->code == TNY_IO_ERROR_READ) && + !enough_free_space) { return TRUE; } else { return FALSE; } } +static gboolean +check_memory_full_error (GtkWidget *parent_window, GError *err) +{ + if (err == NULL) + return FALSE; + + if (is_memory_full_error (err)) + modest_platform_information_banner (parent_window, + NULL, dgettext("ke-recv", + "cerm_device_memory_full")); + else if (err->code == TNY_SYSTEM_ERROR_MEMORY) + /* If the account was created in memory full + conditions then tinymail won't be able to + connect so it'll return this error code */ + modest_platform_information_banner (parent_window, + NULL, _("emev_ui_imap_inbox_select_error")); + else + return FALSE; + + return TRUE; +} + void modest_ui_actions_disk_operations_error_handler (ModestMailOperation *mail_op, gpointer user_data) @@ -1014,6 +1066,13 @@ modest_ui_actions_disk_operations_error_handler (ModestMailOperation *mail_op, modest_platform_information_banner ((GtkWidget *) win, NULL, dgettext("ke-recv", "cerm_device_memory_full")); + } else if (error->code == TNY_SYSTEM_ERROR_MEMORY) { + modest_platform_information_banner ((GtkWidget *) win, + NULL, _("emev_ui_imap_inbox_select_error")); + } else if (error->domain == MODEST_MAIL_OPERATION_ERROR && + error->code == MODEST_MAIL_OPERATION_ERROR_FILE_IO) { + modest_platform_information_banner ((GtkWidget *) win, + NULL, dgettext ("hildon-common-strings", "sfil_ni_unable_to_open_file_not_found")); } else if (user_data) { modest_platform_information_banner ((GtkWidget *) win, NULL, user_data); @@ -1108,9 +1167,8 @@ open_msgs_performer(gboolean canceled, gpointer user_data) { ModestMailOperation *mail_op = NULL; - const gchar *proto_name; gchar *error_msg; - ModestTransportStoreProtocol proto; + ModestProtocolType proto; TnyList *not_opened_headers; TnyConnectionStatus status; gboolean show_open_draft = FALSE; @@ -1128,36 +1186,43 @@ open_msgs_performer(gboolean canceled, open_msgs_helper_destroyer (helper); /* In memory full conditions we could get this error here */ - if (err && is_memory_full_error (err)) { - modest_platform_information_banner ((GtkWidget *) parent_window, - NULL, dgettext("ke-recv", - "cerm_device_memory_full")); - } + check_memory_full_error ((GtkWidget *) parent_window, err); + goto clean; } /* Get the error message depending on the protocol */ - proto_name = tny_account_get_proto (account); - if (proto_name != NULL) { - proto = modest_protocol_info_get_transport_store_protocol (proto_name); - } else { - proto = MODEST_PROTOCOL_STORE_MAILDIR; + proto = modest_tny_account_get_protocol_type (account); + if (proto == MODEST_PROTOCOL_REGISTRY_TYPE_INVALID) { + proto = MODEST_PROTOCOLS_STORE_MAILDIR; } /* Create the error messages */ if (tny_list_get_length (not_opened_headers) == 1) { - if (proto == MODEST_PROTOCOL_STORE_POP) { - error_msg = g_strdup (_("emev_ni_ui_pop3_msg_recv_error")); - } else if (proto == MODEST_PROTOCOL_STORE_IMAP) { - TnyIterator *iter = tny_list_create_iterator (not_opened_headers); - TnyHeader *header = TNY_HEADER (tny_iterator_get_current (iter)); - gchar *subject = tny_header_dup_subject (header); - error_msg = g_strdup_printf (_("emev_ni_ui_imap_message_not_available_in_server"), - subject); - g_free (subject); - g_object_unref (header); - g_object_unref (iter); - } else { + ModestProtocol *protocol; + ModestProtocolRegistry *protocol_registry; + TnyIterator *iter; + TnyHeader *header; + gchar *subject; + + protocol_registry = modest_runtime_get_protocol_registry (); + iter = tny_list_create_iterator (not_opened_headers); + header = TNY_HEADER (tny_iterator_get_current (iter)); + subject = tny_header_dup_subject (header); + + protocol = modest_protocol_registry_get_protocol_by_type (protocol_registry, proto); + error_msg = modest_protocol_get_translation (protocol, MODEST_PROTOCOL_TRANSLATION_MSG_NOT_AVAILABLE, subject); + g_free (subject); + g_object_unref (header); + g_object_unref (iter); + + if (error_msg == NULL) { + error_msg = g_strdup (_("mail_ni_ui_folder_get_msg_folder_error")); + } + + if (modest_protocol_registry_protocol_type_has_tag (protocol_registry, + proto, + MODEST_PROTOCOL_REGISTRY_LOCAL_STORE_PROTOCOLS)) { TnyHeader *header; TnyFolder *folder; TnyIterator *iter; @@ -1171,7 +1236,6 @@ open_msgs_performer(gboolean canceled, g_object_unref (folder); g_object_unref (header); g_object_unref (iter); - error_msg = g_strdup (_("mail_ni_ui_folder_get_msg_folder_error")); } } else { error_msg = g_strdup (_("mail_ni_ui_folder_get_msg_folder_error")); @@ -1337,7 +1401,7 @@ open_msgs_from_headers (TnyList *headers, ModestWindow *win) } } } - + /* Register the headers before actually creating the windows: */ iter_not_opened = tny_list_create_iterator (not_opened_headers); while (!tny_iterator_is_done (iter_not_opened)) { @@ -1381,6 +1445,12 @@ void modest_ui_actions_on_open (GtkAction *action, ModestWindow *win) { TnyList *headers; + + /* we check for low-mem; in that case, show a warning, and don't allow + * opening + */ + if (modest_platform_check_memory_low (MODEST_WINDOW(win), TRUE)) + return; /* Get headers */ headers = get_selected_headers (win); @@ -1393,6 +1463,26 @@ modest_ui_actions_on_open (GtkAction *action, ModestWindow *win) g_object_unref(headers); } +static ReplyForwardHelper* +create_reply_forward_helper (ReplyForwardAction action, + ModestWindow *win, + guint reply_forward_type, + TnyHeader *header) +{ + ReplyForwardHelper *rf_helper = NULL; + const gchar *active_acc = modest_window_get_active_account (win); + + rf_helper = g_slice_new0 (ReplyForwardHelper); + rf_helper->reply_forward_type = reply_forward_type; + rf_helper->action = action; + rf_helper->parent_window = (MODEST_IS_WINDOW (win)) ? GTK_WIDGET (win) : NULL; + rf_helper->header = (header) ? g_object_ref (header) : NULL; + rf_helper->account_name = (active_acc) ? + g_strdup (active_acc) : + modest_account_mgr_get_default_account (modest_runtime_get_account_mgr()); + + return rf_helper; +} static void free_reply_forward_helper (gpointer data) @@ -1401,6 +1491,8 @@ free_reply_forward_helper (gpointer data) helper = (ReplyForwardHelper *) data; g_free (helper->account_name); + if (helper->header) + g_object_unref (helper->header); g_slice_free (ReplyForwardHelper, helper); } @@ -1412,7 +1504,7 @@ reply_forward_cb (ModestMailOperation *mail_op, GError *err, gpointer user_data) { - TnyMsg *new_msg; + TnyMsg *new_msg = NULL; ReplyForwardHelper *rf_helper; ModestWindow *msg_win = NULL; ModestEditType edit_type; @@ -1425,11 +1517,9 @@ reply_forward_cb (ModestMailOperation *mail_op, /* If there was any error. The mail operation could be NULL, this means that we already have the message downloaded and that we didn't do a mail operation to retrieve it */ - if (mail_op && !modest_ui_actions_msg_retrieval_check (mail_op, header, msg)) - return; - - g_return_if_fail (user_data != NULL); rf_helper = (ReplyForwardHelper *) user_data; + if (mail_op && !modest_ui_actions_msg_retrieval_check (mail_op, header, msg)) + goto cleanup; from = modest_account_mgr_get_from_string (modest_runtime_get_account_mgr(), rf_helper->account_name); @@ -1465,10 +1555,11 @@ reply_forward_cb (ModestMailOperation *mail_op, return; } + g_free (from); g_free (signature); if (!new_msg) { - g_printerr ("modest: failed to create message\n"); + g_warning ("%s: failed to create message\n", __FUNCTION__); goto cleanup; } @@ -1476,7 +1567,7 @@ reply_forward_cb (ModestMailOperation *mail_op, rf_helper->account_name, TNY_ACCOUNT_TYPE_STORE); if (!account) { - g_printerr ("modest: failed to get tnyaccount for '%s'\n", rf_helper->account_name); + g_warning ("%s: failed to get tnyaccount for '%s'\n", __FUNCTION__, rf_helper->account_name); goto cleanup; } @@ -1496,13 +1587,10 @@ reply_forward_cb (ModestMailOperation *mail_op, gtk_widget_show_all (GTK_WIDGET (msg_win)); cleanup: - if (msg_win) - g_object_unref (msg_win); if (new_msg) g_object_unref (G_OBJECT (new_msg)); if (account) g_object_unref (G_OBJECT (account)); -/* g_object_unref (msg); */ free_reply_forward_helper (rf_helper); } @@ -1559,20 +1647,50 @@ connect_to_get_msg (ModestWindow *win, return modest_platform_connect_and_wait((GtkWindow *) win, account); } +static void +reply_forward_performer (gboolean canceled, + GError *err, + GtkWindow *parent_window, + TnyAccount *account, + gpointer user_data) +{ + ReplyForwardHelper *rf_helper = NULL; + ModestMailOperation *mail_op; + + rf_helper = (ReplyForwardHelper *) user_data; + + if (canceled || err) { + free_reply_forward_helper (rf_helper); + return; + } + + /* Retrieve the message */ + mail_op = modest_mail_operation_new_with_error_handling (G_OBJECT (parent_window), + modest_ui_actions_disk_operations_error_handler, + NULL, NULL); + modest_mail_operation_queue_add (modest_runtime_get_mail_operation_queue (), mail_op); + modest_mail_operation_get_msg (mail_op, rf_helper->header, TRUE, reply_forward_cb, rf_helper); + + /* Frees */ + g_object_unref(mail_op); +} + /* * Common code for the reply and forward actions */ static void reply_forward (ReplyForwardAction action, ModestWindow *win) { - ModestMailOperation *mail_op = NULL; - TnyList *header_list = NULL; ReplyForwardHelper *rf_helper = NULL; guint reply_forward_type; - gboolean continue_download = TRUE; - gboolean do_retrieve = TRUE; g_return_if_fail (MODEST_IS_WINDOW(win)); + + /* we check for low-mem; in that case, show a warning, and don't allow + * reply/forward (because it could potentially require a lot of memory */ + if (modest_platform_check_memory_low (MODEST_WINDOW(win), TRUE)) + return; + /* we need an account when editing */ if (!modest_account_mgr_has_accounts(modest_runtime_get_account_mgr(), TRUE)) { @@ -1580,113 +1698,118 @@ reply_forward (ReplyForwardAction action, ModestWindow *win) return; } - header_list = get_selected_headers (win); - if (!header_list) - return; - - reply_forward_type = + reply_forward_type = modest_conf_get_int (modest_runtime_get_conf (), - (action == ACTION_FORWARD) ? MODEST_CONF_FORWARD_TYPE : MODEST_CONF_REPLY_TYPE, + (action == ACTION_FORWARD) ? + MODEST_CONF_FORWARD_TYPE : + MODEST_CONF_REPLY_TYPE, NULL); - /* check if we need to download msg before asking about it */ - do_retrieve = (action == ACTION_FORWARD) || - (reply_forward_type != MODEST_TNY_MSG_REPLY_TYPE_CITE); - - if (do_retrieve){ - gint num_of_unc_msgs; - - /* check that the messages have been previously downloaded */ - num_of_unc_msgs = header_list_count_uncached_msgs(header_list); - /* If there are any uncached message ask the user - * whether he/she wants to download them. */ - if (num_of_unc_msgs) { - TnyAccount *account = get_account_from_header_list (header_list); - if (account) { - continue_download = connect_to_get_msg (win, num_of_unc_msgs, account); - g_object_unref (account); - } - } - } - - if (!continue_download) { - g_object_unref (header_list); - return; - } - - /* We assume that we can only select messages of the - same folder and that we reply all of them from the - same account. In fact the interface currently only - allows single selection */ - - /* Fill helpers */ - rf_helper = g_slice_new0 (ReplyForwardHelper); - rf_helper->reply_forward_type = reply_forward_type; - rf_helper->action = action; - rf_helper->account_name = g_strdup (modest_window_get_active_account (win)); - - if ((win != NULL) && (MODEST_IS_WINDOW (win))) - rf_helper->parent_window = GTK_WIDGET (win); - if (!rf_helper->account_name) - rf_helper->account_name = - modest_account_mgr_get_default_account (modest_runtime_get_account_mgr()); - - if (MODEST_IS_MSG_VIEW_WINDOW(win)) { - TnyMsg *msg; - TnyHeader *header; + if (MODEST_IS_MSG_VIEW_WINDOW (win)) { + TnyMsg *msg = NULL; + TnyHeader *header = NULL; /* Get header and message. Do not free them here, the reply_forward_cb must do it */ msg = modest_msg_view_window_get_message (MODEST_MSG_VIEW_WINDOW(win)); - header = modest_msg_view_window_get_header (MODEST_MSG_VIEW_WINDOW(win)); - if (!msg || !header) { - if (msg) - g_object_unref (msg); - g_printerr ("modest: no message found\n"); - return; - } else { + header = modest_msg_view_window_get_header (MODEST_MSG_VIEW_WINDOW (win)); + + if (msg && header) { + /* Create helper */ + rf_helper = create_reply_forward_helper (action, win, + reply_forward_type, header); reply_forward_cb (NULL, header, FALSE, msg, NULL, rf_helper); + } else { + g_warning("%s: no message or header found in viewer\n", __FUNCTION__); } - if (header) + + if (msg) + g_object_unref (msg); + if (header) g_object_unref (header); } else { - TnyHeader *header; + TnyHeader *header = NULL; TnyIterator *iter; + gboolean do_retrieve = TRUE; + TnyList *header_list = NULL; + + header_list = get_selected_headers (win); + if (!header_list) + return; + /* Check that only one message is selected for replying */ + if (tny_list_get_length (header_list) != 1) { + modest_platform_information_banner ((win) ? GTK_WIDGET (win) : NULL, + NULL, _("mcen_ib_select_one_message")); + g_object_unref (header_list); + return; + } /* Only reply/forward to one message */ iter = tny_list_create_iterator (header_list); header = TNY_HEADER (tny_iterator_get_current (iter)); g_object_unref (iter); - if (header) { - /* Retrieve messages */ - if (do_retrieve) { - mail_op = - modest_mail_operation_new_with_error_handling (G_OBJECT(win), - modest_ui_actions_disk_operations_error_handler, - NULL, NULL); - modest_mail_operation_queue_add ( - modest_runtime_get_mail_operation_queue (), mail_op); - - modest_mail_operation_get_msg (mail_op, - header, - reply_forward_cb, - rf_helper); - /* Clean */ - g_object_unref(mail_op); - } else { - /* we put a ref here to prevent double unref as the reply - * forward callback unrefs the header at its end */ - reply_forward_cb (NULL, header, FALSE, NULL, NULL, rf_helper); - } + /* Retrieve messages */ + do_retrieve = (action == ACTION_FORWARD) || + (reply_forward_type != MODEST_TNY_MSG_REPLY_TYPE_CITE); + if (do_retrieve) { + TnyAccount *account = NULL; + TnyFolder *folder = NULL; + gdouble download = TRUE; + guint uncached_msgs = 0; - g_object_unref (header); + folder = tny_header_get_folder (header); + if (!folder) + goto do_retrieve_frees; + account = tny_folder_get_account (folder); + if (!account) + goto do_retrieve_frees; + + uncached_msgs = header_list_count_uncached_msgs (header_list); + + if (uncached_msgs > 0) { + /* Allways download if we are online. */ + if (!tny_device_is_online (modest_runtime_get_device ())) { + gint response; + + /* If ask for user permission to download the messages */ + response = modest_platform_run_confirmation_dialog (GTK_WINDOW (win), + ngettext("mcen_nc_get_msg", + "mcen_nc_get_msgs", + uncached_msgs)); + + /* End if the user does not want to continue */ + if (response == GTK_RESPONSE_CANCEL) + download = FALSE; + } + } + + if (download) { + /* Create helper */ + rf_helper = create_reply_forward_helper (action, win, + reply_forward_type, header); + if (uncached_msgs > 0) { + modest_platform_connect_and_perform (GTK_WINDOW (win), + TRUE, account, + reply_forward_performer, + rf_helper); + } else { + reply_forward_performer (FALSE, NULL, GTK_WINDOW (win), + account, rf_helper); + } + } + do_retrieve_frees: + if (account) + g_object_unref (account); + if (folder) + g_object_unref (folder); + } else { + reply_forward_cb (NULL, header, FALSE, NULL, NULL, rf_helper); } - + /* Frees */ + g_object_unref (header_list); + g_object_unref (header); } - - /* Free */ - g_object_unref (header_list); } void @@ -1774,7 +1897,7 @@ modest_ui_actions_on_sort (GtkAction *action, } /* Show sorting dialog */ - modest_platform_run_sort_dialog (GTK_WINDOW (window), MODEST_SORT_HEADERS); + modest_utils_run_sort_dialog (GTK_WINDOW (window), MODEST_SORT_HEADERS); } } @@ -1846,11 +1969,8 @@ do_send_receive_performer (gboolean canceled, if (err || canceled) { /* In memory full conditions we could get this error here */ - if (err && is_memory_full_error (err)) { - modest_platform_information_banner ((GtkWidget *) parent_window, - NULL, dgettext("ke-recv", - "cerm_device_memory_full")); - } + check_memory_full_error ((GtkWidget *) parent_window, err); + if (info->mail_op) { modest_mail_operation_queue_remove (modest_runtime_get_mail_operation_queue (), info->mail_op); @@ -1963,7 +2083,7 @@ modest_ui_actions_do_cancel_send (const gchar *account_name, } /* Get send queue*/ - send_queue = TNY_SEND_QUEUE (modest_runtime_get_send_queue (transport_account)); + send_queue = TNY_SEND_QUEUE (modest_runtime_get_send_queue (transport_account, TRUE)); if (!TNY_IS_SEND_QUEUE(send_queue)) { g_set_error (&error, MODEST_MAIL_OPERATION_ERROR, MODEST_MAIL_OPERATION_ERROR_ITEM_NOT_FOUND, @@ -2130,8 +2250,10 @@ modest_ui_actions_on_header_selected (ModestHeaderView *header_view, GtkWidget *folder_view = modest_main_window_get_child_widget (main_window, MODEST_MAIN_WINDOW_WIDGET_TYPE_FOLDER_VIEW); - if (folder != NULL) + if (folder != NULL) { modest_folder_view_select_folder (MODEST_FOLDER_VIEW (folder_view), folder, FALSE); + g_object_unref (folder); + } gtk_widget_grab_focus (GTK_WIDGET (folder_view)); return; } @@ -2155,6 +2277,7 @@ modest_ui_actions_on_header_activated (ModestHeaderView *header_view, ModestMainWindow *main_window) { TnyList *headers; + GtkWidget *open_widget; g_return_if_fail (MODEST_IS_MAIN_WINDOW(main_window)); @@ -2166,9 +2289,17 @@ modest_ui_actions_on_header_activated (ModestHeaderView *header_view, return; } + /* we check for low-mem; in that case, show a warning, and don't allow + * activating headers + */ + if (modest_platform_check_memory_low (MODEST_WINDOW(main_window), TRUE)) + return; + + modest_ui_actions_check_menu_dimming_rules (MODEST_WINDOW (main_window)); + open_widget = modest_window_get_action_widget (MODEST_WINDOW (main_window), "/MenuBar/EmailMenu/EmailOpenMenu"); + if (!GTK_WIDGET_IS_SENSITIVE (open_widget)) + return; -/* headers = tny_simple_list_new (); */ -/* tny_list_prepend (headers, G_OBJECT (header)); */ headers = modest_header_view_get_selected_headers (header_view); open_msgs_from_headers (headers, MODEST_WINDOW (main_window)); @@ -2213,23 +2344,36 @@ folder_refreshed_cb (ModestMailOperation *mail_op, gpointer user_data) { ModestMainWindow *win = NULL; - GtkWidget *header_view; + GtkWidget *folder_view; + const GError *error; g_return_if_fail (TNY_IS_FOLDER (folder)); win = MODEST_MAIN_WINDOW (user_data); - header_view = - modest_main_window_get_child_widget(win, MODEST_MAIN_WINDOW_WIDGET_TYPE_HEADER_VIEW); - if (header_view) { - TnyFolder *current_folder; + /* Check if the operation failed due to memory low conditions */ + error = modest_mail_operation_get_error (mail_op); + if (error && error->domain == MODEST_MAIL_OPERATION_ERROR && + error->code == MODEST_MAIL_OPERATION_ERROR_LOW_MEMORY) { + modest_platform_run_information_dialog (GTK_WINDOW (win), + dgettext("ke-recv","memr_ib_operation_disabled"), + TRUE); + return; + } - current_folder = modest_header_view_get_folder (MODEST_HEADER_VIEW (header_view)); - if (current_folder != NULL && folder != current_folder) { - g_object_unref (current_folder); - return; - } else if (current_folder) + folder_view = + modest_main_window_get_child_widget(win, MODEST_MAIN_WINDOW_WIDGET_TYPE_FOLDER_VIEW); + + if (folder_view) { + TnyFolderStore *current_folder; + + current_folder = modest_folder_view_get_selected (MODEST_FOLDER_VIEW (folder_view)); + if (current_folder) { + gboolean different = ((TnyFolderStore *) folder != current_folder); g_object_unref (current_folder); + if (different) + return; + } } /* Check if folder is empty and set headers view contents style */ @@ -2266,11 +2410,15 @@ modest_ui_actions_on_folder_selection_changed (ModestFolderView *folder_view, } } else { if (TNY_IS_FOLDER (folder_store) && selected) { - + TnyAccount *account; + const gchar *account_name = NULL; + /* Update the active account */ - TnyAccount *account = modest_tny_folder_get_account (TNY_FOLDER (folder_store)); + account = modest_tny_folder_get_account (TNY_FOLDER (folder_store)); if (account) { set_active_account_from_tny_account (account, MODEST_WINDOW (main_window)); + account_name = + modest_tny_account_get_parent_modest_account_name_for_server_account (account); g_object_unref (account); account = NULL; } @@ -2288,6 +2436,7 @@ modest_ui_actions_on_folder_selection_changed (ModestFolderView *folder_view, empty view if there are no messages */ modest_header_view_set_folder (MODEST_HEADER_VIEW(header_view), TNY_FOLDER (folder_store), + TRUE, folder_refreshed_cb, main_window); @@ -2305,7 +2454,7 @@ modest_ui_actions_on_folder_selection_changed (ModestFolderView *folder_view, already being done by the sort dialog. Remove it when the GNOME version has the same behaviour */ -#ifdef MODEST_PLATFORM_GNOME +#ifdef MODEST_TOOLKIT_GTK if (modest_main_window_get_contents_style (main_window) == MODEST_MAIN_WINDOW_CONTENTS_STYLE_HEADERS) modest_widget_memory_save (conf, G_OBJECT (header_view), @@ -2392,7 +2541,13 @@ modest_ui_actions_on_msg_link_contextual (ModestMsgView *msgview, const gchar* l void modest_ui_actions_on_msg_attachment_clicked (ModestMsgView *msgview, TnyMimePart *mime_part, ModestWindow *win) -{ +{ + /* we check for low-mem; in that case, show a warning, and don't allow + * viewing attachments + */ + if (modest_platform_check_memory_low (MODEST_WINDOW(win), TRUE)) + return; + modest_msg_view_window_view_attachment (MODEST_MSG_VIEW_WINDOW (win), mime_part); } @@ -2432,6 +2587,61 @@ on_save_to_drafts_cb (ModestMailOperation *mail_op, g_object_unref(edit_window); } +static gboolean +enough_space_for_message (ModestMsgEditWindow *edit_window, + MsgData *data) +{ + TnyAccountStore *acc_store; + guint64 available_disk, expected_size; + gint parts_count; + guint64 parts_size; + + /* Check size */ + acc_store = TNY_ACCOUNT_STORE (modest_runtime_get_account_store()); + available_disk = modest_utils_get_available_space (NULL); + modest_msg_edit_window_get_parts_size (edit_window, &parts_count, &parts_size); + expected_size = modest_tny_msg_estimate_size (data->plain_body, + data->html_body, + parts_count, + parts_size); + + /* Double check: memory full condition or message too big */ + if (available_disk < MIN_FREE_SPACE || + expected_size > available_disk) { + + modest_platform_information_banner (NULL, NULL, + dgettext("ke-recv", + "cerm_device_memory_full")); + return FALSE; + } + + /* + * djcb: if we're in low-memory state, we only allow for + * saving messages smaller than + * MODEST_MAX_LOW_MEMORY_MESSAGE_SIZE (see modest-defs.h) this + * should still allow for sending anything critical... + */ + if ((expected_size > MODEST_MAX_LOW_MEMORY_MESSAGE_SIZE) && + modest_platform_check_memory_low (MODEST_WINDOW(edit_window), TRUE)) + return FALSE; + + /* + * djcb: we also make sure that the attachments are smaller than the max size + * this is for the case where we'd try to forward a message with attachments + * bigger than our max allowed size, or sending an message from drafts which + * somehow got past our checks when attaching. + */ + if (expected_size > MODEST_MAX_ATTACHMENT_SIZE) { + modest_platform_run_information_dialog ( + GTK_WINDOW(edit_window), + dgettext("ke-recv","memr_ib_operation_disabled"), + TRUE); + return FALSE; + } + + return TRUE; +} + gboolean modest_ui_actions_on_save_to_drafts (GtkWidget *widget, ModestMsgEditWindow *edit_window) { @@ -2440,11 +2650,7 @@ modest_ui_actions_on_save_to_drafts (GtkWidget *widget, ModestMsgEditWindow *edi MsgData *data; gchar *account_name, *from; ModestAccountMgr *account_mgr; -/* char *info_text; */ gboolean had_error = FALSE; - guint64 available_disk, expected_size; - gint parts_count; - guint64 parts_size; ModestMainWindow *win; g_return_val_if_fail (MODEST_IS_MSG_EDIT_WINDOW(edit_window), FALSE); @@ -2452,17 +2658,8 @@ modest_ui_actions_on_save_to_drafts (GtkWidget *widget, ModestMsgEditWindow *edi data = modest_msg_edit_window_get_msg_data (edit_window); /* Check size */ - available_disk = modest_folder_available_space (NULL); - modest_msg_edit_window_get_parts_size (edit_window, &parts_count, &parts_size); - expected_size = modest_tny_msg_estimate_size (data->plain_body, - data->html_body, - parts_count, - parts_size); - - if ((available_disk != -1) && expected_size > available_disk) { + if (!enough_space_for_message (edit_window, data)) { modest_msg_edit_window_free_msg_data (edit_window, data); - - modest_platform_information_banner (NULL, NULL, dgettext("ke-recv", "cerm_device_memory_full")); return FALSE; } @@ -2484,7 +2681,7 @@ modest_ui_actions_on_save_to_drafts (GtkWidget *widget, ModestMsgEditWindow *edi transport_account = TNY_TRANSPORT_ACCOUNT(modest_tny_account_store_get_server_account - (modest_runtime_get_account_store(), + (modest_runtime_get_account_store (), account_name, TNY_ACCOUNT_TYPE_TRANSPORT)); if (!transport_account) { @@ -2582,34 +2779,27 @@ modest_ui_actions_on_send (GtkWidget *widget, ModestMsgEditWindow *edit_window) { TnyTransportAccount *transport_account = NULL; gboolean had_error = FALSE; - guint64 available_disk, expected_size; - gint parts_count; - guint64 parts_size; + MsgData *data; + ModestAccountMgr *account_mgr; + gchar *account_name; + gchar *from; + ModestMailOperation *mail_operation; g_return_val_if_fail (MODEST_IS_MSG_EDIT_WINDOW(edit_window), TRUE); if (!modest_msg_edit_window_check_names (edit_window, TRUE)) return TRUE; - MsgData *data = modest_msg_edit_window_get_msg_data (edit_window); + data = modest_msg_edit_window_get_msg_data (edit_window); /* Check size */ - available_disk = modest_folder_available_space (NULL); - modest_msg_edit_window_get_parts_size (edit_window, &parts_count, &parts_size); - expected_size = modest_tny_msg_estimate_size (data->plain_body, - data->html_body, - parts_count, - parts_size); - - if ((available_disk != -1) && expected_size > available_disk) { + if (!enough_space_for_message (edit_window, data)) { modest_msg_edit_window_free_msg_data (edit_window, data); - - modest_platform_information_banner (NULL, NULL, dgettext("ke-recv", "cerm_device_memory_full")); return FALSE; } - ModestAccountMgr *account_mgr = modest_runtime_get_account_mgr(); - gchar *account_name = g_strdup (data->account_name); + account_mgr = modest_runtime_get_account_mgr(); + account_name = g_strdup (data->account_name); if (!account_name) account_name = g_strdup(modest_window_get_active_account (MODEST_WINDOW(edit_window))); @@ -2626,9 +2816,10 @@ modest_ui_actions_on_send (GtkWidget *widget, ModestMsgEditWindow *edit_window) /* Get the currently-active transport account for this modest account: */ if (strcmp (account_name, MODEST_LOCAL_FOLDERS_ACCOUNT_ID) != 0) { - transport_account = TNY_TRANSPORT_ACCOUNT(modest_tny_account_store_get_server_account - (modest_runtime_get_account_store(), - account_name, TNY_ACCOUNT_TYPE_TRANSPORT)); + transport_account = + TNY_TRANSPORT_ACCOUNT(modest_tny_account_store_get_server_account + (modest_runtime_get_account_store (), + account_name, TNY_ACCOUNT_TYPE_TRANSPORT)); } if (!transport_account) { @@ -2638,17 +2829,17 @@ modest_ui_actions_on_send (GtkWidget *widget, ModestMsgEditWindow *edit_window) return TRUE; } - gchar *from = modest_account_mgr_get_from_string (account_mgr, account_name); /* Create the mail operation */ - ModestMailOperation *mail_operation = modest_mail_operation_new (NULL); + from = modest_account_mgr_get_from_string (account_mgr, account_name); + mail_operation = modest_mail_operation_new_with_error_handling (NULL, modest_ui_actions_disk_operations_error_handler, NULL, NULL); modest_mail_operation_queue_add (modest_runtime_get_mail_operation_queue (), mail_operation); modest_mail_operation_send_new_mail (mail_operation, transport_account, data->draft_msg, from, - data->to, + data->to, data->cc, data->bcc, data->subject, @@ -2664,7 +2855,8 @@ modest_ui_actions_on_send (GtkWidget *widget, ModestMsgEditWindow *edit_window) if (modest_mail_operation_get_error (mail_operation) != NULL) { const GError *error = modest_mail_operation_get_error (mail_operation); - if (error->code == MODEST_MAIL_OPERATION_ERROR_INSTANCE_CREATION_FAILED) { + if (error->domain == MODEST_MAIL_OPERATION_ERROR && + error->code == MODEST_MAIL_OPERATION_ERROR_INSTANCE_CREATION_FAILED) { g_warning ("%s failed: %s\n", __FUNCTION__, (modest_mail_operation_get_error (mail_operation))->message); modest_platform_information_banner (NULL, NULL, _CS("sfil_ni_not_enough_memory")); had_error = TRUE; @@ -2808,6 +3000,10 @@ modest_ui_actions_on_insert_image (GtkAction *action, g_return_if_fail (MODEST_IS_MSG_EDIT_WINDOW (window)); g_return_if_fail (GTK_IS_ACTION (action)); + + if (modest_platform_check_memory_low (MODEST_WINDOW(window), TRUE)) + return; + if (modest_msg_edit_window_get_format (MODEST_MSG_EDIT_WINDOW(window)) == MODEST_MSG_EDIT_FORMAT_TEXT) return; @@ -2821,6 +3017,9 @@ modest_ui_actions_on_attach_file (GtkAction *action, g_return_if_fail (MODEST_IS_MSG_EDIT_WINDOW (window)); g_return_if_fail (GTK_IS_ACTION (action)); + if (modest_platform_check_memory_low (MODEST_WINDOW(window), TRUE)) + return; + modest_msg_edit_window_offer_attach_file (window); } @@ -2834,6 +3033,38 @@ modest_ui_actions_on_remove_attachments (GtkAction *action, modest_msg_edit_window_remove_attachments (window, NULL); } + +#ifndef MODEST_TOOLKIT_GTK +typedef struct { + guint handler; + gchar *name; + GtkWindow *win; + TnyFolderStore *folder; +} CreateFolderHelper; + +static gboolean +show_create_folder_in_timeout (gpointer data) +{ + CreateFolderHelper *helper = (CreateFolderHelper *) data; + + /* Remove the timeout ASAP, we can not wait until the dialog + is shown because it could take a lot of time and so the + timeout could be called twice or more times */ + g_source_remove (helper->handler); + + gdk_threads_enter (); + do_create_folder (helper->win, helper->folder, helper->name); + gdk_threads_leave (); + + g_object_unref (helper->win); + g_object_unref (helper->folder); + g_free (helper->name); + g_slice_free (CreateFolderHelper, helper); + + return FALSE; +} +#endif + static void do_create_folder_cb (ModestMailOperation *mail_op, TnyFolderStore *parent_folder, @@ -2858,7 +3089,21 @@ do_create_folder_cb (ModestMailOperation *mail_op, /* Try again. Do *NOT* show any error because the mail operations system will do it for us because we created the mail_op with new_with_error_handler */ +#ifndef MODEST_TOOLKIT_GTK + CreateFolderHelper *helper; + helper = g_slice_new0 (CreateFolderHelper); + helper->name = g_strdup (suggested_name); + helper->folder = g_object_ref (parent_folder); + helper->win = g_object_ref (source_win); + + /* Ugly but neccesary stuff. The problem is that the + dialog when is shown calls a function that destroys + all the temporary windows, so the banner is + destroyed */ + helper->handler = g_timeout_add (2000, show_create_folder_in_timeout, helper); +#else do_create_folder (source_win, parent_folder, (const gchar *) suggested_name); +#endif } else { /* the 'source_win' is either the ModestMainWindow, or the 'Move to folder'-dialog * FIXME: any other? */ @@ -2872,9 +3117,12 @@ do_create_folder_cb (ModestMailOperation *mail_op, folder_view = get_folder_view_from_move_to_dialog (GTK_WIDGET(source_win)); - /* Select the newly created folder */ - modest_folder_view_select_folder (MODEST_FOLDER_VIEW (folder_view), - new_folder, FALSE); + /* Select the newly created folder. It could happen + that the widget is no longer there (i.e. the window + has been destroyed, so we need to check this */ + if (folder_view) + modest_folder_view_select_folder (MODEST_FOLDER_VIEW (folder_view), + new_folder, FALSE); g_object_unref (new_folder); } /* Free. Note that the first time it'll be NULL so noop */ @@ -2921,11 +3169,7 @@ create_folder_performer (gboolean canceled, if (canceled || err) { /* In memory full conditions we could get this error here */ - if (err && is_memory_full_error (err)) { - modest_platform_information_banner ((GtkWidget *) parent_window, - NULL, dgettext("ke-recv", - "cerm_device_memory_full")); - } + check_memory_full_error ((GtkWidget *) parent_window, err); goto frees; } @@ -2981,11 +3225,15 @@ modest_ui_actions_rename_folder_error_handler (ModestMailOperation *mail_op, if (!error) g_return_if_reached (); - switch (error->code) { - case MODEST_MAIL_OPERATION_ERROR_FOLDER_EXISTS: + if (error->domain == MODEST_MAIL_OPERATION_ERROR && + error->code == MODEST_MAIL_OPERATION_ERROR_FOLDER_EXISTS) { message = _CS("ckdg_ib_folder_already_exists"); - break; - default: + } else if (error->domain == TNY_ERROR_DOMAIN && + error->code == TNY_SERVICE_ERROR_STATE) { + /* This means that the folder is already in use (a + message is opened for example */ + message = _("emev_ni_internal_error"); + } else { message = _("emev_ib_ui_imap_unable_to_rename"); } @@ -3006,6 +3254,11 @@ on_rename_folder_cb (ModestMailOperation *mail_op, { ModestFolderView *folder_view; + /* If the window was closed when renaming a folder this could + happen */ + if (!MODEST_IS_FOLDER_VIEW (user_data)) + return; + folder_view = MODEST_FOLDER_VIEW (user_data); /* Note that if the rename fails new_folder will be NULL */ if (new_folder) { @@ -3013,6 +3266,7 @@ on_rename_folder_cb (ModestMailOperation *mail_op, } else { modest_folder_view_select_first_inbox_or_local (folder_view); } + gtk_widget_grab_focus (GTK_WIDGET (folder_view)); } static void @@ -3029,11 +3283,7 @@ on_rename_folder_performer (gboolean canceled, if (canceled || err) { /* In memory full conditions we could get this error here */ - if (err && is_memory_full_error (err)) { - modest_platform_information_banner ((GtkWidget *) parent_window, - NULL, dgettext("ke-recv", - "cerm_device_memory_full")); - } + check_memory_full_error ((GtkWidget *) parent_window, err); } else if (MODEST_IS_MAIN_WINDOW(parent_window)) { folder_view = modest_main_window_get_child_widget ( @@ -3050,7 +3300,7 @@ on_rename_folder_performer (gboolean canceled, /* Clear the headers view */ sel = gtk_tree_view_get_selection (GTK_TREE_VIEW (folder_view)); - gtk_tree_selection_unselect_all (sel); + gtk_tree_selection_unselect_all (sel); /* Actually rename the folder */ modest_mail_operation_rename_folder (mail_op, @@ -3058,6 +3308,7 @@ on_rename_folder_performer (gboolean canceled, (const gchar *) (data->new_name), on_rename_folder_cb, folder_view); + g_object_unref (data->folder); g_object_unref (mail_op); } @@ -3109,7 +3360,7 @@ modest_ui_actions_on_rename_folder (GtkAction *action, do_rename = FALSE; } else { RenameFolderInfo *rename_folder_data = g_new0 (RenameFolderInfo, 1); - rename_folder_data->folder = folder; + rename_folder_data->folder = g_object_ref (folder); rename_folder_data->new_name = folder_name; modest_platform_connect_if_remote_and_perform (GTK_WINDOW(main_window), TRUE, folder, on_rename_folder_performer, rename_folder_data); @@ -3245,6 +3496,30 @@ modest_ui_actions_on_move_folder_to_trash_folder (GtkAction *action, ModestMainW } +typedef struct _PasswordDialogFields { + GtkWidget *username; + GtkWidget *password; + GtkWidget *dialog; +} PasswordDialogFields; + +static void +password_dialog_check_field (GtkEditable *editable, + PasswordDialogFields *fields) +{ + const gchar *value; + gboolean any_value_empty = FALSE; + + value = gtk_entry_get_text (GTK_ENTRY (fields->username)); + if ((value == NULL) || value[0] == '\0') { + any_value_empty = TRUE; + } + value = gtk_entry_get_text (GTK_ENTRY (fields->password)); + if ((value == NULL) || value[0] == '\0') { + any_value_empty = TRUE; + } + gtk_dialog_set_response_sensitive (GTK_DIALOG (fields->dialog), GTK_RESPONSE_ACCEPT, !any_value_empty); +} + void modest_ui_actions_on_password_requested (TnyAccountStore *account_store, const gchar* server_account_name, @@ -3256,6 +3531,7 @@ modest_ui_actions_on_password_requested (TnyAccountStore *account_store, { g_return_if_fail(server_account_name); gboolean completed = FALSE; + PasswordDialogFields *fields = NULL; /* Initalize output parameters: */ if (cancel) @@ -3264,7 +3540,7 @@ modest_ui_actions_on_password_requested (TnyAccountStore *account_store, if (remember) *remember = TRUE; -#ifdef MODEST_PLATFORM_MAEMO +#ifndef MODEST_TOOLKIT_GTK /* Maemo uses a different (awkward) button order, * It should probably just use gtk_alternative_dialog_button_order (). */ @@ -3285,7 +3561,7 @@ modest_ui_actions_on_password_requested (TnyAccountStore *account_store, GTK_STOCK_OK, GTK_RESPONSE_ACCEPT, NULL); -#endif /* MODEST_PLATFORM_MAEMO */ +#endif /* !MODEST_TOOLKIT_GTK */ modest_window_mgr_set_modal (modest_runtime_get_window_mgr(), GTK_WINDOW (dialog)); @@ -3316,12 +3592,17 @@ modest_ui_actions_on_password_requested (TnyAccountStore *account_store, gtk_entry_set_text (GTK_ENTRY (entry_username), initial_username); /* Dim this if a connection has ever succeeded with this username, * as per the UI spec: */ - const gboolean username_known = - modest_account_mgr_get_server_account_username_has_succeeded( - modest_runtime_get_account_mgr(), server_account_name); - gtk_widget_set_sensitive (entry_username, !username_known); - -#ifdef MODEST_PLATFORM_MAEMO + /* const gboolean username_known = */ + /* modest_account_mgr_get_server_account_username_has_succeeded( */ + /* modest_runtime_get_account_mgr(), server_account_name); */ + /* gtk_widget_set_sensitive (entry_username, !username_known); */ + + /* We drop the username sensitive code and disallow changing it here + * as tinymail does not support really changing the username in the callback + */ + gtk_widget_set_sensitive (entry_username, FALSE); + +#ifndef MODEST_TOOLKIT_GTK /* Auto-capitalization is the default, so let's turn it off: */ hildon_gtk_entry_set_input_mode (GTK_ENTRY (entry_username), HILDON_GTK_INPUT_MODE_FULL); @@ -3339,14 +3620,14 @@ modest_ui_actions_on_password_requested (TnyAccountStore *account_store, #else gtk_box_pack_start (GTK_BOX(GTK_DIALOG(dialog)->vbox), entry_username, TRUE, FALSE, 0); -#endif /* MODEST_PLATFORM_MAEMO */ +#endif /* !MODEST_TOOLKIT_GTK */ /* password: */ GtkWidget *entry_password = gtk_entry_new (); gtk_entry_set_visibility (GTK_ENTRY(entry_password), FALSE); /* gtk_entry_set_invisible_char (GTK_ENTRY(entry_password), "*"); */ -#ifdef MODEST_PLATFORM_MAEMO +#ifndef MODEST_TOOLKIT_GTK /* Auto-capitalization is the default, so let's turn it off: */ hildon_gtk_entry_set_input_mode (GTK_ENTRY (entry_password), HILDON_GTK_INPUT_MODE_FULL | HILDON_GTK_INPUT_MODE_INVISIBLE); @@ -3361,7 +3642,7 @@ modest_ui_actions_on_password_requested (TnyAccountStore *account_store, #else gtk_box_pack_start (GTK_BOX(GTK_DIALOG(dialog)->vbox), entry_password, TRUE, FALSE, 0); -#endif /* MODEST_PLATFORM_MAEMO */ +#endif /* !MODEST_TOOLKIT_GTK */ if (initial_username != NULL) gtk_widget_grab_focus (GTK_WIDGET (entry_password)); @@ -3372,6 +3653,15 @@ modest_ui_actions_on_password_requested (TnyAccountStore *account_store, TRUE, FALSE, 0); */ + fields = g_slice_new0 (PasswordDialogFields); + fields->username = entry_username; + fields->password = entry_password; + fields->dialog = dialog; + + g_signal_connect (entry_username, "changed", G_CALLBACK (password_dialog_check_field), fields); + g_signal_connect (entry_password, "changed", G_CALLBACK (password_dialog_check_field), fields); + password_dialog_check_field (NULL, fields); + gtk_widget_show_all (GTK_WIDGET(GTK_DIALOG(dialog)->vbox)); while (!completed) { @@ -3435,6 +3725,7 @@ modest_ui_actions_on_password_requested (TnyAccountStore *account_store, */ gtk_widget_destroy (dialog); + g_slice_free (PasswordDialogFields, fields); /* printf ("DEBUG: %s: cancel=%d\n", __FUNCTION__, *cancel); */ } @@ -3513,9 +3804,16 @@ modest_ui_actions_on_copy (GtkAction *action, gtk_clipboard_set_can_store (clipboard, NULL, 0); gtk_clipboard_store (clipboard); } else if (GTK_IS_HTML (focused_widget)) { - gtk_html_copy (GTK_HTML (focused_widget)); - gtk_clipboard_set_can_store (clipboard, NULL, 0); - gtk_clipboard_store (clipboard); + const gchar *sel; + int len = -1; + sel = gtk_html_get_selection_html (GTK_HTML (focused_widget), &len); + if ((sel == NULL) || (sel[0] == '\0')) { + copied = FALSE; + } else { + gtk_html_copy (GTK_HTML (focused_widget)); + gtk_clipboard_set_can_store (clipboard, NULL, 0); + gtk_clipboard_store (clipboard); + } } else if (GTK_IS_TEXT_VIEW (focused_widget)) { GtkTextBuffer *buffer; buffer = gtk_text_view_get_buffer (GTK_TEXT_VIEW (focused_widget)); @@ -3614,8 +3912,10 @@ paste_as_attachment_free (gpointer data) { PasteAsAttachmentHelper *helper = (PasteAsAttachmentHelper *) data; - gtk_widget_destroy (helper->banner); - g_object_unref (helper->banner); + if (helper->banner) { + gtk_widget_destroy (helper->banner); + g_object_unref (helper->banner); + } g_free (helper); } @@ -3669,7 +3969,6 @@ modest_ui_actions_on_paste (GtkAction *action, mail_op = modest_mail_operation_new (G_OBJECT (window)); if (helper->banner != NULL) { g_object_ref (G_OBJECT (helper->banner)); - gtk_window_set_modal (GTK_WINDOW (helper->banner), FALSE); gtk_widget_show (GTK_WIDGET (helper->banner)); } @@ -3804,9 +4103,9 @@ modest_ui_actions_on_select_all (GtkAction *action, /* Set focuse on header view */ gtk_widget_grab_focus (header_view); - /* Enable window dimming management */ modest_window_enable_dimming (MODEST_WINDOW(window)); + modest_ui_actions_check_menu_dimming_rules (MODEST_WINDOW (window)); modest_ui_actions_check_toolbar_dimming_rules (MODEST_WINDOW (window)); } @@ -3939,11 +4238,12 @@ headers_action_show_details (TnyHeader *header, dialog = modest_details_dialog_new_with_header (GTK_WINDOW (window), header); /* Run dialog */ - gtk_window_set_modal (GTK_WINDOW (dialog), TRUE); + modest_window_mgr_set_modal (modest_runtime_get_window_mgr (), GTK_WINDOW (dialog)); gtk_widget_show_all (dialog); - gtk_dialog_run (GTK_DIALOG (dialog)); - gtk_widget_destroy (dialog); + g_signal_connect_swapped (dialog, "response", + G_CALLBACK (gtk_widget_destroy), + dialog); } /* @@ -4167,8 +4467,13 @@ on_move_to_dialog_folder_selection_changed (ModestFolderView* self, return; children = gtk_container_get_children (GTK_CONTAINER (GTK_DIALOG (dialog)->action_area)); +#ifndef MODEST_TOOLKIT_GTK ok_button = GTK_WIDGET (children->next->next->data); new_button = GTK_WIDGET (children->next->data); +#else + ok_button = GTK_WIDGET (children->data); + new_button = GTK_WIDGET (children->next->next->data); +#endif g_list_free (children); /* check if folder_store is an remote account */ @@ -4183,15 +4488,17 @@ on_move_to_dialog_folder_selection_changed (ModestFolderView* self, if ((gpointer) local_account != (gpointer) folder_store && (gpointer) mmc_account != (gpointer) folder_store) { - const char *proto_name = tny_account_get_proto (TNY_ACCOUNT (folder_store)); - ModestTransportStoreProtocol proto = MODEST_PROTOCOL_STORE_MAILDIR; - if (proto_name != NULL) { - proto = modest_protocol_info_get_transport_store_protocol (proto_name); + ModestProtocolType proto; + proto = modest_tny_account_get_protocol_type (TNY_ACCOUNT (folder_store)); + if (proto == MODEST_PROTOCOL_REGISTRY_TYPE_INVALID) { + proto = MODEST_PROTOCOLS_STORE_MAILDIR; } is_local_account = FALSE; /* New button should be dimmed on remote POP account root */ - new_sensitive = (proto != MODEST_PROTOCOL_STORE_POP); + new_sensitive = (modest_protocol_registry_protocol_type_has_tag (modest_runtime_get_protocol_registry (), + proto, + MODEST_PROTOCOL_REGISTRY_STORE_HAS_FOLDERS)); } g_object_unref (local_account); g_object_unref (mmc_account); @@ -4305,12 +4612,24 @@ create_move_to_dialog (GtkWindow *win, GTK_DIALOG_MODAL | GTK_DIALOG_NO_SEPARATOR | GTK_DIALOG_DESTROY_WITH_PARENT, NULL); +#ifndef MODEST_TOOLKIT_GTK gtk_dialog_add_button (GTK_DIALOG (dialog), _("mcen_bd_dialog_ok"), GTK_RESPONSE_ACCEPT); /* We do this manually so GTK+ does not associate a response ID for * the button. */ new_button = gtk_button_new_from_stock (_("mcen_bd_new")); gtk_box_pack_end (GTK_BOX (GTK_DIALOG (dialog)->action_area), new_button, FALSE, FALSE, 0); gtk_dialog_add_button (GTK_DIALOG (dialog), _("mcen_bd_dialog_cancel"), GTK_RESPONSE_REJECT); +#else + /* We do this manually so GTK+ does not associate a response ID for + * the button. */ + new_button = gtk_button_new_with_label (_("mcen_ti_new_folder")); + gtk_box_pack_start (GTK_BOX (GTK_DIALOG (dialog)->action_area), new_button, FALSE, FALSE, 0); + gtk_button_box_set_child_secondary (GTK_BUTTON_BOX (GTK_DIALOG (dialog)->action_area), new_button, TRUE); + gtk_dialog_add_button (GTK_DIALOG (dialog), GTK_STOCK_CANCEL, GTK_RESPONSE_REJECT); + gtk_dialog_add_button (GTK_DIALOG (dialog), GTK_STOCK_OK, GTK_RESPONSE_ACCEPT); + gtk_container_set_border_width (GTK_CONTAINER (dialog), 12); + gtk_box_set_spacing (GTK_BOX (GTK_DIALOG (dialog)->vbox), 24); +#endif /* Create scrolled window */ scroll = gtk_scrolled_window_new (NULL, NULL); @@ -4318,6 +4637,10 @@ create_move_to_dialog (GtkWindow *win, GTK_POLICY_AUTOMATIC, GTK_POLICY_AUTOMATIC); +#ifdef MODEST_TOOLKIT_GTK + gtk_scrolled_window_set_shadow_type (GTK_SCROLLED_WINDOW (scroll), GTK_SHADOW_IN); +#endif + /* Create folder view */ *tree_view = modest_platform_create_folder_view (NULL); @@ -4397,45 +4720,15 @@ create_move_to_dialog (GtkWindow *win, scroll, TRUE, TRUE, 0); gtk_widget_show_all (GTK_WIDGET(GTK_DIALOG(dialog)->vbox)); +#ifndef MODEST_TOOLKIT_GTK gtk_window_set_default_size (GTK_WINDOW (dialog), 300, 300); +#else + gtk_window_set_default_size (GTK_WINDOW (dialog), 600, 400); +#endif return dialog; } -/* - * Returns TRUE if at least one of the headers of the list belongs to - * a message that has been fully retrieved. - */ -#if 0 /* no longer in use. delete in 2007.10 */ -static gboolean -has_retrieved_msgs (TnyList *list) -{ - TnyIterator *iter; - gboolean found = FALSE; - - iter = tny_list_create_iterator (list); - while (!tny_iterator_is_done (iter) && !found) { - TnyHeader *header; - TnyHeaderFlags flags = 0; - - header = TNY_HEADER (tny_iterator_get_current (iter)); - if (header) { - flags = tny_header_get_flags (header); - if (flags & TNY_HEADER_FLAG_CACHED) -/* if (!(flags & TNY_HEADER_FLAG_PARTIAL)) */ - found = TRUE; - - g_object_unref (header); - } - - if (!found) - tny_iterator_next (iter); - } - g_object_unref (iter); - - return found; -} -#endif /* 0 */ /* @@ -4500,6 +4793,21 @@ modest_ui_actions_msgs_move_to_confirmation (ModestWindow *win, } static void +move_to_helper_destroyer (gpointer user_data) +{ + MoveToHelper *helper = (MoveToHelper *) user_data; + + /* Close the "Pasting" information banner */ + if (helper->banner) { + gtk_widget_destroy (GTK_WIDGET (helper->banner)); + g_object_unref (helper->banner); + } + if (helper->reference != NULL) + gtk_tree_row_reference_free (helper->reference); + g_free (helper); +} + +static void move_to_cb (ModestMailOperation *mail_op, gpointer user_data) { @@ -4537,13 +4845,8 @@ move_to_cb (ModestMailOperation *mail_op, } g_object_unref (object); } - - /* Close the "Pasting" information banner */ - gtk_widget_destroy (GTK_WIDGET(helper->banner)); - g_object_unref (helper->banner); - if (helper->reference != NULL) - gtk_tree_row_reference_free (helper->reference); - g_free (helper); + /* Destroy the helper */ + move_to_helper_destroyer (helper); } static void @@ -4654,7 +4957,9 @@ open_msg_for_purge_cb (ModestMailOperation *mail_op, response = modest_platform_run_confirmation_dialog (GTK_WINDOW (win),_("mcen_nc_purge_file_text_inbox")); if (response == GTK_RESPONSE_OK) { - modest_platform_information_banner (NULL, NULL, _("mcen_ib_removing_attachment")); + GtkWidget *info; + info = + modest_platform_animation_banner (GTK_WIDGET (win), NULL, _("mcen_ib_removing_attachment")); iter = tny_list_create_iterator (parts); while (!tny_iterator_is_done (iter)) { TnyMimePart *part; @@ -4671,10 +4976,9 @@ open_msg_for_purge_cb (ModestMailOperation *mail_op, g_object_unref (iter); tny_msg_rewrite_cache (msg); + + gtk_widget_destroy (info); } - /* } else { */ - /* This string no longer exists, refer to NB#75415 for more info */ - /* modest_platform_information_banner (NULL, NULL, _("mail_ib_attachment_already_purged")); */ } modest_window_mgr_unregister_header (mgr, header); @@ -4735,7 +5039,7 @@ modest_ui_actions_on_main_window_remove_attachments (GtkAction *action, modest_ui_actions_disk_operations_error_handler, NULL, NULL); modest_mail_operation_queue_add (modest_runtime_get_mail_operation_queue (), mail_op); - modest_mail_operation_get_msg (mail_op, header, open_msg_for_purge_cb, win); + modest_mail_operation_get_msg (mail_op, header, FALSE, open_msg_for_purge_cb, win); g_object_unref (mail_op); } @@ -4803,7 +5107,7 @@ modest_ui_actions_xfer_messages_check (GtkWindow *parent_window, /* The transfer is possible and the user wants to */ *do_xfer = TRUE; - if (remote_folder_is_pop (src_folder) && delete_originals) { + if (remote_folder_has_leave_on_server (src_folder) && delete_originals) { const gchar *account_name; gboolean leave_on_server; @@ -4830,7 +5134,7 @@ xfer_messages_error_handler (ModestMailOperation *mail_op, gpointer user_data) { ModestWindow *main_window = NULL; - + /* Disable next automatic folder selection */ main_window = modest_window_mgr_get_main_window (modest_runtime_get_window_mgr (), FALSE); /* don't create */ @@ -4842,8 +5146,14 @@ xfer_messages_error_handler (ModestMailOperation *mail_op, if (win) g_object_unref (win); } + move_to_helper_destroyer (user_data); } +typedef struct { + TnyFolderStore *dst_folder; + TnyList *headers; +} XferMsgsHelper; + /** * Utility function that transfer messages from both the main window * and the msg view window when using the "Move to" dialog @@ -4855,90 +5165,74 @@ xfer_messages_performer (gboolean canceled, TnyAccount *account, gpointer user_data) { - TnyFolderStore *dst_folder = TNY_FOLDER_STORE (user_data); ModestWindow *win = MODEST_WINDOW (parent_window); - TnyList *headers = NULL; TnyAccount *dst_account = NULL; - const gchar *proto_str = NULL; - gboolean dst_is_pop = FALSE; + gboolean dst_forbids_message_add = FALSE; + XferMsgsHelper *helper; + MoveToHelper *movehelper; + ModestMailOperation *mail_op; - if (canceled) - goto end; + helper = (XferMsgsHelper *) user_data; - if (err) { - if (is_memory_full_error (err)) { - modest_platform_information_banner ((GtkWidget *) parent_window, - NULL, dgettext("ke-recv", - "cerm_device_memory_full")); - } else { + if (canceled || err) { + if (!check_memory_full_error ((GtkWidget *) parent_window, err)) { /* Show the proper error message */ modest_ui_actions_on_account_connection_error (parent_window, account); } goto end; } - dst_account = tny_folder_get_account (TNY_FOLDER (dst_folder)); - proto_str = tny_account_get_proto (dst_account); + dst_account = tny_folder_get_account (TNY_FOLDER (helper->dst_folder)); /* tinymail will return NULL for local folders it seems */ - dst_is_pop = proto_str && - (modest_protocol_info_get_transport_store_protocol (proto_str) == - MODEST_PROTOCOL_STORE_POP); - + dst_forbids_message_add = modest_protocol_registry_protocol_type_has_tag (modest_runtime_get_protocol_registry (), + modest_tny_account_get_protocol_type (dst_account), + MODEST_PROTOCOL_REGISTRY_STORE_FORBID_MESSAGE_ADD); g_object_unref (dst_account); - /* Get selected headers */ - headers = get_selected_headers (MODEST_WINDOW (win)); - if (!headers) { - g_warning ("%s: no headers selected", __FUNCTION__); - return; - } - - - if (dst_is_pop) { + if (dst_forbids_message_add) { modest_platform_information_banner (GTK_WIDGET (win), NULL, ngettext("mail_in_ui_folder_move_target_error", "mail_in_ui_folder_move_targets_error", - tny_list_get_length (headers))); - g_object_unref (headers); - return; + tny_list_get_length (helper->headers))); + goto end; } - MoveToHelper *helper = g_new0 (MoveToHelper, 1); - helper->banner = modest_platform_animation_banner (GTK_WIDGET (win), NULL, - _CS("ckct_nw_pasting")); - if (helper->banner != NULL) { - g_object_ref (helper->banner); - gtk_window_set_modal (GTK_WINDOW(helper->banner), FALSE); - gtk_widget_show (GTK_WIDGET(helper->banner)); + movehelper = g_new0 (MoveToHelper, 1); + movehelper->banner = modest_platform_animation_banner (GTK_WIDGET (win), NULL, + _CS("ckct_nw_pasting")); + if (movehelper->banner != NULL) { + g_object_ref (movehelper->banner); + gtk_widget_show (GTK_WIDGET (movehelper->banner)); } if (MODEST_IS_MAIN_WINDOW (win)) { GtkWidget *header_view = modest_main_window_get_child_widget (MODEST_MAIN_WINDOW(win), MODEST_MAIN_WINDOW_WIDGET_TYPE_HEADER_VIEW); - helper->reference = get_next_after_selected_headers (MODEST_HEADER_VIEW (header_view)); + movehelper->reference = get_next_after_selected_headers (MODEST_HEADER_VIEW (header_view)); } - ModestMailOperation *mail_op = - modest_mail_operation_new_with_error_handling (G_OBJECT(win), - xfer_messages_error_handler, - NULL, NULL); + /* Perform the mail operation */ + mail_op = modest_mail_operation_new_with_error_handling (G_OBJECT(win), + xfer_messages_error_handler, + movehelper, NULL); modest_mail_operation_queue_add (modest_runtime_get_mail_operation_queue (), mail_op); modest_mail_operation_xfer_msgs (mail_op, - headers, - TNY_FOLDER (dst_folder), + helper->headers, + TNY_FOLDER (helper->dst_folder), TRUE, msgs_move_to_cb, - helper); + movehelper); g_object_unref (G_OBJECT (mail_op)); - g_object_unref (headers); end: - g_object_unref (dst_folder); + g_object_unref (helper->dst_folder); + g_object_unref (helper->headers); + g_slice_free (XferMsgsHelper, helper); } typedef struct { @@ -4968,7 +5262,6 @@ on_move_folder_cb (gboolean canceled, GError *err, GtkWindow *parent_window, _CS("ckct_nw_pasting")); if (helper->banner != NULL) { g_object_ref (helper->banner); - gtk_window_set_modal (GTK_WINDOW(helper->banner), FALSE); gtk_widget_show (GTK_WIDGET(helper->banner)); } /* Clean folder on header view before moving it */ @@ -5082,8 +5375,8 @@ modest_ui_actions_on_main_window_move_to (GtkAction *action, headers = modest_header_view_get_selected_headers(header_view); /* Transfer the messages */ - transfer_messages_helper (GTK_WINDOW (win), TNY_FOLDER (src_folder), - headers, TNY_FOLDER (dst_folder)); + modest_ui_actions_transfer_messages_helper (GTK_WINDOW (win), TNY_FOLDER (src_folder), + headers, TNY_FOLDER (dst_folder)); g_object_unref (headers); } @@ -5093,14 +5386,19 @@ modest_ui_actions_on_main_window_move_to (GtkAction *action, } -static void -transfer_messages_helper (GtkWindow *win, - TnyFolder *src_folder, - TnyList *headers, - TnyFolder *dst_folder) +void +modest_ui_actions_transfer_messages_helper (GtkWindow *win, + TnyFolder *src_folder, + TnyList *headers, + TnyFolder *dst_folder) { gboolean need_connection = TRUE; gboolean do_xfer = TRUE; + XferMsgsHelper *helper; + + g_return_if_fail (TNY_IS_FOLDER (src_folder)); + g_return_if_fail (TNY_IS_FOLDER (dst_folder)); + g_return_if_fail (TNY_IS_LIST (headers)); modest_ui_actions_xfer_messages_check (win, TNY_FOLDER_STORE (src_folder), headers, TNY_FOLDER (dst_folder), @@ -5111,11 +5409,16 @@ transfer_messages_helper (GtkWindow *win, if (!do_xfer) return; + /* Create the helper */ + helper = g_slice_new (XferMsgsHelper); + helper->dst_folder = g_object_ref (dst_folder); + helper->headers = g_object_ref (headers); + if (need_connection) { DoubleConnectionInfo *connect_info = g_slice_new (DoubleConnectionInfo); connect_info->callback = xfer_messages_performer; connect_info->dst_account = tny_folder_get_account (TNY_FOLDER (dst_folder)); - connect_info->data = g_object_ref (dst_folder); + connect_info->data = helper; modest_platform_double_connect_and_perform(GTK_WINDOW (win), TRUE, TNY_FOLDER_STORE (src_folder), @@ -5123,8 +5426,7 @@ transfer_messages_helper (GtkWindow *win, } else { TnyAccount *src_account = get_account_from_folder_store (TNY_FOLDER_STORE (src_folder)); xfer_messages_performer (FALSE, NULL, GTK_WINDOW (win), - src_account, - g_object_ref (dst_folder)); + src_account, helper); g_object_unref (src_account); } } @@ -5151,10 +5453,11 @@ modest_ui_actions_on_msg_view_window_move_to (GtkAction *action, tny_list_append (headers, G_OBJECT (header)); /* Transfer the messages */ - transfer_messages_helper (GTK_WINDOW (win), src_folder, headers, - TNY_FOLDER (dst_folder)); + modest_ui_actions_transfer_messages_helper (GTK_WINDOW (win), src_folder, headers, + TNY_FOLDER (dst_folder)); /* Frees */ + g_object_unref (src_folder); g_object_unref (header); g_object_unref (headers); } @@ -5189,7 +5492,7 @@ modest_ui_actions_on_move_to (GtkAction *action, /* Create and run the dialog */ dialog = create_move_to_dialog (GTK_WINDOW (win), folder_view, &tree_view); modest_folder_view_select_first_inbox_or_local (MODEST_FOLDER_VIEW (tree_view)); - gtk_window_set_modal (GTK_WINDOW (dialog), TRUE); + modest_window_mgr_set_modal (modest_runtime_get_window_mgr (), GTK_WINDOW (dialog)); result = gtk_dialog_run (GTK_DIALOG(dialog)); g_object_ref (tree_view); gtk_widget_destroy (dialog); @@ -5276,6 +5579,10 @@ modest_ui_actions_save_attachments (GtkAction *action, ModestWindow *window) { if (MODEST_IS_MSG_VIEW_WINDOW (window)) { + + if (modest_platform_check_memory_low (MODEST_WINDOW(window), TRUE)) + return; + modest_msg_view_window_save_attachments (MODEST_MSG_VIEW_WINDOW (window), NULL); } else { /* not supported window for this action */ @@ -5319,15 +5626,53 @@ modest_ui_actions_on_help (GtkAction *action, { const gchar *help_id; - g_return_if_fail (action); g_return_if_fail (win && GTK_IS_WINDOW(win)); help_id = modest_window_mgr_get_help_id (modest_runtime_get_window_mgr(), win); - - if (help_id) - modest_platform_show_help (GTK_WINDOW (win), help_id); + + if (help_id) + modest_platform_show_help (GTK_WINDOW (win), help_id); +} + +void +modest_ui_actions_on_csm_help (GtkAction *action, + GtkWindow *win) +{ + const gchar* help_id = NULL; + GtkWidget *folder_view; + TnyFolderStore *folder_store; + + g_return_if_fail (win && MODEST_IS_MAIN_WINDOW (win)); + + /* Get selected folder */ + folder_view = modest_main_window_get_child_widget (MODEST_MAIN_WINDOW (win), + MODEST_MAIN_WINDOW_WIDGET_TYPE_FOLDER_VIEW); + folder_store = modest_folder_view_get_selected (MODEST_FOLDER_VIEW (folder_view)); + + /* Switch help_id */ + if (folder_store && TNY_IS_FOLDER (folder_store)) + help_id = modest_tny_folder_get_help_id (TNY_FOLDER (folder_store)); + + if (folder_store) + g_object_unref (folder_store); + + if (help_id) + modest_platform_show_help (GTK_WINDOW (win), help_id); else - g_warning ("%s: no help for window %p", __FUNCTION__, win); + modest_ui_actions_on_help (action, win); +} + +static void +retrieve_contents_cb (ModestMailOperation *mail_op, + TnyHeader *header, + gboolean canceled, + TnyMsg *msg, + GError *err, + gpointer user_data) +{ + /* We only need this callback to show an error in case of + memory low condition */ + modest_ui_actions_msg_retrieval_check (mail_op, header, msg); } static void @@ -5341,11 +5686,7 @@ retrieve_msg_contents_performer (gboolean canceled, TnyList *headers = TNY_LIST (user_data); if (err || canceled) { - if (err && is_memory_full_error (err)) { - modest_platform_information_banner ((GtkWidget *) parent_window, - NULL, dgettext("ke-recv", - "cerm_device_memory_full")); - } + check_memory_full_error ((GtkWidget *) parent_window, err); goto out; } @@ -5354,7 +5695,7 @@ retrieve_msg_contents_performer (gboolean canceled, modest_ui_actions_disk_operations_error_handler, NULL, NULL); modest_mail_operation_queue_add (modest_runtime_get_mail_operation_queue (), mail_op); - modest_mail_operation_get_msgs_full (mail_op, headers, NULL, NULL, NULL); + modest_mail_operation_get_msgs_full (mail_op, headers, retrieve_contents_cb, NULL, NULL); /* Frees */ g_object_unref (mail_op); @@ -5511,6 +5852,12 @@ modest_ui_actions_on_search_messages (GtkAction *action, ModestWindow *window) { g_return_if_fail (MODEST_IS_WINDOW (window)); + /* we check for low-mem; in that case, show a warning, and don't allow + * searching + */ + if (modest_platform_check_memory_low (window, TRUE)) + return; + modest_platform_show_search_messages (GTK_WINDOW (window)); } @@ -5518,6 +5865,15 @@ void modest_ui_actions_on_open_addressbook (GtkAction *action, ModestWindow *win) { g_return_if_fail (MODEST_IS_WINDOW (win)); + + + /* we check for low-mem; in that case, show a warning, and don't allow + * for the addressbook + */ + if (modest_platform_check_memory_low (win, TRUE)) + return; + + modest_platform_show_addressbook (GTK_WINDOW (win)); } @@ -5596,9 +5952,12 @@ modest_ui_actions_on_send_queue_error_happened (TnySendQueue *self, TnyTransportAccount *server_account; gchar *message = NULL; - /* Don't show anything if the user cancelled something or the send receive request is not - * interactive */ + /* Don't show anything if the user cancelled something or the + * send receive request is not interactive. Authentication + * errors are managed by the account store so no need to show + * a dialog here again */ if (err->code == TNY_SYSTEM_ERROR_CANCEL || + err->code == TNY_SERVICE_ERROR_AUTHENTICATE || !modest_tny_send_queue_get_requested_send_receive (MODEST_TNY_SEND_QUEUE (self))) return; @@ -5616,9 +5975,6 @@ modest_ui_actions_on_send_queue_error_happened (TnySendQueue *self, case TNY_SERVICE_ERROR_CONNECT: message = g_strdup_printf (_("emev_ib_ui_smtp_server_invalid"), server_name); break; - case TNY_SERVICE_ERROR_AUTHENTICATE: - message = g_strdup_printf (_("emev_ni_ui_smtp_authentication_fail_error"), server_name); - break; case TNY_SERVICE_ERROR_SEND: message = g_strdup (dgettext("hildon-common-strings", "sfil_ib_unable_to_send")); break; @@ -5631,10 +5987,6 @@ modest_ui_actions_on_send_queue_error_happened (TnySendQueue *self, message = g_strdup (dgettext("hildon-common-strings", "sfil_ib_unable_to_send")); break; } - - /* TODO if the username or the password where not defined we - should show the Accounts Settings dialog or the Connection - specific SMTP server window */ modest_platform_run_information_dialog (NULL, message, FALSE); g_free (message); @@ -5686,6 +6038,8 @@ modest_ui_actions_on_send_queue_status_changed (ModestTnySendQueue *send_queue, /* Rerun dimming rules, because the message could become deletable for example */ modest_window_check_dimming_rules_group (MODEST_WINDOW (main_window), MODEST_DIMMING_RULES_TOOLBAR); + modest_window_check_dimming_rules_group (MODEST_WINDOW (main_window), + MODEST_DIMMING_RULES_MENU); /* Free */ frees: @@ -5697,31 +6051,18 @@ void modest_ui_actions_on_account_connection_error (GtkWindow *parent_window, TnyAccount *account) { - ModestTransportStoreProtocol proto; - const gchar *proto_name; + ModestProtocolType protocol_type; + ModestProtocol *protocol; gchar *error_note = NULL; - proto_name = tny_account_get_proto (account); - proto = modest_protocol_info_get_transport_store_protocol (proto_name); - - switch (proto) { - case MODEST_PROTOCOL_STORE_POP: - error_note = g_strdup_printf (_("emev_ni_ui_pop3_msg_connect_error"), - tny_account_get_hostname (account)); - break; - case MODEST_PROTOCOL_STORE_IMAP: - error_note = g_strdup_printf (_("emev_ni_ui_imap_connect_server_error"), - tny_account_get_hostname (account)); - break; - case MODEST_PROTOCOL_STORE_MAILDIR: - case MODEST_PROTOCOL_STORE_MBOX: - error_note = g_strdup (_("emev_nc_mailbox_notavailable")); - break; - default: - g_warning ("%s: This should not be reached", __FUNCTION__); - } + protocol_type = modest_tny_account_get_protocol_type (account); + protocol = modest_protocol_registry_get_protocol_by_type (modest_runtime_get_protocol_registry (), + protocol_type); - if (error_note) { + error_note = modest_protocol_get_translation (protocol, MODEST_PROTOCOL_TRANSLATION_ACCOUNT_CONNECTION_ERROR, tny_account_get_hostname (account)); + if (error_note == NULL) { + g_warning ("%s: This should not be reached", __FUNCTION__); + } else { modest_platform_run_information_dialog (parent_window, error_note, FALSE); g_free (error_note); } @@ -5731,9 +6072,11 @@ gchar * modest_ui_actions_get_msg_already_deleted_error_msg (ModestWindow *win) { gchar *msg = NULL; + gchar *subject; TnyFolderStore *folder = NULL; TnyAccount *account = NULL; - ModestTransportStoreProtocol proto; + ModestProtocolType proto; + ModestProtocol *protocol; TnyHeader *header = NULL; if (MODEST_IS_MAIN_WINDOW (win)) { @@ -5760,16 +6103,14 @@ modest_ui_actions_get_msg_already_deleted_error_msg (ModestWindow *win) /* Get the account type */ account = tny_folder_get_account (TNY_FOLDER (folder)); - proto = modest_protocol_info_get_transport_store_protocol (tny_account_get_proto (account)); - if (proto == MODEST_PROTOCOL_STORE_POP) { - msg = g_strdup (_("emev_ni_ui_pop3_msg_recv_error")); - } else if (proto == MODEST_PROTOCOL_STORE_IMAP) { - gchar *subject; - subject = tny_header_dup_subject (header); - msg = g_strdup_printf (_("emev_ni_ui_imap_message_not_available_in_server"), - subject); - g_free (subject); - } else { + proto = modest_tny_account_get_protocol_type (account); + protocol = modest_protocol_registry_get_protocol_by_type (modest_runtime_get_protocol_registry (), + proto); + + subject = tny_header_dup_subject (header); + msg = modest_protocol_get_translation (protocol, MODEST_PROTOCOL_TRANSLATION_MSG_NOT_AVAILABLE, subject); + g_free (subject); + if (msg == NULL) { msg = g_strdup_printf (_("mail_ni_ui_folder_get_msg_folder_error")); }