X-Git-Url: http://git.maemo.org/git/?p=modest;a=blobdiff_plain;f=src%2Fmodest-ui-actions.c;h=9c88b5d5b7963142b92cb8c067eeb11c86ea78bb;hp=a175fb0f38ac1a835925ac94bc31d90551feba44;hb=93540692199f400bd03936d3ac1d7340a2710d14;hpb=d27a0a29347366d5421e7e796eca4655ef0d095a diff --git a/src/modest-ui-actions.c b/src/modest-ui-actions.c index a175fb0..9c88b5d 100644 --- a/src/modest-ui-actions.c +++ b/src/modest-ui-actions.c @@ -70,7 +70,7 @@ #include "modest-text-utils.h" #ifdef MODEST_HAVE_EASYSETUP -#include "easysetup/modest-easysetup-wizard.h" +#include "easysetup/modest-easysetup-wizard-dialog.h" #endif /* MODEST_HAVE_EASYSETUP */ #include @@ -154,10 +154,7 @@ static gboolean connect_to_get_msg (ModestWindow *win, gint num_of_uncached_msgs, TnyAccount *account); -static gboolean remote_folder_is_pop (const TnyFolderStore *folder); - -static gboolean msgs_already_deleted_from_server ( TnyList *headers, - const TnyFolderStore *src_folder); +static gboolean remote_folder_is_pop (TnyFolderStore *folder); static void do_create_folder (GtkWindow *window, TnyFolderStore *parent_folder, @@ -165,55 +162,31 @@ static void do_create_folder (GtkWindow *window, static GtkWidget* get_folder_view_from_move_to_dialog (GtkWidget *move_to_dialog); +static TnyAccount *get_account_from_folder_store (TnyFolderStore *folder_store); + +static void transfer_messages_helper (GtkWindow *win, + TnyFolder *src_folder, + TnyList *headers, + TnyFolder *dst_folder); /* * This function checks whether a TnyFolderStore is a pop account */ static gboolean -remote_folder_is_pop (const TnyFolderStore *folder) +remote_folder_is_pop (TnyFolderStore *folder) { const gchar *proto = NULL; TnyAccount *account = NULL; - g_return_val_if_fail (TNY_IS_FOLDER_STORE(folder), FALSE); - - if (TNY_IS_ACCOUNT (folder)) { - account = TNY_ACCOUNT(folder); - g_object_ref(account); - } else if (TNY_IS_FOLDER (folder)) { - account = tny_folder_get_account(TNY_FOLDER(folder)); - } - - if (!TNY_IS_ACCOUNT(account)) { - g_warning ("%s: could not get account", __FUNCTION__); - return FALSE; - } + g_return_val_if_fail (TNY_IS_FOLDER_STORE (folder), FALSE); - proto = tny_account_get_proto(account); + account = get_account_from_folder_store (folder); + proto = tny_account_get_proto (account); g_object_unref (account); - return proto && - (modest_protocol_info_get_transport_store_protocol (proto) == MODEST_PROTOCOL_STORE_POP); -} - -/* - * This functions checks whether if a list of messages are already - * deleted from the server: that is, if the server is a POP account - * and all messages are already cached. - */ -static gboolean -msgs_already_deleted_from_server (TnyList *headers, const TnyFolderStore *src_folder) -{ - g_return_val_if_fail (TNY_IS_FOLDER_STORE(src_folder), FALSE); - g_return_val_if_fail (TNY_IS_LIST(headers), FALSE); - - gboolean src_is_pop = remote_folder_is_pop (src_folder); - gint uncached_msgs = header_list_count_uncached_msgs (headers); - - return (src_is_pop && !uncached_msgs); + return (modest_protocol_info_get_transport_store_protocol (proto) == MODEST_PROTOCOL_STORE_POP); } - /* FIXME: this should be merged with the similar code in modest-account-view-window */ /* Show the account creation wizard dialog. * returns: TRUE if an account was created. FALSE if the user cancelled. @@ -395,11 +368,8 @@ void modest_ui_actions_refresh_message_window_after_delete (ModestMsgViewWindow* win) { /* Close msg view window or select next */ - if (modest_msg_view_window_last_message_selected (win) && - modest_msg_view_window_first_message_selected (win)) { - modest_ui_actions_on_close_window (NULL, MODEST_WINDOW (win)); - } else if (!modest_msg_view_window_select_next_message (win) && - !modest_msg_view_window_select_previous_message (win)) { + if (!modest_msg_view_window_select_next_message (win) && + !modest_msg_view_window_select_previous_message (win)) { gboolean ret_value; g_signal_emit_by_name (G_OBJECT (win), "delete-event", NULL, &ret_value); } @@ -733,7 +703,8 @@ modest_ui_actions_compose_msg(ModestWindow *win, const gchar *bcc_str, const gchar *subject_str, const gchar *body_str, - GSList *attachments) + GSList *attachments, + gboolean set_as_modified) { gchar *account_name = NULL; TnyMsg *msg = NULL; @@ -788,6 +759,8 @@ modest_ui_actions_compose_msg(ModestWindow *win, attachments = g_slist_next(attachments); } modest_window_mgr_register_window (modest_runtime_get_window_mgr(), msg_win); + modest_msg_edit_window_set_modified (MODEST_MSG_EDIT_WINDOW (msg_win), set_as_modified); + gtk_widget_show_all (GTK_WIDGET (msg_win)); cleanup: @@ -809,7 +782,7 @@ modest_ui_actions_on_new_msg (GtkAction *action, ModestWindow *win) if (!modest_ui_actions_run_account_setup_wizard (win)) return; - modest_ui_actions_compose_msg(win, NULL, NULL, NULL, NULL, NULL, NULL); + modest_ui_actions_compose_msg(win, NULL, NULL, NULL, NULL, NULL, NULL, FALSE); } @@ -834,6 +807,28 @@ modest_ui_actions_msg_retrieval_check (ModestMailOperation *mail_op, return TRUE; } +typedef struct { + guint idle_handler; + gchar *message; + GtkWidget *banner; +} OpenMsgBannerInfo; + +gboolean +open_msg_banner_idle (gpointer userdata) +{ + OpenMsgBannerInfo *banner_info = (OpenMsgBannerInfo *) userdata; + + gdk_threads_enter (); + banner_info->idle_handler = 0; + banner_info->banner = modest_platform_animation_banner (NULL, NULL, banner_info->message); + g_object_ref (banner_info->banner); + + gdk_threads_leave (); + + return FALSE; + +} + static void open_msg_cb (ModestMailOperation *mail_op, TnyHeader *header, @@ -849,12 +844,13 @@ open_msg_cb (ModestMailOperation *mail_op, gchar *account = NULL; TnyFolder *folder; gboolean open_in_editor = FALSE; + OpenMsgBannerInfo *banner_info = (OpenMsgBannerInfo *) user_data; /* Do nothing if there was any problem with the mail operation. The error will be shown by the error_handler of the mail operation */ if (!modest_ui_actions_msg_retrieval_check (mail_op, header, msg)) - return; + goto banner_cleanup; parent_win = (ModestWindow *) modest_mail_operation_get_source (mail_op); folder = tny_header_get_folder (header); @@ -935,9 +931,6 @@ open_msg_cb (ModestMailOperation *mail_op, win = modest_msg_edit_window_new (msg, account, TRUE); - /* Show banner */ - modest_platform_information_banner_with_timeout - (NULL, NULL, _("mail_ib_opening_draft_message"), 1200); } else { gchar *uid = modest_tny_folder_get_header_unique_id (header); @@ -992,11 +985,25 @@ cleanup: g_free(account); g_object_unref (parent_win); g_object_unref (folder); +banner_cleanup: + if (banner_info) { + g_free (banner_info->message); + if (banner_info->idle_handler > 0) { + g_source_remove (banner_info->idle_handler); + banner_info->idle_handler = 0; + } + if (banner_info->banner != NULL) { + gtk_widget_destroy (banner_info->banner); + g_object_unref (banner_info->banner); + banner_info->banner = NULL; + } + g_slice_free (OpenMsgBannerInfo, banner_info); + } } void -modest_ui_actions_get_msgs_full_error_handler (ModestMailOperation *mail_op, - gpointer user_data) +modest_ui_actions_disk_operations_error_handler (ModestMailOperation *mail_op, + gpointer user_data) { const GError *error; GObject *win = NULL; @@ -1008,9 +1015,13 @@ modest_ui_actions_get_msgs_full_error_handler (ModestMailOperation *mail_op, if (error->code == TNY_SYSTEM_ERROR_MEMORY || error->code == TNY_IO_ERROR_WRITE || error->code == TNY_IO_ERROR_READ) { - modest_platform_information_banner ((GtkWidget *) win, - NULL, dgettext("ke-recv", - "cerm_device_memory_full")); + ModestMailOperationStatus st = modest_mail_operation_get_status (mail_op); + /* If the mail op has been cancelled then it's not an error: don't show any message */ + if (st != MODEST_MAIL_OPERATION_STATUS_CANCELED) { + modest_platform_information_banner ((GtkWidget *) win, + NULL, dgettext("ke-recv", + "cerm_device_memory_full")); + } } else if (user_data) { modest_platform_information_banner ((GtkWidget *) win, NULL, user_data); @@ -1033,9 +1044,29 @@ get_account_from_header_list (TnyList *headers) TnyIterator *iter = tny_list_create_iterator (headers); TnyHeader *header = TNY_HEADER (tny_iterator_get_current (iter)); TnyFolder *folder = tny_header_get_folder (header); - account = tny_folder_get_account (folder); - g_object_unref (folder); - g_object_unref (header); + + if (!folder) { + g_object_unref (header); + + while (!tny_iterator_is_done (iter)) { + header = TNY_HEADER (tny_iterator_get_current (iter)); + folder = tny_header_get_folder (header); + if (folder) + break; + g_object_unref (header); + header = NULL; + tny_iterator_next (iter); + } + } + + if (folder) { + account = tny_folder_get_account (folder); + g_object_unref (folder); + } + + if (header) + g_object_unref (header); + g_object_unref (iter); } return account; @@ -1064,6 +1095,8 @@ open_msgs_performer(gboolean canceled, ModestTransportStoreProtocol proto; TnyList *not_opened_headers; TnyConnectionStatus status; + gboolean show_open_draft = FALSE; + OpenMsgBannerInfo *banner_info = NULL; not_opened_headers = TNY_LIST (user_data); @@ -1095,6 +1128,19 @@ open_msgs_performer(gboolean canceled, g_object_unref (header); g_object_unref (iter); } else { + TnyHeader *header; + TnyFolder *folder; + TnyIterator *iter; + TnyFolderType folder_type; + + iter = tny_list_create_iterator (not_opened_headers); + header = TNY_HEADER (tny_iterator_get_current (iter)); + folder = tny_header_get_folder (header); + folder_type = modest_tny_folder_get_local_or_mmc_folder_type (folder); + show_open_draft = (folder_type == TNY_FOLDER_TYPE_DRAFTS); + g_object_unref (folder); + g_object_unref (header); + g_object_unref (iter); error_msg = g_strdup (_("mail_ni_ui_folder_get_msg_folder_error")); } } else { @@ -1104,15 +1150,22 @@ open_msgs_performer(gboolean canceled, /* Create the mail operation */ mail_op = modest_mail_operation_new_with_error_handling ((GObject *) parent_window, - modest_ui_actions_get_msgs_full_error_handler, + modest_ui_actions_disk_operations_error_handler, error_msg, g_free); modest_mail_operation_queue_add (modest_runtime_get_mail_operation_queue (), mail_op); - + + if (show_open_draft) { + banner_info = g_slice_new (OpenMsgBannerInfo); + banner_info->message = g_strdup (_("mail_ib_opening_draft_message")); + banner_info->banner = NULL; + banner_info->idle_handler = g_timeout_add (500, open_msg_banner_idle, banner_info); + } + modest_mail_operation_get_msgs_full (mail_op, not_opened_headers, open_msg_cb, - NULL, + banner_info, NULL); /* Frees */ @@ -1142,8 +1195,8 @@ open_msgs_from_headers (TnyList *headers, ModestWindow *win) /* Check that only one message is selected for opening */ if (tny_list_get_length (headers) != 1) { - modest_platform_run_information_dialog ((win) ? GTK_WINDOW (win) : NULL, - _("mcen_ib_select_one_message")); + modest_platform_information_banner ((win) ? GTK_WIDGET (win) : NULL, + NULL, _("mcen_ib_select_one_message")); return; } @@ -1152,7 +1205,10 @@ open_msgs_from_headers (TnyList *headers, ModestWindow *win) /* Get the account */ account = get_account_from_header_list (headers); - + + if (!account) + return; + /* Look if we already have a message view for each header. If true, then remove the header from the list of headers to open */ @@ -1475,8 +1531,10 @@ reply_forward (ReplyForwardAction action, ModestWindow *win) * whether he/she wants to download them. */ if (num_of_unc_msgs) { TnyAccount *account = get_account_from_header_list (header_list); - continue_download = connect_to_get_msg (win, num_of_unc_msgs, account); - g_object_unref (account); + if (account) { + continue_download = connect_to_get_msg (win, num_of_unc_msgs, account); + g_object_unref (account); + } } } @@ -1533,7 +1591,7 @@ reply_forward (ReplyForwardAction action, ModestWindow *win) if (do_retrieve) { mail_op = modest_mail_operation_new_with_error_handling (G_OBJECT(win), - modest_ui_actions_get_msgs_full_error_handler, + modest_ui_actions_disk_operations_error_handler, NULL, NULL); modest_mail_operation_queue_add ( modest_runtime_get_mail_operation_queue (), mail_op); @@ -1699,6 +1757,7 @@ typedef struct { TnyAccount *account; ModestWindow *win; gchar *account_name; + gboolean poke_status; } SendReceiveInfo; static void @@ -1733,7 +1792,7 @@ do_send_receive_performer (gboolean canceled, /* Send & receive. */ modest_mail_operation_queue_add (modest_runtime_get_mail_operation_queue (), mail_op); - modest_mail_operation_update_account (mail_op, info->account_name, (info->win) ? FALSE : TRUE, + modest_mail_operation_update_account (mail_op, info->account_name, info->poke_status, (info->win) ? retrieve_all_messages_cb : NULL, new_messages_arrived, info->win); g_object_unref (G_OBJECT (mail_op)); @@ -1758,6 +1817,7 @@ do_send_receive_performer (gboolean canceled, void modest_ui_actions_do_send_receive (const gchar *account_name, gboolean force_connection, + gboolean poke_status, ModestWindow *win) { gchar *acc_name = NULL; @@ -1785,6 +1845,7 @@ modest_ui_actions_do_send_receive (const gchar *account_name, info = g_slice_new (SendReceiveInfo); info->account_name = acc_name; info->win = (win) ? g_object_ref (win) : NULL; + info->poke_status = poke_status; info->account = modest_tny_account_store_get_server_account (acc_store, acc_name, TNY_ACCOUNT_TYPE_STORE); @@ -1873,7 +1934,8 @@ modest_ui_actions_cancel_send (GtkAction *action, ModestWindow *win) */ void modest_ui_actions_do_send_receive_all (ModestWindow *win, - gboolean force_connection) + gboolean force_connection, + gboolean poke_status) { GSList *account_names, *iter; @@ -1882,7 +1944,9 @@ modest_ui_actions_do_send_receive_all (ModestWindow *win, iter = account_names; while (iter) { - modest_ui_actions_do_send_receive ((const char*) iter->data, force_connection, win); + modest_ui_actions_do_send_receive ((const char*) iter->data, + force_connection, + poke_status, win); iter = g_slist_next (iter); } @@ -1923,8 +1987,9 @@ modest_ui_actions_on_send_receive (GtkAction *action, ModestWindow *win) g_object_unref (folder_store); } - /* Refresh the active account. Force the connection if needed */ - modest_ui_actions_do_send_receive (NULL, TRUE, win); + /* Refresh the active account. Force the connection if needed + and poke the status of all folders */ + modest_ui_actions_do_send_receive (NULL, TRUE, TRUE, win); } @@ -1992,6 +2057,7 @@ modest_ui_actions_on_header_selected (ModestHeaderView *header_view, gtk_widget_grab_focus (GTK_WIDGET(header_view)); /* Update toolbar dimming state */ + modest_ui_actions_check_menu_dimming_rules (MODEST_WINDOW (main_window)); modest_ui_actions_check_toolbar_dimming_rules (MODEST_WINDOW (main_window)); } @@ -2264,15 +2330,10 @@ on_save_to_drafts_cb (ModestMailOperation *mail_op, edit_window = MODEST_MSG_EDIT_WINDOW (user_data); - /* It might not be a good idea to do nothing if there was an error, - * so let's at least show a generic error banner. */ - /* TODO error while saving attachment, show "Saving draft failed" banner */ - if (modest_mail_operation_get_error (mail_op) != NULL) { - g_warning ("%s failed: %s\n", __FUNCTION__, (modest_mail_operation_get_error (mail_op))->message); - modest_platform_information_banner (NULL, NULL, _("mail_ib_file_operation_failed")); - } else { + /* Set draft is there was no error */ + if (!modest_mail_operation_get_error (mail_op)) modest_msg_edit_window_set_draft (edit_window, saved_draft); - } + g_object_unref(edit_window); } @@ -2289,6 +2350,7 @@ modest_ui_actions_on_save_to_drafts (GtkWidget *widget, ModestMsgEditWindow *edi guint64 available_disk, expected_size; gint parts_count; guint64 parts_size; + ModestMainWindow *win; g_return_val_if_fail (MODEST_IS_MSG_EDIT_WINDOW(edit_window), FALSE); @@ -2339,7 +2401,8 @@ modest_ui_actions_on_save_to_drafts (GtkWidget *widget, ModestMsgEditWindow *edi from = modest_account_mgr_get_from_string (account_mgr, account_name); /* Create the mail operation */ - mail_operation = modest_mail_operation_new (NULL); + mail_operation = modest_mail_operation_new_with_error_handling (NULL, modest_ui_actions_disk_operations_error_handler, + NULL, NULL); modest_mail_operation_queue_add (modest_runtime_get_mail_operation_queue (), mail_operation); modest_mail_operation_save_to_drafts (mail_operation, @@ -2358,9 +2421,19 @@ modest_ui_actions_on_save_to_drafts (GtkWidget *widget, ModestMsgEditWindow *edi on_save_to_drafts_cb, g_object_ref(edit_window)); -/* info_text = g_strdup_printf (_("mail_va_saved_to_drafts"), _("mcen_me_folder_drafts")); */ - modest_platform_information_banner (NULL, NULL, _CS("sfil_ib_saving")); - modest_msg_edit_window_reset_modified (edit_window); + /* Use the main window as the parent of the banner, if the + main window does not exist it won't be shown, if the parent + window exists then it's properly shown. We don't use the + editor window because it could be closed (save to drafts + could happen after closing the window */ + win = (ModestMainWindow *) + modest_window_mgr_get_main_window( modest_runtime_get_window_mgr(), FALSE); + if (win) { + gchar *text = g_strdup_printf (_("mail_va_saved_to_drafts"), _("mcen_me_folder_drafts")); + modest_platform_information_banner (GTK_WIDGET (win), NULL, text); + g_free (text); + } + modest_msg_edit_window_set_modified (edit_window, FALSE); /* Frees */ g_free (from); @@ -2385,8 +2458,6 @@ modest_ui_actions_on_save_to_drafts (GtkWidget *widget, ModestMsgEditWindow *edi * we find a better solution it should be removed * See NB#65125 (commend #18) for details. */ - ModestMainWindow *win = MODEST_MAIN_WINDOW(modest_window_mgr_get_main_window( - modest_runtime_get_window_mgr(), FALSE)); if (!had_error && win != NULL) { ModestFolderView *view = MODEST_FOLDER_VIEW(modest_main_window_get_child_widget( win, MODEST_MAIN_WINDOW_WIDGET_TYPE_FOLDER_VIEW)); @@ -2425,9 +2496,6 @@ modest_ui_actions_on_send (GtkWidget *widget, ModestMsgEditWindow *edit_window) if (!modest_msg_edit_window_check_names (edit_window, TRUE)) return TRUE; - /* FIXME: Code added just for testing. The final version will - use the send queue provided by tinymail and some - classifier */ MsgData *data = modest_msg_edit_window_get_msg_data (edit_window); /* Check size */ @@ -2681,11 +2749,20 @@ do_create_folder_cb (ModestMailOperation *mail_op, GtkWindow *source_win = (GtkWindow *) modest_mail_operation_get_source (mail_op); if (modest_mail_operation_get_error (mail_op)) { - /* Show an error */ - modest_platform_information_banner (GTK_WIDGET (source_win), NULL, - _("mail_in_ui_folder_create_error")); - /* Try again */ + /* Show an error. If there was some problem writing to + disk, show it, otherwise show the generic folder + create error. We do it here and not in an error + handler because the call to do_create_folder will + stop the main loop in a gtk_dialog_run and then, + the message won't be shown until that dialog is + closed */ + modest_ui_actions_disk_operations_error_handler (mail_op, + _("mail_in_ui_folder_create_error")); + + /* Try again. Do *NOT* show any error because the mail + operations system will do it for us because we + created the mail_op with new_with_error_handler */ do_create_folder (source_win, parent_folder, (const gchar *) suggested_name); } else { /* the 'source_win' is either the ModestMainWindow, or the 'Move to folder'-dialog @@ -2726,8 +2803,7 @@ do_create_folder (GtkWindow *parent_window, if (result == GTK_RESPONSE_ACCEPT) { ModestMailOperation *mail_op; - mail_op = modest_mail_operation_new (G_OBJECT(parent_window)); - + mail_op = modest_mail_operation_new (NULL); modest_mail_operation_queue_add (modest_runtime_get_mail_operation_queue (), mail_op); modest_mail_operation_create_folder (mail_op, @@ -2960,6 +3036,7 @@ on_delete_folder_cb (gboolean canceled, if (!MODEST_IS_MAIN_WINDOW(parent_window) || canceled || (err!=NULL)) { g_object_unref (G_OBJECT (info->folder)); g_free (info); + return; } folder_view = modest_main_window_get_child_widget ( @@ -3053,26 +3130,6 @@ modest_ui_actions_on_move_folder_to_trash_folder (GtkAction *action, ModestMainW } -static void -show_error (GtkWidget *parent_widget, const gchar* text) -{ - modest_platform_information_banner(parent_widget, NULL, text); - -#if 0 - GtkDialog *dialog = GTK_DIALOG (hildon_note_new_information (parent_window, text)); */ - /* - GtkDialog *dialog = GTK_DIALOG (gtk_message_dialog_new (parent_window, - (GtkDialogFlags)0, - GTK_MESSAGE_ERROR, - GTK_BUTTONS_OK, - text )); - */ - - gtk_dialog_run (dialog); - gtk_widget_destroy (GTK_WIDGET (dialog)); -#endif -} - void modest_ui_actions_on_password_requested (TnyAccountStore *account_store, const gchar* server_account_name, @@ -3083,6 +3140,7 @@ modest_ui_actions_on_password_requested (TnyAccountStore *account_store, ModestMainWindow *main_window) { g_return_if_fail(server_account_name); + gboolean completed = FALSE; /* Initalize output parameters: */ if (cancel) @@ -3200,49 +3258,58 @@ modest_ui_actions_on_password_requested (TnyAccountStore *account_store, */ gtk_widget_show_all (GTK_WIDGET(GTK_DIALOG(dialog)->vbox)); + + while (!completed) { - if (gtk_dialog_run (GTK_DIALOG(dialog)) == GTK_RESPONSE_ACCEPT) { - if (username) { - *username = g_strdup (gtk_entry_get_text (GTK_ENTRY(entry_username))); - - modest_account_mgr_set_server_account_username ( - modest_runtime_get_account_mgr(), server_account_name, - *username); - - const gboolean username_was_changed = - (strcmp (*username, initial_username) != 0); - if (username_was_changed) { - g_warning ("%s: tinymail does not yet support changing the " - "username in the get_password() callback.\n", __FUNCTION__); + if (gtk_dialog_run (GTK_DIALOG(dialog)) == GTK_RESPONSE_ACCEPT) { + if (username) { + *username = g_strdup (gtk_entry_get_text (GTK_ENTRY(entry_username))); + + /* Note that an empty field becomes the "" string */ + if (*username && strlen (*username) > 0) { + modest_account_mgr_set_server_account_username (modest_runtime_get_account_mgr(), + server_account_name, + *username); + completed = TRUE; + + const gboolean username_was_changed = + (strcmp (*username, initial_username) != 0); + if (username_was_changed) { + g_warning ("%s: tinymail does not yet support changing the " + "username in the get_password() callback.\n", __FUNCTION__); + } + } else { + /* Show error */ + modest_platform_information_banner (GTK_WIDGET (dialog), NULL, + _("mcen_ib_username_pw_incorrect")); + completed = FALSE; + } } - } - if (password) { - *password = g_strdup (gtk_entry_get_text (GTK_ENTRY(entry_password))); + if (password) { + *password = g_strdup (gtk_entry_get_text (GTK_ENTRY(entry_password))); - /* We do not save the password in the configuration, - * because this function is only called for passwords that should - * not be remembered: - modest_server_account_set_password ( + /* We do not save the password in the configuration, + * because this function is only called for passwords that should + * not be remembered: + modest_server_account_set_password ( modest_runtime_get_account_mgr(), server_account_name, *password); - */ + */ + } + if (cancel) + *cancel = FALSE; + } else { + modest_platform_information_banner(GTK_WIDGET (dialog), + NULL, _("mail_ib_login_cancelled")); + completed = TRUE; + if (username) + *username = NULL; + if (password) + *password = NULL; + if (cancel) + *cancel = TRUE; } - - if (cancel) - *cancel = FALSE; - - } else { - show_error(GTK_WIDGET (main_window), _("mail_ib_login_cancelled")); - - if (username) - *username = NULL; - - if (password) - *password = NULL; - - if (cancel) - *cancel = TRUE; } /* This is not in the Maemo UI spec: @@ -3274,9 +3341,11 @@ modest_ui_actions_on_cut (GtkAction *action, GtkTextBuffer *buffer; buffer = gtk_text_view_get_buffer (GTK_TEXT_VIEW (focused_widget)); - gtk_text_buffer_cut_clipboard (buffer, clipboard, TRUE); - gtk_clipboard_set_can_store (clipboard, NULL, 0); - gtk_clipboard_store (clipboard); + if (modest_text_utils_buffer_selection_is_valid (buffer)) { + gtk_text_buffer_cut_clipboard (buffer, clipboard, TRUE); + gtk_clipboard_set_can_store (clipboard, NULL, 0); + gtk_clipboard_store (clipboard); + } } else if (MODEST_IS_HEADER_VIEW (focused_widget)) { TnyList *header_list = modest_header_view_get_selected_headers ( MODEST_HEADER_VIEW (focused_widget)); @@ -3287,8 +3356,10 @@ modest_ui_actions_on_cut (GtkAction *action, if (num_of_unc_msgs) { TnyAccount *account = get_account_from_header_list (header_list); - continue_download = connect_to_get_msg (window, num_of_unc_msgs, account); - g_object_unref (account); + if (account) { + continue_download = connect_to_get_msg (window, num_of_unc_msgs, account); + g_object_unref (account); + } } if (num_of_unc_msgs == 0 || continue_download) { @@ -3333,9 +3404,11 @@ modest_ui_actions_on_copy (GtkAction *action, } else if (GTK_IS_TEXT_VIEW (focused_widget)) { GtkTextBuffer *buffer; buffer = gtk_text_view_get_buffer (GTK_TEXT_VIEW (focused_widget)); - gtk_text_buffer_copy_clipboard (buffer, clipboard); - gtk_clipboard_set_can_store (clipboard, NULL, 0); - gtk_clipboard_store (clipboard); + if (modest_text_utils_buffer_selection_is_valid (buffer)) { + gtk_text_buffer_copy_clipboard (buffer, clipboard); + gtk_clipboard_set_can_store (clipboard, NULL, 0); + gtk_clipboard_store (clipboard); + } } else if (MODEST_IS_HEADER_VIEW (focused_widget)) { TnyList *header_list = modest_header_view_get_selected_headers ( MODEST_HEADER_VIEW (focused_widget)); @@ -3346,8 +3419,10 @@ modest_ui_actions_on_copy (GtkAction *action, if (num_of_unc_msgs) { TnyAccount *account = get_account_from_header_list (header_list); - continue_download = connect_to_get_msg (window, num_of_unc_msgs, account); - g_object_unref (account); + if (account) { + continue_download = connect_to_get_msg (window, num_of_unc_msgs, account); + g_object_unref (account); + } } if (num_of_unc_msgs == 0 || continue_download) { @@ -3966,9 +4041,11 @@ on_move_to_dialog_folder_selection_changed (ModestFolderView* self, GtkWidget *folder_view = NULL; ModestTnyFolderRules rules; + g_return_if_fail (MODEST_IS_FOLDER_VIEW(self)); + if (!selected) return; - + /* Get the OK button */ dialog = gtk_widget_get_ancestor (GTK_WIDGET (self), GTK_TYPE_DIALOG); if (!dialog) @@ -4002,6 +4079,7 @@ on_move_to_dialog_folder_selection_changed (ModestFolderView* self, new_sensitive = (proto != MODEST_PROTOCOL_STORE_POP); } g_object_unref (local_account); + g_object_unref (mmc_account); } /* Check the target folder rules */ @@ -4050,25 +4128,36 @@ on_move_to_dialog_folder_selection_changed (ModestFolderView* self, } g_object_unref (moved_folder); } else { - TnyHeader *header = NULL; TnyFolder *src_folder = NULL; /* Moving a message */ if (MODEST_IS_MSG_VIEW_WINDOW (user_data)) { - header = modest_msg_view_window_get_header (MODEST_MSG_VIEW_WINDOW (user_data)); - src_folder = tny_header_get_folder (header); - g_object_unref (header); + + TnyHeader *header = NULL; + header = modest_msg_view_window_get_header + (MODEST_MSG_VIEW_WINDOW (user_data)); + if (!TNY_IS_HEADER(header)) + g_warning ("%s: could not get source header", __FUNCTION__); + else + src_folder = tny_header_get_folder (header); + + if (header) + g_object_unref (header); } else { src_folder = - TNY_FOLDER (modest_folder_view_get_selected (MODEST_FOLDER_VIEW (folder_view))); + TNY_FOLDER (modest_folder_view_get_selected + (MODEST_FOLDER_VIEW (folder_view))); } - /* Do not allow to move the msg to the same folder */ - /* Do not allow to move the msg to an account */ - if ((gpointer) src_folder == (gpointer) folder_store || - TNY_IS_ACCOUNT (folder_store)) - ok_sensitive = FALSE; - g_object_unref (src_folder); + if (TNY_IS_FOLDER(src_folder)) { + /* Do not allow to move the msg to the same folder */ + /* Do not allow to move the msg to an account */ + if ((gpointer) src_folder == (gpointer) folder_store || + TNY_IS_ACCOUNT (folder_store)) + ok_sensitive = FALSE; + g_object_unref (src_folder); + } else + g_warning ("%s: could not get source folder", __FUNCTION__); } end: @@ -4310,11 +4399,8 @@ move_to_cb (ModestMailOperation *mail_op, if (MODEST_IS_MSG_VIEW_WINDOW (object)) { ModestMsgViewWindow *self = MODEST_MSG_VIEW_WINDOW (object); - if (modest_msg_view_window_last_message_selected (self) && - modest_msg_view_window_first_message_selected (self)) { - modest_ui_actions_on_close_window (NULL, MODEST_WINDOW (self)); - } else if (!modest_msg_view_window_select_next_message (self) && - !modest_msg_view_window_select_previous_message (self)) { + if (!modest_msg_view_window_select_next_message (self) && + !modest_msg_view_window_select_previous_message (self)) { /* No more messages to view, so close this window */ modest_ui_actions_on_close_window (NULL, MODEST_WINDOW(self)); } @@ -4547,7 +4633,7 @@ modest_ui_actions_on_main_window_remove_attachments (GtkAction *action, ModestMailOperation *mail_op = NULL; modest_window_mgr_register_header (modest_runtime_get_window_mgr (), header, NULL); mail_op = modest_mail_operation_new_with_error_handling (G_OBJECT (win), - modest_ui_actions_get_msgs_full_error_handler, + modest_ui_actions_disk_operations_error_handler, NULL, NULL); modest_mail_operation_queue_add (modest_runtime_get_mail_operation_queue (), mail_op); modest_mail_operation_get_msg (mail_op, header, open_msg_for_purge_cb, win); @@ -4560,14 +4646,97 @@ modest_ui_actions_on_main_window_remove_attachments (GtkAction *action, g_object_unref (header_list); } +/* + * Checks if we need a connection to do the transfer and if the user + * wants to connect to complete it + */ +void +modest_ui_actions_xfer_messages_check (GtkWindow *parent_window, + TnyFolderStore *src_folder, + TnyList *headers, + TnyFolder *dst_folder, + gboolean delete_originals, + gboolean *need_connection, + gboolean *do_xfer) +{ + TnyAccount *src_account; + gint uncached_msgs = 0; + + uncached_msgs = header_list_count_uncached_msgs (headers); + + /* We don't need any further check if + * + * 1- the source folder is local OR + * 2- the device is already online + */ + if (!modest_tny_folder_store_is_remote (src_folder) || + tny_device_is_online (modest_runtime_get_device())) { + *need_connection = FALSE; + *do_xfer = TRUE; + return; + } + + /* We must ask for a connection when + * + * - the message(s) is not already cached OR + * - the message(s) is cached but the leave_on_server setting + * is FALSE (because we need to sync the source folder to + * delete the message from the server (for IMAP we could do it + * offline, it'll take place the next time we get a + * connection) + */ + src_account = get_account_from_folder_store (src_folder); + if (uncached_msgs > 0) { + guint num_headers; + const gchar *msg; + + *need_connection = TRUE; + num_headers = tny_list_get_length (headers); + msg = ngettext ("mcen_nc_get_msg", "mcen_nc_get_msgs", num_headers); + + if (modest_platform_run_confirmation_dialog (parent_window, msg) == + GTK_RESPONSE_CANCEL) { + *do_xfer = FALSE; + } else { + *do_xfer = TRUE; + } + } else { + /* The transfer is possible and the user wants to */ + *do_xfer = TRUE; + + if (remote_folder_is_pop (src_folder) && delete_originals) { + const gchar *account_name; + gboolean leave_on_server; + + account_name = modest_tny_account_get_parent_modest_account_name_for_server_account (src_account); + leave_on_server = modest_account_mgr_get_leave_on_server (modest_runtime_get_account_mgr (), + account_name); + + if (leave_on_server == TRUE) { + *need_connection = FALSE; + } else { + *need_connection = TRUE; + } + } else { + *need_connection = FALSE; + } + } + + /* Frees */ + g_object_unref (src_account); +} + + /** * Utility function that transfer messages from both the main window * and the msg view window when using the "Move to" dialog */ static void -xfer_messages_from_move_to_cb (gboolean canceled, GError *err, - GtkWindow *parent_window, - TnyAccount *account, gpointer user_data) +xfer_messages_performer (gboolean canceled, + GError *err, + GtkWindow *parent_window, + TnyAccount *account, + gpointer user_data) { TnyFolderStore *dst_folder = TNY_FOLDER_STORE (user_data); ModestWindow *win = MODEST_WINDOW (parent_window); @@ -4577,6 +4746,8 @@ xfer_messages_from_move_to_cb (gboolean canceled, GError *err, gboolean dst_is_pop = FALSE; if (canceled || err) { + /* Show the proper error message */ + modest_ui_actions_on_account_connection_error (parent_window, account); g_object_unref (dst_folder); return; } @@ -4644,36 +4815,6 @@ xfer_messages_from_move_to_cb (gboolean canceled, GError *err, } typedef struct { - TnyAccount *dst_account; - ModestConnectedPerformer callback; - gpointer data; -} DoubleConnectionInfo; - -static void -src_account_connect_performer (gboolean canceled, - GError *err, - GtkWindow *parent_window, - TnyAccount *src_account, - gpointer user_data) -{ - DoubleConnectionInfo *info = (DoubleConnectionInfo *) user_data; - - if (canceled || err) { - /* If there was any error call the user callback */ - info->callback (canceled, err, parent_window, src_account, info->data); - } else { - /* Connect the destination account */ - modest_platform_connect_if_remote_and_perform (parent_window, TRUE, - TNY_FOLDER_STORE (info->dst_account), - info->callback, info->data); - } - - /* Free the info object */ - g_object_unref (info->dst_account); - g_slice_free (DoubleConnectionInfo, info); -} - -typedef struct { TnyFolder *src_folder; TnyFolderStore *dst_folder; gboolean delete_original; @@ -4746,6 +4887,15 @@ on_move_folder_cb (gboolean canceled, GError *err, GtkWindow *parent_window, g_free (user_data); } +static TnyAccount * +get_account_from_folder_store (TnyFolderStore *folder_store) +{ + if (TNY_IS_ACCOUNT (folder_store)) + return g_object_ref (folder_store); + else + return tny_folder_get_account (TNY_FOLDER (folder_store)); +} + /* * UI handler for the "Move to" action when invoked from the * ModestMainWindow @@ -4757,8 +4907,7 @@ modest_ui_actions_on_main_window_move_to (GtkAction *action, ModestMainWindow *win) { ModestHeaderView *header_view = NULL; - TnyFolderStore *src_folder; - gboolean online = (tny_device_is_online (modest_runtime_get_device())); + TnyFolderStore *src_folder = NULL; g_return_if_fail (MODEST_IS_MAIN_WINDOW (win)); @@ -4774,79 +4923,84 @@ modest_ui_actions_on_main_window_move_to (GtkAction *action, /* Allow only to transfer folders to the local root folder */ if (TNY_IS_ACCOUNT (dst_folder) && - !MODEST_IS_TNY_LOCAL_FOLDERS_ACCOUNT (dst_folder)) { + !MODEST_IS_TNY_LOCAL_FOLDERS_ACCOUNT (dst_folder) && + !modest_tny_account_is_memory_card_account (TNY_ACCOUNT (dst_folder))) { do_xfer = FALSE; } else if (!TNY_IS_FOLDER (src_folder)) { g_warning ("%s: src_folder is not a TnyFolder.\n", __FUNCTION__); do_xfer = FALSE; - } /* else if (!online && modest_tny_folder_store_is_remote(src_folder)) { - guint num_headers = tny_folder_get_all_count(TNY_FOLDER (src_folder)); - TnyAccount *account = tny_folder_get_account (TNY_FOLDER (src_folder)); - if (!connect_to_get_msg(MODEST_WINDOW (win), num_headers, account)) - do_xfer = FALSE; - g_object_unref (account); - }*/ - - if (do_xfer) { + } + + if (do_xfer) { MoveFolderInfo *info = g_new0 (MoveFolderInfo, 1); - info->src_folder = TNY_FOLDER (src_folder); - info->dst_folder = dst_folder; + DoubleConnectionInfo *connect_info = g_slice_new (DoubleConnectionInfo); + + info->src_folder = g_object_ref (src_folder); + info->dst_folder = g_object_ref (dst_folder); info->delete_original = TRUE; info->folder_view = folder_view; - g_object_ref (G_OBJECT (info->src_folder)); - g_object_ref (G_OBJECT (info->dst_folder)); - modest_platform_connect_if_remote_and_perform(GTK_WINDOW (win), TRUE, - TNY_FOLDER_STORE (dst_folder), on_move_folder_cb, info); + + connect_info->callback = on_move_folder_cb; + connect_info->dst_account = get_account_from_folder_store (TNY_FOLDER_STORE (dst_folder)); + connect_info->data = info; + + modest_platform_double_connect_and_perform(GTK_WINDOW (win), TRUE, + TNY_FOLDER_STORE (src_folder), + connect_info); } } else if (gtk_widget_is_focus (GTK_WIDGET(header_view))) { - gboolean do_xfer = TRUE; + TnyList *headers; - /* Show an error when trying to move msgs to an account */ - if (!TNY_IS_FOLDER (dst_folder)) { - modest_platform_information_banner (GTK_WIDGET (win), - NULL, - _CS("ckdg_ib_unable_to_move_to_current_location")); - goto free; - } + headers = modest_header_view_get_selected_headers(header_view); - /* Ask for confirmation if the source folder is remote and we're not connected */ - if (!online && modest_tny_folder_store_is_remote(src_folder)) { - TnyList *headers = modest_header_view_get_selected_headers(header_view); - if (!msgs_already_deleted_from_server(headers, src_folder)) { - guint num_headers = tny_list_get_length(headers); - TnyAccount *account = get_account_from_header_list (headers); - GtkResponseType response; + /* Transfer the messages */ + transfer_messages_helper (GTK_WINDOW (win), TNY_FOLDER (src_folder), + headers, TNY_FOLDER (dst_folder)); - response = modest_platform_run_confirmation_dialog (GTK_WINDOW (win), - ngettext("mcen_nc_get_msg", - "mcen_nc_get_msgs", - num_headers)); - if (response == GTK_RESPONSE_CANCEL) - do_xfer = FALSE; - - g_object_unref (account); - } - g_object_unref(headers); - } - if (do_xfer) /* Transfer messages */ { - DoubleConnectionInfo *info = g_slice_new (DoubleConnectionInfo); - info->callback = xfer_messages_from_move_to_cb; - info->dst_account = tny_folder_get_account (TNY_FOLDER (dst_folder)); - info->data = g_object_ref (dst_folder); - - modest_platform_connect_if_remote_and_perform(GTK_WINDOW (win), TRUE, - TNY_FOLDER_STORE (src_folder), - src_account_connect_performer, - info); - } + g_object_unref (headers); } - free: - if (src_folder) - g_object_unref (src_folder); + /* Frees */ + g_object_unref (src_folder); } +static void +transfer_messages_helper (GtkWindow *win, + TnyFolder *src_folder, + TnyList *headers, + TnyFolder *dst_folder) +{ + gboolean need_connection = TRUE; + gboolean do_xfer = TRUE; + + modest_ui_actions_xfer_messages_check (win, TNY_FOLDER_STORE (src_folder), + headers, TNY_FOLDER (dst_folder), + TRUE, &need_connection, + &do_xfer); + + /* If we don't want to transfer just return */ + if (!do_xfer) + return; + + if (need_connection) { + DoubleConnectionInfo *connect_info = g_slice_new (DoubleConnectionInfo); + connect_info->callback = xfer_messages_performer; + connect_info->dst_account = tny_folder_get_account (TNY_FOLDER (dst_folder)); + connect_info->data = g_object_ref (dst_folder); + + modest_platform_double_connect_and_perform(GTK_WINDOW (win), TRUE, + TNY_FOLDER_STORE (src_folder), + connect_info); + } else { + TnyAccount *src_account = get_account_from_folder_store (TNY_FOLDER_STORE (src_folder)); + xfer_messages_performer (FALSE, NULL, GTK_WINDOW (win), + src_account, + g_object_ref (dst_folder)); + g_object_unref (src_account); + } +} + /* * UI handler for the "Move to" action when invoked from the * ModestMsgViewWindow @@ -4856,36 +5010,25 @@ modest_ui_actions_on_msg_view_window_move_to (GtkAction *action, TnyFolderStore *dst_folder, ModestMsgViewWindow *win) { + TnyList *headers = NULL; TnyHeader *header = NULL; TnyFolder *src_folder = NULL; - TnyAccount *account = NULL; - gboolean do_xfer = FALSE; + + g_return_if_fail (TNY_IS_FOLDER (dst_folder)); /* Create header list */ - header = modest_msg_view_window_get_header (MODEST_MSG_VIEW_WINDOW (win)); + header = modest_msg_view_window_get_header (MODEST_MSG_VIEW_WINDOW (win)); src_folder = TNY_FOLDER (tny_header_get_folder(header)); - g_object_unref (header); + headers = tny_simple_list_new (); + tny_list_append (headers, G_OBJECT (header)); - account = tny_folder_get_account (src_folder); - if (!modest_tny_folder_store_is_remote(TNY_FOLDER_STORE(src_folder))) { - /* Transfer if the source folder is local */ - do_xfer = TRUE; - } else if (remote_folder_is_pop(TNY_FOLDER_STORE(src_folder))) { - /* Transfer if the source folder is POP (as it means - * that the message is already downloaded) */ - do_xfer = TRUE; - } else if (connect_to_get_msg(MODEST_WINDOW(win), 1, account)) { - /* Transfer after asking confirmation */ - do_xfer = TRUE; - } - - if (do_xfer) { - g_object_ref (dst_folder); - modest_platform_connect_if_remote_and_perform(GTK_WINDOW (win), TRUE, - TNY_FOLDER_STORE (dst_folder), xfer_messages_from_move_to_cb, dst_folder); - } - g_object_unref (account); - g_object_unref (src_folder); + /* Transfer the messages */ + transfer_messages_helper (GTK_WINDOW (win), src_folder, headers, + TNY_FOLDER (dst_folder)); + + /* Frees */ + g_object_unref (header); + g_object_unref (headers); } void @@ -5075,7 +5218,7 @@ retrieve_msg_contents_performer (gboolean canceled, /* Create mail operation */ mail_op = modest_mail_operation_new_with_error_handling ((GObject *) parent_window, - modest_ui_actions_get_msgs_full_error_handler, + modest_ui_actions_disk_operations_error_handler, NULL, NULL); modest_mail_operation_queue_add (modest_runtime_get_mail_operation_queue (), mail_op); modest_mail_operation_get_msgs_full (mail_op, headers, NULL, NULL, NULL); @@ -5347,6 +5490,9 @@ modest_ui_actions_on_send_queue_error_happened (TnySendQueue *self, case TNY_SERVICE_ERROR_SEND: message = g_strdup (_("emev_ib_ui_smtp_send_error")); break; + case TNY_SERVICE_ERROR_UNAVAILABLE: + message = g_strdup_printf (_("emev_ib_ui_smtp_server_invalid"), server_name); + break; default: g_warning ("%s: unexpected ERROR %d", __FUNCTION__, err->code);