X-Git-Url: http://git.maemo.org/git/?p=modest;a=blobdiff_plain;f=src%2Fmodest-ui-actions.c;h=aec999d66ee4fb94be9609fe5454331fdf6fafdb;hp=f454815e291fef4f80da81f7f5938e1b81f95bed;hb=40e92875620a12ce1d34126c9a9c6bce97b21e6c;hpb=58cbe9db1e63b6f9bb18c9bac457e48cdaaff8a0 diff --git a/src/modest-ui-actions.c b/src/modest-ui-actions.c index f454815..aec999d 100644 --- a/src/modest-ui-actions.c +++ b/src/modest-ui-actions.c @@ -26,19 +26,20 @@ * NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ - + #ifdef HAVE_CONFIG_H #include #endif /*HAVE_CONFIG_H*/ #include +#include #include #include #include #include #include #include - +#include "modest-error.h" #include "modest-ui-actions.h" #include "modest-tny-platform-factory.h" @@ -69,6 +70,7 @@ #include #include #include +#include typedef struct _GetMsgAsyncHelper { ModestWindow *window; @@ -89,6 +91,7 @@ typedef struct _ReplyForwardHelper { guint reply_forward_type; ReplyForwardAction action; gchar *account_name; + GtkWidget *parent_window; } ReplyForwardHelper; /* @@ -216,7 +219,7 @@ headers_action_delete (TnyHeader *header, { ModestMailOperation *mail_op = NULL; - mail_op = modest_mail_operation_new (MODEST_MAIL_OPERATION_ID_DELETE, G_OBJECT(win)); + mail_op = modest_mail_operation_new (MODEST_MAIL_OPERATION_TYPE_DELETE, G_OBJECT(win)); modest_mail_operation_queue_add (modest_runtime_get_mail_operation_queue (), mail_op); @@ -234,12 +237,41 @@ modest_ui_actions_on_delete (GtkAction *action, ModestWindow *win) gchar *message = NULL; gchar *desc = NULL; gint response; + gboolean found; + ModestWindowMgr *mgr; g_return_if_fail (MODEST_IS_WINDOW(win)); header_list = get_selected_headers (win); if (!header_list) return; + /* Check if any of the headers is already opened */ + iter = tny_list_create_iterator (header_list); + found = FALSE; + mgr = modest_runtime_get_window_mgr (); + while (!tny_iterator_is_done (iter) && !found) { + header = TNY_HEADER (tny_iterator_get_current (iter)); + if (modest_window_mgr_find_window_by_header (mgr, header)) + found = TRUE; + g_object_unref (header); + tny_iterator_next (iter); + } + g_object_unref (iter); + + if (found) { + gchar *num, *msg; + + num = g_strdup_printf ("%d", tny_list_get_length (header_list)); + msg = g_strdup_printf (_("mcen_nc_unable_to_delete_n_messages"), num); + + modest_platform_run_information_dialog (GTK_WINDOW (win), (const gchar *) msg); + + g_free (msg); + g_free (num); + g_object_unref (header_list); + return; + } + /* Select message */ if (tny_list_get_length(header_list) > 1) message = g_strdup(_("emev_nc_delete_messages")); @@ -248,6 +280,8 @@ modest_ui_actions_on_delete (GtkAction *action, ModestWindow *win) header = TNY_HEADER (tny_iterator_get_current (iter)); desc = g_strdup_printf ("%s", tny_header_get_subject (header)); message = g_strdup_printf(_("emev_nc_delete_message"), desc); + g_object_unref (header); + g_object_unref (iter); } /* Confirmation dialog */ @@ -274,7 +308,6 @@ modest_ui_actions_on_delete (GtkAction *action, ModestWindow *win) g_free(message); g_free(desc); g_object_unref (header_list); - g_object_unref (iter); } @@ -312,8 +345,14 @@ modest_ui_actions_on_add_to_contacts (GtkAction *action, ModestWindow *win) clipboard = gtk_clipboard_get (GDK_SELECTION_PRIMARY); selection = gtk_clipboard_wait_for_text (clipboard); - modest_address_book_add_address (selection); - g_free (selection); + /* Question: why is the clipboard being used here? + * It doesn't really make a lot of sense. */ + + if (selection) + { + modest_address_book_add_address (selection); + g_free (selection); + } } void @@ -390,11 +429,22 @@ modest_ui_actions_on_smtp_servers (GtkAction *action, ModestWindow *win) #ifdef MODEST_PLATFORM_MAEMO /* Defined in config.h */ /* Create the window if necessary: */ + const gchar *active_account_name = modest_window_get_active_account (win); + + /* TODO: Dim the menu item (not in the UI spec)? or show a warning, + * or show the default account? + * If we show the default account then the account name should be shown in + * the window when we show it. */ + if (!active_account_name) { + g_warning ("%s: No account is active.", __FUNCTION__); + return; + } + GtkWidget *specific_window = GTK_WIDGET (modest_connection_specific_smtp_window_new ()); modest_connection_specific_smtp_window_fill_with_connections ( MODEST_CONNECTION_SPECIFIC_SMTP_WINDOW (specific_window), modest_runtime_get_account_mgr(), - modest_window_get_active_account (win)); + active_account_name); /* Show the window: */ gtk_window_set_transient_for (GTK_WINDOW (specific_window), GTK_WINDOW (win)); @@ -471,6 +521,7 @@ modest_ui_actions_on_new_msg (GtkAction *action, ModestWindow *win) /* } */ /* Create and register edit window */ + /* This is destroyed by TOOD. */ msg_win = modest_msg_edit_window_new (msg, account_name); mgr = modest_runtime_get_window_mgr (); modest_window_mgr_register_window (mgr, msg_win); @@ -520,7 +571,7 @@ open_msg_cb (ModestMailOperation *mail_op, if (!account) account = modest_account_mgr_get_default_account (modest_runtime_get_account_mgr()); - /* Get folder type */ + /* Gets folder type (OUTBOX headers will be opened in edit window */ if (modest_tny_folder_is_local_folder (folder)) folder_type = modest_tny_folder_get_local_folder_type (folder); @@ -529,6 +580,8 @@ open_msg_cb (ModestMailOperation *mail_op, if (folder_type == TNY_FOLDER_TYPE_DRAFTS) { win = modest_msg_edit_window_new (msg, account); } else { + gchar *uid = modest_tny_folder_get_header_unique_id (header); + if (MODEST_IS_MAIN_WINDOW (parent_win)) { GtkWidget *header_view; GtkTreeSelection *sel; @@ -549,16 +602,18 @@ open_msg_cb (ModestMailOperation *mail_op, g_list_free (sel_list); win = modest_msg_view_window_new_with_header_model (msg, - account, + account, + (const gchar*) uid, model, row_reference); gtk_tree_row_reference_free (row_reference); } else { - win = modest_msg_view_window_new (msg, account); + win = modest_msg_view_window_new (msg, account, (const gchar*) uid); } } else { - win = modest_msg_view_window_new (msg, account); + win = modest_msg_view_window_new (msg, account, (const gchar*) uid); } + g_free (uid); } /* Register and show new window */ @@ -577,6 +632,25 @@ open_msg_cb (ModestMailOperation *mail_op, } /* + * This function is the error handler of the + * modest_mail_operation_get_msgs_full operation + */ +static void +modest_ui_actions_get_msgs_full_error_handler (ModestMailOperation *mail_op, + gpointer user_data) +{ + const GError *error; + + error = modest_mail_operation_get_error (mail_op); + if (error->code == MODEST_MAIL_OPERATION_ERROR_MESSAGE_SIZE_LIMIT) { + GObject *win = modest_mail_operation_get_source (mail_op); + + modest_platform_run_information_dialog ((win) ? GTK_WINDOW (win) : NULL, + error->message); + } +} + +/* * This function is used by both modest_ui_actions_on_open and * modest_ui_actions_on_header_activated. This way we always do the * same when trying to open messages. @@ -598,16 +672,23 @@ _modest_ui_actions_open (TnyList *headers, ModestWindow *win) TnyHeader *header; header = TNY_HEADER (tny_iterator_get_current (iter)); - window = modest_window_mgr_find_window_by_msguid (mgr, tny_header_get_uid (header)); - if (window) + window = modest_window_mgr_find_window_by_header (mgr, header); + if (window) { + /* Do not open again the message and present + the window to the user */ tny_list_remove (headers, G_OBJECT (header)); + gtk_window_present (GTK_WINDOW (window)); + } g_object_unref (header); tny_iterator_next (iter); } /* Open each message */ - mail_op = modest_mail_operation_new (MODEST_MAIL_OPERATION_ID_RECEIVE, G_OBJECT (win)); + mail_op = modest_mail_operation_new_with_error_handling (MODEST_MAIL_OPERATION_TYPE_RECEIVE, + G_OBJECT (win), + modest_ui_actions_get_msgs_full_error_handler, + NULL); modest_mail_operation_queue_add (modest_runtime_get_mail_operation_queue (), mail_op); modest_mail_operation_get_msgs_full (mail_op, headers, @@ -657,8 +738,6 @@ reply_forward_cb (ModestMailOperation *mail_op, ModestWindow *msg_win; ModestEditType edit_type; gchar *from; - GError *err = NULL; - TnyFolder *folder = NULL; TnyAccount *account = NULL; ModestWindowMgr *mgr; gchar *signature = NULL; @@ -715,33 +794,24 @@ reply_forward_cb (ModestMailOperation *mail_op, goto cleanup; } - folder = modest_tny_account_get_special_folder (account, TNY_FOLDER_TYPE_DRAFTS); - if (!folder) { - g_printerr ("modest: failed to find Drafts folder\n"); - goto cleanup; - } - - tny_folder_add_msg (folder, msg, &err); - if (err) { - g_printerr ("modest: error adding msg to Drafts folder: %s", - err->message); - g_error_free (err); - goto cleanup; - } - - /* Create and register the windows */ + /* Create and register the windows */ msg_win = modest_msg_edit_window_new (new_msg, rf_helper->account_name); mgr = modest_runtime_get_window_mgr (); modest_window_mgr_register_window (mgr, msg_win); + if (rf_helper->parent_window != NULL) { + gdouble parent_zoom; + + parent_zoom = modest_window_get_zoom (MODEST_WINDOW (rf_helper->parent_window)); + modest_window_set_zoom (msg_win, parent_zoom); + } + /* Show edit window */ gtk_widget_show_all (GTK_WIDGET (msg_win)); cleanup: if (new_msg) g_object_unref (G_OBJECT (new_msg)); - if (folder) - g_object_unref (G_OBJECT (folder)); if (account) g_object_unref (G_OBJECT (account)); g_object_unref (msg); @@ -749,6 +819,52 @@ cleanup: } /* + * Checks a list of headers. If any of them are not currently + * downloaded (CACHED) then it asks the user for permission to + * download them. + * + * Returns FALSE if the user does not want to download the + * messages. Returns TRUE if the user allowed the download or if all + * of them are currently downloaded + */ +static gboolean +download_uncached_messages (TnyList *header_list, GtkWindow *win) +{ + TnyIterator *iter; + gboolean found, retval; + + iter = tny_list_create_iterator (header_list); + found = FALSE; + while (!tny_iterator_is_done (iter) && !found) { + TnyHeader *header; + TnyHeaderFlags flags; + + header = TNY_HEADER (tny_iterator_get_current (iter)); + flags = tny_header_get_flags (header); + /* TODO: is this the right flag?, it seems that some + headers that have been previously downloaded do not + come with it */ + found = !(flags & TNY_HEADER_FLAG_CACHED); + g_object_unref (header); + tny_iterator_next (iter); + } + g_object_unref (iter); + + /* Ask for user permission to download the messages */ + retval = TRUE; + if (found) { + GtkResponseType response; + response = + modest_platform_run_confirmation_dialog (GTK_WINDOW (win), + _("mcen_nc_get_multi_msg_txt")); + if (response == GTK_RESPONSE_CANCEL) + retval = FALSE; + } + return retval; +} + + +/* * Common code for the reply and forward actions */ static void @@ -758,16 +874,25 @@ reply_forward (ReplyForwardAction action, ModestWindow *win) TnyList *header_list = NULL; ReplyForwardHelper *rf_helper = NULL; guint reply_forward_type; + gboolean continue_download; g_return_if_fail (MODEST_IS_WINDOW(win)); header_list = get_selected_headers (win); if (!header_list) return; + + /* Check that the messages have been previously downloaded */ + continue_download = download_uncached_messages (header_list, GTK_WINDOW (win)); + if (!continue_download) { + g_object_unref (header_list); + return; + } - reply_forward_type = modest_conf_get_int (modest_runtime_get_conf (), - (action == ACTION_FORWARD) ? MODEST_CONF_FORWARD_TYPE : MODEST_CONF_REPLY_TYPE, - NULL); + reply_forward_type = + modest_conf_get_int (modest_runtime_get_conf (), + (action == ACTION_FORWARD) ? MODEST_CONF_FORWARD_TYPE : MODEST_CONF_REPLY_TYPE, + NULL); /* We assume that we can only select messages of the same folder and that we reply all of them from the same account. In fact the interface currently only @@ -778,6 +903,8 @@ reply_forward (ReplyForwardAction action, ModestWindow *win) rf_helper->reply_forward_type = reply_forward_type; rf_helper->action = action; rf_helper->account_name = g_strdup (modest_window_get_active_account (win)); + if ((win != NULL) && (MODEST_IS_WINDOW (win))) + rf_helper->parent_window = GTK_WIDGET (win); if (!rf_helper->account_name) rf_helper->account_name = modest_account_mgr_get_default_account (modest_runtime_get_account_mgr()); @@ -800,7 +927,10 @@ reply_forward (ReplyForwardAction action, ModestWindow *win) reply_forward_cb (NULL, header, msg, rf_helper); } else { /* Retrieve messages */ - mail_op = modest_mail_operation_new (MODEST_MAIL_OPERATION_ID_RECEIVE, G_OBJECT(win)); + mail_op = modest_mail_operation_new_with_error_handling (MODEST_MAIL_OPERATION_TYPE_RECEIVE, + G_OBJECT(win), + modest_ui_actions_get_msgs_full_error_handler, + NULL); modest_mail_operation_queue_add (modest_runtime_get_mail_operation_queue (), mail_op); modest_mail_operation_get_msgs_full (mail_op, header_list, @@ -899,41 +1029,20 @@ modest_ui_actions_on_sort (GtkAction *action, } } -/** Check that an appropriate connection is open. - */ -gboolean check_for_connection (const gchar *account_name) -{ - TnyDevice *device = modest_runtime_get_device (); - -/* - g_assert (TNY_IS_MAEMO_CONIC_DEVICE (device)); - - TnyMaemoConicDevice *maemo_device = TNY_MAEMO_CONIC_DEVICE (device); -*/ - - if (tny_device_is_online (device)) - return TRUE; - else { - modest_platform_connect_and_wait (NULL); - - /* TODO: Wait until a result. */ - return TRUE; - } -} - /* * This function performs the send & receive required actions. The - * window it's used to create the mail operation. Tipically it should - * be allways the main window, but we pass it as argument in order to + * window is used to create the mail operation. Typically it should + * always be the main window, but we pass it as argument in order to * be more flexible. */ void modest_ui_actions_do_send_receive (const gchar *account_name, ModestWindow *win) { gchar *acc_name = NULL; + ModestMailOperation *mail_op; - /* If no account name was provided get the current account, if - there is none either then pick the default one */ + /* If no account name was provided then get the current account, and if + there is no current account then pick the default one: */ if (!account_name) { acc_name = g_strdup (modest_window_get_active_account(win)); if (!acc_name) @@ -947,31 +1056,13 @@ modest_ui_actions_do_send_receive (const gchar *account_name, ModestWindow *win) } /* Send & receive. */ - - /* Do not continue if no suitable connection - is open */ - if (!check_for_connection (acc_name)) { - g_free (acc_name); - return; - } - - /* TODO: Do not continue if an operation is already in progress: - * Maybe there are some operations that tinymail allows to - * happen simulatenously. - * TODO: Maybe a simple global gboolean is_updating is enough? - * murrayc. - */ - - /* As per the UI spec, - * for POP accounts, we should receive, - * for IMAP we should synchronize everything, including receiving, - * for SMTP we should send, - * first receiving, then sending: - */ - /* Create the mail operation */ /* TODO: The spec wants us to first do any pending deletions, before receiving. */ - ModestMailOperation *mail_op; - mail_op = modest_mail_operation_new (MODEST_MAIL_OPERATION_ID_RECEIVE, G_OBJECT(win)); + /* Receive and then send. The operation is tagged initially as + a receive operation because the account update performs a + receive and then a send. The operation changes its type + internally, so the progress objects will receive the proper + progress information */ + mail_op = modest_mail_operation_new (MODEST_MAIL_OPERATION_TYPE_RECEIVE, G_OBJECT(win)); modest_mail_operation_queue_add (modest_runtime_get_mail_operation_queue (), mail_op); modest_mail_operation_update_account (mail_op, acc_name); g_object_unref (G_OBJECT (mail_op)); @@ -1075,6 +1166,9 @@ modest_ui_actions_on_header_selected (ModestHeaderView *header_view, else gtk_window_set_title (GTK_WINDOW (main_window), _("mail_va_no_subject")); } + + /* Update toolbar dimming state */ + modest_ui_actions_check_toolbar_dimming_rules (MODEST_WINDOW (main_window)); } void @@ -1101,18 +1195,17 @@ static void set_active_account_from_tny_account (TnyAccount *account, ModestWindow *window) { - TnyAccount *modest_server_account; - const gchar *server_acc_name; - gchar *modest_acc_name; - - server_acc_name = tny_account_get_id (account); + const gchar *server_acc_name = tny_account_get_id (account); + /* We need the TnyAccount provided by the account store because that is the one that knows the name of the Modest account */ - modest_server_account = + TnyAccount *modest_server_account = modest_server_account = modest_tny_account_store_get_tny_account_by_id (modest_runtime_get_account_store (), server_acc_name); - modest_acc_name = (gchar *) g_object_get_data (G_OBJECT (modest_server_account), "modest_account"); + + const gchar *modest_acc_name = + modest_tny_account_get_parent_modest_account_name_for_server_account (modest_server_account); modest_window_set_active_account (window, modest_acc_name); g_object_unref (modest_server_account); } @@ -1125,7 +1218,6 @@ modest_ui_actions_on_folder_selection_changed (ModestFolderView *folder_view, { ModestConf *conf; GtkWidget *header_view; - TnyAccount *account; g_return_if_fail (MODEST_IS_MAIN_WINDOW(main_window)); @@ -1143,10 +1235,13 @@ modest_ui_actions_on_folder_selection_changed (ModestFolderView *folder_view, modest_main_window_set_contents_style (main_window, MODEST_MAIN_WINDOW_CONTENTS_STYLE_DETAILS); } else { if (TNY_IS_FOLDER (folder_store) && selected) { - /* Update the active account */ - account = tny_folder_get_account (TNY_FOLDER (folder_store)); - set_active_account_from_tny_account (account, MODEST_WINDOW (main_window)); - g_object_unref (account); + + if (!TNY_IS_MERGE_FOLDER (folder_store)) { /* TnyMergeFolder can have no get_account() implementation. */ + /* Update the active account */ + TnyAccount *account = tny_folder_get_account (TNY_FOLDER (folder_store)); + set_active_account_from_tny_account (account, MODEST_WINDOW (main_window)); + g_object_unref (account); + } /* Set folder on header view */ modest_main_window_set_contents_style (main_window, @@ -1163,6 +1258,9 @@ modest_ui_actions_on_folder_selection_changed (ModestFolderView *folder_view, modest_header_view_set_folder (MODEST_HEADER_VIEW(header_view), NULL); } } + + /* Update toolbar dimming state */ + modest_ui_actions_check_toolbar_dimming_rules (MODEST_WINDOW (main_window)); } void @@ -1273,6 +1371,11 @@ modest_ui_actions_on_save_to_drafts (GtkWidget *widget, ModestMsgEditWindow *edi modest_msg_edit_window_free_msg_data (edit_window, data); return; } + + if (!strcmp (account_name, MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID)) { + account_name = g_strdup (data->account_name); + } + transport_account = TNY_TRANSPORT_ACCOUNT(modest_tny_account_store_get_tny_account_by_account (modest_runtime_get_account_store(), @@ -1287,11 +1390,12 @@ modest_ui_actions_on_save_to_drafts (GtkWidget *widget, ModestMsgEditWindow *edi from = modest_account_mgr_get_from_string (account_mgr, account_name); /* Create the mail operation */ - mail_operation = modest_mail_operation_new (MODEST_MAIL_OPERATION_ID_INFO, G_OBJECT(edit_window)); + mail_operation = modest_mail_operation_new (MODEST_MAIL_OPERATION_TYPE_INFO, G_OBJECT(edit_window)); modest_mail_operation_queue_add (modest_runtime_get_mail_operation_queue (), mail_operation); modest_mail_operation_save_to_drafts (mail_operation, transport_account, + data->draft_msg, from, data->to, data->cc, @@ -1312,35 +1416,36 @@ modest_ui_actions_on_save_to_drafts (GtkWidget *widget, ModestMsgEditWindow *edi /* Save settings and close the window */ gtk_widget_destroy (GTK_WIDGET (edit_window)); } + +/* For instance, when clicking the Send toolbar button when editing a message: */ void modest_ui_actions_on_send (GtkWidget *widget, ModestMsgEditWindow *edit_window) { - TnyTransportAccount *transport_account; - ModestMailOperation *mail_operation; - MsgData *data; - gchar *account_name, *from; - ModestAccountMgr *account_mgr; - g_return_if_fail (MODEST_IS_MSG_EDIT_WINDOW(edit_window)); if (!modest_msg_edit_window_check_names (edit_window)) return; - data = modest_msg_edit_window_get_msg_data (edit_window); - /* FIXME: Code added just for testing. The final version will use the send queue provided by tinymail and some classifier */ - account_mgr = modest_runtime_get_account_mgr(); - account_name = g_strdup(modest_window_get_active_account (MODEST_WINDOW(edit_window))); + ModestAccountMgr *account_mgr = modest_runtime_get_account_mgr(); + gchar *account_name = g_strdup(modest_window_get_active_account (MODEST_WINDOW(edit_window))); if (!account_name) account_name = modest_account_mgr_get_default_account (account_mgr); + if (!account_name) { g_printerr ("modest: no account found\n"); - modest_msg_edit_window_free_msg_data (edit_window, data); return; } - transport_account = + MsgData *data = modest_msg_edit_window_get_msg_data (edit_window); + + if (!strcmp (account_name, MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID)) { + account_name = g_strdup (data->account_name); + } + + /* Get the currently-active transport account for this modest account: */ + TnyTransportAccount *transport_account = TNY_TRANSPORT_ACCOUNT(modest_tny_account_store_get_transport_account_for_open_connection (modest_runtime_get_account_store(), account_name)); @@ -1350,14 +1455,43 @@ modest_ui_actions_on_send (GtkWidget *widget, ModestMsgEditWindow *edit_window) modest_msg_edit_window_free_msg_data (edit_window, data); return; } - from = modest_account_mgr_get_from_string (account_mgr, account_name); + + gchar *from = modest_account_mgr_get_from_string (account_mgr, account_name); - /* Create the mail operation */ - mail_operation = modest_mail_operation_new (MODEST_MAIL_OPERATION_ID_SEND, G_OBJECT(edit_window)); + /* mail content checks and dialogs */ + if (data->subject == NULL || data->subject[0] == '\0') { + GtkResponseType response; + response = modest_platform_run_confirmation_dialog (GTK_WINDOW (edit_window), + _("mcen_nc_subject_is_empty_send")); + if (response == GTK_RESPONSE_CANCEL) { + g_free (account_name); + return; + } + } + + if (data->plain_body == NULL || data->plain_body[0] == '\0') { + GtkResponseType response; + gchar *note_message; + gchar *note_subject = data->subject; + if (note_subject == NULL || note_subject[0] == '\0') + note_subject = _("mail_va_no_subject"); + note_message = g_strdup_printf (_("emev_ni_ui_smtp_message_null"), note_subject); + response = modest_platform_run_confirmation_dialog (GTK_WINDOW (edit_window), + note_message); + g_free (note_message); + if (response == GTK_RESPONSE_CANCEL) { + g_free (account_name); + return; + } + } + + /* Create the mail operation */ + ModestMailOperation *mail_operation = modest_mail_operation_new (MODEST_MAIL_OPERATION_TYPE_SEND, G_OBJECT(edit_window)); modest_mail_operation_queue_add (modest_runtime_get_mail_operation_queue (), mail_operation); modest_mail_operation_send_new_mail (mail_operation, transport_account, + data->draft_msg, from, data->to, data->cc, @@ -1367,7 +1501,8 @@ modest_ui_actions_on_send (GtkWidget *widget, ModestMsgEditWindow *edit_window) data->html_body, data->attachments, data->priority_flags); - /* Frees */ + + /* Free data: */ g_free (from); g_free (account_name); g_object_unref (G_OBJECT (transport_account)); @@ -1375,7 +1510,7 @@ modest_ui_actions_on_send (GtkWidget *widget, ModestMsgEditWindow *edit_window) modest_msg_edit_window_free_msg_data (edit_window, data); - /* Save settings and close the window */ + /* Save settings and close the window: */ gtk_widget_destroy (GTK_WIDGET (edit_window)); } @@ -1594,26 +1729,20 @@ modest_ui_actions_on_new_folder (GtkAction *action, ModestMainWindow *main_windo if (result == GTK_RESPONSE_REJECT) { finished = TRUE; } else { - ModestMailOperation *mail_op = modest_mail_operation_new (MODEST_MAIL_OPERATION_ID_INFO, G_OBJECT(main_window)); + ModestMailOperation *mail_op; TnyFolder *new_folder = NULL; + mail_op = modest_mail_operation_new (MODEST_MAIL_OPERATION_TYPE_INFO, + G_OBJECT(main_window)); modest_mail_operation_queue_add (modest_runtime_get_mail_operation_queue (), mail_op); - new_folder = modest_mail_operation_create_folder (mail_op, parent_folder, (const gchar *) folder_name); if (new_folder) { g_object_unref (new_folder); finished = TRUE; - } -/* else { */ -/* /\* TODO: check error and follow proper actions *\/ */ -/* /\* suggested_name = X; *\/ */ -/* /\* Show error to the user *\/ */ -/* modest_platform_run_information_dialog (GTK_WINDOW (main_window), */ -/* _("mail_in_ui_folder_create_error")); */ -/* } */ + } g_object_unref (mail_op); } g_free (folder_name); @@ -1655,7 +1784,7 @@ modest_ui_actions_on_rename_folder (GtkAction *action, if (folder_name != NULL && strlen (folder_name) > 0) { ModestMailOperation *mail_op; - mail_op = modest_mail_operation_new (MODEST_MAIL_OPERATION_ID_INFO, G_OBJECT(main_window)); + mail_op = modest_mail_operation_new (MODEST_MAIL_OPERATION_TYPE_INFO, G_OBJECT(main_window)); modest_mail_operation_queue_add (modest_runtime_get_mail_operation_queue (), mail_op); @@ -1673,6 +1802,16 @@ modest_ui_actions_on_rename_folder (GtkAction *action, } static void +modest_ui_actions_delete_folder_error_handler (ModestMailOperation *mail_op, + gpointer user_data) +{ + GObject *win = modest_mail_operation_get_source (mail_op); + + modest_platform_run_information_dialog ((win) ? GTK_WINDOW (win) : NULL, + _("mail_in_ui_folder_delete_error")); +} + +static void delete_folder (ModestMainWindow *main_window, gboolean move_to_trash) { TnyFolderStore *folder; @@ -1704,17 +1843,15 @@ delete_folder (ModestMainWindow *main_window, gboolean move_to_trash) g_free (message); if (response == GTK_RESPONSE_OK) { - ModestMailOperation *mail_op = modest_mail_operation_new (MODEST_MAIL_OPERATION_ID_DELETE, G_OBJECT(main_window)); + ModestMailOperation *mail_op = + modest_mail_operation_new_with_error_handling (MODEST_MAIL_OPERATION_TYPE_DELETE, + G_OBJECT(main_window), + modest_ui_actions_delete_folder_error_handler, + NULL); modest_mail_operation_queue_add (modest_runtime_get_mail_operation_queue (), mail_op); modest_mail_operation_remove_folder (mail_op, TNY_FOLDER (folder), move_to_trash); - - /* Show error if happened */ - if (modest_mail_operation_get_error (mail_op)) - modest_platform_run_information_dialog (GTK_WINDOW (main_window), - _("mail_in_ui_folder_delete_error")); - g_object_unref (G_OBJECT (mail_op)); } @@ -1929,7 +2066,7 @@ modest_ui_actions_on_cut (GtkAction *action, GtkTextBuffer *buffer; GtkClipboard *clipboard; - clipboard = gtk_clipboard_get (GDK_SELECTION_PRIMARY); + clipboard = gtk_clipboard_get (GDK_SELECTION_CLIPBOARD); buffer = gtk_text_view_get_buffer (GTK_TEXT_VIEW (focused_widget)); gtk_text_buffer_cut_clipboard (buffer, clipboard, TRUE); } @@ -1942,7 +2079,7 @@ modest_ui_actions_on_copy (GtkAction *action, GtkClipboard *clipboard; GtkWidget *focused_widget; - clipboard = gtk_clipboard_get (GDK_SELECTION_PRIMARY); + clipboard = gtk_clipboard_get (GDK_SELECTION_CLIPBOARD); focused_widget = gtk_window_get_focus (GTK_WINDOW (window)); if (GTK_IS_LABEL (focused_widget)) { gtk_clipboard_set_text (clipboard, gtk_label_get_text (GTK_LABEL (focused_widget)), -1); @@ -1980,7 +2117,7 @@ modest_ui_actions_on_paste (GtkAction *action, GtkTextBuffer *buffer; GtkClipboard *clipboard; - clipboard = gtk_clipboard_get (GDK_SELECTION_PRIMARY); + clipboard = gtk_clipboard_get (GDK_SELECTION_CLIPBOARD); buffer = gtk_text_view_get_buffer (GTK_TEXT_VIEW (focused_widget)); gtk_text_buffer_paste_clipboard (buffer, clipboard, NULL, TRUE); } @@ -2008,6 +2145,21 @@ modest_ui_actions_on_select_all (GtkAction *action, gtk_text_buffer_get_end_iter (buffer, &end); gtk_text_buffer_select_range (buffer, &start, &end); } + else if ((MODEST_IS_FOLDER_VIEW (focused_widget)) || + (MODEST_IS_HEADER_VIEW (focused_widget))) { + + GtkTreeSelection *selection = NULL; + + /* Get header view */ + GtkWidget *header_view = focused_widget; + if (MODEST_IS_FOLDER_VIEW (focused_widget)) + header_view = modest_main_window_get_child_widget (MODEST_MAIN_WINDOW (window), + MODEST_WIDGET_TYPE_HEADER_VIEW); + + /* Select all messages */ + selection = gtk_tree_view_get_selection (GTK_TREE_VIEW(header_view)); + gtk_tree_selection_select_all (selection); + } } void @@ -2421,6 +2573,7 @@ msgs_move_to_confirmation (GtkWindow *win, response = modest_platform_run_confirmation_dialog (GTK_WINDOW (win), (const gchar *) message); } + g_object_unref (src_folder); } return response; } @@ -2439,17 +2592,15 @@ tranasfer_msgs_from_viewer_cb (const GObject *object, gpointer user_data) g_return_if_fail (found); } -static void -move_to_error_checking (const GObject *obj, gpointer user_data) +void +modest_ui_actions_move_folder_error_handler (ModestMailOperation *mail_op, + gpointer user_data) { - ModestWindow *win = NULL; - - g_return_if_fail (MODEST_IS_WINDOW (obj)); - win = MODEST_WINDOW (obj); + GObject *win = modest_mail_operation_get_source (mail_op); /* TODO: show error message */ -/* modest_platform_run_information_dialog (GTK_WINDOW (win), */ -/* _("mail_in_ui_folder_move_target_error")); */ + modest_platform_run_information_dialog ((win) ? GTK_WINDOW (win) : NULL, + _("mail_in_ui_folder_move_target_error")); } /* @@ -2499,18 +2650,19 @@ modest_ui_actions_on_main_window_move_to (GtkAction *action, modest_header_view_set_folder (MODEST_HEADER_VIEW (header_view), NULL); if (TNY_IS_FOLDER (src_folder)) { - mail_op = modest_mail_operation_new_with_error_handling (MODEST_MAIL_OPERATION_ID_RECEIVE, - G_OBJECT(win), - move_to_error_checking); - modest_mail_operation_queue_add (modest_runtime_get_mail_operation_queue (), - mail_op); + mail_op = + modest_mail_operation_new_with_error_handling (MODEST_MAIL_OPERATION_TYPE_RECEIVE, + G_OBJECT(win), + modest_ui_actions_move_folder_error_handler, + NULL); + modest_mail_operation_queue_add (modest_runtime_get_mail_operation_queue (), mail_op); modest_mail_operation_xfer_folder (mail_op, TNY_FOLDER (src_folder), folder_store, TRUE); + /* Unref mail operation */ g_object_unref (G_OBJECT (mail_op)); - } /* Frees */ @@ -2529,7 +2681,7 @@ modest_ui_actions_on_main_window_move_to (GtkAction *action, /* Transfer messages */ if (response == GTK_RESPONSE_OK) { - mail_op = modest_mail_operation_new (MODEST_MAIL_OPERATION_ID_RECEIVE, G_OBJECT(win)); + mail_op = modest_mail_operation_new (MODEST_MAIL_OPERATION_TYPE_RECEIVE, G_OBJECT(win)); modest_mail_operation_queue_add (modest_runtime_get_mail_operation_queue (), mail_op); @@ -2539,13 +2691,13 @@ modest_ui_actions_on_main_window_move_to (GtkAction *action, TRUE, NULL, NULL); + g_object_unref (G_OBJECT (mail_op)); } g_object_unref (headers); } } g_object_unref (folder_store); - end: gtk_widget_destroy (dialog); } @@ -2597,7 +2749,7 @@ modest_ui_actions_on_msg_view_window_move_to (GtkAction *action, ModestMailOperation *mail_op; /* Create mail op */ - mail_op = modest_mail_operation_new (MODEST_MAIL_OPERATION_ID_RECEIVE, G_OBJECT(win)); + mail_op = modest_mail_operation_new (MODEST_MAIL_OPERATION_TYPE_RECEIVE, G_OBJECT(win)); modest_mail_operation_queue_add (modest_runtime_get_mail_operation_queue (), mail_op); @@ -2714,6 +2866,61 @@ modest_ui_actions_on_settings (GtkAction *action, } void +modest_ui_actions_on_help (GtkAction *action, + ModestWindow *win) +{ + const gchar *help_id = NULL; + + if (MODEST_IS_MAIN_WINDOW (win)) { + const gchar *action_name; + action_name = gtk_action_get_name (action); + + if (!strcmp (action_name, "FolderViewCSMHelp") || + !strcmp (action_name, "HeaderViewCSMHelp")) { + GtkWidget *folder_view; + TnyFolderStore *folder_store; + /* Get selected folder */ + folder_view = modest_main_window_get_child_widget (MODEST_MAIN_WINDOW (win), + MODEST_WIDGET_TYPE_FOLDER_VIEW); + folder_store = modest_folder_view_get_selected (MODEST_FOLDER_VIEW (folder_view)); + + /* Switch help_id */ + if (TNY_IS_FOLDER (folder_store)) { + switch (tny_folder_get_folder_type (TNY_FOLDER (folder_store))) { + case TNY_FOLDER_TYPE_NORMAL: + help_id = "applications_email_userfolder"; + break; + case TNY_FOLDER_TYPE_INBOX: + help_id = "applications_email_inbox"; + break; + case TNY_FOLDER_TYPE_OUTBOX: + help_id = "applications_email_outbox"; + break; + case TNY_FOLDER_TYPE_SENT: + help_id = "applications_email_sent"; + break; + case TNY_FOLDER_TYPE_DRAFTS: + help_id = "applications_email_drafts"; + break; + case TNY_FOLDER_TYPE_ARCHIVE: + help_id = "applications_email_archive"; + break; + default: + help_id = NULL; + } + } + } else { + help_id = "applications_email_mainview"; + } + } else if (MODEST_IS_MSG_VIEW_WINDOW (win)) { + help_id = "applications_email_viewer"; + } else if (MODEST_IS_MSG_EDIT_WINDOW (win)) + help_id = "applications_email_editor"; + + modest_platform_show_help (GTK_WINDOW (win), help_id); +} + +void modest_ui_actions_on_retrieve_msg_contents (GtkAction *action, ModestWindow *window) { @@ -2726,7 +2933,10 @@ modest_ui_actions_on_retrieve_msg_contents (GtkAction *action, return; /* Create mail operation */ - mail_op = modest_mail_operation_new (MODEST_MAIL_OPERATION_ID_RECEIVE, G_OBJECT (window)); + mail_op = modest_mail_operation_new_with_error_handling (MODEST_MAIL_OPERATION_TYPE_RECEIVE, + G_OBJECT (window), + modest_ui_actions_get_msgs_full_error_handler, + NULL); modest_mail_operation_queue_add (modest_runtime_get_mail_operation_queue (), mail_op); modest_mail_operation_get_msgs_full (mail_op, headers, NULL, NULL, NULL); @@ -2734,3 +2944,62 @@ modest_ui_actions_on_retrieve_msg_contents (GtkAction *action, g_object_unref (headers); g_object_unref (mail_op); } + +void +modest_ui_actions_on_email_menu_activated (GtkAction *action, + ModestWindow *window) +{ + g_return_if_fail (MODEST_IS_WINDOW (window)); + + /* Update dimmed */ + modest_window_check_dimming_rules_group (window, "ModestMenuDimmingRules"); +} + +void +modest_ui_actions_on_edit_menu_activated (GtkAction *action, + ModestWindow *window) +{ + g_return_if_fail (MODEST_IS_WINDOW (window)); + + /* Update dimmed */ + modest_window_check_dimming_rules_group (window, "ModestMenuDimmingRules"); +} + +void +modest_ui_actions_on_toolbar_csm_menu_activated (GtkAction *action, + ModestWindow *window) +{ + g_return_if_fail (MODEST_IS_WINDOW (window)); + + /* Update dimmed */ + modest_window_check_dimming_rules_group (window, "ModestMenuDimmingRules"); +} + +void +modest_ui_actions_on_folder_view_csm_menu_activated (GtkAction *action, + ModestWindow *window) +{ + g_return_if_fail (MODEST_IS_WINDOW (window)); + + /* Update dimmed */ + modest_window_check_dimming_rules_group (window, "ModestMenuDimmingRules"); +} + +void +modest_ui_actions_on_header_view_csm_menu_activated (GtkAction *action, + ModestWindow *window) +{ + g_return_if_fail (MODEST_IS_WINDOW (window)); + + /* Update dimmed */ + modest_window_check_dimming_rules_group (window, "ModestMenuDimmingRules"); +} + +void +modest_ui_actions_check_toolbar_dimming_rules (ModestWindow *window) +{ + g_return_if_fail (MODEST_IS_WINDOW (window)); + + /* Update dimmed */ + modest_window_check_dimming_rules_group (window, "ModestToolbarDimmingRules"); +}