X-Git-Url: http://git.maemo.org/git/?p=modest;a=blobdiff_plain;f=src%2Fmodest-ui-dimming-rules.c;h=03ae7213524da4f66cca68b19dc6d09f0a5d5549;hp=d3c620d563f4001064352435f320241249052bd7;hb=362784ce756b3f0e31cd451d9ac5e69b909d4053;hpb=2298607f8d2547dcadd2a7cd7e45b12618e617fd diff --git a/src/modest-ui-dimming-rules.c b/src/modest-ui-dimming-rules.c index d3c620d..03ae721 100644 --- a/src/modest-ui-dimming-rules.c +++ b/src/modest-ui-dimming-rules.c @@ -35,6 +35,7 @@ #include "modest-ui-dimming-rules.h" #include "modest-dimming-rule.h" #include "modest-tny-folder.h" +#include "modest-tny-account.h" #include "modest-text-utils.h" #include #include @@ -78,7 +79,8 @@ modest_ui_dimming_rules_on_new_msg (ModestWindow *win, gpointer user_data) /* Check dimmed rule */ if (!dimmed) { - dimmed = _msg_download_in_progress (MODEST_MSG_VIEW_WINDOW(win)); + if (MODEST_IS_MSG_VIEW_WINDOW (win)) + dimmed = _msg_download_in_progress (MODEST_MSG_VIEW_WINDOW(win)); if (dimmed) modest_dimming_rule_set_notification (rule, ""); } @@ -174,23 +176,33 @@ modest_ui_dimming_rules_on_delete (ModestWindow *win, gpointer user_data) GtkWidget *header_view = NULL; gboolean dimmed = FALSE; - g_return_val_if_fail (MODEST_IS_MAIN_WINDOW(win), FALSE); g_return_val_if_fail (MODEST_IS_DIMMING_RULE (user_data), FALSE); rule = MODEST_DIMMING_RULE (user_data); - /* Get the folder view */ - folder_view = modest_main_window_get_child_widget (MODEST_MAIN_WINDOW(win), - MODEST_WIDGET_TYPE_FOLDER_VIEW); - - /* Get header view */ - header_view = modest_main_window_get_child_widget (MODEST_MAIN_WINDOW(win), + if (MODEST_IS_MAIN_WINDOW (win)) { + /* Get the folder view */ + folder_view = modest_main_window_get_child_widget (MODEST_MAIN_WINDOW(win), + MODEST_WIDGET_TYPE_FOLDER_VIEW); + + /* Get header view */ + header_view = modest_main_window_get_child_widget (MODEST_MAIN_WINDOW(win), MODEST_WIDGET_TYPE_HEADER_VIEW); - if (header_view && gtk_widget_is_focus (header_view)) - dimmed = modest_ui_dimming_rules_on_delete_msg (win, rule); + if (header_view && gtk_widget_is_focus (header_view)) + dimmed = modest_ui_dimming_rules_on_delete_msg (win, rule); - if (folder_view && gtk_widget_is_focus (folder_view)) + if (folder_view && gtk_widget_is_focus (folder_view)) + dimmed = modest_ui_dimming_rules_on_delete_folder (win, rule); + + if (header_view && folder_view && + !gtk_widget_is_focus (header_view) && + !gtk_widget_is_focus (folder_view)) { + dimmed = TRUE; + modest_dimming_rule_set_notification (rule, dgettext("hildon-common-strings", "ckct_ib_nothing_to_delete")); + } + } else { dimmed = modest_ui_dimming_rules_on_delete_folder (win, rule); + } return dimmed; } @@ -201,7 +213,7 @@ gboolean modest_ui_dimming_rules_on_delete_folder (ModestWindow *win, gpointer user_data) { ModestDimmingRule *rule = NULL; - TnyFolderType types[5]; + TnyFolderType types[6]; gboolean dimmed = FALSE; g_return_val_if_fail (MODEST_IS_MAIN_WINDOW(win), FALSE); @@ -213,6 +225,7 @@ modest_ui_dimming_rules_on_delete_folder (ModestWindow *win, gpointer user_data) types[2] = TNY_FOLDER_TYPE_SENT; types[3] = TNY_FOLDER_TYPE_INBOX; types[4] = TNY_FOLDER_TYPE_ROOT; + types[5] = TNY_FOLDER_TYPE_ARCHIVE; /* Check dimmed rule */ @@ -222,7 +235,7 @@ modest_ui_dimming_rules_on_delete_folder (ModestWindow *win, gpointer user_data) modest_dimming_rule_set_notification (rule, _("mail_in_ui_folder_delete_error")); } if (!dimmed) { - dimmed = _selected_folder_is_any_of_type (win, types, 5); + dimmed = _selected_folder_is_any_of_type (win, types, 6); if (dimmed) modest_dimming_rule_set_notification (rule, _("mail_in_ui_folder_delete_error")); } @@ -253,8 +266,12 @@ modest_ui_dimming_rules_on_sort (ModestWindow *win, gpointer user_data) /* Check dimmed rule */ if (!dimmed) { dimmed = _selected_folder_is_root (MODEST_MAIN_WINDOW(win)); - if (dimmed) - modest_dimming_rule_set_notification (rule, ""); + modest_dimming_rule_set_notification (rule, _CS("ckdg_ib_nothing_to_sort")); + } + + if (!dimmed) { + dimmed = _selected_folder_is_empty (MODEST_MAIN_WINDOW(win)); + modest_dimming_rule_set_notification (rule, _CS("ckdg_ib_nothing_to_sort")); } return dimmed; @@ -265,7 +282,7 @@ gboolean modest_ui_dimming_rules_on_rename_folder (ModestWindow *win, gpointer user_data) { ModestDimmingRule *rule = NULL; - TnyFolderType types[3]; + TnyFolderType types[4]; gboolean dimmed = FALSE; g_return_val_if_fail (MODEST_IS_MAIN_WINDOW(win), FALSE); @@ -275,6 +292,7 @@ modest_ui_dimming_rules_on_rename_folder (ModestWindow *win, gpointer user_data) types[0] = TNY_FOLDER_TYPE_DRAFTS; types[1] = TNY_FOLDER_TYPE_OUTBOX; types[2] = TNY_FOLDER_TYPE_SENT; + types[3] = TNY_FOLDER_TYPE_ARCHIVE; /* Check dimmed rule */ if (!dimmed) { @@ -288,7 +306,7 @@ modest_ui_dimming_rules_on_rename_folder (ModestWindow *win, gpointer user_data) modest_dimming_rule_set_notification (rule, ""); } if (!dimmed) { - dimmed = _selected_folder_is_any_of_type (win, types, 3); + dimmed = _selected_folder_is_any_of_type (win, types, 4); if (dimmed) modest_dimming_rule_set_notification (rule, ""); } @@ -365,9 +383,10 @@ modest_ui_dimming_rules_on_reply_msg (ModestWindow *win, gpointer user_data) modest_dimming_rule_set_notification (rule, _("mail_ib_notavailable_downloading")); } if (!dimmed) { - dimmed = _msg_download_in_progress (MODEST_MSG_VIEW_WINDOW(win)); + if (MODEST_IS_MSG_VIEW_WINDOW (win)) + dimmed = _msg_download_in_progress (MODEST_MSG_VIEW_WINDOW (win)); if (dimmed) - modest_dimming_rule_set_notification (rule, ""); + modest_dimming_rule_set_notification (rule, _("mcen_ib_unable_to_reply")); } } @@ -451,7 +470,7 @@ modest_ui_dimming_rules_on_delete_msg (ModestWindow *win, gpointer user_data) if (!dimmed) { dimmed = _selected_msg_sent_in_progress (win); if (dimmed) - modest_dimming_rule_set_notification (rule, _("mcen_ib_message_unableto_delete")); + modest_dimming_rule_set_notification (rule, _CS("ckct_ib_unable_to_delete")); } } else if (MODEST_IS_MSG_VIEW_WINDOW (win)) { @@ -461,14 +480,14 @@ modest_ui_dimming_rules_on_delete_msg (ModestWindow *win, gpointer user_data) modest_dimming_rule_set_notification (rule, _("mail_ib_notavailable_downloading")); } if (!dimmed) { + dimmed = _marked_as_deleted (win); + if (dimmed) + modest_dimming_rule_set_notification (rule, _("mcen_ib_message_already_deleted")); + } + if (!dimmed) { dimmed = !modest_msg_view_window_has_headers_model (MODEST_MSG_VIEW_WINDOW(win)); if (dimmed) { - gchar *num = g_strdup("1"); - gchar *message = g_strdup_printf(_("mcen_nc_unable_to_delete_n_messages"), num); -/* modest_dimming_rule_set_notification (rule, _("mcen_nc_unable_to_delete_n_messages")); */ - modest_dimming_rule_set_notification (rule, message); - g_free(message); - g_free(num); + modest_dimming_rule_set_notification (rule, _CS("ckct_ib_unable_to_delete")); } } } @@ -527,7 +546,8 @@ modest_ui_dimming_rules_on_details (ModestWindow *win, gpointer user_data) /* Check dimmed rule */ if (!dimmed) { - dimmed = _msg_download_in_progress (MODEST_MSG_VIEW_WINDOW(win)); + if (MODEST_IS_MSG_VIEW_WINDOW (win)) + dimmed = _msg_download_in_progress (MODEST_MSG_VIEW_WINDOW (win)); if (dimmed) modest_dimming_rule_set_notification (rule, ""); } @@ -612,6 +632,7 @@ modest_ui_dimming_rules_on_main_window_move_to (ModestWindow *win, gpointer user GtkWidget *folder_view = NULL; GtkWidget *header_view = NULL; ModestDimmingRule *rule = NULL; + guint n_messages = 0; gboolean dimmed = FALSE; g_return_val_if_fail (MODEST_IS_MAIN_WINDOW(win), TRUE); @@ -628,6 +649,14 @@ modest_ui_dimming_rules_on_main_window_move_to (ModestWindow *win, gpointer user /* Check diming rules for folders and messages transfer */ if (!dimmed) { + dimmed = _already_opened_msg (win, &n_messages); + if (dimmed) { + gchar *message = g_strdup_printf(_("emev_bd_unabletomove_items"), n_messages); + modest_dimming_rule_set_notification (rule, message); + g_free(message); + } + } + if (!dimmed) { if (!gtk_widget_is_focus (folder_view)) dimmed = _invalid_msg_selected (MODEST_MAIN_WINDOW(win), FALSE, user_data); @@ -653,7 +682,8 @@ modest_ui_dimming_rules_on_view_window_move_to (ModestWindow *win, gpointer user modest_dimming_rule_set_notification (rule, _("mail_ib_notavailable_downloading")); } if (!dimmed) { - dimmed = !modest_msg_view_window_has_headers_model (MODEST_MSG_VIEW_WINDOW(win)); + if (MODEST_IS_MSG_VIEW_WINDOW (win)) + dimmed = !modest_msg_view_window_has_headers_model (MODEST_MSG_VIEW_WINDOW (win)); if (dimmed) modest_dimming_rule_set_notification (rule, _("mcen_ib_unable_to_move_mail_attachment")); } @@ -687,7 +717,7 @@ modest_ui_dimming_rules_on_paste_msgs (ModestWindow *win, gpointer user_data) ModestDimmingRule *rule = NULL; TnyFolderType types[3]; gboolean dimmed = FALSE; - + g_return_val_if_fail (MODEST_IS_MAIN_WINDOW(win), FALSE); g_return_val_if_fail (MODEST_IS_DIMMING_RULE (user_data), FALSE); rule = MODEST_DIMMING_RULE (user_data); @@ -705,7 +735,13 @@ modest_ui_dimming_rules_on_paste_msgs (ModestWindow *win, gpointer user_data) if (!dimmed) { dimmed = _selected_folder_is_any_of_type (win, types, 3); if (dimmed) - modest_dimming_rule_set_notification (rule, _("ckct_ib_unable_to_paste_here")); + modest_dimming_rule_set_notification (rule, dgettext("hildon-common-strings", "ckct_ib_unable_to_paste_here")); + } + if (!dimmed) { + dimmed = _selected_folder_not_writeable (MODEST_MAIN_WINDOW(win)); + if (dimmed) { + modest_dimming_rule_set_notification (rule, dgettext("hildon-common-strings", "ckct_ib_unable_to_paste_here")); + } } if (!dimmed) { dimmed = _selected_folder_is_same_as_source (win); @@ -870,11 +906,6 @@ modest_ui_dimming_rules_on_cut (ModestWindow *win, gpointer user_data) /* Check window specific dimming rules */ if (MODEST_IS_MAIN_WINDOW (win)) { - if (!dimmed) { - dimmed = _selected_folder_not_writeable (MODEST_MAIN_WINDOW(win)); - if (dimmed) - modest_dimming_rule_set_notification (rule, _("mcen_ib_message_unableto_delete")); - } if (!dimmed) { dimmed = _selected_folder_is_empty (MODEST_MAIN_WINDOW(win)); if (dimmed) @@ -939,9 +970,9 @@ modest_ui_dimming_rules_on_view_previous (ModestWindow *win, gpointer user_data) modest_dimming_rule_set_notification (rule, _("mail_ib_notavailable_downloading")); } if (!dimmed) { - dimmed = modest_msg_view_window_first_message_selected (MODEST_MSG_VIEW_WINDOW(win)); - if (dimmed) - modest_dimming_rule_set_notification (rule, ""); + if (MODEST_IS_MSG_VIEW_WINDOW (win)) + dimmed = modest_msg_view_window_first_message_selected (MODEST_MSG_VIEW_WINDOW(win)); + modest_dimming_rule_set_notification (rule, NULL); } return dimmed; @@ -964,9 +995,9 @@ modest_ui_dimming_rules_on_view_next (ModestWindow *win, gpointer user_data) modest_dimming_rule_set_notification (rule, _("mail_ib_notavailable_downloading")); } if (!dimmed) { - dimmed = modest_msg_view_window_last_message_selected (MODEST_MSG_VIEW_WINDOW(win)); - if (dimmed) - modest_dimming_rule_set_notification (rule, ""); + if (MODEST_IS_MSG_VIEW_WINDOW (win)) + dimmed = modest_msg_view_window_last_message_selected (MODEST_MSG_VIEW_WINDOW (win)); + modest_dimming_rule_set_notification (rule, NULL); } return dimmed; @@ -986,12 +1017,34 @@ modest_ui_dimming_rules_on_tools_smtp_servers (ModestWindow *win, gpointer user_ gboolean modest_ui_dimming_rules_on_cancel_sending (ModestWindow *win, gpointer user_data) { + ModestDimmingRule *rule = NULL; + TnyFolderType types[1]; + guint n_messages = 0; gboolean dimmed = FALSE; - /* Check dimmed rule */ - if (!dimmed) + g_return_val_if_fail (MODEST_IS_MAIN_WINDOW(win), FALSE); + g_return_val_if_fail (MODEST_IS_DIMMING_RULE (user_data), FALSE); + rule = MODEST_DIMMING_RULE (user_data); + + types[0] = TNY_FOLDER_TYPE_OUTBOX; + + /* Check dimmed rules */ + if (!dimmed) { + dimmed = _already_opened_msg (win, &n_messages); + if (dimmed) + modest_dimming_rule_set_notification (rule, _("mcen_ib_message_unableto_cancel_send")); + } + if (!dimmed) { + dimmed = !_selected_folder_is_any_of_type (win, types, 1); + if (dimmed) + modest_dimming_rule_set_notification (rule, ""); + } + if (!dimmed) { dimmed = !_sending_in_progress (win); - + if (dimmed) + modest_dimming_rule_set_notification (rule, ""); + } + return dimmed; } @@ -1030,7 +1083,7 @@ modest_ui_dimming_rules_on_add_to_contacts (ModestWindow *win, gpointer user_dat gchar *selection = NULL; selection = gtk_clipboard_wait_for_text (clipboard); - dimmed = !((selection != NULL) && (modest_text_utils_validate_recipient (selection))); + dimmed = !((selection != NULL) && (modest_text_utils_validate_recipient (selection, NULL))); } return dimmed; @@ -1044,8 +1097,6 @@ _marked_as_deleted (ModestWindow *win) gboolean result = FALSE; TnyHeaderFlags flags; - g_return_val_if_fail (MODEST_IS_MAIN_WINDOW(win), FALSE); - flags = TNY_HEADER_FLAG_DELETED; /* Check dimmed rule */ @@ -1120,6 +1171,24 @@ _selected_folder_is_root (ModestMainWindow *win) g_return_val_if_fail (MODEST_IS_MAIN_WINDOW(win), FALSE); + /* All accounts are root items: */ + GtkWidget *folder_view = modest_main_window_get_child_widget (MODEST_MAIN_WINDOW(win), + MODEST_WIDGET_TYPE_FOLDER_VIEW); + if (folder_view) { + gboolean is_account = FALSE; + TnyFolderStore *folder_store = + modest_folder_view_get_selected (MODEST_FOLDER_VIEW(folder_view)); + if (folder_store) { + is_account = TNY_IS_ACCOUNT (folder_store); + g_object_unref (folder_store); + folder_store = NULL; + } + + if (is_account) + return TRUE; + } + + /* Try something more precise: */ types[0] = TNY_FOLDER_TYPE_ROOT; /* Check folder type */ @@ -1169,8 +1238,6 @@ _selected_folder_is_MMC_or_POP_root (ModestMainWindow *win) } - - static gboolean _selected_folder_is_empty (ModestMainWindow *win) { @@ -1256,7 +1323,7 @@ _selected_folder_is_any_of_type (ModestWindow *win, guint i=0; gboolean result = FALSE; - /*Get curent folder */ + /*Get current folder */ if (MODEST_IS_MAIN_WINDOW(win)) { /* Get folder view */ @@ -1264,7 +1331,7 @@ _selected_folder_is_any_of_type (ModestWindow *win, MODEST_WIDGET_TYPE_FOLDER_VIEW); /* If no folder view, always dimmed */ if (!folder_view) - return TRUE; + return FALSE; /* Get selected folder as parent of new folder to create */ folder = modest_folder_view_get_selected (MODEST_FOLDER_VIEW(folder_view)); @@ -1272,7 +1339,7 @@ _selected_folder_is_any_of_type (ModestWindow *win, if (!(folder && TNY_IS_FOLDER(folder))) { if (folder) g_object_unref (folder); - return TRUE; + return FALSE; } /* Check folder type */ @@ -1304,11 +1371,8 @@ _folder_is_any_of_type (TnyFolder *folder, g_return_val_if_fail (TNY_IS_FOLDER(folder), FALSE); /* Get folder type */ - if (modest_tny_folder_is_local_folder (folder)) - folder_type = modest_tny_folder_get_local_folder_type (folder); - else - folder_type = modest_tny_folder_guess_folder_type (folder); - + folder_type = modest_tny_folder_guess_folder_type (folder); + /* Check foler type */ for (i=0; i < ntypes; i++) { result = result || folder_type == types[i]; @@ -1325,7 +1389,7 @@ _selected_folder_is_snd_level (ModestMainWindow *win) GtkTreeModel *model = NULL; GtkTreePath *path = NULL; GtkTreeIter iter; - TnyFolderStore *folder = NULL; + TnyFolderStore *folder = NULL; gboolean result = FALSE; g_return_val_if_fail (MODEST_IS_MAIN_WINDOW(win), TRUE); @@ -1353,7 +1417,7 @@ _selected_folder_is_snd_level (ModestMainWindow *win) frees: if (folder != NULL) g_object_unref (folder); - if (path != NULL) + if (path != NULL) gtk_tree_path_free (path); return result; @@ -1398,7 +1462,7 @@ _invalid_clipboard_selected (ModestWindow *win, (MODEST_IS_ATTACHMENTS_VIEW (focused))); if (result) - modest_dimming_rule_set_notification (rule, _("")); + modest_dimming_rule_set_notification (rule, ""); } else if (MODEST_IS_MAIN_WINDOW (win)) { GtkWidget *header_view = NULL; @@ -1609,9 +1673,12 @@ _already_opened_msg (ModestWindow *win, found = FALSE; while (!tny_iterator_is_done (iter)) { header = TNY_HEADER (tny_iterator_get_current (iter)); - found = modest_window_mgr_find_registered_header (mgr,header, NULL); + if (header) { + found = modest_window_mgr_find_registered_header (mgr,header, NULL); - g_object_unref (header); + g_object_unref (header); + } + tny_iterator_next (iter); if (found) @@ -1632,15 +1699,27 @@ _selected_msg_marked_as (ModestWindow *win, TnyHeaderFlags mask, gboolean opposite) { + ModestWindow *main_window = NULL; GtkWidget *header_view = NULL; TnyList *selected_headers = NULL; TnyIterator *iter = NULL; TnyHeader *header = NULL; - TnyHeaderFlags flags; + TnyHeaderFlags flags = 0; gboolean result = FALSE; + if (MODEST_IS_MAIN_WINDOW (win)) + main_window = win; + else + main_window = + modest_window_mgr_get_main_window (modest_runtime_get_window_mgr ()); + + /* TODO: Javi, what about if the main window does not + exist?. Adding some code to avoid CRITICALs */ + if (!main_window) + return FALSE; + /* Get header view to check selected messages */ - header_view = modest_main_window_get_child_widget (MODEST_MAIN_WINDOW(win), + header_view = modest_main_window_get_child_widget (MODEST_MAIN_WINDOW(main_window), MODEST_WIDGET_TYPE_HEADER_VIEW); /* Check no selection */ @@ -1656,14 +1735,16 @@ _selected_msg_marked_as (ModestWindow *win, iter = tny_list_create_iterator (selected_headers); while (!tny_iterator_is_done (iter) && !result) { header = TNY_HEADER (tny_iterator_get_current (iter)); + if (header) { + flags = tny_header_get_flags (header); + if (opposite) + result = (flags & mask) == 0; + else + result = (flags & mask) != 0; - flags = tny_header_get_flags (header); - if (opposite) - result = (flags & mask) == 0; - else - result = (flags & mask) != 0; + g_object_unref (header); + } - g_object_unref (header); tny_iterator_next (iter); } @@ -1695,7 +1776,7 @@ _msg_download_completed (ModestMainWindow *win) TnyList *selected_headers = NULL; TnyIterator *iter = NULL; TnyHeader *header = NULL; - TnyHeaderFlags flags; + TnyHeaderFlags flags = 0; gboolean result = FALSE; g_return_val_if_fail (MODEST_IS_MAIN_WINDOW (win), FALSE); @@ -1719,14 +1800,16 @@ _msg_download_completed (ModestMainWindow *win) iter = tny_list_create_iterator (selected_headers); while (!tny_iterator_is_done (iter) && result) { header = TNY_HEADER (tny_iterator_get_current (iter)); - - flags = tny_header_get_flags (header); - /* TODO: is this the right flag?, it seems that some - headers that have been previously downloaded do not - come with it */ - result = (flags & TNY_HEADER_FLAG_CACHED); + if (header) { + flags = tny_header_get_flags (header); + /* TODO: is this the right flag?, it seems that some + headers that have been previously downloaded do not + come with it */ + result = (flags & TNY_HEADER_FLAG_CACHED); + + g_object_unref (header); + } - g_object_unref (header); tny_iterator_next (iter); } @@ -1779,17 +1862,22 @@ _selected_msg_sent_in_progress (ModestWindow *win) if (!header_list) return FALSE; iter = tny_list_create_iterator (header_list); header = TNY_HEADER (tny_iterator_get_current (iter)); - - /* Get message id */ - id = g_strdup(tny_header_get_message_id (header)); + if (header) { + /* Get message id */ + id = g_strdup(tny_header_get_message_id (header)); + g_object_unref (header); + } } else if (MODEST_IS_MSG_VIEW_WINDOW(win)) { /* Get message header */ header = modest_msg_view_window_get_header (MODEST_MSG_VIEW_WINDOW(win)); + if (header) { + /* Get message id */ + id = g_strdup(tny_header_get_message_id (header)); - /* Get message id */ - id = g_strdup(tny_header_get_message_id (header)); + g_object_unref (header); + } } /* Check if msg id is being processed inside send queue */ @@ -1797,7 +1885,6 @@ _selected_msg_sent_in_progress (ModestWindow *win) /* Free */ g_free(id); - g_object_unref (header); g_object_unref(header_list); g_object_unref(iter); @@ -1808,27 +1895,12 @@ _selected_msg_sent_in_progress (ModestWindow *win) static gboolean _sending_in_progress (ModestWindow *win) { - ModestTnySendQueue *send_queue = NULL; - ModestTnyAccountStore *acc_store = NULL; - TnyAccount *account = NULL; - const gchar *account_name = NULL; gboolean result = FALSE; - /* Get transport account */ - acc_store = modest_runtime_get_account_store(); - account_name = modest_window_get_active_account (win); - - /* If no account defined, this action must be always dimmed */ - if (account_name == NULL) return FALSE; - account = modest_tny_account_store_get_transport_account_for_open_connection (acc_store, account_name); - if (!TNY_IS_TRANSPORT_ACCOUNT (account)) return FALSE; - - /* Get send queue for current ransport account */ - send_queue = modest_runtime_get_send_queue (TNY_TRANSPORT_ACCOUNT(account)); - g_return_val_if_fail (MODEST_IS_TNY_SEND_QUEUE (send_queue), FALSE); + g_return_val_if_fail (MODEST_IS_MAIN_WINDOW (win), FALSE); - /* Check if send queue is perfimring any send operation */ - result = modest_tny_send_queue_sending_in_progress (send_queue); + /* Check if send operation is in progress */ + result = modest_main_window_send_receive_in_progress (MODEST_MAIN_WINDOW (win)); return result; } @@ -1847,10 +1919,10 @@ _invalid_folder_for_purge (ModestWindow *win, /* Get folder and account of message */ msg = modest_msg_view_window_get_message (MODEST_MSG_VIEW_WINDOW (win)); g_return_val_if_fail(msg != NULL, TRUE); - folder = tny_msg_get_folder (msg); + folder = tny_msg_get_folder (msg); if (folder == NULL) { modest_dimming_rule_set_notification (rule, _("mail_ib_unable_to_purge_attachments")); - goto frees; + goto frees; } g_object_unref (msg); } else if (MODEST_IS_MAIN_WINDOW (win)) { @@ -1860,9 +1932,7 @@ _invalid_folder_for_purge (ModestWindow *win, return FALSE; folder = TNY_FOLDER (modest_folder_view_get_selected (MODEST_FOLDER_VIEW (folder_view))); if (folder == NULL || ! TNY_IS_FOLDER (folder)) - return FALSE; - g_object_ref (folder); - + goto frees; } else { g_return_val_if_reached (FALSE); } @@ -1888,12 +1958,17 @@ _invalid_folder_for_purge (ModestWindow *win, /* If it's POP then dim */ if (modest_protocol_info_get_transport_store_protocol (proto_str) == MODEST_PROTOCOL_STORE_POP) { - GList *attachments; - gint n_selected; + GList *attachments = NULL; + gint n_selected = 0; result = TRUE; - attachments = modest_msg_view_window_get_attachments (MODEST_MSG_VIEW_WINDOW(win)); - n_selected = g_list_length (attachments); - g_list_free (attachments); + + /* TODO: This check is here to prevent a gwarning, but this looks like a logic error. + * murrayc */ + if (MODEST_IS_MSG_VIEW_WINDOW (win)) { + attachments = modest_msg_view_window_get_attachments (MODEST_MSG_VIEW_WINDOW(win)); + n_selected = g_list_length (attachments); + g_list_free (attachments); + } modest_dimming_rule_set_notification (rule, ngettext ("mail_ib_unable_to_pure_attach_pop_mail_singular",