X-Git-Url: http://git.maemo.org/git/?p=modest;a=blobdiff_plain;f=src%2Fmodest-ui-dimming-rules.c;h=c115653959984cea67a07dc05443186c8f4a1aa8;hp=4dcd268581815bec81c72f38a7ec00d85d717505;hb=b3189f988bc953765fd3cdb325c4dd883ac9f608;hpb=94bd0f94bd12436a3624619478c0c6c6f7c33951 diff --git a/src/modest-ui-dimming-rules.c b/src/modest-ui-dimming-rules.c index 4dcd268..c115653 100644 --- a/src/modest-ui-dimming-rules.c +++ b/src/modest-ui-dimming-rules.c @@ -44,12 +44,14 @@ static gboolean _folder_is_any_of_type (TnyFolder *folder, TnyFolderType types[], guint ntypes); static gboolean _invalid_msg_selected (ModestMainWindow *win, gboolean unique, ModestDimmingRule *rule); -static gboolean _invalid_attach_selected (ModestWindow *win, gboolean unique, gboolean for_view, ModestDimmingRule *rule); +static gboolean _invalid_attach_selected (ModestWindow *win, + gboolean unique, gboolean for_view, gboolean for_remove, + ModestDimmingRule *rule); static gboolean _purged_attach_selected (ModestWindow *win, gboolean all, ModestDimmingRule *rule); static gboolean _clipboard_is_empty (ModestWindow *win); static gboolean _invalid_clipboard_selected (ModestWindow *win, ModestDimmingRule *rule); static gboolean _already_opened_msg (ModestWindow *win, guint *n_messages); -static gboolean _selected_msg_marked_as (ModestWindow *win, TnyHeaderFlags mask, gboolean opposite, gboolean all); +static gboolean _selected_msg_marked_as (ModestMainWindow *win, TnyHeaderFlags mask, gboolean opposite, gboolean all); static gboolean _selected_folder_not_writeable (ModestMainWindow *win); static gboolean _selected_folder_is_snd_level (ModestMainWindow *win); static gboolean _selected_folder_is_any_of_type (ModestWindow *win, TnyFolderType types[], guint ntypes); @@ -62,7 +64,8 @@ static gboolean _msg_download_in_progress (ModestMsgViewWindow *win); static gboolean _msg_download_completed (ModestMainWindow *win); static gboolean _selected_msg_sent_in_progress (ModestWindow *win); static gboolean _sending_in_progress (ModestWindow *win); -static gboolean _marked_as_deleted (ModestWindow *win); +static gboolean _message_is_marked_as_deleted (ModestMsgViewWindow *win); +static gboolean _selected_message_is_marked_as_deleted (ModestMainWindow *win); static gboolean _invalid_folder_for_purge (ModestWindow *win, ModestDimmingRule *rule); static gboolean _transfer_mode_enabled (ModestWindow *win); @@ -329,7 +332,7 @@ modest_ui_dimming_rules_on_open_msg (ModestWindow *win, gpointer user_data) dimmed = _invalid_msg_selected (MODEST_MAIN_WINDOW(win), TRUE, user_data); } if (!dimmed) { - dimmed = _marked_as_deleted (win); + dimmed = _selected_message_is_marked_as_deleted (MODEST_MAIN_WINDOW (win)); if (dimmed) modest_dimming_rule_set_notification (rule, _("mcen_ib_message_already_deleted")); } @@ -463,9 +466,10 @@ modest_ui_dimming_rules_on_delete_msg (ModestWindow *win, gpointer user_data) } } if (!dimmed) { - dimmed = _marked_as_deleted (win); - if (dimmed) + dimmed = _selected_message_is_marked_as_deleted (MODEST_MAIN_WINDOW (win)); + if (dimmed) { modest_dimming_rule_set_notification (rule, _("mcen_ib_message_already_deleted")); + } } if (!dimmed) { dimmed = _selected_msg_sent_in_progress (win); @@ -480,10 +484,16 @@ modest_ui_dimming_rules_on_delete_msg (ModestWindow *win, gpointer user_data) modest_dimming_rule_set_notification (rule, _("mail_ib_notavailable_downloading")); } if (!dimmed) { - dimmed = _marked_as_deleted (win); + dimmed = _message_is_marked_as_deleted (MODEST_MSG_VIEW_WINDOW (win)); if (dimmed) modest_dimming_rule_set_notification (rule, _("mcen_ib_message_already_deleted")); } + + /* Commented out, because deletion should be possible even when + * the message window has no header view model, which will be the + * case when it is not the selected message in the header view. + */ + if (!dimmed) { dimmed = !modest_msg_view_window_has_headers_model (MODEST_MSG_VIEW_WINDOW(win)); if (dimmed) { @@ -575,7 +585,7 @@ modest_ui_dimming_rules_on_mark_as_read_msg (ModestWindow *win, gpointer user_da dimmed = _invalid_msg_selected (MODEST_MAIN_WINDOW(win), FALSE, user_data); } if (!dimmed) { - dimmed = _selected_msg_marked_as (win, flags, FALSE, TRUE); + dimmed = _selected_msg_marked_as (MODEST_MAIN_WINDOW(win), flags, FALSE, TRUE); if (dimmed) modest_dimming_rule_set_notification (rule, ""); } @@ -600,7 +610,7 @@ modest_ui_dimming_rules_on_mark_as_unread_msg (ModestWindow *win, gpointer user_ if (!dimmed) dimmed = _invalid_msg_selected (MODEST_MAIN_WINDOW(win), FALSE, user_data); if (!dimmed) { - dimmed = _selected_msg_marked_as (win, flags, TRUE, TRUE); + dimmed = _selected_msg_marked_as (MODEST_MAIN_WINDOW(win), flags, TRUE, TRUE); if (dimmed) modest_dimming_rule_set_notification (rule, ""); } @@ -647,7 +657,30 @@ modest_ui_dimming_rules_on_main_window_move_to (ModestWindow *win, gpointer user header_view = modest_main_window_get_child_widget (MODEST_MAIN_WINDOW(win), MODEST_WIDGET_TYPE_HEADER_VIEW); - /* Check diming rules for folders and messages transfer */ + /* Check diming rules for folders transfer */ + if (gtk_widget_is_focus (folder_view)) { + TnyFolderType types[5]; + + types[0] = TNY_FOLDER_TYPE_DRAFTS; + types[1] = TNY_FOLDER_TYPE_OUTBOX; + types[2] = TNY_FOLDER_TYPE_SENT; + types[3] = TNY_FOLDER_TYPE_ROOT; + types[4] = TNY_FOLDER_TYPE_INBOX; + + /* Apply folder rules */ + if (!dimmed) { + dimmed = _selected_folder_not_writeable (MODEST_MAIN_WINDOW(win)); + if (dimmed) + modest_dimming_rule_set_notification (rule, _("emev_bd_unabletomove_items")); + } + if (!dimmed) { + dimmed = _selected_folder_is_any_of_type (win, types, 5); + if (dimmed) + modest_dimming_rule_set_notification (rule, _("emev_bd_unabletomove_itemsr")); + } + } + + /* Check diming rules for messages transfer */ if (!dimmed) { dimmed = _already_opened_msg (win, &n_messages); if (dimmed) { @@ -785,7 +818,7 @@ modest_ui_dimming_rules_on_view_attachments (ModestWindow *win, gpointer user_da /* Check dimmed rule */ if (!dimmed) - dimmed = _invalid_attach_selected (win, TRUE, TRUE, rule); + dimmed = _invalid_attach_selected (win, TRUE, TRUE, FALSE, rule); if (!dimmed) { dimmed = _purged_attach_selected (win, FALSE, NULL); @@ -809,7 +842,7 @@ modest_ui_dimming_rules_on_save_attachments (ModestWindow *win, gpointer user_da /* Check dimmed rule */ if (!dimmed) - dimmed = _invalid_attach_selected (win, FALSE, FALSE, rule); + dimmed = _invalid_attach_selected (win, FALSE, FALSE, FALSE, rule); if (!dimmed) { dimmed = _purged_attach_selected (win, FALSE, NULL); @@ -838,7 +871,7 @@ modest_ui_dimming_rules_on_remove_attachments (ModestWindow *win, gpointer user_ /* Check in view window if there's any attachment selected */ if (!dimmed && MODEST_IS_MSG_VIEW_WINDOW (win)) { - dimmed = _invalid_attach_selected (win, FALSE, FALSE, NULL); + dimmed = _invalid_attach_selected (win, FALSE, FALSE, TRUE, NULL); if (dimmed) modest_dimming_rule_set_notification (rule, _("FIXME:no attachment selected")); } @@ -850,7 +883,7 @@ modest_ui_dimming_rules_on_remove_attachments (ModestWindow *win, gpointer user_ /* Check if the selected message in main window has attachments */ if (!dimmed && MODEST_IS_MAIN_WINDOW (win)) { - dimmed = _selected_msg_marked_as (win, TNY_HEADER_FLAG_ATTACHMENTS, TRUE, FALSE); + dimmed = _selected_msg_marked_as (MODEST_MAIN_WINDOW(win), TNY_HEADER_FLAG_ATTACHMENTS, TRUE, FALSE); if (dimmed) modest_dimming_rule_set_notification (rule, _("mail_ib_unable_to_purge_attachments")); } @@ -1091,8 +1124,28 @@ modest_ui_dimming_rules_on_add_to_contacts (ModestWindow *win, gpointer user_dat /* *********************** static utility functions ******************** */ +/* Returns whether the selected message is marked as deleted. */ +static gboolean +_message_is_marked_as_deleted (ModestMsgViewWindow *win) +{ + g_return_val_if_fail (win, FALSE); + g_return_val_if_fail (MODEST_IS_MSG_VIEW_WINDOW(win), FALSE); + + TnyHeader* header = modest_msg_view_window_get_header (win); + if (!header) + return FALSE; + + return (tny_header_get_flags (header) & TNY_HEADER_FLAG_DELETED); +} + + + +/* Returns whether the selected message is marked as deleted. + * @param win The main window, or NULL if you want this function + * to discover the main window itself, which is marginally less + * efficient. */ static gboolean -_marked_as_deleted (ModestWindow *win) +_selected_message_is_marked_as_deleted (ModestMainWindow *win) { gboolean result = FALSE; TnyHeaderFlags flags; @@ -1485,6 +1538,7 @@ static gboolean _invalid_attach_selected (ModestWindow *win, gboolean unique, gboolean for_view, + gboolean for_remove, ModestDimmingRule *rule) { GList *attachments, *node; @@ -1497,7 +1551,7 @@ _invalid_attach_selected (ModestWindow *win, if (MODEST_IS_MAIN_WINDOW (win)) { flags = TNY_HEADER_FLAG_ATTACHMENTS; if (!result) - result = _selected_msg_marked_as (win, flags, TRUE, FALSE); + result = _selected_msg_marked_as (MODEST_MAIN_WINDOW (win), flags, TRUE, FALSE); } else if (MODEST_IS_MSG_VIEW_WINDOW (win)) { @@ -1519,14 +1573,14 @@ _invalid_attach_selected (ModestWindow *win, for (node = attachments; node != NULL && !result; node = g_list_next (node)) { TnyMimePart *mime_part = TNY_MIME_PART (node->data); TnyList *nested_list = tny_simple_list_new (); - if (TNY_IS_MSG (mime_part)) { + if (!for_remove && TNY_IS_MSG (mime_part)) { selected_messages = TRUE; result = TRUE; } tny_mime_part_get_parts (mime_part, nested_list); - if (tny_list_get_length (nested_list) > 0) { - nested_attachments = TRUE; - result = TRUE; + if (!for_remove && tny_list_get_length (nested_list) > 0) { + nested_attachments = TRUE; + result = TRUE; } g_object_unref (nested_list); } @@ -1694,13 +1748,17 @@ _already_opened_msg (ModestWindow *win, return found; } +/* Returns whether the selected message has these flags. + * @win: The main window, or NULL if you want this function + * to discover the main window itself. + */ static gboolean -_selected_msg_marked_as (ModestWindow *win, +_selected_msg_marked_as (ModestMainWindow *win, TnyHeaderFlags mask, gboolean opposite, gboolean all) { - ModestWindow *main_window = NULL; + ModestMainWindow *main_window = NULL; GtkWidget *header_view = NULL; TnyList *selected_headers = NULL; TnyIterator *iter = NULL; @@ -1708,11 +1766,14 @@ _selected_msg_marked_as (ModestWindow *win, TnyHeaderFlags flags = 0; gboolean result = TRUE; - if (MODEST_IS_MAIN_WINDOW (win)) + /* The caller can supply the main window if it knows it, + * to save time, or we can get it here: */ + if (win && MODEST_IS_MAIN_WINDOW (win)) main_window = win; - else - main_window = - modest_window_mgr_get_main_window (modest_runtime_get_window_mgr ()); + else { + main_window = MODEST_MAIN_WINDOW ( + modest_window_mgr_get_main_window (modest_runtime_get_window_mgr ())); + } /* TODO: Javi, what about if the main window does not exist?. Adding some code to avoid CRITICALs */